)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"675ecbea5680097ee99af1fbbdb60d753e3c21af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are cases where the server details don\u0027t have an instance_id"},{"line_number":10,"context_line":"set but we need to check for that so we can avoid a KeyError. We"},{"line_number":11,"context_line":"also log this case as a warning like the InstanceNotFound in the same"},{"line_number":12,"context_line":"method. Ideally we\u0027d log the share server ID for context but we don\u0027t"},{"line_number":13,"context_line":"have that available in this method which is given ShareServerBackendDetails"},{"line_number":14,"context_line":"key/values."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_47ced084","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":56},"updated":"2016-02-09 17:41:39.000000000","message":"I\u0027ll leave it to the core reviewer team to let me know if you\u0027d like me to pass the share server ID in to the method so we can use it for logging when instance_id is not in the backend details dict provided.","commit_id":"21baff116afd6eec05119946351026eb5354f241"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"245f98b916acb94c9142883e525722bdf7d0e853","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def ensure_service_instance(self, context, server):"},{"line_number":351,"context_line":"        \"\"\"Ensures that server exists and active.\"\"\""},{"line_number":352,"context_line":"        if \u0027instance_id\u0027 not in server:"},{"line_number":353,"context_line":"            return False"},{"line_number":354,"context_line":"        try:"},{"line_number":355,"context_line":"            inst \u003d self.compute_api.server_get(self.admin_context,"},{"line_number":356,"context_line":"                                               server[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_9053eb38","line":353,"range":{"start_line":353,"start_character":19,"end_line":353,"end_character":24},"updated":"2016-02-06 07:49:46.000000000","message":"Wouldn\u0027t it be good to log this like the not found case? Not sure if this is warning, info, or debug. Is this a common problem?","commit_id":"751bd2d61481c6694ce2f920b037a23158deaa58"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"94ef350366dd1c203dcec6a1f3f2239345ac713b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def ensure_service_instance(self, context, server):"},{"line_number":351,"context_line":"        \"\"\"Ensures that server exists and active.\"\"\""},{"line_number":352,"context_line":"        if \u0027instance_id\u0027 not in server:"},{"line_number":353,"context_line":"            return False"},{"line_number":354,"context_line":"        try:"},{"line_number":355,"context_line":"            inst \u003d self.compute_api.server_get(self.admin_context,"},{"line_number":356,"context_line":"                                               server[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a980998c","line":353,"range":{"start_line":353,"start_character":19,"end_line":353,"end_character":24},"in_reply_to":"5a5ae5dd_3a968e3f","updated":"2016-02-09 11:26:25.000000000","message":"Having a log line here would be fair. Warning level?","commit_id":"751bd2d61481c6694ce2f920b037a23158deaa58"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"412928876547a8c8a3f4d3a932861901b47826c5","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def ensure_service_instance(self, context, server):"},{"line_number":351,"context_line":"        \"\"\"Ensures that server exists and active.\"\"\""},{"line_number":352,"context_line":"        if \u0027instance_id\u0027 not in server:"},{"line_number":353,"context_line":"            return False"},{"line_number":354,"context_line":"        try:"},{"line_number":355,"context_line":"            inst \u003d self.compute_api.server_get(self.admin_context,"},{"line_number":356,"context_line":"                                               server[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_3a968e3f","line":353,"range":{"start_line":353,"start_character":19,"end_line":353,"end_character":24},"in_reply_to":"5a5ae5dd_9053eb38","updated":"2016-02-06 15:24:49.000000000","message":"I could log that, sure.\n\nThe details are in the bug, but here is an example:\n\nhttp://logs.openstack.org/95/273495/3/check/gate-manila-tempest-dsvm-neutron/5143008/logs/screen-m-shr.txt.gz?level\u003dTRACE#_2016-02-03_20_33_50_321\n\nlogstash tells me this shows up 329 times since 2/1 (I\u0027m not sure what changed since 2/1 to start causing this).","commit_id":"751bd2d61481c6694ce2f920b037a23158deaa58"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5fdb0ccbeab8b83c6a75a738edcddcf41b64e9f","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def ensure_service_instance(self, context, server):"},{"line_number":351,"context_line":"        \"\"\"Ensures that server exists and active.\"\"\""},{"line_number":352,"context_line":"        if \u0027instance_id\u0027 not in server:"},{"line_number":353,"context_line":"            return False"},{"line_number":354,"context_line":"        try:"},{"line_number":355,"context_line":"            inst \u003d self.compute_api.server_get(self.admin_context,"},{"line_number":356,"context_line":"                                               server[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_08119e5d","line":353,"range":{"start_line":353,"start_character":19,"end_line":353,"end_character":24},"in_reply_to":"5a5ae5dd_a980998c","updated":"2016-02-09 14:34:35.000000000","message":"I can add a log entry. Since it\u0027s using warning for the InstanceNotFound case it seems justified in using warning for this also.","commit_id":"751bd2d61481c6694ce2f920b037a23158deaa58"}]}
