)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6a99272c0ceb41046b87d6f8dce7c61ee190ffa2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Three ways to set Thin/Thick Type in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.If \"capabilities:thin_provision\u003d\u003cis\u003e True or False\" in the share_type,"},{"line_number":10,"context_line":"  it will be used(thin share will be created if \"capabilities:"},{"line_number":11,"context_line":"  thin_provision\u003d\u003cis\u003e True\", thick share will be created if \"capabilities:"},{"line_number":12,"context_line":"  thin_provision\u003d\u003cis\u003e False\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a54edaf_976dd4ce","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":53},"updated":"2016-02-13 06:07:47.000000000","message":"The quoting makes this confusing. How about just:  If thin_provisioning is set in the share type extra-specs...","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Three ways to set Thin/Thick Type in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.If \"capabilities:thin_provision\u003d\u003cis\u003e True or False\" in the share_type,"},{"line_number":10,"context_line":"  it will be used(thin share will be created if \"capabilities:"},{"line_number":11,"context_line":"  thin_provision\u003d\u003cis\u003e True\", thick share will be created if \"capabilities:"},{"line_number":12,"context_line":"  thin_provision\u003d\u003cis\u003e False\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_29ecbfc6","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":53},"in_reply_to":"1a54edaf_976dd4ce","updated":"2016-02-16 08:26:21.000000000","message":"Done","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6a99272c0ceb41046b87d6f8dce7c61ee190ffa2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.If \"capabilities:thin_provision\u003d\u003cis\u003e True or False\" in the share_type,"},{"line_number":10,"context_line":"  it will be used(thin share will be created if \"capabilities:"},{"line_number":11,"context_line":"  thin_provision\u003d\u003cis\u003e True\", thick share will be created if \"capabilities:"},{"line_number":12,"context_line":"  thin_provision\u003d\u003cis\u003e False\")"},{"line_number":13,"context_line":"2.If \"thin_provision\" is not present in the share_type, the config value"},{"line_number":14,"context_line":"  of \"AllocType\" in the config file will be used(thin share will be created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a54edaf_b77250ac","line":11,"updated":"2016-02-13 06:07:47.000000000","message":"s/thin_provision/thin_provisioning/","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.If \"capabilities:thin_provision\u003d\u003cis\u003e True or False\" in the share_type,"},{"line_number":10,"context_line":"  it will be used(thin share will be created if \"capabilities:"},{"line_number":11,"context_line":"  thin_provision\u003d\u003cis\u003e True\", thick share will be created if \"capabilities:"},{"line_number":12,"context_line":"  thin_provision\u003d\u003cis\u003e False\")"},{"line_number":13,"context_line":"2.If \"thin_provision\" is not present in the share_type, the config value"},{"line_number":14,"context_line":"  of \"AllocType\" in the config file will be used(thin share will be created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_a91d6fbf","line":11,"in_reply_to":"1a54edaf_b77250ac","updated":"2016-02-16 08:26:21.000000000","message":"Done","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6a99272c0ceb41046b87d6f8dce7c61ee190ffa2","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        fileparam \u003d {"},{"line_number":359,"context_line":"            \"NAME\": name.replace(\"-\", \"_\"),"},{"line_number":360,"context_line":"            \"DESCRIPTION\": \"\","},{"line_number":361,"context_line":"            \"ALLOCTYPE\": extra_specs[\u0027LUNType\u0027],"},{"line_number":362,"context_line":"            \"CAPACITY\": size,"},{"line_number":363,"context_line":"            \"PARENTID\": poolinfo[\u0027ID\u0027],"},{"line_number":364,"context_line":"            \"INITIALALLOCCAPACITY\": units.Ki * 20,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_ac168753","line":361,"range":{"start_line":361,"start_character":45,"end_line":361,"end_character":48},"updated":"2016-02-13 06:07:47.000000000","message":"You used to check for \u0027LUNType\u0027 in extra_specs. Is this safe w/o that check? Do you need to use get() instead?","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        fileparam \u003d {"},{"line_number":359,"context_line":"            \"NAME\": name.replace(\"-\", \"_\"),"},{"line_number":360,"context_line":"            \"DESCRIPTION\": \"\","},{"line_number":361,"context_line":"            \"ALLOCTYPE\": extra_specs[\u0027LUNType\u0027],"},{"line_number":362,"context_line":"            \"CAPACITY\": size,"},{"line_number":363,"context_line":"            \"PARENTID\": poolinfo[\u0027ID\u0027],"},{"line_number":364,"context_line":"            \"INITIALALLOCCAPACITY\": units.Ki * 20,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_44e76ae4","line":361,"range":{"start_line":361,"start_character":45,"end_line":361,"end_character":48},"in_reply_to":"1a54edaf_ac168753","updated":"2016-02-16 08:26:21.000000000","message":"smartx.py will make extra_specs always have \u0027LUNType\u0027(see get_smartprovisioning_opts in smartx.py)","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"}],"manila/share/drivers/huawei/v3/smartx.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c7e5e1e6e798d443e692d59b77f6b053af14ff1c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    err_msg \u003d (_("},{"line_number":142,"context_line":"                        \u0027Config file is wrong. AllocType type must be set to\u0027"},{"line_number":143,"context_line":"                        \u0027 \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":144,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":145,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6bbdba01","line":142,"range":{"start_line":142,"start_character":25,"end_line":142,"end_character":36},"updated":"2016-02-09 10:17:41.000000000","message":"That\u0027s might a bit confusing. So which config file are you referring to? I guess not manila.conf right?","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    err_msg \u003d (_("},{"line_number":142,"context_line":"                        \u0027Config file is wrong. AllocType type must be set to\u0027"},{"line_number":143,"context_line":"                        \u0027 \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":144,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":145,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_84d172fe","line":142,"range":{"start_line":142,"start_character":25,"end_line":142,"end_character":36},"in_reply_to":"1a54edaf_97563405","updated":"2016-02-16 08:26:21.000000000","message":"Done","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6a99272c0ceb41046b87d6f8dce7c61ee190ffa2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    err_msg \u003d (_("},{"line_number":142,"context_line":"                        \u0027Config file is wrong. AllocType type must be set to\u0027"},{"line_number":143,"context_line":"                        \u0027 \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":144,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":145,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_97563405","line":142,"range":{"start_line":142,"start_character":25,"end_line":142,"end_character":36},"in_reply_to":"5a5ae5dd_6bbdba01","updated":"2016-02-13 06:07:47.000000000","message":"+1","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    err_msg \u003d (_("},{"line_number":142,"context_line":"                        \u0027Config file is wrong. AllocType type must be set to\u0027"},{"line_number":143,"context_line":"                        \u0027 \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":144,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":145,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c4db7a1a","line":142,"range":{"start_line":142,"start_character":25,"end_line":142,"end_character":36},"in_reply_to":"5a5ae5dd_6bbdba01","updated":"2016-02-16 08:26:21.000000000","message":"Done","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6a99272c0ceb41046b87d6f8dce7c61ee190ffa2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            else:"},{"line_number":147,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":148,"context_line":"        else:"},{"line_number":149,"context_line":"            if strutils.bool_from_string(thin_provision):"},{"line_number":150,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THIN_FLAG"},{"line_number":151,"context_line":"            else:"},{"line_number":152,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_d74cac78","line":149,"range":{"start_line":149,"start_character":24,"end_line":149,"end_character":40},"updated":"2016-02-13 06:07:47.000000000","message":"You can use this with strict checking to make sure it is valid, but then you\u0027d want to handle the exception.","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3908e000145be1ae3453a49237fb3626114ad2f4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            else:"},{"line_number":147,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":148,"context_line":"        else:"},{"line_number":149,"context_line":"            if strutils.bool_from_string(thin_provision):"},{"line_number":150,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THIN_FLAG"},{"line_number":151,"context_line":"            else:"},{"line_number":152,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_64cb8e73","line":149,"range":{"start_line":149,"start_character":24,"end_line":149,"end_character":40},"in_reply_to":"1a54edaf_d74cac78","updated":"2016-02-16 08:26:21.000000000","message":"\u0027thin_provision\u0027 is get form the share type extra-specs, it has been used to choose the pool in the scheduler. I think there is no need to check it\u0027s validity","commit_id":"519d9168df97361bd2479044fb8febf6fcc623d2"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"be4f76f855662051927d8d3d941aa2f09e4fde84","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1328,"context_line":"                                            self.share_server)"},{"line_number":1329,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_uuid\", location)"},{"line_number":1330,"context_line":"        self.assertEqual(self.driver.plugin.helper.alloc_type,"},{"line_number":1331,"context_line":"                         constants.ALLOC_TYPE_THIN_FLAG)"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    def test_create_share_with_extra_thick(self):"},{"line_number":1334,"context_line":"        share_type \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_dc9a5261","line":1331,"range":{"start_line":1330,"start_character":0,"end_line":1331,"end_character":56},"updated":"2016-02-18 19:38:43.000000000","message":"assertEqual(expected, actual): Replace to self.assertEqual(constants.ALLOC_TYPE_THIN_FLAG, self.driver.plugin.helper.alloc_type)","commit_id":"4433dc4ef5df20a4ef3e3eba33f5dc4c35337b6c"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"52f57a6d20741639aa121773153ba8119d6de94f","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1328,"context_line":"                                            self.share_server)"},{"line_number":1329,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_uuid\", location)"},{"line_number":1330,"context_line":"        self.assertEqual(self.driver.plugin.helper.alloc_type,"},{"line_number":1331,"context_line":"                         constants.ALLOC_TYPE_THIN_FLAG)"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    def test_create_share_with_extra_thick(self):"},{"line_number":1334,"context_line":"        share_type \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9f669d27","line":1331,"range":{"start_line":1330,"start_character":0,"end_line":1331,"end_character":56},"in_reply_to":"dae33548_dc9a5261","updated":"2016-02-22 02:36:42.000000000","message":"Done","commit_id":"4433dc4ef5df20a4ef3e3eba33f5dc4c35337b6c"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"be4f76f855662051927d8d3d941aa2f09e4fde84","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1344,"context_line":"                                            self.share_server)"},{"line_number":1345,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_uuid\", location)"},{"line_number":1346,"context_line":"        self.assertEqual(self.driver.plugin.helper.alloc_type,"},{"line_number":1347,"context_line":"                         constants.ALLOC_TYPE_THICK_FLAG)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def test_shrink_share_success(self):"},{"line_number":1350,"context_line":"        self.driver.plugin.helper.shrink_share_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_fc80f6f8","line":1347,"range":{"start_line":1346,"start_character":0,"end_line":1347,"end_character":57},"updated":"2016-02-18 19:38:43.000000000","message":"assertEqual(expected, actual): Replace to self.assertEqual(constants.ALLOC_TYPE_THICK_FLAG, self.driver.plugin.helper.alloc_type)","commit_id":"4433dc4ef5df20a4ef3e3eba33f5dc4c35337b6c"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"52f57a6d20741639aa121773153ba8119d6de94f","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1344,"context_line":"                                            self.share_server)"},{"line_number":1345,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_uuid\", location)"},{"line_number":1346,"context_line":"        self.assertEqual(self.driver.plugin.helper.alloc_type,"},{"line_number":1347,"context_line":"                         constants.ALLOC_TYPE_THICK_FLAG)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def test_shrink_share_success(self):"},{"line_number":1350,"context_line":"        self.driver.plugin.helper.shrink_share_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1f73ade8","line":1347,"range":{"start_line":1346,"start_character":0,"end_line":1347,"end_character":57},"in_reply_to":"dae33548_fc80f6f8","updated":"2016-02-22 02:36:42.000000000","message":"Done","commit_id":"4433dc4ef5df20a4ef3e3eba33f5dc4c35337b6c"}]}