)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ea8a0c9bad966061d5622f435c99b883c5630de3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  arbitrarily named, are ignored by \"gluster volume get\" and"},{"line_number":14,"context_line":"  are listed in \"gluster volume info\" output"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So far we used \"gluster volue info\" universally, but that,"},{"line_number":17,"context_line":"apart from being cumbersome for regular options, is also"},{"line_number":18,"context_line":"incorrect, as it can\u0027t distinguish an unset option name from"},{"line_number":19,"context_line":"an undefined one (querying the former should be treated OK,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_d1b5c731","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":29},"updated":"2016-02-16 09:40:32.000000000","message":"volume","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"a8c9a0fc17b5f795dea3ef9a260c1fa47c0bc2cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  arbitrarily named, are ignored by \"gluster volume get\" and"},{"line_number":14,"context_line":"  are listed in \"gluster volume info\" output"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So far we used \"gluster volue info\" universally, but that,"},{"line_number":17,"context_line":"apart from being cumbersome for regular options, is also"},{"line_number":18,"context_line":"incorrect, as it can\u0027t distinguish an unset option name from"},{"line_number":19,"context_line":"an undefined one (querying the former should be treated OK,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_e37d7c1d","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":29},"in_reply_to":"dae33548_d1b5c731","updated":"2016-02-16 21:28:49.000000000","message":"Done","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ea8a0c9bad966061d5622f435c99b883c5630de3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"apart from being cumbersome for regular options, is also"},{"line_number":18,"context_line":"incorrect, as it can\u0027t distinguish an unset option name from"},{"line_number":19,"context_line":"an undefined one (querying the former should be treated OK,"},{"line_number":20,"context_line":"querying the second should be treated as  error)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- implement querying of regular options with \"gluster volume"},{"line_number":23,"context_line":"  get\" (accepting empty response)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_71f4bbf1","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":42},"updated":"2016-02-16 09:40:32.000000000","message":"blank","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"a8c9a0fc17b5f795dea3ef9a260c1fa47c0bc2cd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"apart from being cumbersome for regular options, is also"},{"line_number":18,"context_line":"incorrect, as it can\u0027t distinguish an unset option name from"},{"line_number":19,"context_line":"an undefined one (querying the former should be treated OK,"},{"line_number":20,"context_line":"querying the second should be treated as  error)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- implement querying of regular options with \"gluster volume"},{"line_number":23,"context_line":"  get\" (accepting empty response)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_c378382e","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":42},"in_reply_to":"dae33548_71f4bbf1","updated":"2016-02-16 21:28:49.000000000","message":"Done","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"}],"manila/share/drivers/glusterfs/common.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ea8a0c9bad966061d5622f435c99b883c5630de3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            value \u003d self._get_vol_user_option(useropt)"},{"line_number":263,"context_line":"        if not boolean or value is None:"},{"line_number":264,"context_line":"            return value"},{"line_number":265,"context_line":"        if value.lower() in (\u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027true\u0027, \u0027enable\u0027):"},{"line_number":266,"context_line":"            return True"},{"line_number":267,"context_line":"        if value.lower() in (\u00270\u0027, \u0027off\u0027, \u0027no\u0027, \u0027false\u0027, \u0027disable\u0027):"},{"line_number":268,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_cc308aeb","line":265,"updated":"2016-02-16 09:40:32.000000000","message":"I would prefer to the exsting method in oslo config:\n  import oslo_config import types\n  types.Boolean()(value)","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"88abd05dee00b84f0f8e934c50b547a29d01fc48","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            value \u003d self._get_vol_user_option(useropt)"},{"line_number":263,"context_line":"        if not boolean or value is None:"},{"line_number":264,"context_line":"            return value"},{"line_number":265,"context_line":"        if value.lower() in (\u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027true\u0027, \u0027enable\u0027):"},{"line_number":266,"context_line":"            return True"},{"line_number":267,"context_line":"        if value.lower() in (\u00270\u0027, \u0027off\u0027, \u0027no\u0027, \u0027false\u0027, \u0027disable\u0027):"},{"line_number":268,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_8f506c60","line":265,"in_reply_to":"dae33548_468c3635","updated":"2016-02-25 02:28:59.000000000","message":"Fair enough, Csaba.  But I had the same thought as Marc, and you\u0027ve used this in at least a couple places, so in a future change I encourage you to move this tuple to a constant, such as GLUSTER_TRUE_VALUES or similar, which would make this more self-documenting.","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"a8c9a0fc17b5f795dea3ef9a260c1fa47c0bc2cd","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            value \u003d self._get_vol_user_option(useropt)"},{"line_number":263,"context_line":"        if not boolean or value is None:"},{"line_number":264,"context_line":"            return value"},{"line_number":265,"context_line":"        if value.lower() in (\u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027true\u0027, \u0027enable\u0027):"},{"line_number":266,"context_line":"            return True"},{"line_number":267,"context_line":"        if value.lower() in (\u00270\u0027, \u0027off\u0027, \u0027no\u0027, \u0027false\u0027, \u0027disable\u0027):"},{"line_number":268,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_468c3635","line":265,"in_reply_to":"dae33548_cc308aeb","updated":"2016-02-16 21:28:49.000000000","message":"That would be no help of us. We are not to establish here our private preferences of coercing various values to Boolean, rather to decode string values coming from GlusterFS according to its conventions regarding interpreting strings as Boolean values.\n\nSee https://github.com/gluster/glusterfs/blob/v3.7.8/libglusterfs/src/common-utils.c#L1680-L1708\n\nI\u0027ll add a pointer to that function as comment.","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ea8a0c9bad966061d5622f435c99b883c5630de3","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            return value"},{"line_number":265,"context_line":"        if value.lower() in (\u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027true\u0027, \u0027enable\u0027):"},{"line_number":266,"context_line":"            return True"},{"line_number":267,"context_line":"        if value.lower() in (\u00270\u0027, \u0027off\u0027, \u0027no\u0027, \u0027false\u0027, \u0027disable\u0027):"},{"line_number":268,"context_line":"            return False"},{"line_number":269,"context_line":"        raise exception.GlusterfsException(_("},{"line_number":270,"context_line":"            \"GlusterFS volume option on volume %(volume)s: \""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_0c51d20e","line":267,"updated":"2016-02-16 09:40:32.000000000","message":"same here","commit_id":"d70a3f5823d281c6e79d17d20bc246d2c543d87f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"407257e45fa5cda7fc6c2bbfe5dea2b22b9329c2","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @_check_volume_presence"},{"line_number":244,"context_line":"    def _get_vol_user_option(self, useropt):"},{"line_number":245,"context_line":"        \"\"\"Get the value of an user option set on a GlusterFS volume.\"\"\""},{"line_number":246,"context_line":"        option \u003d \u0027.\u0027.join((\u0027user\u0027, useropt))"},{"line_number":247,"context_line":"        return self._get_vol_option_via_info(option)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_ba95ae41","line":245,"range":{"start_line":245,"start_character":28,"end_line":245,"end_character":30},"updated":"2016-02-26 00:55:44.000000000","message":"s/an/a/","commit_id":"2fc6edc273ed493de9b642be8f96bbf74ebfafb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ce8186f297e788f52560ef0ce8c2b45604cc4b72","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @_check_volume_presence"},{"line_number":244,"context_line":"    def _get_vol_user_option(self, useropt):"},{"line_number":245,"context_line":"        \"\"\"Get the value of an user option set on a GlusterFS volume.\"\"\""},{"line_number":246,"context_line":"        option \u003d \u0027.\u0027.join((\u0027user\u0027, useropt))"},{"line_number":247,"context_line":"        return self._get_vol_option_via_info(option)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_ba6dae34","line":245,"range":{"start_line":245,"start_character":28,"end_line":245,"end_character":30},"in_reply_to":"9aed3d3a_ba95ae41","updated":"2016-02-26 01:01:32.000000000","message":"We will have someone come along and fix this :P","commit_id":"2fc6edc273ed493de9b642be8f96bbf74ebfafb8"}]}
