)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a44b20fa0ebf360ebb645e68e08cbe8fc4dfd050","unresolved":false,"context_lines":[{"line_number":12,"context_line":"backend to specify what other backends it can replicate"},{"line_number":13,"context_line":"to."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Introduce a new scheduler filter that uses a backend"},{"line_number":16,"context_line":"reported \"capability\" called \u0027replication_partners\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Drivers supporting replication should report this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_de18fb86","line":15,"updated":"2016-02-10 23:16:41.000000000","message":"s/Introduce/This patch introduces","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3eaa3e7a3fdb12df6a16c9422d812686ed884f25","unresolved":false,"context_lines":[{"line_number":12,"context_line":"backend to specify what other backends it can replicate"},{"line_number":13,"context_line":"to."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Introduce a new scheduler filter that uses a backend"},{"line_number":16,"context_line":"reported \"capability\" called \u0027replication_partners\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Drivers supporting replication should report this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_68b5862f","line":15,"in_reply_to":"3a57f1b5_de18fb86","updated":"2016-02-11 03:02:09.000000000","message":"Done","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a44b20fa0ebf360ebb645e68e08cbe8fc4dfd050","unresolved":false,"context_lines":[{"line_number":27,"context_line":"stanza names are unique across a deployment."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements bp: manila-dr-scheduler-enhancements"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I194054a9a1071c2d577a588e3299ae81490cd0f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_c1233ea6","line":30,"updated":"2016-02-10 23:16:41.000000000","message":"This patch probably needs the DocImpact flag as we\u0027re adding some new functionality.","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3eaa3e7a3fdb12df6a16c9422d812686ed884f25","unresolved":false,"context_lines":[{"line_number":27,"context_line":"stanza names are unique across a deployment."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements bp: manila-dr-scheduler-enhancements"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I194054a9a1071c2d577a588e3299ae81490cd0f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_0883b257","line":30,"in_reply_to":"3a57f1b5_c1233ea6","updated":"2016-02-11 03:02:09.000000000","message":"Done","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"746ec57e7440b202c59f55f7a99f0ff88c7294b5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"populate this option within the driver, a list of backend"},{"line_number":20,"context_line":"stanza names must be expected by the Manila scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Introduce a new scheduler filter that uses a backend"},{"line_number":23,"context_line":"reported \"capability\" called \u0027replication_partners\u0027."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Note: For this to work as desired, the scheduler must"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_6640e734","line":22,"updated":"2016-02-12 20:52:38.000000000","message":"s/Introduce/This patch introduces","commit_id":"8d372c118d8aef0cdc13094dab3ae44b0db5f265"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"75df368cc7801b7830a922f47b5479a35b89d82a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"populate this option within the driver, a list of backend"},{"line_number":20,"context_line":"stanza names must be expected by the Manila scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Introduce a new scheduler filter that uses a backend"},{"line_number":23,"context_line":"reported \"capability\" called \u0027replication_partners\u0027."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Note: For this to work as desired, the scheduler must"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_c68bdb1d","line":22,"in_reply_to":"3a57f1b5_6640e734","updated":"2016-02-12 20:56:17.000000000","message":"I don\u0027t mind either way, but Valeriy once told me what\u0027s standard practice for good commit messages:\n\n\nAnd  then i read up:\nhttp://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?id\u003dHEAD#n112 \n\nhttp://stackoverflow.com/questions/3580013/should-i-use-past-or-present-tense-in-git-commit-messages\n\nAnd i started mimicking this ever since.. i might still be terrible at it though","commit_id":"8d372c118d8aef0cdc13094dab3ae44b0db5f265"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7172a343d4a8fb0ebd2dca9384cecec0588ecaf4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"driver call."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"They could choose to populate this information through a"},{"line_number":18,"context_line":"ListOpt configuration option. Regardless of how they"},{"line_number":19,"context_line":"populate this option within the driver, a list of backend"},{"line_number":20,"context_line":"stanza names must be expected by the Manila scheduler."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bae84128_3b05d4bb","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":28},"updated":"2016-02-22 11:17:09.000000000","message":"Where is this option? it should be common option defined for \"base driver\" and available in each driver\u0027s own \"self.configuration\". And it should be added exactly in this commit.","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8723e8ff68ae86f6da7764b92d7963b76c36297e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"driver call."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"They could choose to populate this information through a"},{"line_number":18,"context_line":"ListOpt configuration option. Regardless of how they"},{"line_number":19,"context_line":"populate this option within the driver, a list of backend"},{"line_number":20,"context_line":"stanza names must be expected by the Manila scheduler."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bae84128_aa121355","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":28},"in_reply_to":"bae84128_3b05d4bb","updated":"2016-02-22 21:48:51.000000000","message":"I don\u0027t know if drivers would want to specify this as a configuration option. In the NetApp driver implementation, ameade first experimented with a config option called \u0027netapp_replication_partners\u0027 and then, now, decided to implement an automatic way of reading the possible replication partners from the backends themselves. So i want to leave the choice to driver maintainers.. they may not need an option if their workflows are similar.","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8723e8ff68ae86f6da7764b92d7963b76c36297e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"They could choose to populate this information through a"},{"line_number":18,"context_line":"ListOpt configuration option. Regardless of how they"},{"line_number":19,"context_line":"populate this option within the driver, a list of backend"},{"line_number":20,"context_line":"stanza names must be expected by the Manila scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Introduce a new scheduler filter that uses a backend"},{"line_number":23,"context_line":"reported \"capability\" called \u0027replication_partners\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bae84128_ca3cb7ca","line":20,"range":{"start_line":19,"start_character":50,"end_line":20,"end_character":12},"updated":"2016-02-22 21:48:51.000000000","message":"I will update this to \u0027share_backend_name\u0027s","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"}],"manila/scheduler/filters/share_replication.py":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a44b20fa0ebf360ebb645e68e08cbe8fc4dfd050","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareReplicationFilter(base_host.BaseHostFilter):"},{"line_number":27,"context_line":"    \"\"\"ShareReplicationFilter filters host based on replication support.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":30,"context_line":"        \"\"\"Return True if host supports replication with desired backend."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_0178768e","line":27,"range":{"start_line":27,"start_character":38,"end_line":27,"end_character":42},"updated":"2016-02-10 23:16:41.000000000","message":"s/host/hosts","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3eaa3e7a3fdb12df6a16c9422d812686ed884f25","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareReplicationFilter(base_host.BaseHostFilter):"},{"line_number":27,"context_line":"    \"\"\"ShareReplicationFilter filters host based on replication support.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":30,"context_line":"        \"\"\"Return True if host supports replication with desired backend."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_e59c3f5f","line":27,"range":{"start_line":27,"start_character":38,"end_line":27,"end_character":42},"in_reply_to":"3a57f1b5_0178768e","updated":"2016-02-11 03:02:09.000000000","message":"Done","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a44b20fa0ebf360ebb645e68e08cbe8fc4dfd050","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if active_replica_backend not in host_replication_partners:"},{"line_number":61,"context_line":"            msg \u003d (\"Host %(host)s cannot host replicas of \""},{"line_number":62,"context_line":"                   \" %(active_replica_host)s.\")"},{"line_number":63,"context_line":"            LOG.debug(msg, {\"host\": host_state.host,"},{"line_number":64,"context_line":"                            \"active_replica_host\": active_replica_host})"},{"line_number":65,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_210492be","line":62,"updated":"2016-02-10 23:16:41.000000000","message":"I\u0027d add a little more here to say why the host cannot host replicas of the active replica host. Maybe something like:\n\n \"Host %(host)s cannot host replicas of %\n (active_replica_host)s because it\u0027s not in the list\n of replication partners\"","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3eaa3e7a3fdb12df6a16c9422d812686ed884f25","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if active_replica_backend not in host_replication_partners:"},{"line_number":61,"context_line":"            msg \u003d (\"Host %(host)s cannot host replicas of \""},{"line_number":62,"context_line":"                   \" %(active_replica_host)s.\")"},{"line_number":63,"context_line":"            LOG.debug(msg, {\"host\": host_state.host,"},{"line_number":64,"context_line":"                            \"active_replica_host\": active_replica_host})"},{"line_number":65,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_85a46ba6","line":62,"in_reply_to":"3a57f1b5_210492be","updated":"2016-02-11 03:02:09.000000000","message":"Done","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        share_instance_details \u003d filter_properties.get(\u0027request_spec\u0027, {}).get("},{"line_number":45,"context_line":"            \u0027share_instance_properties\u0027, {})"},{"line_number":46,"context_line":"        active_replica_host \u003d share_instance_details.get("},{"line_number":47,"context_line":"            \u0027active_replica_host\u0027, None)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # NOTE(gouthamr): If no active_replica_host is present, you\u0027re"},{"line_number":50,"context_line":"        # probably not creating a replica, then this host obviously passes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_61dd5f6e","line":47,"range":{"start_line":47,"start_character":35,"end_line":47,"end_character":39},"updated":"2016-02-12 05:54:28.000000000","message":"None is the default. Better to omit.","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        share_instance_details \u003d filter_properties.get(\u0027request_spec\u0027, {}).get("},{"line_number":45,"context_line":"            \u0027share_instance_properties\u0027, {})"},{"line_number":46,"context_line":"        active_replica_host \u003d share_instance_details.get("},{"line_number":47,"context_line":"            \u0027active_replica_host\u0027, None)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # NOTE(gouthamr): If no active_replica_host is present, you\u0027re"},{"line_number":50,"context_line":"        # probably not creating a replica, then this host obviously passes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_eb8fc572","line":47,"range":{"start_line":47,"start_character":35,"end_line":47,"end_character":39},"in_reply_to":"3a57f1b5_61dd5f6e","updated":"2016-02-12 20:41:17.000000000","message":"Done","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if active_replica_host is None:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":55,"context_line":"            active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_810dfbe9","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":46},"updated":"2016-02-12 05:54:28.000000000","message":"why is six.text_type needed here?","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if active_replica_host is None:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":55,"context_line":"            active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_8334f549","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":46},"in_reply_to":"3a57f1b5_810dfbe9","updated":"2016-02-12 20:41:17.000000000","message":"Since both these are differently encoded.. the one being reported from the scheduler is encoded as a unicode string.","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":55,"context_line":"            active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"},{"line_number":58,"context_line":"                                     host_state.replication_partners]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if active_replica_backend not in host_replication_partners:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_a1127707","line":57,"range":{"start_line":57,"start_character":37,"end_line":57,"end_character":49},"updated":"2016-02-12 05:54:28.000000000","message":"and here?","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if active_replica_backend not in host_replication_partners:"},{"line_number":61,"context_line":"            msg \u003d (\"Host %(host)s cannot host replicas of \""},{"line_number":62,"context_line":"                   \" %(active_replica_host)s because it is not in \""},{"line_number":63,"context_line":"                   \"its list of \u0027replication_partners\u0027.\")"},{"line_number":64,"context_line":"            LOG.debug(msg, {\"host\": host_state.host,"},{"line_number":65,"context_line":"                            \"active_replica_host\": active_replica_host})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_81dbbb4e","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":21},"updated":"2016-02-12 05:54:28.000000000","message":"there\u0027s an extra space","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if active_replica_backend not in host_replication_partners:"},{"line_number":61,"context_line":"            msg \u003d (\"Host %(host)s cannot host replicas of \""},{"line_number":62,"context_line":"                   \" %(active_replica_host)s because it is not in \""},{"line_number":63,"context_line":"                   \"its list of \u0027replication_partners\u0027.\")"},{"line_number":64,"context_line":"            LOG.debug(msg, {\"host\": host_state.host,"},{"line_number":65,"context_line":"                            \"active_replica_host\": active_replica_host})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_0b8b4169","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":21},"in_reply_to":"3a57f1b5_81dbbb4e","updated":"2016-02-12 20:41:17.000000000","message":"Done","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7172a343d4a8fb0ebd2dca9384cecec0588ecaf4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return True"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":60,"context_line":"                active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":61,"context_line":"        except IndexError:"},{"line_number":62,"context_line":"            msg \u003d _LE(\"The \u0027active\u0027 replica\u0027s host: %(host)s does not have a \""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_bb6f24c4","line":59,"range":{"start_line":59,"start_character":37,"end_line":59,"end_character":51},"updated":"2016-02-22 11:17:09.000000000","message":"Why do you need such str translation? If it is required indeed, then it should be done in this called func.","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"292d4c3c230811ab265fb62f5efb2eb5332e75dd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return True"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":60,"context_line":"                active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":61,"context_line":"        except IndexError:"},{"line_number":62,"context_line":"            msg \u003d _LE(\"The \u0027active\u0027 replica\u0027s host: %(host)s does not have a \""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_ed9a726d","line":59,"range":{"start_line":59,"start_character":37,"end_line":59,"end_character":51},"in_reply_to":"bae84128_6aa80bdc","updated":"2016-02-22 23:26:12.000000000","message":"extract_host returns a string or None.  I don\u0027t understand why you need the str translation, either.  You may need to check for None or an empty string, though.  You could do this:\n\n    try:\n        active_replica_backend \u003d share_utils.extract_host(\n            active_replica_host, level\u003d\u0027backend_name\u0027))\n        if not active_replica_backend:\n            raise exception.InvalidHost(reason\u003d\u003c...\u003e)\n    except (IndexError, exception.InvalidHost):\n        \u003clogging\u003e\n        return False","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8723e8ff68ae86f6da7764b92d7963b76c36297e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return True"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            active_replica_backend \u003d six.text_type(share_utils.extract_host("},{"line_number":60,"context_line":"                active_replica_host, level\u003d\u0027backend_name\u0027))"},{"line_number":61,"context_line":"        except IndexError:"},{"line_number":62,"context_line":"            msg \u003d _LE(\"The \u0027active\u0027 replica\u0027s host: %(host)s does not have a \""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_6aa80bdc","line":59,"range":{"start_line":59,"start_character":37,"end_line":59,"end_character":51},"in_reply_to":"bae84128_bb6f24c4","updated":"2016-02-22 21:48:51.000000000","message":"What\u0027s wrong with doing it here? The second conversion below occurs here..","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7172a343d4a8fb0ebd2dca9384cecec0588ecaf4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            msg \u003d _LE(\"The \u0027active\u0027 replica\u0027s host: %(host)s does not have a \""},{"line_number":63,"context_line":"                      \"backend name in it. Cannot schedule without a backend \""},{"line_number":64,"context_line":"                      \"name.\")"},{"line_number":65,"context_line":"            LOG.error(msg % {\"host\": active_replica_host})"},{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_5b9ff8b3","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":58},"updated":"2016-02-22 11:17:09.000000000","message":"Substitution dict should be second param:\n\n\"\"\"\n\nLOG.error(msg, {\"host\": active_replica_host})\n\n\"\"\"","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7172a343d4a8fb0ebd2dca9384cecec0588ecaf4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            LOG.error(msg % {\"host\": active_replica_host})"},{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"},{"line_number":69,"context_line":"                                     host_state.replication_partners]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if active_replica_backend not in host_replication_partners:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_dbab08d5","line":68,"range":{"start_line":68,"start_character":37,"end_line":68,"end_character":50},"updated":"2016-02-22 11:17:09.000000000","message":"Same here. Why do you need str translation?","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"292d4c3c230811ab265fb62f5efb2eb5332e75dd","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            LOG.error(msg % {\"host\": active_replica_host})"},{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"},{"line_number":69,"context_line":"                                     host_state.replication_partners]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if active_replica_backend not in host_replication_partners:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_0d751631","line":68,"range":{"start_line":68,"start_character":37,"end_line":68,"end_character":50},"in_reply_to":"bae84128_aa67b3e7","updated":"2016-02-22 23:26:12.000000000","message":"Seems like that should be transparent to the code, no?","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8723e8ff68ae86f6da7764b92d7963b76c36297e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            LOG.error(msg % {\"host\": active_replica_host})"},{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        host_replication_partners \u003d [six.text_type(i) for i in"},{"line_number":69,"context_line":"                                     host_state.replication_partners]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if active_replica_backend not in host_replication_partners:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_aa67b3e7","line":68,"range":{"start_line":68,"start_character":37,"end_line":68,"end_character":50},"in_reply_to":"bae84128_dbab08d5","updated":"2016-02-22 21:48:51.000000000","message":"because what\u0027s reported from the scheduler is a unicode string.","commit_id":"b25e243a1ef5b57fa292b51f6e47844aaef10bfb"}],"manila/share/utils.py":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a44b20fa0ebf360ebb645e68e08cbe8fc4dfd050","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    :param host: String for host, which could include host@backend#pool info"},{"line_number":34,"context_line":"    :param level: Indicate which level of information should be extracted"},{"line_number":35,"context_line":"                  from host string. Level can be \u0027host\u0027, \u0027backend\u0027, \u0027pool\u0027,"},{"line_number":36,"context_line":"                  or backend_name, default value is \u0027backend\u0027"},{"line_number":37,"context_line":"    :param use_default_pool_name: This flag specifies what to do"},{"line_number":38,"context_line":"                              if level \u003d\u003d \u0027pool\u0027 and there is no \u0027pool\u0027 info"},{"line_number":39,"context_line":"                              encoded in host string.  default_pool_name\u003dTrue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_81f46687","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":33},"updated":"2016-02-10 23:16:41.000000000","message":"s/backend_name/\u0027backend_name\u0027\n\nJust to match the options on the line above.","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3eaa3e7a3fdb12df6a16c9422d812686ed884f25","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    :param host: String for host, which could include host@backend#pool info"},{"line_number":34,"context_line":"    :param level: Indicate which level of information should be extracted"},{"line_number":35,"context_line":"                  from host string. Level can be \u0027host\u0027, \u0027backend\u0027, \u0027pool\u0027,"},{"line_number":36,"context_line":"                  or backend_name, default value is \u0027backend\u0027"},{"line_number":37,"context_line":"    :param use_default_pool_name: This flag specifies what to do"},{"line_number":38,"context_line":"                              if level \u003d\u003d \u0027pool\u0027 and there is no \u0027pool\u0027 info"},{"line_number":39,"context_line":"                              encoded in host string.  default_pool_name\u003dTrue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_85f9cb82","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":33},"in_reply_to":"3a57f1b5_81f46687","updated":"2016-02-11 03:02:09.000000000","message":"Done","commit_id":"f114e90fa931379ce547b5af8130444b5761230d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return hst.split(\u0027@\u0027)[0]"},{"line_number":65,"context_line":"    if level \u003d\u003d \u0027backend_name\u0027:"},{"line_number":66,"context_line":"        hst \u003d host.split(\u0027#\u0027)[0]"},{"line_number":67,"context_line":"        return hst.split(\u0027@\u0027)[1]"},{"line_number":68,"context_line":"    elif level \u003d\u003d \u0027backend\u0027:"},{"line_number":69,"context_line":"        return host.split(\u0027#\u0027)[0]"},{"line_number":70,"context_line":"    elif level \u003d\u003d \u0027pool\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_3c3d4cc4","line":67,"updated":"2016-02-12 05:54:28.000000000","message":"This would be an index error if host#pool is still possible. See later comment about tests.","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return hst.split(\u0027@\u0027)[0]"},{"line_number":65,"context_line":"    if level \u003d\u003d \u0027backend_name\u0027:"},{"line_number":66,"context_line":"        hst \u003d host.split(\u0027#\u0027)[0]"},{"line_number":67,"context_line":"        return hst.split(\u0027@\u0027)[1]"},{"line_number":68,"context_line":"    elif level \u003d\u003d \u0027backend\u0027:"},{"line_number":69,"context_line":"        return host.split(\u0027#\u0027)[0]"},{"line_number":70,"context_line":"    elif level \u003d\u003d \u0027pool\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_43711d0e","line":67,"in_reply_to":"3a57f1b5_3c3d4cc4","updated":"2016-02-12 20:41:17.000000000","message":"There shouldn\u0027t be an index error for a wellformed host string.. \n\nhost#pool is not possible currently.. a pool is always a subset of a backend.","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"}],"manila/tests/scheduler/filters/test_share_replication.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(ShareReplicationFilterTestCase, self).setUp()"},{"line_number":34,"context_line":"        self.filter \u003d share_replication.ShareReplicationFilter()"},{"line_number":35,"context_line":"        self.backends_supported \u003d []"},{"line_number":36,"context_line":"        for backend in (fakes.FAKE_HOST_STRING_1, fakes.FAKE_HOST_STRING_2):"},{"line_number":37,"context_line":"            self.backends_supported.append("},{"line_number":38,"context_line":"                share_utils.extract_host(backend, level\u003d\u0027backend_name\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _create_replica_request(active_replica_host\u003dNone, is_admin\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_2173e716","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":72},"updated":"2016-02-12 05:54:28.000000000","message":"extra credit if you use list comprehension -- but it\u0027s fine this way","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(ShareReplicationFilterTestCase, self).setUp()"},{"line_number":34,"context_line":"        self.filter \u003d share_replication.ShareReplicationFilter()"},{"line_number":35,"context_line":"        self.backends_supported \u003d []"},{"line_number":36,"context_line":"        for backend in (fakes.FAKE_HOST_STRING_1, fakes.FAKE_HOST_STRING_2):"},{"line_number":37,"context_line":"            self.backends_supported.append("},{"line_number":38,"context_line":"                share_utils.extract_host(backend, level\u003d\u0027backend_name\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _create_replica_request(active_replica_host\u003dNone, is_admin\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_0b67c1b7","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":72},"in_reply_to":"3a57f1b5_2173e716","updated":"2016-02-12 20:41:17.000000000","message":"was avoiding the multiline list declaration.. :)","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"}],"manila/tests/share/test_share_utils.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bdc2aec7429ae6f5f8e30f523381dd946b8ea5d6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual("},{"line_number":58,"context_line":"            \u0027Backend\u0027, share_utils.extract_host(host, \u0027backend_name\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_extract_host_missing_backend(self):"},{"line_number":61,"context_line":"        host \u003d \u0027Host#Pool\u0027"},{"line_number":62,"context_line":"        self.assertEqual("},{"line_number":63,"context_line":"            \u0027Host\u0027, share_utils.extract_host(host))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_fc1b3471","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":48},"updated":"2016-02-12 05:54:28.000000000","message":"These Host#Pool tests would break your backend_name split(\u0027@\u0027)[1] code. Is it still possible to do this? Maybe w/ a single default and no backend stanzas?","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11ed42a6f06793362812c030b56aef28b8e96dae","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual("},{"line_number":58,"context_line":"            \u0027Backend\u0027, share_utils.extract_host(host, \u0027backend_name\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_extract_host_missing_backend(self):"},{"line_number":61,"context_line":"        host \u003d \u0027Host#Pool\u0027"},{"line_number":62,"context_line":"        self.assertEqual("},{"line_number":63,"context_line":"            \u0027Host\u0027, share_utils.extract_host(host))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_83d075ca","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":48},"in_reply_to":"3a57f1b5_fc1b3471","updated":"2016-02-12 20:41:17.000000000","message":"These tests seem to be covering the extract_host method as a raw method; not considering the fact that manila won\u0027t have Host#Pool ...","commit_id":"f4d903ffb19015af043f5d2350ab68dae67dd690"}]}
