)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add multi-segment support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron ML2 mechanisms allows multiple network segments. A net-show call with"},{"line_number":10,"context_line":"a multi-segment setup won\u0027t return a single network-type or segmentation id."},{"line_number":11,"context_line":"Instead it returns a list of it with a certain hierarchy."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dab17558_0708782b","line":9,"updated":"2016-05-09 22:22:19.000000000","message":"wrap at 70 chars","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add multi-segment support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron ML2 mechanisms allows multiple network segments. A net-show call with"},{"line_number":10,"context_line":"a multi-segment setup won\u0027t return a single network-type or segmentation id."},{"line_number":11,"context_line":"Instead it returns a list of it with a certain hierarchy."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bab6814e_65172cee","line":9,"in_reply_to":"dab17558_0708782b","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Add multi-segment support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron ML2 mechanisms allows multiple network segments. A net-show call with"},{"line_number":10,"context_line":"a multi-segment setup won\u0027t return a single network-type or segmentation id."},{"line_number":11,"context_line":"Instead it returns a list of it with a certain hierarchy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dab17558_2203ea0e","line":10,"updated":"2016-05-09 22:22:19.000000000","message":"wrap at 70 chars","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Add multi-segment support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron ML2 mechanisms allows multiple network segments. A net-show call with"},{"line_number":10,"context_line":"a multi-segment setup won\u0027t return a single network-type or segmentation id."},{"line_number":11,"context_line":"Instead it returns a list of it with a certain hierarchy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bab6814e_c5d25834","line":10,"in_reply_to":"dab17558_2203ea0e","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":14,"context_line":"Change-Id: I3570752920d897c11cacb9e4a0b0d012ae2ce13a"},{"line_number":15,"context_line":"Partly-implements: bp manila-hpb-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dab17558_e219e27a","line":15,"updated":"2016-05-09 22:22:19.000000000","message":"Nowadays this bp should lead to a bp spec, not an etherpad.\n\n(Good stuff in etherpad btw).","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":14,"context_line":"Change-Id: I3570752920d897c11cacb9e4a0b0d012ae2ce13a"},{"line_number":15,"context_line":"Partly-implements: bp manila-hpb-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bab6814e_05dd8042","line":15,"in_reply_to":"dab17558_e219e27a","updated":"2016-05-18 06:46:16.000000000","message":"Spec is up for review","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":15,"context_line":"Change-Id: I3570752920d897c11cacb9e4a0b0d012ae2ce13a"},{"line_number":16,"context_line":"Partly-implements: bp manila-hpb-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dada55a8_80c48892","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"updated":"2016-07-24 22:47:31.000000000","message":"Partially","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"572fe8e46c8cd11d526a3aef998f3cf169a81519","unresolved":false,"context_lines":[{"line_number":10,"context_line":"call with a multi-segment setup won\u0027t return a single network-type"},{"line_number":11,"context_line":"or segmentation id. Instead it returns a list of it with a certain"},{"line_number":12,"context_line":"hierarchy."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":15,"context_line":"Change-Id: I3570752920d897c11cacb9e4a0b0d012ae2ce13a"},{"line_number":16,"context_line":"Partially-Implements: bp manila-hpb-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bacf61ea_8fabb274","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2016-07-31 20:01:25.000000000","message":"Could you please add a Depends-On: and link to the parent change-id. Would be easier for reviewers to review the parent..","commit_id":"1ab7690a013297f7f941266bd38216e75c660eee"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8ef10f828625d1d2030ee8d01d4ab8fb79ea7565","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            \u0027segmentation_id\u0027: segmentation_id"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self.db.share_network_update(context,"},{"line_number":164,"context_line":"                                     share_network[\u0027id\u0027],"},{"line_number":165,"context_line":"                                     provider_nw_dict)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _save_neutron_subnet_data(self, context, share_network):"},{"line_number":168,"context_line":"        subnet_info \u003d self.neutron_api.get_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_9ca9667e","line":165,"range":{"start_line":163,"start_character":7,"end_line":165,"end_character":54},"updated":"2016-02-09 08:35:39.000000000","message":"In general it\u0027s not a good idea to duplicate neutron data in the manila db.","commit_id":"7294686c1d2e46cef2552ca92da40a971c9c8d97"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e0cfd18a6aa97c1fb05b3c974b4bdf220b0202e7","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            \u0027segmentation_id\u0027: segmentation_id"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self.db.share_network_update(context,"},{"line_number":164,"context_line":"                                     share_network[\u0027id\u0027],"},{"line_number":165,"context_line":"                                     provider_nw_dict)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _save_neutron_subnet_data(self, context, share_network):"},{"line_number":168,"context_line":"        subnet_info \u003d self.neutron_api.get_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_13b72c87","line":165,"range":{"start_line":163,"start_character":7,"end_line":165,"end_character":54},"in_reply_to":"5a5ae5dd_9ca9667e","updated":"2016-02-21 20:35:24.000000000","message":"1) That info is stored and used right after saving in DB. And only once.\n\n2) That info can be viewed using Manila API.\n\n3) Each new \"share server\" creation using single \"share network\" updates DB info.\n\nSo, there is no case when Manila can use obsolete info.","commit_id":"7294686c1d2e46cef2552ca92da40a971c9c8d97"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"278a4f6170790c82efe692a3f9821e36be2333f3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            segments \u003d net_info[\u0027segments\u0027]"},{"line_number":147,"context_line":"            types \u003d \u0027_\u0027.join("},{"line_number":148,"context_line":"                    [type[\u0027provider:network_type\u0027] for type in segments])"},{"line_number":149,"context_line":"            network_type \u003d \"%s_%s\" % (network_type_prefix, types)"},{"line_number":150,"context_line":"            # We use the segment on top (should be the one that need used"},{"line_number":151,"context_line":"            # by the storage"},{"line_number":152,"context_line":"            segmentation_id \u003d (net_info[\u0027segments\u0027][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_bedd6716","line":149,"range":{"start_line":149,"start_character":27,"end_line":149,"end_character":65},"updated":"2016-02-21 21:58:21.000000000","message":"Why do you need mentioning whole hierarchy? Driver cares only about its own port configuration. So, this change should just add logic of \"list of data\" handling instead of old \"single datum\" handling. And doing so, you will not need to update list of supported network types in each share driver.","commit_id":"aa5d3cf855dd343b9846e67528221c7503acbfdd"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b14dbe51b3896610ae242a1fa0fbc041c0a2871f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            segments \u003d net_info[\u0027segments\u0027]"},{"line_number":147,"context_line":"            types \u003d \u0027_\u0027.join("},{"line_number":148,"context_line":"                    [type[\u0027provider:network_type\u0027] for type in segments])"},{"line_number":149,"context_line":"            network_type \u003d \"%s_%s\" % (network_type_prefix, types)"},{"line_number":150,"context_line":"            # We use the segment on top (should be the one that need used"},{"line_number":151,"context_line":"            # by the storage"},{"line_number":152,"context_line":"            segmentation_id \u003d (net_info[\u0027segments\u0027][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_4ec70264","line":149,"range":{"start_line":149,"start_character":27,"end_line":149,"end_character":65},"in_reply_to":"bae84128_bedd6716","updated":"2016-02-23 10:40:27.000000000","message":"Agree, for my use case yes this would be the easiest solution. I just wanted to \"store\" all information of the network, but yes this could ease up things. Will fix that in a later patch.","commit_id":"aa5d3cf855dd343b9846e67528221c7503acbfdd"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"c42171f2eb9dbdc09117fe7b4c38baf63b67525e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            share_network[\u0027neutron_net_id\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        provider_nw_dict \u003d {}"},{"line_number":155,"context_line":"        if \u0027segments\u0027 in net_info:"},{"line_number":156,"context_line":"            # In case of multi segment we have multiple network types"},{"line_number":157,"context_line":"            network_type_prefix \u003d \u0027multi\u0027"},{"line_number":158,"context_line":"            segments \u003d net_info[\u0027segments\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_e45adc82","line":155,"updated":"2016-03-21 17:49:45.000000000","message":"Do you really need to have the information about the segments? \nWhy not let the ML2 drivers deal with it?","commit_id":"e786176b27d8674bcd4b9b42f27611bc4b7af8f3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":33,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":36,"context_line":"        help\u003d\"The name of the physical network to determine which net segment\""},{"line_number":37,"context_line":"             \"is used\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_22512a0f","line":36,"updated":"2016-05-09 22:22:19.000000000","message":"space between \u0027segment\u0027 and \u0027is used\u0027.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":33,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":36,"context_line":"        help\u003d\"The name of the physical network to determine which net segment\""},{"line_number":37,"context_line":"             \"is used\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_c52b7832","line":36,"in_reply_to":"dab17558_22512a0f","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":197,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":198,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":199,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":200,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":201,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":202,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_d59bb570","line":199,"range":{"start_line":199,"start_character":28,"end_line":199,"end_character":67},"updated":"2016-05-10 02:31:24.000000000","message":"Can just use share_network.get(\u0027network_type\u0027), \u0027None\u0027 would be the default return value.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":197,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":198,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":199,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":200,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":201,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":202,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_0558e0f9","line":199,"range":{"start_line":199,"start_character":28,"end_line":199,"end_character":67},"in_reply_to":"dab17558_d59bb570","updated":"2016-05-18 06:46:16.000000000","message":"In case of multi-segment this field does not exist.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":198,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":199,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":200,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":201,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":202,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":203,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_35896127","line":200,"range":{"start_line":200,"start_character":31,"end_line":200,"end_character":73},"updated":"2016-05-10 02:31:24.000000000","message":"same","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":198,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":199,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":200,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":201,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":202,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":203,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_e55cbcef","line":200,"range":{"start_line":200,"start_character":31,"end_line":200,"end_character":73},"in_reply_to":"dab17558_35896127","updated":"2016-05-18 06:46:16.000000000","message":"In case of multi-segment this field does not exist.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            if not phy:"},{"line_number":238,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":239,"context_line":"                    \"Cannot identify segment used for binding. Please \""},{"line_number":240,"context_line":"                    \"add neutron_physical_net_name in configuration\")"},{"line_number":241,"context_line":"            for segment in net_info[\u0027segments\u0027]:"},{"line_number":242,"context_line":"                phy_nets.append(segment[\u0027provider:physical_network\u0027])"},{"line_number":243,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_2293ea50","line":240,"updated":"2016-05-09 22:22:19.000000000","message":"Need to add a period?","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"},{"line_number":244,"context_line":"                    segmentation_id \u003d segment[\u0027provider:segmentation_id\u0027]"},{"line_number":245,"context_line":"                    network_type \u003d segment[\u0027provider:network_type\u0027]"},{"line_number":246,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":247,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":248,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":249,"context_line":"                    \"%s)\" % (phy, phy_nets))"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_359681f0","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":55},"updated":"2016-05-10 02:31:24.000000000","message":"if not (segmentation_id and network_type):","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":247,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":248,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":249,"context_line":"                    \"%s)\" % (phy, phy_nets))"},{"line_number":250,"context_line":"        else:"},{"line_number":251,"context_line":"            network_type \u003d net_info[\u0027provider:network_type\u0027]"},{"line_number":252,"context_line":"            segmentation_id \u003d net_info[\u0027provider:segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_c2a49ea7","line":249,"updated":"2016-05-09 22:22:19.000000000","message":"ditto","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def _store_neutron_net_info(self, context, share_network):"},{"line_number":422,"context_line":"        if self._is_neutron_multi_segment(share_network):"},{"line_number":423,"context_line":"            # in case of dynamic multi segment the segment is determined while"},{"line_number":424,"context_line":"            # binding the port"},{"line_number":425,"context_line":"            return"},{"line_number":426,"context_line":"        super(NeutronBindNetworkPlugin, self)._store_neutron_net_info("}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_7042d711","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":16},"updated":"2016-05-10 02:31:24.000000000","message":"In","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def _store_neutron_net_info(self, context, share_network):"},{"line_number":422,"context_line":"        if self._is_neutron_multi_segment(share_network):"},{"line_number":423,"context_line":"            # in case of dynamic multi segment the segment is determined while"},{"line_number":424,"context_line":"            # binding the port"},{"line_number":425,"context_line":"            return"},{"line_number":426,"context_line":"        super(NeutronBindNetworkPlugin, self)._store_neutron_net_info("}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_4520284a","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":16},"in_reply_to":"dab17558_7042d711","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        self._wait_for_ports_bind(context, ports, share_server,"},{"line_number":435,"context_line":"                                  config.neutron_bind_timeout)"},{"line_number":436,"context_line":"        if self._is_neutron_multi_segment(share_network):"},{"line_number":437,"context_line":"            # in case of dynamic multi segment the segment is determined while"},{"line_number":438,"context_line":"            # binding the port"},{"line_number":439,"context_line":"            self._save_neutron_network_data(context, share_network)"},{"line_number":440,"context_line":"            self._save_neutron_subnet_data(context, share_network)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_103b8b9d","line":437,"range":{"start_line":437,"start_character":14,"end_line":437,"end_character":16},"updated":"2016-05-10 02:31:24.000000000","message":"In","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        self._wait_for_ports_bind(context, ports, share_server,"},{"line_number":435,"context_line":"                                  config.neutron_bind_timeout)"},{"line_number":436,"context_line":"        if self._is_neutron_multi_segment(share_network):"},{"line_number":437,"context_line":"            # in case of dynamic multi segment the segment is determined while"},{"line_number":438,"context_line":"            # binding the port"},{"line_number":439,"context_line":"            self._save_neutron_network_data(context, share_network)"},{"line_number":440,"context_line":"            self._save_neutron_subnet_data(context, share_network)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_251d2410","line":437,"range":{"start_line":437,"start_character":14,"end_line":437,"end_character":16},"in_reply_to":"dab17558_103b8b9d","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                    \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":444,"context_line":"                    \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027]}"},{"line_number":445,"context_line":"                ports[num] \u003d self.db.network_allocation_update("},{"line_number":446,"context_line":"                    context, port[\u0027id\u0027],"},{"line_number":447,"context_line":"                    port_info)"},{"line_number":448,"context_line":"        return ports"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_753c89e2","line":447,"range":{"start_line":446,"start_character":20,"end_line":447,"end_character":30},"updated":"2016-05-10 02:31:24.000000000","message":"Cloud be one line","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bea2b0a40e0684106a74e753d519a956163b7679","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                    \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":444,"context_line":"                    \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027]}"},{"line_number":445,"context_line":"                ports[num] \u003d self.db.network_allocation_update("},{"line_number":446,"context_line":"                    context, port[\u0027id\u0027],"},{"line_number":447,"context_line":"                    port_info)"},{"line_number":448,"context_line":"        return ports"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_851a1016","line":447,"range":{"start_line":446,"start_character":20,"end_line":447,"end_character":30},"in_reply_to":"dab17558_753c89e2","updated":"2016-05-18 06:46:16.000000000","message":"Done","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab62d722f53b11b260bf8a5e46b94fa5f7938c11","unresolved":false,"context_lines":[{"line_number":33,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":36,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":37,"context_line":"             \"is used\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_20a46049","line":37,"range":{"start_line":36,"start_character":14,"end_line":37,"end_character":23},"updated":"2016-06-17 15:29:04.000000000","message":"Need to say it is optional and will be used only if HPB configured.","commit_id":"f486ddc26361b60074b935838c65cfb1b6d03822"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab62d722f53b11b260bf8a5e46b94fa5f7938c11","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":197,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":198,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":199,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":200,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":201,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":202,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_804a7481","line":199,"range":{"start_line":199,"start_character":60,"end_line":199,"end_character":66},"updated":"2016-06-17 15:29:04.000000000","message":"None is default, no need to return it explicitly.","commit_id":"f486ddc26361b60074b935838c65cfb1b6d03822"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab62d722f53b11b260bf8a5e46b94fa5f7938c11","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                                      self.config.neutron_bind_timeout)"},{"line_number":449,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":450,"context_line":"                # update segment information after port bind"},{"line_number":451,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":452,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":453,"context_line":"                for num, port in enumerate(ports):"},{"line_number":454,"context_line":"                    port_info \u003d {"},{"line_number":455,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_7b829d53","line":452,"range":{"start_line":451,"start_character":16,"end_line":452,"end_character":70},"updated":"2016-06-17 15:29:04.000000000","message":"Either do not implement new method \"_store_neutron_net_info\" or reuse it everywhere.","commit_id":"f486ddc26361b60074b935838c65cfb1b6d03822"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":36,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":37,"context_line":"             \"is used\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_60bfd4fc","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":23},"updated":"2016-07-24 22:47:31.000000000","message":"nit: missing period","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":36,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":37,"context_line":"             \"is used\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_e5e1e39b","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":23},"in_reply_to":"dada55a8_60bfd4fc","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":198,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":199,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":200,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":201,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":202,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":203,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_c0be80fe","line":200,"range":{"start_line":200,"start_character":62,"end_line":200,"end_character":66},"updated":"2016-07-24 22:47:31.000000000","message":"None is the default..","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":198,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"},{"line_number":199,"context_line":"            \u0027label\u0027: self.label,"},{"line_number":200,"context_line":"            \u0027network_type\u0027: share_network.get(\u0027network_type\u0027, None),"},{"line_number":201,"context_line":"            \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027, None),"},{"line_number":202,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":203,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_85e90783","line":200,"range":{"start_line":200,"start_character":62,"end_line":200,"end_character":66},"in_reply_to":"dada55a8_c0be80fe","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            if not phy:"},{"line_number":239,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":240,"context_line":"                    \"Cannot identify segment used for binding. Please \""},{"line_number":241,"context_line":"                    \"add neutron_physical_net_name in configuration\")"},{"line_number":242,"context_line":"            for segment in net_info[\u0027segments\u0027]:"},{"line_number":243,"context_line":"                phy_nets.append(segment[\u0027provider:physical_network\u0027])"},{"line_number":244,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_cb818191","line":241,"range":{"start_line":241,"start_character":54,"end_line":241,"end_character":67},"updated":"2016-07-24 22:47:31.000000000","message":"nit: Missing period","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            if not phy:"},{"line_number":239,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":240,"context_line":"                    \"Cannot identify segment used for binding. Please \""},{"line_number":241,"context_line":"                    \"add neutron_physical_net_name in configuration\")"},{"line_number":242,"context_line":"            for segment in net_info[\u0027segments\u0027]:"},{"line_number":243,"context_line":"                phy_nets.append(segment[\u0027provider:physical_network\u0027])"},{"line_number":244,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ab7c0db6","line":241,"range":{"start_line":241,"start_character":54,"end_line":241,"end_character":67},"updated":"2016-07-24 22:47:31.000000000","message":"which part of the configuration? section name would be helpful?","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"7937241af6d438661be23ebf3974d6ec7db41936","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        provider_nw_dict \u003d {"},{"line_number":256,"context_line":"            \u0027network_type\u0027: network_type,"},{"line_number":257,"context_line":"            \u0027segmentation_id\u0027: segmentation_id"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        share_network.update(provider_nw_dict)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_76f0f4fe","line":257,"updated":"2016-07-06 09:41:08.000000000","message":"Add comma in the end. \nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        provider_nw_dict \u003d {"},{"line_number":256,"context_line":"            \u0027network_type\u0027: network_type,"},{"line_number":257,"context_line":"            \u0027segmentation_id\u0027: segmentation_id"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        share_network.update(provider_nw_dict)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_65a33350","line":257,"in_reply_to":"1aa78d24_76f0f4fe","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def _store_neutron_net_info(self, context, share_network):"},{"line_number":433,"context_line":"        if self._is_neutron_multi_segment(share_network):"},{"line_number":434,"context_line":"            # In case of dynamic multi segment the segment is determined while"},{"line_number":435,"context_line":"            # binding the port"},{"line_number":436,"context_line":"            return"},{"line_number":437,"context_line":"        super(NeutronBindNetworkPlugin, self)._store_neutron_net_info("},{"line_number":438,"context_line":"            context, share_network)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_a69a846c","line":435,"range":{"start_line":434,"start_character":0,"end_line":435,"end_character":30},"updated":"2016-07-24 22:47:31.000000000","message":"I would put this message as the docstring of this method to explain why this method is being overridden..","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"7937241af6d438661be23ebf3974d6ec7db41936","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":454,"context_line":"                # update segment information after port bind"},{"line_number":455,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":456,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":457,"context_line":"                for num, port in enumerate(ports):"},{"line_number":458,"context_line":"                    port_info \u003d {"},{"line_number":459,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_bc0d1bea","line":456,"updated":"2016-07-06 09:41:08.000000000","message":"Better to use NeutronNetworkPlugin._store_neutron_net_info() \n\n    Super(NeutronBindNetworkPlugin, self)._store_neutron_net_info(context, share_network)\n\nIn general, it is much complicated about the callstack. For example:\n\nNeutronBindNetworkPlugin.allocate_network\n-\u003e NeutronNetworkPlugin.allocate_network\n  -\u003e NeutronBindNetworkPlugin._store_neutron_net_info\n    -\u003e NeutronNetworkPlugin._store_neutron_net_info\n-\u003eNeutronNetworkPlugin._store_neutron_net_info\n\nIs there any way to make it simple?","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":454,"context_line":"                # update segment information after port bind"},{"line_number":455,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":456,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":457,"context_line":"                for num, port in enumerate(ports):"},{"line_number":458,"context_line":"                    port_info \u003d {"},{"line_number":459,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_2685f406","line":456,"in_reply_to":"1aa78d24_bc0d1bea","updated":"2016-07-24 22:47:31.000000000","message":"+1","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":460,"context_line":"                        \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":461,"context_line":"                        \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":462,"context_line":"                        \u0027ip_version\u0027: share_network[\u0027ip_version\u0027]}"},{"line_number":463,"context_line":"                    ports[num] \u003d self.db.network_allocation_update("},{"line_number":464,"context_line":"                        context, port[\u0027id\u0027], port_info)"},{"line_number":465,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_e6911c48","line":462,"range":{"start_line":462,"start_character":64,"end_line":462,"end_character":66},"updated":"2016-07-24 22:47:31.000000000","message":"wrap dictionary in the next line.. \n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":460,"context_line":"                        \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":461,"context_line":"                        \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":462,"context_line":"                        \u0027ip_version\u0027: share_network[\u0027ip_version\u0027]}"},{"line_number":463,"context_line":"                    ports[num] \u003d self.db.network_allocation_update("},{"line_number":464,"context_line":"                        context, port[\u0027id\u0027], port_info)"},{"line_number":465,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_05319705","line":462,"range":{"start_line":462,"start_character":64,"end_line":462,"end_character":66},"in_reply_to":"dada55a8_e6911c48","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"572fe8e46c8cd11d526a3aef998f3cf169a81519","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        if self.config.neutron_vnic_type !\u003d \u0027normal\u0027:"},{"line_number":457,"context_line":"            self._wait_for_ports_bind(ports, share_server,"},{"line_number":458,"context_line":"                                      self.config.neutron_bind_timeout)"},{"line_number":459,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":460,"context_line":"                # update segment information after port bind"},{"line_number":461,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":462,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":463,"context_line":"                for num, port in enumerate(ports):"},{"line_number":464,"context_line":"                    port_info \u003d {"},{"line_number":465,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_af95d633","line":462,"range":{"start_line":459,"start_character":12,"end_line":462,"end_character":70},"updated":"2016-07-31 20:01:25.000000000","message":"See jay\u0027s comment on PS 12.. Any particular reason you can\u0027t call super()._store_neutron_net_info()?","commit_id":"1ab7690a013297f7f941266bd38216e75c660eee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"572fe8e46c8cd11d526a3aef998f3cf169a81519","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":466,"context_line":"                        \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":467,"context_line":"                        \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":468,"context_line":"                        \u0027ip_version\u0027: share_network[\u0027ip_version\u0027]"},{"line_number":469,"context_line":"                    }"},{"line_number":470,"context_line":"                    ports[num] \u003d self.db.network_allocation_update("},{"line_number":471,"context_line":"                        context, port[\u0027id\u0027], port_info)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_0f97c23a","line":468,"range":{"start_line":468,"start_character":63,"end_line":468,"end_character":65},"updated":"2016-07-31 20:01:25.000000000","message":"missing trailing comma","commit_id":"1ab7690a013297f7f941266bd38216e75c660eee"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0fbe170dc7b47216803791366a346c503c0853b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt("},{"line_number":34,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":35,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":36,"context_line":"             \"is used.\","},{"line_number":37,"context_line":"        default\u003dNone,"},{"line_number":38,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_38ddaf14","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":24},"updated":"2016-09-01 13:47:28.000000000","message":"patch set 11: \"Need to say it is optional and will be used only if HPB configured.\"\n\nNot addressed.","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":32,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt("},{"line_number":34,"context_line":"        \u0027neutron_physical_net_name\u0027,"},{"line_number":35,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":36,"context_line":"             \"is used.\","},{"line_number":37,"context_line":"        default\u003dNone,"},{"line_number":38,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_dbee6fec","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":24},"in_reply_to":"fa7ab95a_38ddaf14","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cf0440415ddb2d9bc7a8c9dc5a08cd5ccfb37d39","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            if not phy:"},{"line_number":235,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":236,"context_line":"                    \"Cannot identify segment used for binding. Please \""},{"line_number":237,"context_line":"                    \"add neutron_physical_net_name in configuration.\")"},{"line_number":238,"context_line":"            for segment in net_info[\u0027segments\u0027]:"},{"line_number":239,"context_line":"                phy_nets.append(segment[\u0027provider:physical_network\u0027])"},{"line_number":240,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_d8fda33c","line":237,"updated":"2016-09-01 13:48:03.000000000","message":"exception.NetworkBadConfigurationException(reason\u003dmsg)","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            if not phy:"},{"line_number":235,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":236,"context_line":"                    \"Cannot identify segment used for binding. Please \""},{"line_number":237,"context_line":"                    \"add neutron_physical_net_name in configuration.\")"},{"line_number":238,"context_line":"            for segment in net_info[\u0027segments\u0027]:"},{"line_number":239,"context_line":"                phy_nets.append(segment[\u0027provider:physical_network\u0027])"},{"line_number":240,"context_line":"                if segment[\u0027provider:physical_network\u0027] \u003d\u003d phy:"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_988a2dbe","line":237,"in_reply_to":"fa7ab95a_d8fda33c","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    network_type \u003d segment[\u0027provider:network_type\u0027]"},{"line_number":243,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":244,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":245,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":246,"context_line":"                    \"%s)\" % (phy, phy_nets))"},{"line_number":247,"context_line":"        else:"},{"line_number":248,"context_line":"            network_type \u003d net_info[\u0027provider:network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_3f94c7e0","line":245,"range":{"start_line":245,"start_character":64,"end_line":245,"end_character":65},"updated":"2016-09-01 11:30:27.000000000","message":"for","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    network_type \u003d segment[\u0027provider:network_type\u0027]"},{"line_number":243,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":244,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":245,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":246,"context_line":"                    \"%s)\" % (phy, phy_nets))"},{"line_number":247,"context_line":"        else:"},{"line_number":248,"context_line":"            network_type \u003d net_info[\u0027provider:network_type\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_b887f1b3","line":245,"range":{"start_line":245,"start_character":64,"end_line":245,"end_character":65},"in_reply_to":"fa7ab95a_3f94c7e0","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cf0440415ddb2d9bc7a8c9dc5a08cd5ccfb37d39","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":244,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":245,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":246,"context_line":"                    \"%s)\" % (phy, phy_nets))"},{"line_number":247,"context_line":"        else:"},{"line_number":248,"context_line":"            network_type \u003d net_info[\u0027provider:network_type\u0027]"},{"line_number":249,"context_line":"            segmentation_id \u003d net_info[\u0027provider:segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_f8aa6718","line":246,"updated":"2016-09-01 13:48:03.000000000","message":"exception.NetworkBadConfigurationException(reason\u003dmsg)","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            if not segmentation_id or not network_type:"},{"line_number":244,"context_line":"                raise exception.NetworkBadConfigurationException("},{"line_number":245,"context_line":"                    \"No matching neutron_physical_net_name found %s (found:\""},{"line_number":246,"context_line":"                    \"%s)\" % (phy, phy_nets))"},{"line_number":247,"context_line":"        else:"},{"line_number":248,"context_line":"            network_type \u003d net_info[\u0027provider:network_type\u0027]"},{"line_number":249,"context_line":"            segmentation_id \u003d net_info[\u0027provider:segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_18bd3d68","line":246,"in_reply_to":"fa7ab95a_f8aa6718","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    def _store_neutron_net_info(self, context, share_network):"},{"line_number":422,"context_line":"        \"\"\"Store the Neutron network info."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_20e65fb4","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":40},"updated":"2016-09-01 11:30:27.000000000","message":"segments,","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    def _store_neutron_net_info(self, context, share_network):"},{"line_number":422,"context_line":"        \"\"\"Store the Neutron network info."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_b82371bc","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":40},"in_reply_to":"fa7ab95a_20e65fb4","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        \"\"\"Store the Neutron network info."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_60bce76c","line":425,"range":{"start_line":425,"start_character":70,"end_line":425,"end_character":77},"updated":"2016-09-01 11:30:27.000000000","message":"segments","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        \"\"\"Store the Neutron network info."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_381e8170","line":425,"range":{"start_line":425,"start_character":70,"end_line":425,"end_character":77},"in_reply_to":"fa7ab95a_60bce76c","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"},{"line_number":429,"context_line":"        then store network information (see allocate_network())."}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_3316bbf1","line":426,"range":{"start_line":426,"start_character":8,"end_line":426,"end_character":16},"updated":"2016-09-01 11:30:27.000000000","message":"network","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        In case of dynamic multi segment the segment is determined while"},{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"},{"line_number":429,"context_line":"        then store network information (see allocate_network())."}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_580fc538","line":426,"range":{"start_line":426,"start_character":8,"end_line":426,"end_character":16},"in_reply_to":"fa7ab95a_3316bbf1","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"},{"line_number":429,"context_line":"        then store network information (see allocate_network())."},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        if self._is_neutron_multi_segment(share_network):"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_d3e74f10","line":428,"range":{"start_line":428,"start_character":23,"end_line":428,"end_character":39},"updated":"2016-09-01 11:30:27.000000000","message":"segments network","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        binding the port. Therefore this method will return for multi segment"},{"line_number":426,"context_line":"        networks without storing network information."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        Instead, multi segment networks will wait until ports are bound and"},{"line_number":429,"context_line":"        then store network information (see allocate_network())."},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        if self._is_neutron_multi_segment(share_network):"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_7814894c","line":428,"range":{"start_line":428,"start_character":23,"end_line":428,"end_character":39},"in_reply_to":"fa7ab95a_d3e74f10","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cf50779be7be7e25599bfcf27d6bee4498f293","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":451,"context_line":"                # update segment information after port bind"},{"line_number":452,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":453,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":454,"context_line":"                for num, port in enumerate(ports):"},{"line_number":455,"context_line":"                    port_info \u003d {"},{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_53041f7d","line":453,"updated":"2016-09-01 11:30:27.000000000","message":"still, why not use super()._store_neutron_net_info()?","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cf0440415ddb2d9bc7a8c9dc5a08cd5ccfb37d39","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":451,"context_line":"                # update segment information after port bind"},{"line_number":452,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":453,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":454,"context_line":"                for num, port in enumerate(ports):"},{"line_number":455,"context_line":"                    port_info \u003d {"},{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_581b5380","line":453,"in_reply_to":"fa7ab95a_53041f7d","updated":"2016-09-01 13:48:03.000000000","message":"+1.  Please use _store_neutron_net_info().","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0fbe170dc7b47216803791366a346c503c0853b8","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":451,"context_line":"                # update segment information after port bind"},{"line_number":452,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":453,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":454,"context_line":"                for num, port in enumerate(ports):"},{"line_number":455,"context_line":"                    port_info \u003d {"},{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_b820df4a","line":453,"in_reply_to":"fa7ab95a_53041f7d","updated":"2016-09-01 13:47:28.000000000","message":"This suggestion has been around since PS 11 or 12 and still has not been addressed.","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            if self._is_neutron_multi_segment(share_network):"},{"line_number":451,"context_line":"                # update segment information after port bind"},{"line_number":452,"context_line":"                self._save_neutron_network_data(context, share_network)"},{"line_number":453,"context_line":"                self._save_neutron_subnet_data(context, share_network)"},{"line_number":454,"context_line":"                for num, port in enumerate(ports):"},{"line_number":455,"context_line":"                    port_info \u003d {"},{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_7ba7230b","line":453,"in_reply_to":"fa7ab95a_581b5380","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0fbe170dc7b47216803791366a346c503c0853b8","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":457,"context_line":"                        \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":458,"context_line":"                        \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":459,"context_line":"                        \u0027ip_version\u0027: share_network[\u0027ip_version\u0027]"},{"line_number":460,"context_line":"                    }"},{"line_number":461,"context_line":"                    ports[num] \u003d self.db.network_allocation_update("},{"line_number":462,"context_line":"                        context, port[\u0027id\u0027], port_info)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_98aebb96","line":459,"range":{"start_line":459,"start_character":24,"end_line":459,"end_character":65},"updated":"2016-09-01 13:47:28.000000000","message":"PS 14: add trailing comma, not addressed.","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70bb7e58cd15df5bd5e228bae23897c2300a4b80","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                        \u0027network_type\u0027: share_network[\u0027network_type\u0027],"},{"line_number":457,"context_line":"                        \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":458,"context_line":"                        \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":459,"context_line":"                        \u0027ip_version\u0027: share_network[\u0027ip_version\u0027]"},{"line_number":460,"context_line":"                    }"},{"line_number":461,"context_line":"                    ports[num] \u003d self.db.network_allocation_update("},{"line_number":462,"context_line":"                        context, port[\u0027id\u0027], port_info)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_bb944b8b","line":459,"range":{"start_line":459,"start_character":24,"end_line":459,"end_character":65},"in_reply_to":"fa7ab95a_98aebb96","updated":"2016-09-01 17:33:44.000000000","message":"Done","commit_id":"3b916039c89503c2afd88c12ebdc291a2c5ce5c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3465a8179ea8ee4634dc9124c82de5ae5d1537e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        help\u003d\"The name of the physical network to determine which net segment \""},{"line_number":36,"context_line":"             \"is used. This opt is optional and will only be used for \""},{"line_number":37,"context_line":"             \"networks configured with multiple segments.\","},{"line_number":38,"context_line":"        default\u003dNone,"},{"line_number":39,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_214ba888","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":21},"updated":"2016-09-01 17:47:58.000000000","message":"Remove if another patchset\u0027s needed..","commit_id":"8dc73bfc45acaaed707042d1d0e2a22f26ce523a"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"c42171f2eb9dbdc09117fe7b4c38baf63b67525e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":37,"context_line":"SUPPORTED_NETWORK_TYPES \u003d (None, \u0027flat\u0027, \u0027vlan\u0027, \u0027multi_vlan_vxlan\u0027)"},{"line_number":38,"context_line":"SEGMENTED_NETWORK_TYPES \u003d (\u0027vlan\u0027, \u0027multi_vlan_vxlan\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_84bb20c4","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":23},"updated":"2016-03-21 17:49:45.000000000","message":"Is there any specific reason why do you need to create multi_vlan_vxlan type network? \nThere is no such thing","commit_id":"e786176b27d8674bcd4b9b42f27611bc4b7af8f3"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"c42171f2eb9dbdc09117fe7b4c38baf63b67525e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":37,"context_line":"SUPPORTED_NETWORK_TYPES \u003d (None, \u0027flat\u0027, \u0027vlan\u0027, \u0027multi_vlan_vxlan\u0027)"},{"line_number":38,"context_line":"SEGMENTED_NETWORK_TYPES \u003d (\u0027vlan\u0027, \u0027multi_vlan_vxlan\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class NetAppCmodeMultiSVMFileStorageLibrary("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_c4b518ce","line":38,"updated":"2016-03-21 17:49:45.000000000","message":"ditto","commit_id":"e786176b27d8674bcd4b9b42f27611bc4b7af8f3"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"fake_share_network \u003d {"},{"line_number":76,"context_line":"    \u0027id\u0027: \u0027fake nw info id\u0027,"},{"line_number":77,"context_line":"    \u0027neutron_subnet_id\u0027: fake_neutron_network[\u0027subnets\u0027][0],"},{"line_number":78,"context_line":"    \u0027neutron_net_id\u0027: fake_neutron_network[\u0027id\u0027],"},{"line_number":79,"context_line":"    \u0027project_id\u0027: \u0027fake project id\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_a23b5a37","line":76,"updated":"2016-05-09 22:22:19.000000000","message":"I\u0027ll just note that when we move to oslo versioned objects we\u0027re going to have to use valid uuids for lots of these id fields.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":133,"context_line":"    \u0027subnets\u0027: [\u0027fake subnet id\u0027,"},{"line_number":134,"context_line":"                \u0027fake subnet id 2\u0027],"},{"line_number":135,"context_line":"    \u0027segments\u0027: fake_nw_info[\u0027segments\u0027]"},{"line_number":136,"context_line":"}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"fake_share_network_multi \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_955acd4e","line":135,"range":{"start_line":135,"start_character":39,"end_line":135,"end_character":40},"updated":"2016-05-10 02:31:24.000000000","message":"Add \u0027,\u0027 in the end.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac40e4053a2a3aaf248555d0f7d4f2e59de50352","unresolved":false,"context_lines":[{"line_number":164,"context_line":"fake_binding_profile \u003d {"},{"line_number":165,"context_line":"    \u0027neutron_switch_id\u0027: \u0027fake switch id\u0027,"},{"line_number":166,"context_line":"    \u0027neutron_port_id\u0027: \u0027fake port id\u0027,"},{"line_number":167,"context_line":"    \u0027neutron_switch_info\u0027: \u0027fake switch info\u0027"},{"line_number":168,"context_line":"}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_b55f1140","line":167,"range":{"start_line":167,"start_character":44,"end_line":167,"end_character":45},"updated":"2016-05-10 02:31:24.000000000","message":"Add \u0027,\u0027 in the end.","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        self.mock_object(db_api, \u0027network_allocation_create\u0027)"},{"line_number":720,"context_line":"        db_api.network_allocation_create.return_value \u003d fake_network_allocation"},{"line_number":721,"context_line":"        self.mock_object(self.bind_plugin.neutron_api, \u0027get_network\u0027)"},{"line_number":722,"context_line":"        self.bind_plugin.neutron_api.get_network.return_value \u003d \\"},{"line_number":723,"context_line":"            fake_neutron_network"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        with mock.patch.object(self.bind_plugin.neutron_api, \u0027create_port\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_e21c42c3","line":722,"updated":"2016-05-09 22:22:19.000000000","message":"We should be using parens for continuation rather than \u0027\\\u0027, right?","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":762,"context_line":"            \u0027segmentation_id\u0027:"},{"line_number":763,"context_line":"                fake_nw_info[\u0027segments\u0027][0][\u0027provider:segmentation_id\u0027],"},{"line_number":764,"context_line":"        }"},{"line_number":765,"context_line":"        fake_network_allocation_multi_updated \u003d \\"},{"line_number":766,"context_line":"            dict(fake_network_allocation_multi)"},{"line_number":767,"context_line":"        fake_network_allocation_multi_updated.update(network_update_data)"},{"line_number":768,"context_line":"        fake_share_network_multi_updated \u003d dict(fake_share_network_multi)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_828456d4","line":765,"updated":"2016-05-09 22:22:19.000000000","message":"ditto","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        socket.gethostname.return_value \u003d \u0027foohost1\u0027"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        self.mock_object(db_api, \u0027network_allocation_create\u0027)"},{"line_number":790,"context_line":"        db_api.network_allocation_create.return_value \u003d \\"},{"line_number":791,"context_line":"            fake_network_allocation_multi"},{"line_number":792,"context_line":"        self.mock_object(db_api, \u0027network_allocation_update\u0027)"},{"line_number":793,"context_line":"        db_api.network_allocation_update.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_c26e5e2e","line":790,"updated":"2016-05-09 22:22:19.000000000","message":"ditto","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        db_api.network_allocation_create.return_value \u003d \\"},{"line_number":791,"context_line":"            fake_network_allocation_multi"},{"line_number":792,"context_line":"        self.mock_object(db_api, \u0027network_allocation_update\u0027)"},{"line_number":793,"context_line":"        db_api.network_allocation_update.return_value \u003d \\"},{"line_number":794,"context_line":"            fake_network_allocation_multi_updated"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        self.mock_object(self.bind_plugin.neutron_api, \u0027get_network\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_e273a213","line":793,"updated":"2016-05-09 22:22:19.000000000","message":"ditto","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"75384c485e555e506803fe89b0db82ad7f108f36","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            fake_network_allocation_multi_updated"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        self.mock_object(self.bind_plugin.neutron_api, \u0027get_network\u0027)"},{"line_number":797,"context_line":"        self.bind_plugin.neutron_api.get_network.return_value \u003d \\"},{"line_number":798,"context_line":"            fake_neutron_network_multi"},{"line_number":799,"context_line":"        self.mock_object(db_api, \u0027share_network_update\u0027)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_625e9277","line":797,"updated":"2016-05-09 22:22:19.000000000","message":"ditto","commit_id":"9fde962d157484a90d6f2b7b0c6d845b1342b858"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8ab30117bf30a16f5acb842752b0920656798d90","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        self.mock_object(db_api, \u0027network_allocation_create\u0027)"},{"line_number":720,"context_line":"        db_api.network_allocation_create.return_value \u003d fake_network_allocation"},{"line_number":721,"context_line":"        self.mock_object(self.bind_plugin.neutron_api, \u0027get_network\u0027)"},{"line_number":722,"context_line":"        self.bind_plugin.neutron_api.get_network.return_value \u003d \\"},{"line_number":723,"context_line":"            fake_neutron_network"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        with mock.patch.object(self.bind_plugin.neutron_api, \u0027create_port\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_5c3a8535","line":722,"updated":"2016-05-24 21:44:44.000000000","message":"Please use parens for line continuation rather than \u0027\\\u0027 here.\n\nhttp://docs.openstack.org/developer/hacking/\n\nAlso in similar lines below.","commit_id":"96b6222f4ecee268747f6f3f4593d46cfcf080ae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fed646b7755dcf2a948bfd5ccb85179509535bc0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \u0027gateway\u0027: fake_share_network[\u0027gateway\u0027],"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"fake_nw_info \u003d {\u0027segments\u0027: ["},{"line_number":114,"context_line":"    {\u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":115,"context_line":"     \u0027provider:physical_network\u0027: \u0027net1\u0027,"},{"line_number":116,"context_line":"     \u0027provider:segmentation_id\u0027: 3926},"},{"line_number":117,"context_line":"    {\u0027provider:network_type\u0027: \u0027vxlan\u0027,"},{"line_number":118,"context_line":"     \u0027provider:physical_network\u0027: None,"},{"line_number":119,"context_line":"     \u0027provider:segmentation_id\u0027: 2000}]"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"fake_neutron_network_multi \u003d {"},{"line_number":123,"context_line":"    \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_86a3009e","line":120,"range":{"start_line":113,"start_character":0,"end_line":120,"end_character":1},"updated":"2016-07-24 22:47:31.000000000","message":"Dictionary wrapping please: http://docs.openstack.org/developer/hacking/#dictionaries-lists\n\n          \n        fake_nw_info \u003d {\n            \u0027segments\u0027: [\n                {\n                    \u0027provider:network_type\u0027: \u0027vlan\u0027,\n                    \u0027provider:physical_network\u0027: \u0027net1\u0027,\n                    \u0027provider:segmentation_id\u0027: 3926,\n                },\n                {\n                    \u0027provider:network_type\u0027: \u0027vxlan\u0027,\n                    \u0027provider:physical_network\u0027: None,\n                    \u0027provider:segmentation_id\u0027: 2000,\n                },\n            ],\n        }","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \u0027gateway\u0027: fake_share_network[\u0027gateway\u0027],"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"fake_nw_info \u003d {\u0027segments\u0027: ["},{"line_number":114,"context_line":"    {\u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":115,"context_line":"     \u0027provider:physical_network\u0027: \u0027net1\u0027,"},{"line_number":116,"context_line":"     \u0027provider:segmentation_id\u0027: 3926},"},{"line_number":117,"context_line":"    {\u0027provider:network_type\u0027: \u0027vxlan\u0027,"},{"line_number":118,"context_line":"     \u0027provider:physical_network\u0027: None,"},{"line_number":119,"context_line":"     \u0027provider:segmentation_id\u0027: 2000}]"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"fake_neutron_network_multi \u003d {"},{"line_number":123,"context_line":"    \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_a864e2e4","line":120,"range":{"start_line":113,"start_character":0,"end_line":120,"end_character":1},"in_reply_to":"dada55a8_86a3009e","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0d982e9e757bdd1367d88f2791050da90f40a4f2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \u0027segments\u0027: fake_nw_info[\u0027segments\u0027]"},{"line_number":138,"context_line":"}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"fake_share_network_multi \u003d {"},{"line_number":141,"context_line":"    \u0027id\u0027: \u0027fake nw info id\u0027,"},{"line_number":142,"context_line":"    \u0027neutron_subnet_id\u0027: fake_neutron_network_multi[\u0027subnets\u0027][0],"},{"line_number":143,"context_line":"    \u0027neutron_net_id\u0027: fake_neutron_network_multi[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_4dbd6b01","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":24},"updated":"2016-07-06 07:55:09.000000000","message":"I think the gateway is missing for this share network.\nSeems like this is the reason for the failing tests.","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0b0ad533522cac838711ec13683b32b3b064beb6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \u0027segments\u0027: fake_nw_info[\u0027segments\u0027]"},{"line_number":138,"context_line":"}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"fake_share_network_multi \u003d {"},{"line_number":141,"context_line":"    \u0027id\u0027: \u0027fake nw info id\u0027,"},{"line_number":142,"context_line":"    \u0027neutron_subnet_id\u0027: fake_neutron_network_multi[\u0027subnets\u0027][0],"},{"line_number":143,"context_line":"    \u0027neutron_net_id\u0027: fake_neutron_network_multi[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_289f52b5","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":24},"in_reply_to":"1aa78d24_4dbd6b01","updated":"2016-07-29 13:49:54.000000000","message":"Done","commit_id":"361192b042be9fa07587c0552de4e0a9b7adb5bb"}]}
