)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea55ca1bbadaf7928e7457cb3c63dc991cc8e58e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC Isilon Driver Support For CIFS Read-Only Share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support for read-only shares to the CIFS protocol in the Isilon driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0dacb5538071af31cd07a187fead1b34e19db58d"},{"line_number":12,"context_line":"Implements: blueprint emc-isilon-driver-readonly-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bae84128_5c86bc13","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":77},"updated":"2016-02-22 18:27:20.000000000","message":"Please break line if you upload another patch.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC Isilon Driver Support For CIFS Read-Only Share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support for read-only shares to the CIFS protocol in the Isilon driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0dacb5538071af31cd07a187fead1b34e19db58d"},{"line_number":12,"context_line":"Implements: blueprint emc-isilon-driver-readonly-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bae84128_8ae58fdd","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":77},"in_reply_to":"bae84128_5c86bc13","updated":"2016-02-22 23:43:51.000000000","message":"Done","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"}],"manila/share/drivers/emc/plugins/isilon/isilon.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"63519a49759fd0aae334a15453ee0413062cc604","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self._cifs_allow_access_user(access_to, share, access_level)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _cifs_allow_access_ip(self, ip, share, access_level):"},{"line_number":244,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":245,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":246,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":247,"context_line":"            LOG.error(message)"},{"line_number":248,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":251,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":252,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":253,"context_line":"            LOG.error(message)"},{"line_number":254,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":257,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_0c6c7b9b","line":254,"range":{"start_line":244,"start_character":0,"end_line":254,"end_character":62},"updated":"2016-02-13 05:12:38.000000000","message":"I don\u0027t think you meant to duplicate these lines.","commit_id":"bad8cd56f28177e6511085b03ebc87a69314597b"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"f085231545614fb204add5faed32a0e0188c107e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self._cifs_allow_access_user(access_to, share, access_level)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _cifs_allow_access_ip(self, ip, share, access_level):"},{"line_number":244,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":245,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":246,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":247,"context_line":"            LOG.error(message)"},{"line_number":248,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":251,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":252,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":253,"context_line":"            LOG.error(message)"},{"line_number":254,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":257,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_42b3fe97","line":254,"range":{"start_line":244,"start_character":0,"end_line":254,"end_character":62},"in_reply_to":"1a54edaf_0c6c7b9b","updated":"2016-02-19 03:16:37.000000000","message":"Done","commit_id":"bad8cd56f28177e6511085b03ebc87a69314597b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"63519a49759fd0aae334a15453ee0413062cc604","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        denied_ip \u003d access[\u0027access_to\u0027]"},{"line_number":290,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":291,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":292,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":293,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":296,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":297,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # Get list of currently allowed client ips"},{"line_number":300,"context_line":"        export_id \u003d self._isilon_api.lookup_nfs_export("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_ac13e70c","line":297,"range":{"start_line":291,"start_character":0,"end_line":297,"end_character":52},"updated":"2016-02-13 05:12:38.000000000","message":"More duplicated code.","commit_id":"bad8cd56f28177e6511085b03ebc87a69314597b"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"f085231545614fb204add5faed32a0e0188c107e","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        denied_ip \u003d access[\u0027access_to\u0027]"},{"line_number":290,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":291,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":292,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":293,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":296,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":297,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # Get list of currently allowed client ips"},{"line_number":300,"context_line":"        export_id \u003d self._isilon_api.lookup_nfs_export("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ab973eea","line":297,"range":{"start_line":291,"start_character":0,"end_line":297,"end_character":52},"in_reply_to":"1a54edaf_ac13e70c","updated":"2016-02-19 03:16:37.000000000","message":"Done","commit_id":"bad8cd56f28177e6511085b03ebc87a69314597b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea55ca1bbadaf7928e7457cb3c63dc991cc8e58e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            message \u003d _(\u0027Only \"ip\" access type allowed for the NFS\u0027"},{"line_number":200,"context_line":"                        \u0027protocol.\u0027)"},{"line_number":201,"context_line":"            LOG.error(message)"},{"line_number":202,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        export_path \u003d self._get_container_path(share)"},{"line_number":205,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3c13f8b9","line":202,"range":{"start_line":202,"start_character":12,"end_line":202,"end_character":62},"updated":"2016-02-22 18:27:20.000000000","message":"This can be exception.InvalidShareAccess.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            message \u003d _(\u0027Only \"ip\" access type allowed for the NFS\u0027"},{"line_number":200,"context_line":"                        \u0027protocol.\u0027)"},{"line_number":201,"context_line":"            LOG.error(message)"},{"line_number":202,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        export_path \u003d self._get_container_path(share)"},{"line_number":205,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2a19e3d7","line":202,"range":{"start_line":202,"start_character":12,"end_line":202,"end_character":62},"in_reply_to":"bae84128_3c13f8b9","updated":"2016-02-22 23:43:51.000000000","message":"Done","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5cec0f0b04508209cfffbea8bcd65cc748e658ec","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":228,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":229,"context_line":"        if access_type !\u003d \u0027ip\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":230,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":231,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":232,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_71001b02","line":229,"range":{"start_line":229,"start_character":11,"end_line":229,"end_character":56},"updated":"2016-02-22 12:01:43.000000000","message":"\"\"\"\nif access_type not in (\u0027ip\u0027, \u0027user\u0027):\n\"\"\"\n\nBUT, it should be \"else\" clause for below conditions.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":228,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":229,"context_line":"        if access_type !\u003d \u0027ip\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":230,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":231,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":232,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_6ad48bbc","line":229,"range":{"start_line":229,"start_character":11,"end_line":229,"end_character":56},"in_reply_to":"bae84128_71001b02","updated":"2016-02-22 23:43:51.000000000","message":"Refactored if else logic.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea55ca1bbadaf7928e7457cb3c63dc991cc8e58e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":231,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":232,"context_line":"            LOG.error(message)"},{"line_number":233,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":236,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_1c16f4a6","line":233,"range":{"start_line":233,"start_character":12,"end_line":233,"end_character":62},"updated":"2016-02-22 18:27:20.000000000","message":"This can be exception.InvalidShareAccess.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":231,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":232,"context_line":"            LOG.error(message)"},{"line_number":233,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":236,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_eae09b98","line":233,"range":{"start_line":233,"start_character":12,"end_line":233,"end_character":62},"in_reply_to":"bae84128_1c16f4a6","updated":"2016-02-22 23:43:51.000000000","message":"Done","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5cec0f0b04508209cfffbea8bcd65cc748e658ec","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.ro"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._isilon_api.smb_permissions_add(share[\u0027name\u0027], user,"},{"line_number":268,"context_line":"                                             smb_permission)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":271,"context_line":"        \"\"\"Deny access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_b1de233d","line":268,"range":{"start_line":268,"start_character":45,"end_line":268,"end_character":59},"updated":"2016-02-22 12:01:43.000000000","message":"Potential NameError when access_level not passes any of two above conditions. Code should be safer.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea55ca1bbadaf7928e7457cb3c63dc991cc8e58e","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.ro"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._isilon_api.smb_permissions_add(share[\u0027name\u0027], user,"},{"line_number":268,"context_line":"                                             smb_permission)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":271,"context_line":"        \"\"\"Deny access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_9c504460","line":268,"range":{"start_line":268,"start_character":45,"end_line":268,"end_character":59},"in_reply_to":"bae84128_b1de233d","updated":"2016-02-22 18:27:20.000000000","message":"+1","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.ro"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._isilon_api.smb_permissions_add(share[\u0027name\u0027], user,"},{"line_number":268,"context_line":"                                             smb_permission)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":271,"context_line":"        \"\"\"Deny access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_c52828e5","line":268,"range":{"start_line":268,"start_character":45,"end_line":268,"end_character":59},"in_reply_to":"bae84128_b1de233d","updated":"2016-02-22 23:43:51.000000000","message":"Done","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea55ca1bbadaf7928e7457cb3c63dc991cc8e58e","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                        \u0027\"%(access_type)s\". Only \"user\" and \"ip\" access types \u0027"},{"line_number":336,"context_line":"                        \u0027are supported for CIFS protocol access.\u0027) % {"},{"line_number":337,"context_line":"                \u0027access_type\u0027: access_type}"},{"line_number":338,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _cifs_deny_access_ip(self, denied_ip, share):"},{"line_number":341,"context_line":"        \"\"\"Deny access to cifs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_7c6e2002","line":338,"range":{"start_line":338,"start_character":12,"end_line":338,"end_character":62},"updated":"2016-02-22 18:27:20.000000000","message":"If you throw an exception here, your driver will never be able to remove this rule if it is type is incorrect. You need to allow the method to end gracefully (it is a good idea to print a warning message) so it is removed from DB by manager afterwards.","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"ba333dc296a5d7295ab4346ec7ece3de27817446","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                        \u0027\"%(access_type)s\". Only \"user\" and \"ip\" access types \u0027"},{"line_number":336,"context_line":"                        \u0027are supported for CIFS protocol access.\u0027) % {"},{"line_number":337,"context_line":"                \u0027access_type\u0027: access_type}"},{"line_number":338,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _cifs_deny_access_ip(self, denied_ip, share):"},{"line_number":341,"context_line":"        \"\"\"Deny access to cifs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_1abd4a02","line":338,"range":{"start_line":338,"start_character":12,"end_line":338,"end_character":62},"in_reply_to":"bae84128_7c6e2002","updated":"2016-02-22 23:43:51.000000000","message":"Done","commit_id":"3c63290a156b179a38904ffb2b206b2a32e532fc"}],"manila/share/drivers/emc/plugins/isilon/isilon_api.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7ca1b7d0bca169b6f86ef6438c9f02fddcfdd985","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        auth_mappings \u003d user_json[\u0027mapping\u0027]"},{"line_number":275,"context_line":"        if len(auth_mappings) \u003e 1:"},{"line_number":276,"context_line":"            message \u003d _(\u0027More than one mapping found for user \"%(user)s\". \u0027"},{"line_number":277,"context_line":"                        \u0027\u0027) % {\u0027user\u0027: user}"},{"line_number":278,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":279,"context_line":"        user_sid \u003d auth_mappings[0][\u0027user\u0027][\u0027sid\u0027]"},{"line_number":280,"context_line":"        new_permission \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_20c97fad","line":277,"range":{"start_line":277,"start_character":24,"end_line":277,"end_character":27},"updated":"2016-02-19 05:02:31.000000000","message":"Is this empty string necessary?","commit_id":"711b44cdf2072428022b397a0c08deef5a215453"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5f4fbabf928647627aecf546af5e3e70533e9562","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        auth_mappings \u003d user_json[\u0027mapping\u0027]"},{"line_number":275,"context_line":"        if len(auth_mappings) \u003e 1:"},{"line_number":276,"context_line":"            message \u003d _(\u0027More than one mapping found for user \"%(user)s\". \u0027"},{"line_number":277,"context_line":"                        \u0027\u0027) % {\u0027user\u0027: user}"},{"line_number":278,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":279,"context_line":"        user_sid \u003d auth_mappings[0][\u0027user\u0027][\u0027sid\u0027]"},{"line_number":280,"context_line":"        new_permission \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_b0b4a4f2","line":277,"range":{"start_line":277,"start_character":24,"end_line":277,"end_character":27},"in_reply_to":"dae33548_20c97fad","updated":"2016-02-19 20:01:27.000000000","message":"Removed the empty string and wrapped the statement in parenthesis","commit_id":"711b44cdf2072428022b397a0c08deef5a215453"}],"manila/tests/share/drivers/emc/plugins/isilon/test_isilon.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7ca1b7d0bca169b6f86ef6438c9f02fddcfdd985","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_deny_access_nfs_share_does_not_contain_required_key(self):"},{"line_number":283,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":284,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.0.0.1\u0027,"},{"line_number":285,"context_line":"                  \u0027access_level\u0027: const.ACCESS_LEVEL_RW}"},{"line_number":286,"context_line":"        self._mock_isilon_api.get_nfs_export.return_value \u003d {}"},{"line_number":287,"context_line":"        self.assertRaises(exception.ShareBackendException,"},{"line_number":288,"context_line":"                          self.storage_connection.deny_access,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_e05cb7f2","line":285,"range":{"start_line":284,"start_character":8,"end_line":285,"end_character":56},"updated":"2016-02-19 05:02:31.000000000","message":"Please see the guidelines for wrapping multi-line lists \u0026 dicts:\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"711b44cdf2072428022b397a0c08deef5a215453"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5f4fbabf928647627aecf546af5e3e70533e9562","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_deny_access_nfs_share_does_not_contain_required_key(self):"},{"line_number":283,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":284,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.0.0.1\u0027,"},{"line_number":285,"context_line":"                  \u0027access_level\u0027: const.ACCESS_LEVEL_RW}"},{"line_number":286,"context_line":"        self._mock_isilon_api.get_nfs_export.return_value \u003d {}"},{"line_number":287,"context_line":"        self.assertRaises(exception.ShareBackendException,"},{"line_number":288,"context_line":"                          self.storage_connection.deny_access,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_d0796831","line":285,"range":{"start_line":284,"start_character":8,"end_line":285,"end_character":56},"in_reply_to":"dae33548_e05cb7f2","updated":"2016-02-19 20:01:27.000000000","message":"Done","commit_id":"711b44cdf2072428022b397a0c08deef5a215453"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"38a71920a78f7ca10a1743e0ddd3b19e99260441","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def test_allow_access_with_cifs_user_invalid_access_level(self):"},{"line_number":420,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027CIFS\u0027}"},{"line_number":421,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027user\u0027,"},{"line_number":422,"context_line":"                  \u0027access_to\u0027: \u0027foo\u0027,"},{"line_number":423,"context_line":"                  \u0027access_level\u0027: \u0027everything\u0027}"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_0102fd0a","line":421,"range":{"start_line":421,"start_character":19,"end_line":421,"end_character":30},"updated":"2016-02-23 02:12:54.000000000","message":"wrapping again...","commit_id":"3ce786443dfd92689b1e8911f4bc4cb34ab8b601"}]}
