)]}'
{"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"e0dd50c5783cca437899251cfb3ca28d8f077d6b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":64,"context_line":"|             Oracle ZFSSA               |      DHSS \u003d False (K)       |          \\-           |      \\-      |      \\-      |            K           |              K             |"},{"line_number":65,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":66,"context_line":"|                 Tegile                 |      DHSS \u003d False (M)       |          \\-           |      \\-      |      \\-      |            M           |              M             |"},{"line_number":67,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_56775f9f","line":66,"range":{"start_line":66,"start_character":102,"end_line":66,"end_character":120},"updated":"2016-02-18 11:26:01.000000000","message":"According to the driver code, looks like extend and shrink is supported. Please update.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":63,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":64,"context_line":"|             Oracle ZFSSA               |      DHSS \u003d False (K)       |          \\-           |      \\-      |      \\-      |            K           |              K             |"},{"line_number":65,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":66,"context_line":"|                 Tegile                 |      DHSS \u003d False (M)       |          \\-           |      \\-      |      \\-      |            M           |              M             |"},{"line_number":67,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_834e3c94","line":66,"range":{"start_line":66,"start_character":102,"end_line":66,"end_character":120},"in_reply_to":"dae33548_56775f9f","updated":"2016-02-22 10:53:30.000000000","message":"+1","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":63,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":64,"context_line":"|             Oracle ZFSSA               |      DHSS \u003d False (K)       |          \\-           |      \\-      |      \\-      |            K           |              K             |"},{"line_number":65,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":66,"context_line":"|                 Tegile                 |      DHSS \u003d False (M)       |          \\-           |      \\-      |      \\-      |            M           |              M             |"},{"line_number":67,"context_line":"+----------------------------------------+-----------------------------+-----------------------+--------------+--------------+------------------------+----------------------------+"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_f77c5e22","line":66,"range":{"start_line":66,"start_character":102,"end_line":66,"end_character":120},"in_reply_to":"dae33548_56775f9f","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"}],"doc/source/devref/tegile.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb2d6623f9a3261029b53f86e98cf094fb56a6f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * USER access type is supported for NFS and CIFS"},{"line_number":45,"context_line":"* Create snapshot"},{"line_number":46,"context_line":"* Delete snapshot"},{"line_number":47,"context_line":"* Create share from snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Backend Configuration"},{"line_number":50,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_f4be6bac","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":28},"updated":"2016-02-18 12:14:20.000000000","message":"Extend/Shrink are implemented. Shouldn\u0027t they be listed here?","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * USER access type is supported for NFS and CIFS"},{"line_number":45,"context_line":"* Create snapshot"},{"line_number":46,"context_line":"* Delete snapshot"},{"line_number":47,"context_line":"* Create share from snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Backend Configuration"},{"line_number":50,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_0374eccc","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":28},"in_reply_to":"dae33548_f4be6bac","updated":"2016-02-22 10:53:30.000000000","message":"+1","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * USER access type is supported for NFS and CIFS"},{"line_number":45,"context_line":"* Create snapshot"},{"line_number":46,"context_line":"* Delete snapshot"},{"line_number":47,"context_line":"* Create share from snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Backend Configuration"},{"line_number":50,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_778fae23","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":28},"in_reply_to":"dae33548_f4be6bac","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"}],"doc/source/devref/tegile_driver.rst":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"867d52809a6a12b9581a4dad7682d55ae52236c7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Backend Configuration"},{"line_number":52,"context_line":"---------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The following parameters need to be configured in the manila configuration file"},{"line_number":55,"context_line":"for the Tegile driver:"},{"line_number":56,"context_line":"* share_driver \u003d manila.share.drivers.tegile.tegile.TegileShareDriver"},{"line_number":57,"context_line":"* driver_handles_share_servers \u003d False"},{"line_number":58,"context_line":"* tegile_nas_server \u003d \u003ctegile-server-ip-or-hostname\u003e"},{"line_number":59,"context_line":"* tegile_nas_login \u003d \u003ctegile-login-username\u003e"},{"line_number":60,"context_line":"* tegile_nas_password \u003d \u003ctegile-login-password\u003e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Restart of :term:`manila-share` service is needed for the configuration changes"},{"line_number":63,"context_line":"to take effect."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_4ae59935","line":60,"range":{"start_line":54,"start_character":0,"end_line":60,"end_character":47},"updated":"2016-03-02 00:29:44.000000000","message":"This section isn\u0027t rendered correctly in the output.  You can see it in the Jenkins job gate-manila-docs.","commit_id":"8a4549307caf6e3cccf7bfec6df41196144b81f1"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":81,"context_line":"|   driver_handles_share_servers| DHSS, Driver working mode. For Tegile driver **this must be**:                                      |"},{"line_number":82,"context_line":"|                               | *False*.                                                                                            |"},{"line_number":83,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"},{"line_number":84,"context_line":"|   tegile_nas_server           | Tegile array IP  to connect from the Manila node.                                                   |"},{"line_number":85,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"},{"line_number":86,"context_line":"|   tegile_nas_login            | This field is used to provide username credential to Tegile array.                                  |"},{"line_number":87,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7af24918_70062a87","line":84,"range":{"start_line":84,"start_character":50,"end_line":84,"end_character":51},"updated":"2016-03-03 07:46:32.000000000","message":"extra space","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"|   driver_handles_share_servers| DHSS, Driver working mode. For Tegile driver **this must be**:                                      |"},{"line_number":82,"context_line":"|                               | *False*.                                                                                            |"},{"line_number":83,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"},{"line_number":84,"context_line":"|   tegile_nas_server           | Tegile array IP  to connect from the Manila node.                                                   |"},{"line_number":85,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"},{"line_number":86,"context_line":"|   tegile_nas_login            | This field is used to provide username credential to Tegile array.                                  |"},{"line_number":87,"context_line":"+-------------------------------+-----------------------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7af24918_d76badef","line":84,"range":{"start_line":84,"start_character":50,"end_line":84,"end_character":51},"in_reply_to":"7af24918_70062a87","updated":"2016-03-03 09:25:09.000000000","message":"fixed","commit_id":"35fc112c188066d277687b27888caa9e8a987118"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# Tegile Storage drivers"},{"line_number":733,"context_line":"class TegileAPIException(ShareBackendException):"},{"line_number":734,"context_line":"    message \u003d _(\"Unexpected response from Tegile IntelliFlash API\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_993a3d97","line":734,"range":{"start_line":734,"start_character":65,"end_line":734,"end_character":67},"updated":"2016-02-22 02:37:49.000000000","message":"Could you require the response by saying:\n    \n    message \u003d _(\"Unexpected response from Tegile IntelliFlash API: %(response)s\")","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# Tegile Storage drivers"},{"line_number":733,"context_line":"class TegileAPIException(ShareBackendException):"},{"line_number":734,"context_line":"    message \u003d _(\"Unexpected response from Tegile IntelliFlash API\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_e36e2800","line":734,"range":{"start_line":734,"start_character":65,"end_line":734,"end_character":67},"in_reply_to":"bae84128_993a3d97","updated":"2016-02-22 10:53:30.000000000","message":"+1","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# Tegile Storage drivers"},{"line_number":733,"context_line":"class TegileAPIException(ShareBackendException):"},{"line_number":734,"context_line":"    message \u003d _(\"Unexpected response from Tegile IntelliFlash API\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f7a3be9c","line":734,"range":{"start_line":734,"start_character":65,"end_line":734,"end_character":67},"in_reply_to":"bae84128_993a3d97","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"}],"manila/share/drivers/tegile.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF.register_opts(tegile_opts)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":47,"context_line":"default_api_service \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":"TEGILE_API_PATH \u003d \u0027zebi/api\u0027"},{"line_number":49,"context_line":"TEGILE_LOCAL_CONTAINER_NAME \u003d \u0027Local\u0027"},{"line_number":50,"context_line":"TEGILE_SNAPSHOT_PREFIX \u003d \u0027Manual-S-\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_52fa6844","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":19},"updated":"2016-02-12 10:48:29.000000000","message":"Why this is in lower case when all other in upper?","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF.register_opts(tegile_opts)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":47,"context_line":"default_api_service \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":"TEGILE_API_PATH \u003d \u0027zebi/api\u0027"},{"line_number":49,"context_line":"TEGILE_LOCAL_CONTAINER_NAME \u003d \u0027Local\u0027"},{"line_number":50,"context_line":"TEGILE_SNAPSHOT_PREFIX \u003d \u0027Manual-S-\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_ddec35bd","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":19},"in_reply_to":"3a57f1b5_52fa6844","updated":"2016-02-18 09:48:59.000000000","message":"Changed.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2bd85c142b0864b0a40e124418a2dd5fe766358b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"class TegileShareDriver(driver.ShareDriver):"},{"line_number":149,"context_line":"    \"\"\"Tegile NAS driver. Allows for NFS and CIFS NAS storage usage.\"\"\""},{"line_number":150,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":151,"context_line":"        super(TegileShareDriver, self).__init__(False,"},{"line_number":152,"context_line":"                                                *args,"},{"line_number":153,"context_line":"                                                **kwargs)"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a54edaf_69ce415c","line":151,"range":{"start_line":151,"start_character":48,"end_line":151,"end_character":53},"updated":"2016-02-13 04:13:13.000000000","message":"No need to wrap this line.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"class TegileShareDriver(driver.ShareDriver):"},{"line_number":149,"context_line":"    \"\"\"Tegile NAS driver. Allows for NFS and CIFS NAS storage usage.\"\"\""},{"line_number":150,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":151,"context_line":"        super(TegileShareDriver, self).__init__(False,"},{"line_number":152,"context_line":"                                                *args,"},{"line_number":153,"context_line":"                                                **kwargs)"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_1d7fbde0","line":151,"range":{"start_line":151,"start_character":48,"end_line":151,"end_character":53},"in_reply_to":"1a54edaf_69ce415c","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        params \u003d list()"},{"line_number":178,"context_line":"        params.append(pool_name)"},{"line_number":179,"context_line":"        params.append(self._default_project)"},{"line_number":180,"context_line":"        params.append(share_name)"},{"line_number":181,"context_line":"        params.append(share_proto)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        ip \u003d self._api_executor.send_api_request(method\u003d\u0027createShare\u0027,"},{"line_number":184,"context_line":"                                                 params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_12bcf0da","line":181,"range":{"start_line":177,"start_character":8,"end_line":181,"end_character":34},"updated":"2016-02-12 10:48:29.000000000","message":"This is slow init of data container. In your case you do not really need a list and perform \"append\" operations.\n\nMuch faster solution would be following:\n\n\"\"\"\nparams \u003d (pool_name, self._default_project, share_name, share_proto)\n\"\"\"\n\nWere:\n1) Used list class init, that is 3 times slower than list comprehension init\n\n2) Used list when tuple can be used that 10 times faster than list.\n\n3) Used \"append\" operations without need. Its data could be used in init.\n\nCompletely the same valid for whole driver code.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        params \u003d list()"},{"line_number":178,"context_line":"        params.append(pool_name)"},{"line_number":179,"context_line":"        params.append(self._default_project)"},{"line_number":180,"context_line":"        params.append(share_name)"},{"line_number":181,"context_line":"        params.append(share_proto)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        ip \u003d self._api_executor.send_api_request(method\u003d\u0027createShare\u0027,"},{"line_number":184,"context_line":"                                                 params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_3d63a143","line":181,"range":{"start_line":177,"start_character":8,"end_line":181,"end_character":34},"in_reply_to":"3a57f1b5_12bcf0da","updated":"2016-02-18 09:48:59.000000000","message":"Changed for this and all other similar lines.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        params.append(share_name)"},{"line_number":181,"context_line":"        params.append(share_proto)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        ip \u003d self._api_executor.send_api_request(method\u003d\u0027createShare\u0027,"},{"line_number":184,"context_line":"                                                 params\u003dparams)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d2e418e1","line":183,"range":{"start_line":183,"start_character":13,"end_line":183,"end_character":31},"updated":"2016-02-12 10:48:29.000000000","message":"I would make alias for \"self._api_executor\", for example \"self.api\".\n\nAnd for \"send_api_request\" make a method \"__call__\" in \"TegileAPIExecutor\" class and call its instance as following:\n\nclass TegileAPIExecutor(object):\n    ...\n\n    def __call__(self, *args, **kwargs):\n        return self.send_api_request(*args, **kwargs)\n\n\nclass TegileShareDriver(driver.ShareDriver):\n    ...\n\n    @debugger\n    def create_share(self, context, share, share_server\u003dNone):\n        \"\"\"Is called to create share.\"\"\"\n        share_name \u003d share[\u0027name\u0027]\n        share_proto \u003d share[\u0027share_proto\u0027]\n\n        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)\n\n        params \u003d (pool_name, self._default_project, share_name, share_proto)\n\n        ip \u003d self.api(method\u003d\u0027createShare\u0027, params\u003dparams)\n\n        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),\n                 {\u0027sharename\u0027: share_name, \u0027shid\u0027: share[\u0027id\u0027]})\n\n        return self._get_location_path(share_name, share_proto, ip)","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        params.append(share_name)"},{"line_number":181,"context_line":"        params.append(share_proto)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        ip \u003d self._api_executor.send_api_request(method\u003d\u0027createShare\u0027,"},{"line_number":184,"context_line":"                                                 params\u003dparams)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_7d59a98d","line":183,"range":{"start_line":183,"start_character":13,"end_line":183,"end_character":31},"in_reply_to":"3a57f1b5_d2e418e1","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        There is no shrink for Tegile shares."},{"line_number":215,"context_line":"        We just adjust the quotas. The API is still called \u0027resizeShare\u0027."},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        self.extend_share(shrink_share, shrink_size, share_server)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @debugger"},{"line_number":220,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_678ec8d1","line":217,"range":{"start_line":217,"start_character":8,"end_line":217,"end_character":66},"updated":"2016-02-12 10:48:29.000000000","message":"Don\u0027t you need to perform current usage validation? What happens if used more than new size set?","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        There is no shrink for Tegile shares."},{"line_number":215,"context_line":"        We just adjust the quotas. The API is still called \u0027resizeShare\u0027."},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        self.extend_share(shrink_share, shrink_size, share_server)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @debugger"},{"line_number":220,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_5db82575","line":217,"range":{"start_line":217,"start_character":8,"end_line":217,"end_character":66},"in_reply_to":"3a57f1b5_678ec8d1","updated":"2016-02-18 09:48:59.000000000","message":"I am calling the backend API to adjust the quota, if there is an error, it will come here as an exception. Because it is not a actual shrink operation, in the support doc, I am not marking that Tegile support resize/shrink.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":332,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":333,"context_line":"            return"},{"line_number":334,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":335,"context_line":"            LOG.warning(_LW(\u0027Only USER access type is allowed for\u0027"},{"line_number":336,"context_line":"                            \u0027 NFS shares.\u0027))"},{"line_number":337,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_2d06711d","line":334,"range":{"start_line":334,"start_character":13,"end_line":334,"end_character":60},"updated":"2016-02-12 10:48:29.000000000","message":"Really? Ip access not supported for NFS? But supported for CIFS? Is this driver from parallel universe? Or here is some bug?","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":332,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":333,"context_line":"            return"},{"line_number":334,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":335,"context_line":"            LOG.warning(_LW(\u0027Only USER access type is allowed for\u0027"},{"line_number":336,"context_line":"                            \u0027 NFS shares.\u0027))"},{"line_number":337,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_a0c2e682","line":334,"range":{"start_line":334,"start_character":13,"end_line":334,"end_character":60},"in_reply_to":"3a57f1b5_2d06711d","updated":"2016-02-18 09:48:59.000000000","message":"Tegile has capability to support NFS and CIFS both ip and user and both rw/ro modes. When I originally posted this, I was having some issues with NFS and ip mode. I thought 2/11 was deadline for the driver code so I disabled it in the python side to avoid shipping with a potential problem. I figured what the problem was and everything is fine now.\n\nBut I am taking away the CIFS ip access because we are not officially supporting it yet (although it seems to work fine in my tests)\n\nSo we what we have now is ip allow/deny access for NFS and user allow/deny access for nfs and cifs.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":358,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":361,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":362,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":363,"context_line":"            return"},{"line_number":364,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":365,"context_line":"            LOG.warning(_LW(\u0027Only USER access type is allowed for\u0027"},{"line_number":366,"context_line":"                            \u0027 NFS shares.\u0027))"},{"line_number":367,"context_line":"            return"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        params \u003d []"},{"line_number":370,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_6d2f8988","line":367,"range":{"start_line":360,"start_character":8,"end_line":367,"end_character":18},"updated":"2016-02-12 10:48:29.000000000","message":"It is code duplication from above.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":358,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":361,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":362,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":363,"context_line":"            return"},{"line_number":364,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":365,"context_line":"            LOG.warning(_LW(\u0027Only USER access type is allowed for\u0027"},{"line_number":366,"context_line":"                            \u0027 NFS shares.\u0027))"},{"line_number":367,"context_line":"            return"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        params \u003d []"},{"line_number":370,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_e0b86e13","line":367,"range":{"start_line":360,"start_character":8,"end_line":367,"end_character":18},"in_reply_to":"3a57f1b5_6d2f8988","updated":"2016-02-18 09:48:59.000000000","message":"It is required here too, right?","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2bd85c142b0864b0a40e124418a2dd5fe766358b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            # fixing values coming back here as String to float"},{"line_number":391,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d float(data.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":392,"context_line":"            data[\u0027free_capacity_gb\u0027] \u003d float(data.get(\u0027free_capacity_gb\u0027, 0))"},{"line_number":393,"context_line":"            for pool in data.get(\u0027pools\u0027, []):"},{"line_number":394,"context_line":"                pool[\u0027total_capacity_gb\u0027] \u003d float("},{"line_number":395,"context_line":"                    pool.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":396,"context_line":"                pool[\u0027free_capacity_gb\u0027] \u003d float("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a54edaf_493fc525","line":393,"range":{"start_line":393,"start_character":16,"end_line":393,"end_character":20},"updated":"2016-02-13 04:13:13.000000000","message":"Where do you actually add the pools to the share stats array?  And did you really intend to include all pool data returned from your getArrayStats call in what you send to the Manila scheduler?  How much data is that?","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            # fixing values coming back here as String to float"},{"line_number":391,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d float(data.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":392,"context_line":"            data[\u0027free_capacity_gb\u0027] \u003d float(data.get(\u0027free_capacity_gb\u0027, 0))"},{"line_number":393,"context_line":"            for pool in data.get(\u0027pools\u0027, []):"},{"line_number":394,"context_line":"                pool[\u0027total_capacity_gb\u0027] \u003d float("},{"line_number":395,"context_line":"                    pool.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":396,"context_line":"                pool[\u0027free_capacity_gb\u0027] \u003d float("}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_009f525f","line":393,"range":{"start_line":393,"start_character":16,"end_line":393,"end_character":20},"in_reply_to":"1a54edaf_493fc525","updated":"2016-02-18 09:48:59.000000000","message":"From the API above  - getArrayStats. I don\u0027t think it is too much data. test_tegile.py has a variable \u0027arrays_stats\u0027 that gives a sample output of the variable. That is ~780 bytes.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            data[\u0027qos\u0027] \u003d False"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":416,"context_line":"        except Exception as e:"},{"line_number":417,"context_line":"            LOG.warning(_LW(\u0027%(clsname)s \u0027"},{"line_number":418,"context_line":"                            \u0027_update_share_stats failed: %(error)s\u0027),"},{"line_number":419,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":420,"context_line":"                         \u0027error\u0027: e})"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    @debugger"},{"line_number":423,"context_line":"    def get_pool(self, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_ed7059a6","line":420,"range":{"start_line":416,"start_character":8,"end_line":420,"end_character":37},"updated":"2016-02-12 10:48:29.000000000","message":"Share stats update error should not be suppressed with just logging warning. Exception should be raised anyway.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            data[\u0027qos\u0027] \u003d False"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":416,"context_line":"        except Exception as e:"},{"line_number":417,"context_line":"            LOG.warning(_LW(\u0027%(clsname)s \u0027"},{"line_number":418,"context_line":"                            \u0027_update_share_stats failed: %(error)s\u0027),"},{"line_number":419,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":420,"context_line":"                         \u0027error\u0027: e})"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    @debugger"},{"line_number":423,"context_line":"    def get_pool(self, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_408b1a1f","line":420,"range":{"start_line":416,"start_character":8,"end_line":420,"end_character":37},"in_reply_to":"3a57f1b5_ed7059a6","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        \"\"\"Get number of network interfaces to be created.\"\"\""},{"line_number":435,"context_line":"        return 0"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @debugger"},{"line_number":438,"context_line":"    def _setup_server(self, network_info, metadata\u003dNone):"},{"line_number":439,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":440,"context_line":"        raise NotImplementedError()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @debugger"},{"line_number":443,"context_line":"    def _teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":444,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":445,"context_line":"        raise NotImplementedError()"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    @debugger"},{"line_number":448,"context_line":"    def _get_location_path(self, share_name, share_proto, ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_4db72d3a","line":445,"range":{"start_line":437,"start_character":4,"end_line":445,"end_character":35},"updated":"2016-02-12 10:48:29.000000000","message":"These should be removed.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        \"\"\"Get number of network interfaces to be created.\"\"\""},{"line_number":435,"context_line":"        return 0"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @debugger"},{"line_number":438,"context_line":"    def _setup_server(self, network_info, metadata\u003dNone):"},{"line_number":439,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":440,"context_line":"        raise NotImplementedError()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @debugger"},{"line_number":443,"context_line":"    def _teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":444,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":445,"context_line":"        raise NotImplementedError()"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    @debugger"},{"line_number":448,"context_line":"    def _get_location_path(self, share_name, share_proto, ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_208ed62d","line":445,"range":{"start_line":437,"start_character":4,"end_line":445,"end_character":35},"in_reply_to":"3a57f1b5_4db72d3a","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2bd85c142b0864b0a40e124418a2dd5fe766358b","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":452,"context_line":"            location \u003d \u0027%s:%s\u0027 % (ip, share_name)"},{"line_number":453,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":454,"context_line":"            location \u003d \u0027\\\\\\\\%s\\\\%s\u0027 % (ip, share_name)"},{"line_number":455,"context_line":"        else:"},{"line_number":456,"context_line":"            message \u003d _(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto"},{"line_number":457,"context_line":"            raise exception.InvalidInput(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a54edaf_4995853e","line":454,"range":{"start_line":454,"start_character":23,"end_line":454,"end_character":29},"updated":"2016-02-13 04:13:13.000000000","message":"Here you could use:\n\n    location \u003d r\u0027\\\\%s\\%s\u0027 % (ip, share_name)","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":452,"context_line":"            location \u003d \u0027%s:%s\u0027 % (ip, share_name)"},{"line_number":453,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":454,"context_line":"            location \u003d \u0027\\\\\\\\%s\\\\%s\u0027 % (ip, share_name)"},{"line_number":455,"context_line":"        else:"},{"line_number":456,"context_line":"            message \u003d _(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto"},{"line_number":457,"context_line":"            raise exception.InvalidInput(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_8081a2fd","line":454,"range":{"start_line":454,"start_character":23,"end_line":454,"end_character":29},"in_reply_to":"1a54edaf_4995853e","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2bd85c142b0864b0a40e124418a2dd5fe766358b","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    @debugger"},{"line_number":462,"context_line":"    def _get_pool_project_share_name(self, share):"},{"line_number":463,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027],"},{"line_number":464,"context_line":"                                        level\u003d\u0027pool\u0027)"},{"line_number":465,"context_line":"        project \u003d self._default_project"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a54edaf_e916b1a6","line":463,"range":{"start_line":463,"start_character":40,"end_line":463,"end_character":45},"updated":"2016-02-13 04:13:13.000000000","message":"No need to wrap here.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    @debugger"},{"line_number":462,"context_line":"    def _get_pool_project_share_name(self, share):"},{"line_number":463,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027],"},{"line_number":464,"context_line":"                                        level\u003d\u0027pool\u0027)"},{"line_number":465,"context_line":"        project \u003d self._default_project"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_60845e0a","line":463,"range":{"start_line":463,"start_character":40,"end_line":463,"end_character":45},"in_reply_to":"1a54edaf_e916b1a6","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"}],"manila/share/drivers/tegile/tegile.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb2d6623f9a3261029b53f86e98cf094fb56a6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 by Tegile Systems, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_74853bcd","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-02-18 12:14:20.000000000","message":"patch was first uploaded in 2016.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 by Tegile Systems, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_035b4c55","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dae33548_74853bcd","updated":"2016-02-22 10:53:30.000000000","message":"+1","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 by Tegile Systems, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_17abca75","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dae33548_74853bcd","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb2d6623f9a3261029b53f86e98cf094fb56a6f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def debugger(func):"},{"line_number":57,"context_line":"    \"\"\"Returns a wrapper that wraps func."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    The wrapper will log the entry and exit points of the function"},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def wrapper(*args, **kwds):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_ef45f242","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":66},"updated":"2016-02-18 12:14:20.000000000","message":"add a period.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def debugger(func):"},{"line_number":57,"context_line":"    \"\"\"Returns a wrapper that wraps func."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    The wrapper will log the entry and exit points of the function"},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def wrapper(*args, **kwds):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b7b016df","line":59,"range":{"start_line":59,"start_character":65,"end_line":59,"end_character":66},"in_reply_to":"dae33548_ef45f242","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           \u0027method\u0027: method,"},{"line_number":139,"context_line":"                           \u0027response\u0027: response})"},{"line_number":140,"context_line":"        except ValueError:"},{"line_number":141,"context_line":"            response \u003d \u0027\u0027"},{"line_number":142,"context_line":"        req.close()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if req.status_code !\u003d 200:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_7f07591c","line":141,"range":{"start_line":141,"start_character":23,"end_line":141,"end_character":25},"updated":"2016-02-22 02:37:49.000000000","message":"Needs an explanation..","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           \u0027method\u0027: method,"},{"line_number":139,"context_line":"                           \u0027response\u0027: response})"},{"line_number":140,"context_line":"        except ValueError:"},{"line_number":141,"context_line":"            response \u003d \u0027\u0027"},{"line_number":142,"context_line":"        req.close()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if req.status_code !\u003d 200:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_37c5263c","line":141,"range":{"start_line":141,"start_character":23,"end_line":141,"end_character":25},"in_reply_to":"bae84128_7f07591c","updated":"2016-03-01 19:50:03.000000000","message":"Added comment","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if req.status_code !\u003d 200:"},{"line_number":145,"context_line":"            msg \u003d _(\u0027API response: %(response)s\u0027) % {\u0027response\u0027: response}"},{"line_number":146,"context_line":"            raise exception.TegileAPIException(msg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return response"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_3f0dd13e","line":146,"range":{"start_line":146,"start_character":47,"end_line":146,"end_character":50},"updated":"2016-02-22 02:37:49.000000000","message":"If you made the change suggested in exception.py, this would be:\n\n    response\u003dresponse","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if req.status_code !\u003d 200:"},{"line_number":145,"context_line":"            msg \u003d _(\u0027API response: %(response)s\u0027) % {\u0027response\u0027: response}"},{"line_number":146,"context_line":"            raise exception.TegileAPIException(msg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return response"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_e313c864","line":146,"range":{"start_line":146,"start_character":47,"end_line":146,"end_character":50},"in_reply_to":"bae84128_3f0dd13e","updated":"2016-02-22 10:53:30.000000000","message":"+1","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if req.status_code !\u003d 200:"},{"line_number":145,"context_line":"            msg \u003d _(\u0027API response: %(response)s\u0027) % {\u0027response\u0027: response}"},{"line_number":146,"context_line":"            raise exception.TegileAPIException(msg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return response"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b7e776e3","line":146,"range":{"start_line":146,"start_character":47,"end_line":146,"end_character":50},"in_reply_to":"bae84128_3f0dd13e","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":154,"context_line":"        super(TegileShareDriver, self).__init__(False, *args, **kwargs)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_2e60f700","line":156,"range":{"start_line":156,"start_character":55,"end_line":156,"end_character":61},"updated":"2016-02-22 10:53:30.000000000","message":"\"None\" is redundant.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":154,"context_line":"        super(TegileShareDriver, self).__init__(False, *args, **kwargs)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f7d1fefc","line":156,"range":{"start_line":156,"start_character":55,"end_line":156,"end_character":61},"in_reply_to":"bae84128_2e60f700","updated":"2016-03-01 19:50:03.000000000","message":"removed","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        super(TegileShareDriver, self).__init__(False, *args, **kwargs)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ce486b8a","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":60},"updated":"2016-02-22 10:53:30.000000000","message":"Line 157 will fail if line 156 returns None. So, this single code block introduces bug for itself.\n\nFor the moment, your code tied on usage of \"self.configuration\".\n\nIt means:\n\n- line 44, registration in DEFAULT config group is redundant.\n- __init__ method should fail explicitly when configuration is absent or be able to use opts from common config (use line 44), not only \"self.configuration\".","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        super(TegileShareDriver, self).__init__(False, *args, **kwargs)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_97035a73","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":60},"in_reply_to":"bae84128_ce486b8a","updated":"2016-03-01 19:50:03.000000000","message":"I fixed it based on what I understood - I am following what all the others are doing in their drivers","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"},{"line_number":161,"context_line":"            \u0027openstack\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_aeefe785","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":64},"updated":"2016-02-22 10:53:30.000000000","message":"Why do you register these opts when they are not used in your driver?","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027, None)"},{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"},{"line_number":161,"context_line":"            \u0027openstack\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_d7f5e283","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":64},"in_reply_to":"bae84128_aeefe785","updated":"2016-03-01 19:50:03.000000000","message":"removed","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"},{"line_number":161,"context_line":"            \u0027openstack\u0027)"},{"line_number":162,"context_line":"        self._hostname \u003d getattr(self.configuration, \u0027tegile_nas_server\u0027)"},{"line_number":163,"context_line":"        username \u003d getattr(self.configuration, \u0027tegile_nas_login\u0027)"},{"line_number":164,"context_line":"        password \u003d getattr(self.configuration, \u0027tegile_nas_password\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_2e3c77c7","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":24},"updated":"2016-02-22 10:53:30.000000000","message":"self.configuration.safe_get(\"tegile_default_project\") or \u0027foo\u0027\n\nSame for other such occurrences.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.configuration.append_config_values(tegile_opts)"},{"line_number":158,"context_line":"        self.configuration.append_config_values(driver.ssh_opts)"},{"line_number":159,"context_line":"        self._default_project \u003d ("},{"line_number":160,"context_line":"            getattr(self.configuration, \u0027tegile_default_project\u0027) or"},{"line_number":161,"context_line":"            \u0027openstack\u0027)"},{"line_number":162,"context_line":"        self._hostname \u003d getattr(self.configuration, \u0027tegile_nas_server\u0027)"},{"line_number":163,"context_line":"        username \u003d getattr(self.configuration, \u0027tegile_nas_login\u0027)"},{"line_number":164,"context_line":"        password \u003d getattr(self.configuration, \u0027tegile_nas_password\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_17f0ea8f","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":24},"in_reply_to":"bae84128_2e3c77c7","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # from the one passed to it. Eg. \u0027projectname-sharename\u0027 instead"},{"line_number":183,"context_line":"        # of \u0027sharename\u0027 if inherited share properties are selected."},{"line_number":184,"context_line":"        ip, real_share_name \u003d self._api(method\u003d\u0027createShare\u0027,"},{"line_number":185,"context_line":"                                        params\u003dparams).split(\u0027 \u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),"},{"line_number":188,"context_line":"                 {\u0027sharename\u0027: share_name, \u0027shid\u0027: share[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_b95e21e7","line":185,"range":{"start_line":185,"start_character":61,"end_line":185,"end_character":64},"updated":"2016-02-22 02:37:49.000000000","message":"The default separator is whitespace.. any reason for this override?","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # from the one passed to it. Eg. \u0027projectname-sharename\u0027 instead"},{"line_number":183,"context_line":"        # of \u0027sharename\u0027 if inherited share properties are selected."},{"line_number":184,"context_line":"        ip, real_share_name \u003d self._api(method\u003d\u0027createShare\u0027,"},{"line_number":185,"context_line":"                                        params\u003dparams).split(\u0027 \u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),"},{"line_number":188,"context_line":"                 {\u0027sharename\u0027: share_name, \u0027shid\u0027: share[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b783f6cb","line":185,"range":{"start_line":185,"start_character":61,"end_line":185,"end_character":64},"in_reply_to":"bae84128_0e237306","updated":"2016-03-01 19:50:03.000000000","message":"Goutham, I initially contemplated using \u0027*\u0027 as separator, later chnaged to space.\nValery, I think we would some API in the future that does not require splitting, I would let the clients split the output.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # from the one passed to it. Eg. \u0027projectname-sharename\u0027 instead"},{"line_number":183,"context_line":"        # of \u0027sharename\u0027 if inherited share properties are selected."},{"line_number":184,"context_line":"        ip, real_share_name \u003d self._api(method\u003d\u0027createShare\u0027,"},{"line_number":185,"context_line":"                                        params\u003dparams).split(\u0027 \u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        LOG.info(_LI(\"Created share %(sharename)s, share id %(shid)s.\"),"},{"line_number":188,"context_line":"                 {\u0027sharename\u0027: share_name, \u0027shid\u0027: share[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_0e237306","line":185,"range":{"start_line":185,"start_character":61,"end_line":185,"end_character":64},"in_reply_to":"bae84128_b95e21e7","updated":"2016-02-22 10:53:30.000000000","message":"Moreover, this \"split\" is called in all cases when response is valuable. So, it means, that such split should be done in scope of \"api\" method itself.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":233,"context_line":"        \"\"\"Is called to create snapshot.\"\"\""},{"line_number":234,"context_line":"        snap_name \u003d snapshot[\u0027name\u0027]"},{"line_number":235,"context_line":"        display_list \u003d [getattr(snapshot, \u0027display_name\u0027, \u0027\u0027),"},{"line_number":236,"context_line":"                        getattr(snapshot, \u0027display_description\u0027, \u0027\u0027)]"},{"line_number":237,"context_line":"        snap_description \u003d \u0027:\u0027.join(filter(None, display_list))"},{"line_number":238,"context_line":"        # Limit to 254 characters"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4ed8db1d","line":235,"range":{"start_line":235,"start_character":24,"end_line":235,"end_character":61},"updated":"2016-02-22 10:53:30.000000000","message":"Why do you use \"getattr\" when you know name of attr? List of existing attributes is static.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":233,"context_line":"        \"\"\"Is called to create snapshot.\"\"\""},{"line_number":234,"context_line":"        snap_name \u003d snapshot[\u0027name\u0027]"},{"line_number":235,"context_line":"        display_list \u003d [getattr(snapshot, \u0027display_name\u0027, \u0027\u0027),"},{"line_number":236,"context_line":"                        getattr(snapshot, \u0027display_description\u0027, \u0027\u0027)]"},{"line_number":237,"context_line":"        snap_description \u003d \u0027:\u0027.join(filter(None, display_list))"},{"line_number":238,"context_line":"        # Limit to 254 characters"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_377886f2","line":235,"range":{"start_line":235,"start_character":24,"end_line":235,"end_character":61},"in_reply_to":"bae84128_4ed8db1d","updated":"2016-03-01 19:50:03.000000000","message":"don\u0027t need this, removed","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        display_list \u003d [getattr(snapshot, \u0027display_name\u0027, \u0027\u0027),"},{"line_number":236,"context_line":"                        getattr(snapshot, \u0027display_description\u0027, \u0027\u0027)]"},{"line_number":237,"context_line":"        snap_description \u003d \u0027:\u0027.join(filter(None, display_list))"},{"line_number":238,"context_line":"        # Limit to 254 characters"},{"line_number":239,"context_line":"        snap_description \u003d snap_description[:254]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name("},{"line_number":242,"context_line":"            snapshot[\u0027share\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_2998f1bf","line":239,"range":{"start_line":238,"start_character":8,"end_line":239,"end_character":49},"updated":"2016-02-22 10:53:30.000000000","message":"Why 254 and not 256?","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        display_list \u003d [getattr(snapshot, \u0027display_name\u0027, \u0027\u0027),"},{"line_number":236,"context_line":"                        getattr(snapshot, \u0027display_description\u0027, \u0027\u0027)]"},{"line_number":237,"context_line":"        snap_description \u003d \u0027:\u0027.join(filter(None, display_list))"},{"line_number":238,"context_line":"        # Limit to 254 characters"},{"line_number":239,"context_line":"        snap_description \u003d snap_description[:254]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name("},{"line_number":242,"context_line":"            snapshot[\u0027share\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_17758af8","line":239,"range":{"start_line":238,"start_character":8,"end_line":239,"end_character":49},"in_reply_to":"bae84128_2998f1bf","updated":"2016-03-01 19:50:03.000000000","message":"don\u0027t need this, removed","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb2d6623f9a3261029b53f86e98cf094fb56a6f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        return [location]"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @debugger"},{"line_number":323,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":324,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":325,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":326,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_94e71fab","line":323,"range":{"start_line":323,"start_character":8,"end_line":323,"end_character":20},"updated":"2016-02-18 12:14:20.000000000","message":"please implement update_access() instead of allow_access","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        return [location]"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @debugger"},{"line_number":323,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":324,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":325,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":326,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_77604e36","line":323,"range":{"start_line":323,"start_character":8,"end_line":323,"end_character":20},"in_reply_to":"dae33548_94e71fab","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":328,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":331,"context_line":"            LOG.warning(_LW(\u0027USER access types are allowed for \u0027"},{"line_number":332,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":333,"context_line":"            return"},{"line_number":334,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":335,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":336,"context_line":"                            \u0027NFS shares.\u0027))"},{"line_number":337,"context_line":"            return"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"},{"line_number":340,"context_line":"        params \u003d (\u0027%s/%s/%s/%s\u0027 % (pool,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_0e6ff392","line":337,"range":{"start_line":330,"start_character":8,"end_line":337,"end_character":18},"updated":"2016-02-22 10:53:30.000000000","message":"These \"true\" conditions should raise exception. Right now, your driver does not provide access in that case and reports \"OK\". It is bug.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":328,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":331,"context_line":"            LOG.warning(_LW(\u0027USER access types are allowed for \u0027"},{"line_number":332,"context_line":"                            \u0027CIFS shares.\u0027))"},{"line_number":333,"context_line":"            return"},{"line_number":334,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":335,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":336,"context_line":"                            \u0027NFS shares.\u0027))"},{"line_number":337,"context_line":"            return"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"},{"line_number":340,"context_line":"        params \u003d (\u0027%s/%s/%s/%s\u0027 % (pool,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b75ad681","line":337,"range":{"start_line":330,"start_character":8,"end_line":337,"end_character":18},"in_reply_to":"bae84128_0e6ff392","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb2d6623f9a3261029b53f86e98cf094fb56a6f","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        self._api(\u0027shareAllowAccess\u0027, params)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @debugger"},{"line_number":352,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":353,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":354,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":355,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_b4006335","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":19},"updated":"2016-02-18 12:14:20.000000000","message":"please implement update_access() instead of deny_access","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        self._api(\u0027shareAllowAccess\u0027, params)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @debugger"},{"line_number":352,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":353,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":354,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":355,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_975fda71","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":19},"in_reply_to":"dae33548_b4006335","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":403,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027share_backend_name\u0027)"},{"line_number":406,"context_line":"            data[\u0027share_backend_name\u0027] \u003d backend_name or \u0027Tegile\u0027"},{"line_number":407,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"},{"line_number":408,"context_line":"            data[\u0027driver_version\u0027] \u003d VERSION"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_3f031144","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":76},"updated":"2016-02-22 02:37:49.000000000","message":"Please read this in your __init__ method, not here.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51d7dc4dbf7a32b0a70de23c767b6843e3572464","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":403,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027share_backend_name\u0027)"},{"line_number":406,"context_line":"            data[\u0027share_backend_name\u0027] \u003d backend_name or \u0027Tegile\u0027"},{"line_number":407,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"},{"line_number":408,"context_line":"            data[\u0027driver_version\u0027] \u003d VERSION"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ceceabb3","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":76},"in_reply_to":"bae84128_3f031144","updated":"2016-02-22 10:53:30.000000000","message":"+1\n\nIt is not expected to be changed. So, no need to reread.","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":403,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027share_backend_name\u0027)"},{"line_number":406,"context_line":"            data[\u0027share_backend_name\u0027] \u003d backend_name or \u0027Tegile\u0027"},{"line_number":407,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"},{"line_number":408,"context_line":"            data[\u0027driver_version\u0027] \u003d VERSION"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f7545e55","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":76},"in_reply_to":"bae84128_3f031144","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf6ca79ea9198a9ea141f49a520609fee0caf4d3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027share_backend_name\u0027)"},{"line_number":406,"context_line":"            data[\u0027share_backend_name\u0027] \u003d backend_name or \u0027Tegile\u0027"},{"line_number":407,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"},{"line_number":408,"context_line":"            data[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":409,"context_line":"            data[\u0027storage_protocol\u0027] \u003d \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_5ff89549","line":406,"range":{"start_line":406,"start_character":57,"end_line":406,"end_character":65},"updated":"2016-02-22 02:37:49.000000000","message":"could you make this a constant in your class? perhaps a variable called self._driver_class_name?","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"eb40fbb4e314a8d0b2ff63157b2a7a16e642c199","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027share_backend_name\u0027)"},{"line_number":406,"context_line":"            data[\u0027share_backend_name\u0027] \u003d backend_name or \u0027Tegile\u0027"},{"line_number":407,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"},{"line_number":408,"context_line":"            data[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":409,"context_line":"            data[\u0027storage_protocol\u0027] \u003d \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_374fe6be","line":406,"range":{"start_line":406,"start_character":57,"end_line":406,"end_character":65},"in_reply_to":"bae84128_5ff89549","updated":"2016-03-01 19:50:03.000000000","message":"Done","commit_id":"99029f26a424893bdd758ac4c00cb8ba1c33ad41"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        There is no shrink for Tegile shares."},{"line_number":215,"context_line":"        We just adjust the quotas. The API is still called \u0027resizeShare\u0027."},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        self.extend_share(shrink_share, shrink_size, share_server)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @debugger"},{"line_number":220,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_184f76be","line":217,"range":{"start_line":217,"start_character":13,"end_line":217,"end_character":25},"updated":"2016-03-01 21:44:13.000000000","message":"It\u0027s not a great idea to call one top-level driver method from another one.  If nothing else, the logging can get harder to follow.  I\u0027d suggest a private method called by both extend_share and shrink_share.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        There is no shrink for Tegile shares."},{"line_number":215,"context_line":"        We just adjust the quotas. The API is still called \u0027resizeShare\u0027."},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        self.extend_share(shrink_share, shrink_size, share_server)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @debugger"},{"line_number":220,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a43734af","line":217,"range":{"start_line":217,"start_character":13,"end_line":217,"end_character":25},"in_reply_to":"7af24918_184f76be","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name("},{"line_number":238,"context_line":"            snapshot[\u0027share\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        share \u003d {\u0027poolName\u0027: \u0027%s\u0027 % pool,"},{"line_number":241,"context_line":"                 \u0027projectName\u0027: \u0027%s\u0027 % project,"},{"line_number":242,"context_line":"                 \u0027name\u0027: share_name,"},{"line_number":243,"context_line":"                 \u0027availableSize\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_38c192e5","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":41},"updated":"2016-03-01 21:44:13.000000000","message":"Please wrap according to OpenStack guidelines.\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name("},{"line_number":238,"context_line":"            snapshot[\u0027share\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        share \u003d {\u0027poolName\u0027: \u0027%s\u0027 % pool,"},{"line_number":241,"context_line":"                 \u0027projectName\u0027: \u0027%s\u0027 % project,"},{"line_number":242,"context_line":"                 \u0027name\u0027: share_name,"},{"line_number":243,"context_line":"                 \u0027availableSize\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e4413c0d","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":41},"in_reply_to":"7af24918_38c192e5","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(_LI(\u0027Creating snapshot for share_name\u003d%(shr)s\u0027"},{"line_number":255,"context_line":"                     \u0027 snap_name\u003d%(name)s\u0027),"},{"line_number":256,"context_line":"                 {\u0027shr\u0027: share_name,"},{"line_number":257,"context_line":"                  \u0027name\u0027: snap_name})"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self._api(\u0027createShareSnapshot\u0027, params)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_584a9e84","line":257,"range":{"start_line":256,"start_character":17,"end_line":257,"end_character":36},"updated":"2016-03-01 21:44:13.000000000","message":"The guidelines say don\u0027t wrap a dict that fits on one line.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(_LI(\u0027Creating snapshot for share_name\u003d%(shr)s\u0027"},{"line_number":255,"context_line":"                     \u0027 snap_name\u003d%(name)s\u0027),"},{"line_number":256,"context_line":"                 {\u0027shr\u0027: share_name,"},{"line_number":257,"context_line":"                  \u0027name\u0027: snap_name})"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self._api(\u0027createShareSnapshot\u0027, params)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_0449c831","line":257,"range":{"start_line":256,"start_character":17,"end_line":257,"end_character":36},"in_reply_to":"7af24918_584a9e84","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        return [location]"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @debugger"},{"line_number":318,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":319,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":320,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":321,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_7325fba9","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":20},"updated":"2016-03-01 21:44:13.000000000","message":"Because you implemented update_access (thanks!), the share manager will never directly call allow_access and deny_access in your driver.  So allow_access and deny_access should be private methods.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        return [location]"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @debugger"},{"line_number":318,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":319,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":320,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":321,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a45e14e7","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":20},"in_reply_to":"7af24918_7325fba9","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":354,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":357,"context_line":"            reason \u003d _LW(\u0027Only USER access type is allowed for \u0027"},{"line_number":358,"context_line":"                         \u0027CIFS shares.\u0027)"},{"line_number":359,"context_line":"            LOG.warning(reason)"},{"line_number":360,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":361,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":362,"context_line":"            reason \u003d _LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":363,"context_line":"                         \u0027NFS shares.\u0027)"},{"line_number":364,"context_line":"            LOG.warning(reason)"},{"line_number":365,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"},{"line_number":368,"context_line":"        params \u003d (\u0027%s/%s/%s/%s\u0027 % (pool,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_b39303a3","line":365,"range":{"start_line":356,"start_character":8,"end_line":365,"end_character":61},"updated":"2016-03-01 21:44:13.000000000","message":"This block is identical to that in allow_access.  You can move it to a common helper method.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":354,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":357,"context_line":"            reason \u003d _LW(\u0027Only USER access type is allowed for \u0027"},{"line_number":358,"context_line":"                         \u0027CIFS shares.\u0027)"},{"line_number":359,"context_line":"            LOG.warning(reason)"},{"line_number":360,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":361,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":362,"context_line":"            reason \u003d _LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":363,"context_line":"                         \u0027NFS shares.\u0027)"},{"line_number":364,"context_line":"            LOG.warning(reason)"},{"line_number":365,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        pool, project, share_name \u003d self._get_pool_project_share_name(share)"},{"line_number":368,"context_line":"        params \u003d (\u0027%s/%s/%s/%s\u0027 % (pool,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e4581cfd","line":365,"range":{"start_line":356,"start_character":8,"end_line":365,"end_character":61},"in_reply_to":"7af24918_b39303a3","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                       share_name),"},{"line_number":391,"context_line":"                      share_proto)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"            # Clears all current acls"},{"line_number":394,"context_line":"            # Remove ip and user acls if share_proto is NFS"},{"line_number":395,"context_line":"            # Remove user acls if share_proto is CIFS"},{"line_number":396,"context_line":"            self._api(\u0027clearAccessRules\u0027, params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_73469b24","line":393,"range":{"start_line":393,"start_character":33,"end_line":393,"end_character":37},"updated":"2016-03-01 21:44:13.000000000","message":"s/acls/ACLs/\n\nSame below.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                       share_name),"},{"line_number":391,"context_line":"                      share_proto)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"            # Clears all current acls"},{"line_number":394,"context_line":"            # Remove ip and user acls if share_proto is NFS"},{"line_number":395,"context_line":"            # Remove user acls if share_proto is CIFS"},{"line_number":396,"context_line":"            self._api(\u0027clearAccessRules\u0027, params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c45d20eb","line":393,"range":{"start_line":393,"start_character":33,"end_line":393,"end_character":37},"in_reply_to":"7af24918_73469b24","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                             request_type\u003d\u0027get\u0027,"},{"line_number":416,"context_line":"                             fine_logging\u003dFalse)"},{"line_number":417,"context_line":"            # fixing values coming back here as String to float"},{"line_number":418,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d float(data.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":419,"context_line":"            data[\u0027free_capacity_gb\u0027] \u003d float(data.get(\u0027free_capacity_gb\u0027, 0))"},{"line_number":420,"context_line":"            for pool in data.get(\u0027pools\u0027, []):"},{"line_number":421,"context_line":"                pool[\u0027total_capacity_gb\u0027] \u003d float("},{"line_number":422,"context_line":"                    pool.get(\u0027total_capacity_gb\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_338d3332","line":419,"range":{"start_line":418,"start_character":0,"end_line":419,"end_character":77},"updated":"2016-03-01 21:44:13.000000000","message":"You shouldn\u0027t need these 2 lines since you are reporting per-pool capacity.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                             request_type\u003d\u0027get\u0027,"},{"line_number":416,"context_line":"                             fine_logging\u003dFalse)"},{"line_number":417,"context_line":"            # fixing values coming back here as String to float"},{"line_number":418,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d float(data.get(\u0027total_capacity_gb\u0027, 0))"},{"line_number":419,"context_line":"            data[\u0027free_capacity_gb\u0027] \u003d float(data.get(\u0027free_capacity_gb\u0027, 0))"},{"line_number":420,"context_line":"            for pool in data.get(\u0027pools\u0027, []):"},{"line_number":421,"context_line":"                pool[\u0027total_capacity_gb\u0027] \u003d float("},{"line_number":422,"context_line":"                    pool.get(\u0027total_capacity_gb\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_24732482","line":419,"range":{"start_line":418,"start_character":0,"end_line":419,"end_character":77},"in_reply_to":"7af24918_338d3332","updated":"2016-03-02 00:07:46.000000000","message":"removed","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":442,"context_line":"        except Exception as e:"},{"line_number":443,"context_line":"            LOG.warning(_LW(\u0027%(clsname)s \u0027"},{"line_number":444,"context_line":"                            \u0027_update_share_stats failed: %(error)s\u0027),"},{"line_number":445,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":446,"context_line":"                         \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_33bb73c6","line":443,"range":{"start_line":443,"start_character":12,"end_line":443,"end_character":23},"updated":"2016-03-01 21:44:13.000000000","message":"Why not use LOG.exception here?  It will include the exception details so you don\u0027t have to include that explicitly.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":442,"context_line":"        except Exception as e:"},{"line_number":443,"context_line":"            LOG.warning(_LW(\u0027%(clsname)s \u0027"},{"line_number":444,"context_line":"                            \u0027_update_share_stats failed: %(error)s\u0027),"},{"line_number":445,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":446,"context_line":"                         \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_0470a871","line":443,"range":{"start_line":443,"start_character":12,"end_line":443,"end_character":23},"in_reply_to":"7af24918_33bb73c6","updated":"2016-03-02 00:07:46.000000000","message":"Done","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"398d8d7d071b9bbc8a6273668a20be8d125076ed","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        return 0"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @debugger"},{"line_number":465,"context_line":"    def _get_location_path(self, share_name, share_proto, ip\u003dNone):"},{"line_number":466,"context_line":"        if ip is None:"},{"line_number":467,"context_line":"            ip \u003d self._hostname"},{"line_number":468,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_b8f5a284","line":465,"range":{"start_line":465,"start_character":8,"end_line":465,"end_character":26},"updated":"2016-03-01 21:44:13.000000000","message":"Please use the new export location format, which looks like:\n\n    {\n        \u0027path\u0027: \u003cexport path like you have now\u003e,\n        \u0027is_admin_only\u0027: False,\n        \u0027metadata\u0027: {\n            \u0027preferred\u0027: True,\n        },\n    }","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"8603f383a899f7488f4029f5aad196f132509486","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        return 0"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @debugger"},{"line_number":465,"context_line":"    def _get_location_path(self, share_name, share_proto, ip\u003dNone):"},{"line_number":466,"context_line":"        if ip is None:"},{"line_number":467,"context_line":"            ip \u003d self._hostname"},{"line_number":468,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_04f708d4","line":465,"range":{"start_line":465,"start_character":8,"end_line":465,"end_character":26},"in_reply_to":"7af24918_b8f5a284","updated":"2016-03-02 00:07:46.000000000","message":"I changed it to new format. \nSo far, so good with the tempest tests; they are running fine with new format.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            # Clears all current ACLs"},{"line_number":406,"context_line":"            # Remove ip and user ACLs if share_proto is NFS"},{"line_number":407,"context_line":"            # Remove user ACLs if share_proto is CIFS"},{"line_number":408,"context_line":"            self._api(\u0027clearAccessRules\u0027, params)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"            # Looping thru all rules."},{"line_number":411,"context_line":"            # Will have one API call per rule."}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_62b94e79","line":408,"range":{"start_line":408,"start_character":12,"end_line":408,"end_character":49},"updated":"2016-03-02 23:37:32.000000000","message":"You may want to consider whether this will lead to a brief outage for users.  If your backend supports it, it may be safer to read the rules from the storage controller, compute the difference in the driver, and call add or remove as needed.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            # Clears all current ACLs"},{"line_number":406,"context_line":"            # Remove ip and user ACLs if share_proto is NFS"},{"line_number":407,"context_line":"            # Remove user ACLs if share_proto is CIFS"},{"line_number":408,"context_line":"            self._api(\u0027clearAccessRules\u0027, params)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"            # Looping thru all rules."},{"line_number":411,"context_line":"            # Will have one API call per rule."}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_491f126c","line":408,"range":{"start_line":408,"start_character":12,"end_line":408,"end_character":49},"in_reply_to":"7af24918_62b94e79","updated":"2016-03-03 02:02:37.000000000","message":"I didn\u0027t think about the outage part.\n\nWe don\u0027t have an API that gives all the current rules. I will work on that API (that needs approval from others in my company, so it will take time) after the driver is approved as we are very close to the deadline.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":452,"context_line":"        except Exception as e:"},{"line_number":453,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":454,"context_line":"            LOG.exception(msg)"},{"line_number":455,"context_line":"            raise e"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a25d1649","line":453,"range":{"start_line":453,"start_character":12,"end_line":453,"end_character":34},"updated":"2016-03-02 23:37:32.000000000","message":"This isn\u0027t necessary.  LOG.exception will do this for you and include the pertinent exception details.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":452,"context_line":"        except Exception as e:"},{"line_number":453,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":454,"context_line":"            LOG.exception(msg)"},{"line_number":455,"context_line":"            raise e"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a910565a","line":453,"range":{"start_line":453,"start_character":12,"end_line":453,"end_character":34},"in_reply_to":"7af24918_a25d1649","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":452,"context_line":"        except Exception as e:"},{"line_number":453,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":454,"context_line":"            LOG.exception(msg)"},{"line_number":455,"context_line":"            raise e"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    @debugger"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a224f6c4","line":454,"range":{"start_line":454,"start_character":26,"end_line":454,"end_character":29},"updated":"2016-03-02 23:37:32.000000000","message":"You can just pass your own string here, such as \"Failed to get array stats.\", and let LOG.exception do the rest.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            super(TegileShareDriver, self)._update_share_stats(data)"},{"line_number":452,"context_line":"        except Exception as e:"},{"line_number":453,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":454,"context_line":"            LOG.exception(msg)"},{"line_number":455,"context_line":"            raise e"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    @debugger"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_89159a4a","line":454,"range":{"start_line":454,"start_character":26,"end_line":454,"end_character":29},"in_reply_to":"7af24918_a224f6c4","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"VENDOR \u003d \u0027Tegile Systems Inc.\u0027"},{"line_number":52,"context_line":"DEFAULT_BACKEND_NAME \u003d \u0027Tegile\u0027"},{"line_number":53,"context_line":"VERSION \u003d \u00271.0.0\u0027"},{"line_number":54,"context_line":"DEBUG_LOGGING \u003d False  # For debugging purposes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def debugger(func):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_d1e62014","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":47},"updated":"2016-03-03 07:46:32.000000000","message":"you might want this as a conf setting","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"VENDOR \u003d \u0027Tegile Systems Inc.\u0027"},{"line_number":52,"context_line":"DEFAULT_BACKEND_NAME \u003d \u0027Tegile\u0027"},{"line_number":53,"context_line":"VERSION \u003d \u00271.0.0\u0027"},{"line_number":54,"context_line":"DEBUG_LOGGING \u003d False  # For debugging purposes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def debugger(func):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_521ccb69","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":47},"in_reply_to":"7af24918_d1e62014","updated":"2016-03-03 09:25:09.000000000","message":"The intention is to use it for dev purposes only. So did not use a configuration option.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"952d7d80831989f478e192ba5864306559617ac2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return self._send_api_request(*args, **kwargs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @debugger"},{"line_number":100,"context_line":"    @utils.retry(exception\u003d(requests.ConnectionError, requests.Timeout))"},{"line_number":101,"context_line":"    def _send_api_request(self, method, params\u003dNone,"},{"line_number":102,"context_line":"                          request_type\u003d\u0027post\u0027,"},{"line_number":103,"context_line":"                          api_service\u003dDEFAULT_API_SERVICE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_907016de","line":100,"updated":"2016-03-03 06:45:39.000000000","message":"maybe that\u0027s a bit too much retry? maybe 3 retries with a constant wait interval would be better?","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return self._send_api_request(*args, **kwargs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @debugger"},{"line_number":100,"context_line":"    @utils.retry(exception\u003d(requests.ConnectionError, requests.Timeout))"},{"line_number":101,"context_line":"    def _send_api_request(self, method, params\u003dNone,"},{"line_number":102,"context_line":"                          request_type\u003d\u0027post\u0027,"},{"line_number":103,"context_line":"                          api_service\u003dDEFAULT_API_SERVICE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_722d8794","line":100,"in_reply_to":"7af24918_907016de","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"952d7d80831989f478e192ba5864306559617ac2","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            reason \u003d _LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":389,"context_line":"                         \u0027NFS shares.\u0027)"},{"line_number":390,"context_line":"            LOG.warning(reason)"},{"line_number":391,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @debugger"},{"line_number":394,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_abdb234e","line":391,"updated":"2016-03-03 06:45:39.000000000","message":"There\u0027s a \"else\" needed which raises an exception. Otherwise other share protocols just pass this method.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            reason \u003d _LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":389,"context_line":"                         \u0027NFS shares.\u0027)"},{"line_number":390,"context_line":"            LOG.warning(reason)"},{"line_number":391,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @debugger"},{"line_number":394,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_f1607c03","line":391,"in_reply_to":"7af24918_abdb234e","updated":"2016-03-03 07:46:32.000000000","message":"+1","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            reason \u003d _LW(\u0027Only IP or USER access types are allowed for \u0027"},{"line_number":389,"context_line":"                         \u0027NFS shares.\u0027)"},{"line_number":390,"context_line":"            LOG.warning(reason)"},{"line_number":391,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @debugger"},{"line_number":394,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_d21e1b5e","line":391,"in_reply_to":"7af24918_abdb234e","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                pool[\u0027allocated_capacity_gb\u0027] \u003d float("},{"line_number":438,"context_line":"                    pool.get(\u0027allocated_capacity_gb\u0027, 0))"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"                pool[\u0027qos\u0027] \u003d pool[\u0027QoS_support\u0027]"},{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_03e79b11","line":440,"range":{"start_line":440,"start_character":36,"end_line":440,"end_character":47},"updated":"2016-03-03 07:46:32.000000000","message":"We\u0027ve defined qos. We don\u0027t use QoS_support. Better to not report it.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                pool[\u0027allocated_capacity_gb\u0027] \u003d float("},{"line_number":438,"context_line":"                    pool.get(\u0027allocated_capacity_gb\u0027, 0))"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"                pool[\u0027qos\u0027] \u003d pool[\u0027QoS_support\u0027]"},{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_52332bf6","line":440,"range":{"start_line":440,"start_character":36,"end_line":440,"end_character":47},"in_reply_to":"7af24918_03e79b11","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    pool.get(\u0027allocated_capacity_gb\u0027, 0))"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"                pool[\u0027qos\u0027] \u003d pool[\u0027QoS_support\u0027]"},{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":444,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_03c4bb8e","line":441,"range":{"start_line":441,"start_character":12,"end_line":441,"end_character":47},"updated":"2016-03-03 07:46:32.000000000","message":"You should read reserved_percentage from conf, then the scheduler will implement this feature for you.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    pool.get(\u0027allocated_capacity_gb\u0027, 0))"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"                pool[\u0027qos\u0027] \u003d pool[\u0027QoS_support\u0027]"},{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":444,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_924f736a","line":441,"range":{"start_line":441,"start_character":12,"end_line":441,"end_character":47},"in_reply_to":"7af24918_03c4bb8e","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":444,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"            data[\u0027share_backend_name\u0027] \u003d self._backend_name"},{"line_number":447,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_c35bf3f4","line":444,"updated":"2016-03-03 07:46:32.000000000","message":"You need to set max_over_subscription_ratio (usually from conf) for thin provisioning.  I guess you are using the default, but that is not realistic w/o being configurable.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                pool[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":442,"context_line":"                pool[\u0027dedupe\u0027] \u003d True"},{"line_number":443,"context_line":"                pool[\u0027compression\u0027] \u003d True"},{"line_number":444,"context_line":"                pool[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"            data[\u0027share_backend_name\u0027] \u003d self._backend_name"},{"line_number":447,"context_line":"            data[\u0027vendor_name\u0027] \u003d VENDOR"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_725467fe","line":444,"in_reply_to":"7af24918_c35bf3f4","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"cc887acd069172ca8c4bc9037dff2a032631274a","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            LOG.warning(reason)"},{"line_number":394,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":395,"context_line":"        elif share_proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"},{"line_number":396,"context_line":"            reason \u003d _LW(\u0027Unsupported protocol \\\"%s\\\" specified for \u0027"},{"line_number":397,"context_line":"                         \u0027access rule.\u0027) % share_proto"},{"line_number":398,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_72510736","line":396,"range":{"start_line":396,"start_character":47,"end_line":396,"end_character":53},"updated":"2016-03-03 09:41:28.000000000","message":"Don\u0027t need to excape double-quotes inside single quote - but it still works.","commit_id":"a8c5b41ab48536ed1d4565379fbacdef4f8ed653"}],"manila/tests/share/drivers/tegile/test_tegile.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from manila.share.drivers.tegile import tegile"},{"line_number":28,"context_line":"from manila import test"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SHARE_DRIVER \u003d tegile.TegileShareDriver"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c449a08d","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":27},"updated":"2016-03-02 00:14:23.000000000","message":"This import is out of place.\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SHARE_DRIVER \u003d tegile.TegileShareDriver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_7f877961","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":39},"updated":"2016-03-02 00:14:23.000000000","message":"Is this constant really necessary?  I don\u0027t think so.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class FakeTegileService(tegile.TegileAPIExecutor):"},{"line_number":96,"context_line":"    def __init__(self, classname, hostname, username, password):"},{"line_number":97,"context_line":"        super(FakeTegileService, self).__init__(classname,"},{"line_number":98,"context_line":"                                                hostname,"},{"line_number":99,"context_line":"                                                username,"},{"line_number":100,"context_line":"                                                password)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __call__(self, *args, **kwargs):"},{"line_number":103,"context_line":"        return self.send_api_request(*args, **kwargs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def send_api_request(self, method, params\u003dNone,"},{"line_number":106,"context_line":"                         request_type\u003d\u0027post\u0027,"},{"line_number":107,"context_line":"                         api_service\u003d\u0027openstack\u0027,"},{"line_number":108,"context_line":"                         fine_logging\u003dFalse):"},{"line_number":109,"context_line":"        if method in (\u0027createShare\u0027,"},{"line_number":110,"context_line":"                      \u0027cloneShareSnapshot\u0027,"},{"line_number":111,"context_line":"                      \u0027getShareIPAndMountPoint\u0027):"},{"line_number":112,"context_line":"            return self._hostname + \u0027 \u0027 + test_share[\u0027name\u0027]"},{"line_number":113,"context_line":"        elif method is \u0027getArrayStats\u0027:"},{"line_number":114,"context_line":"            return array_stats"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            return \u0027\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"fake_tegile_backend \u003d FakeTegileService(\"TestCase\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_dfca0da1","line":116,"range":{"start_line":95,"start_character":0,"end_line":116,"end_character":21},"updated":"2016-03-02 00:14:23.000000000","message":"This seems a little overcomplicated.  It works, but you can also just use simple mocks for the API request.  And over time, if you need more fake data to model API calls, consider moving that to a separate fakes file.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                        test_config.tegile_nas_password)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class FakeTegileServiceFail(object):"},{"line_number":126,"context_line":"    def __call__(self, *args, **kwargs):"},{"line_number":127,"context_line":"        raise TegileAPIException(response\u003d\"Fake Exception\")"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"fake_tegile_backend_fail \u003d FakeTegileServiceFail()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_24de846d","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":59},"updated":"2016-03-02 00:14:23.000000000","message":"This can be replaced with a simple mock in TegileShareDriverTestCase.__init__():\n\nfake_tegile_backend_fail \u003d mock.Mock(\n    side_effect\u003dTegileAPIException(response\u003d\"Fake Exception\"))","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        super(TegileShareDriverTestCase, self).setUp()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_create_share(self):"},{"line_number":157,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":158,"context_line":"        self.mock_object(tegile_driver, \u0027_api\u0027, fake_tegile_backend)"},{"line_number":159,"context_line":"        self.assertEqual(\u0027some-ip:testshare\u0027,"},{"line_number":160,"context_line":"                         tegile_driver.create_share(self._ctxt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_1638e2d2","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":59},"updated":"2016-03-02 00:14:23.000000000","message":"Don\u0027t do this in every test.  Place this in setUp() and just refer to it as self.tegile_driver.  Remember that setUp() is called before each test.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                          self._ctxt,"},{"line_number":169,"context_line":"                          test_share)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_delete_share(self):"},{"line_number":172,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":173,"context_line":"        self.mock_object(tegile_driver, \u0027_api\u0027, fake_tegile_backend)"},{"line_number":174,"context_line":"        tegile_driver.delete_share(self._ctxt, test_share)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_delete_share_fail(self):"},{"line_number":177,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_446ab081","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":58},"updated":"2016-03-02 00:14:23.000000000","message":"This is not a valuable unit test.  You should mock things that delete_share needs, and assert that the right things happened when you call it.  I\u0027ve taken the liberty of writing a proper unit test for this method as an example; I tested it and it works.  You will need to apply the same ideas everywhere else.\n\nAs I\u0027ve done here, please use whitespace to separate unit tests into 3 sections (mocks, call, asserts) for greater readability.\n\n    def test_delete_share(self):\n\n        fake_share_info \u003d (\u0027fake_pool\u0027, \u0027fake_project\u0027, \u0027fake_share\u0027)\n        self.mock_object(self.tegile_driver,\n                         \u0027_get_pool_project_share_name\u0027,\n                         mock.Mock(return_value\u003dfake_share_info))\n        mock_api \u003d self.mock_object(self.tegile_driver, \u0027_api\u0027)\n\n\n        self.tegile_driver.delete_share(self._ctxt, test_share)\n\n\n        delete_path \u003d \u0027%s/%s/%s/%s\u0027 % (\n            \u0027fake_pool\u0027, \u0027Local\u0027, \u0027fake_project\u0027, \u0027fake_share\u0027)\n        delete_params \u003d (delete_path, True, False)\n        mock_api.assert_called_once_with(\u0027deleteShare\u0027, delete_params)","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def test_delete_share_fail(self):"},{"line_number":177,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":178,"context_line":"        self.mock_object(tegile_driver, \u0027_api\u0027, fake_tegile_backend_fail)"},{"line_number":179,"context_line":"        self.assertRaises(TegileAPIException,"},{"line_number":180,"context_line":"                          tegile_driver.delete_share,"},{"line_number":181,"context_line":"                          self._ctxt,"},{"line_number":182,"context_line":"                          test_share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_64788cf3","line":179,"range":{"start_line":179,"start_character":13,"end_line":179,"end_character":25},"updated":"2016-03-02 00:14:23.000000000","message":"Here there isn\u0027t a separate call, but you still need whitespace between mock \u0026 assert sections.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    def test_get_pool(self):"},{"line_number":307,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":308,"context_line":"        self.mock_object(tegile_driver, \u0027_api\u0027, fake_tegile_backend)"},{"line_number":309,"context_line":"        self.assertEqual(\u0027testPool\u0027, tegile_driver.get_pool(test_share))"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_extend_share(self):"},{"line_number":312,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c45fe070","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":72},"updated":"2016-03-02 00:14:23.000000000","message":"Separate the call from the assert, like this:\n\n    result \u003d tegile_driver.get_pool(test_share)\n\n    self.assertEqual(\u0027testPool\u0027, result)\n\nSame everywhere else.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            \u0027access_level\u0027: const.ACCESS_LEVEL_RW,"},{"line_number":394,"context_line":"            \u0027access_to\u0027: \u0027some-ip\u0027,"},{"line_number":395,"context_line":"        }"},{"line_number":396,"context_line":"        tegile_driver.deny_access(self._ctxt, test_share, access)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        access \u003d {"},{"line_number":399,"context_line":"            \u0027access_type\u0027: \u0027user\u0027,"},{"line_number":400,"context_line":"            \u0027access_level\u0027: const.ACCESS_LEVEL_RW,"},{"line_number":401,"context_line":"            \u0027access_to\u0027: \u0027some-ip\u0027,"},{"line_number":402,"context_line":"        }"},{"line_number":403,"context_line":"        tegile_driver.deny_access(self._ctxt, test_share, access)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_deny_access_fail(self):"},{"line_number":406,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_0400a833","line":403,"range":{"start_line":396,"start_character":8,"end_line":403,"end_character":65},"updated":"2016-03-02 00:14:23.000000000","message":"One test invocation per test method, please.  Same everywhere else.  You can use DDT to pass different sets of stimuli to otherwise identical test code.  Examples abound elsewhere in manila.","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"099ff88cc5b6128f79ecdb40d12c72bf79206aff","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                                       test_config.tegile_nas_login,"},{"line_number":528,"context_line":"                                       test_config.tegile_nas_password)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        self.assertEqual(json_output,"},{"line_number":531,"context_line":"                         api(method\u003d\"Test\","},{"line_number":532,"context_line":"                             request_type\u003d\u0027post\u0027,"},{"line_number":533,"context_line":"                             params\u003d\u0027[]\u0027,"},{"line_number":534,"context_line":"                             fine_logging\u003dTrue))"},{"line_number":535,"context_line":"        self.assertEqual(json_output,"},{"line_number":536,"context_line":"                         api(method\u003d\"Test\","},{"line_number":537,"context_line":"                             request_type\u003d\u0027get\u0027,"},{"line_number":538,"context_line":"                             fine_logging\u003dFalse))"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        self.mock_object(requests, \u0027get\u0027,"},{"line_number":541,"context_line":"                         mock.Mock(return_value\u003dFakeResponse(404, [])))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_449110f0","line":538,"range":{"start_line":530,"start_character":0,"end_line":538,"end_character":49},"updated":"2016-03-02 00:14:23.000000000","message":"As above, separate call from asserts, and separate separate invocations into separate test methods (or use DDT where possible).","commit_id":"f8f8ef1155bc66261c6068c1cbb9a3243bd52d70"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":121,"context_line":"        self._driver \u003d tegile.TegileShareDriver("},{"line_number":122,"context_line":"            configuration\u003dself.configuration)"},{"line_number":123,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":124,"context_line":"        super(TegileShareDriverTestCase, self).setUp()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_create_share(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_9d679fe8","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":63},"updated":"2016-03-02 23:37:32.000000000","message":"Duplicate line.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":121,"context_line":"        self._driver \u003d tegile.TegileShareDriver("},{"line_number":122,"context_line":"            configuration\u003dself.configuration)"},{"line_number":123,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":124,"context_line":"        super(TegileShareDriverTestCase, self).setUp()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_create_share(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_89a8fadc","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":63},"in_reply_to":"7af24918_9d679fe8","updated":"2016-03-03 02:02:37.000000000","message":"removed","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                    mock.Mock("},{"line_number":131,"context_line":"                                        return_value\u003dapi_return_value))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        result \u003d {"},{"line_number":134,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":135,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":136,"context_line":"            \u0027path\u0027: \u0027some-ip:testshare\u0027,"},{"line_number":137,"context_line":"        }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.assertEqual(result,"},{"line_number":140,"context_line":"                         self._driver.create_share(self._ctxt,"},{"line_number":141,"context_line":"                                                   test_share))"},{"line_number":142,"context_line":"        create_params \u003d ("},{"line_number":143,"context_line":"            \u0027testPool\u0027,"},{"line_number":144,"context_line":"            \u0027openstack\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_fdc6a366","line":141,"range":{"start_line":133,"start_character":0,"end_line":141,"end_character":63},"updated":"2016-03-02 23:37:32.000000000","message":"This isn\u0027t wrong, but it\u0027s a little confusing to use \u0027result\u0027 as the expected value instead of the result of the test call.  And like I mentioned yesterday, please separate the call from the assert.  Something like this:\n\n\n    result \u003d self._driver.create_share(self._ctxt, test_share)\n\n\n    expected \u003d {\n        \u0027is_admin_only\u0027: False,\n        \u0027metadata\u0027: {\n            \u0027preferred\u0027: True,\n        },\n        \u0027path\u0027: \u0027some-ip:testshare\u0027,\n    }\n    self.assertEqual(expected, result)\n\n\nPlease do the same for other methods that return a value.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                    mock.Mock("},{"line_number":131,"context_line":"                                        return_value\u003dapi_return_value))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        result \u003d {"},{"line_number":134,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":135,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":136,"context_line":"            \u0027path\u0027: \u0027some-ip:testshare\u0027,"},{"line_number":137,"context_line":"        }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.assertEqual(result,"},{"line_number":140,"context_line":"                         self._driver.create_share(self._ctxt,"},{"line_number":141,"context_line":"                                                   test_share))"},{"line_number":142,"context_line":"        create_params \u003d ("},{"line_number":143,"context_line":"            \u0027testPool\u0027,"},{"line_number":144,"context_line":"            \u0027openstack\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_29056613","line":141,"range":{"start_line":133,"start_character":0,"end_line":141,"end_character":63},"in_reply_to":"7af24918_fdc6a366","updated":"2016-03-03 02:02:37.000000000","message":"Changed.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            \u0027testPool\u0027,"},{"line_number":144,"context_line":"            \u0027openstack\u0027,"},{"line_number":145,"context_line":"            test_share[\u0027name\u0027],"},{"line_number":146,"context_line":"            test_share[\u0027share_proto\u0027])"},{"line_number":147,"context_line":"        mock_api.assert_called_once_with(\u0027createShare\u0027, create_params)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_create_share_fail(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_fdd98323","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":38},"updated":"2016-03-02 23:37:32.000000000","message":"Please don\u0027t forget to wrap multi-line values like this with a trailing comma and the closing element on the following line.\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            \u0027testPool\u0027,"},{"line_number":144,"context_line":"            \u0027openstack\u0027,"},{"line_number":145,"context_line":"            test_share[\u0027name\u0027],"},{"line_number":146,"context_line":"            test_share[\u0027share_proto\u0027])"},{"line_number":147,"context_line":"        mock_api.assert_called_once_with(\u0027createShare\u0027, create_params)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_create_share_fail(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_64015305","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":38},"in_reply_to":"7af24918_fdd98323","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":582,"context_line":"               \u0027host\u0027: None})"},{"line_number":583,"context_line":"    @ddt.unpack"},{"line_number":584,"context_line":"    def test_get_location_path(self, path, share_proto, host):"},{"line_number":585,"context_line":"        result \u003d {"},{"line_number":586,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":587,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_e88b7f66","line":588,"range":{"start_line":585,"start_character":0,"end_line":588,"end_character":25},"updated":"2016-03-02 23:37:32.000000000","message":"Please wrap fully per the guidelines.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":582,"context_line":"               \u0027host\u0027: None})"},{"line_number":583,"context_line":"    @ddt.unpack"},{"line_number":584,"context_line":"    def test_get_location_path(self, path, share_proto, host):"},{"line_number":585,"context_line":"        result \u003d {"},{"line_number":586,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":587,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_4406d71d","line":588,"range":{"start_line":585,"start_character":0,"end_line":588,"end_character":25},"in_reply_to":"7af24918_e88b7f66","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"},{"line_number":592,"context_line":"                         self._driver._get_location_path(\u0027shareName\u0027,"},{"line_number":593,"context_line":"                                                         share_proto,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_28da874c","line":590,"range":{"start_line":590,"start_character":8,"end_line":590,"end_character":62},"updated":"2016-03-02 23:37:32.000000000","message":"It\u0027s not necessary to mock a value like this.  What\u0027s wrong with this?\n\n    self._driver._hostname \u003d \u0027some-ip\u0027","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"},{"line_number":592,"context_line":"                         self._driver._get_location_path(\u0027shareName\u0027,"},{"line_number":593,"context_line":"                                                         share_proto,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a407db16","line":590,"range":{"start_line":590,"start_character":8,"end_line":590,"end_character":62},"in_reply_to":"7af24918_28da874c","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"},{"line_number":592,"context_line":"                         self._driver._get_location_path(\u0027shareName\u0027,"},{"line_number":593,"context_line":"                                                         share_proto,"},{"line_number":594,"context_line":"                                                         host))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_get_location_path_fail(self):"},{"line_number":597,"context_line":"        self.assertRaises(exception.InvalidInput,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_08f06bc8","line":594,"range":{"start_line":591,"start_character":0,"end_line":594,"end_character":63},"updated":"2016-03-02 23:37:32.000000000","message":"Separate call from assert.  Same everywhere else.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            \u0027path\u0027: path}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        self.mock_object(self._driver, \u0027_hostname\u0027, \u0027some-ip\u0027)"},{"line_number":591,"context_line":"        self.assertEqual(result,"},{"line_number":592,"context_line":"                         self._driver._get_location_path(\u0027shareName\u0027,"},{"line_number":593,"context_line":"                                                         share_proto,"},{"line_number":594,"context_line":"                                                         host))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_get_location_path_fail(self):"},{"line_number":597,"context_line":"        self.assertRaises(exception.InvalidInput,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_e4156340","line":594,"range":{"start_line":591,"start_character":0,"end_line":594,"end_character":63},"in_reply_to":"7af24918_08f06bc8","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                          \u0027some-ip\u0027)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_get_network_allocations_number(self):"},{"line_number":604,"context_line":"        result \u003d 0"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        self.assertEqual(result, self._driver.get_network_allocations_number())"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"class TegileAPIExecutorTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_68ae4f99","line":606,"range":{"start_line":604,"start_character":0,"end_line":606,"end_character":79},"updated":"2016-03-02 23:37:32.000000000","message":"This:\n\n\n    result \u003d self._driver.get_network_allocations_number()\n\n\n    self.assertEqual(0, result)\n\n\nYou get the idea!","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                          \u0027some-ip\u0027)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_get_network_allocations_number(self):"},{"line_number":604,"context_line":"        result \u003d 0"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        self.assertEqual(result, self._driver.get_network_allocations_number())"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"class TegileAPIExecutorTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_04196f79","line":606,"range":{"start_line":604,"start_character":0,"end_line":606,"end_character":79},"in_reply_to":"7af24918_68ae4f99","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8cab74b7ac4df4bd986649be74b41642529751dc","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        super(TegileAPIExecutorTestCase, self).setUp()"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def test_send_api_post(self):"},{"line_number":618,"context_line":"        json_output \u003d {"},{"line_number":619,"context_line":"            \u0027value\u0027: \u0027abc\u0027,"},{"line_number":620,"context_line":"        }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        self.mock_object(requests, \u0027post\u0027,"},{"line_number":623,"context_line":"                         mock.Mock(return_value\u003dFakeResponse(200,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_4891d346","line":620,"range":{"start_line":618,"start_character":0,"end_line":620,"end_character":9},"updated":"2016-03-02 23:37:32.000000000","message":"No wrap.  This fits on one line.  Same below.","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"15343768e52acd55f71e183401f76036ba116db7","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        super(TegileAPIExecutorTestCase, self).setUp()"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def test_send_api_post(self):"},{"line_number":618,"context_line":"        json_output \u003d {"},{"line_number":619,"context_line":"            \u0027value\u0027: \u0027abc\u0027,"},{"line_number":620,"context_line":"        }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        self.mock_object(requests, \u0027post\u0027,"},{"line_number":623,"context_line":"                         mock.Mock(return_value\u003dFakeResponse(200,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_64283387","line":620,"range":{"start_line":618,"start_character":0,"end_line":620,"end_character":9},"in_reply_to":"7af24918_4891d346","updated":"2016-03-03 02:02:37.000000000","message":"Done","commit_id":"d356429291cc331fba7f28901ba732eac0c41465"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027pools\u0027: ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \u0027total_capacity_gb\u0027: 913.5,"},{"line_number":72,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":73,"context_line":"            \u0027free_capacity_gb\u0027: 911.812650680542,"},{"line_number":74,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":75,"context_line":"            \u0027pool_name\u0027: \u0027pyramid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_6b4f5b6b","line":72,"range":{"start_line":72,"start_character":13,"end_line":72,"end_character":33},"updated":"2016-03-03 07:46:32.000000000","message":"QoS_support is now \"qos\"","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027pools\u0027: ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \u0027total_capacity_gb\u0027: 913.5,"},{"line_number":72,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":73,"context_line":"            \u0027free_capacity_gb\u0027: 911.812650680542,"},{"line_number":74,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":75,"context_line":"            \u0027pool_name\u0027: \u0027pyramid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_72a2a7fe","line":72,"range":{"start_line":72,"start_character":13,"end_line":72,"end_character":33},"in_reply_to":"7af24918_6b4f5b6b","updated":"2016-03-03 09:25:09.000000000","message":"This is used a API\u0027s return object, so leaving it as it is, because API returns it.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        {"},{"line_number":78,"context_line":"            \u0027total_capacity_gb\u0027: 2742.1996604874,"},{"line_number":79,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":80,"context_line":"            \u0027free_capacity_gb\u0027: 2740.148867149747,"},{"line_number":81,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":82,"context_line":"            \u0027pool_name\u0027: \u0027cobalt\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_8b5aa728","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":33},"updated":"2016-03-03 07:46:32.000000000","message":"and here","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        {"},{"line_number":78,"context_line":"            \u0027total_capacity_gb\u0027: 2742.1996604874,"},{"line_number":79,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":80,"context_line":"            \u0027free_capacity_gb\u0027: 2740.148867149747,"},{"line_number":81,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":82,"context_line":"            \u0027pool_name\u0027: \u0027cobalt\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_f2aeb7e4","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":33},"in_reply_to":"7af24918_8b5aa728","updated":"2016-03-03 09:25:09.000000000","message":"same as above","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        },"},{"line_number":84,"context_line":"        {"},{"line_number":85,"context_line":"            \u0027total_capacity_gb\u0027: 913.5,"},{"line_number":86,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":87,"context_line":"            \u0027free_capacity_gb\u0027: 913.4198722839355,"},{"line_number":88,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":89,"context_line":"            \u0027pool_name\u0027: \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_eb6a4bb2","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":33},"updated":"2016-03-03 07:46:32.000000000","message":"and here","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        },"},{"line_number":84,"context_line":"        {"},{"line_number":85,"context_line":"            \u0027total_capacity_gb\u0027: 913.5,"},{"line_number":86,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":87,"context_line":"            \u0027free_capacity_gb\u0027: 913.4198722839355,"},{"line_number":88,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":89,"context_line":"            \u0027pool_name\u0027: \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_32b5bf30","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":33},"in_reply_to":"7af24918_eb6a4bb2","updated":"2016-03-03 09:25:09.000000000","message":"same as above","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9ddb3335212cbc40b723a68d4012b5acd6b3b718","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        result \u003d self._driver.create_share(self._ctxt, test_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        expected \u003d {"},{"line_number":135,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":136,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":137,"context_line":"            \u0027path\u0027: \u0027some-ip:testshare\u0027,"},{"line_number":138,"context_line":"        }"},{"line_number":139,"context_line":"        self.assertEqual(expected, result)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        create_params \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_e4fba3bf","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":9},"updated":"2016-03-03 02:13:55.000000000","message":"There are a few places where this dict should be fully opened, per the guidelines:\n\n\n        expected \u003d {\n            \u0027is_admin_only\u0027: False,\n            \u0027metadata\u0027: {\n                \u0027preferred\u0027: True,\n            },\n            \u0027path\u0027: \u0027some-ip:testshare\u0027,\n        }","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        result \u003d self._driver.create_share(self._ctxt, test_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        expected \u003d {"},{"line_number":135,"context_line":"            \u0027is_admin_only\u0027: False,"},{"line_number":136,"context_line":"            \u0027metadata\u0027: {\u0027preferred\u0027: True},"},{"line_number":137,"context_line":"            \u0027path\u0027: \u0027some-ip:testshare\u0027,"},{"line_number":138,"context_line":"        }"},{"line_number":139,"context_line":"        self.assertEqual(expected, result)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        create_params \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_1299a3c4","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":9},"in_reply_to":"7af24918_e4fba3bf","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(TegileAPIException,"},{"line_number":175,"context_line":"                          self._driver.delete_share,"},{"line_number":176,"context_line":"                          self._ctxt,"},{"line_number":177,"context_line":"                          test_share)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def test_create_snapshot(self):"},{"line_number":180,"context_line":"        mock_api \u003d self.mock_object(self._driver, \u0027_api\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_965beef5","line":177,"updated":"2016-03-03 07:46:32.000000000","message":"still should assert that _api is called as expected","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(TegileAPIException,"},{"line_number":175,"context_line":"                          self._driver.delete_share,"},{"line_number":176,"context_line":"                          self._ctxt,"},{"line_number":177,"context_line":"                          test_share)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def test_create_snapshot(self):"},{"line_number":180,"context_line":"        mock_api \u003d self.mock_object(self._driver, \u0027_api\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_f2951787","line":177,"in_reply_to":"7af24918_965beef5","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertRaises(TegileAPIException,"},{"line_number":238,"context_line":"                          self._driver.delete_snapshot,"},{"line_number":239,"context_line":"                          self._ctxt,"},{"line_number":240,"context_line":"                          test_snapshot)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_create_share_from_snapshot(self):"},{"line_number":243,"context_line":"        api_return_value \u003d (test_config.tegile_nas_server +"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_8b9c675e","line":240,"updated":"2016-03-03 07:46:32.000000000","message":"you should always try to assert that your mocked objects are called as expected (it often catches mocking mistakes).  Here and other fail tests. For exceptions it doesn\u0027t seem like a terrible omission.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertRaises(TegileAPIException,"},{"line_number":238,"context_line":"                          self._driver.delete_snapshot,"},{"line_number":239,"context_line":"                          self._ctxt,"},{"line_number":240,"context_line":"                          test_snapshot)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_create_share_from_snapshot(self):"},{"line_number":243,"context_line":"        api_return_value \u003d (test_config.tegile_nas_server +"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_92ebf312","line":240,"in_reply_to":"7af24918_8b9c675e","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            test_share[\u0027name\u0027],"},{"line_number":274,"context_line":"            True,"},{"line_number":275,"context_line":"        )"},{"line_number":276,"context_line":"        mock_api.assert_called_once_with(\u0027cloneShareSnapshot\u0027, create_params)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_create_share_from_snapshot_fail(self):"},{"line_number":279,"context_line":"        self.mock_object(self._driver, \u0027_api\u0027, fake_tegile_backend_fail)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_2b76f305","line":276,"updated":"2016-03-03 07:46:32.000000000","message":"assert that _get_pool_project_share_name is called as expected.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            test_share[\u0027name\u0027],"},{"line_number":274,"context_line":"            True,"},{"line_number":275,"context_line":"        )"},{"line_number":276,"context_line":"        mock_api.assert_called_once_with(\u0027cloneShareSnapshot\u0027, create_params)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_create_share_from_snapshot_fail(self):"},{"line_number":279,"context_line":"        self.mock_object(self._driver, \u0027_api\u0027, fake_tegile_backend_fail)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_b2f6eff6","line":276,"in_reply_to":"7af24918_2b76f305","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            \u0027%s/%s/%s/%s\u0027 % ("},{"line_number":311,"context_line":"                \u0027fake_pool\u0027, \u0027Local\u0027, \u0027fake_project\u0027, test_share[\u0027name\u0027])]"},{"line_number":312,"context_line":"        mock_api.assert_called_once_with(\u0027getShareIPAndMountPoint\u0027,"},{"line_number":313,"context_line":"                                         ensure_params)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def test_ensure_share_fail(self):"},{"line_number":316,"context_line":"        self.mock_object(self._driver, \u0027_api\u0027, fake_tegile_backend_fail)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_d671f677","line":313,"updated":"2016-03-03 07:46:32.000000000","message":"assert _get_pool_project_share_name called as expected","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            \u0027%s/%s/%s/%s\u0027 % ("},{"line_number":311,"context_line":"                \u0027fake_pool\u0027, \u0027Local\u0027, \u0027fake_project\u0027, test_share[\u0027name\u0027])]"},{"line_number":312,"context_line":"        mock_api.assert_called_once_with(\u0027getShareIPAndMountPoint\u0027,"},{"line_number":313,"context_line":"                                         ensure_params)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def test_ensure_share_fail(self):"},{"line_number":316,"context_line":"        self.mock_object(self._driver, \u0027_api\u0027, fake_tegile_backend_fail)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_32e3ff34","line":313,"in_reply_to":"7af24918_d671f677","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            \u0027free_capacity_gb\u0027: 4565.381390112452,"},{"line_number":334,"context_line":"            \u0027pools\u0027: ["},{"line_number":335,"context_line":"                {"},{"line_number":336,"context_line":"                    \u0027QoS_support\u0027: False, \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":337,"context_line":"                    \u0027compression\u0027: True,"},{"line_number":338,"context_line":"                    \u0027dedupe\u0027: True,"},{"line_number":339,"context_line":"                    \u0027free_capacity_gb\u0027: 911.812650680542,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_8bd467bd","line":336,"range":{"start_line":336,"start_character":20,"end_line":336,"end_character":40},"updated":"2016-03-03 07:46:32.000000000","message":"delete QoS_support. you have qos below.","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            \u0027free_capacity_gb\u0027: 4565.381390112452,"},{"line_number":334,"context_line":"            \u0027pools\u0027: ["},{"line_number":335,"context_line":"                {"},{"line_number":336,"context_line":"                    \u0027QoS_support\u0027: False, \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":337,"context_line":"                    \u0027compression\u0027: True,"},{"line_number":338,"context_line":"                    \u0027dedupe\u0027: True,"},{"line_number":339,"context_line":"                    \u0027free_capacity_gb\u0027: 911.812650680542,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_92d2d35a","line":336,"range":{"start_line":336,"start_character":20,"end_line":336,"end_character":40},"in_reply_to":"7af24918_8bd467bd","updated":"2016-03-03 09:25:09.000000000","message":"Done","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8fee75e6f8714ff5bda845f40e383b4abfa709da","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        )"},{"line_number":465,"context_line":"        mock_api.assert_called_once_with(\u0027shareAllowAccess\u0027, allow_params)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @ddt.data({\u0027access_type\u0027: \u0027some\u0027, \u0027to\u0027: \u0027some-ip\u0027, \u0027share\u0027: test_share,"},{"line_number":468,"context_line":"               \u0027exception_type\u0027: exception.InvalidShareAccess},"},{"line_number":469,"context_line":"              {\u0027access_type\u0027: \u0027ip\u0027, \u0027to\u0027: \u0027some-ip\u0027, \u0027share\u0027: test_share,"},{"line_number":470,"context_line":"               \u0027exception_type\u0027: exception.TegileAPIException},"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_36dada17","line":467,"range":{"start_line":467,"start_character":31,"end_line":467,"end_character":35},"updated":"2016-03-03 07:46:32.000000000","message":"some? what about user?  Is \"some\" your way of testing what I would call \"other\" or \"bogus\" or \"foo\"?","commit_id":"35fc112c188066d277687b27888caa9e8a987118"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"66dfb2715f281b219ad234a623468ab63f92249b","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        )"},{"line_number":465,"context_line":"        mock_api.assert_called_once_with(\u0027shareAllowAccess\u0027, allow_params)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @ddt.data({\u0027access_type\u0027: \u0027some\u0027, \u0027to\u0027: \u0027some-ip\u0027, \u0027share\u0027: test_share,"},{"line_number":468,"context_line":"               \u0027exception_type\u0027: exception.InvalidShareAccess},"},{"line_number":469,"context_line":"              {\u0027access_type\u0027: \u0027ip\u0027, \u0027to\u0027: \u0027some-ip\u0027, \u0027share\u0027: test_share,"},{"line_number":470,"context_line":"               \u0027exception_type\u0027: exception.TegileAPIException},"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_124ec33a","line":467,"range":{"start_line":467,"start_character":31,"end_line":467,"end_character":35},"in_reply_to":"7af24918_36dada17","updated":"2016-03-03 09:25:09.000000000","message":"Changed to \u0027other\u0027 to avoid confusion. It means any value other than \u0027ip\u0027 or \u0027user\u0027","commit_id":"35fc112c188066d277687b27888caa9e8a987118"}],"manila/tests/share/drivers/test_tegile.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":34,"context_line":"test_config.tegile_nas_login \u003d \u0027some-user\u0027"},{"line_number":35,"context_line":"test_config.tegile_nas_password \u003d \u0027some-password\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"test_share \u003d {\u0027host\u0027: \u0027node#testPool\u0027,"},{"line_number":38,"context_line":"              \u0027name\u0027: \u0027testshare\u0027,"},{"line_number":39,"context_line":"              \u0027id\u0027: \u0027a24c2ee8-525a-4406-8ccd-8d38688f8e9e\u0027,"},{"line_number":40,"context_line":"              \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":41,"context_line":"              \u0027size\u0027: 10}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"test_snapshot \u003d {\u0027name\u0027: \u0027testSnap\u0027,"},{"line_number":44,"context_line":"                 \u0027id\u0027: \u002707ae9978-5445-405e-8881-28f2adfee732\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_cdf0fdff","line":41,"range":{"start_line":37,"start_character":0,"end_line":41,"end_character":25},"updated":"2016-02-12 10:48:29.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists\n\nSame for whole change.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"test_config.tegile_nas_login \u003d \u0027some-user\u0027"},{"line_number":35,"context_line":"test_config.tegile_nas_password \u003d \u0027some-password\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"test_share \u003d {\u0027host\u0027: \u0027node#testPool\u0027,"},{"line_number":38,"context_line":"              \u0027name\u0027: \u0027testshare\u0027,"},{"line_number":39,"context_line":"              \u0027id\u0027: \u0027a24c2ee8-525a-4406-8ccd-8d38688f8e9e\u0027,"},{"line_number":40,"context_line":"              \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":41,"context_line":"              \u0027size\u0027: 10}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"test_snapshot \u003d {\u0027name\u0027: \u0027testSnap\u0027,"},{"line_number":44,"context_line":"                 \u0027id\u0027: \u002707ae9978-5445-405e-8881-28f2adfee732\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_a07ae621","line":41,"range":{"start_line":37,"start_character":0,"end_line":41,"end_character":25},"in_reply_to":"3a57f1b5_cdf0fdff","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                         fine_logging\u003dFalse):"},{"line_number":85,"context_line":"        if method is \u0027createShare\u0027:"},{"line_number":86,"context_line":"            return self._hostname"},{"line_number":87,"context_line":"        elif method is \u0027deleteShare\u0027:"},{"line_number":88,"context_line":"            return \u0027\u0027"},{"line_number":89,"context_line":"        elif method is \u0027createShareSnapshot\u0027:"},{"line_number":90,"context_line":"            return \u0027\u0027"},{"line_number":91,"context_line":"        elif method is \u0027deleteShareSnapshot\u0027:"},{"line_number":92,"context_line":"            return \u0027\u0027"},{"line_number":93,"context_line":"        elif method is \u0027cloneShareSnapshot\u0027:"},{"line_number":94,"context_line":"            return \u0027\u0027"},{"line_number":95,"context_line":"        elif method is \u0027listPools\u0027:"},{"line_number":96,"context_line":"            return \u0027\u0027"},{"line_number":97,"context_line":"        elif method is \u0027resizeShare\u0027:"},{"line_number":98,"context_line":"            return \u0027\u0027"},{"line_number":99,"context_line":"        elif method is \u0027getShareSizeinGB\u0027:"},{"line_number":100,"context_line":"            return 25"},{"line_number":101,"context_line":"        elif method is \u0027getISCSIMappingForShare\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_adf821c4","line":98,"range":{"start_line":87,"start_character":8,"end_line":98,"end_character":21},"updated":"2016-02-12 10:48:29.000000000","message":"One more kitten cries somewhere in the World when such subconditions are being implemented. Should be:\n\n\"\"\"\nif method is \u0027createShare\u0027:\n    return self._hostname\nelif method in (\u0027deleteShare\u0027, ...):\n    return \u0027\u0027\nelif ...\nelse:\n    # \"else\" must have if you do not expect None be returned.\n    # Assuming it, because you return empty \"string\".\n\"\"\"\n\nOr maybe you should return empty string in else and have only several expected conditions? - those 5 that have different return data.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                         fine_logging\u003dFalse):"},{"line_number":85,"context_line":"        if method is \u0027createShare\u0027:"},{"line_number":86,"context_line":"            return self._hostname"},{"line_number":87,"context_line":"        elif method is \u0027deleteShare\u0027:"},{"line_number":88,"context_line":"            return \u0027\u0027"},{"line_number":89,"context_line":"        elif method is \u0027createShareSnapshot\u0027:"},{"line_number":90,"context_line":"            return \u0027\u0027"},{"line_number":91,"context_line":"        elif method is \u0027deleteShareSnapshot\u0027:"},{"line_number":92,"context_line":"            return \u0027\u0027"},{"line_number":93,"context_line":"        elif method is \u0027cloneShareSnapshot\u0027:"},{"line_number":94,"context_line":"            return \u0027\u0027"},{"line_number":95,"context_line":"        elif method is \u0027listPools\u0027:"},{"line_number":96,"context_line":"            return \u0027\u0027"},{"line_number":97,"context_line":"        elif method is \u0027resizeShare\u0027:"},{"line_number":98,"context_line":"            return \u0027\u0027"},{"line_number":99,"context_line":"        elif method is \u0027getShareSizeinGB\u0027:"},{"line_number":100,"context_line":"            return 25"},{"line_number":101,"context_line":"        elif method is \u0027getISCSIMappingForShare\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_80fd2270","line":98,"range":{"start_line":87,"start_character":8,"end_line":98,"end_character":21},"in_reply_to":"3a57f1b5_adf821c4","updated":"2016-02-18 09:48:59.000000000","message":"kittens rescued.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_create_share(self):"},{"line_number":142,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":143,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":144,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":145,"context_line":"                               fake_tegile_backend):"},{"line_number":146,"context_line":"            self.assertEqual(\u0027some-ip:testshare\u0027,"},{"line_number":147,"context_line":"                             tegile_driver.create_share(self._ctxt,"},{"line_number":148,"context_line":"                                                        test_share))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_0db855c7","line":145,"range":{"start_line":143,"start_character":7,"end_line":145,"end_character":52},"updated":"2016-02-12 10:48:29.000000000","message":"We have nice method called \"self.mock_object(...)\" for such things. Please, use it instead of \"with\" thing.","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_create_share(self):"},{"line_number":142,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"},{"line_number":143,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":144,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":145,"context_line":"                               fake_tegile_backend):"},{"line_number":146,"context_line":"            self.assertEqual(\u0027some-ip:testshare\u0027,"},{"line_number":147,"context_line":"                             tegile_driver.create_share(self._ctxt,"},{"line_number":148,"context_line":"                                                        test_share))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_e0706e42","line":145,"range":{"start_line":143,"start_character":7,"end_line":145,"end_character":52},"in_reply_to":"3a57f1b5_0db855c7","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"47859a7ff1083bc81d7d563a33b886b2a47dd653","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":238,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":239,"context_line":"                               fake_tegile_backend):"},{"line_number":240,"context_line":"            self.assertEqual({\u0027driver_handles_share_servers\u0027: False,"},{"line_number":241,"context_line":"                              \u0027driver_version\u0027: \u00271.0.0\u0027,"},{"line_number":242,"context_line":"                              \u0027free_capacity_gb\u0027: 4565.381390112452,"},{"line_number":243,"context_line":"                              \u0027pools\u0027: [{\u0027QoS_support\u0027: False,"},{"line_number":244,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":245,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":246,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":247,"context_line":"                                         \u0027free_capacity_gb\u0027: 911.812650680542,"},{"line_number":248,"context_line":"                                         \u0027pool_name\u0027: \u0027pyramid\u0027,"},{"line_number":249,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":250,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":251,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":252,"context_line":"                                         \u0027total_capacity_gb\u0027: 913.5},"},{"line_number":253,"context_line":"                                        {\u0027QoS_support\u0027: False,"},{"line_number":254,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":255,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":256,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":257,"context_line":"                                         \u0027free_capacity_gb\u0027: 2740.148867149747,"},{"line_number":258,"context_line":"                                         \u0027pool_name\u0027: \u0027cobalt\u0027,"},{"line_number":259,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":260,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":261,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":262,"context_line":"                                         \u0027total_capacity_gb\u0027: 2742.1996604874},"},{"line_number":263,"context_line":"                                        {\u0027QoS_support\u0027: False,"},{"line_number":264,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":265,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":266,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":267,"context_line":"                                         \u0027free_capacity_gb\u0027: 913.4198722839355,"},{"line_number":268,"context_line":"                                         \u0027pool_name\u0027: \u0027test\u0027,"},{"line_number":269,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":270,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":271,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":272,"context_line":"                                         \u0027total_capacity_gb\u0027: 913.5}],"},{"line_number":273,"context_line":"                              \u0027qos\u0027: False,"},{"line_number":274,"context_line":"                              \u0027reserved_percentage\u0027: 0,"},{"line_number":275,"context_line":"                              \u0027share_backend_name\u0027: \u0027Tegile\u0027,"},{"line_number":276,"context_line":"                              \u0027snapshot_support\u0027: True,"},{"line_number":277,"context_line":"                              \u0027storage_protocol\u0027: \u0027NFS_CIFS\u0027,"},{"line_number":278,"context_line":"                              \u0027total_capacity_gb\u0027: 4569.199686084874,"},{"line_number":279,"context_line":"                              \u0027vendor_name\u0027: \u0027Tegile Systems Inc.\u0027},"},{"line_number":280,"context_line":"                             tegile_driver.get_share_stats(True))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_get_pool(self):"},{"line_number":283,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_0d913547","line":280,"range":{"start_line":240,"start_character":12,"end_line":280,"end_character":65},"updated":"2016-02-12 10:48:29.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"261f5a4264020127f89e10bafe5e63e829686bf4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":238,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":239,"context_line":"                               fake_tegile_backend):"},{"line_number":240,"context_line":"            self.assertEqual({\u0027driver_handles_share_servers\u0027: False,"},{"line_number":241,"context_line":"                              \u0027driver_version\u0027: \u00271.0.0\u0027,"},{"line_number":242,"context_line":"                              \u0027free_capacity_gb\u0027: 4565.381390112452,"},{"line_number":243,"context_line":"                              \u0027pools\u0027: [{\u0027QoS_support\u0027: False,"},{"line_number":244,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":245,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":246,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":247,"context_line":"                                         \u0027free_capacity_gb\u0027: 911.812650680542,"},{"line_number":248,"context_line":"                                         \u0027pool_name\u0027: \u0027pyramid\u0027,"},{"line_number":249,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":250,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":251,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":252,"context_line":"                                         \u0027total_capacity_gb\u0027: 913.5},"},{"line_number":253,"context_line":"                                        {\u0027QoS_support\u0027: False,"},{"line_number":254,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":255,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":256,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":257,"context_line":"                                         \u0027free_capacity_gb\u0027: 2740.148867149747,"},{"line_number":258,"context_line":"                                         \u0027pool_name\u0027: \u0027cobalt\u0027,"},{"line_number":259,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":260,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":261,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":262,"context_line":"                                         \u0027total_capacity_gb\u0027: 2742.1996604874},"},{"line_number":263,"context_line":"                                        {\u0027QoS_support\u0027: False,"},{"line_number":264,"context_line":"                                         \u0027allocated_capacity_gb\u0027: 0.0,"},{"line_number":265,"context_line":"                                         \u0027compression\u0027: True,"},{"line_number":266,"context_line":"                                         \u0027dedupe\u0027: True,"},{"line_number":267,"context_line":"                                         \u0027free_capacity_gb\u0027: 913.4198722839355,"},{"line_number":268,"context_line":"                                         \u0027pool_name\u0027: \u0027test\u0027,"},{"line_number":269,"context_line":"                                         \u0027qos\u0027: False,"},{"line_number":270,"context_line":"                                         \u0027reserved_percentage\u0027: 0,"},{"line_number":271,"context_line":"                                         \u0027thin_provisioning\u0027: True,"},{"line_number":272,"context_line":"                                         \u0027total_capacity_gb\u0027: 913.5}],"},{"line_number":273,"context_line":"                              \u0027qos\u0027: False,"},{"line_number":274,"context_line":"                              \u0027reserved_percentage\u0027: 0,"},{"line_number":275,"context_line":"                              \u0027share_backend_name\u0027: \u0027Tegile\u0027,"},{"line_number":276,"context_line":"                              \u0027snapshot_support\u0027: True,"},{"line_number":277,"context_line":"                              \u0027storage_protocol\u0027: \u0027NFS_CIFS\u0027,"},{"line_number":278,"context_line":"                              \u0027total_capacity_gb\u0027: 4569.199686084874,"},{"line_number":279,"context_line":"                              \u0027vendor_name\u0027: \u0027Tegile Systems Inc.\u0027},"},{"line_number":280,"context_line":"                             tegile_driver.get_share_stats(True))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_get_pool(self):"},{"line_number":283,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_c0a60aad","line":280,"range":{"start_line":240,"start_character":12,"end_line":280,"end_character":65},"in_reply_to":"3a57f1b5_0d913547","updated":"2016-02-18 09:48:59.000000000","message":"Done","commit_id":"01f7e9c14ed1c03706aeeab3f7c08a12b7eef907"}]}
