)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"83f1d205f7d4c5d09a9c211dd3dc284458849bae","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"    @na_utils.trace"},{"line_number":1784,"context_line":"    def get_cifs_share_access(self, share_name):"},{"line_number":1785,"context_line":"        api_args \u003d {"},{"line_number":1786,"context_line":"            \u0027max-records\u0027: 1000,"},{"line_number":1787,"context_line":"            \u0027query\u0027: {"},{"line_number":1788,"context_line":"                \u0027cifs-share-access-control\u0027: {"},{"line_number":1789,"context_line":"                    \u0027share\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_27236cbe","line":1786,"range":{"start_line":1786,"start_character":12,"end_line":1786,"end_character":32},"updated":"2016-02-18 18:59:41.000000000","message":"I don\u0027t know how your backend works, but what would happen if you have 1001 rules? The last one will not be returned? If so, it might break the update_access implementation.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"906c3e4ac0dbc419ac9547502b2a1df8f1092c75","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"    @na_utils.trace"},{"line_number":1784,"context_line":"    def get_cifs_share_access(self, share_name):"},{"line_number":1785,"context_line":"        api_args \u003d {"},{"line_number":1786,"context_line":"            \u0027max-records\u0027: 1000,"},{"line_number":1787,"context_line":"            \u0027query\u0027: {"},{"line_number":1788,"context_line":"                \u0027cifs-share-access-control\u0027: {"},{"line_number":1789,"context_line":"                    \u0027share\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_fcfc7673","line":1786,"range":{"start_line":1786,"start_character":12,"end_line":1786,"end_character":32},"in_reply_to":"dae33548_27236cbe","updated":"2016-02-18 19:51:28.000000000","message":"Correct, as written the API would only return 1000 rules.  I can set the number to anything, but it\u0027s difficult to imagine surpassing that in a cloud use case.  The default of 20 is obviously too low, which is why I set it much higher.  If you feel 1000 isn\u0027t enough, please help me understand that.\n\nThere is already a bug logged against this driver to implement getter API pagination generically for all getters, so that all records are always returned without having to set an arbitrary limit.  Any lingering concern would be fully addressed in that fix.  https://bugs.launchpad.net/manila/+bug/1500255","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5e34a5e46d74082d1fcf396f07994a827d3a83e9","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"            user_or_group \u003d rule.get_child_content(\u0027user-or-group\u0027)"},{"line_number":1809,"context_line":"            permission \u003d rule.get_child_content(\u0027permission\u0027)"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"            if permission \u003d\u003d \u0027read\u0027:"},{"line_number":1812,"context_line":"                rules[user_or_group] \u003d \u0027ro\u0027"},{"line_number":1813,"context_line":"            elif permission \u003d\u003d \u0027full_control\u0027:"},{"line_number":1814,"context_line":"                rules[user_or_group] \u003d \u0027rw\u0027"},{"line_number":1815,"context_line":"            elif permission \u003d\u003d \u0027change\u0027:"},{"line_number":1816,"context_line":"                rules[user_or_group] \u003d \u0027change\u0027"},{"line_number":1817,"context_line":"            elif permission \u003d\u003d \u0027no_access\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_7c5844fb","line":1814,"range":{"start_line":1811,"start_character":11,"end_line":1814,"end_character":43},"updated":"2016-02-19 15:49:09.000000000","message":"Since you are not translating the constants that you receive from the API to \u0027rw\u0027/\u0027ro\u0027, I believe it is safe to use constants here as well instead of hardcoded values.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f09533cedceef37d7699e73ff50b8f69b56bca47","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"            user_or_group \u003d rule.get_child_content(\u0027user-or-group\u0027)"},{"line_number":1809,"context_line":"            permission \u003d rule.get_child_content(\u0027permission\u0027)"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"            if permission \u003d\u003d \u0027read\u0027:"},{"line_number":1812,"context_line":"                rules[user_or_group] \u003d \u0027ro\u0027"},{"line_number":1813,"context_line":"            elif permission \u003d\u003d \u0027full_control\u0027:"},{"line_number":1814,"context_line":"                rules[user_or_group] \u003d \u0027rw\u0027"},{"line_number":1815,"context_line":"            elif permission \u003d\u003d \u0027change\u0027:"},{"line_number":1816,"context_line":"                rules[user_or_group] \u003d \u0027change\u0027"},{"line_number":1817,"context_line":"            elif permission \u003d\u003d \u0027no_access\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_e42127fd","line":1814,"range":{"start_line":1811,"start_character":11,"end_line":1814,"end_character":43},"in_reply_to":"bae84128_7c5844fb","updated":"2016-02-21 17:56:17.000000000","message":"Thanks, Rodrigo.  Thinking about this further, I\u0027d rather go the other way and not mingle manila and cDOT constants in the API client layer.  Better to let that remain pure cDOT and handle the translation in the driver layer.  The code is simpler that way, too.  So I made that change.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"83f1d205f7d4c5d09a9c211dd3dc284458849bae","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"                rules[user_or_group] \u003d \u0027ro\u0027"},{"line_number":1813,"context_line":"            elif permission \u003d\u003d \u0027full_control\u0027:"},{"line_number":1814,"context_line":"                rules[user_or_group] \u003d \u0027rw\u0027"},{"line_number":1815,"context_line":"            elif permission \u003d\u003d \u0027change\u0027:"},{"line_number":1816,"context_line":"                rules[user_or_group] \u003d \u0027change\u0027"},{"line_number":1817,"context_line":"            elif permission \u003d\u003d \u0027no_access\u0027:"},{"line_number":1818,"context_line":"                rules[user_or_group] \u003d \u0027no_access\u0027"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        return rules"},{"line_number":1821,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ed832301","line":1818,"range":{"start_line":1815,"start_character":0,"end_line":1818,"end_character":50},"updated":"2016-02-18 18:59:41.000000000","message":"These access_types are not supported by manila... will this ever be executed? In any case, I would suggest changing both these elifs to a single else, since you are not changing the values.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"906c3e4ac0dbc419ac9547502b2a1df8f1092c75","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"                rules[user_or_group] \u003d \u0027ro\u0027"},{"line_number":1813,"context_line":"            elif permission \u003d\u003d \u0027full_control\u0027:"},{"line_number":1814,"context_line":"                rules[user_or_group] \u003d \u0027rw\u0027"},{"line_number":1815,"context_line":"            elif permission \u003d\u003d \u0027change\u0027:"},{"line_number":1816,"context_line":"                rules[user_or_group] \u003d \u0027change\u0027"},{"line_number":1817,"context_line":"            elif permission \u003d\u003d \u0027no_access\u0027:"},{"line_number":1818,"context_line":"                rules[user_or_group] \u003d \u0027no_access\u0027"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        return rules"},{"line_number":1821,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_fc9d960a","line":1818,"range":{"start_line":1815,"start_character":0,"end_line":1818,"end_character":50},"in_reply_to":"dae33548_ed832301","updated":"2016-02-18 19:51:28.000000000","message":"The 4 values represented here are the full set of what my backend reports, even though Manila only uses 2 of them (\u0027read\u0027 and \u0027full_control\u0027).  One of my goals of this patch was to completely restore the set of rules as known to Manila, even if they had been set differently on the storage without Manila\u0027s knowledge, including having been set to any possible value.  I don\u0027t see an issue with these values being reported as such by the client layer; it doesn\u0027t affect the code in the protocol hander at the driver layer.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f09533cedceef37d7699e73ff50b8f69b56bca47","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"                rules[user_or_group] \u003d \u0027ro\u0027"},{"line_number":1813,"context_line":"            elif permission \u003d\u003d \u0027full_control\u0027:"},{"line_number":1814,"context_line":"                rules[user_or_group] \u003d \u0027rw\u0027"},{"line_number":1815,"context_line":"            elif permission \u003d\u003d \u0027change\u0027:"},{"line_number":1816,"context_line":"                rules[user_or_group] \u003d \u0027change\u0027"},{"line_number":1817,"context_line":"            elif permission \u003d\u003d \u0027no_access\u0027:"},{"line_number":1818,"context_line":"                rules[user_or_group] \u003d \u0027no_access\u0027"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"        return rules"},{"line_number":1821,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_041c0b76","line":1818,"range":{"start_line":1815,"start_character":0,"end_line":1818,"end_character":50},"in_reply_to":"dae33548_fc9d960a","updated":"2016-02-21 17:56:17.000000000","message":"By virtue of the change inspired by Rodrigo, Tiago\u0027s comment is also addressed since the various values are no longer called out here.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"}],"manila/share/drivers/netapp/dataontap/protocols/cifs_cmode.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"83f1d205f7d4c5d09a9c211dd3dc284458849bae","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        existing_rules \u003d self._get_access_rules(share, share_name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Update rules in an order that will prevent transient disruptions"},{"line_number":64,"context_line":"        share_name \u003d self.get_share_name_for_share(share)"},{"line_number":65,"context_line":"        self._handle_added_rules(share_name, existing_rules, new_rules)"},{"line_number":66,"context_line":"        self._handle_ro_to_rw_rules(share_name, existing_rules, new_rules)"},{"line_number":67,"context_line":"        self._handle_rw_to_ro_rules(share_name, existing_rules, new_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_275c0c4a","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":57},"updated":"2016-02-18 18:59:41.000000000","message":"Why is this needed here but not on the previous call (_get_access_rules)?","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"906c3e4ac0dbc419ac9547502b2a1df8f1092c75","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        existing_rules \u003d self._get_access_rules(share, share_name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Update rules in an order that will prevent transient disruptions"},{"line_number":64,"context_line":"        share_name \u003d self.get_share_name_for_share(share)"},{"line_number":65,"context_line":"        self._handle_added_rules(share_name, existing_rules, new_rules)"},{"line_number":66,"context_line":"        self._handle_ro_to_rw_rules(share_name, existing_rules, new_rules)"},{"line_number":67,"context_line":"        self._handle_rw_to_ro_rules(share_name, existing_rules, new_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_dc3c12e3","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":57},"in_reply_to":"dae33548_275c0c4a","updated":"2016-02-18 19:51:28.000000000","message":"Theoretically, this shouldn\u0027t be necessary, assuming the export location always correctly reflects the share name.  I\u0027m comfortable removing this in the next patch set.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f09533cedceef37d7699e73ff50b8f69b56bca47","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        existing_rules \u003d self._get_access_rules(share, share_name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Update rules in an order that will prevent transient disruptions"},{"line_number":64,"context_line":"        share_name \u003d self.get_share_name_for_share(share)"},{"line_number":65,"context_line":"        self._handle_added_rules(share_name, existing_rules, new_rules)"},{"line_number":66,"context_line":"        self._handle_ro_to_rw_rules(share_name, existing_rules, new_rules)"},{"line_number":67,"context_line":"        self._handle_rw_to_ro_rules(share_name, existing_rules, new_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_a40d5f40","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":57},"in_reply_to":"dae33548_dc3c12e3","updated":"2016-02-21 17:56:17.000000000","message":"Line removed.","commit_id":"d7a865c84449e9305746ec5a761684c2e34c226f"}],"manila/share/drivers/netapp/dataontap/protocols/nfs_cmode.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed5e84b8bdf520066436178bdbd73e8eb31e976","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    @staticmethod"},{"line_number":157,"context_line":"    def _get_temp_export_policy_name():"},{"line_number":158,"context_line":"        \"\"\"Builds export policy name for an NFS share.\"\"\""},{"line_number":159,"context_line":"        return \u0027temp_\u0027 + six.text_type(uuid.uuid1()).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @staticmethod"},{"line_number":162,"context_line":"    def _get_export_policy_name(share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_71193b88","line":159,"range":{"start_line":159,"start_character":25,"end_line":159,"end_character":69},"updated":"2016-02-22 12:18:52.000000000","message":"Maybe usage of instantaneous time would be better? Using \"timeutils.utcnow().isoformat()\"","commit_id":"6ef648282284492e905ff789668e2753382bbf27"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1c12f8ea225999b2257a04aa8c658f1ae1ccabd2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    @staticmethod"},{"line_number":157,"context_line":"    def _get_temp_export_policy_name():"},{"line_number":158,"context_line":"        \"\"\"Builds export policy name for an NFS share.\"\"\""},{"line_number":159,"context_line":"        return \u0027temp_\u0027 + six.text_type(uuid.uuid1()).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @staticmethod"},{"line_number":162,"context_line":"    def _get_export_policy_name(share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_7055a0f8","line":159,"range":{"start_line":159,"start_character":25,"end_line":159,"end_character":69},"in_reply_to":"bae84128_71193b88","updated":"2016-02-22 21:45:04.000000000","message":"Please help me understand why that would be better?  I really just need a policy name that is obviously temporary and guaranteed unique.  utcnow() would probably be sufficiently unique, but I also liked the uniformity of export policy names:\n\npolicy_dff15830_d997_11e5_a085_3c15c2d1d87c\ntemp_a67a28ee_d998_11e5_983a_9b581bd1d2d6","commit_id":"6ef648282284492e905ff789668e2753382bbf27"}]}
