)]}'
{"manila/share/drivers/quobyte/quobyte.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        a_type \u003d \u0027ro\u0027"},{"line_number":104,"context_line":"                    qb_access_list.append({"},{"line_number":105,"context_line":"                        \u0027access_to\u0027: va[\u0027restrict_to_network\u0027],"},{"line_number":106,"context_line":"                        \u0027access_level\u0027: a_type,"},{"line_number":107,"context_line":"                        \u0027access_type\u0027: \u0027ip\u0027"},{"line_number":108,"context_line":"                    })"},{"line_number":109,"context_line":"        return qb_access_list"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_25e60d15","line":106,"range":{"start_line":106,"start_character":40,"end_line":106,"end_character":46},"updated":"2016-02-17 17:25:00.000000000","message":"Please rename this one. We have access_level and access_type and this _looks_ mixed up.  I guess if it is quobyte terminology you can disagree -- but it doesn\u0027t look good.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        a_type \u003d \u0027ro\u0027"},{"line_number":104,"context_line":"                    qb_access_list.append({"},{"line_number":105,"context_line":"                        \u0027access_to\u0027: va[\u0027restrict_to_network\u0027],"},{"line_number":106,"context_line":"                        \u0027access_level\u0027: a_type,"},{"line_number":107,"context_line":"                        \u0027access_type\u0027: \u0027ip\u0027"},{"line_number":108,"context_line":"                    })"},{"line_number":109,"context_line":"        return qb_access_list"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_21b4217e","line":106,"range":{"start_line":106,"start_character":40,"end_line":106,"end_character":46},"in_reply_to":"dae33548_25e60d15","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_454d113d","line":184,"updated":"2016-02-17 17:25:00.000000000","message":"math-speak. Will this be on the exam?","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a14dd19b","line":184,"in_reply_to":"dae33548_454d113d","updated":"2016-02-18 09:40:14.000000000","message":"Definitely! ;)\n\nAdded a comment to be more readily understandable.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_655015d5","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":15},"updated":"2016-02-17 17:25:00.000000000","message":"nit - Your not filtering on \u0027ip\u0027 so you should rename this.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_bc0b3823","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":15},"in_reply_to":"dae33548_655015d5","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6bae9e4d72114c3911ab45c79f31cbfbbd80b623","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("},{"line_number":189,"context_line":"            {\"to\": r.get(\"access_to\"),"},{"line_number":190,"context_line":"             \"type\": r.get(\"access_type\")} not in sub_ip_list)]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":193,"context_line":"        \"\"\"Create or export a volume that is usable as a Manila share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3615ad3f","line":190,"range":{"start_line":184,"start_character":0,"end_line":190,"end_character":63},"updated":"2016-02-17 16:05:50.000000000","message":"You should compare access_level as well.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("},{"line_number":189,"context_line":"            {\"to\": r.get(\"access_to\"),"},{"line_number":190,"context_line":"             \"type\": r.get(\"access_type\")} not in sub_ip_list)]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":193,"context_line":"        \"\"\"Create or export a volume that is usable as a Manila share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_45d0711f","line":190,"range":{"start_line":184,"start_character":0,"end_line":190,"end_character":63},"in_reply_to":"dae33548_3615ad3f","updated":"2016-02-17 17:25:00.000000000","message":"+1","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("},{"line_number":189,"context_line":"            {\"to\": r.get(\"access_to\"),"},{"line_number":190,"context_line":"             \"type\": r.get(\"access_type\")} not in sub_ip_list)]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":193,"context_line":"        \"\"\"Create or export a volume that is usable as a Manila share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3c1568e4","line":190,"range":{"start_line":184,"start_character":0,"end_line":190,"end_character":63},"in_reply_to":"dae33548_3615ad3f","updated":"2016-02-18 09:40:14.000000000","message":"Done.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend, subtrahend):"},{"line_number":185,"context_line":"        sub_ip_list \u003d []"},{"line_number":186,"context_line":"        sub_ip_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":187,"context_line":"                           \"type\": s.get(\u0027access_type\u0027)} for s in subtrahend]"},{"line_number":188,"context_line":"        return [r for r in minuend if ("},{"line_number":189,"context_line":"            {\"to\": r.get(\"access_to\"),"},{"line_number":190,"context_line":"             \"type\": r.get(\"access_type\")} not in sub_ip_list)]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":193,"context_line":"        \"\"\"Create or export a volume that is usable as a Manila share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9cd63426","line":190,"range":{"start_line":184,"start_character":0,"end_line":190,"end_character":63},"in_reply_to":"dae33548_45d0711f","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        return \u0027%(nfs_server_ip)s:%(nfs_export_path)s\u0027 % result"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":267,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":268,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":269,"context_line":"            raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_5b1b32ca","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":20},"updated":"2016-02-17 17:56:58.000000000","message":"please rename this to _allow_access to prevent it from being called otherwise.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        return \u0027%(nfs_server_ip)s:%(nfs_export_path)s\u0027 % result"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":267,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":268,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":269,"context_line":"            raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_7ce370d9","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":20},"in_reply_to":"dae33548_5b1b32ca","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":273,"context_line":"            share[\u0027name\u0027],"},{"line_number":274,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":275,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":276,"context_line":"            volume_uuid\u003dvolume_uuid,"},{"line_number":277,"context_line":"            read_only\u003daccess[\u0027access_level\u0027] \u003d\u003d (manila.common.constants."},{"line_number":278,"context_line":"                                                 ACCESS_LEVEL_RO),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_1b6c0a34","line":275,"range":{"start_line":275,"start_character":38,"end_line":275,"end_character":43},"updated":"2016-02-17 17:56:58.000000000","message":"do not use dict(), use {}","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":273,"context_line":"            share[\u0027name\u0027],"},{"line_number":274,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":275,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":276,"context_line":"            volume_uuid\u003dvolume_uuid,"},{"line_number":277,"context_line":"            read_only\u003daccess[\u0027access_level\u0027] \u003d\u003d (manila.common.constants."},{"line_number":278,"context_line":"                                                 ACCESS_LEVEL_RO),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_bc85f8cf","line":275,"range":{"start_line":275,"start_character":38,"end_line":275,"end_character":43},"in_reply_to":"dae33548_1b6c0a34","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                                 ACCESS_LEVEL_RO),"},{"line_number":279,"context_line":"            add_allow_ip\u003daccess[\u0027access_to\u0027]))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":282,"context_line":"        \"\"\"Remove white-list ip from a share.\"\"\""},{"line_number":283,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Quobyte driver only supports ip access control. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_db8582cf","line":281,"updated":"2016-02-17 17:56:58.000000000","message":"please rename this to _deny_access to prevent it from being called otherwise.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                                 ACCESS_LEVEL_RO),"},{"line_number":279,"context_line":"            add_allow_ip\u003daccess[\u0027access_to\u0027]))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":282,"context_line":"        \"\"\"Remove white-list ip from a share.\"\"\""},{"line_number":283,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Quobyte driver only supports ip access control. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_dce6fce6","line":281,"in_reply_to":"dae33548_db8582cf","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":291,"context_line":"            share[\u0027name\u0027],"},{"line_number":292,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":293,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":294,"context_line":"            volume_uuid\u003dvolume_uuid,"},{"line_number":295,"context_line":"            remove_allow_ip\u003daccess[\u0027access_to\u0027]))"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_5b721212","line":293,"range":{"start_line":293,"start_character":38,"end_line":293,"end_character":43},"updated":"2016-02-17 17:56:58.000000000","message":"do not use dict(), use {}","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":291,"context_line":"            share[\u0027name\u0027],"},{"line_number":292,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":293,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":294,"context_line":"            volume_uuid\u003dvolume_uuid,"},{"line_number":295,"context_line":"            remove_allow_ip\u003daccess[\u0027access_to\u0027]))"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_1c71840f","line":293,"range":{"start_line":293,"start_character":38,"end_line":293,"end_character":43},"in_reply_to":"dae33548_5b721212","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                        self.allow_access(context, share, a_rule)"},{"line_number":349,"context_line":"                if delete_rules is not None:"},{"line_number":350,"context_line":"                    for d_rule in delete_rules:"},{"line_number":351,"context_line":"                        self.deny_access(context, share, d_rule)"},{"line_number":352,"context_line":"        else:"},{"line_number":353,"context_line":"            if access_rules is None:"},{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_406a1fb4","line":351,"updated":"2016-02-17 17:25:00.000000000","message":"Can you have an IP that is both RO and RW?  If not, you might need to do the deletes first -- in case there is a conflicting add.  Anyone else run into this?","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        InvalidShareAccess exception"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":345,"context_line":"                # Handling access rule update"},{"line_number":346,"context_line":"                if add_rules is not None:"},{"line_number":347,"context_line":"                    for a_rule in add_rules:"},{"line_number":348,"context_line":"                        self.allow_access(context, share, a_rule)"},{"line_number":349,"context_line":"                if delete_rules is not None:"},{"line_number":350,"context_line":"                    for d_rule in delete_rules:"},{"line_number":351,"context_line":"                        self.deny_access(context, share, d_rule)"},{"line_number":352,"context_line":"        else:"},{"line_number":353,"context_line":"            if access_rules is None:"},{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_7bef16e9","line":351,"range":{"start_line":345,"start_character":0,"end_line":351,"end_character":64},"updated":"2016-02-17 17:56:58.000000000","message":"unecessary extra identation here","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                        self.allow_access(context, share, a_rule)"},{"line_number":349,"context_line":"                if delete_rules is not None:"},{"line_number":350,"context_line":"                    for d_rule in delete_rules:"},{"line_number":351,"context_line":"                        self.deny_access(context, share, d_rule)"},{"line_number":352,"context_line":"        else:"},{"line_number":353,"context_line":"            if access_rules is None:"},{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3d2f2140","line":351,"in_reply_to":"dae33548_406a1fb4","updated":"2016-02-18 09:40:14.000000000","message":"It is possible but I\u0027ll switch order as the behaviour in that state is not clearly defined.\nDone.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        InvalidShareAccess exception"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":345,"context_line":"                # Handling access rule update"},{"line_number":346,"context_line":"                if add_rules is not None:"},{"line_number":347,"context_line":"                    for a_rule in add_rules:"},{"line_number":348,"context_line":"                        self.allow_access(context, share, a_rule)"},{"line_number":349,"context_line":"                if delete_rules is not None:"},{"line_number":350,"context_line":"                    for d_rule in delete_rules:"},{"line_number":351,"context_line":"                        self.deny_access(context, share, d_rule)"},{"line_number":352,"context_line":"        else:"},{"line_number":353,"context_line":"            if access_rules is None:"},{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_1c586487","line":351,"range":{"start_line":345,"start_character":0,"end_line":351,"end_character":64},"in_reply_to":"dae33548_7bef16e9","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_fbe4c6e0","line":363,"range":{"start_line":363,"start_character":56,"end_line":363,"end_character":58},"updated":"2016-02-17 17:56:58.000000000","message":"add a period","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_7c66d051","line":363,"range":{"start_line":363,"start_character":56,"end_line":363,"end_character":58},"in_reply_to":"dae33548_fbe4c6e0","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2326e1097bf0424dd7d594f565b9cc280baa64d3","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_dbe902b9","line":369,"range":{"start_line":369,"start_character":58,"end_line":369,"end_character":60},"updated":"2016-02-17 17:56:58.000000000","message":"add a period","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9c63d441","line":369,"range":{"start_line":369,"start_character":58,"end_line":369,"end_character":60},"in_reply_to":"dae33548_dbe902b9","updated":"2016-02-18 09:40:14.000000000","message":"Done","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6bae9e4d72114c3911ab45c79f31cbfbbd80b623","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":355,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # Handling access rule recovery"},{"line_number":358,"context_line":"                existing_rules \u003d self._fetch_existing_access(context, share)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_56a83177","line":370,"range":{"start_line":357,"start_character":0,"end_line":370,"end_character":60},"updated":"2016-02-17 16:05:50.000000000","message":"Since the _subtract_access_lists method does not compare access_level, the update_access will not update some existing access level, which might break features that use the update_access directly, like share migration.\n\nYour previous implementation was ok, you just needed to clear any previous access rules, like you are doing in lines 366-370.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fbef5a53856d416266c30a23320c2aa4085a854f","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":355,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # Handling access rule recovery"},{"line_number":358,"context_line":"                existing_rules \u003d self._fetch_existing_access(context, share)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_e5b8a577","line":370,"range":{"start_line":357,"start_character":0,"end_line":370,"end_character":60},"in_reply_to":"dae33548_56a83177","updated":"2016-02-17 17:25:00.000000000","message":"+1","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":355,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # Handling access rule recovery"},{"line_number":358,"context_line":"                existing_rules \u003d self._fetch_existing_access(context, share)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9c1bd480","line":370,"range":{"start_line":357,"start_character":0,"end_line":370,"end_character":60},"in_reply_to":"dae33548_56a83177","updated":"2016-02-18 09:40:14.000000000","message":"_subtract_access_lists now also compares access_level so different access_levels should be detected and updated accordingly. Added this case to an existing tests data.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"64d06503d5f903be1404376f9f7d097c06c09f0b","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":355,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # Handling access rule recovery"},{"line_number":358,"context_line":"                existing_rules \u003d self._fetch_existing_access(context, share)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":361,"context_line":"                                                            existing_rules)"},{"line_number":362,"context_line":"                for a_rule in missing_rules:"},{"line_number":363,"context_line":"                    LOG.debug(\"Adding rule %s in recovery\" % str(a_rule))"},{"line_number":364,"context_line":"                    self.allow_access(context, share, a_rule)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":367,"context_line":"                                                                access_rules)"},{"line_number":368,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":369,"context_line":"                    LOG.debug(\"Removing rule %s in recovery\" % str(d_rule))"},{"line_number":370,"context_line":"                    self.deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_dc11dc5e","line":370,"range":{"start_line":357,"start_character":0,"end_line":370,"end_character":60},"in_reply_to":"dae33548_e5b8a577","updated":"2016-02-18 09:40:14.000000000","message":"pls see above.","commit_id":"cd0bc355bc3c662de9b3f98b17f21f2367ec340d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b3f8e77573a3ca9d9b8000bd89c4ce4d954ae284","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend_list, subtrahend_list):"},{"line_number":185,"context_line":"        \"\"\"Subtracts access_rules from a list in another to return the diff"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        Returns a list of elements from minuend_list that are not elements"},{"line_number":188,"context_line":"        of list subtrahend_list. Uses access_to, access_type and access_level"},{"line_number":189,"context_line":"        for comparison (not access_id)."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param minuend_list: Base list of access rules"},{"line_number":192,"context_line":"        :param subtrahend_list:  List of access rules not to be returned"},{"line_number":193,"context_line":"        :return: List of elements of minuend_list not present in"},{"line_number":194,"context_line":"        subtrahend_list"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        sub_tuples_list \u003d []"},{"line_number":197,"context_line":"        sub_tuples_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":198,"context_line":"                               \"type\": s.get(\u0027access_type\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_20c89173","line":195,"range":{"start_line":184,"start_character":0,"end_line":195,"end_character":11},"updated":"2016-02-18 10:54:47.000000000","message":"I think this is still unnecessarily difficult to understand. Just a suggestion:\n\nChange parameters to list_a and list_b.\n\nChange description to something simpler, like: Returns a list of elements in list_a that are not in list_b.","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"25c108ed25c979ff1a1c56caf3841086c43df9b9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return result[\u0027volume_uuid\u0027]"},{"line_number":182,"context_line":"        return None  # not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _subtract_access_lists(self, minuend_list, subtrahend_list):"},{"line_number":185,"context_line":"        \"\"\"Subtracts access_rules from a list in another to return the diff"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        Returns a list of elements from minuend_list that are not elements"},{"line_number":188,"context_line":"        of list subtrahend_list. Uses access_to, access_type and access_level"},{"line_number":189,"context_line":"        for comparison (not access_id)."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param minuend_list: Base list of access rules"},{"line_number":192,"context_line":"        :param subtrahend_list:  List of access rules not to be returned"},{"line_number":193,"context_line":"        :return: List of elements of minuend_list not present in"},{"line_number":194,"context_line":"        subtrahend_list"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        sub_tuples_list \u003d []"},{"line_number":197,"context_line":"        sub_tuples_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":198,"context_line":"                               \"type\": s.get(\u0027access_type\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_eaa4c04b","line":195,"range":{"start_line":184,"start_character":0,"end_line":195,"end_character":11},"in_reply_to":"dae33548_20c89173","updated":"2016-02-18 12:55:09.000000000","message":"Done","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b3f8e77573a3ca9d9b8000bd89c4ce4d954ae284","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":376,"context_line":"                                                            existing_rules)"},{"line_number":377,"context_line":"                for a_rule in missing_rules:"},{"line_number":378,"context_line":"                    LOG.debug(\"Adding rule %s in recovery.\" % str(a_rule))"},{"line_number":379,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_e0e0692b","line":378,"range":{"start_line":378,"start_character":60,"end_line":378,"end_character":61},"updated":"2016-02-18 10:54:47.000000000","message":"Use the debug method to format the string. Change % to ,","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b3f8e77573a3ca9d9b8000bd89c4ce4d954ae284","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":376,"context_line":"                                                            existing_rules)"},{"line_number":377,"context_line":"                for a_rule in missing_rules:"},{"line_number":378,"context_line":"                    LOG.debug(\"Adding rule %s in recovery.\" % str(a_rule))"},{"line_number":379,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_6c59f58d","line":378,"range":{"start_line":378,"start_character":62,"end_line":378,"end_character":65},"updated":"2016-02-18 10:54:47.000000000","message":"six.text_type","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"25c108ed25c979ff1a1c56caf3841086c43df9b9","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":376,"context_line":"                                                            existing_rules)"},{"line_number":377,"context_line":"                for a_rule in missing_rules:"},{"line_number":378,"context_line":"                    LOG.debug(\"Adding rule %s in recovery.\" % str(a_rule))"},{"line_number":379,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_2acd0831","line":378,"range":{"start_line":378,"start_character":62,"end_line":378,"end_character":65},"in_reply_to":"dae33548_6c59f58d","updated":"2016-02-18 12:55:09.000000000","message":"Done","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"25c108ed25c979ff1a1c56caf3841086c43df9b9","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                missing_rules \u003d self._subtract_access_lists(access_rules,"},{"line_number":376,"context_line":"                                                            existing_rules)"},{"line_number":377,"context_line":"                for a_rule in missing_rules:"},{"line_number":378,"context_line":"                    LOG.debug(\"Adding rule %s in recovery.\" % str(a_rule))"},{"line_number":379,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_0a4e44c0","line":378,"range":{"start_line":378,"start_character":60,"end_line":378,"end_character":61},"in_reply_to":"dae33548_e0e0692b","updated":"2016-02-18 12:55:09.000000000","message":"Done","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b3f8e77573a3ca9d9b8000bd89c4ce4d954ae284","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":382,"context_line":"                                                                access_rules)"},{"line_number":383,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":384,"context_line":"                    LOG.debug(\"Removing rule %s in recovery.\" % str(d_rule))"},{"line_number":385,"context_line":"                    self._deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_c0dba57a","line":384,"range":{"start_line":384,"start_character":62,"end_line":384,"end_character":63},"updated":"2016-02-18 10:54:47.000000000","message":"Same","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b3f8e77573a3ca9d9b8000bd89c4ce4d954ae284","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":382,"context_line":"                                                                access_rules)"},{"line_number":383,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":384,"context_line":"                    LOG.debug(\"Removing rule %s in recovery.\" % str(d_rule))"},{"line_number":385,"context_line":"                    self._deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_4c5cf17c","line":384,"range":{"start_line":384,"start_character":64,"end_line":384,"end_character":67},"updated":"2016-02-18 10:54:47.000000000","message":"six.text_type","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"25c108ed25c979ff1a1c56caf3841086c43df9b9","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":382,"context_line":"                                                                access_rules)"},{"line_number":383,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":384,"context_line":"                    LOG.debug(\"Removing rule %s in recovery.\" % str(d_rule))"},{"line_number":385,"context_line":"                    self._deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_aa52b864","line":384,"range":{"start_line":384,"start_character":64,"end_line":384,"end_character":67},"in_reply_to":"dae33548_4c5cf17c","updated":"2016-02-18 12:55:09.000000000","message":"Done","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"25c108ed25c979ff1a1c56caf3841086c43df9b9","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                superfluous_rules \u003d self._subtract_access_lists(existing_rules,"},{"line_number":382,"context_line":"                                                                access_rules)"},{"line_number":383,"context_line":"                for d_rule in superfluous_rules:"},{"line_number":384,"context_line":"                    LOG.debug(\"Removing rule %s in recovery.\" % str(d_rule))"},{"line_number":385,"context_line":"                    self._deny_access(context, share, d_rule)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_ca573c56","line":384,"range":{"start_line":384,"start_character":62,"end_line":384,"end_character":63},"in_reply_to":"dae33548_c0dba57a","updated":"2016-02-18 12:55:09.000000000","message":"Done","commit_id":"ef4cae6a780778582987e13e79f5a2844ebcb0ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"64b8dc222dafaf1a2ebec3aec81dfe0586ba00fa","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        for tc in tenant_configs:"},{"line_number":100,"context_line":"            for va in tc[\u0027volume_access\u0027]:"},{"line_number":101,"context_line":"                if va[\u0027volume_uuid\u0027] \u003d\u003d volume_uuid:"},{"line_number":102,"context_line":"                    a_level \u003d \u0027rw\u0027"},{"line_number":103,"context_line":"                    if va[\u0027read_only\u0027]:"},{"line_number":104,"context_line":"                        a_level \u003d \u0027ro\u0027"},{"line_number":105,"context_line":"                    qb_access_list.append({"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_9d90b497","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":34},"updated":"2016-02-19 11:51:43.000000000","message":"use constants.ACCESS_LEVEL_RW","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"4d9bded1a2eaddb55caef1f4139d2ac043ab7978","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        for tc in tenant_configs:"},{"line_number":100,"context_line":"            for va in tc[\u0027volume_access\u0027]:"},{"line_number":101,"context_line":"                if va[\u0027volume_uuid\u0027] \u003d\u003d volume_uuid:"},{"line_number":102,"context_line":"                    a_level \u003d \u0027rw\u0027"},{"line_number":103,"context_line":"                    if va[\u0027read_only\u0027]:"},{"line_number":104,"context_line":"                        a_level \u003d \u0027ro\u0027"},{"line_number":105,"context_line":"                    qb_access_list.append({"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_fb5f4873","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":34},"in_reply_to":"bae84128_9d90b497","updated":"2016-02-19 12:26:39.000000000","message":"Done","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"64b8dc222dafaf1a2ebec3aec81dfe0586ba00fa","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                if va[\u0027volume_uuid\u0027] \u003d\u003d volume_uuid:"},{"line_number":102,"context_line":"                    a_level \u003d \u0027rw\u0027"},{"line_number":103,"context_line":"                    if va[\u0027read_only\u0027]:"},{"line_number":104,"context_line":"                        a_level \u003d \u0027ro\u0027"},{"line_number":105,"context_line":"                    qb_access_list.append({"},{"line_number":106,"context_line":"                        \u0027access_to\u0027: va[\u0027restrict_to_network\u0027],"},{"line_number":107,"context_line":"                        \u0027access_level\u0027: a_level,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_bdedb827","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":38},"updated":"2016-02-19 11:51:43.000000000","message":"use constants.ACCESS_LEVEL_RO","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"4d9bded1a2eaddb55caef1f4139d2ac043ab7978","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                if va[\u0027volume_uuid\u0027] \u003d\u003d volume_uuid:"},{"line_number":102,"context_line":"                    a_level \u003d \u0027rw\u0027"},{"line_number":103,"context_line":"                    if va[\u0027read_only\u0027]:"},{"line_number":104,"context_line":"                        a_level \u003d \u0027ro\u0027"},{"line_number":105,"context_line":"                    qb_access_list.append({"},{"line_number":106,"context_line":"                        \u0027access_to\u0027: va[\u0027restrict_to_network\u0027],"},{"line_number":107,"context_line":"                        \u0027access_level\u0027: a_level,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_1b5f8c73","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":38},"in_reply_to":"bae84128_bdedb827","updated":"2016-02-19 12:26:39.000000000","message":"Done","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"64b8dc222dafaf1a2ebec3aec81dfe0586ba00fa","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":284,"context_line":"            share[\u0027name\u0027],"},{"line_number":285,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":286,"context_line":"        ro \u003d access[\u0027access_level\u0027] \u003d\u003d (manila.common.constants."},{"line_number":287,"context_line":"                                        ACCESS_LEVEL_RO)"},{"line_number":288,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, {"},{"line_number":289,"context_line":"            \"volume_uuid\": volume_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_fd13c00b","line":286,"range":{"start_line":286,"start_character":40,"end_line":286,"end_character":63},"updated":"2016-02-19 11:51:43.000000000","message":"it is nicer to \"from manila.common import constants\"","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"4d9bded1a2eaddb55caef1f4139d2ac043ab7978","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        volume_uuid \u003d self._resolve_volume_name("},{"line_number":284,"context_line":"            share[\u0027name\u0027],"},{"line_number":285,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":286,"context_line":"        ro \u003d access[\u0027access_level\u0027] \u003d\u003d (manila.common.constants."},{"line_number":287,"context_line":"                                        ACCESS_LEVEL_RO)"},{"line_number":288,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, {"},{"line_number":289,"context_line":"            \"volume_uuid\": volume_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_7b54d853","line":286,"range":{"start_line":286,"start_character":40,"end_line":286,"end_character":63},"in_reply_to":"bae84128_fd13c00b","updated":"2016-02-19 12:26:39.000000000","message":"Done","commit_id":"079e62eb7b6e6c7efb77cf8498dc883ae4ff0523"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1867170fc8db9ec591010f3bcad0bf4ae247d56e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        list_b"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        sub_tuples_list \u003d []"},{"line_number":194,"context_line":"        sub_tuples_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":195,"context_line":"                               \"type\": s.get(\u0027access_type\u0027),"},{"line_number":196,"context_line":"                               \"level\": s.get(\u0027access_level\u0027)}"},{"line_number":197,"context_line":"                              for s in list_b]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_308506ad","line":194,"range":{"start_line":194,"start_character":23,"end_line":194,"end_character":26},"updated":"2016-02-21 18:50:41.000000000","message":"Why is it better to use this syntax when you could just combine it with the list creation on the previous line?","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        list_b"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        sub_tuples_list \u003d []"},{"line_number":194,"context_line":"        sub_tuples_list[:] \u003d [{\"to\": s.get(\u0027access_to\u0027),"},{"line_number":195,"context_line":"                               \"type\": s.get(\u0027access_type\u0027),"},{"line_number":196,"context_line":"                               \"level\": s.get(\u0027access_level\u0027)}"},{"line_number":197,"context_line":"                              for s in list_b]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_fb125608","line":194,"range":{"start_line":194,"start_character":23,"end_line":194,"end_character":26},"in_reply_to":"bae84128_308506ad","updated":"2016-02-22 08:31:12.000000000","message":"Done","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1867170fc8db9ec591010f3bcad0bf4ae247d56e","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            share[\u0027name\u0027],"},{"line_number":285,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":286,"context_line":"        ro \u003d access[\u0027access_level\u0027] \u003d\u003d (constants.ACCESS_LEVEL_RO)"},{"line_number":287,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, {"},{"line_number":288,"context_line":"            \"volume_uuid\": volume_uuid,"},{"line_number":289,"context_line":"            \"read_only\": ro,"},{"line_number":290,"context_line":"            \"add_allow_ip\": access[\u0027access_to\u0027]})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":293,"context_line":"        \"\"\"Remove white-list ip from a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_50b1aa8e","line":290,"range":{"start_line":287,"start_character":38,"end_line":290,"end_character":48},"updated":"2016-02-21 18:50:41.000000000","message":"The guidelines would have you create the dict before calling the method.  Same in _deny_access.\n\nhttp://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            share[\u0027name\u0027],"},{"line_number":285,"context_line":"            self._get_project_name(context, share[\u0027project_id\u0027]))"},{"line_number":286,"context_line":"        ro \u003d access[\u0027access_level\u0027] \u003d\u003d (constants.ACCESS_LEVEL_RO)"},{"line_number":287,"context_line":"        self.rpc.call(\u0027exportVolume\u0027, {"},{"line_number":288,"context_line":"            \"volume_uuid\": volume_uuid,"},{"line_number":289,"context_line":"            \"read_only\": ro,"},{"line_number":290,"context_line":"            \"add_allow_ip\": access[\u0027access_to\u0027]})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":293,"context_line":"        \"\"\"Remove white-list ip from a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_9ba06aa1","line":290,"range":{"start_line":287,"start_character":38,"end_line":290,"end_character":48},"in_reply_to":"bae84128_50b1aa8e","updated":"2016-02-22 08:31:12.000000000","message":"I see the point. I updated these methods accordingly. However the inline dict creation is used on several methods in here, please note that i do not change the other methods right now as that is outside the scope of this change.\nI\u0027ll add a ticket to switch the other calls in a different change.","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"ca3c833117cc758c3c51c5b5d0c0498b9c5588de","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :raises If all of the *_rules params are None the method raises an"},{"line_number":353,"context_line":"        InvalidShareAccess exception"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_89c7a811","line":355,"updated":"2016-02-20 13:04:28.000000000","message":"Can code be more concise?\n\nif not (add_rules or delete_rules):\n\nAs implemented in the reference driver.","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :raises If all of the *_rules params are None the method raises an"},{"line_number":353,"context_line":"        InvalidShareAccess exception"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_37aa0e71","line":355,"in_reply_to":"bae84128_305a2651","updated":"2016-02-22 08:31:12.000000000","message":"Done","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1867170fc8db9ec591010f3bcad0bf4ae247d56e","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :raises If all of the *_rules params are None the method raises an"},{"line_number":353,"context_line":"        InvalidShareAccess exception"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_305a2651","line":355,"in_reply_to":"bae84128_89c7a811","updated":"2016-02-21 18:50:41.000000000","message":"+1","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :raises If all of the *_rules params are None the method raises an"},{"line_number":353,"context_line":"        InvalidShareAccess exception"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_fbb376e7","line":355,"in_reply_to":"bae84128_89c7a811","updated":"2016-02-22 08:31:12.000000000","message":"Done","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1867170fc8db9ec591010f3bcad0bf4ae247d56e","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"},{"line_number":359,"context_line":"                    self._deny_access(context, share, d_rule)"},{"line_number":360,"context_line":"            if add_rules is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_f070bede","line":357,"range":{"start_line":357,"start_character":12,"end_line":357,"end_character":40},"updated":"2016-02-21 18:50:41.000000000","message":"delete_rules is always a list, so you probably don\u0027t need this line.  Same for add_rules.","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if add_rules is not None or delete_rules is not None:"},{"line_number":356,"context_line":"            # Handling access rule update"},{"line_number":357,"context_line":"            if delete_rules is not None:"},{"line_number":358,"context_line":"                for d_rule in delete_rules:"},{"line_number":359,"context_line":"                    self._deny_access(context, share, d_rule)"},{"line_number":360,"context_line":"            if add_rules is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_db603238","line":357,"range":{"start_line":357,"start_character":12,"end_line":357,"end_character":40},"in_reply_to":"bae84128_f070bede","updated":"2016-02-22 08:31:12.000000000","message":"Done","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"ca3c833117cc758c3c51c5b5d0c0498b9c5588de","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                for a_rule in add_rules:"},{"line_number":362,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            if access_rules is None:"},{"line_number":365,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":366,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":367,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_09971891","line":364,"updated":"2016-02-20 13:04:28.000000000","message":"Can this case be hit currently?","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1867170fc8db9ec591010f3bcad0bf4ae247d56e","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                for a_rule in add_rules:"},{"line_number":362,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            if access_rules is None:"},{"line_number":365,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":366,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":367,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_505fea40","line":364,"in_reply_to":"bae84128_09971891","updated":"2016-02-21 18:50:41.000000000","message":"No.  Even if there are no rules, access_rules will be a list.","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                for a_rule in add_rules:"},{"line_number":362,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            if access_rules is None:"},{"line_number":365,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":366,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":367,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_9be6aab2","line":364,"in_reply_to":"bae84128_09971891","updated":"2016-02-22 08:31:12.000000000","message":"see below","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a0a5eabac861a24ebd77f9662fa569a57b11db54","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                for a_rule in add_rules:"},{"line_number":362,"context_line":"                    self._allow_access(context, share, a_rule)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            if access_rules is None:"},{"line_number":365,"context_line":"                raise exception.InvalidShareAccess("},{"line_number":366,"context_line":"                    _(\"No access rules provided!\"))"},{"line_number":367,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_1bd29ad2","line":364,"in_reply_to":"bae84128_505fea40","updated":"2016-02-22 08:31:12.000000000","message":"switched to \u0027if not access_rules\u0027 to check for emptiness.","commit_id":"920f5355f7dde1d9ff671d2217ebbf7239439c5d"}],"manila/tests/share/drivers/quobyte/test_quobyte.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1d0f9a056e23b969ba554547e547a3e24dc7d984","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @mock.patch.object(quobyte.LOG, \"warning\")"},{"line_number":502,"context_line":"    def test_update_access_no_rules(self, qb_log_mock):"},{"line_number":503,"context_line":"        self._driver.update_access(context\u003dNone, share\u003dNone, access_rules\u003d[])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        qb_log_mock.assert_has_calls([mock.ANY])"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_c8b76e38","line":503,"range":{"start_line":503,"start_character":7,"end_line":503,"end_character":77},"updated":"2016-02-23 17:59:23.000000000","message":"If you upload another patch, please fill add_rules and delete_rules as empty lists. It will prevent breaking your driver when we change the method signature later.","commit_id":"50e6647b6e6d235398278e2f466a0dddc746d74b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"abc6b55da49b49fdd407964ba35c6fff552d4f1c","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @mock.patch.object(quobyte.LOG, \"warning\")"},{"line_number":502,"context_line":"    def test_update_access_no_rules(self, qb_log_mock):"},{"line_number":503,"context_line":"        self._driver.update_access(context\u003dNone, share\u003dNone, access_rules\u003d[])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        qb_log_mock.assert_has_calls([mock.ANY])"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_de88c473","line":503,"range":{"start_line":503,"start_character":7,"end_line":503,"end_character":77},"in_reply_to":"bae84128_c8b76e38","updated":"2016-02-23 18:40:43.000000000","message":"+1","commit_id":"50e6647b6e6d235398278e2f466a0dddc746d74b"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"3625ae46af67df5dd1bee469237ab32c578301a5","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @mock.patch.object(quobyte.LOG, \"warning\")"},{"line_number":502,"context_line":"    def test_update_access_no_rules(self, qb_log_mock):"},{"line_number":503,"context_line":"        self._driver.update_access(context\u003dNone, share\u003dNone, access_rules\u003d[])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        qb_log_mock.assert_has_calls([mock.ANY])"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_74aa5e86","line":503,"range":{"start_line":503,"start_character":7,"end_line":503,"end_character":77},"in_reply_to":"bae84128_c8b76e38","updated":"2016-02-24 07:14:59.000000000","message":"will do","commit_id":"50e6647b6e6d235398278e2f466a0dddc746d74b"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"3625ae46af67df5dd1bee469237ab32c578301a5","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @mock.patch.object(quobyte.LOG, \"warning\")"},{"line_number":502,"context_line":"    def test_update_access_no_rules(self, qb_log_mock):"},{"line_number":503,"context_line":"        self._driver.update_access(context\u003dNone, share\u003dNone, access_rules\u003d[])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        qb_log_mock.assert_has_calls([mock.ANY])"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_54ad9a99","line":503,"range":{"start_line":503,"start_character":7,"end_line":503,"end_character":77},"in_reply_to":"bae84128_de88c473","updated":"2016-02-24 07:14:59.000000000","message":"s.a.","commit_id":"50e6647b6e6d235398278e2f466a0dddc746d74b"}]}
