)]}'
{"manila/share/drivers/generic.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c5b5ae0e9d6f17d648ef4a1cf6502e7b7261a48e","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d9bc29de","line":255,"range":{"start_line":255,"start_character":51,"end_line":255,"end_character":74},"updated":"2016-02-18 17:37:59.000000000","message":"I would remove this.","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c5b5ae0e9d6f17d648ef4a1cf6502e7b7261a48e","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_59ead9db","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":21},"updated":"2016-02-18 17:37:59.000000000","message":"s/check that/Checks whether","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ebcad3be861c74eaa99e336786dbf15d3de14f9c","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_5dbb7327","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":21},"in_reply_to":"dae33548_59ead9db","updated":"2016-02-22 09:21:54.000000000","message":"Done","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ebcad3be861c74eaa99e336786dbf15d3de14f9c","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_bd727fab","line":255,"range":{"start_line":255,"start_character":51,"end_line":255,"end_character":74},"in_reply_to":"dae33548_d9bc29de","updated":"2016-02-22 09:21:54.000000000","message":"Done","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c5b5ae0e9d6f17d648ef4a1cf6502e7b7261a48e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _format_device(self, server_details, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9902a1b2","line":256,"range":{"start_line":256,"start_character":41,"end_line":256,"end_character":68},"updated":"2016-02-18 17:37:59.000000000","message":"Couldn\u0027t you use just volume[\u0027mountpoint\u0027]?","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ebcad3be861c74eaa99e336786dbf15d3de14f9c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"check that the device file is available before doing any action\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, \u0027%s\u0027 % volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _format_device(self, server_details, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1d6a8bb3","line":256,"range":{"start_line":256,"start_character":41,"end_line":256,"end_character":68},"in_reply_to":"dae33548_9902a1b2","updated":"2016-02-22 09:21:54.000000000","message":"Done","commit_id":"4ea5ac1c184816fda5958e95a4ed9520e2f50f5d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c27ebc47180c0203b58700372b308ab13eadb5e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            },"},{"line_number":251,"context_line":"        }"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"Checks whether the device file is available\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _format_device(self, server_details, volume):"},{"line_number":260,"context_line":"        \"\"\"Formats device attached to the service vm.\"\"\""},{"line_number":261,"context_line":"        self._is_device_file_available(server_details, volume)"},{"line_number":262,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027mkfs.%s\u0027 % self.configuration.share_volume_fstype,"},{"line_number":263,"context_line":"                   volume[\u0027mountpoint\u0027]]"},{"line_number":264,"context_line":"        self._ssh_exec(server_details, command)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_4cb26b95","line":261,"range":{"start_line":253,"start_character":4,"end_line":261,"end_character":62},"updated":"2016-02-23 11:02:14.000000000","message":"And where is \"wait some seconds\"?","commit_id":"b8e3f981a722e0d815e9acfddd88bd4938b22a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d2b870c346d80f6548a0a094829cfcc4d376dce9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            },"},{"line_number":251,"context_line":"        }"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"Checks whether the device file is available\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _format_device(self, server_details, volume):"},{"line_number":260,"context_line":"        \"\"\"Formats device attached to the service vm.\"\"\""},{"line_number":261,"context_line":"        self._is_device_file_available(server_details, volume)"},{"line_number":262,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027mkfs.%s\u0027 % self.configuration.share_volume_fstype,"},{"line_number":263,"context_line":"                   volume[\u0027mountpoint\u0027]]"},{"line_number":264,"context_line":"        self._ssh_exec(server_details, command)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_a075f6fa","line":261,"range":{"start_line":253,"start_character":4,"end_line":261,"end_character":62},"in_reply_to":"bae84128_4cb26b95","updated":"2016-02-23 12:19:40.000000000","message":"in @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)","commit_id":"b8e3f981a722e0d815e9acfddd88bd4938b22a42"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4a8890bb6e5bd9bc182f85083a68c64de43b0ac7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            },"},{"line_number":251,"context_line":"        }"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @utils.retry(exception.ProcessExecutionError, backoff_rate\u003d1)"},{"line_number":254,"context_line":"    def _is_device_file_available(self, server_details, volume):"},{"line_number":255,"context_line":"        \"\"\"Checks whether the device file is available\"\"\""},{"line_number":256,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, volume[\u0027mountpoint\u0027]]"},{"line_number":257,"context_line":"        self._ssh_exec(server_details, command)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _format_device(self, server_details, volume):"},{"line_number":260,"context_line":"        \"\"\"Formats device attached to the service vm.\"\"\""},{"line_number":261,"context_line":"        self._is_device_file_available(server_details, volume)"},{"line_number":262,"context_line":"        command \u003d [\u0027sudo\u0027, \u0027mkfs.%s\u0027 % self.configuration.share_volume_fstype,"},{"line_number":263,"context_line":"                   volume[\u0027mountpoint\u0027]]"},{"line_number":264,"context_line":"        self._ssh_exec(server_details, command)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_db9c6bc2","line":261,"range":{"start_line":253,"start_character":4,"end_line":261,"end_character":62},"in_reply_to":"bae84128_a075f6fa","updated":"2016-02-23 12:30:11.000000000","message":"oh, indeed, sorry ))","commit_id":"b8e3f981a722e0d815e9acfddd88bd4938b22a42"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"31985b320d66ebf16166dce852ebff59c90ffd21","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        volume \u003d {\u0027mountpoint\u0027: \u0027fake_mount_point\u0027}"},{"line_number":374,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":375,"context_line":"                         mock.Mock(return_value\u003dNone))"},{"line_number":376,"context_line":"        self._driver._is_device_file_available(self.server, volume)"},{"line_number":377,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":378,"context_line":"            self.server, [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, volume[\u0027mountpoint\u0027]])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_59f6c7f9","line":376,"range":{"start_line":376,"start_character":21,"end_line":376,"end_character":46},"updated":"2016-02-22 20:28:15.000000000","message":"Please use whitespace to separate unit tests into three sections (mocks, call, asserts).","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d3ddfd9445ba55978ff697ce7c1767a14bf1c9f7","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        volume \u003d {\u0027mountpoint\u0027: \u0027fake_mount_point\u0027}"},{"line_number":374,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":375,"context_line":"                         mock.Mock(return_value\u003dNone))"},{"line_number":376,"context_line":"        self._driver._is_device_file_available(self.server, volume)"},{"line_number":377,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":378,"context_line":"            self.server, [\u0027sudo\u0027, \u0027test\u0027, \u0027-b\u0027, volume[\u0027mountpoint\u0027]])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_8cef53e8","line":376,"range":{"start_line":376,"start_character":21,"end_line":376,"end_character":46},"in_reply_to":"bae84128_59f6c7f9","updated":"2016-02-23 10:55:09.000000000","message":"Done","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"31985b320d66ebf16166dce852ebff59c90ffd21","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        volume \u003d {\u0027mountpoint\u0027: \u0027fake_mount_point\u0027}"},{"line_number":382,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":383,"context_line":"                         mock.Mock(return_value\u003d(\u0027\u0027, \u0027\u0027)))"},{"line_number":384,"context_line":"        self.mock_object(self._driver, \u0027_is_device_file_available\u0027)"},{"line_number":385,"context_line":"        self._driver._format_device(self.server, volume)"},{"line_number":386,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":387,"context_line":"            self.server,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_f98ebb77","line":384,"range":{"start_line":384,"start_character":40,"end_line":384,"end_character":65},"updated":"2016-02-22 20:28:15.000000000","message":"Please add an assert to ensure this was called.","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d3ddfd9445ba55978ff697ce7c1767a14bf1c9f7","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        volume \u003d {\u0027mountpoint\u0027: \u0027fake_mount_point\u0027}"},{"line_number":382,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":383,"context_line":"                         mock.Mock(return_value\u003d(\u0027\u0027, \u0027\u0027)))"},{"line_number":384,"context_line":"        self.mock_object(self._driver, \u0027_is_device_file_available\u0027)"},{"line_number":385,"context_line":"        self._driver._format_device(self.server, volume)"},{"line_number":386,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":387,"context_line":"            self.server,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ccbb1be4","line":384,"range":{"start_line":384,"start_character":40,"end_line":384,"end_character":65},"in_reply_to":"bae84128_f98ebb77","updated":"2016-02-23 10:55:09.000000000","message":"Done","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"31985b320d66ebf16166dce852ebff59c90ffd21","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":383,"context_line":"                         mock.Mock(return_value\u003d(\u0027\u0027, \u0027\u0027)))"},{"line_number":384,"context_line":"        self.mock_object(self._driver, \u0027_is_device_file_available\u0027)"},{"line_number":385,"context_line":"        self._driver._format_device(self.server, volume)"},{"line_number":386,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":387,"context_line":"            self.server,"},{"line_number":388,"context_line":"            [\u0027sudo\u0027, \u0027mkfs.%s\u0027 % self.fake_conf.share_volume_fstype,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_99ae8fe4","line":385,"range":{"start_line":385,"start_character":21,"end_line":385,"end_character":35},"updated":"2016-02-22 20:28:15.000000000","message":"Please preserve the whitespace between the mock/call/assert sections.","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d3ddfd9445ba55978ff697ce7c1767a14bf1c9f7","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"},{"line_number":383,"context_line":"                         mock.Mock(return_value\u003d(\u0027\u0027, \u0027\u0027)))"},{"line_number":384,"context_line":"        self.mock_object(self._driver, \u0027_is_device_file_available\u0027)"},{"line_number":385,"context_line":"        self._driver._format_device(self.server, volume)"},{"line_number":386,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":387,"context_line":"            self.server,"},{"line_number":388,"context_line":"            [\u0027sudo\u0027, \u0027mkfs.%s\u0027 % self.fake_conf.share_volume_fstype,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4cd0ab1f","line":385,"range":{"start_line":385,"start_character":21,"end_line":385,"end_character":35},"in_reply_to":"bae84128_99ae8fe4","updated":"2016-02-23 10:55:09.000000000","message":"Done","commit_id":"7b3e08dc6eb1ad3062e307f376a89c86d5bfe3cf"}]}
