)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"80bb0126ef8cbc6f44d0a9c048326a9e94e4e682","unresolved":false,"context_lines":[{"line_number":20,"context_line":"| created_at        | 2016-02-18T21:12:51.000000           |"},{"line_number":21,"context_line":"| updated_at        | 2016-02-18T21:12:51.000000           |"},{"line_number":22,"context_line":"| preferred         | True                                 |"},{"line_number":23,"context_line":"+-------------------+--------------------------------------+"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Implements: blueprint preferred-flag-in-export-location-metadata"},{"line_number":26,"context_line":"Change-Id: Ia63477d4f3e28ab4f53d7b9d51756cc798c977b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_8b8d1a33","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":60},"updated":"2016-02-18 22:02:11.000000000","message":"Please include an APIImpact flag","commit_id":"d94abe5615425ca341d5595100c4ab667d756a84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d9a2766a28f8abbdafae409d9224a7a8f0b00c3d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"| updated_at        | 2016-02-18T21:12:51.000000           |"},{"line_number":22,"context_line":"| preferred         | True                                 |"},{"line_number":23,"context_line":"+-------------------+--------------------------------------+"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Implements: blueprint preferred-flag-in-export-location-metadata"},{"line_number":26,"context_line":"Change-Id: Ia63477d4f3e28ab4f53d7b9d51756cc798c977b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_ab355947","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":0},"updated":"2016-02-19 20:48:55.000000000","message":"Please add an APIImpact flag","commit_id":"fa27c2a155787d1114afd5790d39b9313b193695"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"| preferred         | True                                 |"},{"line_number":23,"context_line":"+-------------------+--------------------------------------+"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This commit also fixes the bug that equated an admin context"},{"line_number":26,"context_line":"with a detail request in the export location view builder."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"APIImpact"},{"line_number":29,"context_line":"Implements: blueprint preferred-flag-in-export-location-metadata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_2fc0557c","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":57},"updated":"2016-02-24 18:51:24.000000000","message":"It is not a bug. It is design, intentional feature.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"| preferred         | True                                 |"},{"line_number":23,"context_line":"+-------------------+--------------------------------------+"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This commit also fixes the bug that equated an admin context"},{"line_number":26,"context_line":"with a detail request in the export location view builder."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"APIImpact"},{"line_number":29,"context_line":"Implements: blueprint preferred-flag-in-export-location-metadata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_675a7252","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":57},"in_reply_to":"bae84128_2fc0557c","updated":"2016-02-25 01:44:04.000000000","message":"OK, I won\u0027t characterize it as a bug.  But we need to change the design.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            instances."},{"line_number":60,"context_line":"    * 2.11 - Share Replication support"},{"line_number":61,"context_line":"    * 2.12 - Manage/unmanage snapshot API."},{"line_number":62,"context_line":"    * 2.13 - Preferred attribute in export location metadata"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\"\"\""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_6bd85454","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":22},"updated":"2016-03-02 03:37:33.000000000","message":"Can this be quoted... \u0027preferred\u0027","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            instances."},{"line_number":60,"context_line":"    * 2.11 - Share Replication support"},{"line_number":61,"context_line":"    * 2.12 - Manage/unmanage snapshot API."},{"line_number":62,"context_line":"    * 2.13 - Preferred attribute in export location metadata"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\"\"\""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_b65640d0","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":22},"in_reply_to":"7af24918_6bd85454","updated":"2016-03-02 05:45:18.000000000","message":"Done","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"2.13"},{"line_number":94,"context_line":"____"},{"line_number":95,"context_line":"  Added preferred attribute to export locations.  Drivers may use this"},{"line_number":96,"context_line":"  field to identify which export locations are most efficient and should be"},{"line_number":97,"context_line":"  used preferentially by clients.  Also, change \u0027uuid\u0027 field to \u0027id\u0027, move"},{"line_number":98,"context_line":"  timestamps to detail view, and return all non-admin fields to users."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7af24918_8bba00e0","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":17},"updated":"2016-03-02 03:37:33.000000000","message":"same here; or rather \"Added attribute \u0027preferred\u0027 to export locations...\"","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"2.13"},{"line_number":94,"context_line":"____"},{"line_number":95,"context_line":"  Added preferred attribute to export locations.  Drivers may use this"},{"line_number":96,"context_line":"  field to identify which export locations are most efficient and should be"},{"line_number":97,"context_line":"  used preferentially by clients.  Also, change \u0027uuid\u0027 field to \u0027id\u0027, move"},{"line_number":98,"context_line":"  timestamps to detail view, and return all non-admin fields to users."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7af24918_b66da09a","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":17},"in_reply_to":"7af24918_8bba00e0","updated":"2016-03-02 05:45:18.000000000","message":"Done","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"}],"manila/api/v2/share_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._verify_share(context, share_id)"},{"line_number":47,"context_line":"        export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":48,"context_line":"            context, share_id, include_admin_only\u003dcontext.is_admin)"},{"line_number":49,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_6f47fd4b","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":47},"updated":"2016-02-24 18:51:24.000000000","message":"It had \"detail\" output for admin. Now you implement \"summary\" for all. Now admin won\u0027t be able to see data that he was able before because of condition on line 42 in https://review.openstack.org/#/c/282070/5/manila/api/views/export_locations.py","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._verify_share(context, share_id)"},{"line_number":47,"context_line":"        export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":48,"context_line":"            context, share_id, include_admin_only\u003dcontext.is_admin)"},{"line_number":49,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_394c0e76","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":47},"in_reply_to":"bae84128_2f78552b","updated":"2016-02-25 01:44:04.000000000","message":"This change allows for a /detail API, and there is already a detail_list() in the export location view builder, so adding the detail API would be trivial should it be needed.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._verify_share(context, share_id)"},{"line_number":47,"context_line":"        export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":48,"context_line":"            context, share_id, include_admin_only\u003dcontext.is_admin)"},{"line_number":49,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_39252eae","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":47},"in_reply_to":"bae84128_6f47fd4b","updated":"2016-02-25 01:44:04.000000000","message":"This change is consistent with other APIs, but as I described in the patch set comment, most fields belong in the summary view anyway.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81aa2b16b097ea4d00ef28819bde0e8b27bab4e0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._verify_share(context, share_id)"},{"line_number":47,"context_line":"        export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":48,"context_line":"            context, share_id, include_admin_only\u003dcontext.is_admin)"},{"line_number":49,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_2f78552b","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":47},"in_reply_to":"bae84128_6f47fd4b","updated":"2016-02-24 18:56:53.000000000","message":"should we have a detail() API\n(like the other APIs?)","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"}],"manila/api/v2/share_instance_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        export_locations \u003d ("},{"line_number":48,"context_line":"            db_api.share_export_locations_get_by_share_instance_id("},{"line_number":49,"context_line":"                context, share_instance_id))"},{"line_number":50,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_d4b85ceb","line":50,"range":{"start_line":50,"start_character":34,"end_line":50,"end_character":41},"updated":"2016-02-24 18:51:24.000000000","message":"Why \"detail\" changed to \"summary\"? Moreover, it is out of scope for the goal of commit.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        export_locations \u003d ("},{"line_number":48,"context_line":"            db_api.share_export_locations_get_by_share_instance_id("},{"line_number":49,"context_line":"                context, share_instance_id))"},{"line_number":50,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_d9b52232","line":50,"range":{"start_line":50,"start_character":34,"end_line":50,"end_character":41},"in_reply_to":"bae84128_af074580","updated":"2016-02-25 01:44:04.000000000","message":"Same answer, it\u0027s definitely allowed.  As seen in the share view builder, detail--\u003edetail_list().  It\u0027s just a matter of adding the API and setting up the route.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        export_locations \u003d ("},{"line_number":48,"context_line":"            db_api.share_export_locations_get_by_share_instance_id("},{"line_number":49,"context_line":"                context, share_instance_id))"},{"line_number":50,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_796df6cb","line":50,"range":{"start_line":50,"start_character":34,"end_line":50,"end_character":41},"in_reply_to":"bae84128_d4b85ceb","updated":"2016-02-25 01:44:04.000000000","message":"By convention with other APIs, index--\u003esummary_list.  I needed to make this change to implement the preferred output correctly.  Might as well do it all in the same microversion.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81aa2b16b097ea4d00ef28819bde0e8b27bab4e0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        export_locations \u003d ("},{"line_number":48,"context_line":"            db_api.share_export_locations_get_by_share_instance_id("},{"line_number":49,"context_line":"                context, share_instance_id))"},{"line_number":50,"context_line":"        return self._view_builder.summary_list(req, export_locations)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_af074580","line":50,"range":{"start_line":50,"start_character":34,"end_line":50,"end_character":41},"in_reply_to":"bae84128_d4b85ceb","updated":"2016-02-24 18:56:53.000000000","message":"same concern here.. allow for a /detail API please..","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"}],"manila/api/views/export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"80bb0126ef8cbc6f44d0a9c048326a9e94e4e682","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            view[\u0027share_instance_id\u0027] \u003d export_location[\u0027share_instance_id\u0027]"},{"line_number":53,"context_line":"            view[\u0027is_admin_only\u0027] \u003d export_location[\u0027is_admin_only\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        return {\u0027export_location\u0027: view}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_0bf62a8e","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":75},"updated":"2016-02-18 22:02:11.000000000","message":"This seems to add it to the summary, and the detail. Are we sure we want this behavior?","commit_id":"d94abe5615425ca341d5595100c4ab667d756a84"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b2874afb80cc4388d19f10040fc0d9b7ff2a3f45","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            view[\u0027share_instance_id\u0027] \u003d export_location[\u0027share_instance_id\u0027]"},{"line_number":53,"context_line":"            view[\u0027is_admin_only\u0027] \u003d export_location[\u0027is_admin_only\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        return {\u0027export_location\u0027: view}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a633f512","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":75},"in_reply_to":"dae33548_0bf62a8e","updated":"2016-02-18 22:35:48.000000000","message":"Yeah, you\u0027re probably right, Goutham.  Let\u0027s let Jenkins vote ahead of the FPF deadline, and then I can fix that.","commit_id":"d94abe5615425ca341d5595100c4ab667d756a84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1826d6244b3230966eb63525e73308a6f5c3fc16","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            view[\u0027share_instance_id\u0027] \u003d export_location[\u0027share_instance_id\u0027]"},{"line_number":53,"context_line":"            view[\u0027is_admin_only\u0027] \u003d export_location[\u0027is_admin_only\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        return {\u0027export_location\u0027: view}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_060aa125","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":75},"in_reply_to":"dae33548_a633f512","updated":"2016-02-18 22:37:19.000000000","message":"+1. Yep.","commit_id":"d94abe5615425ca341d5595100c4ab667d756a84"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e85c245409e41e4483aa9702137c10450b93abe0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027updated_at\u0027: export_location[\u0027updated_at\u0027],"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # NOTE(vponomaryov): Include metadata keys here as export location"},{"line_number":40,"context_line":"        # attributes when such appear."},{"line_number":41,"context_line":"        #"},{"line_number":42,"context_line":"        # Example having export_location[\u0027el_metadata\u0027] as following:"},{"line_number":43,"context_line":"        #"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_1ec1de2e","line":40,"range":{"start_line":39,"start_character":29,"end_line":40,"end_character":38},"updated":"2016-02-22 11:48:33.000000000","message":"Message should be changed because your commit is the one that addresses point \"such appear\".","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"863ce7c702ca0d7ae940e504b5d139e669053d12","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027updated_at\u0027: export_location[\u0027updated_at\u0027],"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # NOTE(vponomaryov): Include metadata keys here as export location"},{"line_number":40,"context_line":"        # attributes when such appear."},{"line_number":41,"context_line":"        #"},{"line_number":42,"context_line":"        # Example having export_location[\u0027el_metadata\u0027] as following:"},{"line_number":43,"context_line":"        #"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a115ee40","line":40,"range":{"start_line":39,"start_character":29,"end_line":40,"end_character":38},"in_reply_to":"bae84128_1ec1de2e","updated":"2016-02-24 04:58:45.000000000","message":"OK, I guess we don\u0027t need the note at all since there\u0027s an example now.  (But at least I found it helpful!)","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e85c245409e41e4483aa9702137c10450b93abe0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                           detail\u003dFalse)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"2.12\")"},{"line_number":89,"context_line":"    def add_preferred_path(self, view_dict, export_location):"},{"line_number":90,"context_line":"        view_dict[\u0027preferred\u0027] \u003d strutils.bool_from_string("},{"line_number":91,"context_line":"            export_location[\u0027el_metadata\u0027].get(\u0027preferred\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_9e5e8e74","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":26},"updated":"2016-02-22 11:48:33.000000000","message":"Preferred path? It is \"preferred\" attr of a path.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"863ce7c702ca0d7ae940e504b5d139e669053d12","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                           detail\u003dFalse)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"2.12\")"},{"line_number":89,"context_line":"    def add_preferred_path(self, view_dict, export_location):"},{"line_number":90,"context_line":"        view_dict[\u0027preferred\u0027] \u003d strutils.bool_from_string("},{"line_number":91,"context_line":"            export_location[\u0027el_metadata\u0027].get(\u0027preferred\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2160bea4","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":26},"in_reply_to":"bae84128_9e5e8e74","updated":"2016-02-24 04:58:45.000000000","message":"Fair enough, I changed this to add_preferred_path_attribute.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e85c245409e41e4483aa9702137c10450b93abe0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"2.12\")"},{"line_number":89,"context_line":"    def add_preferred_path(self, view_dict, export_location):"},{"line_number":90,"context_line":"        view_dict[\u0027preferred\u0027] \u003d strutils.bool_from_string("},{"line_number":91,"context_line":"            export_location[\u0027el_metadata\u0027].get(\u0027preferred\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_feb19a90","line":91,"range":{"start_line":91,"start_character":47,"end_line":91,"end_character":59},"updated":"2016-02-22 11:48:33.000000000","message":"Default value is None? Is it expected?","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"863ce7c702ca0d7ae940e504b5d139e669053d12","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"2.12\")"},{"line_number":89,"context_line":"    def add_preferred_path(self, view_dict, export_location):"},{"line_number":90,"context_line":"        view_dict[\u0027preferred\u0027] \u003d strutils.bool_from_string("},{"line_number":91,"context_line":"            export_location[\u0027el_metadata\u0027].get(\u0027preferred\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_013e5a8b","line":91,"range":{"start_line":91,"start_character":47,"end_line":91,"end_character":59},"in_reply_to":"bae84128_feb19a90","updated":"2016-02-24 04:58:45.000000000","message":"strutils.bool_from_string(None) returns False, so yes it\u0027s expected.  If you think adding a False default anyway would enhance readability, I could do that.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        view \u003d {"},{"line_number":36,"context_line":"            \u0027id\u0027: export_location[\u0027uuid\u0027],"},{"line_number":37,"context_line":"            \u0027path\u0027: export_location[\u0027path\u0027],"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_e90a3689","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":15},"updated":"2016-02-29 21:43:46.000000000","message":"Why it is changed? EL model has two values - UUID and ID. And returned one, user-facing is exactly UUID. Moreover, it is not related to the goal of commit at all.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        view \u003d {"},{"line_number":36,"context_line":"            \u0027id\u0027: export_location[\u0027uuid\u0027],"},{"line_number":37,"context_line":"            \u0027path\u0027: export_location[\u0027path\u0027],"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_301bd1cb","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":15},"in_reply_to":"9aed3d3a_e90a3689","updated":"2016-03-01 04:46:01.000000000","message":"I figured this might be controversial!  :-)\n\nI checked, and *every* other view builder returns the object\u0027s UUID as \u0027id\u0027.  So while I agree it\u0027s weird to return the value named \u0027UUID\u0027 as \u0027id\u0027 here, I think it\u0027s 1) unlikely we will ever need to return the \u0027ID\u0027 sequence value, and 2) much more important to preserve the consistency across the REST interface.\n\nAnd yes, this patch has grown beyond my initial goal.  I didn\u0027t anticipate its needing this level of change, but IMHO it seems best to do it all with a single microversion.  I will discuss with Ben and, if he agrees, will adjust the blueprint and commit message to reflect what I\u0027m doing.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027id\u0027: export_location[\u0027uuid\u0027],"},{"line_number":37,"context_line":"            \u0027path\u0027: export_location[\u0027path\u0027],"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"},{"line_number":40,"context_line":"        if context.is_admin:"},{"line_number":41,"context_line":"            view[\u0027share_instance_id\u0027] \u003d export_location["},{"line_number":42,"context_line":"                \u0027share_instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_cbd1a8cf","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":75},"updated":"2016-03-02 03:37:33.000000000","message":"my problem with this is that the version modifiers may add more keys in the future that need not be part of the summary; in all other view builders, this is used to augment keys to the detail views.. \n\nHowever, that is not a problem we need to solve right now.","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027id\u0027: export_location[\u0027uuid\u0027],"},{"line_number":37,"context_line":"            \u0027path\u0027: export_location[\u0027path\u0027],"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"        self.update_versioned_resource_dict(request, view, export_location)"},{"line_number":40,"context_line":"        if context.is_admin:"},{"line_number":41,"context_line":"            view[\u0027share_instance_id\u0027] \u003d export_location["},{"line_number":42,"context_line":"                \u0027share_instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_b62120fe","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":75},"in_reply_to":"7af24918_cbd1a8cf","updated":"2016-03-02 05:45:18.000000000","message":"+1","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"}],"manila/api/views/share_snapshots.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return {\u0027snapshot\u0027: snapshot_dict}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @common.ViewBuilder.versioned_method(\"2.13\")"},{"line_number":69,"context_line":"    def add_provider_location_field(self, snapshot_dict, snapshot):"},{"line_number":70,"context_line":"        snapshot_dict[\u0027provider_location\u0027] \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_490a427a","line":68,"range":{"start_line":68,"start_character":44,"end_line":68,"end_character":46},"updated":"2016-02-29 21:43:46.000000000","message":"should not be changed.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return {\u0027snapshot\u0027: snapshot_dict}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @common.ViewBuilder.versioned_method(\"2.13\")"},{"line_number":69,"context_line":"    def add_provider_location_field(self, snapshot_dict, snapshot):"},{"line_number":70,"context_line":"        snapshot_dict[\u0027provider_location\u0027] \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_d059c58f","line":68,"range":{"start_line":68,"start_character":44,"end_line":68,"end_character":46},"in_reply_to":"9aed3d3a_490a427a","updated":"2016-03-01 04:46:01.000000000","message":"True, I must be overworked.  Will fix, thanks.\n\n(I wonder that if we used constants that reflect what each microversion represents, such errors might be less likely.)","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return {\u0027snapshot\u0027: snapshot_dict}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @common.ViewBuilder.versioned_method(\"2.13\")"},{"line_number":69,"context_line":"    def add_provider_location_field(self, snapshot_dict, snapshot):"},{"line_number":70,"context_line":"        snapshot_dict[\u0027provider_location\u0027] \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_29c14ae5","line":68,"range":{"start_line":68,"start_character":44,"end_line":68,"end_character":46},"in_reply_to":"9aed3d3a_d059c58f","updated":"2016-03-01 22:27:08.000000000","message":"Fixed.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"}],"manila/tests/api/v2/test_share_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_a91b0ec9","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"updated":"2016-02-29 21:43:46.000000000","message":"13","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_b0ea4172","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"in_reply_to":"9aed3d3a_a91b0ec9","updated":"2016-03-01 04:46:01.000000000","message":"The goal here was to test the version just before I added the preferred flag, so I think 2.12 is correct.  And 2.9 is the first version for this API, so that makes sense to me.\n\n(Of course, some other 2.13 will likely win the microversion race, so I\u0027ll have to change this again anyway.)","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_e955a21d","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"in_reply_to":"9aed3d3a_b0ea4172","updated":"2016-03-01 22:27:08.000000000","message":"2.13 is tested below in test_list_and_show_with_preferred_path.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_097b1af6","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":47},"updated":"2016-02-29 21:43:46.000000000","message":"13","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_10068d51","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":47},"in_reply_to":"9aed3d3a_097b1af6","updated":"2016-03-01 04:46:01.000000000","message":"same","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    self.assertIn(key, index_el)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            # Check detail keys in show result"},{"line_number":116,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":117,"context_line":"                self.assertEqual(len(admin_detail_keys), len(show_el))"},{"line_number":118,"context_line":"                for key in admin_detail_keys:"},{"line_number":119,"context_line":"                    self.assertIn(key, show_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_69010638","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":31},"updated":"2016-02-29 21:43:46.000000000","message":"two equal conditions means that thier code should be combined. No real need to separate by summary/detail.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    self.assertIn(key, index_el)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            # Check detail keys in show result"},{"line_number":116,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":117,"context_line":"                self.assertEqual(len(admin_detail_keys), len(show_el))"},{"line_number":118,"context_line":"                for key in admin_detail_keys:"},{"line_number":119,"context_line":"                    self.assertIn(key, show_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_f087a9b2","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":31},"in_reply_to":"9aed3d3a_69010638","updated":"2016-03-01 04:46:01.000000000","message":"OK, will do.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    self.assertIn(key, index_el)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            # Check detail keys in show result"},{"line_number":116,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":117,"context_line":"                self.assertEqual(len(admin_detail_keys), len(show_el))"},{"line_number":118,"context_line":"                for key in admin_detail_keys:"},{"line_number":119,"context_line":"                    self.assertIn(key, show_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_2c6838f5","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":31},"in_reply_to":"9aed3d3a_f087a9b2","updated":"2016-03-01 22:27:08.000000000","message":"Done","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertRaises("},{"line_number":136,"context_line":"            exc.HTTPNotFound,"},{"line_number":137,"context_line":"            self.controller.show,"},{"line_number":138,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_id,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_show_export_location_not_found(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_2bfacc42","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":42},"updated":"2016-03-02 03:37:33.000000000","message":"this should be non-existent; but no worries :)","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertRaises("},{"line_number":136,"context_line":"            exc.HTTPNotFound,"},{"line_number":137,"context_line":"            self.controller.show,"},{"line_number":138,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_id,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_show_export_location_not_found(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_9616a4ef","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":42},"in_reply_to":"7af24918_2bfacc42","updated":"2016-03-02 05:45:18.000000000","message":"There are several more of these elsewhere, and I already had to back out those fixes.  Another time!","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"}],"manila/tests/api/v2/test_share_instance_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e85c245409e41e4483aa9702137c10450b93abe0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            for key in expected_keys:"},{"line_number":111,"context_line":"                self.assertEqual("},{"line_number":112,"context_line":"                    index_el[key], show_result[\u0027export_location\u0027][key])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_list_export_locations_share_instance_not_found(self):"},{"line_number":115,"context_line":"        self.assertRaises("},{"line_number":116,"context_line":"            exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_bed272d0","line":113,"updated":"2016-02-22 11:48:33.000000000","message":"No test for old microversion checking that this key is absent.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"863ce7c702ca0d7ae940e504b5d139e669053d12","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            for key in expected_keys:"},{"line_number":111,"context_line":"                self.assertEqual("},{"line_number":112,"context_line":"                    index_el[key], show_result[\u0027export_location\u0027][key])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_list_export_locations_share_instance_not_found(self):"},{"line_number":115,"context_line":"        self.assertRaises("},{"line_number":116,"context_line":"            exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_8188aac6","line":113,"in_reply_to":"bae84128_bed272d0","updated":"2016-02-24 04:58:45.000000000","message":"The previous test defaulted to 2.9, so it was checking the key was absent.  I enhanced that test to cover 2.11 as well.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_29a25e4b","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"updated":"2016-02-29 21:43:46.000000000","message":"13","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_4c2664bb","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"in_reply_to":"7af24918_a809db2e","updated":"2016-03-01 22:27:08.000000000","message":"2.13 is tested below in test_list_and_show_with_preferred_path.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_30a59146","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"in_reply_to":"9aed3d3a_29a25e4b","updated":"2016-03-01 04:46:01.000000000","message":"I still think 12 is right (until I lose 2.13 as well).  What am I missing?","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45430bbec8bc40a8e7f71582ab8a37f6d1bb1aaf","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a809db2e","line":59,"range":{"start_line":59,"start_character":46,"end_line":59,"end_character":48},"in_reply_to":"9aed3d3a_30a59146","updated":"2016-03-01 18:15:31.000000000","message":"Target microversion not tested?","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_898baac2","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":47},"updated":"2016-02-29 21:43:46.000000000","message":"13","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":58,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.9\u0027},"},{"line_number":59,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.12\u0027},"},{"line_number":60,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.12\u0027})"},{"line_number":61,"context_line":"    @ddt.unpack"},{"line_number":62,"context_line":"    def test_list_and_show(self, role, version):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_b046c178","line":60,"range":{"start_line":60,"start_character":45,"end_line":60,"end_character":47},"in_reply_to":"9aed3d3a_898baac2","updated":"2016-03-01 04:46:01.000000000","message":"(Besides, anyone with triskaidekaphobia would advise me to get off of microversion 13 anyway.)","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            show_el \u003d show_result[\u0027export_location\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # Check summary keys in index result"},{"line_number":106,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":107,"context_line":"                self.assertEqual(len(admin_summary_keys), len(index_el))"},{"line_number":108,"context_line":"                for key in admin_summary_keys:"},{"line_number":109,"context_line":"                    self.assertIn(key, index_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_c99132f3","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":15},"updated":"2016-02-29 21:43:46.000000000","message":"Same here. Two equal conditions should be combined.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            show_el \u003d show_result[\u0027export_location\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # Check summary keys in index result"},{"line_number":106,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":107,"context_line":"                self.assertEqual(len(admin_summary_keys), len(index_el))"},{"line_number":108,"context_line":"                for key in admin_summary_keys:"},{"line_number":109,"context_line":"                    self.assertIn(key, index_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_acad6833","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":15},"in_reply_to":"9aed3d3a_10620d0a","updated":"2016-03-01 22:27:08.000000000","message":"Done","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            show_el \u003d show_result[\u0027export_location\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # Check summary keys in index result"},{"line_number":106,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":107,"context_line":"                self.assertEqual(len(admin_summary_keys), len(index_el))"},{"line_number":108,"context_line":"                for key in admin_summary_keys:"},{"line_number":109,"context_line":"                    self.assertIn(key, index_el)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_10620d0a","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":15},"in_reply_to":"9aed3d3a_c99132f3","updated":"2016-03-01 04:46:01.000000000","message":"OK.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"}],"manila_tempest_tests/tests/api/admin/test_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e85c245409e41e4483aa9702137c10450b93abe0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                self.assertIn(key, export_location)"},{"line_number":60,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":61,"context_line":"                self.assertIn(export_location[\u0027is_admin_only\u0027], (True, False))"},{"line_number":62,"context_line":"                self.assertIn(export_location[\u0027preferred\u0027], (True, False))"},{"line_number":63,"context_line":"                self.assertTrue("},{"line_number":64,"context_line":"                    uuidutils.is_uuid_like("},{"line_number":65,"context_line":"                        export_location[\u0027share_instance_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_fe8a3abe","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":74},"updated":"2016-02-22 11:48:33.000000000","message":"It will fail if we use older microversion.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"863ce7c702ca0d7ae940e504b5d139e669053d12","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                self.assertIn(key, export_location)"},{"line_number":60,"context_line":"            if role \u003d\u003d \u0027admin\u0027:"},{"line_number":61,"context_line":"                self.assertIn(export_location[\u0027is_admin_only\u0027], (True, False))"},{"line_number":62,"context_line":"                self.assertIn(export_location[\u0027preferred\u0027], (True, False))"},{"line_number":63,"context_line":"                self.assertTrue("},{"line_number":64,"context_line":"                    uuidutils.is_uuid_like("},{"line_number":65,"context_line":"                        export_location[\u0027share_instance_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_6e9e23ba","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":74},"in_reply_to":"bae84128_fe8a3abe","updated":"2016-02-24 04:58:45.000000000","message":"I fixed this, moved it out of the admin section, and added multiple microversion checks for one of the share export location tests as well as one of the share instance export location tests.","commit_id":"0dd4f1ad9accc688b7edbb24cf34623fbfb0205e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Check the format of the detail keys"},{"line_number":89,"context_line":"            if format \u003d\u003d \u0027detail\u0027:"},{"line_number":90,"context_line":"                if utils.is_microversion_ge(version, \u00272.12\u0027):"},{"line_number":91,"context_line":"                    self.assertIn(export_location[\u0027preferred\u0027], (True, False))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                if role \u003d\u003d \u0027admin\u0027:"},{"line_number":94,"context_line":"                    self.assertIn(export_location[\u0027is_admin_only\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_94a9b427","line":91,"range":{"start_line":91,"start_character":64,"end_line":91,"end_character":77},"updated":"2016-02-24 18:51:24.000000000","message":"Check for None?","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Check the format of the detail keys"},{"line_number":89,"context_line":"            if format \u003d\u003d \u0027detail\u0027:"},{"line_number":90,"context_line":"                if utils.is_microversion_ge(version, \u00272.12\u0027):"},{"line_number":91,"context_line":"                    self.assertIn(export_location[\u0027preferred\u0027], (True, False))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                if role \u003d\u003d \u0027admin\u0027:"},{"line_number":94,"context_line":"                    self.assertIn(export_location[\u0027is_admin_only\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_39e88e16","line":91,"range":{"start_line":91,"start_character":64,"end_line":91,"end_character":77},"in_reply_to":"bae84128_94a9b427","updated":"2016-02-25 01:44:04.000000000","message":"Ben asked that preferred always be True or False, so I coded it so that None isn\u0027t possible (else it\u0027s an error that this test will catch).","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        admin_summary_keys \u003d list(summary_keys) + ["},{"line_number":55,"context_line":"            \u0027share_instance_id\u0027, \u0027is_admin_only\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_49424269","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":40},"updated":"2016-02-29 21:43:46.000000000","message":"why do you need list conversion?","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        admin_summary_keys \u003d list(summary_keys) + ["},{"line_number":55,"context_line":"            \u0027share_instance_id\u0027, \u0027is_admin_only\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_7f09442c","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":40},"in_reply_to":"7af24918_0860cfcd","updated":"2016-03-01 22:27:08.000000000","message":"Done","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        admin_summary_keys \u003d list(summary_keys) + ["},{"line_number":55,"context_line":"            \u0027share_instance_id\u0027, \u0027is_admin_only\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_f00a0925","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":40},"in_reply_to":"9aed3d3a_49424269","updated":"2016-03-01 04:46:01.000000000","message":"I wanted a separate copy of the key list, so that when someone adds another key with a new microversion, doing \"detail_keys +\u003d [\u0027new_key\u0027]\" doesn\u0027t also modify summary keys.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45430bbec8bc40a8e7f71582ab8a37f6d1bb1aaf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        admin_summary_keys \u003d list(summary_keys) + ["},{"line_number":55,"context_line":"            \u0027share_instance_id\u0027, \u0027is_admin_only\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_0860cfcd","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":40},"in_reply_to":"9aed3d3a_f00a0925","updated":"2016-03-01 18:15:31.000000000","message":"you perform \"+\" operation that generates new object anyway.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4622ccc5f63c7c2f01e68cf888645a2a65192298","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if format \u003d\u003d \u0027summary\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_a9530e38","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":52},"updated":"2016-02-29 21:43:46.000000000","message":"ditto","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"82345ae5cf9d390542e2663cec3aeb085391a694","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if format \u003d\u003d \u0027summary\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ff1d5467","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":52},"in_reply_to":"7af24918_48a017f5","updated":"2016-03-01 22:27:08.000000000","message":"Changed.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3673582b4832d9e0be741b53b540f96daa95d4df","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if format \u003d\u003d \u0027summary\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_d308af2a","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":52},"in_reply_to":"9aed3d3a_a9530e38","updated":"2016-03-01 04:46:01.000000000","message":"Ditto, I\u0027m just doing some paranoid futureproofing.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45430bbec8bc40a8e7f71582ab8a37f6d1bb1aaf","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        detail_keys \u003d list(summary_keys) + [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        admin_detail_keys \u003d list(admin_summary_keys) + ["},{"line_number":60,"context_line":"            \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if format \u003d\u003d \u0027summary\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_48a017f5","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":52},"in_reply_to":"9aed3d3a_d308af2a","updated":"2016-03-01 18:15:31.000000000","message":"not paranoid, just redundant.","commit_id":"dca9f79448e0f47804d57063755defc0d13dd4a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    timeutils.parse_strtime(time)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":105,"context_line":"    @ddt.data(\u00272.11\u0027, LATEST_MICROVERSION)"},{"line_number":106,"context_line":"    def test_list_share_export_locations(self, version):"},{"line_number":107,"context_line":"        export_locations \u003d self.admin_client.list_share_export_locations("},{"line_number":108,"context_line":"            self.share[\u0027id\u0027], version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_8b63201a","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":19},"updated":"2016-03-02 03:37:33.000000000","message":"This assumes that the server supports 2.11; could you separate these methods and use a \u0027skip exception\u0027?","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    timeutils.parse_strtime(time)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":105,"context_line":"    @ddt.data(\u00272.11\u0027, LATEST_MICROVERSION)"},{"line_number":106,"context_line":"    def test_list_share_export_locations(self, version):"},{"line_number":107,"context_line":"        export_locations \u003d self.admin_client.list_share_export_locations("},{"line_number":108,"context_line":"            self.share[\u0027id\u0027], version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_1602946f","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":19},"in_reply_to":"7af24918_8b63201a","updated":"2016-03-02 05:45:18.000000000","message":"Done","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e567ec29d3cfb0720acd6d509aa946d2e3b8b88f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                                   format\u003d\u0027detail\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":142,"context_line":"    @ddt.data(\u00272.11\u0027, LATEST_MICROVERSION)"},{"line_number":143,"context_line":"    def test_list_share_instance_export_locations(self, version):"},{"line_number":144,"context_line":"        for share_instance in self.share_instances:"},{"line_number":145,"context_line":"            export_locations \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_cb6d2806","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":18},"updated":"2016-03-02 03:37:33.000000000","message":"same","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0937a82e24a514b5f981eaf7d743ee6907b6d9b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                                   format\u003d\u0027detail\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":142,"context_line":"    @ddt.data(\u00272.11\u0027, LATEST_MICROVERSION)"},{"line_number":143,"context_line":"    def test_list_share_instance_export_locations(self, version):"},{"line_number":144,"context_line":"        for share_instance in self.share_instances:"},{"line_number":145,"context_line":"            export_locations \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_360d1091","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":18},"in_reply_to":"7af24918_cb6d2806","updated":"2016-03-02 05:45:18.000000000","message":"Done","commit_id":"a072218da6e3ba4a9ab562753aeb583ae7186588"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a9828607fc85c7edfb7d3ea15dc33ba1126121c5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                self.assertIn(key, export_location)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # Check the format of ever-present summary keys"},{"line_number":83,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(export_location[\u0027id\u0027]))"},{"line_number":84,"context_line":"            self.assertTrue(isinstance(export_location[\u0027path\u0027],"},{"line_number":85,"context_line":"                                       six.string_types))"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_13e3b006","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":70},"updated":"2016-03-02 12:19:56.000000000","message":"this key will be absent on 2.9-2.13 microversions.","commit_id":"e44b9764624179ec9244ba4a85a4ab988584c89c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8879f99be1b9fff9ca2bef08712a3279ee48923c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                self.assertIn(key, export_location)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # Check the format of ever-present summary keys"},{"line_number":83,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(export_location[\u0027id\u0027]))"},{"line_number":84,"context_line":"            self.assertTrue(isinstance(export_location[\u0027path\u0027],"},{"line_number":85,"context_line":"                                       six.string_types))"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_d47120e2","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":70},"in_reply_to":"7af24918_13e3b006","updated":"2016-03-02 16:04:32.000000000","message":"As we discussed today, I treated this as a bug and changed the code for all microversions.  So this shouldn\u0027t cause a failure.","commit_id":"e44b9764624179ec9244ba4a85a4ab988584c89c"}],"manila_tempest_tests/tests/api/admin/test_export_locations_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cls.share[\u0027id\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":40,"context_line":"    def test_get_export_locations_by_nonexistent_share(self):"},{"line_number":41,"context_line":"        self.assertRaises("},{"line_number":42,"context_line":"            lib_exc.NotFound,"},{"line_number":43,"context_line":"            self.admin_client.list_share_export_locations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_0f5751cb","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":40},"updated":"2016-02-24 18:51:24.000000000","message":"All of these fixes looks unrelated too to the goal of commit.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cls.share[\u0027id\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":40,"context_line":"    def test_get_export_locations_by_nonexistent_share(self):"},{"line_number":41,"context_line":"        self.assertRaises("},{"line_number":42,"context_line":"            lib_exc.NotFound,"},{"line_number":43,"context_line":"            self.admin_client.list_share_export_locations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_59f752f5","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":40},"in_reply_to":"bae84128_0f5751cb","updated":"2016-02-25 01:44:04.000000000","message":"True.  I restored the misspellings.  It hurt :-)","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a9828607fc85c7edfb7d3ea15dc33ba1126121c5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                self.assertRaises("},{"line_number":91,"context_line":"                    lib_exc.Forbidden,"},{"line_number":92,"context_line":"                    self.member_client.get_share_instance_export_location,"},{"line_number":93,"context_line":"                    share_instance[\u0027id\u0027], el[\u0027id\u0027],"},{"line_number":94,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_932fc03d","line":93,"range":{"start_line":93,"start_character":42,"end_line":93,"end_character":51},"updated":"2016-03-02 12:19:56.000000000","message":"Now it is dependent on microversion. and will fail if we set max supported API to 2.13","commit_id":"e44b9764624179ec9244ba4a85a4ab988584c89c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8879f99be1b9fff9ca2bef08712a3279ee48923c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                self.assertRaises("},{"line_number":91,"context_line":"                    lib_exc.Forbidden,"},{"line_number":92,"context_line":"                    self.member_client.get_share_instance_export_location,"},{"line_number":93,"context_line":"                    share_instance[\u0027id\u0027], el[\u0027id\u0027],"},{"line_number":94,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_af9cfdc0","line":93,"range":{"start_line":93,"start_character":42,"end_line":93,"end_character":51},"in_reply_to":"7af24918_932fc03d","updated":"2016-03-02 16:04:32.000000000","message":"It shouldn\u0027t given how I changed it.","commit_id":"e44b9764624179ec9244ba4a85a4ab988584c89c"}],"manila_tempest_tests/tests/api/test_quotas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7f67f574617bfe292b26eb4dce8090ea72fb2a2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SharesQuotasTest(base.BaseSharesTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_6ffffdaa","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":8},"updated":"2016-02-24 18:51:24.000000000","message":"This one definitely should be in other commit.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"553f8dcfc7407f8bd65ac2daf67c9f7d4968ea2c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SharesQuotasTest(base.BaseSharesTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_59ce32b5","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":8},"in_reply_to":"bae84128_6ffffdaa","updated":"2016-02-25 01:44:04.000000000","message":"OK, I changed it back.  I need to look for other ones anyway.","commit_id":"acebaccb607a43baa0834aa57ed095bfbf460b85"}]}
