)]}'
{"manila/api/openstack/wsgi.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3afce14f180a9dc67bc338178bfbf58f099e172b","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        try:"},{"line_number":1210,"context_line":"            update[status_attr] \u003d body[status_attr]"},{"line_number":1211,"context_line":"        except (TypeError, KeyError):"},{"line_number":1212,"context_line":"            msg \u003d _(\"Must specify \u0027%s\u0027\")"},{"line_number":1213,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg % status_attr)"},{"line_number":1214,"context_line":"        if update[status_attr] not in self.valid_statuses[status_attr]:"},{"line_number":1215,"context_line":"            expl \u003d (_(\"Invalid state. Valid states: %s.\") %"},{"line_number":1216,"context_line":"                    \", \".join(self.valid_statuses[status_attr]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0bdf623a","line":1213,"range":{"start_line":1212,"start_character":10,"end_line":1213,"end_character":73},"updated":"2016-02-24 12:29:54.000000000","message":"very small nit: format the string in the same statement.","commit_id":"2be9ce5006fcefc5b36e22e1b4873884aab85fcd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3afce14f180a9dc67bc338178bfbf58f099e172b","unresolved":false,"context_lines":[{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"    @Controller.authorize(\u0027reset_status\u0027)"},{"line_number":1221,"context_line":"    def _reset_status(self, req, id, body, status_attr\u003d\u0027status\u0027):"},{"line_number":1222,"context_line":"        \"\"\"Reset status on the resource.\"\"\""},{"line_number":1223,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":1224,"context_line":"        body_attr \u003d self.body_attributes[status_attr]"},{"line_number":1225,"context_line":"        update \u003d self.validate_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_8ba7f2a5","line":1222,"range":{"start_line":1222,"start_character":8,"end_line":1222,"end_character":43},"updated":"2016-02-24 12:29:54.000000000","message":"This docstring does not make sense anymore if you are updating any field, not only status. Method name may be renamed to \"reset_attribute\" or something like that. Will make more sense.","commit_id":"2be9ce5006fcefc5b36e22e1b4873884aab85fcd"}],"manila/share/manager.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"23699666277b8df95f147ccfd050a88d77c4e32e","unresolved":false,"context_lines":[{"line_number":884,"context_line":"                context, share_replica[\u0027id\u0027],"},{"line_number":885,"context_line":"                {\u0027status\u0027: constants.STATUS_ERROR,"},{"line_number":886,"context_line":"                 \u0027replica_state\u0027: constants.STATUS_ERROR})"},{"line_number":887,"context_line":"            msg \u003d _(\"An active instance with \u0027available\u0027 status does \""},{"line_number":888,"context_line":"                    \"not exist to add replica to share %s.\")"},{"line_number":889,"context_line":"            raise exception.ReplicationException("},{"line_number":890,"context_line":"                reason\u003dmsg % share_replica[\u0027share_id\u0027])"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_d94937b9","line":888,"range":{"start_line":887,"start_character":21,"end_line":888,"end_character":54},"updated":"2016-02-22 20:58:41.000000000","message":"This wording is kinda awkward.","commit_id":"2be9ce5006fcefc5b36e22e1b4873884aab85fcd"}],"manila/share/rpcapi.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3afce14f180a9dc67bc338178bfbf58f099e172b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                          share_replica_id\u003dshare_replica_id,"},{"line_number":246,"context_line":"                          share_id\u003dshare_id)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def update_share_replica(self, context, share_replica_id, host,"},{"line_number":249,"context_line":"                             share_id\u003dNone):"},{"line_number":250,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":251,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":252,"context_line":"        call_context.cast(context,"},{"line_number":253,"context_line":"                          \u0027update_share_replica\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2eb3540b","line":250,"range":{"start_line":248,"start_character":4,"end_line":250,"end_character":43},"updated":"2016-02-24 12:29:54.000000000","message":"nit: I would prefer if this method received the share_replica model and extracted the host from it.","commit_id":"2be9ce5006fcefc5b36e22e1b4873884aab85fcd"}]}