)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08582f107b5d993f0cce6d63fec303cc59b92dac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve exception msg when attaching/detaching volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When something goes wrong in the generic drivers attach/detach"},{"line_number":10,"context_line":"volume handing, be more verbose and also show the volume-id in the"},{"line_number":11,"context_line":"exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I03176801bf6f0d76a2d82b94ba6c1d5ee8f6193e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aed3d3a_1a681af5","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":14},"updated":"2016-02-26 01:06:55.000000000","message":"handling?","commit_id":"68fd502c4d123dc57c5fdd20915446d9f4db588d"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3dbc2a908ccf31c1de9535cab8499ca657613b25","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                        _(\u0027Failed to attach volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":407,"context_line":"                time.sleep(1)"},{"line_number":408,"context_line":"            else:"},{"line_number":409,"context_line":"                msg_dict \u003d dict(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":410,"context_line":"                                max_time\u003dself.configuration.max_time_to_attach)"},{"line_number":411,"context_line":"                raise exception.ManilaException("},{"line_number":412,"context_line":"                    _(\u0027Volume %(volume_id)s have not been attached in \u0027"},{"line_number":413,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9e541855","line":410,"range":{"start_line":409,"start_character":16,"end_line":410,"end_character":79},"updated":"2016-02-19 17:30:08.000000000","message":"Please do not add new code using dict(), use {}.","commit_id":"1a278c850c75c3d9982f156d99dc159d40abb580"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"81a83c12fab69f1f7ee98e6dabe68a81e59d0cd0","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                        _(\u0027Failed to attach volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":407,"context_line":"                time.sleep(1)"},{"line_number":408,"context_line":"            else:"},{"line_number":409,"context_line":"                msg_dict \u003d dict(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":410,"context_line":"                                max_time\u003dself.configuration.max_time_to_attach)"},{"line_number":411,"context_line":"                raise exception.ManilaException("},{"line_number":412,"context_line":"                    _(\u0027Volume %(volume_id)s have not been attached in \u0027"},{"line_number":413,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_1dfbabc2","line":410,"range":{"start_line":409,"start_character":16,"end_line":410,"end_character":79},"in_reply_to":"bae84128_9e541855","updated":"2016-02-22 09:25:58.000000000","message":"Done","commit_id":"1a278c850c75c3d9982f156d99dc159d40abb580"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3dbc2a908ccf31c1de9535cab8499ca657613b25","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                        break"},{"line_number":502,"context_line":"                    time.sleep(1)"},{"line_number":503,"context_line":"                else:"},{"line_number":504,"context_line":"                    msg_dict \u003d dict("},{"line_number":505,"context_line":"                        volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":506,"context_line":"                        max_time\u003dself.configuration.max_time_to_attach"},{"line_number":507,"context_line":"                    )"},{"line_number":508,"context_line":"                    raise exception.ManilaException("},{"line_number":509,"context_line":"                        _(\u0027Volume %(volume_id)s have not been detached in \u0027"},{"line_number":510,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_3ed6acc5","line":507,"range":{"start_line":504,"start_character":20,"end_line":507,"end_character":21},"updated":"2016-02-19 17:30:08.000000000","message":"Please do not add new code using dict(), use {}.","commit_id":"1a278c850c75c3d9982f156d99dc159d40abb580"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"81a83c12fab69f1f7ee98e6dabe68a81e59d0cd0","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                        break"},{"line_number":502,"context_line":"                    time.sleep(1)"},{"line_number":503,"context_line":"                else:"},{"line_number":504,"context_line":"                    msg_dict \u003d dict("},{"line_number":505,"context_line":"                        volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":506,"context_line":"                        max_time\u003dself.configuration.max_time_to_attach"},{"line_number":507,"context_line":"                    )"},{"line_number":508,"context_line":"                    raise exception.ManilaException("},{"line_number":509,"context_line":"                        _(\u0027Volume %(volume_id)s have not been detached in \u0027"},{"line_number":510,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_fdf527cb","line":507,"range":{"start_line":504,"start_character":20,"end_line":507,"end_character":21},"in_reply_to":"bae84128_3ed6acc5","updated":"2016-02-22 09:25:58.000000000","message":"Done","commit_id":"1a278c850c75c3d9982f156d99dc159d40abb580"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"bb8223a2e312d1833213aee5552916759c07be81","unresolved":false,"context_lines":[{"line_number":507,"context_line":"                    )"},{"line_number":508,"context_line":"                    raise exception.ManilaException("},{"line_number":509,"context_line":"                        _(\u0027Volume %(volume_id)s have not been detached in \u0027"},{"line_number":510,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":511,"context_line":"        do_detach()"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def _allocate_container(self, context, share, snapshot\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_86034eb8","line":510,"updated":"2016-02-19 09:20:56.000000000","message":"personally I\u0027d prefer an inline replacement, e.g \n\n  % {\n  \u0027volume_id\u0027: volume[\u0027id\u0027],\n  \u0027max_time\u0027: self.configuration.max_time_to_attach }","commit_id":"1a278c850c75c3d9982f156d99dc159d40abb580"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9bc60d3ebee003f1c2800cb197c77f521495bc08","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":412,"context_line":"                }"},{"line_number":413,"context_line":"                raise exception.ManilaException("},{"line_number":414,"context_line":"                    _(\u0027Volume %(volume_id)s have not been attached in \u0027"},{"line_number":415,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":416,"context_line":"        return do_attach(volume)"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e3ff4865","line":414,"range":{"start_line":414,"start_character":44,"end_line":414,"end_character":48},"updated":"2016-02-22 10:20:44.000000000","message":"Please, change \"have\" to \"has\" as you already change this line.","commit_id":"f5c7d65ca92d98de873ec5de13bf471763d42046"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"28e1a445d82ed654ccf6beb6be75a67859eee3d4","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":412,"context_line":"                }"},{"line_number":413,"context_line":"                raise exception.ManilaException("},{"line_number":414,"context_line":"                    _(\u0027Volume %(volume_id)s have not been attached in \u0027"},{"line_number":415,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":416,"context_line":"        return do_attach(volume)"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_802c6703","line":414,"range":{"start_line":414,"start_character":44,"end_line":414,"end_character":48},"in_reply_to":"bae84128_e3ff4865","updated":"2016-02-22 14:04:43.000000000","message":"Done","commit_id":"f5c7d65ca92d98de873ec5de13bf471763d42046"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9bc60d3ebee003f1c2800cb197c77f521495bc08","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                        \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":509,"context_line":"                    }"},{"line_number":510,"context_line":"                    raise exception.ManilaException("},{"line_number":511,"context_line":"                        _(\u0027Volume %(volume_id)s have not been detached in \u0027"},{"line_number":512,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":513,"context_line":"        do_detach()"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_23fad075","line":511,"range":{"start_line":511,"start_character":48,"end_line":511,"end_character":52},"updated":"2016-02-22 10:20:44.000000000","message":"Same here.","commit_id":"f5c7d65ca92d98de873ec5de13bf471763d42046"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"28e1a445d82ed654ccf6beb6be75a67859eee3d4","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                        \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":509,"context_line":"                    }"},{"line_number":510,"context_line":"                    raise exception.ManilaException("},{"line_number":511,"context_line":"                        _(\u0027Volume %(volume_id)s have not been detached in \u0027"},{"line_number":512,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":513,"context_line":"        do_detach()"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a039ab43","line":511,"range":{"start_line":511,"start_character":48,"end_line":511,"end_character":52},"in_reply_to":"bae84128_23fad075","updated":"2016-02-22 14:04:43.000000000","message":"Done","commit_id":"f5c7d65ca92d98de873ec5de13bf471763d42046"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c756e89e544c62ded3d79c2ab5d721bb90330eb","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                        _(\u0027Failed to attach volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":407,"context_line":"                time.sleep(1)"},{"line_number":408,"context_line":"            else:"},{"line_number":409,"context_line":"                msg_dict \u003d {"},{"line_number":410,"context_line":"                    \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":411,"context_line":"                    \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":412,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_17e1add0","line":409,"range":{"start_line":409,"start_character":16,"end_line":409,"end_character":24},"updated":"2016-02-22 18:42:54.000000000","message":"I disagree with Gabor\u0027s comment, but this variable name could be more intuitive, like \"error_msg\".","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"80ea043b63518862322100c9e42b377b21b1db24","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                        _(\u0027Failed to attach volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":407,"context_line":"                time.sleep(1)"},{"line_number":408,"context_line":"            else:"},{"line_number":409,"context_line":"                msg_dict \u003d {"},{"line_number":410,"context_line":"                    \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":411,"context_line":"                    \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":412,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_1703bfb9","line":409,"range":{"start_line":409,"start_character":16,"end_line":409,"end_character":24},"in_reply_to":"bae84128_17e1add0","updated":"2016-02-25 10:33:30.000000000","message":"Done","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c756e89e544c62ded3d79c2ab5d721bb90330eb","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                }"},{"line_number":413,"context_line":"                raise exception.ManilaException("},{"line_number":414,"context_line":"                    _(\u0027Volume %(volume_id)s has not been attached in \u0027"},{"line_number":415,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":416,"context_line":"        return do_attach(volume)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_volume_name(self, share_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_b7e8c1e3","line":415,"range":{"start_line":415,"start_character":47,"end_line":415,"end_character":48},"updated":"2016-02-22 18:42:54.000000000","message":"Please add a period.","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"80ea043b63518862322100c9e42b377b21b1db24","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                }"},{"line_number":413,"context_line":"                raise exception.ManilaException("},{"line_number":414,"context_line":"                    _(\u0027Volume %(volume_id)s has not been attached in \u0027"},{"line_number":415,"context_line":"                      \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":416,"context_line":"        return do_attach(volume)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_volume_name(self, share_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_b7f5b3cc","line":415,"range":{"start_line":415,"start_character":47,"end_line":415,"end_character":48},"in_reply_to":"bae84128_b7e8c1e3","updated":"2016-02-25 10:33:30.000000000","message":"Done","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c756e89e544c62ded3d79c2ab5d721bb90330eb","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                        break"},{"line_number":504,"context_line":"                    time.sleep(1)"},{"line_number":505,"context_line":"                else:"},{"line_number":506,"context_line":"                    msg_dict \u003d {"},{"line_number":507,"context_line":"                        \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":508,"context_line":"                        \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":509,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_77e8f9b4","line":506,"range":{"start_line":506,"start_character":20,"end_line":506,"end_character":28},"updated":"2016-02-22 18:42:54.000000000","message":"I disagree with Gabor\u0027s comment, but this variable name could be more intuitive, like \"error_msg\".","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"80ea043b63518862322100c9e42b377b21b1db24","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                        break"},{"line_number":504,"context_line":"                    time.sleep(1)"},{"line_number":505,"context_line":"                else:"},{"line_number":506,"context_line":"                    msg_dict \u003d {"},{"line_number":507,"context_line":"                        \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":508,"context_line":"                        \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":509,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_970eafe3","line":506,"range":{"start_line":506,"start_character":20,"end_line":506,"end_character":28},"in_reply_to":"bae84128_77e8f9b4","updated":"2016-02-25 10:33:30.000000000","message":"Done","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c756e89e544c62ded3d79c2ab5d721bb90330eb","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    }"},{"line_number":510,"context_line":"                    raise exception.ManilaException("},{"line_number":511,"context_line":"                        _(\u0027Volume %(volume_id)s has not been detached in \u0027"},{"line_number":512,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":513,"context_line":"        do_detach()"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _allocate_container(self, context, share, snapshot\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_57e175fd","line":512,"range":{"start_line":512,"start_character":51,"end_line":512,"end_character":52},"updated":"2016-02-22 18:42:54.000000000","message":"Please add a period.","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"80ea043b63518862322100c9e42b377b21b1db24","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    }"},{"line_number":510,"context_line":"                    raise exception.ManilaException("},{"line_number":511,"context_line":"                        _(\u0027Volume %(volume_id)s has not been detached in \u0027"},{"line_number":512,"context_line":"                          \u0027%(max_time)ss. Giving up\u0027) % msg_dict)"},{"line_number":513,"context_line":"        do_detach()"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _allocate_container(self, context, share, snapshot\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_77132b0e","line":512,"range":{"start_line":512,"start_character":51,"end_line":512,"end_character":52},"in_reply_to":"bae84128_57e175fd","updated":"2016-02-25 10:33:30.000000000","message":"Done","commit_id":"86936c2619afbe740194097daa4323e582bc79d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08582f107b5d993f0cce6d63fec303cc59b92dac","unresolved":false,"context_lines":[{"line_number":408,"context_line":"            else:"},{"line_number":409,"context_line":"                err_msg \u003d {"},{"line_number":410,"context_line":"                    \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":411,"context_line":"                    \u0027max_time\u0027: self.configuration.max_time_to_attach"},{"line_number":412,"context_line":"                }"},{"line_number":413,"context_line":"                raise exception.ManilaException("},{"line_number":414,"context_line":"                    _(\u0027Volume %(volume_id)s has not been attached in \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_7ab6868b","line":411,"range":{"start_line":411,"start_character":51,"end_line":411,"end_character":69},"updated":"2016-02-26 01:06:55.000000000","message":"nit: trailing comma, here and below.","commit_id":"68fd502c4d123dc57c5fdd20915446d9f4db588d"}]}
