)]}'
{"manila/share/drivers/service_instance.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ba911ef3c5eb8f7e0732183894c70a0df3659092","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    def _get_set_of_device_cidrs(self, device):"},{"line_number":917,"context_line":"        cidrs \u003d set()"},{"line_number":918,"context_line":"        addr_list \u003d []"},{"line_number":919,"context_line":"        try:"},{"line_number":920,"context_line":"            # NOTE(ganso): I could call ip_lib.device_exists here, but since"},{"line_number":921,"context_line":"            # this is a concurrency problem, it would not fix the problem."},{"line_number":922,"context_line":"            addr_list \u003d device.addr.list()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8dff7866","line":919,"updated":"2016-02-22 16:48:43.000000000","message":"Does that really work? Isn\u0027t addr_list() always empty if one of the devices is gone while iterating over it?\nImo this fix should be done in the list() function.","commit_id":"97531facd1944449092fad5062efca259c227b91"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2bd95e00524c81d398bc3b3b5cf936458af7b1c3","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    def _get_set_of_device_cidrs(self, device):"},{"line_number":917,"context_line":"        cidrs \u003d set()"},{"line_number":918,"context_line":"        addr_list \u003d []"},{"line_number":919,"context_line":"        try:"},{"line_number":920,"context_line":"            # NOTE(ganso): I could call ip_lib.device_exists here, but since"},{"line_number":921,"context_line":"            # this is a concurrency problem, it would not fix the problem."},{"line_number":922,"context_line":"            addr_list \u003d device.addr.list()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_90a66b0e","line":919,"in_reply_to":"bae84128_8dff7866","updated":"2016-02-22 16:58:37.000000000","message":"ip_lib IPAddrNetwork.list runs a \"ip addr show {device_name}\" command to retrieve the list of addresses of a device, so if {device_name} does not exist, it throws an exception. It is not the address that does not exist, it is the device it belongs to.\n\nthe list method returning empty would mean that the device has no addresses, this is not entirely true, since the device does not even exist.","commit_id":"97531facd1944449092fad5062efca259c227b91"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"b69ebdcc98a4ab9b73f59b9d6c2bb28331b5ce96","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    def _get_set_of_device_cidrs(self, device):"},{"line_number":917,"context_line":"        cidrs \u003d set()"},{"line_number":918,"context_line":"        addr_list \u003d []"},{"line_number":919,"context_line":"        try:"},{"line_number":920,"context_line":"            # NOTE(ganso): I could call ip_lib.device_exists here, but since"},{"line_number":921,"context_line":"            # this is a concurrency problem, it would not fix the problem."},{"line_number":922,"context_line":"            addr_list \u003d device.addr.list()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_70e127fe","line":919,"in_reply_to":"bae84128_90a66b0e","updated":"2016-02-22 17:03:50.000000000","message":"Ah. Sorry. It\u0027s per device. I thought it\u0027s iterating over all devices.","commit_id":"97531facd1944449092fad5062efca259c227b91"}]}
