)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8a9102b399a616c1299e93dad3ce838847b1d9be","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix binding in neutron driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current implementation allows a port binding by specifying a"},{"line_number":10,"context_line":"neutron_host_id (introduced with LXC feature). Issue with that is that a"},{"line_number":11,"context_line":"binding in neutron has a state and this state must be checked otherwise"},{"line_number":12,"context_line":"there can be race conditions happening."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1af94dfe_a836a4e4","line":10,"updated":"2016-03-17 09:19:24.000000000","message":"Marc, LXC feature is almost gone. Probably it is not a good idea to refer to it.","commit_id":"788a0ac5b645e31267d2e7d7ab31a8a65785e7b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new neutron plugin which enables port bind actions for network"},{"line_number":10,"context_line":"fabrics. This driver waits until all ports are in state \"active\""},{"line_number":11,"context_line":"and set\u0027s the binding host flag. Default vNIC type is set to"},{"line_number":12,"context_line":"\"baremetal\" in order to benefit from the code already in place for"},{"line_number":13,"context_line":"Ironic. It\u0027s also possible to switch to \u0027normal\u0027 which assumes an"},{"line_number":14,"context_line":"neutron agent in place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dada55a8_66fd2c3b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":10},"updated":"2016-07-25 13:44:38.000000000","message":"sets","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new neutron plugin which enables port bind actions for network"},{"line_number":10,"context_line":"fabrics. This driver waits until all ports are in state \"active\""},{"line_number":11,"context_line":"and set\u0027s the binding host flag. Default vNIC type is set to"},{"line_number":12,"context_line":"\"baremetal\" in order to benefit from the code already in place for"},{"line_number":13,"context_line":"Ironic. It\u0027s also possible to switch to \u0027normal\u0027 which assumes an"},{"line_number":14,"context_line":"neutron agent in place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_cda4cba7","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":10},"in_reply_to":"dada55a8_66fd2c3b","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"baremetal\" in order to benefit from the code already in place for"},{"line_number":13,"context_line":"Ironic. It\u0027s also possible to switch to \u0027normal\u0027 which assumes an"},{"line_number":14,"context_line":"neutron agent in place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":17,"context_line":"Partly-implements: bp manila-hpb-support"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dada55a8_725dd314","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2016-07-25 13:44:38.000000000","message":"DocImpact flag, please..","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"baremetal\" in order to benefit from the code already in place for"},{"line_number":13,"context_line":"Ironic. It\u0027s also possible to switch to \u0027normal\u0027 which assumes an"},{"line_number":14,"context_line":"neutron agent in place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":17,"context_line":"Partly-implements: bp manila-hpb-support"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_ad9fd74e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"dada55a8_725dd314","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"neutron agent in place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":17,"context_line":"Partly-implements: bp manila-hpb-support"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I3156d7468d48f84f1b46885780a2426f9b99a387"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dada55a8_c6fcd840","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2016-07-25 13:44:38.000000000","message":"Partially","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"neutron agent in place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"},{"line_number":17,"context_line":"Partly-implements: bp manila-hpb-support"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I3156d7468d48f84f1b46885780a2426f9b99a387"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bacf61ea_4db73bd8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"dada55a8_c6fcd840","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"}],"doc/source/adminref/network_plugins.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  1.3 `manila.network.neutron.neutron_network_plugin.NeutronBindNetworkPlugin`."},{"line_number":81,"context_line":"    This driver waits for active binding and fails if a Neutron port can\u0027t be"},{"line_number":82,"context_line":"    bound or an error occurs. This drives is useful for agent based binding"},{"line_number":83,"context_line":"    (like OVS with docker driver) and fabric binding where real HW"},{"line_number":84,"context_line":"    reconfiguration is taking place. The existing"},{"line_number":85,"context_line":"    `NeutronBindSingleNetworkPlugin` is a combination of 1.2 and 1.3."}],"source_content_type":"text/x-rst","patch_set":27,"id":"3ac371cc_8b83ea55","line":82,"range":{"start_line":82,"start_character":35,"end_line":82,"end_character":41},"updated":"2016-08-16 16:04:02.000000000","message":"driver? plugin?","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  1.3 `manila.network.neutron.neutron_network_plugin.NeutronBindNetworkPlugin`."},{"line_number":81,"context_line":"    This driver waits for active binding and fails if a Neutron port can\u0027t be"},{"line_number":82,"context_line":"    bound or an error occurs. This drives is useful for agent based binding"},{"line_number":83,"context_line":"    (like OVS with docker driver) and fabric binding where real HW"},{"line_number":84,"context_line":"    reconfiguration is taking place. The existing"},{"line_number":85,"context_line":"    `NeutronBindSingleNetworkPlugin` is a combination of 1.2 and 1.3."}],"source_content_type":"text/x-rst","patch_set":27,"id":"3ac371cc_8f5ab628","line":82,"range":{"start_line":82,"start_character":35,"end_line":82,"end_character":41},"in_reply_to":"3ac371cc_8b83ea55","updated":"2016-08-17 12:57:09.000000000","message":"Done","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"}],"manila/exception.py":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"fa2770ee29ed68d1d0370ec227fe05125b3f8554","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NetworkBindException(ManilaException):"},{"line_number":118,"context_line":"    message \u003d _(\"Exception due failed port status in binding.\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class NetworkBadConfigurationException(NetworkException):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_2f2130b5","line":118,"range":{"start_line":118,"start_character":27,"end_line":118,"end_character":32},"updated":"2016-08-16 13:35:52.000000000","message":"due to failed?","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NetworkBindException(ManilaException):"},{"line_number":118,"context_line":"    message \u003d _(\"Exception due failed port status in binding.\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class NetworkBadConfigurationException(NetworkException):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_4b6452e3","line":118,"range":{"start_line":118,"start_character":27,"end_line":118,"end_character":32},"in_reply_to":"3ac371cc_2f2130b5","updated":"2016-08-16 16:04:02.000000000","message":"+1","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NetworkBindException(ManilaException):"},{"line_number":118,"context_line":"    message \u003d _(\"Exception due failed port status in binding.\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class NetworkBadConfigurationException(NetworkException):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_ef436a40","line":118,"range":{"start_line":118,"start_character":27,"end_line":118,"end_character":32},"in_reply_to":"3ac371cc_4b6452e3","updated":"2016-08-17 12:57:09.000000000","message":"Done","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"}],"manila/network/__init__.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        :param share_server: share server object"},{"line_number":76,"context_line":"        :return: list of updated ports or None if nothing was updated"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        return None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @abc.abstractmethod"},{"line_number":81,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_d2c6169b","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":19},"updated":"2016-06-17 15:10:12.000000000","message":"This line is redundant. Docstring is enough.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        :param share_server: share server object"},{"line_number":76,"context_line":"        :return: list of updated ports or None if nothing was updated"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        return None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @abc.abstractmethod"},{"line_number":81,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_a15298db","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":19},"in_reply_to":"7aa08908_d2c6169b","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"}],"manila/network/neutron/api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d4ec862cbe76189bb029badb5facbda340ddd1a8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        extensions_list \u003d self.client.list_extensions().get(\u0027extensions\u0027)"},{"line_number":252,"context_line":"        return {ext[\u0027name\u0027]: ext for ext in extensions_list}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def has_port_binding_extension(self):"},{"line_number":255,"context_line":"        if not self.extensions:"},{"line_number":256,"context_line":"            self.extensions \u003d self.list_extensions()"},{"line_number":257,"context_line":"        return neutron_constants.PORTBINDING_EXT in self.extensions"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_5891f151","line":254,"updated":"2016-05-08 04:37:28.000000000","message":"I don\u0027t see this function called externally other than in unit tests. Why is _ removed?","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        extensions_list \u003d self.client.list_extensions().get(\u0027extensions\u0027)"},{"line_number":252,"context_line":"        return {ext[\u0027name\u0027]: ext for ext in extensions_list}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def has_port_binding_extension(self):"},{"line_number":255,"context_line":"        if not self.extensions:"},{"line_number":256,"context_line":"            self.extensions \u003d self.list_extensions()"},{"line_number":257,"context_line":"        return neutron_constants.PORTBINDING_EXT in self.extensions"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_8c34a9fb","line":254,"in_reply_to":"dab17558_5891f151","updated":"2016-05-09 10:17:18.000000000","message":"It\u0027s used in neutron_network_plugin.py L292. I removed the \"_\" since it\u0027s used outside this module.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"f2997170ea4a1c4f29ff493771ab6eda399b5d35","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        extensions_list \u003d self.client.list_extensions().get(\u0027extensions\u0027)"},{"line_number":252,"context_line":"        return {ext[\u0027name\u0027]: ext for ext in extensions_list}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def has_port_binding_extension(self):"},{"line_number":255,"context_line":"        if not self.extensions:"},{"line_number":256,"context_line":"            self.extensions \u003d self.list_extensions()"},{"line_number":257,"context_line":"        return neutron_constants.PORTBINDING_EXT in self.extensions"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_42e9cf13","line":254,"updated":"2016-07-29 09:09:54.000000000","message":"unnecessary","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        extensions_list \u003d self.client.list_extensions().get(\u0027extensions\u0027)"},{"line_number":252,"context_line":"        return {ext[\u0027name\u0027]: ext for ext in extensions_list}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def has_port_binding_extension(self):"},{"line_number":255,"context_line":"        if not self.extensions:"},{"line_number":256,"context_line":"            self.extensions \u003d self.list_extensions()"},{"line_number":257,"context_line":"        return neutron_constants.PORTBINDING_EXT in self.extensions"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_edc0af2c","line":254,"in_reply_to":"bacf61ea_42e9cf13","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"983adfef7ce7a096fa8856d00d1ff99867e1b098","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt("},{"line_number":50,"context_line":"        \u0027vnic_type\u0027,"},{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1d2656ba","line":50,"updated":"2016-03-01 17:22:10.000000000","message":"It should have \"neutron_\" prefix as options above.","commit_id":"fde110bd8658ed424d18e638f7456fc530f1a3e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"983adfef7ce7a096fa8856d00d1ff99867e1b098","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        return share_network"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class NeutronBindNetworkPlugin(NeutronNetworkPlugin):"},{"line_number":301,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":302,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":303,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1d82d652","line":300,"range":{"start_line":300,"start_character":0,"end_line":300,"end_character":53},"updated":"2016-03-01 17:22:10.000000000","message":"Currently existing \"admin export locations\" feature makes it required to implement \"single_network_plugin\" too.\n\nSo, need to add one more class that uses network data from config and works with single network. - Analog of existing \"NeutronSingleNetworkPlugin\".","commit_id":"fde110bd8658ed424d18e638f7456fc530f1a3e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt("},{"line_number":50,"context_line":"        \u0027vnic_type\u0027,"},{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_1c1e5963","line":50,"updated":"2016-03-21 14:09:12.000000000","message":"Specific prefix should be added to option name.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt("},{"line_number":50,"context_line":"        \u0027vnic_type\u0027,"},{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_c5c1a082","line":50,"in_reply_to":"fa0719c6_1c1e5963","updated":"2016-03-21 14:50:47.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":48,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt("},{"line_number":50,"context_line":"        \u0027vnic_type\u0027,"},{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("},{"line_number":54,"context_line":"        \u0027bind_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_fc31e5ed","line":51,"updated":"2016-03-21 14:09:12.000000000","message":"What values are allowed?","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":48,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt("},{"line_number":50,"context_line":"        \u0027vnic_type\u0027,"},{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("},{"line_number":54,"context_line":"        \u0027bind_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_05bc3804","line":51,"in_reply_to":"fa0719c6_fc31e5ed","updated":"2016-03-21 14:50:47.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("},{"line_number":54,"context_line":"        \u0027bind_timeout\u0027,"},{"line_number":55,"context_line":"        help\u003d\"Bind timeout in seconds\","},{"line_number":56,"context_line":"        default\u003d240),"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_9c20a99d","line":54,"updated":"2016-03-21 14:09:12.000000000","message":"same here.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":52,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":53,"context_line":"    cfg.IntOpt("},{"line_number":54,"context_line":"        \u0027bind_timeout\u0027,"},{"line_number":55,"context_line":"        help\u003d\"Bind timeout in seconds\","},{"line_number":56,"context_line":"        default\u003d240),"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_6537f4b0","line":54,"in_reply_to":"fa0719c6_9c20a99d","updated":"2016-03-21 14:50:47.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            self.neutron_api.delete_port(port[\u0027id\u0027])"},{"line_number":167,"context_line":"        except exception.NetworkException:"},{"line_number":168,"context_line":"            self.db.network_allocation_usate("},{"line_number":169,"context_line":"                context, port[\u0027id\u0027], {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":170,"context_line":"            raise"},{"line_number":171,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_9ca54906","line":168,"range":{"start_line":168,"start_character":39,"end_line":168,"end_character":44},"updated":"2016-03-21 14:09:12.000000000","message":"?","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bc39b6283e9a120f50a5692bff3d61be1e05586","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            self.neutron_api.delete_port(port[\u0027id\u0027])"},{"line_number":167,"context_line":"        except exception.NetworkException:"},{"line_number":168,"context_line":"            self.db.network_allocation_usate("},{"line_number":169,"context_line":"                context, port[\u0027id\u0027], {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":170,"context_line":"            raise"},{"line_number":171,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_d0104051","line":168,"range":{"start_line":168,"start_character":39,"end_line":168,"end_character":44},"in_reply_to":"fa0719c6_9ca54906","updated":"2016-03-21 14:57:56.000000000","message":"Not addressed in PS7.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b79e72fcd9b424083b8b1af8af5b223190e3282f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            self.neutron_api.delete_port(port[\u0027id\u0027])"},{"line_number":167,"context_line":"        except exception.NetworkException:"},{"line_number":168,"context_line":"            self.db.network_allocation_usate("},{"line_number":169,"context_line":"                context, port[\u0027id\u0027], {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":170,"context_line":"            raise"},{"line_number":171,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_9c27e511","line":168,"range":{"start_line":168,"start_character":39,"end_line":168,"end_character":44},"in_reply_to":"fa0719c6_d0104051","updated":"2016-03-22 09:24:38.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return share_network"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"class NeutronBindNetworkPlugin(NeutronNetworkPlugin):"},{"line_number":279,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":280,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":281,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_9cca69a0","line":278,"updated":"2016-03-21 14:09:12.000000000","message":"If add new classes then only in pairs - \"share-network\"-based and \"config\"-based (single).\n\nIt was said in your previous commits.\n\nIt is not recommendation. It is requirement. Since Mitaka, Manila allows drivers to set up two networks - user-facing and admin-facing. And in case of NetApp driver, you will need to set up \"share-network\" based network plugin for user-facing net and \"single network plugin\" for admin net, that you do not implement here.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b79e72fcd9b424083b8b1af8af5b223190e3282f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return share_network"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"class NeutronBindNetworkPlugin(NeutronNetworkPlugin):"},{"line_number":279,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":280,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":281,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_02d40745","line":278,"in_reply_to":"fa0719c6_900ec832","updated":"2016-03-22 09:24:38.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bc39b6283e9a120f50a5692bff3d61be1e05586","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return share_network"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"class NeutronBindNetworkPlugin(NeutronNetworkPlugin):"},{"line_number":279,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":280,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":281,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_900ec832","line":278,"in_reply_to":"fa0719c6_9cca69a0","updated":"2016-03-21 14:57:56.000000000","message":"Not addressed in PS7.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                              dict(id\u003dport[\u0027id\u0027],"},{"line_number":304,"context_line":"                                   state\u003dport[\u0027status\u0027]))"},{"line_number":305,"context_line":"                    all_active \u003d False"},{"line_number":306,"context_line":"                if all_active:"},{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_bc92cd55","line":307,"range":{"start_line":306,"start_character":16,"end_line":307,"end_character":26},"updated":"2016-03-21 14:09:12.000000000","message":"It is done in cycle. So, cycle will end after first succeeded port.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                              dict(id\u003dport[\u0027id\u0027],"},{"line_number":304,"context_line":"                                   state\u003dport[\u0027status\u0027]))"},{"line_number":305,"context_line":"                    all_active \u003d False"},{"line_number":306,"context_line":"                if all_active:"},{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_ff4b97ae","line":307,"range":{"start_line":306,"start_character":16,"end_line":307,"end_character":26},"in_reply_to":"fa0719c6_bc92cd55","updated":"2016-03-21 14:50:47.000000000","message":"Oops I need to add a unit test for this","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"},{"line_number":311,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_dc7ce122","line":310,"range":{"start_line":310,"start_character":20,"end_line":310,"end_character":54},"updated":"2016-03-21 14:09:12.000000000","message":"Which ports? For which share server?","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b79e72fcd9b424083b8b1af8af5b223190e3282f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"},{"line_number":311,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_62cb43a6","line":310,"range":{"start_line":310,"start_character":20,"end_line":310,"end_character":54},"in_reply_to":"fa0719c6_05043815","updated":"2016-03-22 09:24:38.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bc39b6283e9a120f50a5692bff3d61be1e05586","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"},{"line_number":311,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_05043815","line":310,"range":{"start_line":310,"start_character":20,"end_line":310,"end_character":54},"in_reply_to":"fa0719c6_65e9b41a","updated":"2016-03-21 14:57:56.000000000","message":"Debug and exception are different levels.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    return"},{"line_number":308,"context_line":"            time.sleep(1)"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            msg \u003d (\"Ports are not bound during timeout\")"},{"line_number":311,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_65e9b41a","line":310,"range":{"start_line":310,"start_character":20,"end_line":310,"end_character":54},"in_reply_to":"fa0719c6_dc7ce122","updated":"2016-03-21 14:50:47.000000000","message":"The inactive ports are listed in the debug message. I added share server id","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c66901fa12cc68f25df04d54a4715d612a24b5c7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \u0027neutron_vnic_type\u0027,"},{"line_number":52,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":53,"context_line":"        choices\u003d[\u0027baremetal\u0027, \u0027normal\u0027, \u0027direct\u0027,"},{"line_number":54,"context_line":"                 \u0027direct-physical\u0027, \u0027macvtap\u0027],"},{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_d7bac722","line":52,"range":{"start_line":52,"start_character":40,"end_line":52,"end_character":41},"updated":"2016-05-09 03:28:12.000000000","message":"Add \u0027.\u0027 in the end.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d80c55e733dee3032678952fce43102ad324ea","unresolved":false,"context_lines":[{"line_number":49,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \u0027neutron_vnic_type\u0027,"},{"line_number":52,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":53,"context_line":"        choices\u003d[\u0027baremetal\u0027, \u0027normal\u0027, \u0027direct\u0027,"},{"line_number":54,"context_line":"                 \u0027direct-physical\u0027, \u0027macvtap\u0027],"},{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_7b8326cd","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":18},"updated":"2016-05-06 19:45:22.000000000","message":"vNIC","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \u0027neutron_vnic_type\u0027,"},{"line_number":52,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":53,"context_line":"        choices\u003d[\u0027baremetal\u0027, \u0027normal\u0027, \u0027direct\u0027,"},{"line_number":54,"context_line":"                 \u0027direct-physical\u0027, \u0027macvtap\u0027],"},{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_80458db4","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":18},"in_reply_to":"dab17558_7b8326cd","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"neutron_bind_network_plugin_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \u0027neutron_vnic_type\u0027,"},{"line_number":52,"context_line":"        help\u003d\"Vnic type used for binding\","},{"line_number":53,"context_line":"        choices\u003d[\u0027baremetal\u0027, \u0027normal\u0027, \u0027direct\u0027,"},{"line_number":54,"context_line":"                 \u0027direct-physical\u0027, \u0027macvtap\u0027],"},{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_e01299b3","line":52,"range":{"start_line":52,"start_character":40,"end_line":52,"end_character":41},"in_reply_to":"dab17558_d7bac722","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c66901fa12cc68f25df04d54a4715d612a24b5c7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":56,"context_line":"    cfg.IntOpt("},{"line_number":57,"context_line":"        \u0027neutron_bind_timeout\u0027,"},{"line_number":58,"context_line":"        help\u003d\"Bind timeout in seconds\","},{"line_number":59,"context_line":"        default\u003d240),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"neutron_host_id\","}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_b7b58332","line":58,"range":{"start_line":58,"start_character":37,"end_line":58,"end_character":38},"updated":"2016-05-09 03:28:12.000000000","message":"Add \u0027.\u0027 in the end.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":56,"context_line":"    cfg.IntOpt("},{"line_number":57,"context_line":"        \u0027neutron_bind_timeout\u0027,"},{"line_number":58,"context_line":"        help\u003d\"Bind timeout in seconds\","},{"line_number":59,"context_line":"        default\u003d240),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"neutron_host_id\","}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_00107da7","line":58,"range":{"start_line":58,"start_character":37,"end_line":58,"end_character":38},"in_reply_to":"dab17558_b7b58332","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d80c55e733dee3032678952fce43102ad324ea","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        default\u003d240),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"neutron_host_id\","},{"line_number":62,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set\""},{"line_number":63,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":64,"context_line":"        default\u003dNone),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_3b635e1c","line":62,"range":{"start_line":62,"start_character":71,"end_line":62,"end_character":72},"updated":"2016-05-06 19:45:22.000000000","message":"space missing","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        default\u003d240),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"neutron_host_id\","},{"line_number":62,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set\""},{"line_number":63,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":64,"context_line":"        default\u003dNone),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_e079f9fd","line":62,"range":{"start_line":62,"start_character":71,"end_line":62,"end_character":72},"in_reply_to":"dab17558_3b635e1c","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d80c55e733dee3032678952fce43102ad324ea","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        port \u003d self.neutron_api.create_port("},{"line_number":155,"context_line":"            share_network[\u0027project_id\u0027],"},{"line_number":156,"context_line":"            **create_args)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        port_dict \u003d {"},{"line_number":159,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_bb5e2e43","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":26},"updated":"2016-05-06 19:45:22.000000000","message":"nit: doesn\u0027t need to be wrapped in a separate line.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        port \u003d self.neutron_api.create_port("},{"line_number":155,"context_line":"            share_network[\u0027project_id\u0027],"},{"line_number":156,"context_line":"            **create_args)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        port_dict \u003d {"},{"line_number":159,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_4091e551","line":156,"in_reply_to":"dab17558_bb5e2e43","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d80c55e733dee3032678952fce43102ad324ea","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                \"Binding network driver configured but neutron doesn\u0027t \""},{"line_number":295,"context_line":"                \"support port binding.\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _wait_for_ports_bind(self, context, ports, share_server, timeout\u003d240):"},{"line_number":298,"context_line":"        t \u003d time.time()"},{"line_number":299,"context_line":"        inactive_ports \u003d []"},{"line_number":300,"context_line":"        while time.time() - t \u003c timeout:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_fbda7577","line":297,"range":{"start_line":297,"start_character":72,"end_line":297,"end_character":76},"updated":"2016-05-06 19:45:22.000000000","message":"needn\u0027t be a kwarg since you\u0027ve configured it","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                \"Binding network driver configured but neutron doesn\u0027t \""},{"line_number":295,"context_line":"                \"support port binding.\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _wait_for_ports_bind(self, context, ports, share_server, timeout\u003d240):"},{"line_number":298,"context_line":"        t \u003d time.time()"},{"line_number":299,"context_line":"        inactive_ports \u003d []"},{"line_number":300,"context_line":"        while time.time() - t \u003c timeout:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_8072ad47","line":297,"in_reply_to":"dab17558_fbda7577","updated":"2016-05-09 10:17:18.000000000","message":"mh, missing the context here - you are refering to timeout?","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c66901fa12cc68f25df04d54a4715d612a24b5c7","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":301,"context_line":"            all_active \u003d True"},{"line_number":302,"context_line":"            inactive_ports \u003d []"},{"line_number":303,"context_line":"            for port in ports:"},{"line_number":304,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":305,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":306,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_9c96a44a","line":303,"range":{"start_line":303,"start_character":24,"end_line":303,"end_character":29},"updated":"2016-05-09 03:28:12.000000000","message":"If ports is \u0027[]\u0027, this function will return true. It means \"Ports are bound for share server\". If ports is \u0027[]\u0027, Does we need to raise code line 320 error?","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":301,"context_line":"            all_active \u003d True"},{"line_number":302,"context_line":"            inactive_ports \u003d []"},{"line_number":303,"context_line":"            for port in ports:"},{"line_number":304,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":305,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":306,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_c0e035cf","line":303,"in_reply_to":"dab17558_9c96a44a","updated":"2016-05-09 10:17:18.000000000","message":"I mean in theory a driver could return a allocation_number of 0. This would mean no port needs to be created. So I would say this is fine.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c66901fa12cc68f25df04d54a4715d612a24b5c7","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":306,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":307,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":308,"context_line":"                    msg \u003d _(\"Port %s is in state error\") % port[\u0027id\u0027]"},{"line_number":309,"context_line":"                    raise exception.ManilaException(msg)"},{"line_number":310,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":311,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_f79eebb6","line":308,"range":{"start_line":308,"start_character":29,"end_line":308,"end_character":54},"updated":"2016-05-09 03:28:12.000000000","message":"Port %s is in state error or VIF binding failed?","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":306,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":307,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":308,"context_line":"                    msg \u003d _(\"Port %s is in state error\") % port[\u0027id\u0027]"},{"line_number":309,"context_line":"                    raise exception.ManilaException(msg)"},{"line_number":310,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":311,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_00eb5db1","line":308,"in_reply_to":"dab17558_f79eebb6","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c66901fa12cc68f25df04d54a4715d612a24b5c7","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":311,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":312,"context_line":"                              \"Wait for active state.\","},{"line_number":313,"context_line":"                              dict(id\u003dport[\u0027id\u0027],"},{"line_number":314,"context_line":"                                   state\u003dport[\u0027status\u0027]))"},{"line_number":315,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":316,"context_line":"                    all_active \u003d False"},{"line_number":317,"context_line":"            if all_active:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_dcdcac14","line":314,"range":{"start_line":313,"start_character":0,"end_line":314,"end_character":57},"updated":"2016-05-09 03:28:12.000000000","message":"This could be on line.","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c90d885af9ed69b1b495765f7c0883937ae792e1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":312,"context_line":"                              \"Wait for active state.\","},{"line_number":313,"context_line":"                              dict(id\u003dport[\u0027id\u0027],"},{"line_number":314,"context_line":"                                   state\u003dport[\u0027status\u0027]))"},{"line_number":315,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":316,"context_line":"                    all_active \u003d False"},{"line_number":317,"context_line":"            if all_active:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_80ee2db2","line":314,"in_reply_to":"dab17558_dcdcac14","updated":"2016-05-09 10:17:18.000000000","message":"Done","commit_id":"079da6b41b1d72c9f656887bc8b6d16d18ea1f3d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d9da00df90e64ec75f3464ca88872fd9c50dc806","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        t \u003d time.time()"},{"line_number":298,"context_line":"        inactive_ports \u003d []"},{"line_number":299,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":300,"context_line":"            all_active \u003d True"},{"line_number":301,"context_line":"            inactive_ports \u003d []"},{"line_number":302,"context_line":"            for port in ports:"},{"line_number":303,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_3359e28f","line":300,"updated":"2016-05-12 12:55:12.000000000","message":"all_active not needed. you can use len(incative_ports)","commit_id":"de3946558b5e4ebd68d3f396c954057d03377f36"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2167345e97fa5aa2211144d94aa925663d61fd12","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        t \u003d time.time()"},{"line_number":298,"context_line":"        inactive_ports \u003d []"},{"line_number":299,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":300,"context_line":"            all_active \u003d True"},{"line_number":301,"context_line":"            inactive_ports \u003d []"},{"line_number":302,"context_line":"            for port in ports:"},{"line_number":303,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_65e44c3b","line":300,"in_reply_to":"dab17558_3359e28f","updated":"2016-05-18 06:42:05.000000000","message":"Done","commit_id":"de3946558b5e4ebd68d3f396c954057d03377f36"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d9da00df90e64ec75f3464ca88872fd9c50dc806","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                              dict(id\u003dport[\u0027id\u0027], state\u003dport[\u0027status\u0027]))"},{"line_number":313,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":314,"context_line":"                    all_active \u003d False"},{"line_number":315,"context_line":"            if all_active:"},{"line_number":316,"context_line":"                return"},{"line_number":317,"context_line":"            time.sleep(1)"},{"line_number":318,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_53d746bf","line":315,"updated":"2016-05-12 12:55:12.000000000","message":"if len(inactive_ports) \u003d\u003d 0:","commit_id":"de3946558b5e4ebd68d3f396c954057d03377f36"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2167345e97fa5aa2211144d94aa925663d61fd12","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                              dict(id\u003dport[\u0027id\u0027], state\u003dport[\u0027status\u0027]))"},{"line_number":313,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":314,"context_line":"                    all_active \u003d False"},{"line_number":315,"context_line":"            if all_active:"},{"line_number":316,"context_line":"                return"},{"line_number":317,"context_line":"            time.sleep(1)"},{"line_number":318,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_a5d47447","line":315,"in_reply_to":"dab17558_53d746bf","updated":"2016-05-18 06:42:05.000000000","message":"Done","commit_id":"de3946558b5e4ebd68d3f396c954057d03377f36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":313,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":314,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":315,"context_line":"                    raise exception.ManilaException(msg)"},{"line_number":316,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":317,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":318,"context_line":"                              \"Wait for active state.\","}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_127d3e1c","line":315,"range":{"start_line":315,"start_character":36,"end_line":315,"end_character":51},"updated":"2016-06-17 15:10:12.000000000","message":"Please, use more specific exception here.\n\nhttps://github.com/openstack/manila/blob/94e04c8d/manila/exception.py#L113 ?\nor define new one...","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":313,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":314,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":315,"context_line":"                    raise exception.ManilaException(msg)"},{"line_number":316,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":317,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":318,"context_line":"                              \"Wait for active state.\","}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_bbe5a9a9","line":315,"range":{"start_line":315,"start_character":36,"end_line":315,"end_character":51},"in_reply_to":"7aa08908_127d3e1c","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":317,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":318,"context_line":"                              \"Wait for active state.\","},{"line_number":319,"context_line":"                              dict(id\u003dport[\u0027id\u0027], state\u003dport[\u0027status\u0027]))"},{"line_number":320,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":321,"context_line":"                    all_active \u003d False"},{"line_number":322,"context_line":"            if all_active:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_b2e8aab4","line":319,"range":{"start_line":319,"start_character":30,"end_line":319,"end_character":71},"updated":"2016-06-17 15:10:12.000000000","message":"Please, use dict comprehensions instead of dict classes.\n\nSee https://www.python.org/dev/peps/pep-0274/","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":317,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":318,"context_line":"                              \"Wait for active state.\","},{"line_number":319,"context_line":"                              dict(id\u003dport[\u0027id\u0027], state\u003dport[\u0027status\u0027]))"},{"line_number":320,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":321,"context_line":"                    all_active \u003d False"},{"line_number":322,"context_line":"            if all_active:"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_9be26d9e","line":319,"range":{"start_line":319,"start_character":30,"end_line":319,"end_character":71},"in_reply_to":"7aa08908_b2e8aab4","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                return"},{"line_number":324,"context_line":"            time.sleep(1)"},{"line_number":325,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""},{"line_number":326,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % dict("},{"line_number":327,"context_line":"            s_id\u003dshare_server[\u0027id\u0027], ports\u003dinactive_ports)"},{"line_number":328,"context_line":"        raise exception.ManilaException(msg)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_d231f65a","line":327,"range":{"start_line":326,"start_character":60,"end_line":327,"end_character":58},"updated":"2016-06-17 15:10:12.000000000","message":"Same here.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                return"},{"line_number":324,"context_line":"            time.sleep(1)"},{"line_number":325,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""},{"line_number":326,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % dict("},{"line_number":327,"context_line":"            s_id\u003dshare_server[\u0027id\u0027], ports\u003dinactive_ports)"},{"line_number":328,"context_line":"        raise exception.ManilaException(msg)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_dbf2356f","line":327,"range":{"start_line":326,"start_character":60,"end_line":327,"end_character":58},"in_reply_to":"7aa08908_d231f65a","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"},{"line_number":331,"context_line":"                              device_owner):"},{"line_number":332,"context_line":"        args \u003d super(NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":333,"context_line":"            context, share_network, share_network, device_owner)"},{"line_number":334,"context_line":"        if self.config.neutron_host_id:"},{"line_number":335,"context_line":"            args[\u0027host_id\u0027] \u003d self.config.neutron_host_id"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_92180e86","line":332,"range":{"start_line":332,"start_character":8,"end_line":332,"end_character":12},"updated":"2016-06-17 15:10:12.000000000","message":"Please, do not use args. It overlaps with pdb built-in name and common name for tuple of positional arguments of some python function.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"},{"line_number":331,"context_line":"                              device_owner):"},{"line_number":332,"context_line":"        args \u003d super(NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":333,"context_line":"            context, share_network, share_network, device_owner)"},{"line_number":334,"context_line":"        if self.config.neutron_host_id:"},{"line_number":335,"context_line":"            args[\u0027host_id\u0027] \u003d self.config.neutron_host_id"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_3bb6d98a","line":332,"range":{"start_line":332,"start_character":8,"end_line":332,"end_character":12},"in_reply_to":"7aa08908_92180e86","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"},{"line_number":331,"context_line":"                              device_owner):"},{"line_number":332,"context_line":"        args \u003d super(NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":333,"context_line":"            context, share_network, share_network, device_owner)"},{"line_number":334,"context_line":"        if self.config.neutron_host_id:"},{"line_number":335,"context_line":"            args[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":336,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_727e42e5","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":20},"updated":"2016-06-17 15:10:12.000000000","message":"This \"context\" arg is not used neither in parent nor here.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    def _get_port_create_args(self, context, share_server, share_network,"},{"line_number":331,"context_line":"                              device_owner):"},{"line_number":332,"context_line":"        args \u003d super(NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":333,"context_line":"            context, share_network, share_network, device_owner)"},{"line_number":334,"context_line":"        if self.config.neutron_host_id:"},{"line_number":335,"context_line":"            args[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":336,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_fb629115","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":20},"in_reply_to":"7aa08908_727e42e5","updated":"2016-06-20 09:39:50.000000000","message":"Done","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        return ports"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"class NeutronBindSingleNetworkPlugin(NeutronSingleNetworkPlugin,"},{"line_number":359,"context_line":"                                     NeutronBindNetworkPlugin):"},{"line_number":360,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_f5221cb8","line":360,"range":{"start_line":358,"start_character":0,"end_line":360,"end_character":8},"updated":"2016-06-17 15:10:12.000000000","message":"Marc, have you tested this class? \n\nI am asking because having multi-inheritance and method name overlapping you get here \"allocate_network\" from only one of parents. So, code from lines 344-355 is not running in NeutronBindSingleNetworkPlugin.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2ed5ca3714d0a85ac1b4a9277772d3c61cdb4e60","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        return ports"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"class NeutronBindSingleNetworkPlugin(NeutronSingleNetworkPlugin,"},{"line_number":359,"context_line":"                                     NeutronBindNetworkPlugin):"},{"line_number":360,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_a4d8e61e","line":360,"range":{"start_line":358,"start_character":0,"end_line":360,"end_character":8},"in_reply_to":"7aa08908_f5221cb8","updated":"2016-06-20 09:39:50.000000000","message":"Basically it works fine. For allocate_network the call structure is like that:\n1. NeutronSingleNetwork.allocate_network()\n2. NeutronBindNetwork.allocate_network()\n3. NeutronNetwork.allocate_network()\n\nL344 - 355 is called.\nI added unit tests that proofs it.","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"neutron_host_id\","},{"line_number":62,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":63,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":64,"context_line":"        default\u003dNone),"},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_069550e3","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":20},"updated":"2016-07-25 13:44:38.000000000","message":"default\u003dsocket.gethostname()","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"neutron_host_id\","},{"line_number":62,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":63,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":64,"context_line":"        default\u003dNone),"},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_6decbf8f","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":20},"in_reply_to":"dada55a8_069550e3","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            \"network_id\": share_network[\u0027neutron_net_id\u0027],"},{"line_number":145,"context_line":"            \"subnet_id\": share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":146,"context_line":"            \"device_owner\": \u0027manila:\u0027 + device_owner,"},{"line_number":147,"context_line":"            \"device_id\": share_server.get(\u0027id\u0027, None)"},{"line_number":148,"context_line":"        }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _create_port(self, context, share_server, share_network, device_owner):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_e6975ce9","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":53},"updated":"2016-07-25 13:44:38.000000000","message":"add trailing comma","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            \"network_id\": share_network[\u0027neutron_net_id\u0027],"},{"line_number":145,"context_line":"            \"subnet_id\": share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":146,"context_line":"            \"device_owner\": \u0027manila:\u0027 + device_owner,"},{"line_number":147,"context_line":"            \"device_id\": share_server.get(\u0027id\u0027, None)"},{"line_number":148,"context_line":"        }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _create_port(self, context, share_server, share_network, device_owner):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_adfeb735","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":53},"in_reply_to":"dada55a8_e6975ce9","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            self._wait_for_ports_bind(ports, share_server,"},{"line_number":301,"context_line":"                                      self.config.neutron_bind_timeout)"},{"line_number":302,"context_line":"            return ports"},{"line_number":303,"context_line":"        return None"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _wait_for_ports_bind(self, ports, share_server, timeout\u003d240):"},{"line_number":306,"context_line":"        t \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_26b9747a","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":19},"updated":"2016-07-25 13:44:38.000000000","message":"redundant...","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            self._wait_for_ports_bind(ports, share_server,"},{"line_number":301,"context_line":"                                      self.config.neutron_bind_timeout)"},{"line_number":302,"context_line":"            return ports"},{"line_number":303,"context_line":"        return None"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _wait_for_ports_bind(self, ports, share_server, timeout\u003d240):"},{"line_number":306,"context_line":"        t \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_0dfee336","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":19},"in_reply_to":"dada55a8_26b9747a","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            inactive_ports \u003d []"},{"line_number":310,"context_line":"            for port in ports:"},{"line_number":311,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":312,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":313,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_868940cd","line":312,"range":{"start_line":312,"start_character":38,"end_line":312,"end_character":45},"updated":"2016-07-25 13:44:38.000000000","message":"suggestion: needs to be in constants file.. \n\nconstants.NEUTRON_PORT_STATUS_ERROR?","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            inactive_ports \u003d []"},{"line_number":310,"context_line":"            for port in ports:"},{"line_number":311,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":312,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":313,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_4d961bf1","line":312,"range":{"start_line":312,"start_character":38,"end_line":312,"end_character":45},"in_reply_to":"dada55a8_868940cd","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":312,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":313,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_86b0208d","line":314,"range":{"start_line":314,"start_character":53,"end_line":314,"end_character":69},"updated":"2016-07-25 13:44:38.000000000","message":"same","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":312,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027 or"},{"line_number":313,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_8da01345","line":314,"range":{"start_line":314,"start_character":53,"end_line":314,"end_character":69},"in_reply_to":"dada55a8_86b0208d","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":318,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":319,"context_line":"                              \"Wait for active state.\", {"},{"line_number":320,"context_line":"                                  \"id\": port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_66840cb1","line":317,"range":{"start_line":317,"start_character":40,"end_line":317,"end_character":46},"updated":"2016-07-25 13:44:38.000000000","message":"same","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d \u0027binding_failed\u0027)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":318,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":319,"context_line":"                              \"Wait for active state.\", {"},{"line_number":320,"context_line":"                                  \"id\": port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_cd8a0bbf","line":317,"range":{"start_line":317,"start_character":40,"end_line":317,"end_character":46},"in_reply_to":"dada55a8_66840cb1","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            if len(inactive_ports) \u003d\u003d 0:"},{"line_number":324,"context_line":"                return"},{"line_number":325,"context_line":"            time.sleep(1)"},{"line_number":326,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""},{"line_number":327,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % {"},{"line_number":328,"context_line":"            \"s_id\": share_server[\u0027id\u0027],"},{"line_number":329,"context_line":"            \"ports\": inactive_ports}"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_06bc306b","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":43},"updated":"2016-07-25 13:44:38.000000000","message":"within","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            if len(inactive_ports) \u003d\u003d 0:"},{"line_number":324,"context_line":"                return"},{"line_number":325,"context_line":"            time.sleep(1)"},{"line_number":326,"context_line":"        msg \u003d _(\"Ports are not bound during timeout for share server \""},{"line_number":327,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % {"},{"line_number":328,"context_line":"            \"s_id\": share_server[\u0027id\u0027],"},{"line_number":329,"context_line":"            \"ports\": inactive_ports}"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_4dbd7b67","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":43},"in_reply_to":"dada55a8_06bc306b","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        arguments \u003d super("},{"line_number":335,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":336,"context_line":"                share_network, share_network, device_owner)"},{"line_number":337,"context_line":"        if self.config.neutron_host_id:"},{"line_number":338,"context_line":"            arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            arguments[\u0027host_id\u0027] \u003d socket.gethostname()"},{"line_number":341,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":342,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":343,"context_line":"        return arguments"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_974e79bf","line":340,"range":{"start_line":337,"start_character":0,"end_line":340,"end_character":55},"updated":"2016-07-25 13:44:38.000000000","message":"this can be simplified by the default arg suggested in the config section..","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        arguments \u003d super("},{"line_number":335,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":336,"context_line":"                share_network, share_network, device_owner)"},{"line_number":337,"context_line":"        if self.config.neutron_host_id:"},{"line_number":338,"context_line":"            arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            arguments[\u0027host_id\u0027] \u003d socket.gethostname()"},{"line_number":341,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":342,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":343,"context_line":"        return arguments"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_2dc007e0","line":340,"range":{"start_line":337,"start_character":0,"end_line":340,"end_character":55},"in_reply_to":"dada55a8_974e79bf","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51da38addeeef437f521a6de37f2aca35ada806a","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            return ports"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _wait_for_ports_bind(self, ports, share_server, timeout\u003d240):"},{"line_number":305,"context_line":"        t \u003d time.time()"},{"line_number":306,"context_line":"        inactive_ports \u003d []"},{"line_number":307,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":308,"context_line":"            inactive_ports \u003d []"},{"line_number":309,"context_line":"            for port in ports:"},{"line_number":310,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":311,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d neutron_constants.PORT_STATUS_ERROR or"},{"line_number":312,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":313,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d"},{"line_number":314,"context_line":"                         neutron_constants.VIF_TYPE_BINDING_FAILED)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d neutron_constants.PORT_STATUS_ACTIVE:"},{"line_number":318,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":319,"context_line":"                              \"Wait for active state.\", {"},{"line_number":320,"context_line":"                                  \"id\": port[\u0027id\u0027],"},{"line_number":321,"context_line":"                                  \"state:\": port[\u0027status\u0027]})"},{"line_number":322,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":323,"context_line":"            if len(inactive_ports) \u003d\u003d 0:"},{"line_number":324,"context_line":"                return"},{"line_number":325,"context_line":"            time.sleep(1)"},{"line_number":326,"context_line":"        msg \u003d _(\"Ports are not bound within timeout for share server \""},{"line_number":327,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % {"},{"line_number":328,"context_line":"            \"s_id\": share_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_6ffe3eaf","line":325,"range":{"start_line":305,"start_character":7,"end_line":325,"end_character":25},"updated":"2016-07-31 19:54:09.000000000","message":"You should re-use the retry method in manila/utils.. the retry logic is identical.. \n\nhttps://github.com/openstack/manila/blob/cd698f2/manila/utils.py#L549","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2b7c8988b30ed9f496434ec8302c0a32452fc603","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            return ports"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _wait_for_ports_bind(self, ports, share_server, timeout\u003d240):"},{"line_number":305,"context_line":"        t \u003d time.time()"},{"line_number":306,"context_line":"        inactive_ports \u003d []"},{"line_number":307,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":308,"context_line":"            inactive_ports \u003d []"},{"line_number":309,"context_line":"            for port in ports:"},{"line_number":310,"context_line":"                port \u003d self._neutron_api.show_port(port[\u0027id\u0027])"},{"line_number":311,"context_line":"                if (port[\u0027status\u0027] \u003d\u003d neutron_constants.PORT_STATUS_ERROR or"},{"line_number":312,"context_line":"                        (\u0027binding:vif_type\u0027 in port and"},{"line_number":313,"context_line":"                         port[\u0027binding:vif_type\u0027] \u003d\u003d"},{"line_number":314,"context_line":"                         neutron_constants.VIF_TYPE_BINDING_FAILED)):"},{"line_number":315,"context_line":"                    msg \u003d _(\"Port binding %s failed.\") % port[\u0027id\u0027]"},{"line_number":316,"context_line":"                    raise exception.NetworkException(msg)"},{"line_number":317,"context_line":"                elif port[\u0027status\u0027] !\u003d neutron_constants.PORT_STATUS_ACTIVE:"},{"line_number":318,"context_line":"                    LOG.debug(\"The port %(id)s is in state %(state)s. \""},{"line_number":319,"context_line":"                              \"Wait for active state.\", {"},{"line_number":320,"context_line":"                                  \"id\": port[\u0027id\u0027],"},{"line_number":321,"context_line":"                                  \"state:\": port[\u0027status\u0027]})"},{"line_number":322,"context_line":"                    inactive_ports.append(port[\u0027id\u0027])"},{"line_number":323,"context_line":"            if len(inactive_ports) \u003d\u003d 0:"},{"line_number":324,"context_line":"                return"},{"line_number":325,"context_line":"            time.sleep(1)"},{"line_number":326,"context_line":"        msg \u003d _(\"Ports are not bound within timeout for share server \""},{"line_number":327,"context_line":"                \"\u0027%(s_id)s\u0027 (inactive ports: %(ports)s)\") % {"},{"line_number":328,"context_line":"            \"s_id\": share_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_c66d7ecd","line":325,"range":{"start_line":305,"start_character":7,"end_line":325,"end_character":25},"in_reply_to":"bacf61ea_6ffe3eaf","updated":"2016-08-01 11:34:26.000000000","message":"Done","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51da38addeeef437f521a6de37f2aca35ada806a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":336,"context_line":"                share_network, share_network, device_owner)"},{"line_number":337,"context_line":"        arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":338,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":339,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":340,"context_line":"        return arguments"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_cfbbeae3","line":339,"range":{"start_line":338,"start_character":41,"end_line":339,"end_character":42},"updated":"2016-07-31 19:54:09.000000000","message":"can fit within previous line.","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2b7c8988b30ed9f496434ec8302c0a32452fc603","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":336,"context_line":"                share_network, share_network, device_owner)"},{"line_number":337,"context_line":"        arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":338,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":339,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":340,"context_line":"        return arguments"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_da60bfd1","line":339,"range":{"start_line":338,"start_character":41,"end_line":339,"end_character":42},"in_reply_to":"bacf61ea_cfbbeae3","updated":"2016-08-01 11:34:26.000000000","message":"Done","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51da38addeeef437f521a6de37f2aca35ada806a","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"},{"line_number":343,"context_line":"                         **kwargs):"},{"line_number":344,"context_line":"        ports \u003d super(NeutronBindNetworkPlugin, self).allocate_network("},{"line_number":345,"context_line":"            context, share_server, share_network, **kwargs)"},{"line_number":346,"context_line":"        # If vnic type is \u0027normal\u0027 we expect a neutron agent to bind the"},{"line_number":347,"context_line":"        # ports. This action requires a vnic to be spawned by the driver."},{"line_number":348,"context_line":"        # Therefore we do not wait for the port binding here, but"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_6f9abe6f","line":345,"range":{"start_line":345,"start_character":0,"end_line":345,"end_character":59},"updated":"2016-07-31 19:54:09.000000000","message":"Should you be checking if the binding extension is available in the cloud; something along the lines of:\n\n        if not self._has_port_binding_extension():\n            msg \u003d \"%s extension required\" % neutron_constants.PORTBINDING_EXT\n            raise exception.NetworkBadConfigurationException(reason\u003dmsg)","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2b7c8988b30ed9f496434ec8302c0a32452fc603","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"},{"line_number":343,"context_line":"                         **kwargs):"},{"line_number":344,"context_line":"        ports \u003d super(NeutronBindNetworkPlugin, self).allocate_network("},{"line_number":345,"context_line":"            context, share_server, share_network, **kwargs)"},{"line_number":346,"context_line":"        # If vnic type is \u0027normal\u0027 we expect a neutron agent to bind the"},{"line_number":347,"context_line":"        # ports. This action requires a vnic to be spawned by the driver."},{"line_number":348,"context_line":"        # Therefore we do not wait for the port binding here, but"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_da49df61","line":345,"range":{"start_line":345,"start_character":0,"end_line":345,"end_character":59},"in_reply_to":"bacf61ea_6f9abe6f","updated":"2016-08-01 11:34:26.000000000","message":"I would say this should be checked on API level if host_id is given. Fixed here:\nhttps://review.openstack.org/#/c/341327/","commit_id":"61efc45d34c5c85b327b009d7befdf39105c8059"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \"neutron_host_id\","},{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_cbcb22a4","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":21},"updated":"2016-08-16 16:04:02.000000000","message":"ID","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        default\u003d\u0027baremetal\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \"neutron_host_id\","},{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_2f33c2f7","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":21},"in_reply_to":"3ac371cc_cbcb22a4","updated":"2016-08-17 12:57:09.000000000","message":"Done","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_06740f66","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":36},"updated":"2016-08-16 16:04:02.000000000","message":"does this mean that these opts can be part of the [neutron] group?","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b731e9cf36dfdba3cf25e6680c557c882c062c65","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_e10f1d2c","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":36},"in_reply_to":"3ac371cc_06740f66","updated":"2016-08-16 16:12:59.000000000","message":"No all neutron related opts are part of the backend group or you specify network_config_group/admin_network_config_group.","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_cf394ed9","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":36},"in_reply_to":"3ac371cc_dc6e4695","updated":"2016-08-17 12:57:09.000000000","message":"Done","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a01336de5bff794ad26efebfe7f73a1829b1d45f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Host id to be used when creating neutron port. If not set \""},{"line_number":58,"context_line":"             \"host is set to manila-share host by default.\","},{"line_number":59,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":60,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_dc6e4695","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":36},"in_reply_to":"3ac371cc_e10f1d2c","updated":"2016-08-16 16:27:28.000000000","message":"My question is wrt to \u0027deprecated_group\u0027.. it\u0027s a new opt as we discussed on the channel, why a deprecated group.","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":288,"context_line":"        CONF.register_opts("},{"line_number":289,"context_line":"            neutron_bind_network_plugin_opts,"},{"line_number":290,"context_line":"            group\u003dself.neutron_api.config_group_name)"},{"line_number":291,"context_line":"        self.config \u003d self.neutron_api.configuration"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def update_network_allocation(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_86a2bfac","line":290,"range":{"start_line":290,"start_character":18,"end_line":290,"end_character":52},"updated":"2016-08-16 16:04:02.000000000","message":"looks like we want them to be part of [neutron] config group.. Should we move them in the opt.py like this: https://review.openstack.org/#/c/355517","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a01336de5bff794ad26efebfe7f73a1829b1d45f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":288,"context_line":"        CONF.register_opts("},{"line_number":289,"context_line":"            neutron_bind_network_plugin_opts,"},{"line_number":290,"context_line":"            group\u003dself.neutron_api.config_group_name)"},{"line_number":291,"context_line":"        self.config \u003d self.neutron_api.configuration"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def update_network_allocation(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_fc3b42cf","line":290,"range":{"start_line":290,"start_character":18,"end_line":290,"end_character":52},"in_reply_to":"3ac371cc_0174f965","updated":"2016-08-16 16:27:28.000000000","message":"Sorry, i didn\u0027t understand that thoroughly.. got it now.","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b731e9cf36dfdba3cf25e6680c557c882c062c65","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        super(NeutronBindNetworkPlugin, self).__init__(*args, **kwargs)"},{"line_number":288,"context_line":"        CONF.register_opts("},{"line_number":289,"context_line":"            neutron_bind_network_plugin_opts,"},{"line_number":290,"context_line":"            group\u003dself.neutron_api.config_group_name)"},{"line_number":291,"context_line":"        self.config \u003d self.neutron_api.configuration"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def update_network_allocation(self, context, share_server):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_0174f965","line":290,"range":{"start_line":290,"start_character":18,"end_line":290,"end_character":52},"in_reply_to":"3ac371cc_86a2bfac","updated":"2016-08-16 16:12:59.000000000","message":"no there aren\u0027t part of the neutron group. the network driver opts should be backend specific (e.g. docker driver needs different settings than netapp driver..)","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":330,"context_line":"                share_network, share_network, device_owner)"},{"line_number":331,"context_line":"        arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":332,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":333,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":334,"context_line":"        return arguments"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_eb789e2d","line":333,"range":{"start_line":332,"start_character":41,"end_line":333,"end_character":42},"updated":"2016-08-16 16:04:02.000000000","message":"nit: fits in one line..","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            NeutronBindNetworkPlugin, self)._get_port_create_args("},{"line_number":330,"context_line":"                share_network, share_network, device_owner)"},{"line_number":331,"context_line":"        arguments[\u0027host_id\u0027] \u003d self.config.neutron_host_id"},{"line_number":332,"context_line":"        arguments[\u0027binding:vnic_type\u0027] \u003d ("},{"line_number":333,"context_line":"            self.config.neutron_vnic_type)"},{"line_number":334,"context_line":"        return arguments"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def allocate_network(self, context, share_server, share_network\u003dNone,"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_5815113e","line":333,"range":{"start_line":332,"start_character":41,"end_line":333,"end_character":42},"in_reply_to":"3ac371cc_eb789e2d","updated":"2016-08-17 12:57:09.000000000","message":"Done","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29b7c2234a2e6ec1c11b06c2b8974163928ae591","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return ports"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"class NeutronBindSingleNetworkPlugin(NeutronSingleNetworkPlugin,"},{"line_number":352,"context_line":"                                     NeutronBindNetworkPlugin):"},{"line_number":353,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_6b35cef5","line":352,"range":{"start_line":351,"start_character":0,"end_line":352,"end_character":63},"updated":"2016-08-16 16:04:02.000000000","message":"The allocate_network method in the SingleNetworkPlugin doesn\u0027t return ports... so, this plugin may not work?","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e00842714cc6b94332f540ae0f687aa0ca832989","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return ports"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"class NeutronBindSingleNetworkPlugin(NeutronSingleNetworkPlugin,"},{"line_number":352,"context_line":"                                     NeutronBindNetworkPlugin):"},{"line_number":353,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"3ac371cc_584d113d","line":352,"range":{"start_line":351,"start_character":0,"end_line":352,"end_character":63},"in_reply_to":"3ac371cc_6b35cef5","updated":"2016-08-17 12:57:09.000000000","message":"the driver/manager doesn\u0027t use the return value. It retrieves it from the DB (manila/share/manager.py:2346). I just tested it again and it works. The current docker driver doesn\u0027t support admin networks. But I think this part would be good for a rework later.","commit_id":"1c3dbea9b97979caa905431afaa2ac47ef7827eb"}],"manila/share/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def get_admin_network_allocations_number(self):"},{"line_number":563,"context_line":"        return 0"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def update_network_allocation(self, context, share_server, **kwargs):"},{"line_number":566,"context_line":"        \"\"\"Update network allocation after share server creation.\"\"\""},{"line_number":567,"context_line":"        self.network_api.update_network_allocation(context, share_server)"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_97aaf917","line":565,"range":{"start_line":565,"start_character":65,"end_line":565,"end_character":71},"updated":"2016-07-25 13:44:38.000000000","message":"?","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def get_admin_network_allocations_number(self):"},{"line_number":563,"context_line":"        return 0"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def update_network_allocation(self, context, share_server, **kwargs):"},{"line_number":566,"context_line":"        \"\"\"Update network allocation after share server creation.\"\"\""},{"line_number":567,"context_line":"        self.network_api.update_network_allocation(context, share_server)"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_8db77385","line":565,"range":{"start_line":565,"start_character":65,"end_line":565,"end_character":71},"in_reply_to":"dada55a8_97aaf917","updated":"2016-07-29 13:49:43.000000000","message":"Removed","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        \"\"\"Update network allocation after share server creation.\"\"\""},{"line_number":567,"context_line":"        self.network_api.update_network_allocation(context, share_server)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def update_admin_network_allocation(self, context, share_server, **kwargs):"},{"line_number":570,"context_line":"        \"\"\"Update admin network allocation after share server creation.\"\"\""},{"line_number":571,"context_line":"        if (self.get_admin_network_allocations_number() and"},{"line_number":572,"context_line":"                self.admin_network_api):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_d7bbd173","line":569,"range":{"start_line":569,"start_character":69,"end_line":569,"end_character":78},"updated":"2016-07-25 13:44:38.000000000","message":"?","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        \"\"\"Update network allocation after share server creation.\"\"\""},{"line_number":567,"context_line":"        self.network_api.update_network_allocation(context, share_server)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def update_admin_network_allocation(self, context, share_server, **kwargs):"},{"line_number":570,"context_line":"        \"\"\"Update admin network allocation after share server creation.\"\"\""},{"line_number":571,"context_line":"        if (self.get_admin_network_allocations_number() and"},{"line_number":572,"context_line":"                self.admin_network_api):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_cdb16b91","line":569,"range":{"start_line":569,"start_character":69,"end_line":569,"end_character":78},"in_reply_to":"dada55a8_d7bbd173","updated":"2016-07-29 13:49:43.000000000","message":"Removed","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"}],"manila/tests/network/neutron/test_neutron_api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0f7e3ea0bacde71976c005a12d21a7e32d21eff","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # instantiate Neutron API object"},{"line_number":108,"context_line":"        obj \u003d neutron_api.API(fake_config_group_name)"},{"line_number":109,"context_line":"        obj.get_client(mock.Mock())"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Verify results"},{"line_number":112,"context_line":"        self.assertTrue(clientv20.Client.called)"},{"line_number":113,"context_line":"        self.assertTrue(hasattr(obj, \u0027client\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_5918e384","line":110,"updated":"2016-03-21 14:09:12.000000000","message":"No test coverage for possibility to provide kwargs.","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"de95eaa7ca358978bcea2a7e3057bd7c9bc1fc30","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # instantiate Neutron API object"},{"line_number":108,"context_line":"        obj \u003d neutron_api.API(fake_config_group_name)"},{"line_number":109,"context_line":"        obj.get_client(mock.Mock())"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Verify results"},{"line_number":112,"context_line":"        self.assertTrue(clientv20.Client.called)"},{"line_number":113,"context_line":"        self.assertTrue(hasattr(obj, \u0027client\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_a5caac9f","line":110,"in_reply_to":"fa0719c6_5918e384","updated":"2016-03-21 14:50:47.000000000","message":"ok I will add that later","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b79e72fcd9b424083b8b1af8af5b223190e3282f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # instantiate Neutron API object"},{"line_number":108,"context_line":"        obj \u003d neutron_api.API(fake_config_group_name)"},{"line_number":109,"context_line":"        obj.get_client(mock.Mock())"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Verify results"},{"line_number":112,"context_line":"        self.assertTrue(clientv20.Client.called)"},{"line_number":113,"context_line":"        self.assertTrue(hasattr(obj, \u0027client\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_c2e32f32","line":110,"in_reply_to":"fa0719c6_a5caac9f","updated":"2016-03-22 09:24:38.000000000","message":"Done","commit_id":"c77045e7695c28a4a36220efc54213a471074d85"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19f77ce0097aa436bf4a2a4bb760a376d8cea5ff","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                fake_network_allocation)"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"class NeutronBindSingleNetworkPluginTest(NeutronBindNetworkPluginTest,"},{"line_number":595,"context_line":"                                         NeutronSingleNetworkPluginTest):"},{"line_number":596,"context_line":"    def setUp(self):"},{"line_number":597,"context_line":"        super(NeutronBindSingleNetworkPluginTest, self).setUp()"},{"line_number":598,"context_line":"        fake_net_id \u003d \u0027fake net id\u0027"},{"line_number":599,"context_line":"        fake_subnet_id \u003d \u0027fake subnet id\u0027"},{"line_number":600,"context_line":"        config_data \u003d {"},{"line_number":601,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":602,"context_line":"                \u0027neutron_net_id\u0027: fake_net_id,"},{"line_number":603,"context_line":"                \u0027neutron_subnet_id\u0027: fake_subnet_id,"},{"line_number":604,"context_line":"            }"},{"line_number":605,"context_line":"        }"},{"line_number":606,"context_line":"        fake_net \u003d {\u0027subnets\u0027: [\u0027fake1\u0027, \u0027fake2\u0027, fake_subnet_id]}"},{"line_number":607,"context_line":"        self.mock_object("},{"line_number":608,"context_line":"            neutron_api.API, \u0027get_network\u0027, mock.Mock(return_value\u003dfake_net))"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        with test_utils.create_temp_config_with_opts(config_data):"},{"line_number":611,"context_line":"            self.bind_plugin \u003d plugin.NeutronBindSingleNetworkPlugin()"},{"line_number":612,"context_line":"            self.bind_plugin.db \u003d db_api"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_809b94c8","line":612,"range":{"start_line":594,"start_character":0,"end_line":612,"end_character":40},"updated":"2016-06-17 15:10:12.000000000","message":"It does not cover case mentioned in [1].\n\nI suspect you have bug because of multi-inheritance.\n\n[1] https://review.openstack.org/#/c/283494/16/manila/network/neutron/neutron_network_plugin.py","commit_id":"63d8f3d61c34f7fb22bf16e3c2b3f6b5005ffb34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":592,"context_line":"                \u0027network_id\u0027: fake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":593,"context_line":"                \u0027subnet_id\u0027: fake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":594,"context_line":"                \u0027device_owner\u0027: \u0027manila:share\u0027,"},{"line_number":595,"context_line":"                \u0027device_id\u0027: fake_share_network[\u0027id\u0027]"},{"line_number":596,"context_line":"            }"},{"line_number":597,"context_line":"            self.bind_plugin.neutron_api.create_port.assert_called_once_with("},{"line_number":598,"context_line":"                fake_share_network[\u0027project_id\u0027], **expected_kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_173ba9ec","line":595,"range":{"start_line":595,"start_character":51,"end_line":595,"end_character":53},"updated":"2016-07-25 13:44:38.000000000","message":"trailing comma..","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":592,"context_line":"                \u0027network_id\u0027: fake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":593,"context_line":"                \u0027subnet_id\u0027: fake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":594,"context_line":"                \u0027device_owner\u0027: \u0027manila:share\u0027,"},{"line_number":595,"context_line":"                \u0027device_id\u0027: fake_share_network[\u0027id\u0027]"},{"line_number":596,"context_line":"            }"},{"line_number":597,"context_line":"            self.bind_plugin.neutron_api.create_port.assert_called_once_with("},{"line_number":598,"context_line":"                fake_share_network[\u0027project_id\u0027], **expected_kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_8dd2d3d0","line":595,"range":{"start_line":595,"start_character":51,"end_line":595,"end_character":53},"in_reply_to":"dada55a8_173ba9ec","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        super(NeutronBindNetworkPluginWithNormalTypeTest, self).setUp()"},{"line_number":630,"context_line":"        config_data \u003d {"},{"line_number":631,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":632,"context_line":"                \u0027neutron_vnic_type\u0027: \u0027normal\u0027"},{"line_number":633,"context_line":"            }"},{"line_number":634,"context_line":"        }"},{"line_number":635,"context_line":"        self.plugin \u003d plugin.NeutronNetworkPlugin()"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_37206db0","line":632,"range":{"start_line":632,"start_character":44,"end_line":632,"end_character":45},"updated":"2016-07-25 13:44:38.000000000","message":"trailing comma","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        super(NeutronBindNetworkPluginWithNormalTypeTest, self).setUp()"},{"line_number":630,"context_line":"        config_data \u003d {"},{"line_number":631,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":632,"context_line":"                \u0027neutron_vnic_type\u0027: \u0027normal\u0027"},{"line_number":633,"context_line":"            }"},{"line_number":634,"context_line":"        }"},{"line_number":635,"context_line":"        self.plugin \u003d plugin.NeutronNetworkPlugin()"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_cddccbe6","line":632,"range":{"start_line":632,"start_character":44,"end_line":632,"end_character":45},"in_reply_to":"dada55a8_37206db0","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                \u0027network_id\u0027: fake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":680,"context_line":"                \u0027subnet_id\u0027: fake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":681,"context_line":"                \u0027device_owner\u0027: \u0027manila:share\u0027,"},{"line_number":682,"context_line":"                \u0027device_id\u0027: fake_share_network[\u0027id\u0027]"},{"line_number":683,"context_line":"            }"},{"line_number":684,"context_line":"            self.bind_plugin.neutron_api.create_port.assert_called_once_with("},{"line_number":685,"context_line":"                fake_share_network[\u0027project_id\u0027], **expected_kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_772ae591","line":682,"range":{"start_line":682,"start_character":51,"end_line":682,"end_character":53},"updated":"2016-07-25 13:44:38.000000000","message":"trailing comma","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                \u0027network_id\u0027: fake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":680,"context_line":"                \u0027subnet_id\u0027: fake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":681,"context_line":"                \u0027device_owner\u0027: \u0027manila:share\u0027,"},{"line_number":682,"context_line":"                \u0027device_id\u0027: fake_share_network[\u0027id\u0027]"},{"line_number":683,"context_line":"            }"},{"line_number":684,"context_line":"            self.bind_plugin.neutron_api.create_port.assert_called_once_with("},{"line_number":685,"context_line":"                fake_share_network[\u0027project_id\u0027], **expected_kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_0de703b1","line":682,"range":{"start_line":682,"start_character":51,"end_line":682,"end_character":53},"in_reply_to":"dada55a8_772ae591","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class NeutronBindSingleNetworkPluginWithNormalTypeTest("},{"line_number":705,"context_line":"        NeutronBindNetworkPluginWithNormalTypeTest):"},{"line_number":706,"context_line":"    def setUp(self):"},{"line_number":707,"context_line":"        super(NeutronBindSingleNetworkPluginWithNormalTypeTest, self).setUp()"},{"line_number":708,"context_line":"        fake_net_id \u003d \u0027fake net id\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_d24c7f78","line":705,"range":{"start_line":705,"start_character":8,"end_line":705,"end_character":50},"updated":"2016-07-25 13:44:38.000000000","message":"We should not be subclassing tests.. this may gives us all sorts of problems when the code in the subclass starts to grow and overrides are added.. even if you were to test the same code paths, could you please expand these independently?","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"class NeutronBindSingleNetworkPluginWithNormalTypeTest("},{"line_number":705,"context_line":"        NeutronBindNetworkPluginWithNormalTypeTest):"},{"line_number":706,"context_line":"    def setUp(self):"},{"line_number":707,"context_line":"        super(NeutronBindSingleNetworkPluginWithNormalTypeTest, self).setUp()"},{"line_number":708,"context_line":"        fake_net_id \u003d \u0027fake net id\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_ede1cf9b","line":705,"range":{"start_line":705,"start_character":8,"end_line":705,"end_character":50},"in_reply_to":"dada55a8_d24c7f78","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42e9f03a416879bafc94f435e6a918f8a41c21f3","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":712,"context_line":"                \u0027neutron_net_id\u0027: fake_net_id,"},{"line_number":713,"context_line":"                \u0027neutron_subnet_id\u0027: fake_subnet_id,"},{"line_number":714,"context_line":"                \u0027neutron_vnic_type\u0027: \u0027normal\u0027"},{"line_number":715,"context_line":"            }"},{"line_number":716,"context_line":"        }"},{"line_number":717,"context_line":"        fake_net \u003d {\u0027subnets\u0027: [\u0027fake1\u0027, \u0027fake2\u0027, fake_subnet_id]}"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_d7175152","line":714,"range":{"start_line":714,"start_character":44,"end_line":714,"end_character":45},"updated":"2016-07-25 13:44:38.000000000","message":"trailing comma","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"2a447ff12dac530206cf6b2fb9f3e35b49032e3f","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":712,"context_line":"                \u0027neutron_net_id\u0027: fake_net_id,"},{"line_number":713,"context_line":"                \u0027neutron_subnet_id\u0027: fake_subnet_id,"},{"line_number":714,"context_line":"                \u0027neutron_vnic_type\u0027: \u0027normal\u0027"},{"line_number":715,"context_line":"            }"},{"line_number":716,"context_line":"        }"},{"line_number":717,"context_line":"        fake_net \u003d {\u0027subnets\u0027: [\u0027fake1\u0027, \u0027fake2\u0027, fake_subnet_id]}"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_4def3b87","line":714,"range":{"start_line":714,"start_character":44,"end_line":714,"end_character":45},"in_reply_to":"dada55a8_d7175152","updated":"2016-07-29 13:49:43.000000000","message":"Done","commit_id":"060965c6c402d3a1c5e162b0d111ac233103fd03"}]}
