)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"754487e8096d6aaec4038102c69e8ad02175b25a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add binding_profile option for backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to do port binding of physical ports it must be"},{"line_number":10,"context_line":"specified which switch and switch_port is used. It is"},{"line_number":11,"context_line":"expected for HPB that the neutron driver handles to"},{"line_number":12,"context_line":"logic of dependent core switches."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa7ab95a_f358c858","line":10,"updated":"2016-09-01 14:17:07.000000000","message":"nit: s/which switch and switch_port is used/which switch and switch_port are used","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"754487e8096d6aaec4038102c69e8ad02175b25a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to do port binding of physical ports it must be"},{"line_number":10,"context_line":"specified which switch and switch_port is used. It is"},{"line_number":11,"context_line":"expected for HPB that the neutron driver handles to"},{"line_number":12,"context_line":"logic of dependent core switches."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Daniel Gonzalez \u003cdaniel@gonzalez-nothnagel.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa7ab95a_b37720d3","line":11,"updated":"2016-09-01 14:17:07.000000000","message":"nit: s/to/the?","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"}],"manila/network/__init__.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c603b4baa8e96ef94b1f1bf6e6c17c02cc77254a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def API(config_group_name\u003dNone, label\u003d\u0027user\u0027, binding_profiles\u003dNone):"},{"line_number":39,"context_line":"    \"\"\"Selects class and config group of network plugin."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    :param config_group_name: name of config group to be used for"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_1dee568b","line":38,"range":{"start_line":38,"start_character":46,"end_line":38,"end_character":67},"updated":"2016-03-01 17:30:02.000000000","message":"It is neutron-specific. Also, addressing comments in [1] it will not be required. Because these data will be defined in neutron network plugin.\n\n[1] https://review.openstack.org/#/c/284034/2/manila/share/driver.py","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"1349566f1547bf68e3f85fa3319b33ddb2ebf893","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        default\u003d240),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \u0027switch_id\u0027,"},{"line_number":62,"context_line":"        help\u003d\"Switch ID for binding profile\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_62723fe7","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":28},"updated":"2016-03-21 17:36:43.000000000","message":"Do you want to pass the binding profile through the configuration? \nHow many such nodes do you expect to exist in the system? \nIf you make any connectivity changes, do you expect to restart the services? \nWill this scale for manila? Is this correct deployable model?","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"6dd55608ddaa6b169f32c3aa7cd6c3deffa12abf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        default\u003d240),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \u0027switch_id\u0027,"},{"line_number":62,"context_line":"        help\u003d\"Switch ID for binding profile\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_2485d0ac","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":28},"in_reply_to":"fa0719c6_62723fe7","updated":"2016-03-22 12:37:35.000000000","message":"It is correct that for each \"cabeling\" action it\u0027s needed to reconfigure manila and restart the corresponding manila-share service. For us this is acceptable since nobody should re-cable the storage on a daily basis.\n\nThere is at least one other possible ways: \n - Adding this information for each backend into the DB\nThis means: API-Impact and DB migration","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2265d40dedea4acd8f8f91728e8102830c5e8398","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \u0027switch_id\u0027,"},{"line_number":62,"context_line":"        help\u003d\"Switch ID for binding profile\"),"},{"line_number":63,"context_line":"    cfg.StrOpt("},{"line_number":64,"context_line":"        \u0027port_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_7d3cba2f","line":61,"updated":"2016-03-01 17:28:14.000000000","message":"same as in https://review.openstack.org/#/c/283494/4/manila/network/neutron/neutron_network_plugin.py\n\n\"neutron_\" prefix.","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"297a8d041173ecb9e412083d518fa8b2d8f67da8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":76,"context_line":"    cfg.StrOpt("},{"line_number":77,"context_line":"        \u0027neutron_switch_id\u0027,"},{"line_number":78,"context_line":"        help\u003d\"Switch ID for binding profile\"),"},{"line_number":79,"context_line":"    cfg.StrOpt("},{"line_number":80,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":81,"context_line":"        help\u003d\"Port ID on the given switch\",),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e2df4638","line":78,"range":{"start_line":78,"start_character":43,"end_line":78,"end_character":44},"updated":"2016-04-23 08:47:24.000000000","message":"Add a \u0027.\u0027 at the end of the help message.\nAlso, why not set a default value?","commit_id":"95221d6d1c57430afe48598fce46fa987aa97d5f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"297a8d041173ecb9e412083d518fa8b2d8f67da8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        help\u003d\"Switch ID for binding profile\"),"},{"line_number":79,"context_line":"    cfg.StrOpt("},{"line_number":80,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":81,"context_line":"        help\u003d\"Port ID on the given switch\",),"},{"line_number":82,"context_line":"    cfg.DictOpt("},{"line_number":83,"context_line":"        \u0027neutron_switch_info\u0027,"},{"line_number":84,"context_line":"        help\u003d\"Switch label\",),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_82f132d0","line":81,"range":{"start_line":81,"start_character":41,"end_line":81,"end_character":42},"updated":"2016-04-23 08:47:24.000000000","message":"Add a \u0027.\u0027 at the end of the help message.","commit_id":"95221d6d1c57430afe48598fce46fa987aa97d5f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"297a8d041173ecb9e412083d518fa8b2d8f67da8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        help\u003d\"Port ID on the given switch\",),"},{"line_number":82,"context_line":"    cfg.DictOpt("},{"line_number":83,"context_line":"        \u0027neutron_switch_info\u0027,"},{"line_number":84,"context_line":"        help\u003d\"Switch label\",),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_c2b96aee","line":84,"range":{"start_line":84,"start_character":26,"end_line":84,"end_character":28},"updated":"2016-04-23 08:47:24.000000000","message":"same above","commit_id":"95221d6d1c57430afe48598fce46fa987aa97d5f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3cffc1edf955fca26dda8c7d72c16ca67313a8e0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":82,"context_line":"    cfg.DictOpt("},{"line_number":83,"context_line":"        \u0027neutron_switch_info\u0027,"},{"line_number":84,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_22fbc1c2","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":27},"updated":"2016-05-16 13:23:57.000000000","message":"\"neutron_switch_info\" and \"switch_label\" are not identical. Please, either rename it or clarify better what should be set here.","commit_id":"4cd55cefe485a35f54ab16c9c166f95c7bb0a20a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f5c8e65428f574f583fed85ccabe8a39fd49a34f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"neutron_binding_profile \u003d ["},{"line_number":68,"context_line":"    cfg.ListOpt("},{"line_number":69,"context_line":"        \"neutron_binding_profiles\","},{"line_number":70,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":71,"context_line":"             \"action.\","},{"line_number":72,"context_line":"        default\u003dNone)"},{"line_number":73,"context_line":"    ]"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_606308b2","line":71,"range":{"start_line":70,"start_character":14,"end_line":71,"end_character":23},"updated":"2016-06-17 15:19:42.000000000","message":"Please, add some examples here. Where one should get correct values for these profiles?","commit_id":"d4e5376487e1fffea4abf4c915640889ef5a3935"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f5c8e65428f574f583fed85ccabe8a39fd49a34f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":71,"context_line":"             \"action.\","},{"line_number":72,"context_line":"        default\u003dNone)"},{"line_number":73,"context_line":"    ]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":76,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_60d5c841","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":5},"updated":"2016-06-17 15:19:42.000000000","message":"Wrong indentation.","commit_id":"d4e5376487e1fffea4abf4c915640889ef5a3935"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f5c8e65428f574f583fed85ccabe8a39fd49a34f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":81,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":82,"context_line":"    cfg.DictOpt("},{"line_number":83,"context_line":"        \u0027neutron_switch_info\u0027,"},{"line_number":84,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_40e24ca1","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":27},"updated":"2016-06-17 15:19:42.000000000","message":"More details would really help.","commit_id":"d4e5376487e1fffea4abf4c915640889ef5a3935"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ae70ad0c2f307c6ebf9d870e0a4f9f3312e76c5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"neutron_binding_profile \u003d ["},{"line_number":63,"context_line":"    cfg.ListOpt("},{"line_number":64,"context_line":"        \"neutron_binding_profiles\","},{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":66,"context_line":"             \"action.\","},{"line_number":67,"context_line":"        default\u003dNone)"},{"line_number":68,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_22bfd5aa","line":65,"range":{"start_line":65,"start_character":24,"end_line":65,"end_character":40},"updated":"2016-08-30 15:00:45.000000000","message":"need more detail here:\n\n  \"A list of binding profiles to be used during port binding. This option\n   can be used with the NeutronBindNetworkPlugin. The value for this\n   option has to be a comma separated list of names that correspond\n   to each binding profile. Each binding profile needs to be specified\n   as an individual configuration section using the binding profile name\n   as the section name.\"","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ae70ad0c2f307c6ebf9d870e0a4f9f3312e76c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"neutron_binding_profiles\","},{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":66,"context_line":"             \"action.\","},{"line_number":67,"context_line":"        default\u003dNone)"},{"line_number":68,"context_line":"    ]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"neutron_binding_profile_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_424db998","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":20},"updated":"2016-08-30 15:00:45.000000000","message":"default is already None.\n\nhttp://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.ListOpt","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ae70ad0c2f307c6ebf9d870e0a4f9f3312e76c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"neutron_binding_profiles\","},{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":66,"context_line":"             \"action.\","},{"line_number":67,"context_line":"        default\u003dNone)"},{"line_number":68,"context_line":"    ]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"neutron_binding_profile_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_828181fd","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":21},"updated":"2016-08-30 15:00:45.000000000","message":"trailing comma","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ae70ad0c2f307c6ebf9d870e0a4f9f3312e76c5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":66,"context_line":"             \"action.\","},{"line_number":67,"context_line":"        default\u003dNone)"},{"line_number":68,"context_line":"    ]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":71,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_c27f0913","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":5},"updated":"2016-08-30 15:00:45.000000000","message":"wrapping","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ae70ad0c2f307c6ebf9d870e0a4f9f3312e76c5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.StrOpt("},{"line_number":75,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":76,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":77,"context_line":"    cfg.DictOpt("},{"line_number":78,"context_line":"        \u0027neutron_switch_info\u0027,"},{"line_number":79,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_4266992a","line":79,"range":{"start_line":77,"start_character":4,"end_line":79,"end_character":31},"updated":"2016-08-30 15:00:45.000000000","message":"needs an example..","commit_id":"e92f999c2e50d412d3de1216cd013aca9b52f9e6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0eb62ef6c135bbdc4650569301bd7c504d5db5eb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        default\u003dsocket.gethostname()),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"neutron_binding_profile \u003d ["},{"line_number":63,"context_line":"    cfg.ListOpt("},{"line_number":64,"context_line":"        \"neutron_binding_profiles\","},{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to be used during port binding. This option \""},{"line_number":66,"context_line":"             \"can be used with the NeutronBindNetworkPlugin. The value for this \""},{"line_number":67,"context_line":"             \"option has to be a comma separated list of names that correspond \""},{"line_number":68,"context_line":"             \"to each binding profile. Each binding profile needs to be specified \""},{"line_number":69,"context_line":"             \"as an individual configuration section using the binding profile name \""},{"line_number":70,"context_line":"             \"as the section name.\"),"},{"line_number":71,"context_line":"]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":74,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_6e268a69","line":71,"range":{"start_line":62,"start_character":0,"end_line":71,"end_character":1},"updated":"2016-09-01 14:40:51.000000000","message":"I don\u0027t think pep8 will approve this","commit_id":"9ff644da7ae62c5f731d4959fa54546f1a040796"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"e84086067566d50b27cb1727b1bee6e95ae5ed95","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        default\u003dsocket.gethostname()),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"neutron_binding_profile \u003d ["},{"line_number":63,"context_line":"    cfg.ListOpt("},{"line_number":64,"context_line":"        \"neutron_binding_profiles\","},{"line_number":65,"context_line":"        help\u003d\"A list of binding profiles to be used during port binding. This option \""},{"line_number":66,"context_line":"             \"can be used with the NeutronBindNetworkPlugin. The value for this \""},{"line_number":67,"context_line":"             \"option has to be a comma separated list of names that correspond \""},{"line_number":68,"context_line":"             \"to each binding profile. Each binding profile needs to be specified \""},{"line_number":69,"context_line":"             \"as an individual configuration section using the binding profile name \""},{"line_number":70,"context_line":"             \"as the section name.\"),"},{"line_number":71,"context_line":"]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"neutron_binding_profile_opts \u003d ["},{"line_number":74,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_e1762b3d","line":71,"range":{"start_line":62,"start_character":0,"end_line":71,"end_character":1},"in_reply_to":"fa7ab95a_6e268a69","updated":"2016-09-01 14:55:54.000000000","message":"Done","commit_id":"9ff644da7ae62c5f731d4959fa54546f1a040796"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0eb62ef6c135bbdc4650569301bd7c504d5db5eb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":79,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":80,"context_line":"    cfg.DictOpt("},{"line_number":81,"context_line":"        \u0027neutron_switch_info. For example: \"switch_ip: 10.4.30.5\". Multiple key-value \u0027"},{"line_number":82,"context_line":"        \u0027pairs separated by commas are acceped.\u0027,"},{"line_number":83,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_6eddaa41","line":81,"range":{"start_line":81,"start_character":67,"end_line":81,"end_character":87},"updated":"2016-09-01 14:40:51.000000000","message":"same as above","commit_id":"9ff644da7ae62c5f731d4959fa54546f1a040796"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"e84086067566d50b27cb1727b1bee6e95ae5ed95","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":79,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":80,"context_line":"    cfg.DictOpt("},{"line_number":81,"context_line":"        \u0027neutron_switch_info. For example: \"switch_ip: 10.4.30.5\". Multiple key-value \u0027"},{"line_number":82,"context_line":"        \u0027pairs separated by commas are acceped.\u0027,"},{"line_number":83,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_218f3324","line":81,"range":{"start_line":81,"start_character":67,"end_line":81,"end_character":87},"in_reply_to":"fa7ab95a_6eddaa41","updated":"2016-09-01 14:55:54.000000000","message":"Done","commit_id":"9ff644da7ae62c5f731d4959fa54546f1a040796"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"19e29b6cd6ed95ad795c3dfaa58623a83abf873b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":79,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":80,"context_line":"    cfg.DictOpt("},{"line_number":81,"context_line":"        \u0027neutron_switch_info. For example: \"switch_ip: 10.4.30.5\". Multiple \u0027"},{"line_number":82,"context_line":"        \u0027key-value pairs separated by commas are acceped.\u0027,"},{"line_number":83,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_c4469520","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":31},"updated":"2016-09-01 15:17:35.000000000","message":"this is incorrect, the text is included in the config option name","commit_id":"1520dedeb7d2121c4491548442ad8258362cb2e5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"57e91e387e864780059d39c196dd5b9150be8700","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        \u0027neutron_port_id\u0027,"},{"line_number":79,"context_line":"        help\u003d\"Port ID on the given switch.\",),"},{"line_number":80,"context_line":"    cfg.DictOpt("},{"line_number":81,"context_line":"        \u0027neutron_switch_info. For example: \"switch_ip: 10.4.30.5\". Multiple \u0027"},{"line_number":82,"context_line":"        \u0027key-value pairs separated by commas are acceped.\u0027,"},{"line_number":83,"context_line":"        help\u003d\"Switch label.\",),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_ba636cdc","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":31},"in_reply_to":"fa7ab95a_c4469520","updated":"2016-09-01 15:35:32.000000000","message":"\u0027neutron_switch_info\u0027,  should be on line 81.  \"For example….\" should be added as part of the help text on line 83.","commit_id":"1520dedeb7d2121c4491548442ad8258362cb2e5"}],"manila/share/driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2265d40dedea4acd8f8f91728e8102830c5e8398","unresolved":false,"context_lines":[{"line_number":118,"context_line":"             \"group and set its name here. Used only with another \""},{"line_number":119,"context_line":"             \"option \u0027driver_handles_share_servers\u0027 set to \u0027True\u0027.\"),"},{"line_number":120,"context_line":"    cfg.ListOpt("},{"line_number":121,"context_line":"        \"binding_profiles\","},{"line_number":122,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":123,"context_line":"             \"action.\"),"},{"line_number":124,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_dddb4e1a","line":121,"updated":"2016-03-01 17:28:14.000000000","message":"Better to add \"neutron_\" prefix as it is neutron-specific. Also, we know that it is Neutron specific, then it should be in appropriate network plugins. It will not be used, for example, in StandAloneNetworkPlugin.","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2265d40dedea4acd8f8f91728e8102830c5e8398","unresolved":false,"context_lines":[{"line_number":119,"context_line":"             \"option \u0027driver_handles_share_servers\u0027 set to \u0027True\u0027.\"),"},{"line_number":120,"context_line":"    cfg.ListOpt("},{"line_number":121,"context_line":"        \"binding_profiles\","},{"line_number":122,"context_line":"        help\u003d\"A list of binding profiles to add while doing a port bind \""},{"line_number":123,"context_line":"             \"action.\"),"},{"line_number":124,"context_line":"]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_bdc12231","line":123,"range":{"start_line":122,"start_character":14,"end_line":123,"end_character":21},"updated":"2016-03-01 17:28:14.000000000","message":"Where one should get it?","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2265d40dedea4acd8f8f91728e8102830c5e8398","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                binding_profiles\u003dbinding_profiles)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"            # Enable admin network"},{"line_number":263,"context_line":"            if admin_network_config_group:"},{"line_number":264,"context_line":"                self._admin_network_api \u003d network.API("},{"line_number":265,"context_line":"                    config_group_name\u003dadmin_network_config_group,"},{"line_number":266,"context_line":"                    label\u003d\u0027admin\u0027,"},{"line_number":267,"context_line":"                    binding_profiles\u003dbinding_profiles)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        if hasattr(self, \u0027init_execute_mixin\u0027):"},{"line_number":270,"context_line":"            # Instance with \u0027ExecuteMixin\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_1db656dc","line":267,"range":{"start_line":263,"start_character":12,"end_line":267,"end_character":53},"updated":"2016-03-01 17:28:14.000000000","message":"As said in [1] - this part of code will work only with \"single_network_plugin\" type that takes info from config.\n\n[1] https://review.openstack.org/#/c/283494/4/manila/network/neutron/neutron_network_plugin.py","commit_id":"d8a173ee45b74449d95d94bad6bbac7cfb504e41"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"297a8d041173ecb9e412083d518fa8b2d8f67da8","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                       mock.Mock(return_value\u003dfake_share_network))"},{"line_number":694,"context_line":"    @mock.patch.object(db_api, \u0027share_server_get\u0027,"},{"line_number":695,"context_line":"                       mock.Mock(return_value\u003dfake_share_server))"},{"line_number":696,"context_line":"    def test__get_port_create_args(self, neutron_binding_profiles,"},{"line_number":697,"context_line":"                                   binding_profiles):"},{"line_number":698,"context_line":"        fake_device_owner \u003d \u0027share\u0027"},{"line_number":699,"context_line":"        fake_host_id \u003d \u0027fake host\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_22849eaf","line":696,"range":{"start_line":696,"start_character":12,"end_line":696,"end_character":14},"updated":"2016-04-23 08:47:24.000000000","message":"? s/__/_   :)","commit_id":"95221d6d1c57430afe48598fce46fa987aa97d5f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"297a8d041173ecb9e412083d518fa8b2d8f67da8","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                       mock.Mock(return_value\u003dfake_share_network))"},{"line_number":694,"context_line":"    @mock.patch.object(db_api, \u0027share_server_get\u0027,"},{"line_number":695,"context_line":"                       mock.Mock(return_value\u003dfake_share_server))"},{"line_number":696,"context_line":"    def test__get_port_create_args(self, neutron_binding_profiles,"},{"line_number":697,"context_line":"                                   binding_profiles):"},{"line_number":698,"context_line":"        fake_device_owner \u003d \u0027share\u0027"},{"line_number":699,"context_line":"        fake_host_id \u003d \u0027fake host\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_968b3368","line":696,"range":{"start_line":696,"start_character":3,"end_line":696,"end_character":66},"updated":"2016-04-23 08:47:24.000000000","message":"How about add test for:\n{\n        \u0027neutron_binding_profiles\u0027: \u0027fake_profile\u0027,\n        \u0027binding_profiles\u0027: None,\n}","commit_id":"95221d6d1c57430afe48598fce46fa987aa97d5f"}]}
