)]}'
{"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0153ff33faed78523bde7cb75cf7a625d20282f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            LOG.error(_LE(\u0027Invalid status of filesystem: \u0027"},{"line_number":223,"context_line":"                          \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_0f96b53e","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":23},"updated":"2016-02-29 00:20:42.000000000","message":"Use a comma here, except you need the string for the exception as well.  See next comment.","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dc30a93f3c3e36f3ccd89b3d15dcab1593d5e5f3","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            LOG.error(_LE(\u0027Invalid status of filesystem: \u0027"},{"line_number":223,"context_line":"                          \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_bb40a235","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":23},"in_reply_to":"9aed3d3a_0f96b53e","updated":"2016-02-29 07:56:18.000000000","message":"Done","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0153ff33faed78523bde7cb75cf7a625d20282f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def create_snapshot(self, snapshot, share_server\u003dNone):"},{"line_number":230,"context_line":"        \"\"\"Create a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_cf716d46","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":52},"updated":"2016-02-29 00:20:42.000000000","message":"You should send your error message to this exception.","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"866cb761c896c21abd1aea32565a88f6444eeb88","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def create_snapshot(self, snapshot, share_server\u003dNone):"},{"line_number":230,"context_line":"        \"\"\"Create a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f675e663","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":52},"in_reply_to":"9aed3d3a_11fcf870","updated":"2016-03-01 02:40:07.000000000","message":"Done","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dc30a93f3c3e36f3ccd89b3d15dcab1593d5e5f3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def create_snapshot(self, snapshot, share_server\u003dNone):"},{"line_number":230,"context_line":"        \"\"\"Create a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f87cf0b6","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":52},"in_reply_to":"9aed3d3a_cf716d46","updated":"2016-02-29 07:56:18.000000000","message":"StorageResourceException needs no parameters.\nsee https://github.com/openstack/manila/blob/master/manila/exception.py#L580","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a8ba34e8a75e5284c6516c30f575ec7203e0a02","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":225,"context_line":"                      % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":226,"context_line":"                         \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":227,"context_line":"            raise exception.StorageResourceException()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def create_snapshot(self, snapshot, share_server\u003dNone):"},{"line_number":230,"context_line":"        \"\"\"Create a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_11fcf870","line":227,"range":{"start_line":227,"start_character":28,"end_line":227,"end_character":52},"in_reply_to":"9aed3d3a_f87cf0b6","updated":"2016-02-29 15:28:31.000000000","message":"It *requires* no parameters, but because it subclasses ManilaException it *accepts* a message string.  So since you already have an error message here, please pass it to the exception.\n\nHere\u0027s a trivial experiment that shows what I\u0027m requesting:\n\n   \u003e\u003e\u003e from manila import exception\n   \u003e\u003e\u003e raise exception.StorageResourceException()\n   Traceback (most recent call last):\n     File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n   manila.exception.StorageResourceException: Storage resource exception.\n   \u003e\u003e\u003e raise exception.StorageResourceException(\"Something broke\")\n   Traceback (most recent call last):\n     File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n   manila.exception.StorageResourceException: Something broke","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d0153ff33faed78523bde7cb75cf7a625d20282f","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                except exception.ShareUmountException as err:"},{"line_number":453,"context_line":"                    LOG.warning(_LW(\u0027Failed to unmount share %(name)s. \u0027"},{"line_number":454,"context_line":"                                    \u0027Reason: %(err)s.\u0027)"},{"line_number":455,"context_line":"                                % {\u0027name\u0027: item[\u0027name\u0027],"},{"line_number":456,"context_line":"                                   \u0027err\u0027: six.text_type(err)})"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            self.deny_access(new_share, new_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_6f97813a","line":455,"range":{"start_line":455,"start_character":32,"end_line":455,"end_character":33},"updated":"2016-02-29 00:20:42.000000000","message":"Use a comma here.","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dc30a93f3c3e36f3ccd89b3d15dcab1593d5e5f3","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                except exception.ShareUmountException as err:"},{"line_number":453,"context_line":"                    LOG.warning(_LW(\u0027Failed to unmount share %(name)s. \u0027"},{"line_number":454,"context_line":"                                    \u0027Reason: %(err)s.\u0027)"},{"line_number":455,"context_line":"                                % {\u0027name\u0027: item[\u0027name\u0027],"},{"line_number":456,"context_line":"                                   \u0027err\u0027: six.text_type(err)})"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            self.deny_access(new_share, new_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_fb46aa4d","line":455,"range":{"start_line":455,"start_character":32,"end_line":455,"end_character":33},"in_reply_to":"9aed3d3a_6f97813a","updated":"2016-02-29 07:56:18.000000000","message":"Done","commit_id":"8b16c833f5c90fc08efe1e0af6dfbb59988b89fb"}]}
