)]}'
{"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0fa2021351ef2e64205721973361ebd2147275bf","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        # NOTE(vponomaryov): Now, when no file usages and mounts of dataset"},{"line_number":190,"context_line":"        # exist, destroy dataset."},{"line_number":191,"context_line":"        self.zfs(\u0027destroy\u0027, \u0027-f\u0027, name)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _setup_helpers(self):"},{"line_number":194,"context_line":"        \"\"\"Setups share helper for ZFS backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_8057d9c8","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":16},"updated":"2016-03-04 07:13:53.000000000","message":"I would keep \"retry\" one here. Look at PS 5 results - http://logs.openstack.org/16/287316/5/check/gate-manila-tempest-dsvm-postgres-zfsonlinux-multibackend/403564d/logs/screen-m-shr.txt.gz#_2016-03-03_20_45_34_065\n\nAlso, local lab testing shows, that it is common situation when dataset deleted only from second-third attempt.\n\nPlease, keep \"zfs_with_retry\" call here.","commit_id":"dec2f2c34ce46ebd74467a0d7ba023d060979d16"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7dbd32334587c067dbe6eb95d4f4ca62327e1cf7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":195,"context_line":"            LOG.info(_LI(\"Failed to destroy ZFS dataset, retrying one time\"))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # NOTE(bswartz): There appears to be a bug in ZFS when creating and "},{"line_number":198,"context_line":"        # destroying datasets concurrently where the filesystem remains mounted"},{"line_number":199,"context_line":"        # even though ZFS thinks it\u0027s unmounted. The most reliable workaround"},{"line_number":200,"context_line":"        # I\u0027ve found is to force the unmount, then retry the destroy, with"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_9ad5ce1d","line":197,"range":{"start_line":197,"start_character":75,"end_line":197,"end_character":76},"updated":"2016-03-09 15:33:50.000000000","message":"pep8 complains at trailing whitespace here.","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b2a88910dfbb8a5268d2d914ddf7ecf8aac05ddb","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # short pauses around the unmount."},{"line_number":202,"context_line":"        time.sleep(1)"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.execute(\u0027sudo\u0027, \u0027umount\u0027, mountpoint)"},{"line_number":205,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":206,"context_line":"            # Ignore failed umount, it\u0027s normal"},{"line_number":207,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_a55edd73","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":54},"updated":"2016-03-08 21:46:58.000000000","message":"zfsonlinux devs strictly recommend to perform umount only using ZFS interface.","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"4ac4c9d0b54efc11eaeed847f00e7fb36e5a9b98","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # short pauses around the unmount."},{"line_number":202,"context_line":"        time.sleep(1)"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.execute(\u0027sudo\u0027, \u0027umount\u0027, mountpoint)"},{"line_number":205,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":206,"context_line":"            # Ignore failed umount, it\u0027s normal"},{"line_number":207,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_0717d0ed","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":54},"in_reply_to":"5aef4532_a55edd73","updated":"2016-03-09 00:57:58.000000000","message":"They may say this, but their own code fails, requiring us to use this workaround. If you know how to file a bug with the zfsonlinux team I can provide them with a simple shellscript that reproduces the issue.\n\nAlso, your prior workaround that I\u0027m replacing also directly calls umount.","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b2a88910dfbb8a5268d2d914ddf7ecf8aac05ddb","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        time.sleep(1)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # This time the destroy is expected to succeed."},{"line_number":211,"context_line":"        self.zfs(\u0027destroy\u0027, \u0027-f\u0027, name)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def _setup_helpers(self):"},{"line_number":214,"context_line":"        \"\"\"Setups share helper for ZFS backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_c5e96982","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":39},"updated":"2016-03-08 21:46:58.000000000","message":"still no sure that just two tries will be enough.","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"4ac4c9d0b54efc11eaeed847f00e7fb36e5a9b98","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        time.sleep(1)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # This time the destroy is expected to succeed."},{"line_number":211,"context_line":"        self.zfs(\u0027destroy\u0027, \u0027-f\u0027, name)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def _setup_helpers(self):"},{"line_number":214,"context_line":"        \"\"\"Setups share helper for ZFS backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_e7cf447d","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":39},"in_reply_to":"5aef4532_c5e96982","updated":"2016-03-09 00:57:58.000000000","message":"Empirical testing shows that after forced umount, zfs destroy succeeds 100% of the time. If we see more failures I think we should add another workaround using a different approach instead of trying the same thing again.","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"}],"manila/tests/share/drivers/zfsonlinux/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7dbd32334587c067dbe6eb95d4f4ca62327e1cf7","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    def test__delete_dataset_or_snapshot_with_retry_busy(self):"},{"line_number":906,"context_line":"        self.mock_object(self.driver, \u0027get_zfs_option\u0027)"},{"line_number":907,"context_line":"        self.mock_object("},{"line_number":908,"context_line":"            self.driver, \u0027execute\u0027, mock.Mock(side_effect\u003d"},{"line_number":909,"context_line":"                exception.ProcessExecutionError("},{"line_number":910,"context_line":"                    \u0027FAKE lsof returns not found\u0027)))"},{"line_number":911,"context_line":"        self.mock_object("},{"line_number":912,"context_line":"            self.driver, \u0027zfs\u0027, mock.Mock(side_effect\u003d["},{"line_number":913,"context_line":"                exception.ProcessExecutionError("}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_fa7b3226","line":910,"range":{"start_line":908,"start_character":12,"end_line":910,"end_character":52},"updated":"2016-03-09 15:33:50.000000000","message":"pep8 compliains here. See http://logs.openstack.org/16/287316/10/check/gate-manila-pep8/9b4d9ea/console.html#_2016-03-08_21_47_22_379","commit_id":"a114127e08baaefca747cd1a7485432cf1193b2a"}]}
