)]}'
{"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"854dbe1b41a12247bd40de9abbe3589089ca17a4","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        share_replica \u003d self._get_share_replica_dict(context, share_replica)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"        try:"},{"line_number":1397,"context_line":"            replica_state \u003d self.driver.update_replica_state("},{"line_number":1398,"context_line":"                context, replica_list, share_replica, access_rules,"},{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_bee2a301","line":1397,"range":{"start_line":1397,"start_character":0,"end_line":1397,"end_character":12},"updated":"2016-03-08 00:42:29.000000000","message":"nit: revert this whitespace deletion if you make another patch","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"724c3db9c3c0434079eb34792f8d7a73038cca75","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        share_replica \u003d self._get_share_replica_dict(context, share_replica)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"        try:"},{"line_number":1397,"context_line":"            replica_state \u003d self.driver.update_replica_state("},{"line_number":1398,"context_line":"                context, replica_list, share_replica, access_rules,"},{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3ec21334","line":1397,"range":{"start_line":1397,"start_character":0,"end_line":1397,"end_character":12},"in_reply_to":"5aef4532_3eab3376","updated":"2016-03-08 00:45:48.000000000","message":"Well, +1. May not be necessary..","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"90f66ee0fd75de6a43dd861ace6550c90644e921","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        share_replica \u003d self._get_share_replica_dict(context, share_replica)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"        try:"},{"line_number":1397,"context_line":"            replica_state \u003d self.driver.update_replica_state("},{"line_number":1398,"context_line":"                context, replica_list, share_replica, access_rules,"},{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3eab3376","line":1397,"range":{"start_line":1397,"start_character":0,"end_line":1397,"end_character":12},"in_reply_to":"5aef4532_bee2a301","updated":"2016-03-08 00:44:35.000000000","message":"i dont like that whitespace :P","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"854dbe1b41a12247bd40de9abbe3589089ca17a4","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            msg \u003d _LE(\"Driver error when updating replica state.\")"},{"line_number":1402,"context_line":"            LOG.exception(msg)"},{"line_number":1403,"context_line":"            self.db.share_replica_update("},{"line_number":1404,"context_line":"                context, share_replica[\u0027id\u0027],"},{"line_number":1405,"context_line":"                {\u0027replica_state\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_deb4cff3","line":1402,"range":{"start_line":1402,"start_character":26,"end_line":1402,"end_character":30},"updated":"2016-03-08 00:42:29.000000000","message":"Should you log the exception traceback as well?","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"724c3db9c3c0434079eb34792f8d7a73038cca75","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            msg \u003d _LE(\"Driver error when updating replica state.\")"},{"line_number":1402,"context_line":"            LOG.exception(msg)"},{"line_number":1403,"context_line":"            self.db.share_replica_update("},{"line_number":1404,"context_line":"                context, share_replica[\u0027id\u0027],"},{"line_number":1405,"context_line":"                {\u0027replica_state\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7ee2dbd6","line":1402,"range":{"start_line":1402,"start_character":26,"end_line":1402,"end_character":30},"in_reply_to":"5aef4532_de996f70","updated":"2016-03-08 00:45:48.000000000","message":"Then please do :)","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"90f66ee0fd75de6a43dd861ace6550c90644e921","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            msg \u003d _LE(\"Driver error when updating replica state.\")"},{"line_number":1402,"context_line":"            LOG.exception(msg)"},{"line_number":1403,"context_line":"            self.db.share_replica_update("},{"line_number":1404,"context_line":"                context, share_replica[\u0027id\u0027],"},{"line_number":1405,"context_line":"                {\u0027replica_state\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_de996f70","line":1402,"range":{"start_line":1402,"start_character":26,"end_line":1402,"end_character":30},"in_reply_to":"5aef4532_deb4cff3","updated":"2016-03-08 00:44:35.000000000","message":"I think so, because any exception raised by the driver is a real issue that  may need an admin to intervene in order to fix.","commit_id":"7c2adaace44c61ceabd14e886220d2a340654466"},{"author":{"_account_id":16522,"name":"daiki kato","email":"d-kato@wr.jp.nec.com","username":"daiki"},"change_message_id":"28260d80a1af10c21b6dec5ddfeac43fbdd4b0d8","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"                context, replica_list, share_replica, access_rules,"},{"line_number":1399,"context_line":"                share_server\u003dshare_server)"},{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            msg \u003d _LE(\"Driver error when updating replica state for replica %s.\")"},{"line_number":1402,"context_line":"            LOG.exception(msg % share_replica[\u0027id\u0027])"},{"line_number":1403,"context_line":"            self.db.share_replica_update("},{"line_number":1404,"context_line":"                context, share_replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_8704b37e","line":1401,"range":{"start_line":1401,"start_character":50,"end_line":1401,"end_character":57},"updated":"2016-03-08 05:23:45.000000000","message":"Please break this line according to PEP8.\n./manila/share/manager.py:1401:80: E501 line too long (81 \u003e 79 characters)","commit_id":"c2bf5f4c5d22d36c2936333217002c4b507a2061"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5701b80bbfde41b0db424b9dcb9444760309eedd","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            msg \u003d _LE(\"Driver error when updating replica \""},{"line_number":1402,"context_line":"                      \"state for replica %s.\")"},{"line_number":1403,"context_line":"            LOG.exception(msg % share_replica[\u0027id\u0027])"},{"line_number":1404,"context_line":"            self.db.share_replica_update("},{"line_number":1405,"context_line":"                context, share_replica[\u0027id\u0027],"},{"line_number":1406,"context_line":"                {\u0027replica_state\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_17739ee8","line":1403,"range":{"start_line":1403,"start_character":30,"end_line":1403,"end_character":31},"updated":"2016-03-08 15:00:59.000000000","message":"Use a comma","commit_id":"5cb9560d3b901d303fc74bf5117459d414af37a8"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"92afa405ec662400b9b40febbb51db7a104419eb","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        self.assertEqual(2, mock_update_method.call_count)"},{"line_number":1099,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    @ddt.data(constants.REPLICA_STATE_IN_SYNC,"},{"line_number":1102,"context_line":"              constants.REPLICA_STATE_OUT_OF_SYNC)"},{"line_number":1103,"context_line":"    def test__share_replica_update_driver_exception(self, replica_state):"},{"line_number":1104,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"},{"line_number":1105,"context_line":"        replica \u003d fake_replica(replica_state\u003dreplica_state)"},{"line_number":1106,"context_line":"        self.mock_object(db, \u0027share_replicas_get_all_by_share\u0027,"},{"line_number":1107,"context_line":"                         mock.Mock(return_value\u003d[replica]))"},{"line_number":1108,"context_line":"        self.mock_object(self.share_manager.db, \u0027share_replica_get\u0027,"},{"line_number":1109,"context_line":"                         mock.Mock(return_value\u003dreplica))"},{"line_number":1110,"context_line":"        self.mock_object(db, \u0027share_server_get\u0027,"},{"line_number":1111,"context_line":"                         mock.Mock(return_value\u003d\u0027fake_share_server\u0027))"},{"line_number":1112,"context_line":"        self.mock_object(self.share_manager.driver, \u0027update_replica_state\u0027,"},{"line_number":1113,"context_line":"                         mock.Mock(side_effect\u003dexception.ManilaException))"},{"line_number":1114,"context_line":"        mock_db_update_call \u003d self.mock_object("},{"line_number":1115,"context_line":"            self.share_manager.db, \u0027share_replica_update\u0027)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        self.share_manager._share_replica_update("},{"line_number":1118,"context_line":"            self.context,  replica, share_id\u003dreplica[\u0027share_id\u0027])"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        mock_db_update_call.assert_called_once_with("},{"line_number":1121,"context_line":"            self.context, replica[\u0027id\u0027],"},{"line_number":1122,"context_line":"            {\u0027replica_state\u0027: constants.STATUS_ERROR,"},{"line_number":1123,"context_line":"             \u0027status\u0027: constants.STATUS_ERROR}"},{"line_number":1124,"context_line":"        )"},{"line_number":1125,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def test__share_replica_update_driver_exception_ignored(self):"},{"line_number":1128,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_71aa3a72","line":1125,"range":{"start_line":1101,"start_character":4,"end_line":1125,"end_character":54},"updated":"2016-03-11 12:55:45.000000000","message":"This test should try update more than one share and get error not on the last one.","commit_id":"bb608e9237e4d7fabf335847680559ecd3fb2ebf"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7eab5d2fa7e0bb6becaf034e291afd4b4790f210","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        self.assertEqual(2, mock_update_method.call_count)"},{"line_number":1099,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    @ddt.data(constants.REPLICA_STATE_IN_SYNC,"},{"line_number":1102,"context_line":"              constants.REPLICA_STATE_OUT_OF_SYNC)"},{"line_number":1103,"context_line":"    def test__share_replica_update_driver_exception(self, replica_state):"},{"line_number":1104,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"},{"line_number":1105,"context_line":"        replica \u003d fake_replica(replica_state\u003dreplica_state)"},{"line_number":1106,"context_line":"        self.mock_object(db, \u0027share_replicas_get_all_by_share\u0027,"},{"line_number":1107,"context_line":"                         mock.Mock(return_value\u003d[replica]))"},{"line_number":1108,"context_line":"        self.mock_object(self.share_manager.db, \u0027share_replica_get\u0027,"},{"line_number":1109,"context_line":"                         mock.Mock(return_value\u003dreplica))"},{"line_number":1110,"context_line":"        self.mock_object(db, \u0027share_server_get\u0027,"},{"line_number":1111,"context_line":"                         mock.Mock(return_value\u003d\u0027fake_share_server\u0027))"},{"line_number":1112,"context_line":"        self.mock_object(self.share_manager.driver, \u0027update_replica_state\u0027,"},{"line_number":1113,"context_line":"                         mock.Mock(side_effect\u003dexception.ManilaException))"},{"line_number":1114,"context_line":"        mock_db_update_call \u003d self.mock_object("},{"line_number":1115,"context_line":"            self.share_manager.db, \u0027share_replica_update\u0027)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        self.share_manager._share_replica_update("},{"line_number":1118,"context_line":"            self.context,  replica, share_id\u003dreplica[\u0027share_id\u0027])"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        mock_db_update_call.assert_called_once_with("},{"line_number":1121,"context_line":"            self.context, replica[\u0027id\u0027],"},{"line_number":1122,"context_line":"            {\u0027replica_state\u0027: constants.STATUS_ERROR,"},{"line_number":1123,"context_line":"             \u0027status\u0027: constants.STATUS_ERROR}"},{"line_number":1124,"context_line":"        )"},{"line_number":1125,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def test__share_replica_update_driver_exception_ignored(self):"},{"line_number":1128,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_79bb400f","line":1125,"range":{"start_line":1101,"start_character":4,"end_line":1125,"end_character":54},"in_reply_to":"3afc51ec_71aa3a72","updated":"2016-03-11 13:51:56.000000000","message":"This function only updates a single share.","commit_id":"bb608e9237e4d7fabf335847680559ecd3fb2ebf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d1aa6c90f09ce4f5c0258e83aa5ed1b9936f5515","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        self.assertEqual(2, mock_update_method.call_count)"},{"line_number":1099,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    @ddt.data(constants.REPLICA_STATE_IN_SYNC,"},{"line_number":1102,"context_line":"              constants.REPLICA_STATE_OUT_OF_SYNC)"},{"line_number":1103,"context_line":"    def test__share_replica_update_driver_exception(self, replica_state):"},{"line_number":1104,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"},{"line_number":1105,"context_line":"        replica \u003d fake_replica(replica_state\u003dreplica_state)"},{"line_number":1106,"context_line":"        self.mock_object(db, \u0027share_replicas_get_all_by_share\u0027,"},{"line_number":1107,"context_line":"                         mock.Mock(return_value\u003d[replica]))"},{"line_number":1108,"context_line":"        self.mock_object(self.share_manager.db, \u0027share_replica_get\u0027,"},{"line_number":1109,"context_line":"                         mock.Mock(return_value\u003dreplica))"},{"line_number":1110,"context_line":"        self.mock_object(db, \u0027share_server_get\u0027,"},{"line_number":1111,"context_line":"                         mock.Mock(return_value\u003d\u0027fake_share_server\u0027))"},{"line_number":1112,"context_line":"        self.mock_object(self.share_manager.driver, \u0027update_replica_state\u0027,"},{"line_number":1113,"context_line":"                         mock.Mock(side_effect\u003dexception.ManilaException))"},{"line_number":1114,"context_line":"        mock_db_update_call \u003d self.mock_object("},{"line_number":1115,"context_line":"            self.share_manager.db, \u0027share_replica_update\u0027)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        self.share_manager._share_replica_update("},{"line_number":1118,"context_line":"            self.context,  replica, share_id\u003dreplica[\u0027share_id\u0027])"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        mock_db_update_call.assert_called_once_with("},{"line_number":1121,"context_line":"            self.context, replica[\u0027id\u0027],"},{"line_number":1122,"context_line":"            {\u0027replica_state\u0027: constants.STATUS_ERROR,"},{"line_number":1123,"context_line":"             \u0027status\u0027: constants.STATUS_ERROR}"},{"line_number":1124,"context_line":"        )"},{"line_number":1125,"context_line":"        self.assertEqual(1, mock_debug_log.call_count)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def test__share_replica_update_driver_exception_ignored(self):"},{"line_number":1128,"context_line":"        mock_debug_log \u003d self.mock_object(manager.LOG, \u0027debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_b993084f","line":1125,"range":{"start_line":1101,"start_character":4,"end_line":1125,"end_character":54},"in_reply_to":"3afc51ec_79bb400f","updated":"2016-03-11 13:56:36.000000000","message":"Oh, nevermind. It is ok.","commit_id":"bb608e9237e4d7fabf335847680559ecd3fb2ebf"}]}
