)]}'
{"manila/tests/test_utils.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"579d3c40e947ff2efc877d59e53333b1113cf13b","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        fake_predicate \u003d mock.Mock(return_value\u003dFalse)"},{"line_number":888,"context_line":"        exc \u003d exception.ManilaException"},{"line_number":889,"context_line":"        self.assertRaises(exception.ManilaException, utils.wait_until_true,"},{"line_number":890,"context_line":"                          fake_predicate, 0.01, 0.01, exc)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_9baeb083","line":890,"range":{"start_line":890,"start_character":42,"end_line":890,"end_character":52},"updated":"2016-03-08 17:22:26.000000000","message":"Is it not preferable to mock eventlet.sleep()?  That\u0027s how we have sped up other similar unit tests.","commit_id":"cc481fbdc7a859f92124eff176d9f6163ae8a551"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"e787254d3abd8947adf3d46bb4768a2cd109a5d3","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        fake_predicate \u003d mock.Mock(return_value\u003dFalse)"},{"line_number":888,"context_line":"        exc \u003d exception.ManilaException"},{"line_number":889,"context_line":"        self.assertRaises(exception.ManilaException, utils.wait_until_true,"},{"line_number":890,"context_line":"                          fake_predicate, 0.01, 0.01, exc)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b150ed0b","line":890,"range":{"start_line":890,"start_character":42,"end_line":890,"end_character":52},"in_reply_to":"5aef4532_16b71787","updated":"2016-03-08 17:50:50.000000000","message":"Cool, did not test that. Done. Thank you!","commit_id":"cc481fbdc7a859f92124eff176d9f6163ae8a551"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3de8f6587d07459b4306703a636a1153c99eb79b","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        fake_predicate \u003d mock.Mock(return_value\u003dFalse)"},{"line_number":888,"context_line":"        exc \u003d exception.ManilaException"},{"line_number":889,"context_line":"        self.assertRaises(exception.ManilaException, utils.wait_until_true,"},{"line_number":890,"context_line":"                          fake_predicate, 0.01, 0.01, exc)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_16b71787","line":890,"range":{"start_line":890,"start_character":42,"end_line":890,"end_character":52},"in_reply_to":"5aef4532_3b083c2d","updated":"2016-03-08 17:46:23.000000000","message":"OK, thanks.  FWIW, I tried passing 0, which also worked.  Either is better than waiting for a second!","commit_id":"cc481fbdc7a859f92124eff176d9f6163ae8a551"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"3cb153a6f7aad14b0ec22eb503fd656eb3a76c97","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        fake_predicate \u003d mock.Mock(return_value\u003dFalse)"},{"line_number":888,"context_line":"        exc \u003d exception.ManilaException"},{"line_number":889,"context_line":"        self.assertRaises(exception.ManilaException, utils.wait_until_true,"},{"line_number":890,"context_line":"                          fake_predicate, 0.01, 0.01, exc)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3b083c2d","line":890,"range":{"start_line":890,"start_character":42,"end_line":890,"end_character":52},"in_reply_to":"5aef4532_9baeb083","updated":"2016-03-08 17:30:50.000000000","message":"If eventlet.sleep() is mocked, eventlet.timeout.Timeout() will never trigger, so it will wait forever. Please let me know if I am missing something.","commit_id":"cc481fbdc7a859f92124eff176d9f6163ae8a551"}]}
