)]}'
{"manila/share/api.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"6bc40e932b7589eba56d954ac768ac2b50ce1b1a","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                                          project_id\u003dproject_id,"},{"line_number":612,"context_line":"                                          shares\u003d-1,"},{"line_number":613,"context_line":"                                          gigabytes\u003d-share[\u0027size\u0027],"},{"line_number":614,"context_line":"                                          user_id\u003dshare[\u0027user_id\u0027])"},{"line_number":615,"context_line":"        except Exception as e:"},{"line_number":616,"context_line":"            reservations \u003d None"},{"line_number":617,"context_line":"            LOG.exception("}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_82073817","line":614,"updated":"2016-03-09 11:09:49.000000000","message":"Ah, can we also update the doc for DbQuotaDriver.reserve?\nIMHO the param description is a bit misleading:\n       :param user_id: Specify the user_id if current context\n                        is admin and admin wants to impact on\n                        common user.","commit_id":"18c3c5d69f4126e3071edff85ac419c0e241e691"}],"manila/tests/api/v1/test_share_networks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"36be844316861c4c0d7df199679d95ff0d5154af","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        {\u0027neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":121,"context_line":"        {\u0027neutron_net_id\u0027: \u0027fake\u0027, \u0027neutron_subnet_id\u0027: \u0027fake\u0027})"},{"line_number":122,"context_line":"    def test_create_valid_cases(self, data):"},{"line_number":123,"context_line":"        data.update({\u0027user_id\u0027: \u0027fake_user_id\u0027})"},{"line_number":124,"context_line":"        body \u003d {share_networks.RESOURCE_NAME: data}"},{"line_number":125,"context_line":"        result \u003d self.controller.create(self.req, body)"},{"line_number":126,"context_line":"        data.pop(\u0027user_id\u0027, None)"},{"line_number":127,"context_line":"        for k, v in data.items():"},{"line_number":128,"context_line":"            self.assertIn(data[k], result[\u0027share_network\u0027][k])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @ddt.data("},{"line_number":131,"context_line":"        {\u0027nova_net_id\u0027: \u0027foo\u0027, \u0027neutron_net_id\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_025a8e83","line":128,"range":{"start_line":123,"start_character":8,"end_line":128,"end_character":62},"updated":"2016-03-11 11:33:02.000000000","message":"It is expected to test \"user_id\" usage here.","commit_id":"8538521ded133447a4a152ce89f4a02b9829ec0d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9a32b598798fedcd3f618f6a32f68a61cab29436","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        {\u0027neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":121,"context_line":"        {\u0027neutron_net_id\u0027: \u0027fake\u0027, \u0027neutron_subnet_id\u0027: \u0027fake\u0027})"},{"line_number":122,"context_line":"    def test_create_valid_cases(self, data):"},{"line_number":123,"context_line":"        data.update({\u0027user_id\u0027: \u0027fake_user_id\u0027})"},{"line_number":124,"context_line":"        body \u003d {share_networks.RESOURCE_NAME: data}"},{"line_number":125,"context_line":"        result \u003d self.controller.create(self.req, body)"},{"line_number":126,"context_line":"        data.pop(\u0027user_id\u0027, None)"},{"line_number":127,"context_line":"        for k, v in data.items():"},{"line_number":128,"context_line":"            self.assertIn(data[k], result[\u0027share_network\u0027][k])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @ddt.data("},{"line_number":131,"context_line":"        {\u0027nova_net_id\u0027: \u0027foo\u0027, \u0027neutron_net_id\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_31f55283","line":128,"range":{"start_line":123,"start_character":8,"end_line":128,"end_character":62},"in_reply_to":"3afc51ec_02444e72","updated":"2016-03-11 12:56:59.000000000","message":"I am confused. PS11 still does not check that proper user_id was used.","commit_id":"8538521ded133447a4a152ce89f4a02b9829ec0d"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"86b051bb035ffe82895d9f510f47f85e1e06a089","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        {\u0027neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":121,"context_line":"        {\u0027neutron_net_id\u0027: \u0027fake\u0027, \u0027neutron_subnet_id\u0027: \u0027fake\u0027})"},{"line_number":122,"context_line":"    def test_create_valid_cases(self, data):"},{"line_number":123,"context_line":"        data.update({\u0027user_id\u0027: \u0027fake_user_id\u0027})"},{"line_number":124,"context_line":"        body \u003d {share_networks.RESOURCE_NAME: data}"},{"line_number":125,"context_line":"        result \u003d self.controller.create(self.req, body)"},{"line_number":126,"context_line":"        data.pop(\u0027user_id\u0027, None)"},{"line_number":127,"context_line":"        for k, v in data.items():"},{"line_number":128,"context_line":"            self.assertIn(data[k], result[\u0027share_network\u0027][k])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @ddt.data("},{"line_number":131,"context_line":"        {\u0027nova_net_id\u0027: \u0027foo\u0027, \u0027neutron_net_id\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_02444e72","line":128,"range":{"start_line":123,"start_character":8,"end_line":128,"end_character":62},"in_reply_to":"3afc51ec_025a8e83","updated":"2016-03-11 11:45:51.000000000","message":"Ok. i will update that key in the fake_share_network, before running the quota test","commit_id":"8538521ded133447a4a152ce89f4a02b9829ec0d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf036b7b5a964e61d62e4fb0281b143a65b7ae3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        {\u0027neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":121,"context_line":"        {\u0027neutron_net_id\u0027: \u0027fake\u0027, \u0027neutron_subnet_id\u0027: \u0027fake\u0027})"},{"line_number":122,"context_line":"    def test_create_valid_cases(self, data):"},{"line_number":123,"context_line":"        data.update({\u0027user_id\u0027: \u0027fake_user_id\u0027})"},{"line_number":124,"context_line":"        body \u003d {share_networks.RESOURCE_NAME: data}"},{"line_number":125,"context_line":"        result \u003d self.controller.create(self.req, body)"},{"line_number":126,"context_line":"        data.pop(\u0027user_id\u0027, None)"},{"line_number":127,"context_line":"        for k, v in data.items():"},{"line_number":128,"context_line":"            self.assertIn(data[k], result[\u0027share_network\u0027][k])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @ddt.data("},{"line_number":131,"context_line":"        {\u0027nova_net_id\u0027: \u0027foo\u0027, \u0027neutron_net_id\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_ef5a9b29","line":128,"range":{"start_line":123,"start_character":8,"end_line":128,"end_character":62},"in_reply_to":"3afc51ec_31f55283","updated":"2016-03-14 12:06:03.000000000","message":"Hi Tom. You could mock share_networks.QUOTAS reserve and commit methods to assert they were called using proper user_id.","commit_id":"8538521ded133447a4a152ce89f4a02b9829ec0d"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"da401cd7f806d300eba061861e26fb6deb9175c2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        {\u0027neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":121,"context_line":"        {\u0027neutron_net_id\u0027: \u0027fake\u0027, \u0027neutron_subnet_id\u0027: \u0027fake\u0027})"},{"line_number":122,"context_line":"    def test_create_valid_cases(self, data):"},{"line_number":123,"context_line":"        data.update({\u0027user_id\u0027: \u0027fake_user_id\u0027})"},{"line_number":124,"context_line":"        body \u003d {share_networks.RESOURCE_NAME: data}"},{"line_number":125,"context_line":"        result \u003d self.controller.create(self.req, body)"},{"line_number":126,"context_line":"        data.pop(\u0027user_id\u0027, None)"},{"line_number":127,"context_line":"        for k, v in data.items():"},{"line_number":128,"context_line":"            self.assertIn(data[k], result[\u0027share_network\u0027][k])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @ddt.data("},{"line_number":131,"context_line":"        {\u0027nova_net_id\u0027: \u0027foo\u0027, \u0027neutron_net_id\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_0da38c50","line":128,"range":{"start_line":123,"start_character":8,"end_line":128,"end_character":62},"in_reply_to":"3afc51ec_ef5a9b29","updated":"2016-03-14 13:27:36.000000000","message":"Hi. This is already done in Line 267 in test_quota_delete_reservation_failed.","commit_id":"8538521ded133447a4a152ce89f4a02b9829ec0d"}]}
