)]}'
{"manila/share/drivers/lxd.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ec655d507e688bd795c838361a60df08b041d9af","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        self.lxd.start_container(server_id)"},{"line_number":749,"context_line":"        self.lxd.api.container_run_command(server_id,"},{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\") or None"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_dd9efe05","line":751,"range":{"start_line":751,"start_character":64,"end_line":751,"end_character":72},"updated":"2016-03-10 10:23:51.000000000","message":"This is redundant, see https://github.com/openstack/manila/blob/3cb25007/manila/share/configuration.py#L74","commit_id":"178e10579bf25b3c13c9bedaecd064b0e6b59fc1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"e0de97c983badd5ca830f62adf47195575bd5997","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        self.lxd.start_container(server_id)"},{"line_number":749,"context_line":"        self.lxd.api.container_run_command(server_id,"},{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\") or None"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_d35c2e1b","line":751,"range":{"start_line":751,"start_character":64,"end_line":751,"end_character":72},"in_reply_to":"5aef4532_dd9efe05","updated":"2016-03-10 11:16:30.000000000","message":"Good point, thank you.","commit_id":"178e10579bf25b3c13c9bedaecd064b0e6b59fc1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ec655d507e688bd795c838361a60df08b041d9af","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        self.lxd.start_container(server_id)"},{"line_number":749,"context_line":"        self.lxd.api.container_run_command(server_id,"},{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\") or None"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_bd6fb2fa","line":754,"range":{"start_line":750,"start_character":8,"end_line":754,"end_character":70},"updated":"2016-03-10 10:23:51.000000000","message":"All of these should be covered with unit tests.\n\nAlso, if it does not work without host ID, then it is required thing, why do you just \"warn\"?","commit_id":"178e10579bf25b3c13c9bedaecd064b0e6b59fc1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"e0de97c983badd5ca830f62adf47195575bd5997","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        self.lxd.start_container(server_id)"},{"line_number":749,"context_line":"        self.lxd.api.container_run_command(server_id,"},{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\") or None"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_73827ac9","line":754,"range":{"start_line":750,"start_character":8,"end_line":754,"end_character":70},"in_reply_to":"5aef4532_bd6fb2fa","updated":"2016-03-10 11:16:30.000000000","message":"The warning is here for the unlikely case of direct manipulations with containers. My initial idea was to hint a possible user that something might be wrong, not to decide for him what to put in a config. Also as you have mentioned some time ago we are connecting to a network, not to a neutron network, so we should either avoid strong assumptions or state explicitly that it works with neutron only.","commit_id":"178e10579bf25b3c13c9bedaecd064b0e6b59fc1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d87fe6ed240d74635cd0b6e8152e12708a94649","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\")"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_a486db10","line":754,"range":{"start_line":753,"start_character":12,"end_line":754,"end_character":70},"updated":"2016-03-14 18:59:43.000000000","message":"I am having a hard time understanding the purpose of this bugfix. If this is a scenario that should be prevented, shouldn\u0027t it throw an exception instead of allowing the driver to continue?","commit_id":"35cbb157fa14636e160987d9d573b070ff6294e0"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c012f6755072a6221940a7bc536b212fb33e28a0","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\")"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_20f58256","line":754,"range":{"start_line":753,"start_character":12,"end_line":754,"end_character":70},"in_reply_to":"3afc51ec_304de26c","updated":"2016-03-15 07:57:28.000000000","message":"Please see my response to Rodrigo\u0027s comment above.","commit_id":"35cbb157fa14636e160987d9d573b070ff6294e0"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"0ddf3b688bea9878567d3a29195cf0e58e3682ba","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\")"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_304de26c","line":754,"range":{"start_line":753,"start_character":12,"end_line":754,"end_character":70},"in_reply_to":"3afc51ec_a486db10","updated":"2016-03-14 19:56:30.000000000","message":"+1\n\nIf the driver doesn\u0027t have the info it needs to create reachable containers, it should raise an exception in check_for_setup_error() and refuse to start.  Are there cases where neutron_host_id is not needed?","commit_id":"35cbb157fa14636e160987d9d573b070ff6294e0"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c012f6755072a6221940a7bc536b212fb33e28a0","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                           [\"mkdir\", \"-m\", \"777\", \"/shares\"])"},{"line_number":751,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\")"},{"line_number":752,"context_line":"        if host_id is None:"},{"line_number":753,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":754,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":755,"context_line":"        self._connect_to_network(server_id, network_info)"},{"line_number":756,"context_line":"        # TODO(aovchinnikov): expand metadata above the bare minimum"},{"line_number":757,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_c0ddbee1","line":754,"range":{"start_line":753,"start_character":12,"end_line":754,"end_character":70},"in_reply_to":"3afc51ec_a486db10","updated":"2016-03-15 07:57:28.000000000","message":"This will fail user\u0027s expectation in the case  when he is using Neutron and is expecting to access share from within Neutron\u0027s network. If, for some reason, he decides to use other NaaS solutions and/or wants to manage container access in some other way then this won\u0027t necessary be an error. Thus I decided that probably it is better to use strong warning rather than raise an exception. On the other hand it could be checked together with network_api_class and then it is ok to raise an exception. I\u0027ll probably just do it right away.","commit_id":"35cbb157fa14636e160987d9d573b070ff6294e0"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9f5c90110822f5d127d2b9ed7f298fdfb232d307","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    def _get_container_name(self, server_id):"},{"line_number":755,"context_line":"        return \"manila-%s\" % server_id"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    def _check_for_setup_errors(self):"},{"line_number":758,"context_line":"        host_id \u003d self.configuration.safe_get(\"neutron_host_id\")"},{"line_number":759,"context_line":"        neutron_class \u003d (\u0027manila.network.neutron.neutron_network_plugin.\u0027"},{"line_number":760,"context_line":"                         \u0027NeutronNetworkPlugin\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_e45debed","line":757,"range":{"start_line":757,"start_character":8,"end_line":757,"end_character":31},"updated":"2016-03-15 13:41:02.000000000","message":"This is called from the setup_server path.  Wouldn\u0027t it be better to have this check in the standard check_for_setup_error() method that is called when the driver starts?  An exception there will prevent the driver from starting and force the admin to fix the issue instead of discovering the issue sometime later when a share server fails to build.","commit_id":"3461fc3c1edb49dc9c37fca6a49a0affb4f380d4"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c887bc72ffc9b6d1e5ce5bd47c6da892ebaed37a","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        neutron_class \u003d (\u0027manila.network.neutron.neutron_network_plugin.\u0027"},{"line_number":760,"context_line":"                         \u0027NeutronNetworkPlugin\u0027)"},{"line_number":761,"context_line":"        actual_class \u003d self.configuration.safe_get(\"network_api_class\")"},{"line_number":762,"context_line":"        if host_id is None and (actual_class \u003d\u003d neutron_class):"},{"line_number":763,"context_line":"            msg \u003d _(\"%s requires neutron_host_id to be \""},{"line_number":764,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":765,"context_line":"            raise exception.ManilaException(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_79f94780","line":762,"updated":"2016-03-16 12:08:30.000000000","message":"For me it makes no sense to hard-code a Network driver to this code. This actually binds driver code to network code. At least I would use \"isinstance(NeutronNetworkPlugin)\" instead of a equal match to allow inheritance..","commit_id":"3461fc3c1edb49dc9c37fca6a49a0affb4f380d4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60e2131d78250b6ed387847aaaafe592b9273fb1","unresolved":false,"context_lines":[{"line_number":764,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":765,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":766,"context_line":"        elif host_id is None:"},{"line_number":767,"context_line":"            LOG.info(_LI(\"neutron_host_id is not specified. This driver \""},{"line_number":768,"context_line":"                         \"might not work as expected without it.\"))"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    def _setup_server(self, network_info, metadata\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_01f3ae0b","line":767,"range":{"start_line":767,"start_character":12,"end_line":767,"end_character":20},"updated":"2016-03-15 11:53:51.000000000","message":"I still think this should be a warning. The admin can insert any value that is not going to be used just to fix the warning if it is using a different NaaS. I am not downvoting due to this though, would like to know other reviewers\u0027 opinion.","commit_id":"3461fc3c1edb49dc9c37fca6a49a0affb4f380d4"}]}
