)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"422d8cd7a0a01fb84933ad3b93263e9c7be1f43e","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6386c95a4cdcf7ea6f0c08a798c90b4613227cd4"},{"line_number":14,"context_line":"Closes-bug: #1553126"},{"line_number":15,"context_line":"Closes-bug: #1553126"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_92570a26","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":20},"updated":"2016-03-11 09:37:19.000000000","message":"bug id duplicated.","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9a99ccb2098b85755839ebbac4e3797e5787ec61","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6386c95a4cdcf7ea6f0c08a798c90b4613227cd4"},{"line_number":14,"context_line":"Closes-bug: #1553126"},{"line_number":15,"context_line":"Closes-bug: #1553126"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_2698776a","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":20},"in_reply_to":"5aef4532_92570a26","updated":"2016-03-11 09:40:49.000000000","message":"Done","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"}],"manila/share/drivers/lxd.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b502db9e1c97d16b3267ee9ec69ccab2f92df41f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":401,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def _get_share_name(self):"},{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":407,"context_line":"            \"id\": str(self.share.id),"},{"line_number":408,"context_line":"        }"},{"line_number":409,"context_line":"        return name % expd"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def create_share(self, server_id):"},{"line_number":412,"context_line":"        share_name \u003d self._get_share_name()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_c6b9d3cd","line":409,"range":{"start_line":403,"start_character":3,"end_line":409,"end_character":26},"updated":"2016-03-11 09:42:17.000000000","message":"It is duplicated. Now is right time to implement base class.","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"03d383e15670db2e12647d157cb768c80d7e9a7f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":401,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def _get_share_name(self):"},{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":407,"context_line":"            \"id\": str(self.share.id),"},{"line_number":408,"context_line":"        }"},{"line_number":409,"context_line":"        return name % expd"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def create_share(self, server_id):"},{"line_number":412,"context_line":"        share_name \u003d self._get_share_name()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_a90298b2","line":409,"range":{"start_line":403,"start_character":3,"end_line":409,"end_character":26},"in_reply_to":"5aef4532_c6b9d3cd","updated":"2016-03-11 10:03:40.000000000","message":"I guess you are right, its about past the time for this code to be refactored.","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b502db9e1c97d16b3267ee9ec69ccab2f92df41f","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            raise exception.InvalidShare("},{"line_number":628,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def _get_share_name(self, share):"},{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _get_lv_device(self, share):"},{"line_number":639,"context_line":"        return os.path.join(\"/dev\", self.configuration.lxd_volume_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_46cdc35c","line":636,"range":{"start_line":630,"start_character":4,"end_line":636,"end_character":26},"updated":"2016-03-11 09:42:17.000000000","message":"Same here. Duplication.","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"03d383e15670db2e12647d157cb768c80d7e9a7f","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            raise exception.InvalidShare("},{"line_number":628,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def _get_share_name(self, share):"},{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _get_lv_device(self, share):"},{"line_number":639,"context_line":"        return os.path.join(\"/dev\", self.configuration.lxd_volume_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_09e10cff","line":636,"range":{"start_line":630,"start_character":4,"end_line":636,"end_character":26},"in_reply_to":"5aef4532_46cdc35c","updated":"2016-03-11 10:03:40.000000000","message":"Will fix in the next commit.","commit_id":"d65e68174fc1183c05ccf2f808de3c7547684819"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self.access_rules_ro \u003d \"(ro,no_root_squash,async,no_subtree_check)\""},{"line_number":270,"context_line":"        self.access_rules_rw \u003d \"(rw,no_root_squash,async,no_subtree_check)\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def _get_share_name(self):"},{"line_number":273,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":274,"context_line":"        expd \u003d {"},{"line_number":275,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5cc9145a","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":23},"updated":"2016-03-11 10:32:44.000000000","message":"You have defined this method here...","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self.access_rules_ro \u003d \"(ro,no_root_squash,async,no_subtree_check)\""},{"line_number":270,"context_line":"        self.access_rules_rw \u003d \"(rw,no_root_squash,async,no_subtree_check)\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def _get_share_name(self):"},{"line_number":273,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":274,"context_line":"        expd \u003d {"},{"line_number":275,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5c2474c5","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":23},"in_reply_to":"5aef4532_5cc9145a","updated":"2016-03-11 10:52:53.000000000","message":"Well","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":274,"context_line":"        expd \u003d {"},{"line_number":275,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":276,"context_line":"            \"id\": str(self.share.id),"},{"line_number":277,"context_line":"        }"},{"line_number":278,"context_line":"        return name % expd"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1c982c6a","line":276,"range":{"start_line":276,"start_character":18,"end_line":276,"end_character":21},"updated":"2016-03-11 10:32:44.000000000","message":"Please use six.text_type() instead of str()","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":274,"context_line":"        expd \u003d {"},{"line_number":275,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":276,"context_line":"            \"id\": str(self.share.id),"},{"line_number":277,"context_line":"        }"},{"line_number":278,"context_line":"        return name % expd"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_bc3498fb","line":276,"range":{"start_line":276,"start_character":18,"end_line":276,"end_character":21},"in_reply_to":"5aef4532_1c982c6a","updated":"2016-03-11 10:52:53.000000000","message":"Done","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":401,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def _get_share_name(self):"},{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3cc6c849","line":403,"range":{"start_line":403,"start_character":8,"end_line":403,"end_character":23},"updated":"2016-03-11 10:32:44.000000000","message":"... here","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":401,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def _get_share_name(self):"},{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7c2b3095","line":403,"range":{"start_line":403,"start_character":8,"end_line":403,"end_character":23},"in_reply_to":"5aef4532_3cc6c849","updated":"2016-03-11 10:52:53.000000000","message":"yes","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":407,"context_line":"            \"id\": str(self.share.id),"},{"line_number":408,"context_line":"        }"},{"line_number":409,"context_line":"        return name % expd"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3c9fe851","line":407,"range":{"start_line":407,"start_character":18,"end_line":407,"end_character":21},"updated":"2016-03-11 10:32:44.000000000","message":"six.text_type()","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":405,"context_line":"        expd \u003d {"},{"line_number":406,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":407,"context_line":"            \"id\": str(self.share.id),"},{"line_number":408,"context_line":"        }"},{"line_number":409,"context_line":"        return name % expd"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fc158049","line":407,"range":{"start_line":407,"start_character":18,"end_line":407,"end_character":21},"in_reply_to":"5aef4532_3c9fe851","updated":"2016-03-11 10:52:53.000000000","message":"Done","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            raise exception.InvalidShare("},{"line_number":628,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def _get_share_name(self, share):"},{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fc01006c","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":23},"updated":"2016-03-11 10:32:44.000000000","message":"... and here. This doesn\u0027t look right. Can\u0027t this method be placed somewhere else where you can just call it, instead of defining on every class you need it?","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            raise exception.InvalidShare("},{"line_number":628,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def _get_share_name(self, share):"},{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5f3906d8","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":23},"in_reply_to":"5aef4532_fc01006c","updated":"2016-03-11 10:52:53.000000000","message":"you are completely right:) I\u0027m refactoring this mess in the next patch set.","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fc0f4086","line":634,"range":{"start_line":634,"start_character":22,"end_line":634,"end_character":30},"updated":"2016-03-11 10:32:44.000000000","message":"Please use share[\u0027id\u0027] instead.","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"b5203df68321055b0d7ac563764351b0c1fdfa55","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_9cac3c8e","line":634,"range":{"start_line":634,"start_character":18,"end_line":634,"end_character":21},"updated":"2016-03-11 10:32:44.000000000","message":"six.text_type()","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7f3042e9","line":634,"range":{"start_line":634,"start_character":18,"end_line":634,"end_character":21},"in_reply_to":"5aef4532_9cac3c8e","updated":"2016-03-11 10:52:53.000000000","message":"Done","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7cef3efba78c05abe12e21e5b79cdc78041d9a2c","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":632,"context_line":"        expd \u003d {"},{"line_number":633,"context_line":"            \"prefix\": self.configuration.lxd_share_prefix,"},{"line_number":634,"context_line":"            \"id\": str(share.id),"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":"        return name % expd"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_bf500a0c","line":634,"range":{"start_line":634,"start_character":22,"end_line":634,"end_character":30},"in_reply_to":"5aef4532_fc0f4086","updated":"2016-03-11 10:52:53.000000000","message":"Ok, thank you.","commit_id":"cc1067ec15c4b0103bebced5bac6e39cdede9307"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"6e40d68d496ec68d25a4c0604de8e77fd8b8dfc6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.StrOpt(\"lxd_image_name\","},{"line_number":75,"context_line":"               default\u003d\"manila-lxd-image\","},{"line_number":76,"context_line":"               help\u003d\"LXD image to be used for a server.\"),"},{"line_number":77,"context_line":"    cfg.StrOpt(\"lxd_share_prefix\","},{"line_number":78,"context_line":"               default\u003d\"manila_share\","},{"line_number":79,"context_line":"               help\u003d\"Prefix to be used when creating a share.\"),"},{"line_number":80,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_1a181884","line":77,"updated":"2016-03-11 21:12:24.000000000","message":"I\u0027m torn because technically this config option is the right way to implement this, but the config option should have been added before feature freeze.\n\nOne alternative is to hardcode the prefix in mitaka and make it configurable in newton. It seems silly to split it though. Marking -1 for now while I look for other config options added in bugfixes.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"55f63d657976f42fd9fa15696ab0bf1ff997b1ab","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.StrOpt(\"lxd_image_name\","},{"line_number":75,"context_line":"               default\u003d\"manila-lxd-image\","},{"line_number":76,"context_line":"               help\u003d\"LXD image to be used for a server.\"),"},{"line_number":77,"context_line":"    cfg.StrOpt(\"lxd_share_prefix\","},{"line_number":78,"context_line":"               default\u003d\"manila_share\","},{"line_number":79,"context_line":"               help\u003d\"Prefix to be used when creating a share.\"),"},{"line_number":80,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_052a4d7e","line":77,"in_reply_to":"3afc51ec_1a181884","updated":"2016-03-14 10:28:54.000000000","message":"I\u0027ll fix merge conflicts and put -1 till decision on what to do with the prefix.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a98ce0f55c4df3ebf3cb80eb4abdf836f38c6066","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_46e4a30c","line":271,"range":{"start_line":271,"start_character":12,"end_line":271,"end_character":50},"updated":"2016-03-11 13:44:20.000000000","message":"you should not need to use six.text_type on share[\u0027id\u0027]. Is there any problem you are facing when not using it?","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b79e1637edb9500bce537e79d0c4e0037739599a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_19b67c8a","line":271,"range":{"start_line":271,"start_character":12,"end_line":271,"end_character":50},"in_reply_to":"3afc51ec_46e4a30c","updated":"2016-03-11 14:54:07.000000000","message":"It looks like that it is not needed here. Thank you!","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a98ce0f55c4df3ebf3cb80eb4abdf836f38c6066","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_06bbbb73","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"updated":"2016-03-11 13:44:20.000000000","message":"I really don\u0027t the idea of setting the share to a class attribute, can\u0027t you send it as argument to this function? I believe this is highly prone to concurrency problems.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b79e1637edb9500bce537e79d0c4e0037739599a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_f22ac5e6","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_06bbbb73","updated":"2016-03-11 14:54:07.000000000","message":"Yes, I could, but this attribute changes each time a helper is requested via _get_helper(), so it seems to me that it should not actually cause any issues unless we somehow manage to simultaneously call two different methods of a single LXDDriver object for two different shares. In this case it probably deserves a separate bug.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"945956f7ef2c94de141c0e6859eee13f5257a8e8","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_a6bf205f","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_4673bc80","updated":"2016-03-14 11:25:10.000000000","message":"Um, from the LXD\u003cwhatever\u003eHelper. Please, see line 263 and line 387 in the base. All I\u0027ve done in this change was to move \u0027share\u0027 attribute to superclass. So it was a little broken even before this change. Am I still missing something?","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d919bdc89c11fb416b81aa79d99b9083d8b53692","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_4673bc80","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_5e10aa01","updated":"2016-03-14 11:12:03.000000000","message":"I am sorry, inherited from which helpers? Your driver is not importing any of the existing helpers such as NFS or CIFS. Also, your driver\u0027s helpers did not have a \"share\" attribute before this change, so I fail to see how this bug is unrelated to this change if it is being introduced by it.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"1b7d3377ab61006e8f4c20bed82416436102012a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_5e10aa01","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_882cf4ac","updated":"2016-03-14 08:50:02.000000000","message":"Thank you for detailed clarification! However I\u0027d like to point out that this behavior is actually inherited from the original implementation of helpers. So it is a bug and I believe that it deserves a bug report (here is a link to it: https://bugs.launchpad.net/manila/+bug/1556802) and a separate change that fixes it. I don\u0027t think it is a good idea to lump several bug fixes together.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b6e671a5e3bfd3e0a289008a21c58e4366dd0bfc","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_695e8b13","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_a6bf205f","updated":"2016-03-14 11:30:18.000000000","message":"Thanks for pointing that out, you are right, I did not notice they were upstream.","commit_id":"db852b912b004480dee736072fecdfcb22980605"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"707bef273986e8bb3463075e49019874ecc76e2c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":265,"context_line":"        self.lxd \u003d lxd_helper"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _get_share_name(self):"},{"line_number":268,"context_line":"        name \u003d \"%(prefix)s_%(id)s\""},{"line_number":269,"context_line":"        expd \u003d {"},{"line_number":270,"context_line":"            \"prefix\": self.conf.lxd_share_prefix,"},{"line_number":271,"context_line":"            \"id\": six.text_type(self.share[\u0027id\u0027]),"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        return name % expd"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_882cf4ac","line":272,"range":{"start_line":267,"start_character":3,"end_line":272,"end_character":9},"in_reply_to":"3afc51ec_f22ac5e6","updated":"2016-03-11 15:28:27.000000000","message":"we can have two simultaneous calls to different shares. If your driver receives a request and takes a while to process it waiting on the operating system, the manager process will get free CPU time to process a different RPC request, invoking your driver again for a different share, which may change the value, and then when the first call unblocks, the value will have changed if it tries to use the attribute again.","commit_id":"db852b912b004480dee736072fecdfcb22980605"}]}
