)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"74b156f1b110cb6f83d5016148f94f827dacbd4a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix instance delete error when share not found"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever drivers throw exceptions during update_access,"},{"line_number":10,"context_line":"share cannot be deleted anymore. This patch adds possibility"},{"line_number":11,"context_line":"of driver throwing a NotFound exception to let the manager"},{"line_number":12,"context_line":"know share does not exist in backend anymore."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_8394fe8a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":54},"updated":"2016-03-10 16:50:45.000000000","message":"Do you mean when the driver throws an error in delete_share?","commit_id":"cd16d0b91c3e6ea7f4f29197efcdfeb11c4603ba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever drivers throw exceptions during update_access,"},{"line_number":10,"context_line":"share cannot be deleted, not even with force-delete."},{"line_number":11,"context_line":"Some drivers already do not throw exception in delete_share"},{"line_number":12,"context_line":"in such cases, but update_access should still throw exception"},{"line_number":13,"context_line":"if share is not found when allow_access or deny_access"},{"line_number":14,"context_line":"are called."},{"line_number":15,"context_line":"This patch adds possibility for driver throwing a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afc51ec_86c160e7","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":13},"updated":"2016-03-13 04:50:21.000000000","message":"This should not be true, is it?\n\nThe NetApp driver for one checks if the share is deleted on the backend. If it is deleted, it will not raise an exception.. However, if there is any other problem; it will raise an exception. Ex: Inability to talk to the storage array etc.","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever drivers throw exceptions during update_access,"},{"line_number":10,"context_line":"share cannot be deleted, not even with force-delete."},{"line_number":11,"context_line":"Some drivers already do not throw exception in delete_share"},{"line_number":12,"context_line":"in such cases, but update_access should still throw exception"},{"line_number":13,"context_line":"if share is not found when allow_access or deny_access"},{"line_number":14,"context_line":"are called."},{"line_number":15,"context_line":"This patch adds possibility for driver throwing a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afc51ec_9a2eb3f8","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":13},"in_reply_to":"3afc51ec_86c160e7","updated":"2016-03-14 14:04:30.000000000","message":"Sorry Goutham, not sure if I understood your question. The scenario you described regarding to NetApp is exactly what I am describing in Commit Message. Anything not related to this specific scenario should still throw exceptions. In delete_share, it does not matter if you throw the new exception as pointed out by this change or swallow it, some drivers, as NetApp, already swallow.","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"}],"manila/share/access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                             remove_rules, share_instance,"},{"line_number":88,"context_line":"                                             share_server)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            error \u003d six.text_type(e)"},{"line_number":91,"context_line":"            LOG.exception(error)"},{"line_number":92,"context_line":"            self.db.share_instance_update_access_status("},{"line_number":93,"context_line":"                context,"},{"line_number":94,"context_line":"                share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_067550ca","line":91,"range":{"start_line":90,"start_character":12,"end_line":91,"end_character":32},"updated":"2016-03-13 04:50:21.000000000","message":"Not necessary, since raised exceptions will be logged automatically.","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                             remove_rules, share_instance,"},{"line_number":88,"context_line":"                                             share_server)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            error \u003d six.text_type(e)"},{"line_number":91,"context_line":"            LOG.exception(error)"},{"line_number":92,"context_line":"            self.db.share_instance_update_access_status("},{"line_number":93,"context_line":"                context,"},{"line_number":94,"context_line":"                share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_d5a80cde","line":91,"range":{"start_line":90,"start_character":12,"end_line":91,"end_character":32},"in_reply_to":"3afc51ec_067550ca","updated":"2016-03-14 14:04:30.000000000","message":"Done","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                context,"},{"line_number":94,"context_line":"                share_instance[\u0027id\u0027],"},{"line_number":95,"context_line":"                constants.STATUS_ERROR)"},{"line_number":96,"context_line":"            if isinstance(e, exception.ShareResourceNotFound):"},{"line_number":97,"context_line":"                raise"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                raise exception.ManilaException(message\u003derror)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_a663bc19","line":97,"range":{"start_line":96,"start_character":12,"end_line":97,"end_character":21},"updated":"2016-03-13 04:50:21.000000000","message":"At this point, should you not be setting the share instance \u0027status\u0027 attr to \u0027error\u0027 as well? The driver says its gone.. might as well set it to \u0027error\u0027 so that it can be dealt with appropriately for all other calls, but delete..","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                context,"},{"line_number":94,"context_line":"                share_instance[\u0027id\u0027],"},{"line_number":95,"context_line":"                constants.STATUS_ERROR)"},{"line_number":96,"context_line":"            if isinstance(e, exception.ShareResourceNotFound):"},{"line_number":97,"context_line":"                raise"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                raise exception.ManilaException(message\u003derror)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_751e5864","line":97,"range":{"start_line":96,"start_character":12,"end_line":97,"end_character":21},"in_reply_to":"3afc51ec_a663bc19","updated":"2016-03-14 14:04:30.000000000","message":"I don\u0027t think it is a good idea to involve share_instance status logic here.","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                constants.STATUS_ERROR)"},{"line_number":96,"context_line":"            if isinstance(e, exception.ShareResourceNotFound):"},{"line_number":97,"context_line":"                raise"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                raise exception.ManilaException(message\u003derror)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # NOTE(ganso): remove rules after maintenance is complete"},{"line_number":102,"context_line":"        if remove_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_26784cc4","line":99,"range":{"start_line":98,"start_character":12,"end_line":99,"end_character":62},"updated":"2016-03-13 04:50:21.000000000","message":"I don\u0027t see the value of raising a ManilaException.. Can we just reraise the same exception that the driver provides?","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                constants.STATUS_ERROR)"},{"line_number":96,"context_line":"            if isinstance(e, exception.ShareResourceNotFound):"},{"line_number":97,"context_line":"                raise"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                raise exception.ManilaException(message\u003derror)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # NOTE(ganso): remove rules after maintenance is complete"},{"line_number":102,"context_line":"        if remove_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_15ab94d7","line":99,"range":{"start_line":98,"start_character":12,"end_line":99,"end_character":62},"in_reply_to":"3afc51ec_26784cc4","updated":"2016-03-14 14:04:30.000000000","message":"Done","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"             \u0027terminated_at\u0027: timeutils.utcnow()}"},{"line_number":642,"context_line":"        )"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        self.share_rpcapi.delete_share_instance(context, share_instance, force)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        # NOTE(u_glide): \u0027updated_at\u0027 timestamp is used to track last usage of"},{"line_number":647,"context_line":"        # share server. This is required for automatic share servers cleanup"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_864fa091","line":644,"range":{"start_line":644,"start_character":73,"end_line":644,"end_character":78},"updated":"2016-03-13 04:50:21.000000000","message":"this will work fine, but for clarity, can we pass this as a kwarg, like line 429?","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":641,"context_line":"             \u0027terminated_at\u0027: timeutils.utcnow()}"},{"line_number":642,"context_line":"        )"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        self.share_rpcapi.delete_share_instance(context, share_instance, force)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        # NOTE(u_glide): \u0027updated_at\u0027 timestamp is used to track last usage of"},{"line_number":647,"context_line":"        # share server. This is required for automatic share servers cleanup"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_159f1451","line":644,"range":{"start_line":644,"start_character":73,"end_line":644,"end_character":78},"in_reply_to":"3afc51ec_864fa091","updated":"2016-03-14 14:04:30.000000000","message":"Done","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"}],"manila/share/manager.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"74b156f1b110cb6f83d5016148f94f827dacbd4a","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            )"},{"line_number":1701,"context_line":"            self.driver.delete_share(context, share_instance,"},{"line_number":1702,"context_line":"                                     share_server\u003dshare_server)"},{"line_number":1703,"context_line":"        except exception.NotFound:"},{"line_number":1704,"context_line":"            LOG.warning(_LW(\"Share instance %s does not exist in the \""},{"line_number":1705,"context_line":"                            \"backend.\"), share_instance_id)"},{"line_number":1706,"context_line":"        except Exception:"},{"line_number":1707,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1708,"context_line":"                self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a3fc9ab8","line":1705,"range":{"start_line":1703,"start_character":8,"end_line":1705,"end_character":59},"updated":"2016-03-10 16:50:45.000000000","message":"If the share is not found, shouldn\u0027t the driver just deal with that and eat the exception? That way if no exception is raised, the manager can continue as if the backend did delete the share?","commit_id":"cd16d0b91c3e6ea7f4f29197efcdfeb11c4603ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d666406706d72e5b0fed0231e5406ea5363d7608","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            )"},{"line_number":1701,"context_line":"            self.driver.delete_share(context, share_instance,"},{"line_number":1702,"context_line":"                                     share_server\u003dshare_server)"},{"line_number":1703,"context_line":"        except exception.NotFound:"},{"line_number":1704,"context_line":"            LOG.warning(_LW(\"Share instance %s does not exist in the \""},{"line_number":1705,"context_line":"                            \"backend.\"), share_instance_id)"},{"line_number":1706,"context_line":"        except Exception:"},{"line_number":1707,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1708,"context_line":"                self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_e6650b45","line":1705,"range":{"start_line":1703,"start_character":8,"end_line":1705,"end_character":59},"in_reply_to":"5aef4532_a3fc9ab8","updated":"2016-03-10 18:44:04.000000000","message":"Please see updated patch. Thanks.","commit_id":"cd16d0b91c3e6ea7f4f29197efcdfeb11c4603ba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"            self.driver.delete_replica("},{"line_number":1203,"context_line":"                context, replica_list, share_replica,"},{"line_number":1204,"context_line":"                share_server\u003dshare_server)"},{"line_number":1205,"context_line":"        except Exception:"},{"line_number":1206,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1207,"context_line":"                if force:"},{"line_number":1208,"context_line":"                    msg \u003d _(\"The driver was unable to delete the share \""},{"line_number":1209,"context_line":"                            \"replica: %s on the backend. Since this \""},{"line_number":1210,"context_line":"                            \"operation is forced, the replica will be \""},{"line_number":1211,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""},{"line_number":1212,"context_line":"                            \"the backend may be necessary.\")"},{"line_number":1213,"context_line":"                    LOG.error(msg % share_replica[\u0027id\u0027])"},{"line_number":1214,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1215,"context_line":"                else:"},{"line_number":1216,"context_line":"                    self.db.share_replica_update("},{"line_number":1217,"context_line":"                        context, share_replica[\u0027id\u0027],"},{"line_number":1218,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR_DELETING,"},{"line_number":1219,"context_line":"                         \u0027replica_state\u0027: constants.STATUS_ERROR})"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"        self.db.share_replica_delete(context, share_replica[\u0027id\u0027])"},{"line_number":1222,"context_line":"        LOG.info(_LI(\"Share replica %s deleted successfully.\"),"},{"line_number":1223,"context_line":"                 share_replica[\u0027id\u0027])"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"    @add_hooks"},{"line_number":1226,"context_line":"    @utils.require_driver_initialized"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_6659b45a","line":1223,"range":{"start_line":1205,"start_character":0,"end_line":1223,"end_character":37},"updated":"2016-03-13 04:50:21.000000000","message":"see this use case.. it is very similar. We might want a similar log for consistency..","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"            self.driver.delete_replica("},{"line_number":1203,"context_line":"                context, replica_list, share_replica,"},{"line_number":1204,"context_line":"                share_server\u003dshare_server)"},{"line_number":1205,"context_line":"        except Exception:"},{"line_number":1206,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1207,"context_line":"                if force:"},{"line_number":1208,"context_line":"                    msg \u003d _(\"The driver was unable to delete the share \""},{"line_number":1209,"context_line":"                            \"replica: %s on the backend. Since this \""},{"line_number":1210,"context_line":"                            \"operation is forced, the replica will be \""},{"line_number":1211,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""},{"line_number":1212,"context_line":"                            \"the backend may be necessary.\")"},{"line_number":1213,"context_line":"                    LOG.error(msg % share_replica[\u0027id\u0027])"},{"line_number":1214,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1215,"context_line":"                else:"},{"line_number":1216,"context_line":"                    self.db.share_replica_update("},{"line_number":1217,"context_line":"                        context, share_replica[\u0027id\u0027],"},{"line_number":1218,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR_DELETING,"},{"line_number":1219,"context_line":"                         \u0027replica_state\u0027: constants.STATUS_ERROR})"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"        self.db.share_replica_delete(context, share_replica[\u0027id\u0027])"},{"line_number":1222,"context_line":"        LOG.info(_LI(\"Share replica %s deleted successfully.\"),"},{"line_number":1223,"context_line":"                 share_replica[\u0027id\u0027])"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"    @add_hooks"},{"line_number":1226,"context_line":"    @utils.require_driver_initialized"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_83c00b2c","line":1223,"range":{"start_line":1205,"start_character":0,"end_line":1223,"end_character":37},"in_reply_to":"3afc51ec_6659b45a","updated":"2016-03-14 14:04:30.000000000","message":"Done","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"396a7419ed4bf24116af91ab4e3589da94b50e6c","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            )"},{"line_number":1701,"context_line":"            self.driver.delete_share(context, share_instance,"},{"line_number":1702,"context_line":"                                     share_server\u003dshare_server)"},{"line_number":1703,"context_line":"        except exception.ShareResourceNotFound:"},{"line_number":1704,"context_line":"            LOG.warning(_LW(\"Share instance %s does not exist in the \""},{"line_number":1705,"context_line":"                            \"backend.\"), share_instance_id)"},{"line_number":1706,"context_line":"        except Exception:"},{"line_number":1707,"context_line":"            if force:"},{"line_number":1708,"context_line":"                LOG.exception(_LW(\"Failed to delete instance %s, deleting it \""},{"line_number":1709,"context_line":"                                  \"forcefully by removing from \""},{"line_number":1710,"context_line":"                                  \"DB.\"), share_instance_id)"},{"line_number":1711,"context_line":"            else:"},{"line_number":1712,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":1713,"context_line":"                    self.db.share_instance_update("},{"line_number":1714,"context_line":"                        context,"},{"line_number":1715,"context_line":"                        share_instance_id,"},{"line_number":1716,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR_DELETING})"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        self.db.share_instance_delete(context, share_instance_id)"},{"line_number":1719,"context_line":"        LOG.info(_LI(\"Share instance %s: deleted successfully.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_4656382a","line":1716,"range":{"start_line":1703,"start_character":0,"end_line":1716,"end_character":68},"updated":"2016-03-13 04:50:21.000000000","message":"\"force\u003dTrue\" should get rid of the share from the delete path, no matter what the exception.. see highlighted section and comment from delete_share_replica","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57f00664c9ff82d39e3fef7ad88e7b23304afa43","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            )"},{"line_number":1701,"context_line":"            self.driver.delete_share(context, share_instance,"},{"line_number":1702,"context_line":"                                     share_server\u003dshare_server)"},{"line_number":1703,"context_line":"        except exception.ShareResourceNotFound:"},{"line_number":1704,"context_line":"            LOG.warning(_LW(\"Share instance %s does not exist in the \""},{"line_number":1705,"context_line":"                            \"backend.\"), share_instance_id)"},{"line_number":1706,"context_line":"        except Exception:"},{"line_number":1707,"context_line":"            if force:"},{"line_number":1708,"context_line":"                LOG.exception(_LW(\"Failed to delete instance %s, deleting it \""},{"line_number":1709,"context_line":"                                  \"forcefully by removing from \""},{"line_number":1710,"context_line":"                                  \"DB.\"), share_instance_id)"},{"line_number":1711,"context_line":"            else:"},{"line_number":1712,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":1713,"context_line":"                    self.db.share_instance_update("},{"line_number":1714,"context_line":"                        context,"},{"line_number":1715,"context_line":"                        share_instance_id,"},{"line_number":1716,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR_DELETING})"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        self.db.share_instance_delete(context, share_instance_id)"},{"line_number":1719,"context_line":"        LOG.info(_LI(\"Share instance %s: deleted successfully.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_239ad763","line":1716,"range":{"start_line":1703,"start_character":0,"end_line":1716,"end_character":68},"in_reply_to":"3afc51ec_4656382a","updated":"2016-03-14 14:04:30.000000000","message":"Not sure if I understood everything you suggested, but I replicated as you suggested above, please take a look.","commit_id":"bdd36330dfbce7a70809048e344f6d557a04b360"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1bb58abdbd0387c423e20c0cabe514fbd8cfc79c","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"        except Exception:"},{"line_number":1705,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1706,"context_line":"                if force:"},{"line_number":1707,"context_line":"                    msg \u003d _(\"The driver was unable to delete access rules \""},{"line_number":1708,"context_line":"                            \"for the instance: %s. Will attempt to delete the \""},{"line_number":1709,"context_line":"                            \"instance anyway.\")"},{"line_number":1710,"context_line":"                    LOG.error(msg % share_instance_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_f0737a7e","line":1707,"range":{"start_line":1707,"start_character":26,"end_line":1707,"end_character":27},"updated":"2016-03-14 20:03:44.000000000","message":"s/_/_LE/","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f80e4ed543e10e836483b44478cc7f89176dcb2","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"        except Exception:"},{"line_number":1705,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1706,"context_line":"                if force:"},{"line_number":1707,"context_line":"                    msg \u003d _(\"The driver was unable to delete access rules \""},{"line_number":1708,"context_line":"                            \"for the instance: %s. Will attempt to delete the \""},{"line_number":1709,"context_line":"                            \"instance anyway.\")"},{"line_number":1710,"context_line":"                    LOG.error(msg % share_instance_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_bec0a37d","line":1707,"range":{"start_line":1707,"start_character":26,"end_line":1707,"end_character":27},"in_reply_to":"3afc51ec_f0737a7e","updated":"2016-03-14 20:44:33.000000000","message":"Done","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1bb58abdbd0387c423e20c0cabe514fbd8cfc79c","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"                    msg \u003d _(\"The driver was unable to delete access rules \""},{"line_number":1708,"context_line":"                            \"for the instance: %s. Will attempt to delete the \""},{"line_number":1709,"context_line":"                            \"instance anyway.\")"},{"line_number":1710,"context_line":"                    LOG.error(msg % share_instance_id)"},{"line_number":1711,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1712,"context_line":"                else:"},{"line_number":1713,"context_line":"                    self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_d06e3e95","line":1710,"range":{"start_line":1710,"start_character":34,"end_line":1710,"end_character":35},"updated":"2016-03-14 20:03:44.000000000","message":"comma","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f80e4ed543e10e836483b44478cc7f89176dcb2","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"                    msg \u003d _(\"The driver was unable to delete access rules \""},{"line_number":1708,"context_line":"                            \"for the instance: %s. Will attempt to delete the \""},{"line_number":1709,"context_line":"                            \"instance anyway.\")"},{"line_number":1710,"context_line":"                    LOG.error(msg % share_instance_id)"},{"line_number":1711,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1712,"context_line":"                else:"},{"line_number":1713,"context_line":"                    self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_5e387fa0","line":1710,"range":{"start_line":1710,"start_character":34,"end_line":1710,"end_character":35},"in_reply_to":"3afc51ec_d06e3e95","updated":"2016-03-14 20:44:33.000000000","message":"Done","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1bb58abdbd0387c423e20c0cabe514fbd8cfc79c","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"        except Exception:"},{"line_number":1725,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1726,"context_line":"                if force:"},{"line_number":1727,"context_line":"                    msg \u003d _(\"The driver was unable to delete the share \""},{"line_number":1728,"context_line":"                            \"instance: %s on the backend. Since this \""},{"line_number":1729,"context_line":"                            \"operation is forced, the instance will be \""},{"line_number":1730,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_30c0427b","line":1727,"range":{"start_line":1727,"start_character":26,"end_line":1727,"end_character":27},"updated":"2016-03-14 20:03:44.000000000","message":"s/_/_LE/","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f80e4ed543e10e836483b44478cc7f89176dcb2","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"        except Exception:"},{"line_number":1725,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":1726,"context_line":"                if force:"},{"line_number":1727,"context_line":"                    msg \u003d _(\"The driver was unable to delete the share \""},{"line_number":1728,"context_line":"                            \"instance: %s on the backend. Since this \""},{"line_number":1729,"context_line":"                            \"operation is forced, the instance will be \""},{"line_number":1730,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_3e3bf39d","line":1727,"range":{"start_line":1727,"start_character":26,"end_line":1727,"end_character":27},"in_reply_to":"3afc51ec_30c0427b","updated":"2016-03-14 20:44:33.000000000","message":"Done","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1bb58abdbd0387c423e20c0cabe514fbd8cfc79c","unresolved":false,"context_lines":[{"line_number":1729,"context_line":"                            \"operation is forced, the instance will be \""},{"line_number":1730,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""},{"line_number":1731,"context_line":"                            \"the backend may be necessary.\")"},{"line_number":1732,"context_line":"                    LOG.error(msg % share_instance_id)"},{"line_number":1733,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1734,"context_line":"                else:"},{"line_number":1735,"context_line":"                    self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_3057a2cf","line":1732,"range":{"start_line":1732,"start_character":34,"end_line":1732,"end_character":35},"updated":"2016-03-14 20:03:44.000000000","message":"comma","commit_id":"eca40c7be127964f339632817c940a56c409677d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f80e4ed543e10e836483b44478cc7f89176dcb2","unresolved":false,"context_lines":[{"line_number":1729,"context_line":"                            \"operation is forced, the instance will be \""},{"line_number":1730,"context_line":"                            \"deleted from Manila\u0027s database. A cleanup on \""},{"line_number":1731,"context_line":"                            \"the backend may be necessary.\")"},{"line_number":1732,"context_line":"                    LOG.error(msg % share_instance_id)"},{"line_number":1733,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":1734,"context_line":"                else:"},{"line_number":1735,"context_line":"                    self.db.share_instance_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_9e42070f","line":1732,"range":{"start_line":1732,"start_character":34,"end_line":1732,"end_character":35},"in_reply_to":"3afc51ec_3057a2cf","updated":"2016-03-14 20:44:33.000000000","message":"Done","commit_id":"eca40c7be127964f339632817c940a56c409677d"}]}
