)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"39ec75d3ad524eaf4e72628dfa8d3da71b7ef609","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                \u0027share_name\u0027: share_name,"},{"line_number":1196,"context_line":"                \u0027vserver\u0027: vserver,"},{"line_number":1197,"context_line":"            }"},{"line_number":1198,"context_line":"            raise netapp_api.NaApiError(message\u003dmsg % msg_args)"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        dm_session \u003d data_motion.DataMotionSession()"},{"line_number":1201,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_d1032672","line":1198,"range":{"start_line":1198,"start_character":29,"end_line":1198,"end_character":39},"updated":"2016-03-16 04:32:29.000000000","message":"Why are we synthesizing an API error in an upper layer?  Let\u0027s not do that unless we really need to make it look as though an API call failed.  There are other exceptions that reflect this condition.  And I\u0027m a little unclear how this change is relevant to the commit.","commit_id":"e8b4d948b75814070bbbef3e08fc05532616ac64"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"fd68cc3f3a95cff9df8ed7e0ca02d15c476a14cc","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"        if not vserver_client.volume_exists(share_name):"},{"line_number":1192,"context_line":"            msg \u003d _LE(\"Volume %(share_name)s does not exist on vserver \""},{"line_number":1193,"context_line":"                      \"%(vserver)s.\")"},{"line_number":1194,"context_line":"            msg_args \u003d {"},{"line_number":1195,"context_line":"                \u0027share_name\u0027: share_name,"},{"line_number":1196,"context_line":"                \u0027vserver\u0027: vserver,"},{"line_number":1197,"context_line":"            }"},{"line_number":1198,"context_line":"            raise exception.ShareNotFound(msg % msg_args)"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        dm_session \u003d data_motion.DataMotionSession()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_ba60cb36","line":1197,"range":{"start_line":1194,"start_character":12,"end_line":1197,"end_character":13},"updated":"2016-03-16 17:06:22.000000000","message":"Please unwrap in your next patch.  This fits on one line.","commit_id":"33f7dcd7b9c2a340fac5adf56e937a839f5ee016"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a67e743717efa87ab086057ff3d6ee641110ab00","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        vserver, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        if not vserver_client.volume_exists(share_name):"},{"line_number":1192,"context_line":"            msg \u003d _LE(\"Volume %(share_name)s does not exist on vserver \""},{"line_number":1193,"context_line":"                      \"%(vserver)s.\")"},{"line_number":1194,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name, \u0027vserver\u0027: vserver}"},{"line_number":1195,"context_line":"            raise exception.ShareResourceNotFound(msg % msg_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_03d16423","line":1192,"updated":"2016-03-17 15:55:56.000000000","message":"This should be _ instead of _LE because the message goes to an exception.","commit_id":"cb4d459ae57503ad383740e5debc1e4e81cf65c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4e2ccdf89dc84b163a526d4bdb29646dedcfa715","unresolved":false,"context_lines":[{"line_number":1172,"context_line":"        vserver, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        if not vserver_client.volume_exists(share_name):"},{"line_number":1175,"context_line":"            msg \u003d _LE(\"Volume %(share_name)s does not exist on vserver \""},{"line_number":1176,"context_line":"                      \"%(vserver)s.\")"},{"line_number":1177,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name, \u0027vserver\u0027: vserver}"},{"line_number":1178,"context_line":"            raise exception.ShareResourceNotFound(msg % msg_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_accde632","line":1175,"updated":"2016-03-18 02:46:19.000000000","message":"This is weird.  I know you fixed it in patch set 4, but this is coming back in patch set 5.  Probably a rebase error.  That\u0027s why my -1 came back automatically.  I was wondering why it showed -1 when I actually gave a +2 in patch set 4.","commit_id":"e253bc34d23d7a16dad720b8f9bd9570ccf7ffc0"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"39ec75d3ad524eaf4e72628dfa8d3da71b7ef609","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"                         \u0027_share_exists\u0027,"},{"line_number":2171,"context_line":"                         mock.Mock(return_value\u003dFalse))"},{"line_number":2172,"context_line":"        mock_dm_session \u003d mock.Mock()"},{"line_number":2173,"context_line":"        self.mock_object(data_motion, \"DataMotionSession\","},{"line_number":2174,"context_line":"                         mock.Mock(return_value\u003dmock_dm_session))"},{"line_number":2175,"context_line":"        self.mock_object(data_motion, \u0027get_client_for_backend\u0027)"},{"line_number":2176,"context_line":"        self.mock_object(mock_dm_session, \u0027get_vserver_from_share\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_514c36c7","line":2173,"range":{"start_line":2173,"start_character":38,"end_line":2173,"end_character":58},"updated":"2016-03-16 04:32:29.000000000","message":"This should be on the next line per the guidelines and for consistency with this file.  Same below.","commit_id":"e8b4d948b75814070bbbef3e08fc05532616ac64"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"39ec75d3ad524eaf4e72628dfa8d3da71b7ef609","unresolved":false,"context_lines":[{"line_number":2180,"context_line":"                                             [fake.SHARE],"},{"line_number":2181,"context_line":"                                             fake.SHARE,"},{"line_number":2182,"context_line":"                                             share_server\u003dNone)"},{"line_number":2183,"context_line":"        self.assertEqual(None, result)"},{"line_number":2184,"context_line":"        self.assertFalse(self.library._deallocate_container.called)"},{"line_number":2185,"context_line":"        mock_dm_session.delete_snapmirror.assert_called_with(fake.SHARE,"},{"line_number":2186,"context_line":"                                                             fake.SHARE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_f1d102cf","line":2183,"range":{"start_line":2183,"start_character":8,"end_line":2183,"end_character":38},"updated":"2016-03-16 04:32:29.000000000","message":"Blank line above this one, please.","commit_id":"e8b4d948b75814070bbbef3e08fc05532616ac64"}]}
