)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c8aa3cea74c2dcea8efb523fcc51be54314fed4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, HNAS driver allows creating snapshots on shares that"},{"line_number":10,"context_line":"do not exist on the backend anymore. Fixed this by verifying if"},{"line_number":11,"context_line":"the share exist and raising an error if it was deleted on the"},{"line_number":12,"context_line":"backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4881fd4304caf1d88e482ead913792b2fbbcac2c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afc51ec_18adafe9","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":15},"updated":"2016-03-12 20:26:44.000000000","message":"exists","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2826ee78d64dcbc0c69bfe476d6adeb1401477e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, HNAS driver allows creating snapshots on shares that"},{"line_number":10,"context_line":"do not exist on the backend anymore. Fixed this by verifying if"},{"line_number":11,"context_line":"the share exist and raising an error if it was deleted on the"},{"line_number":12,"context_line":"backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4881fd4304caf1d88e482ead913792b2fbbcac2c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afc51ec_8fdcb713","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":15},"in_reply_to":"3afc51ec_18adafe9","updated":"2016-03-14 12:16:42.000000000","message":"Done","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"}],"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"944a1b62405ee1cd4f7566d6e32ae5b1ee776cb9","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                    LOG.debug(\"Share %(path)s has more snapshots.\","},{"line_number":419,"context_line":"                              {\u0027path\u0027: path})"},{"line_number":420,"context_line":"                elif \u0027NotFound\u0027 in e.stderr:"},{"line_number":421,"context_line":"                    LOG.warning(_LW(\"Attempted to delete path %s but it does\""},{"line_number":422,"context_line":"                                    \"not exist.\"), path)"},{"line_number":423,"context_line":"                else:"},{"line_number":424,"context_line":"                    msg \u003d six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_d50049ad","line":421,"range":{"start_line":421,"start_character":75,"end_line":421,"end_character":77},"updated":"2016-03-11 18:09:36.000000000","message":"missing a space in message","commit_id":"83fa8c44acdff575b5a540e89faa66b6a8d47d05"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c758d3963955201b7be5b32d9c11251529c51dc7","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                    LOG.debug(\"Share %(path)s has more snapshots.\","},{"line_number":419,"context_line":"                              {\u0027path\u0027: path})"},{"line_number":420,"context_line":"                elif \u0027NotFound\u0027 in e.stderr:"},{"line_number":421,"context_line":"                    LOG.warning(_LW(\"Attempted to delete path %s but it does\""},{"line_number":422,"context_line":"                                    \"not exist.\"), path)"},{"line_number":423,"context_line":"                else:"},{"line_number":424,"context_line":"                    msg \u003d six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_d81a406e","line":421,"range":{"start_line":421,"start_character":75,"end_line":421,"end_character":77},"in_reply_to":"3afc51ec_d50049ad","updated":"2016-03-11 18:23:21.000000000","message":"Done","commit_id":"83fa8c44acdff575b5a540e89faa66b6a8d47d05"}],"manila/tests/share/drivers/hitachi/test_hds_hnas.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1f456d41ee317bcb1d00b65e3b4fc32192393ad8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        ssh.HNASSSHBackend.vvol_delete.assert_called_once_with(share[\u0027id\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_create_snapshot(self):"},{"line_number":242,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_ensure_share\", mock.Mock())"},{"line_number":243,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_get_hnas_share_id\","},{"line_number":244,"context_line":"                         mock.Mock(return_value\u003dshare[\u0027id\u0027]))"},{"line_number":245,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"get_host_list\", mock.Mock("}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_680a1ad4","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":77},"updated":"2016-03-13 21:33:45.000000000","message":"This is redundant.  If you just need an empty mock, omit the 3rd parameter and self.mock_object() will create one for you.  And you should clean up all the other ones in Newton.","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2826ee78d64dcbc0c69bfe476d6adeb1401477e8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        ssh.HNASSSHBackend.vvol_delete.assert_called_once_with(share[\u0027id\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_create_snapshot(self):"},{"line_number":242,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_ensure_share\", mock.Mock())"},{"line_number":243,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_get_hnas_share_id\","},{"line_number":244,"context_line":"                         mock.Mock(return_value\u003dshare[\u0027id\u0027]))"},{"line_number":245,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"get_host_list\", mock.Mock("}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_afe093cd","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":77},"in_reply_to":"3afc51ec_680a1ad4","updated":"2016-03-14 12:16:42.000000000","message":"Did not know that, done. Will clean others after RC1.","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1f456d41ee317bcb1d00b65e3b4fc32192393ad8","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                                      snapshot[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_create_snapshot_first_snapshot(self):"},{"line_number":262,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_ensure_share\", mock.Mock())"},{"line_number":263,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_get_hnas_share_id\","},{"line_number":264,"context_line":"                         mock.Mock(return_value\u003dshare[\u0027id\u0027]))"},{"line_number":265,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"get_host_list\", mock.Mock("}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_c80feedf","line":262,"range":{"start_line":262,"start_character":64,"end_line":262,"end_character":77},"updated":"2016-03-13 21:33:45.000000000","message":"Same below.","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2826ee78d64dcbc0c69bfe476d6adeb1401477e8","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                                      snapshot[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_create_snapshot_first_snapshot(self):"},{"line_number":262,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_ensure_share\", mock.Mock())"},{"line_number":263,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_get_hnas_share_id\","},{"line_number":264,"context_line":"                         mock.Mock(return_value\u003dshare[\u0027id\u0027]))"},{"line_number":265,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"get_host_list\", mock.Mock("}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_0fe8a7b3","line":262,"range":{"start_line":262,"start_character":64,"end_line":262,"end_character":77},"in_reply_to":"3afc51ec_c80feedf","updated":"2016-03-14 12:16:42.000000000","message":"Done","commit_id":"411d29142f509482362baa64dbff953b3a7f28dd"}]}
