)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d917b4a7782de2b03c4825c2aa13ad791c566501","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Ovchinnikov \u003caovchinnikov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-14 15:46:28 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for share race condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Original implementation of LXC/LXD driver was prone to race"},{"line_number":10,"context_line":"conditions due to incorrect share handling. This patch removes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afc51ec_3e1dc5bd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"updated":"2016-03-14 15:41:57.000000000","message":"This commit is driver-specific and should have LXD in the topic.","commit_id":"0c3fd6379af22f84ab0e9a68856cc07ea728bd3c"}],"manila/share/drivers/lxd.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"54f4eb6e560ce3618e49c8efc43ba007403f468e","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            self._restart_unfsd(server_id)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def update_access(self, share_name, server_id, access_rules, add_rules,"},{"line_number":362,"context_line":"                      delete_rules):"},{"line_number":363,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":364,"context_line":"            share_folder \u003d \"/shares/%s\" % share_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_bb7287ab","line":361,"range":{"start_line":361,"start_character":28,"end_line":361,"end_character":38},"updated":"2016-03-14 15:18:30.000000000","message":"I think this parameter is not correct, you are supplying a share, not share_name anymore... and you are using as if share_name was supplied.","commit_id":"0c3fd6379af22f84ab0e9a68856cc07ea728bd3c"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"56f8e9f38a4488b18b8ef7c7eadd2306f4933ce4","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            self._restart_unfsd(server_id)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def update_access(self, share_name, server_id, access_rules, add_rules,"},{"line_number":362,"context_line":"                      delete_rules):"},{"line_number":363,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":364,"context_line":"            share_folder \u003d \"/shares/%s\" % share_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_db595300","line":361,"range":{"start_line":361,"start_character":28,"end_line":361,"end_character":38},"in_reply_to":"3afc51ec_bb7287ab","updated":"2016-03-14 15:21:38.000000000","message":"Yes, thank you!","commit_id":"0c3fd6379af22f84ab0e9a68856cc07ea728bd3c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"54f4eb6e560ce3618e49c8efc43ba007403f468e","unresolved":false,"context_lines":[{"line_number":499,"context_line":"             user_to_allow]"},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def update_access(self, share_name, server_id, access_rules,"},{"line_number":503,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"},{"line_number":504,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":505,"context_line":"            # clean all hosts from allowed hosts list first."}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_d83cb9e4","line":502,"range":{"start_line":502,"start_character":28,"end_line":502,"end_character":38},"updated":"2016-03-14 15:18:30.000000000","message":"I think this parameter is not correct, you are supplying a share, not share_name anymore... and you are using as if share_name was supplied.","commit_id":"0c3fd6379af22f84ab0e9a68856cc07ea728bd3c"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"56f8e9f38a4488b18b8ef7c7eadd2306f4933ce4","unresolved":false,"context_lines":[{"line_number":499,"context_line":"             user_to_allow]"},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def update_access(self, share_name, server_id, access_rules,"},{"line_number":503,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"},{"line_number":504,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":505,"context_line":"            # clean all hosts from allowed hosts list first."}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_3b0037aa","line":502,"range":{"start_line":502,"start_character":28,"end_line":502,"end_character":38},"in_reply_to":"3afc51ec_d83cb9e4","updated":"2016-03-14 15:21:38.000000000","message":"Yes, thank you for pointing this out!","commit_id":"0c3fd6379af22f84ab0e9a68856cc07ea728bd3c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dcc61d547ecdfa922bad251b7dab141e9f40da5a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                      delete_rules):"},{"line_number":363,"context_line":"        share_name \u003d share.share_id"},{"line_number":364,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":365,"context_line":"            share_folder \u003d \"/shares/%s\" % share.share_id"},{"line_number":366,"context_line":"            delete_pattern \u003d \"\\$\" + share_folder + \".*$d\""},{"line_number":367,"context_line":"            self.lxd.execute_sync("},{"line_number":368,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_c1b4c4d2","line":365,"range":{"start_line":365,"start_character":42,"end_line":365,"end_character":56},"updated":"2016-03-14 15:53:17.000000000","message":"this looks pointless since you just assigned share.share_id to share_name. Please use share_name.","commit_id":"9bd3ef91339fa374fe5172c343f4041b63c1e220"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"3da4f298d228ba45e17ed3f9ed14199be50da606","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                      delete_rules):"},{"line_number":363,"context_line":"        share_name \u003d share.share_id"},{"line_number":364,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":365,"context_line":"            share_folder \u003d \"/shares/%s\" % share.share_id"},{"line_number":366,"context_line":"            delete_pattern \u003d \"\\$\" + share_folder + \".*$d\""},{"line_number":367,"context_line":"            self.lxd.execute_sync("},{"line_number":368,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_b50ef238","line":365,"range":{"start_line":365,"start_character":42,"end_line":365,"end_character":56},"in_reply_to":"3afc51ec_c1b4c4d2","updated":"2016-03-15 07:27:46.000000000","message":"Done","commit_id":"9bd3ef91339fa374fe5172c343f4041b63c1e220"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"33d51b8cc49573c1767ecacf8f75422b4b7e6f4c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":396,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":397,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":398,"context_line":"                self._deny_access(server_id, host_to_deny)"},{"line_number":399,"context_line":"            else:"},{"line_number":400,"context_line":"                LOG.warning(_LW(\"Attempt to use access type %s has been \""},{"line_number":401,"context_line":"                                \"blocked.\") % access_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_84e50caa","line":398,"range":{"start_line":398,"start_character":21,"end_line":398,"end_character":58},"updated":"2016-03-15 12:27:04.000000000","message":"In code line 324, _deny_access already add the parameter share. It is also should be added here. _deny_access(share, server_id, host_to_deny)","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"5e6ba2519c652fb239c25cc88b7f0e28851afb1e","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":396,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":397,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":398,"context_line":"                self._deny_access(server_id, host_to_deny)"},{"line_number":399,"context_line":"            else:"},{"line_number":400,"context_line":"                LOG.warning(_LW(\"Attempt to use access type %s has been \""},{"line_number":401,"context_line":"                                \"blocked.\") % access_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_4fdb1dee","line":398,"range":{"start_line":398,"start_character":21,"end_line":398,"end_character":58},"in_reply_to":"1af94dfe_84e50caa","updated":"2016-03-15 13:07:01.000000000","message":"Good catch, thank you!","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"33d51b8cc49573c1767ecacf8f75422b4b7e6f4c","unresolved":false,"context_lines":[{"line_number":459,"context_line":"             allowed_hosts]"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":463,"context_line":"                      access_level):"},{"line_number":464,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":465,"context_line":"            if self.conf.lxd_cifs_guest_ok !\u003d \"yes\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_44266417","line":462,"range":{"start_line":462,"start_character":28,"end_line":462,"end_character":38},"updated":"2016-03-15 12:27:04.000000000","message":"Why not change this too?","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"5e6ba2519c652fb239c25cc88b7f0e28851afb1e","unresolved":false,"context_lines":[{"line_number":459,"context_line":"             allowed_hosts]"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":463,"context_line":"                      access_level):"},{"line_number":464,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":465,"context_line":"            if self.conf.lxd_cifs_guest_ok !\u003d \"yes\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_cfed6d90","line":462,"range":{"start_line":462,"start_character":28,"end_line":462,"end_character":38},"in_reply_to":"1af94dfe_44266417","updated":"2016-03-15 13:07:01.000000000","message":"Done","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"33d51b8cc49573c1767ecacf8f75422b4b7e6f4c","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":543,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":544,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":545,"context_line":"                self._deny_access(server_id, host_to_deny)"},{"line_number":546,"context_line":"            else:"},{"line_number":547,"context_line":"                LOG.warning(_LW(\"Attempt to use access type %s has been \""},{"line_number":548,"context_line":"                                \"blocked.\") % access_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_043bbcec","line":545,"range":{"start_line":545,"start_character":21,"end_line":545,"end_character":58},"updated":"2016-03-15 12:27:04.000000000","message":"same above","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"5e6ba2519c652fb239c25cc88b7f0e28851afb1e","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":543,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":544,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":545,"context_line":"                self._deny_access(server_id, host_to_deny)"},{"line_number":546,"context_line":"            else:"},{"line_number":547,"context_line":"                LOG.warning(_LW(\"Attempt to use access type %s has been \""},{"line_number":548,"context_line":"                                \"blocked.\") % access_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_8f9365fa","line":545,"range":{"start_line":545,"start_character":21,"end_line":545,"end_character":58},"in_reply_to":"1af94dfe_043bbcec","updated":"2016-03-15 13:07:01.000000000","message":"Done","commit_id":"03cd8051cf5c471fb2b7fb1e705b2cbc1714b310"}]}
