)]}'
{"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if \u0027compression\u003doff\u0027 in self.dataset_creation_options:"},{"line_number":162,"context_line":"            self.common_capabilities[\u0027compression\u0027] \u003d [False]"},{"line_number":163,"context_line":"        elif any(\u0027compression\u003d\u0027 in option"},{"line_number":164,"context_line":"                 for option in self.dataset_creation_options):"},{"line_number":165,"context_line":"            self.common_capabilities[\u0027compression\u0027] \u003d [True]"},{"line_number":166,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_5d640521","line":163,"range":{"start_line":163,"start_character":18,"end_line":163,"end_character":30},"updated":"2016-03-17 07:26:15.000000000","message":"Seems like a more affirmative test for \"on\"|\"true\", etc.. would be better -- with somewhere catching invalid settings.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if \u0027compression\u003doff\u0027 in self.dataset_creation_options:"},{"line_number":162,"context_line":"            self.common_capabilities[\u0027compression\u0027] \u003d [False]"},{"line_number":163,"context_line":"        elif any(\u0027compression\u003d\u0027 in option"},{"line_number":164,"context_line":"                 for option in self.dataset_creation_options):"},{"line_number":165,"context_line":"            self.common_capabilities[\u0027compression\u0027] \u003d [True]"},{"line_number":166,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_41b7fbd7","line":163,"range":{"start_line":163,"start_character":18,"end_line":163,"end_character":30},"in_reply_to":"1af94dfe_5d640521","updated":"2016-03-17 11:45:59.000000000","message":"ZFS allows lots of different values to be set as compression. If we set \"off\" we disable, if we set \"on\" we enable default one. BUT, also we are free to set any of lots of possible other values. They can differ for different implementation of used ZFS. So, if there is wrong value, it will be seen on share creation step without waste of resources. It is said, that I do not add any checks for all possible values intentionally.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # ZFS dataset. So, we can consider it as"},{"line_number":171,"context_line":"        # \u0027always thin provisioned\u0027 because this driver never reserves"},{"line_number":172,"context_line":"        # space for dataset."},{"line_number":173,"context_line":"        self.common_capabilities[\u0027thin_provisioning\u0027] \u003d [True]"},{"line_number":174,"context_line":"        self.common_capabilities[\u0027qos\u0027] \u003d [False]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _get_zpool_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_63ea0411","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":51},"updated":"2016-03-17 07:26:15.000000000","message":"thin provisioning should add configurable max_over_subscription_ratio","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # ZFS dataset. So, we can consider it as"},{"line_number":171,"context_line":"        # \u0027always thin provisioned\u0027 because this driver never reserves"},{"line_number":172,"context_line":"        # space for dataset."},{"line_number":173,"context_line":"        self.common_capabilities[\u0027thin_provisioning\u0027] \u003d [True]"},{"line_number":174,"context_line":"        self.common_capabilities[\u0027qos\u0027] \u003d [False]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _get_zpool_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_a1f51fcc","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":51},"in_reply_to":"1af94dfe_63ea0411","updated":"2016-03-17 11:45:59.000000000","message":"It is taken from DEFAULT config group if not set up for driver. The way you propose makes admin be forced to define this opt in driver config group, else default value will be picked up. And value from \"DEFAULT\" group will not be used, that can be defined by admin explicitly. But ok, I will do so just for keeping same approach.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        dedupe_set \u003d False"},{"line_number":344,"context_line":"        dedupe \u003d extra_specs.get(\u0027dedupe\u0027)"},{"line_number":345,"context_line":"        if dedupe:"},{"line_number":346,"context_line":"            if (dedupe.lower() in (\u0027true\u0027, \u0027on\u0027, \u0027yes\u0027, \u00271\u0027) and"},{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_f8ba3f09","line":346,"range":{"start_line":346,"start_character":11,"end_line":346,"end_character":14},"updated":"2016-03-17 07:26:15.000000000","message":"Also \u0027\u003cis\u003e True\u0027 is the traditional and still supported way of setting boolean specs. These short-hand values were only added in M so I think the ugly \u0027\u003cis\u003e True\u0027 syntax should still be supported.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"71c0faaacc678207b9a3cadd490daacf69476c8b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        dedupe_set \u003d False"},{"line_number":344,"context_line":"        dedupe \u003d extra_specs.get(\u0027dedupe\u0027)"},{"line_number":345,"context_line":"        if dedupe:"},{"line_number":346,"context_line":"            if (dedupe.lower() in (\u0027true\u0027, \u0027on\u0027, \u0027yes\u0027, \u00271\u0027) and"},{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_68196579","line":346,"range":{"start_line":346,"start_character":16,"end_line":346,"end_character":60},"updated":"2016-03-16 15:41:27.000000000","message":"Can you use strutils.bool_from_string here?","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        dedupe_set \u003d False"},{"line_number":344,"context_line":"        dedupe \u003d extra_specs.get(\u0027dedupe\u0027)"},{"line_number":345,"context_line":"        if dedupe:"},{"line_number":346,"context_line":"            if (dedupe.lower() in (\u0027true\u0027, \u0027on\u0027, \u0027yes\u0027, \u00271\u0027) and"},{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_3d35b9f6","line":346,"range":{"start_line":346,"start_character":16,"end_line":346,"end_character":60},"in_reply_to":"1af94dfe_68196579","updated":"2016-03-17 07:26:15.000000000","message":"+1","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        dedupe_set \u003d False"},{"line_number":344,"context_line":"        dedupe \u003d extra_specs.get(\u0027dedupe\u0027)"},{"line_number":345,"context_line":"        if dedupe:"},{"line_number":346,"context_line":"            if (dedupe.lower() in (\u0027true\u0027, \u0027on\u0027, \u0027yes\u0027, \u00271\u0027) and"},{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_66104da9","line":346,"range":{"start_line":346,"start_character":11,"end_line":346,"end_character":14},"in_reply_to":"1af94dfe_f8ba3f09","updated":"2016-03-17 11:45:59.000000000","message":"Done","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"71c0faaacc678207b9a3cadd490daacf69476c8b","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"},{"line_number":350,"context_line":"            elif (dedupe.lower() in (\u0027false\u0027, \u0027off\u0027, \u0027no\u0027, \u00270\u0027) and"},{"line_number":351,"context_line":"                    False in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":352,"context_line":"                options.append(\u0027dedup\u003doff\u0027)"},{"line_number":353,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_e823b5a5","line":350,"range":{"start_line":350,"start_character":18,"end_line":350,"end_character":63},"updated":"2016-03-16 15:41:27.000000000","message":"same","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"},{"line_number":350,"context_line":"            elif (dedupe.lower() in (\u0027false\u0027, \u0027off\u0027, \u0027no\u0027, \u00270\u0027) and"},{"line_number":351,"context_line":"                    False in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":352,"context_line":"                options.append(\u0027dedup\u003doff\u0027)"},{"line_number":353,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_fd2b5192","line":350,"range":{"start_line":350,"start_character":18,"end_line":350,"end_character":63},"in_reply_to":"1af94dfe_e823b5a5","updated":"2016-03-17 07:26:15.000000000","message":"+1","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                    True in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"},{"line_number":350,"context_line":"            elif (dedupe.lower() in (\u0027false\u0027, \u0027off\u0027, \u0027no\u0027, \u00270\u0027) and"},{"line_number":351,"context_line":"                    False in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":352,"context_line":"                options.append(\u0027dedup\u003doff\u0027)"},{"line_number":353,"context_line":"                dedupe_set \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_860d9992","line":350,"range":{"start_line":350,"start_character":18,"end_line":350,"end_character":63},"in_reply_to":"1af94dfe_fd2b5192","updated":"2016-03-17 11:45:59.000000000","message":"Done","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"},{"line_number":350,"context_line":"            elif (dedupe.lower() in (\u0027false\u0027, \u0027off\u0027, \u0027no\u0027, \u00270\u0027) and"},{"line_number":351,"context_line":"                    False in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":352,"context_line":"                options.append(\u0027dedup\u003doff\u0027)"},{"line_number":353,"context_line":"                dedupe_set \u003d True"},{"line_number":354,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d897838e","line":351,"range":{"start_line":351,"start_character":19,"end_line":351,"end_character":34},"updated":"2016-03-17 07:26:15.000000000","message":"hmmm. Scheduler should make sure extra-spec in capabilities. So the \u0027and\u0027 here and above seem redundant and unfortunate, but maybe for now you need this to catch unhandled specs like \u0027\u003cis\u003e True\u0027","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                options.append(\u0027dedup\u003don\u0027)"},{"line_number":349,"context_line":"                dedupe_set \u003d True"},{"line_number":350,"context_line":"            elif (dedupe.lower() in (\u0027false\u0027, \u0027off\u0027, \u0027no\u0027, \u00270\u0027) and"},{"line_number":351,"context_line":"                    False in self.common_capabilities[\u0027dedupe\u0027]):"},{"line_number":352,"context_line":"                options.append(\u0027dedup\u003doff\u0027)"},{"line_number":353,"context_line":"                dedupe_set \u003d True"},{"line_number":354,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_e6c45d60","line":351,"range":{"start_line":351,"start_character":19,"end_line":351,"end_character":34},"in_reply_to":"1af94dfe_d897838e","updated":"2016-03-17 11:45:59.000000000","message":"Mark, driver supports both cases \"True\" and \"False\". So, if driver was picked up using some value for this extra spec, then driver should add appropriate option to created share. So, such logic is required always.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eb7705dd80a890b46aac11b8ce51468d1d58dd69","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                        \u0027allowed\u0027: self.common_capabilities[\u0027dedupe\u0027]})"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        compression_set \u003d False"},{"line_number":363,"context_line":"        compression_type \u003d extra_specs.get(\u0027zfsonlinux:compression\u0027)"},{"line_number":364,"context_line":"        if compression_type:"},{"line_number":365,"context_line":"            if (compression_type \u003d\u003d \u0027off\u0027 and"},{"line_number":366,"context_line":"                    False in self.common_capabilities[\u0027compression\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d8e823e5","line":363,"range":{"start_line":363,"start_character":8,"end_line":363,"end_character":24},"updated":"2016-03-17 07:26:15.000000000","message":"bool_from_string would be good here too","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"788b2df33d003169af432726d7fde8c6aed20dfe","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                        \u0027allowed\u0027: self.common_capabilities[\u0027dedupe\u0027]})"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        compression_set \u003d False"},{"line_number":363,"context_line":"        compression_type \u003d extra_specs.get(\u0027zfsonlinux:compression\u0027)"},{"line_number":364,"context_line":"        if compression_type:"},{"line_number":365,"context_line":"            if (compression_type \u003d\u003d \u0027off\u0027 and"},{"line_number":366,"context_line":"                    False in self.common_capabilities[\u0027compression\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_a6f535cc","line":363,"range":{"start_line":363,"start_character":8,"end_line":363,"end_character":24},"in_reply_to":"1af94dfe_d8e823e5","updated":"2016-03-17 11:45:59.000000000","message":"It is not boolean. It is qualified extra spec, specific to this driver. It has nothing to do with common \"compression\". It stores type of compression to be used if enabled. Common extra spec will influence only \"picking up\" some host with this driver.","commit_id":"5a8230be030e6e887d3efb87ed18736be8fc5b95"}]}
