)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"27abf2bed42ec8c01717edc9bc841c5ddeb3016f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1557071"},{"line_number":16,"context_line":"Related-Bug: #1546303"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia4cd2a36e31418e7a3d1c218080caa632755fe16"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1af94dfe_728b9e1f","line":17,"updated":"2016-03-18 13:35:24.000000000","message":"Add Depends-On: for tempest tests I269225b976efe13b2cbb9e0648d541a063df70e5 ?\n\nLooks like they are not tested with NetApp driver right now.","commit_id":"901fc187e712e5cfa07fb2531fc9a2e794bb6296"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"b0bd2e7ff7d184a2ff690a5af1ca09d33d7cdf0a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1557071"},{"line_number":16,"context_line":"Related-Bug: #1546303"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia4cd2a36e31418e7a3d1c218080caa632755fe16"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1af94dfe_b8afc57b","line":17,"in_reply_to":"1af94dfe_728b9e1f","updated":"2016-03-18 14:04:47.000000000","message":"We are not running the tests as part of CI, but I am running those manually. \nI will post the results of the tests for the latest patch.","commit_id":"901fc187e712e5cfa07fb2531fc9a2e794bb6296"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c38f78af17aa47848380cb5d72b897cdd88e0f1e","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"        active_snapshot[\u0027status\u0027] \u003d constants.STATUS_AVAILABLE"},{"line_number":1357,"context_line":"        active_snapshot[\u0027provider_location\u0027] \u003d snapshot_name"},{"line_number":1358,"context_line":"        snapshots \u003d [active_snapshot]"},{"line_number":1359,"context_line":"        instances \u003d zip(sorted(replica_list,"},{"line_number":1360,"context_line":"                               key\u003dlambda x: x[\u0027id\u0027]),"},{"line_number":1361,"context_line":"                        sorted(snapshot_instances,"},{"line_number":1362,"context_line":"                               key\u003dlambda x: x[\u0027share_id\u0027]))"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"        for replica, snapshot in instances:"},{"line_number":1365,"context_line":"            if snapshot[\u0027id\u0027] !\u003d active_snapshot[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_2508282d","line":1362,"range":{"start_line":1359,"start_character":24,"end_line":1362,"end_character":59},"updated":"2016-03-16 15:36:51.000000000","message":"Looks like sorting part is good candidate to be done in share manager.","commit_id":"d612d57e34f8039e8fecd29e3ff414af25a3f35b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c38f78af17aa47848380cb5d72b897cdd88e0f1e","unresolved":false,"context_lines":[{"line_number":1386,"context_line":"                             snapshot_name\u003dactive_snapshot[\u0027provider_location\u0027]"},{"line_number":1387,"context_line":"                             )"},{"line_number":1388,"context_line":"        active_snapshot[\u0027status\u0027] \u003d constants.STATUS_DELETED"},{"line_number":1389,"context_line":"        instances \u003d zip(sorted(replica_list,"},{"line_number":1390,"context_line":"                               key\u003dlambda x: x[\u0027id\u0027]),"},{"line_number":1391,"context_line":"                        sorted(snapshot_instances,"},{"line_number":1392,"context_line":"                               key\u003dlambda x: x[\u0027share_id\u0027]))"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        for replica, snapshot in instances:"},{"line_number":1395,"context_line":"            if snapshot[\u0027id\u0027] !\u003d active_snapshot[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_456e1430","line":1392,"range":{"start_line":1389,"start_character":8,"end_line":1392,"end_character":60},"updated":"2016-03-16 15:36:51.000000000","message":"Same here.","commit_id":"d612d57e34f8039e8fecd29e3ff414af25a3f35b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c38f78af17aa47848380cb5d72b897cdd88e0f1e","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"        share_name \u003d self._get_backend_share_name("},{"line_number":1411,"context_line":"            snapshot_instance[\u0027share_id\u0027])"},{"line_number":1412,"context_line":"        snapshot_name \u003d snapshot_instance.get(\u0027provider_location\u0027)"},{"line_number":1413,"context_line":"        # NOTE(ameade): If there is no provider location,"},{"line_number":1414,"context_line":"        # then grab from active snapshot instance"},{"line_number":1415,"context_line":"        if snapshot_name is None:"},{"line_number":1416,"context_line":"            active_snapshot \u003d [x for x in snapshot_instances"},{"line_number":1417,"context_line":"                               if x[\u0027share_id\u0027] \u003d\u003d active_replica[\u0027id\u0027]][0]"},{"line_number":1418,"context_line":"            snapshot_name \u003d active_snapshot.get(\u0027provider_location\u0027)"},{"line_number":1419,"context_line":"            if not snapshot_name:"},{"line_number":1420,"context_line":"                return"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        snapshot_exists \u003d vserver_client.snapshot_exists(snapshot_name,"},{"line_number":1423,"context_line":"                                                         share_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_e5a2c04a","line":1420,"range":{"start_line":1413,"start_character":7,"end_line":1420,"end_character":22},"updated":"2016-03-16 15:36:51.000000000","message":"Same here, as disscussed in IRC. Share manager should populate provider location after each creation of new replica. So, we will not have case when it is not set.","commit_id":"d612d57e34f8039e8fecd29e3ff414af25a3f35b"}]}