)]}'
{"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"39310cedc5f0b99d93bbb8d021d034e448d0ae01","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        for option in options:"},{"line_number":554,"context_line":"            self.zfs(\u0027set\u0027, option, dataset_name)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # Delete with retry as right after creation it may be temporary busy."},{"line_number":557,"context_line":"        self.execute_with_retry("},{"line_number":558,"context_line":"            \u0027sudo\u0027, \u0027zfs\u0027, \u0027destroy\u0027,"},{"line_number":559,"context_line":"            dataset_name + \u0027@\u0027 + snapshot_name.split(\u0027@\u0027)[-1])"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        return self._get_share_helper("},{"line_number":562,"context_line":"            share[\u0027share_proto\u0027]).create_exports(dataset_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_267b777c","line":559,"range":{"start_line":556,"start_character":0,"end_line":559,"end_character":62},"updated":"2016-03-19 12:48:47.000000000","message":"I will just assume this is necessary, it is not clear to me why exactly you are destroying the snapshot dataset.","commit_id":"b161889e3209921a06eee4ec6e1ec2377d1250ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"39310cedc5f0b99d93bbb8d021d034e448d0ae01","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                )"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        if access_rules:"},{"line_number":842,"context_line":"            # Apply access rules from original share"},{"line_number":843,"context_line":"            # TODO(vponomaryov): we should remove somehow rules that were"},{"line_number":844,"context_line":"            # deleted on active replica after creation of secondary replica."},{"line_number":845,"context_line":"            # For the moment there will be difference and it can be considered"},{"line_number":846,"context_line":"            # as a bug."},{"line_number":847,"context_line":"            self._get_share_helper(replica[\u0027share_proto\u0027]).update_access("},{"line_number":848,"context_line":"                dst_dataset_name, access_rules, add_rules\u003d[], delete_rules\u003d[],"},{"line_number":849,"context_line":"                make_all_ro\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_4694c389","line":846,"range":{"start_line":842,"start_character":12,"end_line":846,"end_character":23},"updated":"2016-03-19 12:48:47.000000000","message":"If rules are being copied by db.share_access_copy when replica is being created, any subsequent access to update_access should clear them. If this is a race condition, then it should be fixed in manager.","commit_id":"b161889e3209921a06eee4ec6e1ec2377d1250ba"}]}
