)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c46ce19358bd1180fa587f0741106b9817441af8","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            # Share doesn\u0027t exist, don\u0027t raise if it\u0027s being deleted anyway."},{"line_number":1051,"context_line":"            if share[\u0027status\u0027] \u003d\u003d constants.STATUS_DELETING:"},{"line_number":1052,"context_line":"                LOG.warning(_LW(\"Could not update access rules, share %s \""},{"line_number":1053,"context_line":"                                \"does not exist.\"), share[\u0027id\u0027])"},{"line_number":1054,"context_line":"            else:"},{"line_number":1055,"context_line":"                raise exception.ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])"},{"line_number":1056,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_3da5b9b4","line":1053,"updated":"2016-03-17 06:43:16.000000000","message":"this log message should probably be updated to better explain the DELETING situation","commit_id":"b5140c69aeac0bf59cfa092a8740960530618889"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b27d25e9afde36e08706ed04c0dffec5d9b345b0","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"            helper.set_client(vserver_client)"},{"line_number":1048,"context_line":"            helper.update_access(share, share_name, access_rules)"},{"line_number":1049,"context_line":"        else:"},{"line_number":1050,"context_line":"            # Share doesn\u0027t exist, don\u0027t raise if it\u0027s being deleted anyway."},{"line_number":1051,"context_line":"            if share[\u0027status\u0027] \u003d\u003d constants.STATUS_DELETING:"},{"line_number":1052,"context_line":"                LOG.warning(_LW(\"Could not update access rules, share %s \""},{"line_number":1053,"context_line":"                                \"does not exist.\"), share[\u0027id\u0027])"},{"line_number":1054,"context_line":"            else:"},{"line_number":1055,"context_line":"                raise exception.ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":1058,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8ecdab87","line":1055,"range":{"start_line":1050,"start_character":12,"end_line":1055,"end_character":75},"updated":"2016-03-17 11:48:01.000000000","message":"Even though this solution is acceptable, it is still not clear to me the difference in behavior between this approach and raising ShareResourceNotFound given the code below:\n\nhttps://github.com/openstack/manila/blob/master/manila/share/manager.py#L1700\n\nIf you always throw ShareResourceNotFound (no if/else condition as in your code), manager will do exactly what you are doing, it will swallow the exception and proceed. If it is not \"Deleting path\", as you are checking for such in share status, it will throw exception, just as are you doing, since manager is only swallowing the exception when deleting the share.\n\nThe only scenario which I think this is valid is if this library is used outside of Manila, which is what I understood based on our IRC conversation, but by using share[\u0027status\u0027] here I am assuming it will not be used outside of Manila Manager code path.\n\nSo I am still confused as why always throwing ShareResourceNotFound does not achieve the same behavior as you are implementing in your driver code. Please correct me if I am missing something.","commit_id":"b5140c69aeac0bf59cfa092a8740960530618889"}]}