)]}'
{"manila/share/drivers/helpers.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"0a2e563f59837162a4d43bfd5f105a8c9f20fbca","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            for access in delete_rules:"},{"line_number":207,"context_line":"                access[\u0027access_to\u0027] \u003d self._get_parsed_access_to("},{"line_number":208,"context_line":"                    access[\u0027access_to\u0027])"},{"line_number":209,"context_line":"                try:"},{"line_number":210,"context_line":"                    self.validate_access_rules("},{"line_number":211,"context_line":"                        [access], (\u0027ip\u0027,),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_90bc8bdd","line":208,"updated":"2016-03-17 19:20:01.000000000","message":"I think it is a bad idea to modify the rule here. A copy should be used instead. But I investigated a little and although these rules can be used later in access.py at least for now only the deleted rules \u0027id\u0027 is used. So it looks OK for now.","commit_id":"7bf936b9010cb7bbfe8412ea991be9bd6f8b0f80"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"0a2e563f59837162a4d43bfd5f105a8c9f20fbca","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                self._sync_nfs_temp_and_perm_files(server)"},{"line_number":226,"context_line":"            for access in add_rules:"},{"line_number":227,"context_line":"                access[\u0027access_to\u0027] \u003d self._get_parsed_access_to("},{"line_number":228,"context_line":"                    access[\u0027access_to\u0027])"},{"line_number":229,"context_line":"                found_item \u003d re.search("},{"line_number":230,"context_line":"                    re.escape(local_path) + \u0027[\\s\\n]*\u0027 + re.escape("},{"line_number":231,"context_line":"                        access[\u0027access_to\u0027]), out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_70a8df8d","line":228,"updated":"2016-03-17 19:20:01.000000000","message":"see above. It happens to apply a little more to delete_rules, but still seems harmless today.","commit_id":"7bf936b9010cb7bbfe8412ea991be9bd6f8b0f80"}]}
