)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"c3224e10bce0c5b2a5e8237b2e29e14f24c74cc3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"by invoking the scheduler to validate the host before invoking the"},{"line_number":12,"context_line":"backend manager."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8c780f2518f4a6eacf37cc448c73fbb41f6b7507"},{"line_number":17,"context_line":"Closes-bug: #1544725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af94dfe_05d5b1e6","line":14,"updated":"2016-03-18 15:03:35.000000000","message":"I don\u0027t see the API impact. RPC !\u003d API","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"826a9dd0c7c1b1774ae982646640596615d2c1d6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"by invoking the scheduler to validate the host before invoking the"},{"line_number":12,"context_line":"backend manager."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8c780f2518f4a6eacf37cc448c73fbb41f6b7507"},{"line_number":17,"context_line":"Closes-bug: #1544725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af94dfe_b5ea26d9","line":14,"in_reply_to":"1af94dfe_05d5b1e6","updated":"2016-03-18 16:15:59.000000000","message":"Okay I get that the response code changes under certain conditions","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"}],"manila/scheduler/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \"\"\"Ensure that the host exists and can accept the share.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def _manage_share_set_error(self, context, ex, request_spec):"},{"line_number":129,"context_line":"            self._set_share_state_and_notify("},{"line_number":130,"context_line":"                \u0027manage_share\u0027,"},{"line_number":131,"context_line":"                {\u0027status\u0027: constants.STATUS_MANAGE_ERROR},"},{"line_number":132,"context_line":"                context, ex, request_spec)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_824c33c9","line":129,"range":{"start_line":129,"start_character":17,"end_line":129,"end_character":44},"updated":"2016-03-18 04:30:53.000000000","message":"We\u0027re using notify.. but its broken.. we need to revert using it until we have proper notifications.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \"\"\"Ensure that the host exists and can accept the share.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def _manage_share_set_error(self, context, ex, request_spec):"},{"line_number":129,"context_line":"            self._set_share_state_and_notify("},{"line_number":130,"context_line":"                \u0027manage_share\u0027,"},{"line_number":131,"context_line":"                {\u0027status\u0027: constants.STATUS_MANAGE_ERROR},"},{"line_number":132,"context_line":"                context, ex, request_spec)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_6f229e53","line":129,"range":{"start_line":129,"start_character":17,"end_line":129,"end_character":44},"in_reply_to":"1af94dfe_824c33c9","updated":"2016-03-18 12:39:44.000000000","message":"I did not know it was broken, but is it causing any harm?","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            self.driver.host_passes_filters("},{"line_number":138,"context_line":"                context, share_ref[\u0027host\u0027], request_spec, filter_properties)"},{"line_number":139,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":140,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":141,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":142,"context_line":"        except Exception as ex:"},{"line_number":143,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_e28537cf","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":55},"updated":"2016-03-18 04:30:53.000000000","message":"We generally don\u0027t reraise the NoValidHost exception (Only the migrate_share_to_host method seems to be doing it).. because the traceback may be unnecessary..\n\nA good message would be helpful.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            self.driver.host_passes_filters("},{"line_number":138,"context_line":"                context, share_ref[\u0027host\u0027], request_spec, filter_properties)"},{"line_number":139,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":140,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":141,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":142,"context_line":"        except Exception as ex:"},{"line_number":143,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_4fe6c215","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":55},"in_reply_to":"1af94dfe_e28537cf","updated":"2016-03-18 12:39:44.000000000","message":"This exception is raised to the share.api.manage, so it is printing a good message there.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a08acc53132c332bb63714c3089946ddae39316d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            self.driver.host_passes_filters("},{"line_number":138,"context_line":"                context, share_ref[\u0027host\u0027], request_spec, filter_properties)"},{"line_number":139,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":140,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":141,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":142,"context_line":"        except Exception as ex:"},{"line_number":143,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":144,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            share_rpcapi.ShareAPI().manage_share(context, share_ref,"},{"line_number":147,"context_line":"                                                 driver_options)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_3e1b9382","line":144,"range":{"start_line":139,"start_character":0,"end_line":144,"end_character":72},"updated":"2016-03-18 17:19:55.000000000","message":"These two exception handling blocks are identical, so why do you need the first one?","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b434038ceefbf7adebdac6def90a4b72951405e4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            self.driver.host_passes_filters("},{"line_number":138,"context_line":"                context, share_ref[\u0027host\u0027], request_spec, filter_properties)"},{"line_number":139,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":140,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":141,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":142,"context_line":"        except Exception as ex:"},{"line_number":143,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":144,"context_line":"                _manage_share_set_error(self, context, ex, request_spec)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            share_rpcapi.ShareAPI().manage_share(context, share_ref,"},{"line_number":147,"context_line":"                                                 driver_options)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_c448e2b5","line":144,"range":{"start_line":139,"start_character":0,"end_line":144,"end_character":72},"in_reply_to":"1af94dfe_3e1b9382","updated":"2016-03-18 18:46:39.000000000","message":"Done","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"}],"manila/scheduler/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        1.3 - Add create_consistency_group method"},{"line_number":38,"context_line":"        1.4 - Add migrate_share_to_host method"},{"line_number":39,"context_line":"        1.5 - Add create_share_replica"},{"line_number":40,"context_line":"        1.6 - Add manage"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_a2316f5c","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":24},"updated":"2016-03-18 04:30:53.000000000","message":"manage_share","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        1.3 - Add create_consistency_group method"},{"line_number":38,"context_line":"        1.4 - Add migrate_share_to_host method"},{"line_number":39,"context_line":"        1.5 - Add create_share_replica"},{"line_number":40,"context_line":"        1.6 - Add manage"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d49b8716","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":24},"in_reply_to":"1af94dfe_a2316f5c","updated":"2016-03-18 12:39:44.000000000","message":"Done","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                     request_spec\u003dNone, filter_properties\u003dNone):"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.6\u0027)"},{"line_number":111,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":112,"context_line":"        return call_context.call(context, \u0027manage_share\u0027,"},{"line_number":113,"context_line":"                                 share_id\u003dshare_id,"},{"line_number":114,"context_line":"                                 driver_options\u003ddriver_options,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_824713bb","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":61},"updated":"2016-03-18 04:30:53.000000000","message":"you are making it primitive in share/api.py","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                     request_spec\u003dNone, filter_properties\u003dNone):"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.6\u0027)"},{"line_number":111,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":112,"context_line":"        return call_context.call(context, \u0027manage_share\u0027,"},{"line_number":113,"context_line":"                                 share_id\u003dshare_id,"},{"line_number":114,"context_line":"                                 driver_options\u003ddriver_options,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_f4bde368","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":61},"in_reply_to":"1af94dfe_824713bb","updated":"2016-03-18 12:39:44.000000000","message":"Done","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        share_type \u003d {}"},{"line_number":512,"context_line":"        share_type_id \u003d share_data[\u0027share_type_id\u0027]"},{"line_number":513,"context_line":"        if share_type_id:"},{"line_number":514,"context_line":"            share_type \u003d share_types.get_share_type(context, share_type_id)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        share_properties \u003d {"},{"line_number":517,"context_line":"            \u0027size\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_82f0b392","line":514,"range":{"start_line":514,"start_character":12,"end_line":514,"end_character":75},"updated":"2016-03-18 04:30:53.000000000","message":"The snapshot support extra spec needs to be updated on the share while it is getting created on the DB.. See, \n\nhttps://github.com/openstack/manila/blob/af16ca6799389a3ed1ad898ec6a14616d749d07b/manila/share/api.py#L226","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        share_type \u003d {}"},{"line_number":512,"context_line":"        share_type_id \u003d share_data[\u0027share_type_id\u0027]"},{"line_number":513,"context_line":"        if share_type_id:"},{"line_number":514,"context_line":"            share_type \u003d share_types.get_share_type(context, share_type_id)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        share_properties \u003d {"},{"line_number":517,"context_line":"            \u0027size\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_afbca606","line":514,"range":{"start_line":514,"start_character":12,"end_line":514,"end_character":75},"in_reply_to":"1af94dfe_82f0b392","updated":"2016-03-18 12:39:44.000000000","message":"Creating the share with proper snapshot_support value now.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \u0027user_id\u0027: share[\u0027user_id\u0027],"},{"line_number":519,"context_line":"            \u0027project_id\u0027: share[\u0027project_id\u0027],"},{"line_number":520,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":521,"context_line":"            \u0027snapshot_support\u0027: share[\u0027snapshot_support\u0027],"},{"line_number":522,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027],"},{"line_number":523,"context_line":"            \u0027share_type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":524,"context_line":"            \u0027is_public\u0027: share[\u0027is_public\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_22243fc3","line":521,"range":{"start_line":521,"start_character":32,"end_line":521,"end_character":57},"updated":"2016-03-18 04:30:53.000000000","message":"this field needs to be set from the share type.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \u0027user_id\u0027: share[\u0027user_id\u0027],"},{"line_number":519,"context_line":"            \u0027project_id\u0027: share[\u0027project_id\u0027],"},{"line_number":520,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":521,"context_line":"            \u0027snapshot_support\u0027: share[\u0027snapshot_support\u0027],"},{"line_number":522,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027],"},{"line_number":523,"context_line":"            \u0027share_type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":524,"context_line":"            \u0027is_public\u0027: share[\u0027is_public\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_0f44ba18","line":521,"range":{"start_line":521,"start_character":32,"end_line":521,"end_character":57},"in_reply_to":"1af94dfe_22243fc3","updated":"2016-03-18 12:39:44.000000000","message":"Creating the share with proper snapshot_support value now.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027]"},{"line_number":543,"context_line":"        }"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        try:"},{"line_number":546,"context_line":"            self.scheduler_rpcapi.manage_share(context, share[\u0027id\u0027],"},{"line_number":547,"context_line":"                                               driver_options, request_spec)"},{"line_number":548,"context_line":"        except Exception:"},{"line_number":549,"context_line":"            msg \u003d _(\u0027Host %(host)s did not pass validation for managing of \u0027"},{"line_number":550,"context_line":"                    \u0027share %(share)s with type %(type)s.\u0027) % {"},{"line_number":551,"context_line":"                \u0027host\u0027: share[\u0027host\u0027],"},{"line_number":552,"context_line":"                \u0027share\u0027: share[\u0027id\u0027],"},{"line_number":553,"context_line":"                \u0027type\u0027: share[\u0027share_type_id\u0027]}"},{"line_number":554,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":555,"context_line":"        return self.db.share_get(context, share[\u0027id\u0027])"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def unmanage(self, context, share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_02e5c3da","line":554,"range":{"start_line":545,"start_character":8,"end_line":554,"end_character":51},"updated":"2016-03-18 04:30:53.000000000","message":"You\u0027re expecting a message from the rpc layer, not the scheduler. this is an async message to the scheduler.. only the RPC can fail here.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027]"},{"line_number":543,"context_line":"        }"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        try:"},{"line_number":546,"context_line":"            self.scheduler_rpcapi.manage_share(context, share[\u0027id\u0027],"},{"line_number":547,"context_line":"                                               driver_options, request_spec)"},{"line_number":548,"context_line":"        except Exception:"},{"line_number":549,"context_line":"            msg \u003d _(\u0027Host %(host)s did not pass validation for managing of \u0027"},{"line_number":550,"context_line":"                    \u0027share %(share)s with type %(type)s.\u0027) % {"},{"line_number":551,"context_line":"                \u0027host\u0027: share[\u0027host\u0027],"},{"line_number":552,"context_line":"                \u0027share\u0027: share[\u0027id\u0027],"},{"line_number":553,"context_line":"                \u0027type\u0027: share[\u0027share_type_id\u0027]}"},{"line_number":554,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":555,"context_line":"        return self.db.share_get(context, share[\u0027id\u0027])"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def unmanage(self, context, share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_4f71a275","line":554,"range":{"start_line":545,"start_character":8,"end_line":554,"end_character":51},"in_reply_to":"1af94dfe_02e5c3da","updated":"2016-03-18 12:39:44.000000000","message":"it is synchronous because I am using call_context.call instead of call_context.cast, the exception is captured here.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a08acc53132c332bb63714c3089946ddae39316d","unresolved":false,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        share_instance \u003d share[\u0027instance\u0027]"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        share_properties \u003d {"},{"line_number":523,"context_line":"            \u0027size\u0027: 0,"},{"line_number":524,"context_line":"            \u0027user_id\u0027: share[\u0027user_id\u0027],"},{"line_number":525,"context_line":"            \u0027project_id\u0027: share[\u0027project_id\u0027],"},{"line_number":526,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":527,"context_line":"            \u0027snapshot_support\u0027: share_data[\u0027snapshot_support\u0027],"},{"line_number":528,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027],"},{"line_number":529,"context_line":"            \u0027share_type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":530,"context_line":"            \u0027is_public\u0027: share[\u0027is_public\u0027],"},{"line_number":531,"context_line":"            \u0027consistency_group_id\u0027: share[\u0027consistency_group_id\u0027],"},{"line_number":532,"context_line":"            \u0027source_cgsnapshot_member_id\u0027: share["},{"line_number":533,"context_line":"                \u0027source_cgsnapshot_member_id\u0027],"},{"line_number":534,"context_line":"            \u0027snapshot_id\u0027: share[\u0027snapshot_id\u0027],"},{"line_number":535,"context_line":"        }"},{"line_number":536,"context_line":"        share_instance_properties \u003d {"},{"line_number":537,"context_line":"            \u0027availability_zone_id\u0027: share_instance[\u0027availability_zone_id\u0027],"},{"line_number":538,"context_line":"            \u0027share_network_id\u0027: share_instance[\u0027share_network_id\u0027],"},{"line_number":539,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":540,"context_line":"            \u0027share_id\u0027: share_instance[\u0027share_id\u0027],"},{"line_number":541,"context_line":"            \u0027host\u0027: share_instance[\u0027host\u0027],"},{"line_number":542,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":543,"context_line":"        }"},{"line_number":544,"context_line":"        request_spec \u003d {"},{"line_number":545,"context_line":"            \u0027share_properties\u0027: share_properties,"},{"line_number":546,"context_line":"            \u0027share_instance_properties\u0027: share_instance_properties,"},{"line_number":547,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":548,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027]"},{"line_number":549,"context_line":"        }"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        try:"},{"line_number":552,"context_line":"            self.scheduler_rpcapi.manage_share(context, share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_89db937b","line":549,"range":{"start_line":522,"start_character":0,"end_line":549,"end_character":9},"updated":"2016-03-18 17:19:55.000000000","message":"This block is almost identical to that in migration_start.  I wonder if we could prevent future bugs by deduplicating this.","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b434038ceefbf7adebdac6def90a4b72951405e4","unresolved":false,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        share_instance \u003d share[\u0027instance\u0027]"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        share_properties \u003d {"},{"line_number":523,"context_line":"            \u0027size\u0027: 0,"},{"line_number":524,"context_line":"            \u0027user_id\u0027: share[\u0027user_id\u0027],"},{"line_number":525,"context_line":"            \u0027project_id\u0027: share[\u0027project_id\u0027],"},{"line_number":526,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":527,"context_line":"            \u0027snapshot_support\u0027: share_data[\u0027snapshot_support\u0027],"},{"line_number":528,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027],"},{"line_number":529,"context_line":"            \u0027share_type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":530,"context_line":"            \u0027is_public\u0027: share[\u0027is_public\u0027],"},{"line_number":531,"context_line":"            \u0027consistency_group_id\u0027: share[\u0027consistency_group_id\u0027],"},{"line_number":532,"context_line":"            \u0027source_cgsnapshot_member_id\u0027: share["},{"line_number":533,"context_line":"                \u0027source_cgsnapshot_member_id\u0027],"},{"line_number":534,"context_line":"            \u0027snapshot_id\u0027: share[\u0027snapshot_id\u0027],"},{"line_number":535,"context_line":"        }"},{"line_number":536,"context_line":"        share_instance_properties \u003d {"},{"line_number":537,"context_line":"            \u0027availability_zone_id\u0027: share_instance[\u0027availability_zone_id\u0027],"},{"line_number":538,"context_line":"            \u0027share_network_id\u0027: share_instance[\u0027share_network_id\u0027],"},{"line_number":539,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":540,"context_line":"            \u0027share_id\u0027: share_instance[\u0027share_id\u0027],"},{"line_number":541,"context_line":"            \u0027host\u0027: share_instance[\u0027host\u0027],"},{"line_number":542,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":543,"context_line":"        }"},{"line_number":544,"context_line":"        request_spec \u003d {"},{"line_number":545,"context_line":"            \u0027share_properties\u0027: share_properties,"},{"line_number":546,"context_line":"            \u0027share_instance_properties\u0027: share_instance_properties,"},{"line_number":547,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":548,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027]"},{"line_number":549,"context_line":"        }"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        try:"},{"line_number":552,"context_line":"            self.scheduler_rpcapi.manage_share(context, share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_5ed65a28","line":549,"range":{"start_line":522,"start_character":0,"end_line":549,"end_character":9},"in_reply_to":"1af94dfe_89db937b","updated":"2016-03-18 18:46:39.000000000","message":"Done","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a08acc53132c332bb63714c3089946ddae39316d","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                \u0027host\u0027: share[\u0027host\u0027],"},{"line_number":558,"context_line":"                \u0027share\u0027: share[\u0027id\u0027],"},{"line_number":559,"context_line":"                \u0027type\u0027: share[\u0027share_type_id\u0027]}"},{"line_number":560,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":561,"context_line":"        return self.db.share_get(context, share[\u0027id\u0027])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def unmanage(self, context, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_292fdf3f","line":560,"range":{"start_line":560,"start_character":28,"end_line":560,"end_character":39},"updated":"2016-03-18 17:19:55.000000000","message":"You\u0027re mapping all exceptions that could be caught here to InvalidHost.  But isn\u0027t that potentially misleading, if the host matches OK but something else blows up?  Perhaps here you need two except blocks (whereas you only need one in the scheduler code), one for InvalidHost and one for everything else.","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b434038ceefbf7adebdac6def90a4b72951405e4","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                \u0027host\u0027: share[\u0027host\u0027],"},{"line_number":558,"context_line":"                \u0027share\u0027: share[\u0027id\u0027],"},{"line_number":559,"context_line":"                \u0027type\u0027: share[\u0027share_type_id\u0027]}"},{"line_number":560,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":561,"context_line":"        return self.db.share_get(context, share[\u0027id\u0027])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def unmanage(self, context, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_04312a5a","line":560,"range":{"start_line":560,"start_character":28,"end_line":560,"end_character":39},"in_reply_to":"1af94dfe_292fdf3f","updated":"2016-03-18 18:46:39.000000000","message":"The sole purpose of scheduler is to validate the host, if it does, it calls manager through async RPC (from scheduler to manila-share). Before this patch, it was just an async call to manila-share without try/catch block, so only thing between is validation. Validation may fail (not pass) for several reasons, so the error message above is still correct.","commit_id":"986bc8dd21d8f3b4361df7363ec8964aef90cdb8"}],"manila/tests/scheduler/test_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"219a42cce282177702420ab53c16b1f921c14319","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        self.manager.manage_share(self.context, share[\u0027id\u0027], \u0027driver_options\u0027,"},{"line_number":255,"context_line":"                                  {}, None)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @ddt.data({\u0027exc\u0027: exception.NoValidHost(\u0027fake\u0027),"},{"line_number":258,"context_line":"               \u0027exc_class\u0027: exception.NoValidHost},"},{"line_number":259,"context_line":"              {\u0027exc\u0027: Exception(\u0027fake\u0027), \u0027exc_class\u0027: Exception})"},{"line_number":260,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_02e663af","line":257,"range":{"start_line":257,"start_character":32,"end_line":257,"end_character":43},"updated":"2016-03-18 04:30:53.000000000","message":"This exception should not be reraised.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bc03dd2a641fb1fbffd227db681151bbbf6e263","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        self.manager.manage_share(self.context, share[\u0027id\u0027], \u0027driver_options\u0027,"},{"line_number":255,"context_line":"                                  {}, None)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @ddt.data({\u0027exc\u0027: exception.NoValidHost(\u0027fake\u0027),"},{"line_number":258,"context_line":"               \u0027exc_class\u0027: exception.NoValidHost},"},{"line_number":259,"context_line":"              {\u0027exc\u0027: Exception(\u0027fake\u0027), \u0027exc_class\u0027: Exception})"},{"line_number":260,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_cf8e522d","line":257,"range":{"start_line":257,"start_character":32,"end_line":257,"end_character":43},"in_reply_to":"1af94dfe_02e663af","updated":"2016-03-18 12:39:44.000000000","message":"it is re-raised so share.api.manage can capture it. If I do not re-raise this, I need to expect it to return something, like boolean False.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"ec4c042d586427adc7d721e99cf6b4edbd9eba60","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        self.manager.manage_share(self.context, share[\u0027id\u0027], \u0027driver_options\u0027,"},{"line_number":255,"context_line":"                                  {}, None)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @ddt.data({\u0027exc\u0027: exception.NoValidHost(\u0027fake\u0027),"},{"line_number":258,"context_line":"               \u0027exc_class\u0027: exception.NoValidHost},"},{"line_number":259,"context_line":"              {\u0027exc\u0027: Exception(\u0027fake\u0027), \u0027exc_class\u0027: Exception})"},{"line_number":260,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_f244ce4a","line":257,"range":{"start_line":257,"start_character":32,"end_line":257,"end_character":43},"in_reply_to":"1af94dfe_cf8e522d","updated":"2016-03-18 13:29:42.000000000","message":"I didn\u0027t realize an exception could be passed over RPC.  But as a general rule, raising an exception is almost always preferable to returning a boolean.","commit_id":"3aedd47630b2f27574f28f950d14b393c0f4fb1c"}]}
