)]}'
{"doc/source/devref/cephfs_native_driver.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"22b57bad8fc964574790120f65d2cf1272a0d009","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- Allow/deny CephFS share access"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  * ``cephx`` access type is supported for CephFS protocol."},{"line_number":30,"context_line":"  * Read/write is supported."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Extend/shrink share"},{"line_number":33,"context_line":"- Create/delete snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_c51ea462","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":15},"updated":"2016-03-22 03:15:18.000000000","message":"Only Read/write access level is supported.","commit_id":"a40caa1929500e19de574735e7e14a045eda7dc3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"41e860a3e7809b0e8ee7c0a280619d50c93d1ad9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- Allow/deny CephFS share access"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  * ``cephx`` access type is supported for CephFS protocol."},{"line_number":30,"context_line":"  * Read/write is supported."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Extend/shrink share"},{"line_number":33,"context_line":"- Create/delete snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_b1bad208","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":15},"in_reply_to":"fa0719c6_c51ea462","updated":"2016-03-22 06:32:05.000000000","message":"Done","commit_id":"a40caa1929500e19de574735e7e14a045eda7dc3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"22b57bad8fc964574790120f65d2cf1272a0d009","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":201,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"},{"line_number":202,"context_line":"  share.  Shares cannot be created from snapshots."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_85402ca7","line":202,"range":{"start_line":202,"start_character":50,"end_line":202,"end_character":50},"updated":"2016-03-22 03:15:18.000000000","message":"Better to add the Module, such as:\n\nThe :mod:`manila.share.drivers.cephfs.cephfs_native.CephFSNativeDriver` Module\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n...\n\nhttps://github.com/openstack/manila/blob/master/doc/source/devref/generic_driver.rst#the-modmanilasharedriversgeneric-module","commit_id":"a40caa1929500e19de574735e7e14a045eda7dc3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"41e860a3e7809b0e8ee7c0a280619d50c93d1ad9","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":201,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"},{"line_number":202,"context_line":"  share.  Shares cannot be created from snapshots."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_51425611","line":202,"range":{"start_line":202,"start_character":50,"end_line":202,"end_character":50},"in_reply_to":"fa0719c6_85402ca7","updated":"2016-03-22 06:32:05.000000000","message":"Done","commit_id":"a40caa1929500e19de574735e7e14a045eda7dc3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d5fc6dde4f853315a060005aaadd9bb74881ddbe","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  When a user"},{"line_number":25,"context_line":"requests access to a share for an ID, Ceph creates a corresponding Ceph auth ID"},{"line_number":26,"context_line":"and a secret key, if they does not already exist, and authorizes the ID to"},{"line_number":27,"context_line":"access the share.  The client can then mount the share using the ID and the"},{"line_number":28,"context_line":"secret key."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_52d7a64a","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":30},"updated":"2016-03-23 12:48:39.000000000","message":"they does?","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"ec1036e19e6dc830f152e21ef99f087f046accb3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  When a user"},{"line_number":25,"context_line":"requests access to a share for an ID, Ceph creates a corresponding Ceph auth ID"},{"line_number":26,"context_line":"and a secret key, if they does not already exist, and authorizes the ID to"},{"line_number":27,"context_line":"access the share.  The client can then mount the share using the ID and the"},{"line_number":28,"context_line":"secret key."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba0121b8_6f722ee7","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":30},"in_reply_to":"fa0719c6_52d7a64a","updated":"2016-03-29 11:53:52.000000000","message":"Done","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d5fc6dde4f853315a060005aaadd9bb74881ddbe","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. code-block:: console"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c ~/mnt"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_12a9ae7b","line":196,"range":{"start_line":196,"start_character":49,"end_line":196,"end_character":79},"updated":"2016-03-23 12:48:39.000000000","message":"Please, split this line to several sublines.","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"ec1036e19e6dc830f152e21ef99f087f046accb3","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. code-block:: console"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c ~/mnt"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba0121b8_2f4f9693","line":196,"range":{"start_line":196,"start_character":49,"end_line":196,"end_character":79},"in_reply_to":"fa0719c6_12a9ae7b","updated":"2016-03-29 11:53:52.000000000","message":"Done","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b546cdd0775dd3a15552dc6a1d1faa9d31db7460","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c ~/mnt"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Known restrictions"},{"line_number":200,"context_line":"------------------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Mitaka release"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_59dc31e4","line":199,"updated":"2016-03-22 12:18:05.000000000","message":"Can we add a section about \"security\" restrictions? It\u0027s important to highlight that every tenant has a full connection to the underling ceph cluster.  Means it\u0027s possible to DoS it and bring it down. This can be very tricky if ceph is also used as RBD block store.","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2af8b1c401685821829a9fb691692d4f9698a1f4","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c ~/mnt"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Known restrictions"},{"line_number":200,"context_line":"------------------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Mitaka release"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_05435543","line":199,"in_reply_to":"fa0719c6_59dc31e4","updated":"2016-03-22 16:55:56.000000000","message":"I\u0027d suggest reviewing this patch on its own merits: adding more security guidance could be a separate change.  I agree that we could add more here, but I don\u0027t think that\u0027s a reason to -1 the other stuff added in this patch.","commit_id":"dac8856fd8d32d1ef14c1162b46bb56db90ae357"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4c780991c8ebef70eb2f1e62ba7ff91f825f2ee1","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. code-block:: console"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring \\"},{"line_number":197,"context_line":"    --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c\\"},{"line_number":198,"context_line":"     ~/mnt"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_4a4d9871","line":198,"range":{"start_line":196,"start_character":4,"end_line":198,"end_character":10},"updated":"2016-03-29 11:57:47.000000000","message":"Maybe so? One line - one optional arg.\n\"\"\"\nsudo ceph-fuse ~/mnt \\\n    --id\u003dalice --conf\u003d./ceph.conf \\\n    --keyring\u003d./alice.keyring \\\n    --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c\n\"\"\"","commit_id":"7d5312e7d69111390ce4bbab9acfe9783ec0ca90"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"da441cfbaa453d29439c0896f1b881ed54cae6d3","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. code-block:: console"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sudo ceph-fuse --id\u003dalice --conf\u003d./ceph.conf --keyring\u003d./alice.keyring \\"},{"line_number":197,"context_line":"    --client-mountpoint\u003d/volumes/_nogroup/4c55ad20-9c55-4a5e-9233-8ac64566b98c\\"},{"line_number":198,"context_line":"     ~/mnt"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_2a7e64e4","line":198,"range":{"start_line":196,"start_character":4,"end_line":198,"end_character":10},"in_reply_to":"ba0121b8_4a4d9871","updated":"2016-03-29 12:07:42.000000000","message":"Done","commit_id":"7d5312e7d69111390ce4bbab9acfe9783ec0ca90"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_208f40cd","line":76,"updated":"2016-03-30 21:37:16.000000000","message":"Wow, this is quite a mouthful :-)\n\nI played around with doing:\n\n$ read -r -d \u0027\u0027 AUTH \u003c\u003c-EOF\n\u0027allow r;\nallow command \"auth del\" with entity perifx client.manila;\n... (etc)\nEOF\ncep auth get-or-create client.manila mon $AUTH ... \u003e keyring.manila\n\nwith hopes of making the magic here more transparent but I\u0027m getting some kind of parse errors on my quotes.\n\nAnyways, if there *is* a way to break this magic out a bit so that it is more comprehensible that would be great.  Otherwise, let\u0027s just make sure that if you cut and paste this one-liner it really works :-)","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"45c82e1390f0ef703bf0819ac47be714ce5ececd","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_cf4aa954","line":76,"in_reply_to":"ba0121b8_208f40cd","updated":"2016-04-20 20:53:09.000000000","message":"Done","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_7591dbf0","line":76,"in_reply_to":"ba0121b8_208f40cd","updated":"2016-03-31 12:08:39.000000000","message":"Fair point, but this is more of a comment about the original file before Ramana\u0027s changes than it is about the patch under review.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4537abd750bff43f76a52f551a52217f1f423639","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_3fea9dac","line":76,"in_reply_to":"ba0121b8_208f40cd","updated":"2016-03-31 13:47:03.000000000","message":"The command works for me if I just and copy paste it as is, and execute with root privileges.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_e10cbc3d","line":76,"in_reply_to":"ba0121b8_3fea9dac","updated":"2016-04-01 19:50:03.000000000","message":"Should line 72 say \"Run the following command with root privileges ...\"?","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_1e5aed50","line":76,"in_reply_to":"ba0121b8_7591dbf0","updated":"2016-04-01 19:50:03.000000000","message":"Agreed.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"},{"line_number":80,"context_line":"these configured in your manila.conf."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Enable snapshots in Ceph if you want to use them in manila:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_e076e8d5","line":80,"updated":"2016-03-30 21:37:16.000000000","message":"maybe: \"... and the paths to these configured in your manila.conf as illustrated in the next section.\"\n\nExcept I don\u0027t see the keyring configured there.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"45c82e1390f0ef703bf0819ac47be714ce5ececd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"},{"line_number":80,"context_line":"these configured in your manila.conf."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Enable snapshots in Ceph if you want to use them in manila:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_6f3f15b4","line":80,"in_reply_to":"ba0121b8_e076e8d5","updated":"2016-04-20 20:53:09.000000000","message":"Done","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4537abd750bff43f76a52f551a52217f1f423639","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":79,"context_line":"on the server where the :term:`manila-share` service runs, and the paths to"},{"line_number":80,"context_line":"these configured in your manila.conf."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Enable snapshots in Ceph if you want to use them in manila:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_ba61a23b","line":80,"in_reply_to":"ba0121b8_e076e8d5","updated":"2016-03-31 13:47:03.000000000","message":"Nice catch! The keyring file path would have to be configured in ceph\u0027s configuration file or be the default path, /etc/ceph/ceph.client.manila.keyring. The cephfs native driver does not make the keyring file path configurable.\n\nAlso, see John\u0027s reply in line 111 below.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":109,"context_line":"    cephfs_auth_id \u003d manila"},{"line_number":110,"context_line":"    cephfs_cluster_name \u003d ceph"},{"line_number":111,"context_line":"    cephfs_enable_snapshots \u003d True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Set ``cephfs_enable_snapshots`` to True in the section to let the driver"},{"line_number":114,"context_line":"perform snapshot related operations."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_e02428c6","line":111,"updated":"2016-03-30 21:37:16.000000000","message":"I\u0027m not seeing how the keyring info is picked up.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":109,"context_line":"    cephfs_auth_id \u003d manila"},{"line_number":110,"context_line":"    cephfs_cluster_name \u003d ceph"},{"line_number":111,"context_line":"    cephfs_enable_snapshots \u003d True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Set ``cephfs_enable_snapshots`` to True in the section to let the driver"},{"line_number":114,"context_line":"perform snapshot related operations."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_d5b267e4","line":111,"in_reply_to":"ba0121b8_e02428c6","updated":"2016-03-31 12:08:39.000000000","message":"Ceph guesses keyring path based on user ID if it\u0027s not specified.  However, we didn\u0027t tell the user the magic place to put the keyring, so they probably need an explicit one here.\n\nAlso, while we\u0027re telling them to install the keyring, we should probably also remind them to set permissions on it such that manila-share can read it.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    cephfs_enable_snapshots \u003d True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Set ``cephfs_enable_snapshots`` to True in the section to let the driver"},{"line_number":114,"context_line":"perform snapshot related operations."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":117,"context_line":"using the section name.  In this example we are also including another backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_88bad16c","line":114,"updated":"2016-03-30 21:37:16.000000000","message":"Is there downside to having ``cephfs_enable_snapshots`` True that the reader needs to be aware of?  If not, it is somewhat puzzling that the default is False, or even that there is an option at all.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    cephfs_enable_snapshots \u003d True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Set ``cephfs_enable_snapshots`` to True in the section to let the driver"},{"line_number":114,"context_line":"perform snapshot related operations."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":117,"context_line":"using the section name.  In this example we are also including another backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_95c0ef51","line":114,"in_reply_to":"ba0121b8_88bad16c","updated":"2016-03-31 12:08:39.000000000","message":"It\u0027s optional because other folks wanted it that way when the driver was in review: because Ceph doesn\u0027t implement snapshot cloning, we have partial snapshot support, so don\u0027t enable it by default to (perhaps) avoid confusion.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    cephfs_enable_snapshots \u003d True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Set ``cephfs_enable_snapshots`` to True in the section to let the driver"},{"line_number":114,"context_line":"perform snapshot related operations."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":117,"context_line":"using the section name.  In this example we are also including another backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_813340f6","line":114,"in_reply_to":"ba0121b8_95c0ef51","updated":"2016-04-01 19:50:03.000000000","message":"Thanks for the explanation.  Nothing to do here I guess :)","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Allowing access to shares"},{"line_number":154,"context_line":"--------------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Allow user ID ``alice`` access to the share using ``cephx`` access type."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. code-block:: console"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_635f9ee5","line":156,"updated":"2016-03-30 21:37:16.000000000","message":"Maybe:  \"Allow ceph auth ID ``alice`` ...\"","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4537abd750bff43f76a52f551a52217f1f423639","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Allowing access to shares"},{"line_number":154,"context_line":"--------------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Allow user ID ``alice`` access to the share using ``cephx`` access type."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. code-block:: console"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_10950d86","line":156,"in_reply_to":"ba0121b8_635f9ee5","updated":"2016-03-31 13:47:03.000000000","message":"Agree. Thanks!","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"45c82e1390f0ef703bf0819ac47be714ce5ececd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Allowing access to shares"},{"line_number":154,"context_line":"--------------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Allow user ID ``alice`` access to the share using ``cephx`` access type."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. code-block:: console"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_af45ad43","line":156,"in_reply_to":"ba0121b8_635f9ee5","updated":"2016-04-20 20:53:09.000000000","message":"Done","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    out of band of manila.  You can refer the link below to see how the admin"},{"line_number":178,"context_line":"    can obtain the secret key of an ID."},{"line_number":179,"context_line":"    http://docs.ceph.com/docs/jewel/rados/operations/user-management/#get-a-user"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Using the mon IP addresses from the share\u0027s export location, create a"},{"line_number":182,"context_line":"configuration file, ``ceph.conf`` like:"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_e00b8828","line":180,"updated":"2016-03-30 21:37:16.000000000","message":"see my remark below in known-restrictions","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    [client]"},{"line_number":187,"context_line":"            client quota \u003d true"},{"line_number":188,"context_line":"            mon host \u003d 192.168.1.7:6789, 192.168.1.8:6789, 192.168.1.9:6789"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Finally, mount the filesystem, substituting the filenames of the keyring and"},{"line_number":191,"context_line":"configuration files you just created, and substituting the path to be mounted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_c8696927","line":188,"updated":"2016-03-30 21:37:16.000000000","message":"Can we use RFC5737 [1] addresses here?\n\n[1] https://tools.ietf.org/html/rfc5737","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4537abd750bff43f76a52f551a52217f1f423639","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    [client]"},{"line_number":187,"context_line":"            client quota \u003d true"},{"line_number":188,"context_line":"            mon host \u003d 192.168.1.7:6789, 192.168.1.8:6789, 192.168.1.9:6789"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Finally, mount the filesystem, substituting the filenames of the keyring and"},{"line_number":191,"context_line":"configuration files you just created, and substituting the path to be mounted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_eabce5bc","line":188,"in_reply_to":"ba0121b8_c8696927","updated":"2016-03-31 13:47:03.000000000","message":"I\u0027m not sure. We\u0027d like the user to substitute a part of the export location as it appears to her. You can see line 150 to see how a share\u0027s export location appears to the user.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    [client]"},{"line_number":187,"context_line":"            client quota \u003d true"},{"line_number":188,"context_line":"            mon host \u003d 192.168.1.7:6789, 192.168.1.8:6789, 192.168.1.9:6789"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Finally, mount the filesystem, substituting the filenames of the keyring and"},{"line_number":191,"context_line":"configuration files you just created, and substituting the path to be mounted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_816180d6","line":188,"in_reply_to":"ba0121b8_eabce5bc","updated":"2016-04-01 19:50:03.000000000","message":"Well the idea is that you use RFC5737 addrs in doc (and e.g. unit tests) so that people won\u0027t copy them literally and have them work in unintended ways.  Not a biggie for me in this context though.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":210,"context_line":" deployments."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"- The secret-key required to mount a share is not exposed by manila APIs.  It"},{"line_number":213,"context_line":"  needs to be shared with the guest by the Ceph admin out of band of manila."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_03a686ad","line":213,"updated":"2016-03-30 21:37:16.000000000","message":"The following remark is more for the roadmap rather than for revising this document: I understand that this is not really a Ceph or CephFS issue per se, but nonetheless I think it is an important issue for making CephFS a successful manila backend. Requiring secret-key to mount a share is great b/c it provides a means of tenant-isolation without the complexities of managing share networks.  That said, without an automated means of distributing these keys to tenants so that they can mount a share from a guest much of the value proposition OpenStack offers of having a \"dashboard\" (or more generally api) that tenants can use to do one-stop provisioning of cloud resources is IMO defeated.\n\nI\u0027d love to be wrong about this, but otherwise I think the issue needs some thought going forwards.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":210,"context_line":" deployments."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"- The secret-key required to mount a share is not exposed by manila APIs.  It"},{"line_number":213,"context_line":"  needs to be shared with the guest by the Ceph admin out of band of manila."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_7018c91e","line":213,"in_reply_to":"ba0121b8_03a686ad","updated":"2016-03-31 12:08:39.000000000","message":"There\u0027s been a fair bit of thought on this, see previous design summit notes and https://wiki.openstack.org/wiki/Manila/design/manila-auth-access-keys\n\nNote that getting keys to the tenant (i.e. returning them from the Manila API) is a separate issue from how the tenant should put these keys (or mount commands generally) into his guest VMs.\n\nMailing list would be better than gerrit comments for these kinds of things, I\u0027d rather use gerrit for discussing the merits of the patch under review.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4537abd750bff43f76a52f551a52217f1f423639","unresolved":false,"context_lines":[{"line_number":210,"context_line":" deployments."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"- The secret-key required to mount a share is not exposed by manila APIs.  It"},{"line_number":213,"context_line":"  needs to be shared with the guest by the Ceph admin out of band of manila."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_e41d4363","line":213,"in_reply_to":"ba0121b8_03a686ad","updated":"2016-03-31 13:47:03.000000000","message":"Tom, just adding to John\u0027s reply. Please see that first.\n\nI\u0027ve a question for you, which as pointed by John is more suited for the ML. My question anyway,\n\n\"Requiring secret-key to mount a share is great b/c it provides a means of tenant-isolation without the complexities of managing share networks.\"\n\nWhat kind of \u0027tenant-isolation\u0027 are you referring to in the above sentence?\nRequiring security keys provides authentication that is available in other drivers by associating security services with share networks. Share network in addition provides isolation of tenants from the storage network since the tenant has direct access only to the storage/service VM and not to the storage cluster/network itself. The cephfs_native driver in Mitaka does not provide isolation of tenant from the storage network. Plans on how a cephfs.* driver intends do this can be found here, https://www.youtube.com/watch?v\u003ddNTCBouMaAU (The relevant bits start after 19 minutes. It\u0027s worth a watch.)","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":210,"context_line":" deployments."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"- The secret-key required to mount a share is not exposed by manila APIs.  It"},{"line_number":213,"context_line":"  needs to be shared with the guest by the Ceph admin out of band of manila."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_c1e7f844","line":213,"in_reply_to":"ba0121b8_7018c91e","updated":"2016-04-01 19:50:03.000000000","message":"Thanks for the explanation, and very fair point about taking this kind of discussion to an appropriate venue.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":210,"context_line":" deployments."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"- The secret-key required to mount a share is not exposed by manila APIs.  It"},{"line_number":213,"context_line":"  needs to be shared with the guest by the Ceph admin out of band of manila."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_414ac828","line":213,"in_reply_to":"ba0121b8_e41d4363","updated":"2016-04-01 19:50:03.000000000","message":"Thanks!","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"},{"line_number":217,"context_line":"  to allow snapshot operations."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":220,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_23c0ea29","line":217,"updated":"2016-03-30 21:37:16.000000000","message":"Not having really been around when this was discussed, I find myself puzzled why anyone would *not* want snapshot support.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- The snapshot support of the driver is disabled by default."},{"line_number":216,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"},{"line_number":217,"context_line":"  to allow snapshot operations."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":220,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_155dff46","line":217,"in_reply_to":"ba0121b8_23c0ea29","updated":"2016-03-31 12:08:39.000000000","message":"Because the driver\u0027s snapshot support is incomplete (no clone) and because snapshots in cephfs itself are not necessarily stable either (we also require users to set an explicit flag in ceph to enable them)","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bc9768fc379864ff7622ed2ab038c6f3339b84af","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":220,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"},{"line_number":221,"context_line":"  share.  Shares cannot be created from snapshots."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The :mod:`manila.share.drivers.cephfs.cephfs_native.driver` Module"},{"line_number":224,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_6332e260","line":221,"updated":"2016-03-30 21:37:16.000000000","message":"As a cinder guy, the whole raison d\u0027etre of a snapshot is to enable creation from snapshot.\n\nI guess the difference is that with filesystems you can \"reach into\" a snapshot to get a filesystem subtree and restore it even if you can\u0027t create a new share from the whole thing?","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e0e69768c158a07e7bf8399d1e2c238c23b4a454","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":220,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"},{"line_number":221,"context_line":"  share.  Shares cannot be created from snapshots."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The :mod:`manila.share.drivers.cephfs.cephfs_native.driver` Module"},{"line_number":224,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_41948843","line":221,"in_reply_to":"ba0121b8_3015b13f","updated":"2016-04-01 19:50:03.000000000","message":"We could consider a slow-path (relative to clone) create-from-snapshot: a) create new empty share, appropriately sized, etc., b) \"reach in\" to the snapshot and copy out the root subtree to the new share.\n\nYeah, I know, take this to an appropriate discussion venue :-)","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"7e25cd0fe1af88c89d02795c34bac07238cb0f17","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- Snapshots are read-only and can be read from"},{"line_number":220,"context_line":"  ``.snap/share-snapshot-{manila-snapshot-id}`` folder within the mounted"},{"line_number":221,"context_line":"  share.  Shares cannot be created from snapshots."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The :mod:`manila.share.drivers.cephfs.cephfs_native.driver` Module"},{"line_number":224,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0121b8_3015b13f","line":221,"in_reply_to":"ba0121b8_6332e260","updated":"2016-03-31 12:08:39.000000000","message":"Correct.\n\nThere\u0027s a separate discussion about whether we should have special read-only shares that just enable reading a snapshot (no cloning going on on backend), which would be an easy semantic for ceph to support, compared with clones.","commit_id":"12df61a12b626b286a54d24ef797bd5c4d3269a9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"06884c67d0d5ece640f181d3049b2c8d2e42447c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Authorize the driver to communicate with Ceph"},{"line_number":70,"context_line":"---------------------------------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Run the following command to create a Ceph identity for manila to use:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. code-block:: console"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_74f79df5","line":72,"updated":"2016-04-22 08:39:52.000000000","message":"s/command/commands/","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"06884c67d0d5ece640f181d3049b2c8d2e42447c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"In the m-share server, you can place the ceph.conf and manila.keyring files"},{"line_number":100,"context_line":"in the /etc/ceph directory.  Set the owner of the :term:`manila-share` process"},{"line_number":101,"context_line":"as also the owner of the manila.keyring file.  And add the following section to"},{"line_number":102,"context_line":"the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_14e74941","line":99,"updated":"2016-04-22 08:39:52.000000000","message":"s/m-share/m-shr/","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ec90542532c33f84dc96eb04741b4b5fe1048482","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"In the m-share server, you can place the ceph.conf and manila.keyring files"},{"line_number":100,"context_line":"in the /etc/ceph directory.  Set the owner of the :term:`manila-share` process"},{"line_number":101,"context_line":"as also the owner of the manila.keyring file.  And add the following section to"},{"line_number":102,"context_line":"the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_56faeebd","line":99,"in_reply_to":"1a122d0e_14e74941","updated":"2016-04-27 08:56:55.000000000","message":"Very strange proposal. \"m-shr\" is just custom name of devstack screen window. It is \"manila-share\" service.","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b95ce2050804662527f58bcb4a9b85d6f6f84f36","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"In the m-share server, you can place the ceph.conf and manila.keyring files"},{"line_number":100,"context_line":"in the /etc/ceph directory.  Set the owner of the :term:`manila-share` process"},{"line_number":101,"context_line":"as also the owner of the manila.keyring file.  And add the following section to"},{"line_number":102,"context_line":"the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_846dfd9b","line":99,"in_reply_to":"1a122d0e_56faeebd","updated":"2016-05-02 11:41:30.000000000","message":"Agree.","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fcb480b7da0e3e2625c3078c530c3dc8b80bbfb8","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":146,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":147,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_5c88ecc6","line":147,"range":{"start_line":147,"start_character":32,"end_line":147,"end_character":40},"updated":"2016-04-21 14:25:09.000000000","message":"remove this word","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b95ce2050804662527f58bcb4a9b85d6f6f84f36","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":146,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":147,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_84f4ddcf","line":147,"range":{"start_line":147,"start_character":32,"end_line":147,"end_character":40},"in_reply_to":"1a122d0e_0532eb0f","updated":"2016-05-02 11:41:30.000000000","message":"OK. Thanks!","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"938078590b963d4f3acc28de83c76e5fc567b1be","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":146,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":147,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_0532eb0f","line":147,"range":{"start_line":147,"start_character":32,"end_line":147,"end_character":40},"in_reply_to":"1a122d0e_453ea38b","updated":"2016-04-27 20:34:54.000000000","message":"the negative vote wasn\u0027t for this though.. i would hope you fix the module below even if you don\u0027t remove this.","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"263504f387e28eb6be6196c5923247ec00ef2cee","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":146,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":147,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_dbee278a","line":147,"range":{"start_line":147,"start_character":32,"end_line":147,"end_character":40},"in_reply_to":"1a122d0e_5c88ecc6","updated":"2016-04-27 08:40:31.000000000","message":"is the usage grammatically incorrect?","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1478a97fdf7214cb562ba0857278007599bfe9d7","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":146,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":147,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_453ea38b","line":147,"range":{"start_line":147,"start_character":32,"end_line":147,"end_character":40},"in_reply_to":"1a122d0e_dbee278a","updated":"2016-04-27 20:34:05.000000000","message":"it sounds informal, since this is documentation, we could avoid that..","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fcb480b7da0e3e2625c3078c530c3dc8b80bbfb8","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"- Shares cannot be created from snapshots."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"The :mod:`manila.share.drivers.cephfs.cephfs_native.driver` Module"},{"line_number":271,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. automodule:: manila.share.drivers.cephfs.cephfs_native.driver"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_df8d0e2c","line":270,"range":{"start_line":270,"start_character":51,"end_line":270,"end_character":58},"updated":"2016-04-21 14:25:09.000000000","message":"There\u0027s no such module.. you mean:\n\n    manila.share.drivers.cephfs.cephfs_native","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b95ce2050804662527f58bcb4a9b85d6f6f84f36","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"- Shares cannot be created from snapshots."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"The :mod:`manila.share.drivers.cephfs.cephfs_native.driver` Module"},{"line_number":271,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. automodule:: manila.share.drivers.cephfs.cephfs_native.driver"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_c4fed5ad","line":270,"range":{"start_line":270,"start_character":51,"end_line":270,"end_character":58},"in_reply_to":"1a122d0e_df8d0e2c","updated":"2016-05-02 11:41:30.000000000","message":"Done","commit_id":"7089822cd5beecf65ed3b2cde7864d074d4c90f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- A Ceph cluster with a filesystem configured ("},{"line_number":58,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":59,"context_line":"- ``ceph-common`` package installed in the manila-share servers running the"},{"line_number":60,"context_line":"  :term: `manila-share` service."},{"line_number":61,"context_line":"- Ceph client installed in the guest, preferably the FUSE based client,"},{"line_number":62,"context_line":"  ``ceph-fuse``."},{"line_number":63,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_87721fe2","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":9},"updated":"2016-05-02 13:23:51.000000000","message":"remove space","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- A Ceph cluster with a filesystem configured ("},{"line_number":58,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":59,"context_line":"- ``ceph-common`` package installed in the manila-share servers running the"},{"line_number":60,"context_line":"  :term: `manila-share` service."},{"line_number":61,"context_line":"- Ceph client installed in the guest, preferably the FUSE based client,"},{"line_number":62,"context_line":"  ``ceph-fuse``."},{"line_number":63,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_1dfdbc08","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":9},"in_reply_to":"1a122d0e_87721fe2","updated":"2016-05-02 14:12:25.000000000","message":"Done","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"- Ceph client installed in the guest, preferably the FUSE based client,"},{"line_number":62,"context_line":"  ``ceph-fuse``."},{"line_number":63,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":64,"context_line":"  manila-share servers."},{"line_number":65,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_47476777","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":22},"updated":"2016-05-02 13:23:51.000000000","message":"As a manila developer, this is confusing to me as opposed to the previous version:\n\n\n\n    server running the :term:`manila-share` service.\n\n\nBecause manila-share servers and manila share servers are two different things, and the hyphen doesn\u0027t do enough justice for the distinction..","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":61,"context_line":"- Ceph client installed in the guest, preferably the FUSE based client,"},{"line_number":62,"context_line":"  ``ceph-fuse``."},{"line_number":63,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":64,"context_line":"  manila-share servers."},{"line_number":65,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_5d073418","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":22},"in_reply_to":"1a122d0e_47476777","updated":"2016-05-02 14:12:25.000000000","message":"Good point. Agree. Done.","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"manila.keyring, along with your ceph.conf file, will then need to be placed"},{"line_number":95,"context_line":"on the manila-share server."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Enable snapshots in Ceph if you want to use them in manila:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_87205fb2","line":95,"range":{"start_line":95,"start_character":7,"end_line":95,"end_character":26},"updated":"2016-05-02 13:23:51.000000000","message":"same..","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"manila.keyring, along with your ceph.conf file, will then need to be placed"},{"line_number":95,"context_line":"on the manila-share server."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Enable snapshots in Ceph if you want to use them in manila:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_1d249cb0","line":95,"range":{"start_line":95,"start_character":7,"end_line":95,"end_character":26},"in_reply_to":"1a122d0e_87205fb2","updated":"2016-05-02 14:12:25.000000000","message":"Done","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the manila-share server, you can place the ceph.conf and manila.keyring"},{"line_number":104,"context_line":"files in the /etc/ceph directory.  Set the owner of the :term:`manila-share`"},{"line_number":105,"context_line":"process as also the owner of the manila.keyring file.  And add the following"},{"line_number":106,"context_line":"section to the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_c72a5790","line":103,"range":{"start_line":103,"start_character":46,"end_line":103,"end_character":55},"updated":"2016-05-02 13:23:51.000000000","message":"``ceph.conf`` and ``manila.keyring``","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the manila-share server, you can place the ceph.conf and manila.keyring"},{"line_number":104,"context_line":"files in the /etc/ceph directory.  Set the owner of the :term:`manila-share`"},{"line_number":105,"context_line":"process as also the owner of the manila.keyring file.  And add the following"},{"line_number":106,"context_line":"section to the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_e72dd3a9","line":103,"range":{"start_line":103,"start_character":7,"end_line":103,"end_character":26},"updated":"2016-05-02 13:23:51.000000000","message":"server running the :term:`manila-share` service","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the manila-share server, you can place the ceph.conf and manila.keyring"},{"line_number":104,"context_line":"files in the /etc/ceph directory.  Set the owner of the :term:`manila-share`"},{"line_number":105,"context_line":"process as also the owner of the manila.keyring file.  And add the following"},{"line_number":106,"context_line":"section to the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_fd28c087","line":103,"range":{"start_line":103,"start_character":46,"end_line":103,"end_character":55},"in_reply_to":"1a122d0e_c72a5790","updated":"2016-05-02 14:12:25.000000000","message":"Done","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the manila-share server, you can place the ceph.conf and manila.keyring"},{"line_number":104,"context_line":"files in the /etc/ceph directory.  Set the owner of the :term:`manila-share`"},{"line_number":105,"context_line":"process as also the owner of the manila.keyring file.  And add the following"},{"line_number":106,"context_line":"section to the ceph.conf file."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_5d1e1460","line":103,"range":{"start_line":103,"start_character":7,"end_line":103,"end_character":26},"in_reply_to":"1a122d0e_e72dd3a9","updated":"2016-05-02 14:12:25.000000000","message":"Done","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"edc0b62a6b32efd32f0413cdcf30caaea17b7b82","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Then edit ``enabled_share_backends`` to point to the driver\u0027s backend section"},{"line_number":150,"context_line":"using the section name.  In this example we are also including another backend"},{"line_number":151,"context_line":"(\"generic1\"), you would include whatever other backends you have configured."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_87597f5e","line":151,"updated":"2016-05-02 13:11:33.000000000","message":"FWIW I don\u0027t think use of \u0027whatever\u0027 here is slang.","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de9611a167df2cb0e939f14d6533ea63a02969e4","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Mitaka release"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":" Consider the driver as a building block for supporting multi-tenant"},{"line_number":259,"context_line":" workloads in the future.  However, it can be used in private cloud"},{"line_number":260,"context_line":" deployments."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_227219b1","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":1},"updated":"2016-05-02 13:23:51.000000000","message":"Is this indentation expected?","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e833cc282d7147f9cad56be73a1551bca895a1ae","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Mitaka release"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":" Consider the driver as a building block for supporting multi-tenant"},{"line_number":259,"context_line":" workloads in the future.  However, it can be used in private cloud"},{"line_number":260,"context_line":" deployments."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_7d3cb0bf","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":1},"in_reply_to":"1a122d0e_227219b1","updated":"2016-05-02 14:12:25.000000000","message":"Done","commit_id":"f98bf19764c3d1a48bbef6e03792b4fba3ddce1c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"426b6dd383d86f10525d0ef0fbac0f561be163ca","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mount the filesystem."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  When a user"},{"line_number":25,"context_line":"requests access to a share for an ID, Ceph creates a corresponding Ceph auth ID"},{"line_number":26,"context_line":"and a secret key, if they do not already exist, and authorizes the ID to access"},{"line_number":27,"context_line":"the share.  The client can then mount the share using the ID and the secret"},{"line_number":28,"context_line":"key."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_1d110eb0","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":36},"updated":"2016-05-03 19:27:36.000000000","message":"this phrasing looks confusing. I would change to \"requests an access ID for a share\"","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2712d5ffaa30147c1d3087f093c575e273a48392","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mount the filesystem."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  When a user"},{"line_number":25,"context_line":"requests access to a share for an ID, Ceph creates a corresponding Ceph auth ID"},{"line_number":26,"context_line":"and a secret key, if they do not already exist, and authorizes the ID to access"},{"line_number":27,"context_line":"the share.  The client can then mount the share using the ID and the secret"},{"line_number":28,"context_line":"key."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_7bba85e2","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":36},"in_reply_to":"1a122d0e_1d110eb0","updated":"2016-05-05 06:05:24.000000000","message":"reworded.","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"b0b38db6a4cad0a7737374b17a59dfd518760589","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- Create/delete CephFS share"},{"line_number":42,"context_line":"- Allow/deny CephFS share access"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  * ``cephx`` access type is supported for CephFS protocol."},{"line_number":45,"context_line":"  * Only Read/write access level is supported."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- Extend/shrink share"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_a114194d","line":44,"updated":"2016-05-04 14:17:34.000000000","message":"I\u0027d make note here that the \"cephx\" access type is the only supported access type for CephFS.","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2712d5ffaa30147c1d3087f093c575e273a48392","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- Create/delete CephFS share"},{"line_number":42,"context_line":"- Allow/deny CephFS share access"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  * ``cephx`` access type is supported for CephFS protocol."},{"line_number":45,"context_line":"  * Only Read/write access level is supported."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- Extend/shrink share"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_bb225d52","line":44,"in_reply_to":"1a122d0e_a114194d","updated":"2016-05-05 06:05:24.000000000","message":"Done","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"426b6dd383d86f10525d0ef0fbac0f561be163ca","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_7dd5a2b5","line":106,"range":{"start_line":106,"start_character":26,"end_line":106,"end_character":29},"updated":"2016-05-03 19:27:36.000000000","message":"I don\u0027t think you should start a phrase using \"and\".","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"426b6dd383d86f10525d0ef0fbac0f561be163ca","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_3dd32ad7","line":106,"range":{"start_line":104,"start_character":72,"end_line":106,"end_character":23},"updated":"2016-05-03 19:27:36.000000000","message":"suggestion: \"Set the same owner for manila-share process and manila.keyring file\" is less confusing to me","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"b0b38db6a4cad0a7737374b17a59dfd518760589","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_17dd4b70","line":106,"range":{"start_line":104,"start_character":72,"end_line":106,"end_character":23},"in_reply_to":"1a122d0e_3dd32ad7","updated":"2016-05-04 14:17:34.000000000","message":"+1","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2712d5ffaa30147c1d3087f093c575e273a48392","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_fb20554b","line":106,"range":{"start_line":104,"start_character":72,"end_line":106,"end_character":23},"in_reply_to":"1a122d0e_3dd32ad7","updated":"2016-05-05 06:05:24.000000000","message":"Done","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2712d5ffaa30147c1d3087f093c575e273a48392","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_3b176def","line":106,"range":{"start_line":106,"start_character":26,"end_line":106,"end_character":29},"in_reply_to":"1a122d0e_7dd5a2b5","updated":"2016-05-05 06:05:24.000000000","message":"Done","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"f8864424e1d8053976af58ff450bab85791da6cd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the server running the :term:`manila-share` service, you can place the"},{"line_number":104,"context_line":"``ceph.conf`` and ``manila.keyring`` files in the /etc/ceph directory.  Set the"},{"line_number":105,"context_line":"owner of the :term:`manila-share` process as also the owner of the"},{"line_number":106,"context_line":"``manila.keyring`` file.  And add the following section to the ``ceph.conf``"},{"line_number":107,"context_line":"file."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_0fb8a674","line":106,"range":{"start_line":106,"start_character":26,"end_line":106,"end_character":29},"in_reply_to":"1a122d0e_7dd5a2b5","updated":"2016-05-04 07:26:06.000000000","message":"You can start a sentence with a conjunction.\nhttp://www.thewriter.com/what-we-think/style-guide/and-and-but-why-its-okay-to-start-a-sentence-with-a-conjunction/\nIf you\u0027re worried about the flow, then I think you\u0027re being a bit too harsh.","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"426b6dd383d86f10525d0ef0fbac0f561be163ca","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    admin socket \u003d /opt/stack/status/stack/ceph-$name.$pid.asok"},{"line_number":116,"context_line":"    keyring \u003d /etc/ceph/manila.keyring"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"You would want to modify the Ceph client\u0027s admin socket file and log file"},{"line_number":119,"context_line":"locations so that they are co-located with manila services\u0027s pid files and"},{"line_number":120,"context_line":"log files respectively."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_bda45a4b","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":24},"updated":"2016-05-03 19:27:36.000000000","message":"\"It is advisable to modify...\"","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"b0b38db6a4cad0a7737374b17a59dfd518760589","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    admin socket \u003d /opt/stack/status/stack/ceph-$name.$pid.asok"},{"line_number":116,"context_line":"    keyring \u003d /etc/ceph/manila.keyring"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"You would want to modify the Ceph client\u0027s admin socket file and log file"},{"line_number":119,"context_line":"locations so that they are co-located with manila services\u0027s pid files and"},{"line_number":120,"context_line":"log files respectively."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_d7c913ae","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":24},"in_reply_to":"1a122d0e_bda45a4b","updated":"2016-05-04 14:17:34.000000000","message":"+1","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2712d5ffaa30147c1d3087f093c575e273a48392","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    admin socket \u003d /opt/stack/status/stack/ceph-$name.$pid.asok"},{"line_number":116,"context_line":"    keyring \u003d /etc/ceph/manila.keyring"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"You would want to modify the Ceph client\u0027s admin socket file and log file"},{"line_number":119,"context_line":"locations so that they are co-located with manila services\u0027s pid files and"},{"line_number":120,"context_line":"log files respectively."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_1b1431e7","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":24},"in_reply_to":"1a122d0e_bda45a4b","updated":"2016-05-05 06:05:24.000000000","message":"Done","commit_id":"f6a815a18f3c2df55109788cc633061fa647a07d"}]}