)]}'
{"manila/share/manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"012a255205b9f09c7d1cf06d62620d6d62a7dedf","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            return"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            self.driver.initialized \u003d True"},{"line_number":269,"context_line":"            LOG.info(_LI(\"Finished initialization of driver: \u0027%(driver)s\""},{"line_number":270,"context_line":"                         \"@%(host)s\u0027\"), {"},{"line_number":271,"context_line":"                \"driver\": self.driver.__class__.__name__,"},{"line_number":272,"context_line":"                \"host\": self.host})"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host(ctxt,"},{"line_number":275,"context_line":"                                                                  self.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_01de7edc","line":272,"range":{"start_line":269,"start_character":12,"end_line":272,"end_character":35},"updated":"2016-03-23 12:12:30.000000000","message":"It is wrong place for saying it. It should be done only after line #330","commit_id":"8c18b44662e4a50d1cc3da08152c5d187ab0e05a"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"5fb5855c2eac040aa222bd0e5f7409783410d65f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\"Initialization for a standalone service.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":247,"context_line":"        LOG.debug((\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                   \"@%(host)s\u0027\"), {"},{"line_number":249,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"            \"host\": self.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_472d2694","line":247,"range":{"start_line":247,"start_character":12,"end_line":247,"end_character":17},"updated":"2016-03-23 12:27:30.000000000","message":"Is this supposed to be debug? I see that the other one you added is info.","commit_id":"40725fe201c1a344c3c5b9000376cb3affc56b23"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"74050832293eb263f3ef3a5cb44d114ddcbd5388","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\"Initialization for a standalone service.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":247,"context_line":"        LOG.debug((\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                   \"@%(host)s\u0027\"), {"},{"line_number":249,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"            \"host\": self.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_c7713678","line":247,"range":{"start_line":247,"start_character":12,"end_line":247,"end_character":17},"in_reply_to":"fa0719c6_472d2694","updated":"2016-03-23 12:35:17.000000000","message":"Yes since the most important information is that initialization is finished. this message is meant for debugging only.","commit_id":"40725fe201c1a344c3c5b9000376cb3affc56b23"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"5fb5855c2eac040aa222bd0e5f7409783410d65f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\"Initialization for a standalone service.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":247,"context_line":"        LOG.debug((\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                   \"@%(host)s\u0027\"), {"},{"line_number":249,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"            \"host\": self.host})"},{"line_number":251,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_67014a05","line":248,"range":{"start_line":247,"start_character":18,"end_line":248,"end_character":32},"updated":"2016-03-23 12:27:30.000000000","message":"Redundant parenthesis.","commit_id":"40725fe201c1a344c3c5b9000376cb3affc56b23"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"74050832293eb263f3ef3a5cb44d114ddcbd5388","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\"Initialization for a standalone service.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":247,"context_line":"        LOG.debug((\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                   \"@%(host)s\u0027\"), {"},{"line_number":249,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"            \"host\": self.host})"},{"line_number":251,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_2702b2b4","line":248,"range":{"start_line":247,"start_character":18,"end_line":248,"end_character":32},"in_reply_to":"fa0719c6_67014a05","updated":"2016-03-23 12:35:17.000000000","message":"Done","commit_id":"40725fe201c1a344c3c5b9000376cb3affc56b23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"daa1c0c2f97188594d072fd1d04969fe6e7b24fc","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    )"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":326,"context_line":"        LOG.info(_LI(\"Finished initialization of driver: \u0027%(driver)s\""},{"line_number":327,"context_line":"                     \"@%(host)s\u0027\"), {"},{"line_number":328,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":329,"context_line":"            \"host\": self.host})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_321cb269","line":326,"range":{"start_line":326,"start_character":8,"end_line":326,"end_character":16},"updated":"2016-03-23 12:42:22.000000000","message":"Is it intended that above one has \"debug\" level and this one \"info\"?","commit_id":"c7939cf2be8257afb43d36a2025435be9eaecf4f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"9954985711339748a88fa0123b6483309f563e2b","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    )"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":326,"context_line":"        LOG.info(_LI(\"Finished initialization of driver: \u0027%(driver)s\""},{"line_number":327,"context_line":"                     \"@%(host)s\u0027\"), {"},{"line_number":328,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":329,"context_line":"            \"host\": self.host})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_2dc3b339","line":326,"range":{"start_line":326,"start_character":8,"end_line":326,"end_character":16},"in_reply_to":"fa0719c6_321cb269","updated":"2016-03-23 13:15:57.000000000","message":"Yes yes, see my comment in PS2 :)","commit_id":"c7939cf2be8257afb43d36a2025435be9eaecf4f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"daa1c0c2f97188594d072fd1d04969fe6e7b24fc","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":326,"context_line":"        LOG.info(_LI(\"Finished initialization of driver: \u0027%(driver)s\""},{"line_number":327,"context_line":"                     \"@%(host)s\u0027\"), {"},{"line_number":328,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":329,"context_line":"            \"host\": self.host})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":332,"context_line":"                                        share_instance, snapshot\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_b26c42d1","line":329,"range":{"start_line":327,"start_character":36,"end_line":329,"end_character":30},"updated":"2016-03-23 12:42:22.000000000","message":"It is second arg and it is expected to start with new line as following:\n\nLOG.info(_(\"FOO message %(bar)s\"),\n         {\u0027bar\u0027: \u0027quuz\u0027})\n\nSame above.","commit_id":"c7939cf2be8257afb43d36a2025435be9eaecf4f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"9954985711339748a88fa0123b6483309f563e2b","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        self.publish_service_capabilities(ctxt)"},{"line_number":326,"context_line":"        LOG.info(_LI(\"Finished initialization of driver: \u0027%(driver)s\""},{"line_number":327,"context_line":"                     \"@%(host)s\u0027\"), {"},{"line_number":328,"context_line":"            \"driver\": self.driver.__class__.__name__,"},{"line_number":329,"context_line":"            \"host\": self.host})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":332,"context_line":"                                        share_instance, snapshot\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_5fc7ae63","line":329,"range":{"start_line":327,"start_character":36,"end_line":329,"end_character":30},"in_reply_to":"fa0719c6_b26c42d1","updated":"2016-03-23 13:15:57.000000000","message":"Done","commit_id":"c7939cf2be8257afb43d36a2025435be9eaecf4f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c10853c7167c942f60d26a591161488baf8dfec6","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        LOG.debug(\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                  \"@%(host)s\u0027\","},{"line_number":249,"context_line":"                  {\"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"                   \"host\": self.host})"},{"line_number":251,"context_line":"        try:"},{"line_number":252,"context_line":"            self.driver.do_setup(ctxt)"},{"line_number":253,"context_line":"            self.driver.check_for_setup_error()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_8280c9c1","line":250,"updated":"2016-03-23 13:33:36.000000000","message":"For consistency with pre-existing code, in both of the messages you added, you may want to consider using the \"\u003cdriver\u003e on \u003chost\u003e\" wording that is used in the exception at lines 256ff instead of this \"\u003cdriver\u003e@\u003chost\u003e\" format.\n\nNot a big deal though.","commit_id":"c01b5bb4ac67f960a250ea19d39922444fe593c6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f8426f18bd589df1f22c8840adc14375c73362a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        LOG.debug(\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                  \"@%(host)s\u0027\","},{"line_number":249,"context_line":"                  {\"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"                   \"host\": self.host})"},{"line_number":251,"context_line":"        try:"},{"line_number":252,"context_line":"            self.driver.do_setup(ctxt)"},{"line_number":253,"context_line":"            self.driver.check_for_setup_error()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_9b47d84a","line":250,"in_reply_to":"fa0719c6_68673de9","updated":"2016-03-28 02:18:38.000000000","message":"+1 The log result like: \n\"Start initialization of driver:\u0027generic1@ubuntu@generic1\u0027. \"\nIt is not very clear, if change to Tom\u0027s suggestion: \"\u003cdriver\u003e on \u003chost\u003e host\". It would be more clear, thanks.","commit_id":"c01b5bb4ac67f960a250ea19d39922444fe593c6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de5917e6132ed9bc4ce708aee1741b94baceccd7","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        LOG.debug(\"Start initialization of driver: \u0027%(driver)s\""},{"line_number":248,"context_line":"                  \"@%(host)s\u0027\","},{"line_number":249,"context_line":"                  {\"driver\": self.driver.__class__.__name__,"},{"line_number":250,"context_line":"                   \"host\": self.host})"},{"line_number":251,"context_line":"        try:"},{"line_number":252,"context_line":"            self.driver.do_setup(ctxt)"},{"line_number":253,"context_line":"            self.driver.check_for_setup_error()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_68673de9","line":250,"in_reply_to":"fa0719c6_8280c9c1","updated":"2016-03-23 20:03:09.000000000","message":"+1 would be nice to be consistent with the error message. Please fix this if you make another patch","commit_id":"c01b5bb4ac67f960a250ea19d39922444fe593c6"}]}