)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ef24da44608721b305757cca54d3844e7b0f78db","unresolved":false,"context_lines":[{"line_number":16,"context_line":"with no choice but to resort to making changes to"},{"line_number":17,"context_line":"the snapshot record in Manila\u0027s database."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Propogate the force flag to the share manager and log"},{"line_number":20,"context_line":"driver exceptions, while ignoring them to obliterate"},{"line_number":21,"context_line":"the snapshot on Manila\u0027s database if the delete"},{"line_number":22,"context_line":"operation is forced."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_f925975c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"updated":"2016-03-24 17:45:33.000000000","message":"s/Propogate/Propagate","commit_id":"cdc776153aee20a6a7f26a9993b0ded7885686bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a0cefad6fb926344ec19a7d47ff839ecc5d4663","unresolved":false,"context_lines":[{"line_number":16,"context_line":"with no choice but to resort to making changes to"},{"line_number":17,"context_line":"the snapshot record in Manila\u0027s database."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Propogate the force flag to the share manager and log"},{"line_number":20,"context_line":"driver exceptions, while ignoring them to obliterate"},{"line_number":21,"context_line":"the snapshot on Manila\u0027s database if the delete"},{"line_number":22,"context_line":"operation is forced."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_ce11dfb1","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"da0c15f0_f925975c","updated":"2016-03-24 19:34:06.000000000","message":"Done","commit_id":"cdc776153aee20a6a7f26a9993b0ded7885686bd"}],"manila/share/manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ef24da44608721b305757cca54d3844e7b0f78db","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"                    context,"},{"line_number":1935,"context_line":"                    snapshot_instance_id,"},{"line_number":1936,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1937,"context_line":"                raise"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        except Exception:"},{"line_number":1940,"context_line":"            with excutils.save_and_reraise_exception() as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_dcafe192","line":1937,"range":{"start_line":1937,"start_character":16,"end_line":1937,"end_character":21},"updated":"2016-03-24 17:45:33.000000000","message":"why not use excutils.save_and_reraise_exception here?","commit_id":"cdc776153aee20a6a7f26a9993b0ded7885686bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a0cefad6fb926344ec19a7d47ff839ecc5d4663","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"                    context,"},{"line_number":1935,"context_line":"                    snapshot_instance_id,"},{"line_number":1936,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1937,"context_line":"                raise"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        except Exception:"},{"line_number":1940,"context_line":"            with excutils.save_and_reraise_exception() as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_6e17f3ed","line":1937,"range":{"start_line":1937,"start_character":16,"end_line":1937,"end_character":21},"in_reply_to":"da0c15f0_dcafe192","updated":"2016-03-24 19:34:06.000000000","message":"Done","commit_id":"cdc776153aee20a6a7f26a9993b0ded7885686bd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51888206d2c0205b3c571fdc61461d713347876d","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"                self.db.share_snapshot_instance_update("},{"line_number":1934,"context_line":"                    context,"},{"line_number":1935,"context_line":"                    snapshot_instance_id,"},{"line_number":1936,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1937,"context_line":"                raise"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_1ff5cb82","line":1936,"range":{"start_line":1936,"start_character":48,"end_line":1936,"end_character":57},"updated":"2016-03-24 17:50:49.000000000","message":"Available? )) Nice )","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f16b147c48289c3871b73a7543116fee828eee64","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"                self.db.share_snapshot_instance_update("},{"line_number":1934,"context_line":"                    context,"},{"line_number":1935,"context_line":"                    snapshot_instance_id,"},{"line_number":1936,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1937,"context_line":"                raise"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_e2a95ce1","line":1936,"range":{"start_line":1936,"start_character":48,"end_line":1936,"end_character":57},"in_reply_to":"da0c15f0_1ff5cb82","updated":"2016-03-24 17:54:46.000000000","message":"Yeah. i found this weird too.. but in the previous case, we weren\u0027t even logging an exception...","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6f601acb77c49c620ddadaa177ebc392d8bd8dd8","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"                self.db.share_snapshot_instance_update("},{"line_number":1934,"context_line":"                    context,"},{"line_number":1935,"context_line":"                    snapshot_instance_id,"},{"line_number":1936,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1937,"context_line":"                raise"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_4d72f97d","line":1936,"range":{"start_line":1936,"start_character":48,"end_line":1936,"end_character":57},"in_reply_to":"da0c15f0_e2a95ce1","updated":"2016-03-24 18:15:18.000000000","message":"same in Cinder: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py\n\nWe inherited it originally. Ok, we can leave it as is, because it is very unlikely to get \"ShareSnapshotIsBusy\" exception if snapshot was in ERROR state.","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51888206d2c0205b3c571fdc61461d713347876d","unresolved":false,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        snapshot_update_call.assert_called_once_with("},{"line_number":1532,"context_line":"            mock.ANY, snapshot_instance[\u0027id\u0027],"},{"line_number":1533,"context_line":"            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"    @ddt.data(True, False)"},{"line_number":1536,"context_line":"    def test_delete_snapshot_with_quota_error(self, quota_error):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_1f094b32","line":1533,"range":{"start_line":1533,"start_character":33,"end_line":1533,"end_character":49},"updated":"2016-03-24 17:50:49.000000000","message":"and here available )))","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"71fb7ed97391ac5f55f7b2af0e53b59ae6b9acd6","unresolved":false,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        snapshot_update_call.assert_called_once_with("},{"line_number":1532,"context_line":"            mock.ANY, snapshot_instance[\u0027id\u0027],"},{"line_number":1533,"context_line":"            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"    @ddt.data(True, False)"},{"line_number":1536,"context_line":"    def test_delete_snapshot_with_quota_error(self, quota_error):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_c8fef704","line":1533,"range":{"start_line":1533,"start_character":33,"end_line":1533,"end_character":49},"in_reply_to":"da0c15f0_1f094b32","updated":"2016-03-24 19:34:37.000000000","message":"Done","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51888206d2c0205b3c571fdc61461d713347876d","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"                         mock.Mock(return_value\u003dshare))"},{"line_number":1606,"context_line":"        self.mock_object(self.share_manager, \u0027_get_share_server\u0027,"},{"line_number":1607,"context_line":"                         mock.Mock(return_value\u003dNone))"},{"line_number":1608,"context_line":"        if exc \u003d\u003d exception.ShareSnapshotIsBusy:"},{"line_number":1609,"context_line":"            raise_exc \u003d exception.ShareSnapshotIsBusy(snapshot_name\u003d\u0027fakename\u0027)"},{"line_number":1610,"context_line":"        else:"},{"line_number":1611,"context_line":"            raise_exc \u003d exception.ManilaException(message\u003d\"somthin\u0027 happened\"),"},{"line_number":1612,"context_line":"        mock_exception_log \u003d self.mock_object(manager.LOG, \u0027exception\u0027)"},{"line_number":1613,"context_line":"        self.mock_object(self.share_manager.driver, \u0027delete_snapshot\u0027,"},{"line_number":1614,"context_line":"                         mock.Mock(side_effect\u003draise_exc))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_bf493f91","line":1611,"range":{"start_line":1608,"start_character":8,"end_line":1611,"end_character":79},"updated":"2016-03-24 17:50:49.000000000","message":"Please, just provide needed classes as args without such conditions.","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"71fb7ed97391ac5f55f7b2af0e53b59ae6b9acd6","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"                         mock.Mock(return_value\u003dshare))"},{"line_number":1606,"context_line":"        self.mock_object(self.share_manager, \u0027_get_share_server\u0027,"},{"line_number":1607,"context_line":"                         mock.Mock(return_value\u003dNone))"},{"line_number":1608,"context_line":"        if exc \u003d\u003d exception.ShareSnapshotIsBusy:"},{"line_number":1609,"context_line":"            raise_exc \u003d exception.ShareSnapshotIsBusy(snapshot_name\u003d\u0027fakename\u0027)"},{"line_number":1610,"context_line":"        else:"},{"line_number":1611,"context_line":"            raise_exc \u003d exception.ManilaException(message\u003d\"somthin\u0027 happened\"),"},{"line_number":1612,"context_line":"        mock_exception_log \u003d self.mock_object(manager.LOG, \u0027exception\u0027)"},{"line_number":1613,"context_line":"        self.mock_object(self.share_manager.driver, \u0027delete_snapshot\u0027,"},{"line_number":1614,"context_line":"                         mock.Mock(side_effect\u003draise_exc))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_8e2087f9","line":1611,"range":{"start_line":1608,"start_character":8,"end_line":1611,"end_character":79},"in_reply_to":"da0c15f0_bf493f91","updated":"2016-03-24 19:34:37.000000000","message":"Done","commit_id":"ee31d909f4331be09303134b1a3735b8ed3e5b6b"}]}
