)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79b6cbca0bbe8a2590bb1931a88d2d3eb4ec0130","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-06 10:13:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add user_id echo in manila show/create/manage api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_e1ed5ab8","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":49},"updated":"2016-04-06 11:30:52.000000000","message":"s/api/API/","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-06 10:13:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add user_id echo in manila show/create/manage api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_9bc65d98","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":49},"in_reply_to":"9a061dce_e1ed5ab8","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79b6cbca0bbe8a2590bb1931a88d2d3eb4ec0130","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user create this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1562846"},{"line_number":14,"context_line":"Change-Id: I2858c7f63182288f354b96448f0970d3642d4bf7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_c1fad674","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":17},"updated":"2016-04-06 11:30:52.000000000","message":"s/create/created/","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user create this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1562846"},{"line_number":14,"context_line":"Change-Id: I2858c7f63182288f354b96448f0970d3642d4bf7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_7bc38989","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":17},"in_reply_to":"9a061dce_c1fad674","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user create this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1562846"},{"line_number":14,"context_line":"Change-Id: I2858c7f63182288f354b96448f0970d3642d4bf7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_2d48d7cb","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":0},"updated":"2016-04-06 14:37:48.000000000","message":"APIImpact flag please..","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user create this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1562846"},{"line_number":14,"context_line":"Change-Id: I2858c7f63182288f354b96448f0970d3642d4bf7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_dbbc5508","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":0},"in_reply_to":"9a061dce_2d48d7cb","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea195d780df08fe77dcdf90f6977a378c26aa073","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add user_id echo in manila show/create/manage API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user created this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a061dce_074bf459","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":55},"updated":"2016-04-07 13:25:24.000000000","message":"nit if you upload another patch: please change to \"Allow the operator to know ...\"","commit_id":"40064b27d5981aa091b483472fe4e6890887032e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c651ea41fcad557cbd3dd186719a87c313653ff5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add user_id echo in manila show/create/manage API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"user_id\" detail when we run command"},{"line_number":10,"context_line":"\"manila show/create/manage ...\". Make the operator know"},{"line_number":11,"context_line":"which user created this share."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a061dce_a6bf85ce","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":55},"in_reply_to":"9a061dce_074bf459","updated":"2016-04-08 01:28:00.000000000","message":"Done","commit_id":"40064b27d5981aa091b483472fe4e6890887032e"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e032bf3396e4fcbb48c90f058933f570a398c6f5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Add user id in manila show API."},{"line_number":69,"context_line":"\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_9c87c0d6","line":68,"range":{"start_line":68,"start_character":35,"end_line":68,"end_character":39},"updated":"2016-03-28 12:53:18.000000000","message":"share show","commit_id":"37f9406a77123329d6014af4c53867c1daa0782c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6c105370b4f3a39c37f66fcbb38f9abc878bc7d5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Add user id in manila show API."},{"line_number":69,"context_line":"\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_7f00de01","line":68,"range":{"start_line":68,"start_character":35,"end_line":68,"end_character":39},"in_reply_to":"da0c15f0_9c87c0d6","updated":"2016-03-28 12:59:47.000000000","message":"And not only \"show\", \"create\" and \"manage\" too.","commit_id":"37f9406a77123329d6014af4c53867c1daa0782c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"32012e5759f6b6459dd10b8ab3284306825b5633","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Add user id in share show/create/manage API."},{"line_number":69,"context_line":"\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_9a7afc75","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":24},"updated":"2016-04-06 13:28:26.000000000","message":"nit: s/user id/user_id","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Add user id in share show/create/manage API."},{"line_number":69,"context_line":"\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_fb3dd98f","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":24},"in_reply_to":"9a061dce_9a7afc75","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6c105370b4f3a39c37f66fcbb38f9abc878bc7d5","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"2.16"},{"line_number":111,"context_line":"----"},{"line_number":112,"context_line":"  Add user id in manila show API."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_7f273eb6","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":33},"updated":"2016-03-28 12:59:47.000000000","message":"same as in https://review.openstack.org/#/c/298115/3/manila/api/openstack/api_version_request.py","commit_id":"37f9406a77123329d6014af4c53867c1daa0782c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"32012e5759f6b6459dd10b8ab3284306825b5633","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"2.16"},{"line_number":111,"context_line":"----"},{"line_number":112,"context_line":"  Add user id in share show/create/manage API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_dadf5467","line":112,"range":{"start_line":112,"start_character":6,"end_line":112,"end_character":13},"updated":"2016-04-06 13:28:26.000000000","message":"nit: s/user id/user_id","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"2.16"},{"line_number":111,"context_line":"----"},{"line_number":112,"context_line":"  Add user id in share show/create/manage API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_9b4dbd40","line":112,"range":{"start_line":112,"start_character":6,"end_line":112,"end_character":13},"in_reply_to":"9a061dce_dadf5467","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"}],"manila/api/views/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"528a3f7ee30ba9663848a9feb10f976fa61a8b40","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027status\u0027: share.get(\u0027status\u0027),"},{"line_number":74,"context_line":"            \u0027name\u0027: share.get(\u0027display_name\u0027),"},{"line_number":75,"context_line":"            \u0027description\u0027: share.get(\u0027display_description\u0027),"},{"line_number":76,"context_line":"            \u0027user_id\u0027: share.get(\u0027user_id\u0027),"},{"line_number":77,"context_line":"            \u0027project_id\u0027: share.get(\u0027project_id\u0027),"},{"line_number":78,"context_line":"            \u0027host\u0027: share_instance.get(\u0027host\u0027),"},{"line_number":79,"context_line":"            \u0027snapshot_id\u0027: share.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_970960e0","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":44},"updated":"2016-03-28 10:55:54.000000000","message":"It should be versioned. need to bump microversion and add this key only with it. See below methods wrapped with \"@common.ViewBuilder.versioned_method\" decorator.\n\nAlso, such change should be covered with functional tests too. It is easy change.","commit_id":"7246d7a4c010ba248b94c86f20aca64b8d1cedcc"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4e336f625ac4f9a9d0d400237465cc2056cddfcf","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":790,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def test_share_show_with_user_id(self):"},{"line_number":793,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003d\u00272.16\u0027)"},{"line_number":794,"context_line":"        res_dict \u003d self.controller.show(req, \u00271\u0027)"},{"line_number":795,"context_line":"        expected \u003d self._get_expected_share_detailed_response()"},{"line_number":796,"context_line":"        expected[\u0027share\u0027][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":797,"context_line":"        expected[\u0027share\u0027][\u0027source_cgsnapshot_member_id\u0027] \u003d None"},{"line_number":798,"context_line":"        expected[\u0027share\u0027][\u0027share_type_name\u0027] \u003d None"},{"line_number":799,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":800,"context_line":"        expected[\u0027share\u0027][\u0027access_rules_status\u0027] \u003d \u0027active\u0027"},{"line_number":801,"context_line":"        expected[\u0027share\u0027].pop(\u0027export_location\u0027)"},{"line_number":802,"context_line":"        expected[\u0027share\u0027].pop(\u0027export_locations\u0027)"},{"line_number":803,"context_line":"        expected[\u0027share\u0027][\u0027replication_type\u0027] \u003d None"},{"line_number":804,"context_line":"        expected[\u0027share\u0027][\u0027has_replicas\u0027] \u003d False"},{"line_number":805,"context_line":"        expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":806,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    def test_share_show_admin(self):"},{"line_number":809,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_49364d04","line":806,"range":{"start_line":792,"start_character":4,"end_line":806,"end_character":44},"updated":"2016-03-29 10:09:59.000000000","message":"Not enough, \"create share\" and \"manage share\" are not tested. Also, would be great to cover border microversions that they do not have new key.","commit_id":"ad80808fd7b700ffbb6656eeee672cfbcdc9a995"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"06bd62a371de9f52fa6779a65c72ae4608816864","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.assertEqual(\"fakenetid\","},{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_0c114004","line":261,"updated":"2016-04-01 12:22:58.000000000","message":"Don\u0027t we want to test 2.15 and 2.16 ? and check that user_id is not available when using 2.15 ?","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0ef5efb246d9de6afdcd9a7c2dc8244eb189c376","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.assertEqual(\"fakenetid\","},{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_5364ee47","line":261,"in_reply_to":"ba0121b8_0c114004","updated":"2016-04-06 02:16:20.000000000","message":"Done","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_share_show_with_user_id(self):"},{"line_number":817,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003d\u00272.16\u0027)"},{"line_number":818,"context_line":"        res_dict \u003d self.controller.show(req, \u00271\u0027)"},{"line_number":819,"context_line":"        expected \u003d self._get_expected_share_detailed_response()"},{"line_number":820,"context_line":"        expected[\u0027share\u0027][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":821,"context_line":"        expected[\u0027share\u0027][\u0027source_cgsnapshot_member_id\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_629c9e0f","line":818,"range":{"start_line":818,"start_character":0,"end_line":818,"end_character":49},"updated":"2016-04-06 14:37:48.000000000","message":"Please add a blank line before and after this line","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_share_show_with_user_id(self):"},{"line_number":817,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003d\u00272.16\u0027)"},{"line_number":818,"context_line":"        res_dict \u003d self.controller.show(req, \u00271\u0027)"},{"line_number":819,"context_line":"        expected \u003d self._get_expected_share_detailed_response()"},{"line_number":820,"context_line":"        expected[\u0027share\u0027][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":821,"context_line":"        expected[\u0027share\u0027][\u0027source_cgsnapshot_member_id\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_5b5685ce","line":818,"range":{"start_line":818,"start_character":0,"end_line":818,"end_character":49},"in_reply_to":"9a061dce_629c9e0f","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        expected[\u0027share\u0027][\u0027replication_type\u0027] \u003d None"},{"line_number":828,"context_line":"        expected[\u0027share\u0027][\u0027has_replicas\u0027] \u003d False"},{"line_number":829,"context_line":"        expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":830,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    def test_share_show_admin(self):"},{"line_number":833,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_62c3feed","line":830,"range":{"start_line":830,"start_character":0,"end_line":830,"end_character":44},"updated":"2016-04-06 14:37:48.000000000","message":"please add a blank line before this line","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        expected[\u0027share\u0027][\u0027replication_type\u0027] \u003d None"},{"line_number":828,"context_line":"        expected[\u0027share\u0027][\u0027has_replicas\u0027] \u003d False"},{"line_number":829,"context_line":"        expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":830,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    def test_share_show_admin(self):"},{"line_number":833,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_9b749d68","line":830,"range":{"start_line":830,"start_character":0,"end_line":830,"end_character":44},"in_reply_to":"9a061dce_62c3feed","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"    def test_share_manage_with_is_public(self, data):"},{"line_number":1906,"context_line":"        self._test_share_manage(data, \"2.8\")"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"    @ddt.data("},{"line_number":1909,"context_line":"        get_fake_manage_body(name\u003d\u0027foo\u0027, description\u003d\u0027bar\u0027, is_public\u003dTrue),"},{"line_number":1910,"context_line":"    )"},{"line_number":1911,"context_line":"    def test_share_manage_with_user_id(self, data):"},{"line_number":1912,"context_line":"        self._test_share_manage(data, \"2.16\")"},{"line_number":1913,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_6d280f87","line":1910,"range":{"start_line":1908,"start_character":4,"end_line":1910,"end_character":5},"updated":"2016-04-06 14:37:48.000000000","message":"If you have only one value, you don\u0027t need ddt.. please assign data within the test and use it..","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"    def test_share_manage_with_is_public(self, data):"},{"line_number":1906,"context_line":"        self._test_share_manage(data, \"2.8\")"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"    @ddt.data("},{"line_number":1909,"context_line":"        get_fake_manage_body(name\u003d\u0027foo\u0027, description\u003d\u0027bar\u0027, is_public\u003dTrue),"},{"line_number":1910,"context_line":"    )"},{"line_number":1911,"context_line":"    def test_share_manage_with_user_id(self, data):"},{"line_number":1912,"context_line":"        self._test_share_manage(data, \"2.16\")"},{"line_number":1913,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_5b24c55e","line":1910,"range":{"start_line":1908,"start_character":4,"end_line":1910,"end_character":5},"in_reply_to":"9a061dce_6d280f87","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":1952,"context_line":"            }"},{"line_number":1953,"context_line":"        }"},{"line_number":1954,"context_line":"        self._setup_manage_mocks()"},{"line_number":1955,"context_line":"        return_share \u003d mock.Mock("},{"line_number":1956,"context_line":"            return_value\u003dstubs.stub_share("},{"line_number":1957,"context_line":"                \u0027fake\u0027,"},{"line_number":1958,"context_line":"                instance\u003d{},"},{"line_number":1959,"context_line":"                )"},{"line_number":1960,"context_line":"        )"},{"line_number":1961,"context_line":"        self.mock_object("},{"line_number":1962,"context_line":"            share_api.API, \u0027manage\u0027, return_share)"},{"line_number":1963,"context_line":"        share \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_8233b213","line":1960,"range":{"start_line":1955,"start_character":8,"end_line":1960,"end_character":9},"updated":"2016-04-06 14:37:48.000000000","message":"Wrap this properly... \n\n    return_share \u003d mock.Mock(\n            return_value\u003dstubs.stub_share(\u0027fake\u0027,instance\u003d{}))","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":1952,"context_line":"            }"},{"line_number":1953,"context_line":"        }"},{"line_number":1954,"context_line":"        self._setup_manage_mocks()"},{"line_number":1955,"context_line":"        return_share \u003d mock.Mock("},{"line_number":1956,"context_line":"            return_value\u003dstubs.stub_share("},{"line_number":1957,"context_line":"                \u0027fake\u0027,"},{"line_number":1958,"context_line":"                instance\u003d{},"},{"line_number":1959,"context_line":"                )"},{"line_number":1960,"context_line":"        )"},{"line_number":1961,"context_line":"        self.mock_object("},{"line_number":1962,"context_line":"            share_api.API, \u0027manage\u0027, return_share)"},{"line_number":1963,"context_line":"        share \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_fb32f9a5","line":1960,"range":{"start_line":1955,"start_character":8,"end_line":1960,"end_character":9},"in_reply_to":"9a061dce_8233b213","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"            mock.ANY, share, driver_options)"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"        self.assertIsNotNone(actual_result)"},{"line_number":1986,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1987,"context_line":"                api_version.APIVersionRequest(\u00272.16\u0027)):"},{"line_number":1988,"context_line":"            expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":1989,"context_line":"            self.assertEqual(expected, actual_result)"},{"line_number":1990,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":1991,"context_line":"            req.environ[\u0027manila.context\u0027], self.resource_name, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_ed6a5fb2","line":1988,"range":{"start_line":1986,"start_character":8,"end_line":1988,"end_character":53},"updated":"2016-04-06 14:37:48.000000000","message":"Please move this line to line 1976 ...","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"            mock.ANY, share, driver_options)"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"        self.assertIsNotNone(actual_result)"},{"line_number":1986,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1987,"context_line":"                api_version.APIVersionRequest(\u00272.16\u0027)):"},{"line_number":1988,"context_line":"            expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":1989,"context_line":"            self.assertEqual(expected, actual_result)"},{"line_number":1990,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":1991,"context_line":"            req.environ[\u0027manila.context\u0027], self.resource_name, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_41ae9381","line":1988,"range":{"start_line":1986,"start_character":8,"end_line":1988,"end_character":53},"in_reply_to":"9a061dce_ed6a5fb2","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1df4a966a85c062c74744aae81d9235b9da9cb8","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        expected \u003d self._get_expected_share_detailed_response(self.share)"},{"line_number":270,"context_line":"        if api_version.APIVersionRequest(microversion) \u003e\u003d ("},{"line_number":271,"context_line":"                api_version.APIVersionRequest(\"2.16\")):"},{"line_number":272,"context_line":"            expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":273,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":274,"context_line":"        expected[\u0027share\u0027][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":275,"context_line":"        expected[\u0027share\u0027][\u0027source_cgsnapshot_member_id\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_9f5ee643","line":272,"range":{"start_line":270,"start_character":8,"end_line":272,"end_character":53},"updated":"2016-04-11 12:59:38.000000000","message":"else:\n    self.assertNotIn(\u0027user_id\u0027, expected[\u0027share\u0027])","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"18d37971e78e8ae3d85e390784ee9472ccb95908","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        expected \u003d self._get_expected_share_detailed_response(self.share)"},{"line_number":270,"context_line":"        if api_version.APIVersionRequest(microversion) \u003e\u003d ("},{"line_number":271,"context_line":"                api_version.APIVersionRequest(\"2.16\")):"},{"line_number":272,"context_line":"            expected[\u0027share\u0027][\u0027user_id\u0027] \u003d \u0027fakeuser\u0027"},{"line_number":273,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":274,"context_line":"        expected[\u0027share\u0027][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":275,"context_line":"        expected[\u0027share\u0027][\u0027source_cgsnapshot_member_id\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_6ae4fb3a","line":272,"range":{"start_line":270,"start_character":8,"end_line":272,"end_character":53},"in_reply_to":"7a1b2928_9f5ee643","updated":"2016-04-12 02:40:00.000000000","message":"Done","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1df4a966a85c062c74744aae81d9235b9da9cb8","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":814,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_share_show_with_user_id(self):"},{"line_number":817,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003d\u00272.16\u0027)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        res_dict \u003d self.controller.show(req, \u00271\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_7f22eaba","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":43},"updated":"2016-04-11 12:59:38.000000000","message":"Why ddt is not used here as for test above? With all its input data?","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"18d37971e78e8ae3d85e390784ee9472ccb95908","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":814,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_share_show_with_user_id(self):"},{"line_number":817,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003d\u00272.16\u0027)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        res_dict \u003d self.controller.show(req, \u00271\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_aa7d73e9","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":43},"in_reply_to":"7a1b2928_7f22eaba","updated":"2016-04-12 02:40:00.000000000","message":"Done","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"},{"line_number":265,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027, version\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_23b45280","line":262,"range":{"start_line":262,"start_character":26,"end_line":262,"end_character":34},"updated":"2016-04-14 16:00:41.000000000","message":"what does original mean?","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"},{"line_number":265,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027, version\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_e80ef630","line":262,"range":{"start_line":262,"start_character":26,"end_line":262,"end_character":34},"in_reply_to":"5a18252c_23b45280","updated":"2016-04-25 01:28:23.000000000","message":"It means not create with share net, snapshot or consistency group, only create a original share.","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"            expected[\u0027share\u0027][\u0027export_location\u0027] \u003d \u0027fake_location\u0027"},{"line_number":1982,"context_line":"            expected[\u0027share\u0027][\u0027export_locations\u0027] \u003d ("},{"line_number":1983,"context_line":"                [\u0027fake_location\u0027, \u0027fake_location2\u0027])"},{"line_number":1984,"context_line":"            expected[\u0027share\u0027].pop(\u0027has_replicas\u0027)"},{"line_number":1985,"context_line":"            expected[\u0027share\u0027].pop(\u0027replication_type\u0027)"},{"line_number":1986,"context_line":"            expected[\u0027share\u0027].pop(\u0027access_rules_status\u0027)"},{"line_number":1987,"context_line":""},{"line_number":1988,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1989,"context_line":"                api_version.APIVersionRequest(\u00272.8\u0027)):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_de757598","line":1986,"range":{"start_line":1984,"start_character":0,"end_line":1986,"end_character":56},"updated":"2016-04-14 16:00:41.000000000","message":"This seems to suggest that these fields were added in v2.16\n\nWhy don\u0027t you do this:\n    \n    if (api_version.APIVersionRequest(version) \u003c\u003d\n                api_version.APIVersionRequest(\u00272.8\u0027)):\n        expected[\u0027share\u0027][\u0027export_location\u0027] \u003d \u0027fake_location\u0027\n            expected[\u0027share\u0027][\u0027export_locations\u0027] \u003d (\n                [\u0027fake_location\u0027, \u0027fake_location2\u0027])\n\n(Alternatively, you can pop if you have this in your expected share already)\n\n\n    if (api_version.APIVersionRequest(version) \u003e\u003d\n                api_version.APIVersionRequest(\u00272.10\u0027)):\n        expected[\u0027share\u0027][\u0027access_rules_status\u0027] \u003d constants.STATUS_ACTIVE\n\n\n\n    if (api_version.APIVersionRequest(version) \u003e\u003d\n                api_version.APIVersionRequest(\u00272.11\u0027)):\n         expected[\u0027share\u0027][\u0027has_replicas\u0027] \u003d False\n         expected[\u0027share\u0027\u0027][\u0027replication_type\u0027] \u003d None","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"            expected[\u0027share\u0027][\u0027export_location\u0027] \u003d \u0027fake_location\u0027"},{"line_number":1982,"context_line":"            expected[\u0027share\u0027][\u0027export_locations\u0027] \u003d ("},{"line_number":1983,"context_line":"                [\u0027fake_location\u0027, \u0027fake_location2\u0027])"},{"line_number":1984,"context_line":"            expected[\u0027share\u0027].pop(\u0027has_replicas\u0027)"},{"line_number":1985,"context_line":"            expected[\u0027share\u0027].pop(\u0027replication_type\u0027)"},{"line_number":1986,"context_line":"            expected[\u0027share\u0027].pop(\u0027access_rules_status\u0027)"},{"line_number":1987,"context_line":""},{"line_number":1988,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1989,"context_line":"                api_version.APIVersionRequest(\u00272.8\u0027)):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_c8205a9e","line":1986,"range":{"start_line":1984,"start_character":0,"end_line":1986,"end_character":56},"in_reply_to":"5a18252c_de757598","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aeb5d9bb3b0c44a6b302bcc028651ef8f960fde4","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"                \u0027task_state\u0027: None,"},{"line_number":1947,"context_line":"                \u0027links\u0027: ["},{"line_number":1948,"context_line":"                    {"},{"line_number":1949,"context_line":"                        \u0027href\u0027: \u0027http://localhost/v1/fake/shares/fake\u0027,"},{"line_number":1950,"context_line":"                        \u0027rel\u0027: \u0027self\u0027"},{"line_number":1951,"context_line":"                    },"},{"line_number":1952,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_79f05fca","line":1949,"range":{"start_line":1949,"start_character":50,"end_line":1949,"end_character":52},"updated":"2016-04-21 12:40:36.000000000","message":"v2","commit_id":"9bd5976f55a0a2414b70ffe3edd6f1b1268eef54"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"bef5dae6f39186d23701a650a58206c747f762b5","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.assertEqual(\"fakenetid\","},{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"}],"source_content_type":"text/x-python","patch_set":21,"id":"dab17558_911bd8c9","line":261,"updated":"2016-05-10 15:31:56.000000000","message":"2.18 shouldn\u0027t be mentioned here because it doesn\u0027t exist","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0abe1df4116d3bd16ab38c04f90fc7def1e2414","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.assertEqual(\"fakenetid\","},{"line_number":259,"context_line":"                         create_mock.call_args[1][\u0027share_network_id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":262,"context_line":"    def test_share_create_original_with_user_id(self, microversion):"},{"line_number":263,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, self.create_mock)"},{"line_number":264,"context_line":"        body \u003d {\"share\": copy.deepcopy(self.share)}"}],"source_content_type":"text/x-python","patch_set":21,"id":"dab17558_a32f9786","line":261,"in_reply_to":"dab17558_911bd8c9","updated":"2016-05-11 01:21:37.000000000","message":"Done","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"bef5dae6f39186d23701a650a58206c747f762b5","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":816,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":819,"context_line":"    def test_share_show_with_user_id(self, microversion):"},{"line_number":820,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003dmicroversion)"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"dab17558_7128f4e2","line":818,"updated":"2016-05-10 15:31:56.000000000","message":"2.18 shouldn\u0027t be mentioned here because it doesn\u0027t exist","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0abe1df4116d3bd16ab38c04f90fc7def1e2414","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        expected[\u0027share\u0027][\u0027task_state\u0027] \u003d None"},{"line_number":816,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    @ddt.data(\"2.15\", \"2.16\", \"2.18\")"},{"line_number":819,"context_line":"    def test_share_show_with_user_id(self, microversion):"},{"line_number":820,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares/1\u0027, version\u003dmicroversion)"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"dab17558_034f836b","line":818,"in_reply_to":"dab17558_7128f4e2","updated":"2016-05-11 01:21:37.000000000","message":"Done","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"87d1a6cf79b7fd84a2d11f696beb4c47867006c3","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"            name\u003d\u0027foo\u0027, description\u003d\u0027bar\u0027, is_public\u003dTrue), \"2.16\")"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"    def _test_share_manage(self, data, version):"},{"line_number":1923,"context_line":"        expected \u003d {"},{"line_number":1924,"context_line":"            \u0027share\u0027: {"},{"line_number":1925,"context_line":"                \u0027status\u0027: \u0027fakestatus\u0027,"},{"line_number":1926,"context_line":"                \u0027description\u0027: \u0027displaydesc\u0027,"},{"line_number":1927,"context_line":"                \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":1928,"context_line":"                \u0027name\u0027: \u0027displayname\u0027,"},{"line_number":1929,"context_line":"                \u0027share_proto\u0027: \u0027FAKEPROTO\u0027,"},{"line_number":1930,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1931,"context_line":"                \u0027project_id\u0027: \u0027fakeproject\u0027,"},{"line_number":1932,"context_line":"                \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":1933,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"},{"line_number":1934,"context_line":"                \u0027snapshot_id\u0027: \u00272\u0027,"},{"line_number":1935,"context_line":"                \u0027share_network_id\u0027: None,"},{"line_number":1936,"context_line":"                \u0027created_at\u0027: datetime.datetime(1, 1, 1, 1, 1, 1),"},{"line_number":1937,"context_line":"                \u0027size\u0027: 1,"},{"line_number":1938,"context_line":"                \u0027share_type_name\u0027: None,"},{"line_number":1939,"context_line":"                \u0027share_server_id\u0027: \u0027fake_share_server_id\u0027,"},{"line_number":1940,"context_line":"                \u0027share_type\u0027: \u00271\u0027,"},{"line_number":1941,"context_line":"                \u0027volume_type\u0027: \u00271\u0027,"},{"line_number":1942,"context_line":"                \u0027is_public\u0027: False,"},{"line_number":1943,"context_line":"                \u0027consistency_group_id\u0027: None,"},{"line_number":1944,"context_line":"                \u0027source_cgsnapshot_member_id\u0027: None,"},{"line_number":1945,"context_line":"                \u0027snapshot_support\u0027: True,"},{"line_number":1946,"context_line":"                \u0027task_state\u0027: None,"},{"line_number":1947,"context_line":"                \u0027links\u0027: ["},{"line_number":1948,"context_line":"                    {"},{"line_number":1949,"context_line":"                        \u0027href\u0027: \u0027http://localhost/v1/fake/shares/fake\u0027,"},{"line_number":1950,"context_line":"                        \u0027rel\u0027: \u0027self\u0027"},{"line_number":1951,"context_line":"                    },"},{"line_number":1952,"context_line":"                    {"},{"line_number":1953,"context_line":"                        \u0027href\u0027: \u0027http://localhost/fake/shares/fake\u0027,"},{"line_number":1954,"context_line":"                        \u0027rel\u0027: \u0027bookmark\u0027"},{"line_number":1955,"context_line":"                    }"},{"line_number":1956,"context_line":"                ],"},{"line_number":1957,"context_line":"            }"},{"line_number":1958,"context_line":"        }"},{"line_number":1959,"context_line":"        self._setup_manage_mocks()"},{"line_number":1960,"context_line":"        return_share \u003d mock.Mock("},{"line_number":1961,"context_line":"            return_value\u003dstubs.stub_share(\u0027fake\u0027, instance\u003d{}))"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a122d0e_1349d1d0","line":1958,"range":{"start_line":1923,"start_character":19,"end_line":1958,"end_character":9},"updated":"2016-05-04 17:33:34.000000000","message":"Shouldn\u0027t you use _get_expected_share_detailed_response here?","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e71652c2ad7269d67c7e04db00ef8c14f5e60186","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"            name\u003d\u0027foo\u0027, description\u003d\u0027bar\u0027, is_public\u003dTrue), \"2.16\")"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"    def _test_share_manage(self, data, version):"},{"line_number":1923,"context_line":"        expected \u003d {"},{"line_number":1924,"context_line":"            \u0027share\u0027: {"},{"line_number":1925,"context_line":"                \u0027status\u0027: \u0027fakestatus\u0027,"},{"line_number":1926,"context_line":"                \u0027description\u0027: \u0027displaydesc\u0027,"},{"line_number":1927,"context_line":"                \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":1928,"context_line":"                \u0027name\u0027: \u0027displayname\u0027,"},{"line_number":1929,"context_line":"                \u0027share_proto\u0027: \u0027FAKEPROTO\u0027,"},{"line_number":1930,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1931,"context_line":"                \u0027project_id\u0027: \u0027fakeproject\u0027,"},{"line_number":1932,"context_line":"                \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":1933,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"},{"line_number":1934,"context_line":"                \u0027snapshot_id\u0027: \u00272\u0027,"},{"line_number":1935,"context_line":"                \u0027share_network_id\u0027: None,"},{"line_number":1936,"context_line":"                \u0027created_at\u0027: datetime.datetime(1, 1, 1, 1, 1, 1),"},{"line_number":1937,"context_line":"                \u0027size\u0027: 1,"},{"line_number":1938,"context_line":"                \u0027share_type_name\u0027: None,"},{"line_number":1939,"context_line":"                \u0027share_server_id\u0027: \u0027fake_share_server_id\u0027,"},{"line_number":1940,"context_line":"                \u0027share_type\u0027: \u00271\u0027,"},{"line_number":1941,"context_line":"                \u0027volume_type\u0027: \u00271\u0027,"},{"line_number":1942,"context_line":"                \u0027is_public\u0027: False,"},{"line_number":1943,"context_line":"                \u0027consistency_group_id\u0027: None,"},{"line_number":1944,"context_line":"                \u0027source_cgsnapshot_member_id\u0027: None,"},{"line_number":1945,"context_line":"                \u0027snapshot_support\u0027: True,"},{"line_number":1946,"context_line":"                \u0027task_state\u0027: None,"},{"line_number":1947,"context_line":"                \u0027links\u0027: ["},{"line_number":1948,"context_line":"                    {"},{"line_number":1949,"context_line":"                        \u0027href\u0027: \u0027http://localhost/v1/fake/shares/fake\u0027,"},{"line_number":1950,"context_line":"                        \u0027rel\u0027: \u0027self\u0027"},{"line_number":1951,"context_line":"                    },"},{"line_number":1952,"context_line":"                    {"},{"line_number":1953,"context_line":"                        \u0027href\u0027: \u0027http://localhost/fake/shares/fake\u0027,"},{"line_number":1954,"context_line":"                        \u0027rel\u0027: \u0027bookmark\u0027"},{"line_number":1955,"context_line":"                    }"},{"line_number":1956,"context_line":"                ],"},{"line_number":1957,"context_line":"            }"},{"line_number":1958,"context_line":"        }"},{"line_number":1959,"context_line":"        self._setup_manage_mocks()"},{"line_number":1960,"context_line":"        return_share \u003d mock.Mock("},{"line_number":1961,"context_line":"            return_value\u003dstubs.stub_share(\u0027fake\u0027, instance\u003d{}))"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a122d0e_9f1a0017","line":1958,"range":{"start_line":1923,"start_character":19,"end_line":1958,"end_character":9},"in_reply_to":"1a122d0e_1349d1d0","updated":"2016-05-04 18:49:44.000000000","message":"That method needs a refactor, you\u0027ll see the uses of \u0027_get_expected_share_detailed_response\u0027 above are sub-optimal as well.. We should really be getting this data from a fakes file.. however, that may not be the goal of this commit..","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d9ee588c08feb185b5bdf782ca0621f231459c27","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"            name\u003d\u0027foo\u0027, description\u003d\u0027bar\u0027, is_public\u003dTrue), \"2.16\")"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"    def _test_share_manage(self, data, version):"},{"line_number":1923,"context_line":"        expected \u003d {"},{"line_number":1924,"context_line":"            \u0027share\u0027: {"},{"line_number":1925,"context_line":"                \u0027status\u0027: \u0027fakestatus\u0027,"},{"line_number":1926,"context_line":"                \u0027description\u0027: \u0027displaydesc\u0027,"},{"line_number":1927,"context_line":"                \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":1928,"context_line":"                \u0027name\u0027: \u0027displayname\u0027,"},{"line_number":1929,"context_line":"                \u0027share_proto\u0027: \u0027FAKEPROTO\u0027,"},{"line_number":1930,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1931,"context_line":"                \u0027project_id\u0027: \u0027fakeproject\u0027,"},{"line_number":1932,"context_line":"                \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":1933,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"},{"line_number":1934,"context_line":"                \u0027snapshot_id\u0027: \u00272\u0027,"},{"line_number":1935,"context_line":"                \u0027share_network_id\u0027: None,"},{"line_number":1936,"context_line":"                \u0027created_at\u0027: datetime.datetime(1, 1, 1, 1, 1, 1),"},{"line_number":1937,"context_line":"                \u0027size\u0027: 1,"},{"line_number":1938,"context_line":"                \u0027share_type_name\u0027: None,"},{"line_number":1939,"context_line":"                \u0027share_server_id\u0027: \u0027fake_share_server_id\u0027,"},{"line_number":1940,"context_line":"                \u0027share_type\u0027: \u00271\u0027,"},{"line_number":1941,"context_line":"                \u0027volume_type\u0027: \u00271\u0027,"},{"line_number":1942,"context_line":"                \u0027is_public\u0027: False,"},{"line_number":1943,"context_line":"                \u0027consistency_group_id\u0027: None,"},{"line_number":1944,"context_line":"                \u0027source_cgsnapshot_member_id\u0027: None,"},{"line_number":1945,"context_line":"                \u0027snapshot_support\u0027: True,"},{"line_number":1946,"context_line":"                \u0027task_state\u0027: None,"},{"line_number":1947,"context_line":"                \u0027links\u0027: ["},{"line_number":1948,"context_line":"                    {"},{"line_number":1949,"context_line":"                        \u0027href\u0027: \u0027http://localhost/v1/fake/shares/fake\u0027,"},{"line_number":1950,"context_line":"                        \u0027rel\u0027: \u0027self\u0027"},{"line_number":1951,"context_line":"                    },"},{"line_number":1952,"context_line":"                    {"},{"line_number":1953,"context_line":"                        \u0027href\u0027: \u0027http://localhost/fake/shares/fake\u0027,"},{"line_number":1954,"context_line":"                        \u0027rel\u0027: \u0027bookmark\u0027"},{"line_number":1955,"context_line":"                    }"},{"line_number":1956,"context_line":"                ],"},{"line_number":1957,"context_line":"            }"},{"line_number":1958,"context_line":"        }"},{"line_number":1959,"context_line":"        self._setup_manage_mocks()"},{"line_number":1960,"context_line":"        return_share \u003d mock.Mock("},{"line_number":1961,"context_line":"            return_value\u003dstubs.stub_share(\u0027fake\u0027, instance\u003d{}))"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a122d0e_dae8d87d","line":1958,"range":{"start_line":1923,"start_character":19,"end_line":1958,"end_character":9},"in_reply_to":"1a122d0e_9f1a0017","updated":"2016-05-05 16:35:34.000000000","message":"Thanks Tiago Pasqualini da Silva and Goutham Pacha Ravi. \nI will open another bug to refactor this expected dict(include v1 -\u003e v2). How about let this patch go on?","commit_id":"866888eca3afdc010db53a12b6c472eee1b8f8f3"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"06bd62a371de9f52fa6779a65c72ae4608816864","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], share[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"},{"line_number":140,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_0c7e6069","line":137,"updated":"2016-04-01 12:22:58.000000000","message":"Comparing the same object. That\u0027s useless","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0ef5efb246d9de6afdcd9a7c2dc8244eb189c376","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], share[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"},{"line_number":140,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_131d56bd","line":137,"in_reply_to":"ba0121b8_0c7e6069","updated":"2016-04-06 02:16:20.000000000","message":"Done","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEqual(share[\u0027share_proto\u0027], get[\u0027share_proto\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(self.st[\u0027share_type\u0027][\u0027name\u0027], get[\u0027share_type\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.6\")"},{"line_number":129,"context_line":"        self.assertEqual(self.st[\u0027share_type\u0027][\u0027id\u0027], get[\u0027share_type\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if utils.is_microversion_ge(version, \"2.8\"):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_adf18703","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":11},"updated":"2016-04-06 14:37:48.000000000","message":"why is this renamed?","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEqual(share[\u0027share_proto\u0027], get[\u0027share_proto\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(self.st[\u0027share_type\u0027][\u0027name\u0027], get[\u0027share_type\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.6\")"},{"line_number":129,"context_line":"        self.assertEqual(self.st[\u0027share_type\u0027][\u0027id\u0027], get[\u0027share_type\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if utils.is_microversion_ge(version, \"2.8\"):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_9b7e5d17","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":11},"in_reply_to":"9a061dce_adf18703","updated":"2016-04-07 06:53:03.000000000","message":"Because if this is named share, it will covered the original share(code line 102), and this share only get from version 2.6, so it not have \u0027user_id\u0027 parameter. I can not find the original share to compare.","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            self.assertFalse(get[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], get[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_0dba330a","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":11},"updated":"2016-04-06 14:37:48.000000000","message":"\u0027actual_share\u0027 or something like that is a better name than \u0027get\u0027","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            self.assertFalse(get[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], get[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_9ec64b98","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":11},"in_reply_to":"9a061dce_0dba330a","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79b6cbca0bbe8a2590bb1931a88d2d3eb4ec0130","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            self.assertFalse(get[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], get[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"},{"line_number":140,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_e17c3ab7","line":137,"range":{"start_line":136,"start_character":8,"end_line":137,"end_character":58},"updated":"2016-04-06 11:30:52.000000000","message":"To run such code you should verify that its microversion is supported. Look at line 131.","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            self.assertFalse(get[\u0027is_public\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.16\")"},{"line_number":137,"context_line":"        self.assertEqual(share[\u0027user_id\u0027], get[\u0027user_id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Delete share"},{"line_number":140,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_7ec37789","line":137,"range":{"start_line":136,"start_character":8,"end_line":137,"end_character":58},"in_reply_to":"9a061dce_e17c3ab7","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1df4a966a85c062c74744aae81d9235b9da9cb8","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":141,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            self.assertIsNone(actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Delete share"},{"line_number":146,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_df205efa","line":143,"range":{"start_line":143,"start_character":29,"end_line":143,"end_character":53},"updated":"2016-04-11 12:59:38.000000000","message":"You will get KeyError exception in that case. For the moment, none of tests call this method with different microversion than latest one.","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"18d37971e78e8ae3d85e390784ee9472ccb95908","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":141,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            self.assertIsNone(actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Delete share"},{"line_number":146,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_0a83c7cd","line":143,"range":{"start_line":143,"start_character":29,"end_line":143,"end_character":53},"in_reply_to":"7a1b2928_df205efa","updated":"2016-04-12 02:40:00.000000000","message":"Done","commit_id":"817d1522f7864ecbab0b0fea2e92f86337783745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e01074b1953ffad17e46d8dd3c5b643d1aa6e493","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":143,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Delete share"},{"line_number":148,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_094aab83","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":55},"updated":"2016-04-12 09:37:45.000000000","message":"This should be absent. It is bug if it exists with \"None\" value.","commit_id":"7b2579b4113d03dc96d7e7e78e2f57d2c9611753"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e01074b1953ffad17e46d8dd3c5b643d1aa6e493","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":160,"context_line":"    @ddt.data(\u00272.15\u0027, \u00272.16\u0027)"},{"line_number":161,"context_line":"    def test_manage_show_user_id(self, version):"},{"line_number":162,"context_line":"        self._test_manage(share\u003dself.shares[2], version\u003dversion)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":165,"context_line":"    def test_manage(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_6cda4d7a","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":46},"updated":"2016-04-12 09:37:45.000000000","message":"This share is already used in test above. You cannot use it.\n\nLook at third-party Ci results that run manage tests. They fail. They fail, because you use one share three times, and second with third tests fail. And should fail. Only unique share should be used for \"manage\" tests.","commit_id":"7b2579b4113d03dc96d7e7e78e2f57d2c9611753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"160a2947307de914d4466beb7c5c284ee072cffe","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                          is_public\u003dTrue,"},{"line_number":160,"context_line":"                          version\u003d\"2.8\")"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":163,"context_line":"    def test_manage_show_user_id(self):"},{"line_number":164,"context_line":"        self._test_manage(share\u003dself.shares[4], version\u003d\"2.16\")"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":167,"context_line":"    def test_manage(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_3ffaf9bd","side":"PARENT","line":164,"range":{"start_line":162,"start_character":4,"end_line":164,"end_character":63},"updated":"2016-04-13 10:50:50.000000000","message":"How is this part of the base revision? o.O","commit_id":"389257c8f03cb4c44d6c9a5434be5c7e36185b7e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"160a2947307de914d4466beb7c5c284ee072cffe","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        }}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Data for creating shares in parallel"},{"line_number":83,"context_line":"        data \u003d [creation_data, creation_data, creation_data, creation_data]"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"},{"line_number":86,"context_line":"        shares_created \u003d cls.create_shares(data)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_ffb081df","line":83,"range":{"start_line":83,"start_character":46,"end_line":83,"end_character":75},"updated":"2016-04-13 10:50:50.000000000","message":"Do you need two shares?","commit_id":"4a492d6a2eae36782c2eaf608b31997e702c6e8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"160a2947307de914d4466beb7c5c284ee072cffe","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":145,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":150,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_bf2ba9ea","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":58},"updated":"2016-04-13 10:50:50.000000000","message":"Valeriy\u0027s right.. you should check that the key isn\u0027t present in the JSON response\n\nThis should be \n\n    self.assertFalse(hasattr(actual_share, \u0027user_id\u0027))","commit_id":"4a492d6a2eae36782c2eaf608b31997e702c6e8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"160a2947307de914d4466beb7c5c284ee072cffe","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":176,"context_line":"    @ddt.data(\u00272.15\u0027, \u00272.16\u0027)"},{"line_number":177,"context_line":"    def test_manage_show_user_id(self, version):"},{"line_number":178,"context_line":"        self._test_manage(share\u003dself.shares[2], version\u003dversion)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":181,"context_line":"    def test_manage(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_3f7dd91c","line":178,"range":{"start_line":177,"start_character":5,"end_line":178,"end_character":64},"updated":"2016-04-13 10:50:50.000000000","message":"1) This method has the same name as the one on line 172. \n2) Do not reuse self.shares[2]. You should probably create a new share in resource_setup just like self.shares[0], [1] and [2]","commit_id":"4a492d6a2eae36782c2eaf608b31997e702c6e8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            self.assertFalse(actual_share[\u0027is_public\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        actual_share \u003d self.shares_v2_client.get_share("},{"line_number":141,"context_line":"            share[\u0027id\u0027], version\u003dversion)"},{"line_number":142,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":143,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_d20e098b","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":41},"updated":"2016-04-14 16:00:41.000000000","message":"Why get again? it\u0027s already done in line 122","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            self.assertFalse(actual_share[\u0027is_public\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        actual_share \u003d self.shares_v2_client.get_share("},{"line_number":141,"context_line":"            share[\u0027id\u0027], version\u003dversion)"},{"line_number":142,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":143,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_083b72d2","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":41},"in_reply_to":"5a18252c_d20e098b","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        actual_share \u003d self.shares_v2_client.get_share("},{"line_number":141,"context_line":"            share[\u0027id\u0027], version\u003dversion)"},{"line_number":142,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":143,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":148,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_6672d312","line":145,"range":{"start_line":142,"start_character":8,"end_line":145,"end_character":58},"updated":"2016-04-14 16:00:41.000000000","message":"this should be removed.","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        actual_share \u003d self.shares_v2_client.get_share("},{"line_number":141,"context_line":"            share[\u0027id\u0027], version\u003dversion)"},{"line_number":142,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":143,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":148,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_e83556db","line":145,"range":{"start_line":142,"start_character":8,"end_line":145,"end_character":58},"in_reply_to":"5a18252c_6672d312","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":148,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            self.assertNotIn(\u0027user_id\u0027, actual_share)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Delete share"},{"line_number":153,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_4656b75c","line":150,"range":{"start_line":147,"start_character":8,"end_line":150,"end_character":53},"updated":"2016-04-14 16:00:41.000000000","message":"This should be part of this patch and not https://review.openstack.org/#/c/305006/2/manila_tempest_tests/tests/api/admin/test_share_manage.py","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            self.assertIsNone(actual_share.get(\u0027user_id\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_ge(version, \"2.16\"):"},{"line_number":148,"context_line":"            self.assertEqual(share[\u0027user_id\u0027], actual_share[\u0027user_id\u0027])"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            self.assertNotIn(\u0027user_id\u0027, actual_share)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Delete share"},{"line_number":153,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_48356ad8","line":150,"range":{"start_line":147,"start_character":8,"end_line":150,"end_character":53},"in_reply_to":"5a18252c_4656b75c","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a69a4b1892b78143861826d44a9ee9ccb637786e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        for share in shares_created:"},{"line_number":93,"context_line":"            # Unmanage shares from manila"},{"line_number":94,"context_line":"            get_share \u003d cls.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":95,"context_line":"            get_share[\"export_locations\"] \u003d ("},{"line_number":96,"context_line":"                cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":97,"context_line":"                .get(\"export_locations\"))"},{"line_number":98,"context_line":"            cls.shares.append(get_share)"},{"line_number":99,"context_line":"            cls.shares_client.unmanage_share(share[\u0027id\u0027])"},{"line_number":100,"context_line":"            cls.shares_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_9dd170d0","line":97,"range":{"start_line":95,"start_character":12,"end_line":97,"end_character":41},"updated":"2016-04-25 16:27:27.000000000","message":"It is incorrect API to be used for getting export locations. Should be following:\n\n\"\"\"\nget_share \u003d cls.shares_v2_client.get_share(share[\u0027id\u0027])\nif utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.9\"):\n    get_share[\"export_locations\"] \u003d cls.shares_v2_client.list_share_export_locations(share[\"id\"])\ncls.shares.append(get_share)\n\n\"\"\"","commit_id":"fe484764caf51f00bd426bf8c8a99e16d7f6dd37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5efd69101f8651ef1bfbcf684a34406132b1235","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        for share in shares_created:"},{"line_number":93,"context_line":"            # Unmanage shares from manila"},{"line_number":94,"context_line":"            get_share \u003d cls.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":95,"context_line":"            get_share[\"export_locations\"] \u003d ("},{"line_number":96,"context_line":"                cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":97,"context_line":"                .get(\"export_locations\"))"},{"line_number":98,"context_line":"            cls.shares.append(get_share)"},{"line_number":99,"context_line":"            cls.shares_client.unmanage_share(share[\u0027id\u0027])"},{"line_number":100,"context_line":"            cls.shares_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_f35d3516","line":97,"range":{"start_line":95,"start_character":12,"end_line":97,"end_character":41},"in_reply_to":"1a122d0e_9dd170d0","updated":"2016-04-25 17:06:45.000000000","message":"+1","commit_id":"fe484764caf51f00bd426bf8c8a99e16d7f6dd37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b2a5d67b882d1bf7d6ba0895a4f29294e84d69f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            get_share \u003d cls.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":95,"context_line":"            if utils.is_microversion_ge("},{"line_number":96,"context_line":"                    CONF.share.max_api_microversion, \"2.9\"):"},{"line_number":97,"context_line":"                get_share[\"export_locations\"] \u003d ("},{"line_number":98,"context_line":"                    cls.shares_v2_client"},{"line_number":99,"context_line":"                    .list_share_export_locations(share[\"id\"]))"},{"line_number":100,"context_line":"            cls.shares.append(get_share)"},{"line_number":101,"context_line":"            cls.shares_client.unmanage_share(share[\u0027id\u0027])"},{"line_number":102,"context_line":"            cls.shares_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":20,"id":"1a122d0e_4c37234d","line":99,"range":{"start_line":97,"start_character":16,"end_line":99,"end_character":62},"updated":"2016-04-26 04:16:36.000000000","message":"This wrapping looks a little wonky:\n\n                  get_share[\"export_locations\"] \u003d (\n                        cls.shares_v2_client.list_share_export_locations(\n                            share[\"id\"])\n                    )\n\n\nIf you make another patch","commit_id":"0f72e053cce2a8515312959c3317a6df08e98054"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"06bd62a371de9f52fa6779a65c72ae4608816864","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            detailed_elements.add(\u0027replication_type\u0027)"},{"line_number":85,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if utils.is_microversion_supported(\u00272.16\u0027):"},{"line_number":88,"context_line":"            detailed_elements.add(\u0027user_id\u0027)"},{"line_number":89,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_6cc71c96","line":87,"updated":"2016-04-01 12:22:58.000000000","message":"Can you add a comment as done for the other checks below?","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0ef5efb246d9de6afdcd9a7c2dc8244eb189c376","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            detailed_elements.add(\u0027replication_type\u0027)"},{"line_number":85,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if utils.is_microversion_supported(\u00272.16\u0027):"},{"line_number":88,"context_line":"            detailed_elements.add(\u0027user_id\u0027)"},{"line_number":89,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_1373964e","line":87,"in_reply_to":"ba0121b8_6cc71c96","updated":"2016-04-06 02:16:20.000000000","message":"Done","commit_id":"f513b01c810589078c9f74a570f516d1b2d37c0f"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6977540e9b985de792a09ed04e8a172fd4b70af3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            detailed_elements.add(\u0027replication_type\u0027)"},{"line_number":85,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # In v 2.16 and beyond,  - we add user_id in show/create/manage"},{"line_number":88,"context_line":"        # share echo."},{"line_number":89,"context_line":"        if utils.is_microversion_supported(\u00272.16\u0027):"},{"line_number":90,"context_line":"            detailed_elements.add(\u0027user_id\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_e9a53c47","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":35},"updated":"2016-04-06 12:48:03.000000000","message":"Please remove this","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            detailed_elements.add(\u0027replication_type\u0027)"},{"line_number":85,"context_line":"            self.assertTrue(detailed_elements.issubset(share.keys()), msg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # In v 2.16 and beyond,  - we add user_id in show/create/manage"},{"line_number":88,"context_line":"        # share echo."},{"line_number":89,"context_line":"        if utils.is_microversion_supported(\u00272.16\u0027):"},{"line_number":90,"context_line":"            detailed_elements.add(\u0027user_id\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_debc4308","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":35},"in_reply_to":"9a061dce_e9a53c47","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            keys.append(\"share_type_name\")"},{"line_number":198,"context_line":"        if utils.is_microversion_ge(version, \u00272.10\u0027):"},{"line_number":199,"context_line":"            keys.append(\"access_rules_status\")"},{"line_number":200,"context_line":"        if utils.is_microversion_ge(version, \u00272.11\u0027):"},{"line_number":201,"context_line":"            keys.append(\"replication_type\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        [self.assertIn(key, sh.keys()) for sh in shares for key in keys]"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_81b71939","line":201,"range":{"start_line":200,"start_character":8,"end_line":201,"end_character":43},"updated":"2016-04-14 16:00:41.000000000","message":"You should add it here as well?","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            keys.append(\"share_type_name\")"},{"line_number":198,"context_line":"        if utils.is_microversion_ge(version, \u00272.10\u0027):"},{"line_number":199,"context_line":"            keys.append(\"access_rules_status\")"},{"line_number":200,"context_line":"        if utils.is_microversion_ge(version, \u00272.11\u0027):"},{"line_number":201,"context_line":"            keys.append(\"replication_type\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        [self.assertIn(key, sh.keys()) for sh in shares for key in keys]"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_2830eee7","line":201,"range":{"start_line":200,"start_character":8,"end_line":201,"end_character":43},"in_reply_to":"5a18252c_81b71939","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":240,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.11\u0027)"},{"line_number":241,"context_line":"    def test_list_shares_with_detail_replication_type_key(self):"},{"line_number":242,"context_line":"        self._list_shares_with_detail(\u00272.11\u0027)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":245,"context_line":"    def test_list_shares_with_detail_filter_by_metadata(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a18252c_e17ecd68","line":242,"range":{"start_line":242,"start_character":43,"end_line":242,"end_character":45},"updated":"2016-04-14 16:00:41.000000000","message":"Add a test here as well?","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":240,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.11\u0027)"},{"line_number":241,"context_line":"    def test_list_shares_with_detail_replication_type_key(self):"},{"line_number":242,"context_line":"        self._list_shares_with_detail(\u00272.11\u0027)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":245,"context_line":"    def test_list_shares_with_detail_filter_by_metadata(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_884dc274","line":242,"range":{"start_line":242,"start_character":43,"end_line":242,"end_character":45},"in_reply_to":"5a18252c_e17ecd68","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"}],"releasenotes/notes/add-user-id-echo-8f42db469b27ff14.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9efb3c543106170a499d4f0fe2e73ee132d2b3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_4d0b8b8e","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":44},"updated":"2016-04-06 14:37:48.000000000","message":"This shows reliance on python-manilaclient\n\n\n\"User ID is added to the JSON response of /shares APIs\"","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_1e07dbca","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":44},"in_reply_to":"9a061dce_4d0b8b8e","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79b6cbca0bbe8a2590bb1931a88d2d3eb4ec0130","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_210bd28f","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":32},"updated":"2016-04-06 11:30:52.000000000","message":"s/api/API/","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_fe0b07d4","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":32},"in_reply_to":"9a061dce_210bd28f","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79b6cbca0bbe8a2590bb1931a88d2d3eb4ec0130","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_01da0e17","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":21},"updated":"2016-04-06 11:30:52.000000000","message":"s/create/created/","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"70f92bb30df2328dddebceb5d517a227698fc7ff","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage api. Make the operator know"},{"line_number":5,"context_line":"    which user create this share."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_5e0dd3e6","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":21},"in_reply_to":"9a061dce_01da0e17","updated":"2016-04-07 06:53:03.000000000","message":"Done","commit_id":"64cd9faa3fcafd9e17235195c14e2bf255eab9b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"952f7f23b37ff586d93306d726b198a4ff33d052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage API. User ID is added"},{"line_number":5,"context_line":"    to the JSON response of /shares APIs. Make the"},{"line_number":6,"context_line":"    operator know which user created this share."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_8adf0439","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":48},"updated":"2016-04-07 14:51:32.000000000","message":"This is redundant info.. \n\n\n    ---\n    features:\n      - User ID is added to the JSON response of the /shares APIs\n\n\nis sufficient, imho","commit_id":"40064b27d5981aa091b483472fe4e6890887032e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea195d780df08fe77dcdf90f6977a378c26aa073","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage API. User ID is added"},{"line_number":5,"context_line":"    to the JSON response of /shares APIs. Make the"},{"line_number":6,"context_line":"    operator know which user created this share."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_479e8cb9","line":6,"range":{"start_line":5,"start_character":42,"end_line":6,"end_character":17},"updated":"2016-04-07 13:25:24.000000000","message":"nit if you upload another patch: please change to \"Allow the operator to know ...\"","commit_id":"40064b27d5981aa091b483472fe4e6890887032e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c651ea41fcad557cbd3dd186719a87c313653ff5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage API. User ID is added"},{"line_number":5,"context_line":"    to the JSON response of /shares APIs. Make the"},{"line_number":6,"context_line":"    operator know which user created this share."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_a60ae5cf","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":48},"in_reply_to":"9a061dce_8adf0439","updated":"2016-04-08 01:28:00.000000000","message":":) done","commit_id":"40064b27d5981aa091b483472fe4e6890887032e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6c0d01714dc59d400125ba82b876c753897f9c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage API. User ID is added"},{"line_number":5,"context_line":"    to the JSON response of /shares APIs. Make the"},{"line_number":6,"context_line":"    operator know which user created this share."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a18252c_414d013d","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":48},"updated":"2016-04-14 16:00:41.000000000","message":"You had this corrected in Patchset 10.. what happened?","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8d6ed59b9e4b74331fca0a24a36906539da77853","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \"user_id\" detail when we run command"},{"line_number":4,"context_line":"    share show/create/manage API. User ID is added"},{"line_number":5,"context_line":"    to the JSON response of /shares APIs. Make the"},{"line_number":6,"context_line":"    operator know which user created this share."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a122d0e_c857ba00","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":48},"in_reply_to":"5a18252c_414d013d","updated":"2016-04-25 01:28:23.000000000","message":"Done","commit_id":"b6fd38040a965a6a290244f2163721da5dd06c5d"}]}