)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7e48b5d5594fd0921c322998c9be8d2d1cd863fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     maqi \u003cmaqi@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-29 16:53:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic dirver:ignore VolumeNotFound in deleting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the volume is already deleted, the share"},{"line_number":10,"context_line":"will be in error_deleting if a deleting request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_b4c49992","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":17},"updated":"2016-03-29 11:26:40.000000000","message":"add a space after \":\"","commit_id":"faf80ed1d335b07b11705dd5352f45047273220a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7e48b5d5594fd0921c322998c9be8d2d1cd863fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     maqi \u003cmaqi@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-29 16:53:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic dirver:ignore VolumeNotFound in deleting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the volume is already deleted, the share"},{"line_number":10,"context_line":"will be in error_deleting if a deleting request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_74ca01a3","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"updated":"2016-03-29 11:26:40.000000000","message":"s/dirver/driver","commit_id":"faf80ed1d335b07b11705dd5352f45047273220a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7e48b5d5594fd0921c322998c9be8d2d1cd863fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic dirver:ignore VolumeNotFound in deleting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the volume is already deleted, the share"},{"line_number":10,"context_line":"will be in error_deleting if a deleting request"},{"line_number":11,"context_line":"is initiated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I82d70b9997a689dd3fd8eefad7dc14c39f9d275a"},{"line_number":14,"context_line":"Closes-Bug: #1563226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_1463c5b2","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":13},"updated":"2016-03-29 11:26:40.000000000","message":"You could describe your fix instead of only describing the problem.","commit_id":"faf80ed1d335b07b11705dd5352f45047273220a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"98c099a3307ce9e59ed1e4a9cea95970a6ddc5ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     maqi \u003cmaqi@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-29 19:32:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic dirver: ignore VolumeNotFound in deleting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the volume is already deleted, the share"},{"line_number":10,"context_line":"will be in error_deleting if a deleting request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_6f5cee25","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"updated":"2016-03-29 11:39:47.000000000","message":"s/dirver/driver","commit_id":"0443ef0144447ed0908a73efe8db90397f8a31fb"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7e48b5d5594fd0921c322998c9be8d2d1cd863fa","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            try:"},{"line_number":503,"context_line":"                volume \u003d self._get_volume(context, share[\u0027id\u0027])"},{"line_number":504,"context_line":"            except exception.VolumeNotFound:"},{"line_number":505,"context_line":"                LOG.info(_LI(\"Volume not found. Already deleted?\"))"},{"line_number":506,"context_line":"                volume \u003d None"},{"line_number":507,"context_line":"            if volume and volume[\u0027id\u0027] in attached_volumes:"},{"line_number":508,"context_line":"                self.compute_api.instance_volume_detach("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_b472d97a","line":505,"range":{"start_line":505,"start_character":36,"end_line":505,"end_character":40},"updated":"2016-03-29 11:26:40.000000000","message":"you could print the share[\u0027id\u0027] here","commit_id":"faf80ed1d335b07b11705dd5352f45047273220a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"98c099a3307ce9e59ed1e4a9cea95970a6ddc5ff","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            try:"},{"line_number":503,"context_line":"                volume \u003d self._get_volume(context, share[\u0027id\u0027])"},{"line_number":504,"context_line":"            except exception.VolumeNotFound:"},{"line_number":505,"context_line":"                LOG.info(_LI(\"Volume not found. Already deleted?\"))"},{"line_number":506,"context_line":"                volume \u003d None"},{"line_number":507,"context_line":"            if volume and volume[\u0027id\u0027] in attached_volumes:"},{"line_number":508,"context_line":"                self.compute_api.instance_volume_detach("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_d47e6dad","line":505,"range":{"start_line":505,"start_character":20,"end_line":505,"end_character":28},"updated":"2016-03-29 11:39:47.000000000","message":"I wouldn\u0027t use info for this kind of message, usually a warning because this is unexpected.","commit_id":"0443ef0144447ed0908a73efe8db90397f8a31fb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"98c099a3307ce9e59ed1e4a9cea95970a6ddc5ff","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            try:"},{"line_number":503,"context_line":"                volume \u003d self._get_volume(context, share[\u0027id\u0027])"},{"line_number":504,"context_line":"            except exception.VolumeNotFound:"},{"line_number":505,"context_line":"                LOG.info(_LI(\"Volume not found. Already deleted?\"))"},{"line_number":506,"context_line":"                volume \u003d None"},{"line_number":507,"context_line":"            if volume and volume[\u0027id\u0027] in attached_volumes:"},{"line_number":508,"context_line":"                self.compute_api.instance_volume_detach("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4f4daa71","line":505,"range":{"start_line":505,"start_character":35,"end_line":505,"end_character":38},"updated":"2016-03-29 11:39:47.000000000","message":"print share[\u0027id\u0027] in message. like: \"Volume %s not found. Possibly already deleted.\", share[\u0027id\u0027]","commit_id":"0443ef0144447ed0908a73efe8db90397f8a31fb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8494cd1456e407d7ee3beffe00f1bb67ed6a51fe","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                volume \u003d self._get_volume(context, share[\u0027id\u0027])"},{"line_number":504,"context_line":"            except exception.VolumeNotFound:"},{"line_number":505,"context_line":"                LOG.warning(_LW(\"Volume not found for share %s. \""},{"line_number":506,"context_line":"                                \"Possibly already deleted.\" % share[\u0027id\u0027]))"},{"line_number":507,"context_line":"                volume \u003d None"},{"line_number":508,"context_line":"            if volume and volume[\u0027id\u0027] in attached_volumes:"},{"line_number":509,"context_line":"                self.compute_api.instance_volume_detach("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_4c4c91c7","line":506,"range":{"start_line":506,"start_character":59,"end_line":506,"end_character":63},"updated":"2016-03-29 13:26:29.000000000","message":"use comma instead of % here","commit_id":"e81a8835f04645165f364a6ec107ee9dc44c61b0"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"1c2a6aca32f10710e152d82bec2012dc21274c8d","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                volume \u003d self._get_volume(context, share[\u0027id\u0027])"},{"line_number":504,"context_line":"            except exception.VolumeNotFound:"},{"line_number":505,"context_line":"                LOG.warning(_LW(\"Volume not found for share %s. \""},{"line_number":506,"context_line":"                                \"Possibly already deleted.\" % share[\u0027id\u0027]))"},{"line_number":507,"context_line":"                volume \u003d None"},{"line_number":508,"context_line":"            if volume and volume[\u0027id\u0027] in attached_volumes:"},{"line_number":509,"context_line":"                self.compute_api.instance_volume_detach("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_a04d6c74","line":506,"range":{"start_line":506,"start_character":59,"end_line":506,"end_character":63},"in_reply_to":"ba0121b8_4c4c91c7","updated":"2016-03-29 14:16:48.000000000","message":"OK, thanks!","commit_id":"e81a8835f04645165f364a6ec107ee9dc44c61b0"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"98c099a3307ce9e59ed1e4a9cea95970a6ddc5ff","unresolved":false,"context_lines":[{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def test_detach_volume_with_volume_not_found(self):"},{"line_number":1058,"context_line":"        fake_vol \u003d fake_volume.FakeVolume()"},{"line_number":1059,"context_line":"        self.mock_object(self._driver.compute_api, \u0027instance_volumes_list\u0027,"},{"line_number":1060,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":1061,"context_line":"        self.mock_object(self._driver, \u0027_get_volume\u0027,"},{"line_number":1062,"context_line":"                         mock.Mock(side_effect\u003dexception.VolumeNotFound("},{"line_number":1063,"context_line":"                             volume_id\u003dfake_vol[\u0027id\u0027])))"},{"line_number":1064,"context_line":"        self._driver._detach_volume(self._context,"},{"line_number":1065,"context_line":"                                    self.share,"},{"line_number":1066,"context_line":"                                    mock.MagicMock())"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_af10c64f","line":1063,"range":{"start_line":1059,"start_character":4,"end_line":1063,"end_character":56},"updated":"2016-03-29 11:39:47.000000000","message":"you can add \"assert_called_once_with\" related to those.","commit_id":"0443ef0144447ed0908a73efe8db90397f8a31fb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8494cd1456e407d7ee3beffe00f1bb67ed6a51fe","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                                    self.share,"},{"line_number":1068,"context_line":"                                    fake_server_details)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"        self._driver.compute_api.instance_volumes_list.\\"},{"line_number":1071,"context_line":"            assert_called_once_with(self._driver.admin_context,"},{"line_number":1072,"context_line":"                                    fake_server_details[\u0027instance_id\u0027])"},{"line_number":1073,"context_line":"        self._driver._get_volume.\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_6cfd153a","line":1070,"range":{"start_line":1070,"start_character":54,"end_line":1070,"end_character":56},"updated":"2016-03-29 13:26:29.000000000","message":"surround your statement with parenthesis to prevent using \"\\\"","commit_id":"e81a8835f04645165f364a6ec107ee9dc44c61b0"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a1cd0001266c6b398ae0347e8100e3723ba7a021","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                                    self.share,"},{"line_number":1068,"context_line":"                                    fake_server_details)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"        self._driver.compute_api.instance_volumes_list.\\"},{"line_number":1071,"context_line":"            assert_called_once_with(self._driver.admin_context,"},{"line_number":1072,"context_line":"                                    fake_server_details[\u0027instance_id\u0027])"},{"line_number":1073,"context_line":"        self._driver._get_volume.\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_1b42c93e","line":1070,"range":{"start_line":1070,"start_character":54,"end_line":1070,"end_character":56},"in_reply_to":"ba0121b8_601eb464","updated":"2016-03-29 14:27:46.000000000","message":"Apparently Rodrigo is suggesting to put the entire statement in parentheses.\nLike this:\n(self._driver.\n    foo.bar(...))","commit_id":"e81a8835f04645165f364a6ec107ee9dc44c61b0"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"1c2a6aca32f10710e152d82bec2012dc21274c8d","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                                    self.share,"},{"line_number":1068,"context_line":"                                    fake_server_details)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"        self._driver.compute_api.instance_volumes_list.\\"},{"line_number":1071,"context_line":"            assert_called_once_with(self._driver.admin_context,"},{"line_number":1072,"context_line":"                                    fake_server_details[\u0027instance_id\u0027])"},{"line_number":1073,"context_line":"        self._driver._get_volume.\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_601eb464","line":1070,"range":{"start_line":1070,"start_character":54,"end_line":1070,"end_character":56},"in_reply_to":"ba0121b8_6cfd153a","updated":"2016-03-29 14:16:48.000000000","message":"Like this?\n        self._driver.compute_api.instance_volumes_list.assert_called_once_with(\n            self._driver.admin_context, fake_server_details[\u0027instance_id\u0027])\n\nBut \"self._driver.compute_api.instance_volumes_list.assert_called_once_with(\" is more than 79 characters.","commit_id":"e81a8835f04645165f364a6ec107ee9dc44c61b0"}]}
