)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"23253a060490401ad35baf6372872f9612e6b9c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A snapshot of a share created by cephfs_native driver can be read from"},{"line_number":10,"context_line":"its corresponding snapshot directory created within the share. The"},{"line_number":11,"context_line":"snapshot directory is named using the snapshot instance ID, which"},{"line_number":12,"context_line":"would be visible only to admins. In effect, a non-admin user would not"},{"line_number":13,"context_line":"be able to read the snapshot\u0027s contents."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_605d9146","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":58},"updated":"2016-03-31 14:40:02.000000000","message":"It is false statement. You use \"snapshot_id\", not \"snapshot_instance_id\".","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4c08f693f14ba8c37489f5420b6f12056e215c0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A snapshot of a share created by cephfs_native driver can be read from"},{"line_number":10,"context_line":"its corresponding snapshot directory created within the share. The"},{"line_number":11,"context_line":"snapshot directory is named using the snapshot instance ID, which"},{"line_number":12,"context_line":"would be visible only to admins. In effect, a non-admin user would not"},{"line_number":13,"context_line":"be able to read the snapshot\u0027s contents."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_13b4e632","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":58},"in_reply_to":"ba0121b8_605d9146","updated":"2016-03-31 16:33:56.000000000","message":"Here I\u0027m stating the problem (use of snapshot instance IDs) and not the solution (instead use snapshot IDs), which I mention in lines 15 and 16.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"}],"manila/share/drivers/cephfs/cephfs_native.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"63fece07887592aa5955ccc6d22deb770a4c9d4d","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_009775ec","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"updated":"2016-03-31 14:38:09.000000000","message":"It is recommended to use snapshot[\u0027id\u0027] which is \"snapshot_instance_id\". To avoid port problems when replication support is added.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"61c2f2fe4e7856aa60c5bc3b0f98afbbe332fbf4","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a8ed47f1","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"9a061dce_0c12b9b4","updated":"2016-04-05 10:23:52.000000000","message":"Done","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"d1c4b86b83a67622b99c028703d31df5973d3114","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_6c79b52f","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"9a061dce_6979a72f","updated":"2016-04-04 13:16:41.000000000","message":"So it seems like Valeriy is saying these names should be unique like instance IDs (i.e. not use snapshot IDs), but we would like users to be able to associate the snapshot IDs from Manila with the snapshot names they see in Ceph.  It would probably work to use the concatenation of snapshot ID and snapshot instance ID as the Ceph snapshot name, that way it\u0027s unique per instance, but also recognisable by snapshot ID.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"61c2f2fe4e7856aa60c5bc3b0f98afbbe332fbf4","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e8d61f26","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"9a061dce_6c79b52f","updated":"2016-04-05 10:23:52.000000000","message":"Thanks for the explanation and the suggestion.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ba793d6b6f0266bec429d5d95bceee7b517cc40b","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0c12b9b4","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"9a061dce_6c79b52f","updated":"2016-04-04 13:18:15.000000000","message":"combination of two is ok.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f8655de4a5ba786ff9c1d3e2eff504618c04c118","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_6979a72f","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"9a061dce_ea03ea74","updated":"2016-04-04 13:03:52.000000000","message":"If yes, then it is unexpected behaviour of Manila share.\n\nIf no, then no problem to use \"snapshot_instance_id\".\n\nIn any case, something if wrong here.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"4c08f693f14ba8c37489f5420b6f12056e215c0b","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_30580056","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"ba0121b8_009775ec","updated":"2016-03-31 16:33:56.000000000","message":"The whole point of this patch is to name the ceph snapshot dirs with snapshot IDs (visible to all users) and *not* snapshot instance IDs (visible only to admins) for the sake of visibility/identification of snapshot dirs to general users. I don\u0027t get what porting problems you foresee? Shouldn\u0027t that be taken care of replication support anyway? What do you otherwise suggest I do to address the bug that this patch intends to address, because your solution would not fix the bug?","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66cf06c9d4fdace3e10e251e76d6e2a6460bf786","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":289,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":290,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_ea03ea74","line":290,"range":{"start_line":290,"start_character":59,"end_line":290,"end_character":70},"in_reply_to":"ba0121b8_30580056","updated":"2016-04-04 12:28:54.000000000","message":"You want to say that user will see all snapshots inside of his share?","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"63fece07887592aa5955ccc6d22deb770a4c9d4d","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":293,"context_line":"        self.volume_client.destroy_snapshot_volume("},{"line_number":294,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027snapshot_id\u0027])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def create_consistency_group(self, context, cg_dict, share_server\u003dNone):"},{"line_number":297,"context_line":"        self.volume_client.create_group(cg_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_409ded08","line":294,"range":{"start_line":294,"start_character":60,"end_line":294,"end_character":70},"updated":"2016-03-31 14:38:09.000000000","message":"Same here.","commit_id":"67365d2933ef44314d7ef004a363104af7db410a"}]}
