)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"53149eb86707270f7e1816017013694951586879","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t check server connection if it w/o IP addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case the server doesn\u0027t have an IP addr in"},{"line_number":10,"context_line":"database (its status is error), don\u0027t check"},{"line_number":11,"context_line":"server connection with connecting port 22."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_1679d02f","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":11},"updated":"2016-03-30 10:26:27.000000000","message":"s/the/a/","commit_id":"5903b37019e60ac4352d4f9207a54f8fefe4a294"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"53149eb86707270f7e1816017013694951586879","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t check server connection if it w/o IP addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case the server doesn\u0027t have an IP addr in"},{"line_number":10,"context_line":"database (its status is error), don\u0027t check"},{"line_number":11,"context_line":"server connection with connecting port 22."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I640ffc065cf111e92027ac77a7e78e9ba5af4d86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_d69d985a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":8},"updated":"2016-03-30 10:26:27.000000000","message":"Does it mean that it has, in fact, an address and this is a DB issue?","commit_id":"5903b37019e60ac4352d4f9207a54f8fefe4a294"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"9e7e8cbd222df6968c87a1a8ca1af696607431f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t check server connection if it w/o IP addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case the server doesn\u0027t have an IP addr in"},{"line_number":10,"context_line":"database (its status is error), don\u0027t check"},{"line_number":11,"context_line":"server connection with connecting port 22."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I640ffc065cf111e92027ac77a7e78e9ba5af4d86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_97b809ca","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"ba0121b8_d69d985a","updated":"2016-03-31 01:27:28.000000000","message":"I\u0027m not sure if it\u0027s a DB issue. I will reword to make it less confusion. Thanks for your comments.","commit_id":"5903b37019e60ac4352d4f9207a54f8fefe4a294"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"22c7777f80bf8ddabd242eafac25d787fe365b31","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t check server connection if it w/o IP addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case a server doesn\u0027t have an IP addr"},{"line_number":10,"context_line":"(its status is error), don\u0027t check server connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I640ffc065cf111e92027ac77a7e78e9ba5af4d86"},{"line_number":13,"context_line":"Closes-Bug: #1563752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_47287ce2","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":20},"updated":"2016-03-31 07:10:39.000000000","message":"Is the lack of IP the only failure indicator? Maybe it is better to check for server being in error state rather than for the lack of IP? This will probably cover more possible failure scenarios.","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"a9605de35fc7b385424d10221bc7c9f25f89fb63","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t check server connection if it w/o IP addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case a server doesn\u0027t have an IP addr"},{"line_number":10,"context_line":"(its status is error), don\u0027t check server connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I640ffc065cf111e92027ac77a7e78e9ba5af4d86"},{"line_number":13,"context_line":"Closes-Bug: #1563752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_d6c0a352","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":20},"in_reply_to":"ba0121b8_47287ce2","updated":"2016-03-31 15:10:54.000000000","message":"I will look at the old logs to find the root cause. At the same time I will upload a partial fix.","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"22c7777f80bf8ddabd242eafac25d787fe365b31","unresolved":false,"context_lines":[{"line_number":10,"context_line":"(its status is error), don\u0027t check server connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I640ffc065cf111e92027ac77a7e78e9ba5af4d86"},{"line_number":13,"context_line":"Closes-Bug: #1563752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_272468c3","line":13,"updated":"2016-03-31 07:10:39.000000000","message":"I believe this patch provides only a partial fix since the root cause for the lack of IP is not clear yet and not fixed and this change only mitigates some side effects of it.","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"53149eb86707270f7e1816017013694951586879","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            return False"},{"line_number":621,"context_line":"        t \u003d time.time()"},{"line_number":622,"context_line":"        while time.time() - t \u003c self.max_time_to_build_instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_76a12ca3","line":619,"updated":"2016-03-30 10:26:27.000000000","message":"I believe this deserves at least a warning message.","commit_id":"5903b37019e60ac4352d4f9207a54f8fefe4a294"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"73b0f0bd0614eaf0ae854641e10ba2b573ced5ef","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            return False"},{"line_number":621,"context_line":"        t \u003d time.time()"},{"line_number":622,"context_line":"        while time.time() - t \u003c self.max_time_to_build_instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_03d35105","line":619,"in_reply_to":"ba0121b8_76a12ca3","updated":"2016-03-30 11:03:00.000000000","message":"+1","commit_id":"5903b37019e60ac4352d4f9207a54f8fefe4a294"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"22c7777f80bf8ddabd242eafac25d787fe365b31","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":621,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":622,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_07104458","line":619,"updated":"2016-03-31 07:10:39.000000000","message":"What do you think about checking server status?","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0460286af7bdcf94cd8f4361ec6f39245b5c8d92","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":621,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":622,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_d9046119","line":619,"in_reply_to":"ba0121b8_07104458","updated":"2016-03-31 12:46:41.000000000","message":"I agree with Alexey\u0027s thought that you may be able to check for something more fundamental if these fields are missing.  One really wants to know why they are missing.","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"a9605de35fc7b385424d10221bc7c9f25f89fb63","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":621,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":622,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_96710b47","line":619,"in_reply_to":"ba0121b8_d9046119","updated":"2016-03-31 15:10:54.000000000","message":"Yes, you are right. I will investigate the old logs why these fields are missing. At the same time I will upload a partial fix.","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1d97306a27b6eaf00e04fbb9b4a1f9d560b0698b","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":621,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":622,"context_line":"            return False"},{"line_number":623,"context_line":"        t \u003d time.time()"},{"line_number":624,"context_line":"        while time.time() - t \u003c self.max_time_to_build_instance:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_300e513b","line":621,"range":{"start_line":621,"start_character":24,"end_line":621,"end_character":55},"updated":"2016-03-31 12:34:33.000000000","message":"Instance ID can be absent as well as IP address.\n\nAnd it is the reason for failure of unit tests.\n\nSee http://logs.openstack.org/63/299263/3/check/gate-manila-python27-db/e3b2322/testr_results.html.gz","commit_id":"5f0fffeb9c292ddb23ac1b26a21905f04d2c5399"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"77db30b7779c705a0196ebced53a797f0970c574","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        return {}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":619,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":620,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":621,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":622,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_4f569506","line":619,"updated":"2016-04-01 08:08:46.000000000","message":"I am still suggesting to check for error state rather than for the lack of an IP. Or at least to add a comment describing why it is ok to check for the IP only.","commit_id":"f5b0cad26a21e4c54ba0ce6f3e4fbf8e074238fd"},{"author":{"_account_id":20160,"name":"haobing1","email":"bing.hao@easystack.cn","username":"haobing"},"change_message_id":"014089e777149eb8fb02cc9d52369c59085e2a64","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        return {}"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":594,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":595,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":596,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":597,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_0fe7cbe6","line":594,"range":{"start_line":594,"start_character":11,"end_line":594,"end_character":40},"updated":"2018-03-26 15:52:37.000000000","message":"Maybe we can use \u0027if not instance_details.get(\u0027ip\u0027, None):\u0027 prevent the instance_details has {..., \u0027ip\u0027: \u0027\u0027} case!","commit_id":"f956283a8e91b1d3e8ef0fa9c41cf03971e6d6aa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"976f7ee1c60a5e418c4073d6e50f7be85d47984c","unresolved":false,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _check_server_availability(self, instance_details):"},{"line_number":594,"context_line":"        if \u0027ip\u0027 not in instance_details:"},{"line_number":595,"context_line":"            LOG.warning(_LW(\u0027The instance %s has no IP address.\u0027),"},{"line_number":596,"context_line":"                        instance_details[\u0027instance_id\u0027])"},{"line_number":597,"context_line":"            return False"},{"line_number":598,"context_line":"        t \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_fb9fc4b1","line":595,"range":{"start_line":595,"start_character":24,"end_line":595,"end_character":27},"updated":"2018-03-26 09:47:15.000000000","message":"Remove \"_LW\"\n\nLOG.warning(\u0027The instance %s has no IP address.\u0027, instance_details[\u0027instance_id\u0027])","commit_id":"f956283a8e91b1d3e8ef0fa9c41cf03971e6d6aa"}]}