)]}'
{"manila/share/manager.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"4d45298e19cd0eeed19025562600ca0380c9acb6","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                    self.db.share_instance_update("},{"line_number":641,"context_line":"                        context, share_instance[\u0027id\u0027], model_update)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"                if moved and not notify:"},{"line_number":644,"context_line":"                    self.db.share_update("},{"line_number":645,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":646,"context_line":"                        {\u0027task_state\u0027:"},{"line_number":647,"context_line":"                            constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":648,"context_line":"                elif moved and notify:"},{"line_number":649,"context_line":"                    self.db.share_instance_update("},{"line_number":650,"context_line":"                        context, share_instance[\u0027id\u0027],"},{"line_number":651,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":652,"context_line":"                    self.db.share_update("},{"line_number":653,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":654,"context_line":"                        {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"                    LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":657,"context_line":"                             \" completed successfully.\"), share_ref[\u0027id\u0027])"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"            except Exception as e:"},{"line_number":660,"context_line":"                msg \u003d six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_76d39060","line":657,"range":{"start_line":643,"start_character":1,"end_line":657,"end_character":74},"updated":"2016-03-31 16:55:10.000000000","message":"I think you should move this down to combine it with the \"if not moved:\" logic. That\u0027ll clean up the if this-and-that part.","commit_id":"a7a3a7c627029d58c93db5eed961fe0a09b3cd56"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"63463ea48a4a88a34279605ffa864296ba291026","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                    self.db.share_instance_update("},{"line_number":641,"context_line":"                        context, share_instance[\u0027id\u0027], model_update)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"                if moved and not notify:"},{"line_number":644,"context_line":"                    self.db.share_update("},{"line_number":645,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":646,"context_line":"                        {\u0027task_state\u0027:"},{"line_number":647,"context_line":"                            constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":648,"context_line":"                elif moved and notify:"},{"line_number":649,"context_line":"                    self.db.share_instance_update("},{"line_number":650,"context_line":"                        context, share_instance[\u0027id\u0027],"},{"line_number":651,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":652,"context_line":"                    self.db.share_update("},{"line_number":653,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":654,"context_line":"                        {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"                    LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":657,"context_line":"                             \" completed successfully.\"), share_ref[\u0027id\u0027])"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"            except Exception as e:"},{"line_number":660,"context_line":"                msg \u003d six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_f7f6778d","line":657,"range":{"start_line":643,"start_character":1,"end_line":657,"end_character":74},"in_reply_to":"ba0121b8_76d39060","updated":"2016-03-31 19:02:20.000000000","message":"Done","commit_id":"a7a3a7c627029d58c93db5eed961fe0a09b3cd56"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7943b3bb9cf452d9167b8abfaf06e7cf34e2d1d6","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":674,"context_line":"                {\u0027task_state\u0027:"},{"line_number":675,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":676,"context_line":"        elif moved and notify:"},{"line_number":677,"context_line":"            self.db.share_instance_update("},{"line_number":678,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":679,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_4c579102","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":29},"updated":"2016-04-04 13:12:12.000000000","message":"Should not it be \"else\" statement? If not, then such one should be added.","commit_id":"3600473cdfc2051479ea6f804f9f4b5960bdcf08"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"684db521ac322866b8b20c253fafbfb6480fd4ca","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":674,"context_line":"                {\u0027task_state\u0027:"},{"line_number":675,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":676,"context_line":"        elif moved and notify:"},{"line_number":677,"context_line":"            self.db.share_instance_update("},{"line_number":678,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":679,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5cb452f1","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":29},"in_reply_to":"9a061dce_4c579102","updated":"2016-04-04 16:28:50.000000000","message":"Done","commit_id":"3600473cdfc2051479ea6f804f9f4b5960bdcf08"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6104137631a142995be942de548c581c2cdd6a34","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    context, share_instance[\u0027id\u0027],"},{"line_number":668,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":669,"context_line":"                raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":670,"context_line":"        else:"},{"line_number":671,"context_line":"            if not notify:"},{"line_number":672,"context_line":"                self.db.share_update("},{"line_number":673,"context_line":"                    context, share_ref[\u0027id\u0027],"},{"line_number":674,"context_line":"                    {\u0027task_state\u0027:"},{"line_number":675,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":676,"context_line":"            else:"},{"line_number":677,"context_line":"                self.db.share_instance_update("},{"line_number":678,"context_line":"                    context, share_instance[\u0027id\u0027],"},{"line_number":679,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":680,"context_line":"                self.db.share_update("},{"line_number":681,"context_line":"                    context, share_ref[\u0027id\u0027],"},{"line_number":682,"context_line":"                    {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"                LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":685,"context_line":"                         \" completed successfully.\"), share_ref[\u0027id\u0027])"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    def _migration_start_generic(self, context, share, share_instance, host,"},{"line_number":688,"context_line":"                                 notify):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_f793b3f8","line":685,"range":{"start_line":670,"start_character":8,"end_line":685,"end_character":70},"updated":"2016-04-11 16:11:55.000000000","message":"why do you use separate condition block?\n\nIt should be enough to do following:\n\nif not moved:\n    foo\nelif not notify:\n    bar\nelse:\n    quuz","commit_id":"59269978854203a5fafb30f104fcd9b0a6824e33"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"31f67a4c2b2c9dd36c216baf5c98a8b546a621fa","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    context, share_instance[\u0027id\u0027],"},{"line_number":668,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":669,"context_line":"                raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":670,"context_line":"        else:"},{"line_number":671,"context_line":"            if not notify:"},{"line_number":672,"context_line":"                self.db.share_update("},{"line_number":673,"context_line":"                    context, share_ref[\u0027id\u0027],"},{"line_number":674,"context_line":"                    {\u0027task_state\u0027:"},{"line_number":675,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":676,"context_line":"            else:"},{"line_number":677,"context_line":"                self.db.share_instance_update("},{"line_number":678,"context_line":"                    context, share_instance[\u0027id\u0027],"},{"line_number":679,"context_line":"                    {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":680,"context_line":"                self.db.share_update("},{"line_number":681,"context_line":"                    context, share_ref[\u0027id\u0027],"},{"line_number":682,"context_line":"                    {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"                LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":685,"context_line":"                         \" completed successfully.\"), share_ref[\u0027id\u0027])"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    def _migration_start_generic(self, context, share, share_instance, host,"},{"line_number":688,"context_line":"                                 notify):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_64ddf80d","line":685,"range":{"start_line":670,"start_character":8,"end_line":685,"end_character":70},"in_reply_to":"7a1b2928_f793b3f8","updated":"2016-04-13 14:14:52.000000000","message":"Done","commit_id":"59269978854203a5fafb30f104fcd9b0a6824e33"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a106629555e8e7682eec9c3744ade3caa59566bd","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                    {\u0027task_state\u0027: ("},{"line_number":628,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS)})"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"                moved, model_update \u003d self.driver.migration_start("},{"line_number":631,"context_line":"                    context, share_instance, share_server, host,"},{"line_number":632,"context_line":"                    dest_driver_migration_info, notify)"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_b8537116","line":630,"range":{"start_line":630,"start_character":23,"end_line":630,"end_character":36},"updated":"2016-04-14 14:06:17.000000000","message":"What all needs to be updated for sure in this model_update? Could you add the fields you expect in the docstring for this method in driver.py? That could be another change though.. doesn\u0027t hold this patch up.","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60da4e361ebd33998a8e212d66f152640cd3c2bf","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                    {\u0027task_state\u0027: ("},{"line_number":628,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS)})"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"                moved, model_update \u003d self.driver.migration_start("},{"line_number":631,"context_line":"                    context, share_instance, share_server, host,"},{"line_number":632,"context_line":"                    dest_driver_migration_info, notify)"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_374da73e","line":630,"range":{"start_line":630,"start_character":23,"end_line":630,"end_character":36},"in_reply_to":"5a18252c_b8537116","updated":"2016-04-14 16:31:59.000000000","message":"I will add the change to this patch.","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a106629555e8e7682eec9c3744ade3caa59566bd","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                                \"with generic migration approach.\") % share_id)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if not moved:"},{"line_number":650,"context_line":"            LOG.debug(\"Starting generic migration \""},{"line_number":651,"context_line":"                      \"for share %s.\", share_id)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"            self.db.share_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_dd19ff89","line":650,"range":{"start_line":650,"start_character":16,"end_line":650,"end_character":21},"updated":"2016-04-14 14:06:17.000000000","message":"This should really be info...","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dadc4099da5e33fba194e7ea0bec9a712d6556c1","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                                \"with generic migration approach.\") % share_id)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if not moved:"},{"line_number":650,"context_line":"            LOG.debug(\"Starting generic migration \""},{"line_number":651,"context_line":"                      \"for share %s.\", share_id)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"            self.db.share_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_bc051c7b","line":650,"range":{"start_line":650,"start_character":16,"end_line":650,"end_character":21},"in_reply_to":"5a18252c_dd19ff89","updated":"2016-04-14 16:18:55.000000000","message":"I believe this should continue to be LOG.debug, because it is additional detail of migration, if generic or optimized migration is used, this is most probably a case for debugging the problem (if there is any). Admin is more interested in error, info (success) or warning (require some action).","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a106629555e8e7682eec9c3744ade3caa59566bd","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                {\u0027task_state\u0027:"},{"line_number":674,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            self.db.share_instance_update("},{"line_number":677,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":678,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":679,"context_line":"            self.db.share_update("},{"line_number":680,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":681,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":684,"context_line":"                     \" completed successfully.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_3d5d9347","line":681,"range":{"start_line":676,"start_character":12,"end_line":681,"end_character":71},"updated":"2016-04-14 14:06:17.000000000","message":"Since you don\u0027t have another instance.. both these calls are updating the same resource.. do you expect to have other share instances? If you do, then you probably can\u0027t tell which share instance gets updated when you say self.db.share_update... since the logic for determining the instance is in the model.. I suggest combining these calls into one.. \n\n    self.db.share_instance_update(\n        context, share_instance[\u0027id\u0027],\n        {\u0027status\u0027: constants.STATUS_AVAILABLE,\n          \u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"78c644064c5ef899a3f5d06fca3cb8af1d1bf51e","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                {\u0027task_state\u0027:"},{"line_number":674,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            self.db.share_instance_update("},{"line_number":677,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":678,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":679,"context_line":"            self.db.share_update("},{"line_number":680,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":681,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":684,"context_line":"                     \" completed successfully.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_fcb15402","line":681,"range":{"start_line":676,"start_character":12,"end_line":681,"end_character":71},"in_reply_to":"5a18252c_3d5d9347","updated":"2016-04-14 16:16:01.000000000","message":"I was wrong.. since task_state is a property of the share, we can\u0027t get away from this.","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dadc4099da5e33fba194e7ea0bec9a712d6556c1","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                {\u0027task_state\u0027:"},{"line_number":674,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE})"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            self.db.share_instance_update("},{"line_number":677,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":678,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":679,"context_line":"            self.db.share_update("},{"line_number":680,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":681,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":684,"context_line":"                     \" completed successfully.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_5c9a086f","line":681,"range":{"start_line":676,"start_character":12,"end_line":681,"end_character":71},"in_reply_to":"5a18252c_3d5d9347","updated":"2016-04-14 16:18:55.000000000","message":"Your suggestion most probably would not work because \"task_state\" does not exist in share_instance model. Also, I prefer not do a share_update that affects proxified fields.","commit_id":"557c812f10431ec8607753151140a91437e3ab8f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6592445ee2b2e61721941f0d48112d9c8f21076","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            self.db.share_instance_update("},{"line_number":677,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":678,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":679,"context_line":"                 \u0027host\u0027: host[\u0027host\u0027]})"},{"line_number":680,"context_line":"            self.db.share_update("},{"line_number":681,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":682,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_ace04197","line":679,"range":{"start_line":679,"start_character":17,"end_line":679,"end_character":37},"updated":"2016-04-14 19:26:06.000000000","message":"+1 -\u003e This makes for a good param description in the driver docstring for the method invoked in \"migration_start\" in driver.py .. host here is a dict with host (hostname) and capabilities","commit_id":"143decf4bc3d1e4f686a7dc7e5336791edc487a3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e61d38e6184e67fb2c6288cc6588360ee1b98883","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            self.db.share_instance_update("},{"line_number":677,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":678,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":679,"context_line":"                 \u0027host\u0027: host[\u0027host\u0027]})"},{"line_number":680,"context_line":"            self.db.share_update("},{"line_number":681,"context_line":"                context, share_ref[\u0027id\u0027],"},{"line_number":682,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_SUCCESS})"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_192374a8","line":679,"range":{"start_line":679,"start_character":17,"end_line":679,"end_character":37},"in_reply_to":"5a18252c_ace04197","updated":"2016-04-14 20:13:10.000000000","message":"which is already there?","commit_id":"143decf4bc3d1e4f686a7dc7e5336791edc487a3"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"4d45298e19cd0eeed19025562600ca0380c9acb6","unresolved":false,"context_lines":[{"line_number":3528,"context_line":"    @ddt.data({\u0027return_value\u0027: (True, \u0027fake_model_update\u0027), \u0027notify\u0027: True},"},{"line_number":3529,"context_line":"              {\u0027return_value\u0027: (False, \u0027fake_model_update\u0027), \u0027notify\u0027: True},"},{"line_number":3530,"context_line":"              {\u0027return_value\u0027: (True, \u0027fake_model_update\u0027), \u0027notify\u0027: False},"},{"line_number":3531,"context_line":"              {\u0027return_value\u0027: (False, \u0027fake_model_update\u0027), \u0027notify\u0027: True})"},{"line_number":3532,"context_line":"    @ddt.unpack"},{"line_number":3533,"context_line":"    def test_migration_start(self, return_value, notify):"},{"line_number":3534,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_7661d0a8","line":3531,"range":{"start_line":3531,"start_character":15,"end_line":3531,"end_character":75},"updated":"2016-03-31 16:55:10.000000000","message":"redundant with above. How about False/False?","commit_id":"a7a3a7c627029d58c93db5eed961fe0a09b3cd56"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"63463ea48a4a88a34279605ffa864296ba291026","unresolved":false,"context_lines":[{"line_number":3528,"context_line":"    @ddt.data({\u0027return_value\u0027: (True, \u0027fake_model_update\u0027), \u0027notify\u0027: True},"},{"line_number":3529,"context_line":"              {\u0027return_value\u0027: (False, \u0027fake_model_update\u0027), \u0027notify\u0027: True},"},{"line_number":3530,"context_line":"              {\u0027return_value\u0027: (True, \u0027fake_model_update\u0027), \u0027notify\u0027: False},"},{"line_number":3531,"context_line":"              {\u0027return_value\u0027: (False, \u0027fake_model_update\u0027), \u0027notify\u0027: True})"},{"line_number":3532,"context_line":"    @ddt.unpack"},{"line_number":3533,"context_line":"    def test_migration_start(self, return_value, notify):"},{"line_number":3534,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_770a678b","line":3531,"range":{"start_line":3531,"start_character":15,"end_line":3531,"end_character":75},"in_reply_to":"ba0121b8_7661d0a8","updated":"2016-03-31 19:02:20.000000000","message":"Done","commit_id":"a7a3a7c627029d58c93db5eed961fe0a09b3cd56"}]}