)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Document driver interfaces properly to please Sphinx"},{"line_number":11,"context_line":"- Document scheduler behavior"},{"line_number":12,"context_line":"- Document replica and snapshot workflows"},{"line_number":13,"context_line":"- Move backend feature support matrix from devref to adminref"},{"line_number":14,"context_line":"- Add columns for \u0027snapshot_support\u0027 and \u0027replication_type\u0027"},{"line_number":15,"context_line":"   common capabilities"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_bda1a3fa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":61},"updated":"2016-04-06 22:44:37.000000000","message":"I\u0027d agree with Thomas here that this should be done in a separate commit.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Document driver interfaces properly to please Sphinx"},{"line_number":11,"context_line":"- Document scheduler behavior"},{"line_number":12,"context_line":"- Document replica and snapshot workflows"},{"line_number":13,"context_line":"- Move backend feature support matrix from devref to adminref"},{"line_number":14,"context_line":"- Add columns for \u0027snapshot_support\u0027 and \u0027replication_type\u0027"},{"line_number":15,"context_line":"   common capabilities"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_a100a202","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":61},"in_reply_to":"9a061dce_bda1a3fa","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"}],"doc/source/adminref/index.rst":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   network_plugins"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Share backends feature support mapping"},{"line_number":27,"context_line":"--------------------------------------"},{"line_number":28,"context_line":".. toctree::"},{"line_number":29,"context_line":"   :maxdepth: 3"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   share_back_ends_feature_support_mapping"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_3df8f3c2","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":42},"updated":"2016-04-06 22:44:37.000000000","message":"I feel like this section could be moved to be under the same heading as the one. Looking at the docs themselves it looks kinda strange to have the table of contents for the admin ref then another top level heading for the Share backends feature support mapping.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   network_plugins"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Share backends feature support mapping"},{"line_number":27,"context_line":"--------------------------------------"},{"line_number":28,"context_line":".. toctree::"},{"line_number":29,"context_line":"   :maxdepth: 3"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   share_back_ends_feature_support_mapping"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_d995d8e4","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":42},"in_reply_to":"9a061dce_3df8f3c2","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"}],"doc/source/adminref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a061dce_fddf9b37","updated":"2016-04-06 22:44:37.000000000","message":"This should be moved back to the developer reference for now and we can move it to the admin reference after this patch merges.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a18252c_5e788ec4","in_reply_to":"9a061dce_fddf9b37","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"------------------------------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":165,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | snapshot_support | dedupe | compression | thin_provisioning | thick_provisioning | qos | replication_type |"},{"line_number":166,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":167,"context_line":"|               ZFSonLinux               |     \\-    |      M     |        M         |   M    |      M      |         M         |          \\-        | \\-  |   readable (M)   |"},{"line_number":168,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_708d107b","line":165,"range":{"start_line":165,"start_character":68,"end_line":165,"end_character":84},"updated":"2016-04-11 08:50:51.000000000","message":"In kilo version, There is no snapshot_support common capabilities. so this version could be starting from the L version in \"snapshot_support\" columns.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":162,"context_line":"------------------------------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":165,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | snapshot_support | dedupe | compression | thin_provisioning | thick_provisioning | qos | replication_type |"},{"line_number":166,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":167,"context_line":"|               ZFSonLinux               |     \\-    |      M     |        M         |   M    |      M      |         M         |          \\-        | \\-  |   readable (M)   |"},{"line_number":168,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_59038842","line":165,"range":{"start_line":165,"start_character":68,"end_line":165,"end_character":84},"in_reply_to":"7a1b2928_708d107b","updated":"2016-04-13 13:57:56.000000000","message":"jun: when snapshot_support was added, the value was not required to be reported to the driver.. unlike the other common capabilities.. there was logic in the base driver to check for snapshot methods and report this value to the scheduler.. so do we really want to separate that notion for this documentation?\n\nI would like to know what release a particular driver started supporting a common capability.. but then, when i\u0027m on the master, i don\u0027t care about this information as much. So i agree with Ben that this table really makes sense in the OpenStack Configuration Reference.. \n\nWe could discuss this further.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":176,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":177,"context_line":"|            Red Hat GlusterFS           |     \\-    |      J     |        L         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":178,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":179,"context_line":"|        Red Hat GlusterFS-Native        |     \\-    |      J     |        K         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":180,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":181,"context_line":"|                  HDFS                  |     \\-    |      K     |        K         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":182,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_8ceed0ea","line":179,"range":{"start_line":179,"start_character":75,"end_line":179,"end_character":77},"updated":"2016-04-11 08:50:51.000000000","message":"s/K/L","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":184,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":185,"context_line":"|                HPE 3PAR                |     L     |      K     |        K         |   L    |      \\-     |         L         |          L         | \\-  |        \\-        |"},{"line_number":186,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":187,"context_line":"|                 Huawei                 |     M     |      K     |        K         |   L    |      L      |         L         |          L         |  M  |        \\-        |"},{"line_number":188,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":189,"context_line":"|                   LVM                  |     \\-    |      M     |        M         |   \\-   |      \\-     |        \\-         |          M         | \\-  |        \\-        |"},{"line_number":190,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_0c2be031","line":187,"range":{"start_line":187,"start_character":75,"end_line":187,"end_character":77},"updated":"2016-04-11 08:50:51.000000000","message":"s/K/M","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":193,"context_line":"|              Windows SMB               |     L     |      L     |        L         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":194,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":195,"context_line":"|                IBM GPFS                |     \\-    |      K     |        K         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":196,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":197,"context_line":"|              Oracle ZFSSA              |     \\-    |      K     |        K         |   \\-   |      \\-     |        \\-         |          L         | \\-  |        \\-        |"},{"line_number":198,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_4c65d8df","line":195,"range":{"start_line":195,"start_character":75,"end_line":195,"end_character":77},"updated":"2016-04-11 08:50:51.000000000","message":"s/K/L","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"}],"doc/source/devref/capabilities_and_extra_specs.rst":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* `replication_type` - indicates the style of replication supported for the"},{"line_number":137,"context_line":"  backend/pool. This extra_spec will have a string value and could be one"},{"line_number":138,"context_line":"  of :term:`writable`, :term:`readable` or :term:`dr`. `writable` replication"},{"line_number":139,"context_line":"  type involves synchronously replicated shares where all replicas are"},{"line_number":140,"context_line":"  writable. Promotion is not supported and not needed. `readable` and `dr`"},{"line_number":141,"context_line":"  replication types involve a single `active` or `primary` replica and one or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_72c6039b","line":138,"range":{"start_line":138,"start_character":50,"end_line":138,"end_character":52},"updated":"2016-04-07 10:14:27.000000000","message":"Out of curiosity, is \u0027dr\u0027 a common term? While it is possible to deduce what it means maybe it would be nice to add some footnote or link or a two word description. That would leave no place for confusion since other options are somewhat self-describing.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* `replication_type` - indicates the style of replication supported for the"},{"line_number":137,"context_line":"  backend/pool. This extra_spec will have a string value and could be one"},{"line_number":138,"context_line":"  of :term:`writable`, :term:`readable` or :term:`dr`. `writable` replication"},{"line_number":139,"context_line":"  type involves synchronously replicated shares where all replicas are"},{"line_number":140,"context_line":"  writable. Promotion is not supported and not needed. `readable` and `dr`"},{"line_number":141,"context_line":"  replication types involve a single `active` or `primary` replica and one or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_7ef8ea49","line":138,"range":{"start_line":138,"start_character":50,"end_line":138,"end_character":52},"in_reply_to":"9a061dce_72c6039b","updated":"2016-04-13 13:57:56.000000000","message":"The :term: annotation leads readers to the term in the glossary..","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  replication, `non-active` replicas have one or more export_locations and"},{"line_number":144,"context_line":"  can thus be mounted and read while the `active` replica is the only one"},{"line_number":145,"context_line":"  that can be written into. In `dr` style of replication, only"},{"line_number":146,"context_line":"  the `active` replica can be mounted, read from and written into."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Reporting Capabilities"},{"line_number":149,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_3742bd68","line":146,"updated":"2016-04-07 10:14:27.000000000","message":"All other common capabilities definitions have a description of when they have been added. Probably one should be added here as well?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  replication, `non-active` replicas have one or more export_locations and"},{"line_number":144,"context_line":"  can thus be mounted and read while the `active` replica is the only one"},{"line_number":145,"context_line":"  that can be written into. In `dr` style of replication, only"},{"line_number":146,"context_line":"  the `active` replica can be mounted, read from and written into."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Reporting Capabilities"},{"line_number":149,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_de95bee4","line":146,"in_reply_to":"9a061dce_3742bd68","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":209,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":210,"context_line":"             \u0027compression\u0027: False,"},{"line_number":211,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":212,"context_line":"             \u0027replication_type\u0027: None,"},{"line_number":213,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":214,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":215,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_c0c2a133","line":212,"range":{"start_line":212,"start_character":37,"end_line":212,"end_character":38},"updated":"2016-04-14 19:49:23.000000000","message":"Might be a better example if we removed all the default value ones -- but for now this is consistent.","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":210,"context_line":"             \u0027compression\u0027: False,"},{"line_number":211,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":212,"context_line":"             \u0027replication_type\u0027: None,"},{"line_number":213,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":214,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":215,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_367abf77","line":212,"range":{"start_line":212,"start_character":37,"end_line":212,"end_character":38},"in_reply_to":"5a18252c_c0c2a133","updated":"2016-04-14 20:13:12.000000000","message":"true","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"}],"doc/source/devref/driver_requirements.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_cce1e8d2","line":97,"range":{"start_line":97,"start_character":65,"end_line":97,"end_character":66},"updated":"2016-04-11 08:50:51.000000000","message":"s/./;","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_98b78d39","line":99,"range":{"start_line":98,"start_character":22,"end_line":99,"end_character":35},"updated":"2016-04-06 22:44:37.000000000","message":"This is kinda awkward. I\u0027d prefer something like:\n\nstring specifying a common group name for all backends that can replicate between each other.\n\nThis is assuming that the only thing that needs to be present for shares to have the ability to replicate to each other is to have the same values for replication_domain.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_4cce785b","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":35},"updated":"2016-04-11 08:50:51.000000000","message":"s/./;","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_5e552e4e","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":35},"in_reply_to":"7a1b2928_4cce785b","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_3e50325e","line":99,"range":{"start_line":98,"start_character":22,"end_line":99,"end_character":35},"in_reply_to":"9a061dce_98b78d39","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_ccba88c0","line":101,"range":{"start_line":101,"start_character":58,"end_line":101,"end_character":60},"updated":"2016-04-11 08:50:51.000000000","message":"Add \u0027.\u0027 in the end. :)","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":98,"context_line":"- replication_domain: string specifying a common value for all backends that"},{"line_number":99,"context_line":"  can replicate between each other."},{"line_number":100,"context_line":"- replication_type: string specifying the type of replication supported by"},{"line_number":101,"context_line":"  the driver. Can be one of (\u0027readable\u0027, \u0027writable\u0027 or \u0027dr\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_dec77e10","line":101,"range":{"start_line":101,"start_character":58,"end_line":101,"end_character":60},"in_reply_to":"7a1b2928_ccba88c0","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"}],"doc/source/devref/index.rst":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   capabilities_and_extra_specs"},{"line_number":88,"context_line":"   export_location_metadata"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Share backends feature support mapping"},{"line_number":91,"context_line":"--------------------------------------"},{"line_number":92,"context_line":".. toctree::"},{"line_number":93,"context_line":"   :maxdepth: 3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"   share_back_ends_feature_support_mapping"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Share backends"},{"line_number":98,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_386c8134","side":"PARENT","line":95,"range":{"start_line":89,"start_character":0,"end_line":95,"end_character":42},"updated":"2016-04-06 22:44:37.000000000","message":"Should move this back to the developer reference for now then move it to the admin reference in another patch.","commit_id":"ffc0d5962a7fc45f385fdb92dfc328163ff58671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   capabilities_and_extra_specs"},{"line_number":88,"context_line":"   export_location_metadata"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Share backends feature support mapping"},{"line_number":91,"context_line":"--------------------------------------"},{"line_number":92,"context_line":".. toctree::"},{"line_number":93,"context_line":"   :maxdepth: 3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"   share_back_ends_feature_support_mapping"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Share backends"},{"line_number":98,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_7eee2ab5","side":"PARENT","line":95,"range":{"start_line":89,"start_character":0,"end_line":95,"end_character":42},"in_reply_to":"9a061dce_386c8134","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"ffc0d5962a7fc45f385fdb92dfc328163ff58671"}],"doc/source/devref/netapp_cluster_mode_driver.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- Update a replica (DHSS\u003dFalse)"},{"line_number":56,"context_line":"- Create a replicated snapshot (DHSS\u003dFalse)"},{"line_number":57,"context_line":"- Delete a replicated snapshot (DHSS\u003dFalse)"},{"line_number":58,"context_line":"- Update a replicated snapshot (DHSS\u003dFalse)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ..note::"},{"line_number":61,"context_line":"    :term:`DHSS` is abbreviated from `driver_handles_share_servers`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_ac58ec57","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":1},"updated":"2016-04-11 08:50:51.000000000","message":"Dose it need to add \"promote a replica\"? It is not a big deal.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- Update a replica (DHSS\u003dFalse)"},{"line_number":56,"context_line":"- Create a replicated snapshot (DHSS\u003dFalse)"},{"line_number":57,"context_line":"- Delete a replicated snapshot (DHSS\u003dFalse)"},{"line_number":58,"context_line":"- Update a replicated snapshot (DHSS\u003dFalse)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ..note::"},{"line_number":61,"context_line":"    :term:`DHSS` is abbreviated from `driver_handles_share_servers`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_fe299a38","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":1},"in_reply_to":"7a1b2928_ac58ec57","updated":"2016-04-13 13:57:56.000000000","message":"It does need it. Thanks!","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- Delete a replicated snapshot (DHSS\u003dFalse)"},{"line_number":58,"context_line":"- Update a replicated snapshot (DHSS\u003dFalse)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ..note::"},{"line_number":61,"context_line":"    :term:`DHSS` is abbreviated from `driver_handles_share_servers`."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Supported Operating Modes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_984cadc9","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":12},"updated":"2016-04-06 22:44:37.000000000","message":"Should be \".. note::\"","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- Delete a replicated snapshot (DHSS\u003dFalse)"},{"line_number":58,"context_line":"- Update a replicated snapshot (DHSS\u003dFalse)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ..note::"},{"line_number":61,"context_line":"    :term:`DHSS` is abbreviated from `driver_handles_share_servers`."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Supported Operating Modes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_5e7d2e1b","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":12},"in_reply_to":"9a061dce_984cadc9","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"}],"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b47ff8784d4e4d3c25afc74213a5d616d4ca2313","unresolved":false,"context_lines":[{"line_number":184,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":185,"context_line":"|                HPE 3PAR                |     L     |      K     |        K         |   L    |      \\-     |         L         |          L         | \\-  |        \\-        |"},{"line_number":186,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":187,"context_line":"|                 Huawei                 |     M     |      K     |        K         |   L    |      L      |         L         |          L         |  M  |        \\-        |"},{"line_number":188,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":189,"context_line":"|                   LVM                  |     \\-    |      M     |        M         |   \\-   |      \\-     |        \\-         |          M         | \\-  |        \\-        |"},{"line_number":190,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_a2e517dd","line":187,"range":{"start_line":187,"start_character":73,"end_line":187,"end_character":77},"updated":"2016-04-14 08:46:16.000000000","message":"But in L version Huawei not support snapshot_support.","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb14b5ac743cc6e2ac92475f215720de2094bc5e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":185,"context_line":"|                HPE 3PAR                |     L     |      K     |        K         |   L    |      \\-     |         L         |          L         | \\-  |        \\-        |"},{"line_number":186,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":187,"context_line":"|                 Huawei                 |     M     |      K     |        K         |   L    |      L      |         L         |          L         |  M  |        \\-        |"},{"line_number":188,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"},{"line_number":189,"context_line":"|                   LVM                  |     \\-    |      M     |        M         |   \\-   |      \\-     |        \\-         |          M         | \\-  |        \\-        |"},{"line_number":190,"context_line":"+----------------------------------------+-----------+------------+------------------+--------+-------------+-------------------+--------------------+-----+------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_06d4cde9","line":187,"range":{"start_line":187,"start_character":73,"end_line":187,"end_character":77},"in_reply_to":"5a18252c_a2e517dd","updated":"2016-04-14 12:46:44.000000000","message":"Jun: https://github.com/openstack/manila/blob/stable/liberty/manila/share/drivers/huawei/huawei_nas.py#L123\n\nHuawei could do snapshots since Kilo.. isn\u0027t that right? \n\nIf snapshot_support is not reported to the scheduler, there\u0027s logic in the base driver to deduce the value from the snapshot methods that are implemented...\n\n\nhttps://github.com/openstack/manila/blob/ad6cdb6/manila/share/driver.py#L754","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"}],"doc/source/devref/share_replication.rst":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"**writable**"},{"line_number":75,"context_line":"    Synchronously replicated shares where all replicas are writable."},{"line_number":76,"context_line":"    Promotion is not supported and not needed."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"**readable**"},{"line_number":79,"context_line":"    Mirror-style replication with a primary (writable) copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_0c67c2e9","line":76,"updated":"2016-04-06 22:44:37.000000000","message":"\"Promotion is not supported and not needed as all replicas are already writable and mountable.\"","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"**writable**"},{"line_number":75,"context_line":"    Synchronously replicated shares where all replicas are writable."},{"line_number":76,"context_line":"    Promotion is not supported and not needed."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"**readable**"},{"line_number":79,"context_line":"    Mirror-style replication with a primary (writable) copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_83ff6fa9","line":76,"in_reply_to":"9a061dce_0c67c2e9","updated":"2016-04-13 13:57:56.000000000","message":"prefer the shorter sentence..","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"**readable**"},{"line_number":79,"context_line":"    Mirror-style replication with a primary (writable) copy"},{"line_number":80,"context_line":"    and one or more secondary (read-only) copies which can become writable"},{"line_number":81,"context_line":"    after a promotion of the secondary."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"**dr (for Disaster Recovery)**"},{"line_number":84,"context_line":"    Generalized replication with secondary copies that are inaccessible until"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_12fea2ad","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":38},"updated":"2016-04-07 10:14:27.000000000","message":"This looks redundant, I\u0027d have it removed.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":78,"context_line":"**readable**"},{"line_number":79,"context_line":"    Mirror-style replication with a primary (writable) copy"},{"line_number":80,"context_line":"    and one or more secondary (read-only) copies which can become writable"},{"line_number":81,"context_line":"    after a promotion of the secondary."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"**dr (for Disaster Recovery)**"},{"line_number":84,"context_line":"    Generalized replication with secondary copies that are inaccessible until"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_c3bde7d8","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":38},"in_reply_to":"9a061dce_12fea2ad","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    after a promotion of the secondary."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"**dr (for Disaster Recovery)**"},{"line_number":84,"context_line":"    Generalized replication with secondary copies that are inaccessible until"},{"line_number":85,"context_line":"    after a promotion of one of the secondary copies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. note::"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_92e912ba","line":85,"range":{"start_line":84,"start_character":72,"end_line":85,"end_character":52},"updated":"2016-04-07 10:14:27.000000000","message":"\"that are inaccessible until promoted\"?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    after a promotion of the secondary."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"**dr (for Disaster Recovery)**"},{"line_number":84,"context_line":"    Generalized replication with secondary copies that are inaccessible until"},{"line_number":85,"context_line":"    after a promotion of one of the secondary copies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. note::"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_2383fb05","line":85,"range":{"start_line":84,"start_character":72,"end_line":85,"end_character":52},"in_reply_to":"9a061dce_92e912ba","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    :term:`writable` style of replication, all replicas are :term:`active`,"},{"line_number":91,"context_line":"    and there could be no distinction of a ``primary`` share. In"},{"line_number":92,"context_line":"    :term:`readable` and :term:`dr` styles of replication, a ``secondary``"},{"line_number":93,"context_line":"    replica may be referred to as ``passive``, ``non-active`` or simply,"},{"line_number":94,"context_line":"    ``replica``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Health of a Share Replica"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_0cdce271","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":16},"updated":"2016-04-06 22:44:37.000000000","message":"\"may be referred to as ``passive``, ``non-active``, or simply ``replica``.\"","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    :term:`writable` style of replication, all replicas are :term:`active`,"},{"line_number":91,"context_line":"    and there could be no distinction of a ``primary`` share. In"},{"line_number":92,"context_line":"    :term:`readable` and :term:`dr` styles of replication, a ``secondary``"},{"line_number":93,"context_line":"    replica may be referred to as ``passive``, ``non-active`` or simply,"},{"line_number":94,"context_line":"    ``replica``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Health of a Share Replica"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_63a4d3a5","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":16},"in_reply_to":"9a061dce_0cdce271","updated":"2016-04-13 13:57:56.000000000","message":"I like the oxford comma.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Administrators have an option of initiating a ``resync`` of a secondary"},{"line_number":124,"context_line":"replica (for :term:`readable` and :term:`dr` types of replication). This could"},{"line_number":125,"context_line":"be performed before a planned failover operation, in order to have the most"},{"line_number":126,"context_line":"up-to-date data on the replica."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_8c6472b9","line":125,"range":{"start_line":125,"start_character":48,"end_line":125,"end_character":49},"updated":"2016-04-06 22:44:37.000000000","message":"Comma not needed here.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Administrators have an option of initiating a ``resync`` of a secondary"},{"line_number":124,"context_line":"replica (for :term:`readable` and :term:`dr` types of replication). This could"},{"line_number":125,"context_line":"be performed before a planned failover operation, in order to have the most"},{"line_number":126,"context_line":"up-to-date data on the replica."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_e3b623db","line":125,"range":{"start_line":125,"start_character":48,"end_line":125,"end_character":49},"in_reply_to":"9a061dce_8c6472b9","updated":"2016-04-13 13:57:56.000000000","message":"okay","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Access rules are not meant to be different across the replicas of the share."},{"line_number":186,"context_line":"Manila expects drivers to handle these access rules effectively depending on"},{"line_number":187,"context_line":"the style of replication supported. For example, :term:`dr` style of"},{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_ccb66af8","line":187,"updated":"2016-04-06 22:44:37.000000000","message":"For example, the...","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Access rules are not meant to be different across the replicas of the share."},{"line_number":186,"context_line":"Manila expects drivers to handle these access rules effectively depending on"},{"line_number":187,"context_line":"the style of replication supported. For example, :term:`dr` style of"},{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_a3dc2b13","line":187,"in_reply_to":"9a061dce_ccb66af8","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"Manila expects drivers to handle these access rules effectively depending on"},{"line_number":187,"context_line":"the style of replication supported. For example, :term:`dr` style of"},{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"},{"line_number":191,"context_line":"support :term:`readable` replication type could want to apply any read-write"},{"line_number":192,"context_line":"rules as read-only for the non-active replicas."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_ac897628","line":190,"range":{"start_line":189,"start_character":31,"end_line":190,"end_character":49},"updated":"2016-04-06 22:44:37.000000000","message":"\"then the rules shall be applied on the :term:`active` replica only.\"","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":186,"context_line":"Manila expects drivers to handle these access rules effectively depending on"},{"line_number":187,"context_line":"the style of replication supported. For example, :term:`dr` style of"},{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"},{"line_number":191,"context_line":"support :term:`readable` replication type could want to apply any read-write"},{"line_number":192,"context_line":"rules as read-only for the non-active replicas."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_c3632740","line":190,"range":{"start_line":189,"start_character":31,"end_line":190,"end_character":49},"in_reply_to":"9a061dce_ac897628","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"},{"line_number":191,"context_line":"support :term:`readable` replication type could want to apply any read-write"},{"line_number":192,"context_line":"rules as read-only for the non-active replicas."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Drivers will receive all the access rules in ``create_replica``,"},{"line_number":195,"context_line":"``delete_replica`` and ``update_replica_state`` calls and have ample"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_4ca89a77","line":192,"range":{"start_line":191,"start_character":42,"end_line":192,"end_character":47},"updated":"2016-04-06 22:44:37.000000000","message":"Is this a hard requirement? Is this something the backend shall do or something that it should do but is not required?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":188,"context_line":"replication does mean that the non-active replicas are inaccessible, so if"},{"line_number":189,"context_line":"read-write rules are expected, it goes without saying that they could be meant"},{"line_number":190,"context_line":"to be applied on the :term:`active` replica alone. Similarly, drivers that"},{"line_number":191,"context_line":"support :term:`readable` replication type could want to apply any read-write"},{"line_number":192,"context_line":"rules as read-only for the non-active replicas."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Drivers will receive all the access rules in ``create_replica``,"},{"line_number":195,"context_line":"``delete_replica`` and ``update_replica_state`` calls and have ample"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_636e9330","line":192,"range":{"start_line":191,"start_character":42,"end_line":192,"end_character":47},"in_reply_to":"9a061dce_4ca89a77","updated":"2016-04-13 13:57:56.000000000","message":"hard design requirement, no check enforced.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":205,"context_line":":term:`replication_type`, matching the style of replication the desired backend"},{"line_number":206,"context_line":"supports. Users can use the share type to create a new share that"},{"line_number":207,"context_line":"allows/supports replication. A replicated share always starts out with one"},{"line_number":208,"context_line":"replica, the ``primary`` share itself."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The :term:`manila-scheduler` service will filter and weigh available pools to"},{"line_number":211,"context_line":"find a suitable pool for the share being created. In particular,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_63959231","line":208,"updated":"2016-04-07 10:14:27.000000000","message":"Does it mean that in fact there is just the share itself and no replicas?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":205,"context_line":":term:`replication_type`, matching the style of replication the desired backend"},{"line_number":206,"context_line":"supports. Users can use the share type to create a new share that"},{"line_number":207,"context_line":"allows/supports replication. A replicated share always starts out with one"},{"line_number":208,"context_line":"replica, the ``primary`` share itself."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The :term:`manila-scheduler` service will filter and weigh available pools to"},{"line_number":211,"context_line":"find a suitable pool for the share being created. In particular,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_c398471e","line":208,"in_reply_to":"9a061dce_63959231","updated":"2016-04-13 13:57:56.000000000","message":"Yes..","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"* The ``AvailabilityZoneFilter`` will ensure that the availability_zone"},{"line_number":219,"context_line":"    requested matches with the pool\u0027s availability zone."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Creating a replica"},{"line_number":222,"context_line":"------------------"},{"line_number":223,"context_line":"The user has to specify the share name/id of the share that is supposed to be"},{"line_number":224,"context_line":"replicated and optionally an availability zone for the replica to exist in."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_e7031d75","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":18},"updated":"2016-04-11 08:50:51.000000000","message":"How about add CLI command, it could be more clear.\n\n.. code-block:: console\n\n$ manila share-replica-create ....","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":218,"context_line":"* The ``AvailabilityZoneFilter`` will ensure that the availability_zone"},{"line_number":219,"context_line":"    requested matches with the pool\u0027s availability zone."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Creating a replica"},{"line_number":222,"context_line":"------------------"},{"line_number":223,"context_line":"The user has to specify the share name/id of the share that is supposed to be"},{"line_number":224,"context_line":"replicated and optionally an availability zone for the replica to exist in."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_83e12f9d","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":18},"in_reply_to":"7a1b2928_e7031d75","updated":"2016-04-13 13:57:56.000000000","message":"That\u0027s already there in the user/admin reference.. \n\nhttp://docs.openstack.org/admin-guide/shared_file_systems_share_replication.html","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Deleting a replica"},{"line_number":237,"context_line":"------------------"},{"line_number":238,"context_line":"Users can remove replicas that are have their `status` attribute set to"},{"line_number":239,"context_line":"``error``, ``in_sync`` or ``out_of_sync``. They could even delete an"},{"line_number":240,"context_line":":term:`active` replica as long as there is another :term:`active` replica"},{"line_number":241,"context_line":"(as could be the case with `writable` replication style). Before the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_cc0e6a8b","line":238,"range":{"start_line":238,"start_character":31,"end_line":238,"end_character":34},"updated":"2016-04-06 22:44:37.000000000","message":"Extra word","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Deleting a replica"},{"line_number":237,"context_line":"------------------"},{"line_number":238,"context_line":"Users can remove replicas that are have their `status` attribute set to"},{"line_number":239,"context_line":"``error``, ``in_sync`` or ``out_of_sync``. They could even delete an"},{"line_number":240,"context_line":":term:`active` replica as long as there is another :term:`active` replica"},{"line_number":241,"context_line":"(as could be the case with `writable` replication style). Before the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_838f6fcb","line":238,"range":{"start_line":238,"start_character":31,"end_line":238,"end_character":34},"in_reply_to":"9a061dce_cc0e6a8b","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":242,"context_line":"``delete_replica`` call is made to the driver, an update_access call is made"},{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"be ignored and the replica will be purged from manila\u0027s database."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Promoting a replica"},{"line_number":249,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_ecb36e98","line":246,"range":{"start_line":245,"start_character":51,"end_line":246,"end_character":10},"updated":"2016-04-06 22:44:37.000000000","message":"I\u0027d make it clear here that the exceptions will still be logged but will not be acted upon.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":242,"context_line":"``delete_replica`` call is made to the driver, an update_access call is made"},{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"be ignored and the replica will be purged from manila\u0027s database."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Promoting a replica"},{"line_number":249,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_23b77b87","line":246,"range":{"start_line":245,"start_character":51,"end_line":246,"end_character":10},"in_reply_to":"9a061dce_ecb36e98","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"-------------------"},{"line_number":259,"context_line":"Prior to a planned failover, an administrator could attempt to update the"},{"line_number":260,"context_line":"data on the replica. The ``update_replica_state`` call will be made during"},{"line_number":261,"context_line":"such an action, giving drivers an opportunity to push latest updates from"},{"line_number":262,"context_line":"the `active` replica to the secondaries."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Creating a snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_ec388ef0","line":261,"range":{"start_line":261,"start_character":49,"end_line":261,"end_character":68},"updated":"2016-04-06 22:44:37.000000000","message":"\"push the latest updates\"","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":258,"context_line":"-------------------"},{"line_number":259,"context_line":"Prior to a planned failover, an administrator could attempt to update the"},{"line_number":260,"context_line":"data on the replica. The ``update_replica_state`` call will be made during"},{"line_number":261,"context_line":"such an action, giving drivers an opportunity to push latest updates from"},{"line_number":262,"context_line":"the `active` replica to the secondaries."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Creating a snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_4321d7b3","line":261,"range":{"start_line":261,"start_character":49,"end_line":261,"end_character":68},"in_reply_to":"9a061dce_ec388ef0","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"40e98dbec3b97654ab51a59e841bebb925658abc","unresolved":false,"context_lines":[{"line_number":267,"context_line":"many snapshot instances as there are share replicas. These snapshot"},{"line_number":268,"context_line":"instances all begin with their `status` attribute set to `creating`. Drivers"},{"line_number":269,"context_line":"must begin to replicate this snapshot as soon as the :term:`active` replica\u0027s"},{"line_number":270,"context_line":"snapshot instance is ``available``."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Deleting a snapshot"},{"line_number":273,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_6350f232","line":270,"updated":"2016-04-07 10:14:27.000000000","message":"Does this mean that snapshots are created sequentially?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":267,"context_line":"many snapshot instances as there are share replicas. These snapshot"},{"line_number":268,"context_line":"instances all begin with their `status` attribute set to `creating`. Drivers"},{"line_number":269,"context_line":"must begin to replicate this snapshot as soon as the :term:`active` replica\u0027s"},{"line_number":270,"context_line":"snapshot instance is ``available``."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Deleting a snapshot"},{"line_number":273,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_e318e386","line":270,"in_reply_to":"9a061dce_6350f232","updated":"2016-04-13 13:57:56.000000000","message":"Good question, no...","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"Driver Interfaces"},{"line_number":281,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"As part of the _update_share_stats() call, the base driver reports the"},{"line_number":284,"context_line":"``replication_domain`` capability. Drivers are expected to update the"},{"line_number":285,"context_line":":term:`replication_type` capability."},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_af004802","line":283,"range":{"start_line":283,"start_character":15,"end_line":283,"end_character":36},"updated":"2016-04-06 22:44:37.000000000","message":"Is there a way we can \"code-ify\" this?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":280,"context_line":"Driver Interfaces"},{"line_number":281,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"As part of the _update_share_stats() call, the base driver reports the"},{"line_number":284,"context_line":"``replication_domain`` capability. Drivers are expected to update the"},{"line_number":285,"context_line":":term:`replication_type` capability."},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_de2c9e4c","line":283,"range":{"start_line":283,"start_character":15,"end_line":283,"end_character":36},"in_reply_to":"9a061dce_af004802","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"characteristics."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"When scheduling new replicas, the scheduler takes into account the"},{"line_number":53,"context_line":"``replication_domain`` option to match like backends. It also ensures that"},{"line_number":54,"context_line":"only one replica can be scheduled per pool. When backends report multiple"},{"line_number":55,"context_line":"pools, Manila would allow for replication between two pools on the same"},{"line_number":56,"context_line":"backend."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_15a70250","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":43},"updated":"2016-04-13 19:34:11.000000000","message":"I would prefer the wording \"similar\"","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"characteristics."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"When scheduling new replicas, the scheduler takes into account the"},{"line_number":53,"context_line":"``replication_domain`` option to match like backends. It also ensures that"},{"line_number":54,"context_line":"only one replica can be scheduled per pool. When backends report multiple"},{"line_number":55,"context_line":"pools, Manila would allow for replication between two pools on the same"},{"line_number":56,"context_line":"backend."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_a92193a1","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":43},"in_reply_to":"5a18252c_15a70250","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"between shares may need to be redefined at the backend during the promotion"},{"line_number":150,"context_line":"operation. If the driver fails at this stage, the replicas may be left in an"},{"line_number":151,"context_line":"inconsistent state. The share manager will set all replicas to have the"},{"line_number":152,"context_line":"``status`` attribute set to error. Recovery from this state would require"},{"line_number":153,"context_line":"administrator intervention."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_b8ac43a1","line":152,"range":{"start_line":152,"start_character":28,"end_line":152,"end_character":33},"updated":"2016-04-13 19:34:11.000000000","message":"add quotes","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"between shares may need to be redefined at the backend during the promotion"},{"line_number":150,"context_line":"operation. If the driver fails at this stage, the replicas may be left in an"},{"line_number":151,"context_line":"inconsistent state. The share manager will set all replicas to have the"},{"line_number":152,"context_line":"``status`` attribute set to error. Recovery from this state would require"},{"line_number":153,"context_line":"administrator intervention."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_0931a7ec","line":152,"range":{"start_line":152,"start_character":28,"end_line":152,"end_character":33},"in_reply_to":"5a18252c_b8ac43a1","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"be ensured, the :term:`replica_state` *must* be reported to Manila as being"},{"line_number":172,"context_line":"``out_of_sync`` until the snapshots have been replicated."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"When a snapshot instance has it\u0027s ``status`` attribute set to ``creating`` or"},{"line_number":175,"context_line":"``deleting``, Manila will poll the respective drivers for a status update. As"},{"line_number":176,"context_line":"described earlier, the parent snapshot itself will be ``available`` only when"},{"line_number":177,"context_line":"its instances across the :term:`active` and ``in_sync`` replicas of the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_98eb47b0","line":174,"range":{"start_line":174,"start_character":29,"end_line":174,"end_character":33},"updated":"2016-04-13 19:34:11.000000000","message":"s/it\u0027s/its","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"be ensured, the :term:`replica_state` *must* be reported to Manila as being"},{"line_number":172,"context_line":"``out_of_sync`` until the snapshots have been replicated."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"When a snapshot instance has it\u0027s ``status`` attribute set to ``creating`` or"},{"line_number":175,"context_line":"``deleting``, Manila will poll the respective drivers for a status update. As"},{"line_number":176,"context_line":"described earlier, the parent snapshot itself will be ``available`` only when"},{"line_number":177,"context_line":"its instances across the :term:`active` and ``in_sync`` replicas of the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_895bf72d","line":174,"range":{"start_line":174,"start_character":29,"end_line":174,"end_character":33},"in_reply_to":"5a18252c_98eb47b0","updated":"2016-04-13 19:51:51.000000000","message":"thanks!","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"only be logged and not re-raised; the replica will be purged from manila\u0027s"},{"line_number":247,"context_line":"database."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Promoting a replica"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_d8fe5f37","line":246,"range":{"start_line":246,"start_character":66,"end_line":246,"end_character":67},"updated":"2016-04-13 19:34:11.000000000","message":"capital M","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"only be logged and not re-raised; the replica will be purged from manila\u0027s"},{"line_number":247,"context_line":"database."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Promoting a replica"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_69065bcf","line":246,"range":{"start_line":246,"start_character":66,"end_line":246,"end_character":67},"in_reply_to":"5a18252c_d8fe5f37","updated":"2016-04-13 19:51:51.000000000","message":"In other doc reviews, people have asked for Manila to not be capitalized. I am not sure why, but they seemed to suggest that OpenStack documentation required it.","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"instances all begin with their `status` attribute set to `creating`. The driver"},{"line_number":270,"context_line":"is expected to create the snapshot of the ``active`` replica and then begin to"},{"line_number":271,"context_line":"replicate this snapshot as soon as the :term:`active` replica\u0027s"},{"line_number":272,"context_line":"snapshot instance is created and ``available``."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Deleting a snapshot"},{"line_number":275,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_b8456371","line":272,"range":{"start_line":272,"start_character":29,"end_line":272,"end_character":45},"updated":"2016-04-13 19:34:11.000000000","message":"I would say \"is created and becomes \u0027\u0027available\u0027\u0027.\"","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":269,"context_line":"instances all begin with their `status` attribute set to `creating`. The driver"},{"line_number":270,"context_line":"is expected to create the snapshot of the ``active`` replica and then begin to"},{"line_number":271,"context_line":"replicate this snapshot as soon as the :term:`active` replica\u0027s"},{"line_number":272,"context_line":"snapshot instance is created and ``available``."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Deleting a snapshot"},{"line_number":275,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_c964cfe6","line":272,"range":{"start_line":272,"start_character":29,"end_line":272,"end_character":45},"in_reply_to":"5a18252c_b8456371","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"When a user deletes a snapshot, the snapshot instances corresponding to each"},{"line_number":277,"context_line":"replica of the share have their ``status`` attribute set to ``deleting``."},{"line_number":278,"context_line":"Drivers must update their secondaries as soon as the :term:`active` replica\u0027s"},{"line_number":279,"context_line":"snapshot instance is ``deleted``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"Driver Interfaces"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_830d9839","line":279,"range":{"start_line":279,"start_character":18,"end_line":279,"end_character":20},"updated":"2016-04-13 19:34:11.000000000","message":"as above, I would say \"becomes\"","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":276,"context_line":"When a user deletes a snapshot, the snapshot instances corresponding to each"},{"line_number":277,"context_line":"replica of the share have their ``status`` attribute set to ``deleting``."},{"line_number":278,"context_line":"Drivers must update their secondaries as soon as the :term:`active` replica\u0027s"},{"line_number":279,"context_line":"snapshot instance is ``deleted``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"Driver Interfaces"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_89ce57b2","line":279,"range":{"start_line":279,"start_character":18,"end_line":279,"end_character":20},"in_reply_to":"5a18252c_830d9839","updated":"2016-04-13 19:51:51.000000000","message":"removed the quotes...","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":294,"context_line":"``update_replicated_snapshot`` need not be implemented by a driver that does"},{"line_number":295,"context_line":"not support snapshots."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_835bd82d","line":297,"range":{"start_line":297,"start_character":48,"end_line":297,"end_character":49},"updated":"2016-04-13 19:34:11.000000000","message":"capital C perhaps?","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"``update_replicated_snapshot`` need not be implemented by a driver that does"},{"line_number":295,"context_line":"not support snapshots."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_a942330e","line":297,"range":{"start_line":297,"start_character":48,"end_line":297,"end_character":49},"in_reply_to":"5a18252c_835bd82d","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":295,"context_line":"not support snapshots."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"},{"line_number":301,"context_line":"host that the replica or snapshot resides on."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_4378a08f","line":298,"range":{"start_line":298,"start_character":63,"end_line":298,"end_character":64},"updated":"2016-04-13 19:34:11.000000000","message":"same as above?","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":295,"context_line":"not support snapshots."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"},{"line_number":301,"context_line":"host that the replica or snapshot resides on."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_8945b718","line":298,"range":{"start_line":298,"start_character":63,"end_line":298,"end_character":64},"in_reply_to":"5a18252c_4378a08f","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"},{"line_number":301,"context_line":"host that the replica or snapshot resides on."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Share Replica interfaces:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_23bbe428","line":300,"range":{"start_line":300,"start_character":0,"end_line":300,"end_character":1},"updated":"2016-04-13 19:34:11.000000000","message":"capital or quotes?","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"},{"line_number":301,"context_line":"host that the replica or snapshot resides on."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Share Replica interfaces:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_63831c57","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":51},"updated":"2016-04-13 19:34:11.000000000","message":"quotes?","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"Each driver request is made on a specific host. create/delete operations"},{"line_number":298,"context_line":"on secondary replicas are always made on the destination host. create/delete"},{"line_number":299,"context_line":"operations on snapshots are always made on the :term:`active` replica\u0027s host."},{"line_number":300,"context_line":"update_replica_state and update_replicated_snapshot calls are made on the"},{"line_number":301,"context_line":"host that the replica or snapshot resides on."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Share Replica interfaces:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_c947af1b","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":51},"in_reply_to":"5a18252c_63831c57","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"cc5a47dda5f72f8da6a1c0a60a5782d8ece287cd","unresolved":false,"context_lines":[{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"only be logged and not re-raised; the replica will be purged from manila\u0027s"},{"line_number":247,"context_line":"database."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Promoting a replica"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_8e6e58ff","line":246,"range":{"start_line":246,"start_character":66,"end_line":246,"end_character":74},"updated":"2016-04-13 21:39:46.000000000","message":"s/manila\u0027s/Manila\u0027s","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"b1d9a48da39b6a9a379dc7df40ad905e076442a0","unresolved":false,"context_lines":[{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"only be logged and not re-raised; the replica will be purged from manila\u0027s"},{"line_number":247,"context_line":"database."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Promoting a replica"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_d140f5a7","line":246,"range":{"start_line":246,"start_character":66,"end_line":246,"end_character":74},"in_reply_to":"5a18252c_31a5e9b4","updated":"2016-04-13 21:56:34.000000000","message":"I stand corrected! Good to know for future reference.","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb184f3d4a86462ca55a03bfb9ec6667b73abdd2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"to ensure access rules are safely removed for the replica."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Administrators may also ``force-delete`` replicas. Any driver exceptions will"},{"line_number":246,"context_line":"only be logged and not re-raised; the replica will be purged from manila\u0027s"},{"line_number":247,"context_line":"database."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Promoting a replica"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_31a5e9b4","line":246,"range":{"start_line":246,"start_character":66,"end_line":246,"end_character":74},"in_reply_to":"5a18252c_8e6e58ff","updated":"2016-04-13 21:48:31.000000000","message":"https://review.openstack.org/#/c/272158/","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"When creating a share that is meant to have replicas in the future, the user"},{"line_number":67,"context_line":"will use a ``share_type`` with an extra_spec, :term:`replication_type` set to"},{"line_number":68,"context_line":"a valid replication type that Manila supports. Drivers must report the"},{"line_number":69,"context_line":"replication type that they support as the :term:`replication_type`"},{"line_number":70,"context_line":"capability during the ``_update_share_stats()`` call."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_e3bc07bd","line":68,"range":{"start_line":68,"start_character":30,"end_line":68,"end_character":36},"updated":"2016-04-14 19:49:23.000000000","message":"s/Manila/manila/ and other places\nwould linking to glossary be good as well?","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"When creating a share that is meant to have replicas in the future, the user"},{"line_number":67,"context_line":"will use a ``share_type`` with an extra_spec, :term:`replication_type` set to"},{"line_number":68,"context_line":"a valid replication type that Manila supports. Drivers must report the"},{"line_number":69,"context_line":"replication type that they support as the :term:`replication_type`"},{"line_number":70,"context_line":"capability during the ``_update_share_stats()`` call."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_d6954b33","line":68,"range":{"start_line":68,"start_character":30,"end_line":68,"end_character":36},"in_reply_to":"5a18252c_e3bc07bd","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":287,"context_line":":term:`replication_type` capability."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Drivers must implement the methods enumerated below in order to support"},{"line_number":290,"context_line":"replication. `promote_replica`, `update_replica_state` and"},{"line_number":291,"context_line":"``update_replicated_snapshot`` need not be implemented by drivers that support"},{"line_number":292,"context_line":"the :term:`writable` style of replication. The snapshot methods"},{"line_number":293,"context_line":"``create_replicated_snapshot``, ``delete_replicated_snapshot`` and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_630bd72a","line":290,"range":{"start_line":290,"start_character":13,"end_line":290,"end_character":54},"updated":"2016-04-14 19:49:23.000000000","message":"these 2 use single back-ticks but the rest of the list is using double back-ticks","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":287,"context_line":":term:`replication_type` capability."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Drivers must implement the methods enumerated below in order to support"},{"line_number":290,"context_line":"replication. `promote_replica`, `update_replica_state` and"},{"line_number":291,"context_line":"``update_replicated_snapshot`` need not be implemented by drivers that support"},{"line_number":292,"context_line":"the :term:`writable` style of replication. The snapshot methods"},{"line_number":293,"context_line":"``create_replicated_snapshot``, ``delete_replicated_snapshot`` and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_76a557a0","line":290,"range":{"start_line":290,"start_character":13,"end_line":290,"end_character":54},"in_reply_to":"5a18252c_630bd72a","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"}],"doc/source/glossary.rst":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   A type of replication supported by :term:`Manila` in which there is one :term:`active`"},{"line_number":38,"context_line":"   replica (also referred to as `primary` share) and one or more non-active replicas (also"},{"line_number":39,"context_line":"   referred to as `secondary` shares). All share replicas have at least one export location"},{"line_number":40,"context_line":"   and are mountable. However, the non-active replicas cannot be written into until after"},{"line_number":41,"context_line":"   promotion."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  writable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_4f46cc4f","line":40,"range":{"start_line":40,"start_character":73,"end_line":40,"end_character":77},"updated":"2016-04-06 22:44:37.000000000","message":"s/into/to","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   A type of replication supported by :term:`Manila` in which there is one :term:`active`"},{"line_number":38,"context_line":"   replica (also referred to as `primary` share) and one or more non-active replicas (also"},{"line_number":39,"context_line":"   referred to as `secondary` shares). All share replicas have at least one export location"},{"line_number":40,"context_line":"   and are mountable. However, the non-active replicas cannot be written into until after"},{"line_number":41,"context_line":"   promotion."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  writable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_a391cb9b","line":40,"range":{"start_line":40,"start_character":73,"end_line":40,"end_character":77},"in_reply_to":"9a061dce_4f46cc4f","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  writable"},{"line_number":44,"context_line":"   A type of replication supported by :term:`Manila` in which all share replicas are"},{"line_number":45,"context_line":"   writable. There is no requirement of a promotion since replication is synchronous."},{"line_number":46,"context_line":"   All of them have one or more export locations each and are mountable."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  dr"},{"line_number":49,"context_line":"   Acronym for `Disaster Recovery`. It is a type of replication supported by :term:`Manila`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_8f88e472","line":46,"range":{"start_line":46,"start_character":7,"end_line":46,"end_character":14},"updated":"2016-04-06 22:44:37.000000000","message":"s/of them/share replicas","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  writable"},{"line_number":44,"context_line":"   A type of replication supported by :term:`Manila` in which all share replicas are"},{"line_number":45,"context_line":"   writable. There is no requirement of a promotion since replication is synchronous."},{"line_number":46,"context_line":"   All of them have one or more export locations each and are mountable."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  dr"},{"line_number":49,"context_line":"   Acronym for `Disaster Recovery`. It is a type of replication supported by :term:`Manila`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_83e3ef32","line":46,"range":{"start_line":46,"start_character":7,"end_line":46,"end_character":14},"in_reply_to":"9a061dce_8f88e472","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   replicas are inaccessible until after promotion."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written into. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Hence, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_2fdf186a","line":56,"range":{"start_line":56,"start_character":80,"end_line":56,"end_character":84},"updated":"2016-04-06 22:44:37.000000000","message":"s/into/to","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   replicas are inaccessible until after promotion."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written into. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Hence, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_e3d0e355","line":56,"range":{"start_line":56,"start_character":80,"end_line":56,"end_character":84},"in_reply_to":"9a061dce_2fdf186a","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written into. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Hence, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"},{"line_number":60,"context_line":"   `primary` share."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_afd16859","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":23},"updated":"2016-04-06 22:44:37.000000000","message":"s/Hence/Thus","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written into. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Hence, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"},{"line_number":60,"context_line":"   `primary` share."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_436ef796","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":23},"in_reply_to":"9a061dce_afd16859","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. glossary::"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  Manila"},{"line_number":8,"context_line":"   OpenStack project to provide \"Shared Filesystems as a service\"."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  manila-api"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_e3d9a758","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":8},"updated":"2016-04-14 19:49:23.000000000","message":"maybe this isn\u0027t the right patch to change it but in docs it is s/Manila/manila.","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   capability can be one of :term:`readable`, :term:`writable` or :term:`dr`."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  readable"},{"line_number":37,"context_line":"   A type of replication supported by :term:`Manila` in which there is one :term:`active`"},{"line_number":38,"context_line":"   replica (also referred to as `primary` share) and one or more non-active replicas (also"},{"line_number":39,"context_line":"   referred to as `secondary` shares). All share replicas have at least one export location"},{"line_number":40,"context_line":"   and are mountable. However, the non-active replicas cannot be written to until after"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_634ab727","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":51},"updated":"2016-04-14 19:49:23.000000000","message":"manila","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   capability can be one of :term:`readable`, :term:`writable` or :term:`dr`."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  readable"},{"line_number":37,"context_line":"   A type of replication supported by :term:`Manila` in which there is one :term:`active`"},{"line_number":38,"context_line":"   replica (also referred to as `primary` share) and one or more non-active replicas (also"},{"line_number":39,"context_line":"   referred to as `secondary` shares). All share replicas have at least one export location"},{"line_number":40,"context_line":"   and are mountable. However, the non-active replicas cannot be written to until after"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_16b343ea","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":51},"in_reply_to":"5a18252c_634ab727","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   promotion."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  writable"},{"line_number":44,"context_line":"   A type of replication supported by :term:`Manila` in which all share replicas are"},{"line_number":45,"context_line":"   writable. There is no requirement of a promotion since replication is synchronous."},{"line_number":46,"context_line":"   All share replicas have one or more export locations each and are mountable."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_43569bce","line":44,"range":{"start_line":44,"start_character":45,"end_line":44,"end_character":51},"updated":"2016-04-14 19:49:23.000000000","message":"manila","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   promotion."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  writable"},{"line_number":44,"context_line":"   A type of replication supported by :term:`Manila` in which all share replicas are"},{"line_number":45,"context_line":"   writable. There is no requirement of a promotion since replication is synchronous."},{"line_number":46,"context_line":"   All share replicas have one or more export locations each and are mountable."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_76cc376a","line":44,"range":{"start_line":44,"start_character":45,"end_line":44,"end_character":51},"in_reply_to":"5a18252c_43569bce","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   All share replicas have one or more export locations each and are mountable."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  dr"},{"line_number":49,"context_line":"   Acronym for `Disaster Recovery`. It is a type of replication supported by :term:`Manila`"},{"line_number":50,"context_line":"   in which there is one :term:`active` replica (also referred to as `primary` share) and"},{"line_number":51,"context_line":"   one or more non-active replicas (also referred to as `secondary` shares). Only the"},{"line_number":52,"context_line":"   `active` replica has one or more export locations and can be mounted. The non-active"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_83743368","line":49,"range":{"start_line":49,"start_character":84,"end_line":49,"end_character":90},"updated":"2016-04-14 19:49:23.000000000","message":"manila","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   All share replicas have one or more export locations each and are mountable."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  dr"},{"line_number":49,"context_line":"   Acronym for `Disaster Recovery`. It is a type of replication supported by :term:`Manila`"},{"line_number":50,"context_line":"   in which there is one :term:`active` replica (also referred to as `primary` share) and"},{"line_number":51,"context_line":"   one or more non-active replicas (also referred to as `secondary` shares). Only the"},{"line_number":52,"context_line":"   `active` replica has one or more export locations and can be mounted. The non-active"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_b6c24f32","line":49,"range":{"start_line":49,"start_character":84,"end_line":49,"end_character":90},"in_reply_to":"5a18252c_83743368","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   replicas are inaccessible until after promotion."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written to. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Thus, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_c36aab80","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":19},"updated":"2016-04-14 19:49:23.000000000","message":"manila","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   replicas are inaccessible until after promotion."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  active"},{"line_number":56,"context_line":"   In :term:`Manila`, an `active` replica refers to a share that can be written to. In"},{"line_number":57,"context_line":"   `readable` and `dr` styles of replication, there is only one `active` replica at any given"},{"line_number":58,"context_line":"   point in time. Thus, it may also be referred to as the `primary` share. In `writable`"},{"line_number":59,"context_line":"   style of replication, all replicas are writable and there may be no distinction of a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_56c93b58","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":19},"in_reply_to":"5a18252c_c36aab80","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   `primary` share."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  replica_state"},{"line_number":63,"context_line":"   An attribute of the Share Instance (Share Replica) model in :term:`Manila`. If the value is"},{"line_number":64,"context_line":"   :term:`active`, it refers to the type of the replica. If the value is one of `in_sync` or"},{"line_number":65,"context_line":"   `out_of_sync`, it refers to the state of consistency of data between the :term:`active`"},{"line_number":66,"context_line":"   replica and the share replica. If the value is `error`, a potentially irrecoverable"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_030783ca","line":63,"range":{"start_line":63,"start_character":70,"end_line":63,"end_character":76},"updated":"2016-04-14 19:49:23.000000000","message":"manila","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   `primary` share."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  replica_state"},{"line_number":63,"context_line":"   An attribute of the Share Instance (Share Replica) model in :term:`Manila`. If the value is"},{"line_number":64,"context_line":"   :term:`active`, it refers to the type of the replica. If the value is one of `in_sync` or"},{"line_number":65,"context_line":"   `out_of_sync`, it refers to the state of consistency of data between the :term:`active`"},{"line_number":66,"context_line":"   replica and the share replica. If the value is `error`, a potentially irrecoverable"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_f6de870f","line":63,"range":{"start_line":63,"start_character":70,"end_line":63,"end_character":76},"in_reply_to":"5a18252c_030783ca","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"}],"manila/share/driver.py":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_7b56ee2a","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"updated":"2016-04-06 22:44:37.000000000","message":"Will not or shall not?","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_83192f7c","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"9a061dce_7b56ee2a","updated":"2016-04-13 13:57:56.000000000","message":"http://blog.oxforddictionaries.com/2013/09/will-versus-shall/ interesting, distracting read :)","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"db4630ac43f32554023c387e313dd56369fd78e1","unresolved":false,"context_lines":[{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        :param replica_snapshot: Dictionary of the snapshot instance"},{"line_number":1793,"context_line":"            This is the instance to be updated. It will be in \u0027creating\u0027 or"},{"line_number":1794,"context_line":"            \u0027deleting\u0027 states when sent via this parameter."},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"        Example::"},{"line_number":1797,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_d62271a2","line":1794,"range":{"start_line":1794,"start_character":23,"end_line":1794,"end_character":29},"updated":"2016-04-06 22:44:37.000000000","message":"s/states/state","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        :param replica_snapshot: Dictionary of the snapshot instance"},{"line_number":1793,"context_line":"            This is the instance to be updated. It will be in \u0027creating\u0027 or"},{"line_number":1794,"context_line":"            \u0027deleting\u0027 states when sent via this parameter."},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"        Example::"},{"line_number":1797,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_23581b32","line":1794,"range":{"start_line":1794,"start_character":23,"end_line":1794,"end_character":29},"in_reply_to":"9a061dce_d62271a2","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a6bd66d1cf22d875af9b7bfe3514afbbb6b786fc","unresolved":false,"context_lines":[{"line_number":1817,"context_line":"            The dictionary must contain values that need to be updated on the"},{"line_number":1818,"context_line":"            database for the snapshot instance that represents the snapshot on"},{"line_number":1819,"context_line":"            the replica."},{"line_number":1820,"context_line":"        :raises: exception.SnapshotResourceNotFound ."},{"line_number":1821,"context_line":"            Raise this exception for snapshots that are not found on the"},{"line_number":1822,"context_line":"            backend and their status was \u0027deleting\u0027."},{"line_number":1823,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_107c9c71","line":1820,"range":{"start_line":1820,"start_character":51,"end_line":1820,"end_character":52},"updated":"2016-04-11 08:50:51.000000000","message":"Redundant space.","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd40d258a5be0672a827e533c1116acbc7944084","unresolved":false,"context_lines":[{"line_number":1817,"context_line":"            The dictionary must contain values that need to be updated on the"},{"line_number":1818,"context_line":"            database for the snapshot instance that represents the snapshot on"},{"line_number":1819,"context_line":"            the replica."},{"line_number":1820,"context_line":"        :raises: exception.SnapshotResourceNotFound ."},{"line_number":1821,"context_line":"            Raise this exception for snapshots that are not found on the"},{"line_number":1822,"context_line":"            backend and their status was \u0027deleting\u0027."},{"line_number":1823,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_636973be","line":1820,"range":{"start_line":1820,"start_character":51,"end_line":1820,"end_character":52},"in_reply_to":"7a1b2928_107c9c71","updated":"2016-04-13 13:57:56.000000000","message":"Done","commit_id":"0d124e1824cacb14f1e5021d87402a6c21db8106"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                ..."},{"line_number":1243,"context_line":"            ]"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"        :param replica: Dictionary of the share replica being deleted"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        Example::"},{"line_number":1248,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_bee38b04","line":1245,"range":{"start_line":1245,"start_character":68,"end_line":1245,"end_character":69},"updated":"2016-04-13 19:34:11.000000000","message":"period","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                ..."},{"line_number":1243,"context_line":"            ]"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"        :param replica: Dictionary of the share replica being deleted"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        Example::"},{"line_number":1248,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_692dbb45","line":1245,"range":{"start_line":1245,"start_character":68,"end_line":1245,"end_character":69},"in_reply_to":"5a18252c_bee38b04","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027share_server\u0027: \u003cmodels.ShareServer\u003e or None,"},{"line_number":1267,"context_line":"            }"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"        :param replica_snapshots: A list of snapshot instance dictionaries"},{"line_number":1270,"context_line":"            The dict contains snapshot instances that are associated with the"},{"line_number":1271,"context_line":"            share replica being deleted."},{"line_number":1272,"context_line":"            No model updates to snapshot instances are possible in this method."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_de73e77e","line":1269,"range":{"start_line":1269,"start_character":73,"end_line":1269,"end_character":74},"updated":"2016-04-13 19:34:11.000000000","message":"period","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027share_server\u0027: \u003cmodels.ShareServer\u003e or None,"},{"line_number":1267,"context_line":"            }"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"        :param replica_snapshots: A list of snapshot instance dictionaries"},{"line_number":1270,"context_line":"            The dict contains snapshot instances that are associated with the"},{"line_number":1271,"context_line":"            share replica being deleted."},{"line_number":1272,"context_line":"            No model updates to snapshot instances are possible in this method."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_a927d362","line":1269,"range":{"start_line":1269,"start_character":73,"end_line":1269,"end_character":74},"in_reply_to":"5a18252c_de73e77e","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"                ..."},{"line_number":1584,"context_line":"            ]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        :param replica_snapshots: List of dictionaries of snapshot instances"},{"line_number":1587,"context_line":"            These snapshot instances track the snapshot across the replicas."},{"line_number":1588,"context_line":"            All the instances will have their status attribute set to"},{"line_number":1589,"context_line":"            \u0027creating\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_7eaf3394","line":1586,"range":{"start_line":1586,"start_character":75,"end_line":1586,"end_character":76},"updated":"2016-04-13 19:34:11.000000000","message":".","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"                ..."},{"line_number":1584,"context_line":"            ]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        :param replica_snapshots: List of dictionaries of snapshot instances"},{"line_number":1587,"context_line":"            These snapshot instances track the snapshot across the replicas."},{"line_number":1588,"context_line":"            All the instances will have their status attribute set to"},{"line_number":1589,"context_line":"            \u0027creating\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_a9deb33c","line":1586,"range":{"start_line":1586,"start_character":75,"end_line":1586,"end_character":76},"in_reply_to":"5a18252c_7eaf3394","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"                ..."},{"line_number":1660,"context_line":"            ]"},{"line_number":1661,"context_line":""},{"line_number":1662,"context_line":"        :param replica_snapshots: List of dictionaries of snapshot instances"},{"line_number":1663,"context_line":"            These snapshot instances track the snapshot across the replicas."},{"line_number":1664,"context_line":"            All the instances will have their status attribute set to"},{"line_number":1665,"context_line":"            \u0027deleting\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_5e051778","line":1662,"range":{"start_line":1662,"start_character":75,"end_line":1662,"end_character":76},"updated":"2016-04-13 19:34:11.000000000","message":"period","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"                ..."},{"line_number":1660,"context_line":"            ]"},{"line_number":1661,"context_line":""},{"line_number":1662,"context_line":"        :param replica_snapshots: List of dictionaries of snapshot instances"},{"line_number":1663,"context_line":"            These snapshot instances track the snapshot across the replicas."},{"line_number":1664,"context_line":"            All the instances will have their status attribute set to"},{"line_number":1665,"context_line":"            \u0027deleting\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_89af7793","line":1662,"range":{"start_line":1662,"start_character":75,"end_line":1662,"end_character":76},"in_reply_to":"5a18252c_5e051778","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"                  ..."},{"line_number":1744,"context_line":"            ]"},{"line_number":1745,"context_line":""},{"line_number":1746,"context_line":"        :param share_replica: Share replica dictionary"},{"line_number":1747,"context_line":"            This replica is associated with the snapshot instance whose"},{"line_number":1748,"context_line":"            status is being updated. Replicas in \u0027active\u0027 replica_state will"},{"line_number":1749,"context_line":"            not be passed via this parameter."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_de55a750","line":1746,"range":{"start_line":1746,"start_character":53,"end_line":1746,"end_character":54},"updated":"2016-04-13 19:34:11.000000000","message":"period","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"                  ..."},{"line_number":1744,"context_line":"            ]"},{"line_number":1745,"context_line":""},{"line_number":1746,"context_line":"        :param share_replica: Share replica dictionary"},{"line_number":1747,"context_line":"            This replica is associated with the snapshot instance whose"},{"line_number":1748,"context_line":"            status is being updated. Replicas in \u0027active\u0027 replica_state will"},{"line_number":1749,"context_line":"            not be passed via this parameter."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_c9916f54","line":1746,"range":{"start_line":1746,"start_character":53,"end_line":1746,"end_character":54},"in_reply_to":"5a18252c_de55a750","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bbd4f23a372631b12bbd8ff09a7df0f2de1df53b","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                ..."},{"line_number":1790,"context_line":"            ]"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        :param replica_snapshot: Dictionary of the snapshot instance"},{"line_number":1793,"context_line":"            This is the instance to be updated. It will be in \u0027creating\u0027 or"},{"line_number":1794,"context_line":"            \u0027deleting\u0027 state when sent via this parameter."},{"line_number":1795,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_fe4a23ab","line":1792,"range":{"start_line":1792,"start_character":67,"end_line":1792,"end_character":68},"updated":"2016-04-13 19:34:11.000000000","message":"period","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c280b221faa6760a25887944ff3f9977cd30049a","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                ..."},{"line_number":1790,"context_line":"            ]"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        :param replica_snapshot: Dictionary of the snapshot instance"},{"line_number":1793,"context_line":"            This is the instance to be updated. It will be in \u0027creating\u0027 or"},{"line_number":1794,"context_line":"            \u0027deleting\u0027 state when sent via this parameter."},{"line_number":1795,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_69893b26","line":1792,"range":{"start_line":1792,"start_character":67,"end_line":1792,"end_character":68},"in_reply_to":"5a18252c_fe4a23ab","updated":"2016-04-13 19:51:51.000000000","message":"Done","commit_id":"5d9e5c2f07b4f933ee24c418eb42c410f49212bb"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"cc5a47dda5f72f8da6a1c0a60a5782d8ece287cd","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_b13619e5","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"updated":"2016-04-13 21:39:46.000000000","message":"Very interesting read! I still think that \"shall not\" is valid as it\u0027s something that we are commanding that the user not do. I could go either way though!","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a61146136cff3d1c2f7ad8514429351fa89384d","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_ec19d47a","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_31c049e0","updated":"2016-04-13 22:02:53.000000000","message":"Dustin, the call\u0027s being made by the share manager to the share driver.. Are you speaking about reimplementation?","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"b1d9a48da39b6a9a379dc7df40ad905e076442a0","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_51c86522","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_51898525","updated":"2016-04-13 21:56:34.000000000","message":"I\u0027m thinking of this file as a \"standard\" that the other driver implementations have to abide by. Because of that I want to put \"shall not\" in here to show that not only will active state replicas not be present in this parameter, but that they cannot be present in this parameter. I\u0027m fine with either way, but I\u0027d prefer to see \"shall not\".","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad94867fb82a31039cb4ea9d1b389073749b9c69","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_31c049e0","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_51c86522","updated":"2016-04-13 22:00:03.000000000","message":"I don\u0027t quite understand that.. In any case, this change existed before this rearrangement.. \n\nI don\u0027t feel strongly about the change. If others point out other issues with this patch, i\u0027ll update this.","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"014fab9ebeee2191488074822165d3e512590ace","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_4cbba8e5","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_acf51ccc","updated":"2016-04-13 22:13:30.000000000","message":"No.. the share manager is implemented.. the drivers aren\u0027t. At best this is direction..","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb184f3d4a86462ca55a03bfb9ec6667b73abdd2","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_51898525","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_b13619e5","updated":"2016-04-13 21:48:31.000000000","message":"This isn\u0027t user facing...","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a06960bd44ebf03d714d00a38dc3608dd18ed056","unresolved":false,"context_lines":[{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        :param replica: Dictionary of the replica being updated"},{"line_number":1459,"context_line":"            Replica state will always be \u0027in_sync\u0027, \u0027out_of_sync\u0027, or \u0027error\u0027."},{"line_number":1460,"context_line":"            Replicas in \u0027active\u0027 state will not be passed via this parameter."},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        Example::"},{"line_number":1463,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_acf51ccc","line":1460,"range":{"start_line":1460,"start_character":39,"end_line":1460,"end_character":47},"in_reply_to":"5a18252c_ec19d47a","updated":"2016-04-13 22:10:24.000000000","message":"I guess where I\u0027m tripping up is whether or not it\u0027s an error to pass in active replicas in this parameter. If it is an error, then I think this should be updated to shall not to indicate that doing so would be an error. You are right that this is outside the scope of this change so it should probably just be left be for now. We\u0027ll have to come back to this one.","commit_id":"26c87e86297e35338a558050caf44b8fd8e277fd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9ead214366fc6705444bc8f01ae13e31db0a2842","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"            The dictionaries can contain values that need to be updated on the"},{"line_number":1690,"context_line":"            database for the snapshot instances being deleted. To confirm the"},{"line_number":1691,"context_line":"            deletion of the snapshot instance, set the \u0027status\u0027 attribute of"},{"line_number":1692,"context_line":"            the instance to  \u0027deleted\u0027 (constants.STATUS_DELETED)"},{"line_number":1693,"context_line":"        :raises: Exception."},{"line_number":1694,"context_line":"            Any exception in this method will set the status attribute of all"},{"line_number":1695,"context_line":"            snapshot instances to \u0027error_deleting\u0027."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_e3052711","line":1692,"range":{"start_line":1692,"start_character":27,"end_line":1692,"end_character":28},"updated":"2016-04-14 19:49:23.000000000","message":"extra space","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"911c82b8f2994fd3990ce5f0118a6d84887bb02b","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"            The dictionaries can contain values that need to be updated on the"},{"line_number":1690,"context_line":"            database for the snapshot instances being deleted. To confirm the"},{"line_number":1691,"context_line":"            deletion of the snapshot instance, set the \u0027status\u0027 attribute of"},{"line_number":1692,"context_line":"            the instance to  \u0027deleted\u0027 (constants.STATUS_DELETED)"},{"line_number":1693,"context_line":"        :raises: Exception."},{"line_number":1694,"context_line":"            Any exception in this method will set the status attribute of all"},{"line_number":1695,"context_line":"            snapshot instances to \u0027error_deleting\u0027."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_96e2b32d","line":1692,"range":{"start_line":1692,"start_character":27,"end_line":1692,"end_character":28},"in_reply_to":"5a18252c_e3052711","updated":"2016-04-14 20:13:12.000000000","message":"Done","commit_id":"863425981ae754f91a10242a943c928ed21c2e99"}]}