)]}'
{"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffe6a4fc691e9fcb9292ed1215acf2be57b53924","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            # Wait for status, should be manage_error and available"},{"line_number":183,"context_line":"            # respectively."},{"line_number":184,"context_line":"            self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], status)"},{"line_number":185,"context_line":"            shares.append(share)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Delete shares. Cleanup failed share entry and properly managed share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_6ca7ff4f","line":184,"updated":"2016-04-04 10:14:38.000000000","message":"Call of \"addCleanup\" should be added before line 184. Because if test fails then created DB records will not be removed.","commit_id":"8c3339ef66b4799984b0cbf9455e477b004b44c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffe6a4fc691e9fcb9292ed1215acf2be57b53924","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], status)"},{"line_number":185,"context_line":"            shares.append(share)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Delete shares. Cleanup failed share entry and properly managed share,"},{"line_number":188,"context_line":"        # that was created in class setup."},{"line_number":189,"context_line":"        for share in shares:"},{"line_number":190,"context_line":"            self.shares_v2_client.reset_state(share[\u0027id\u0027])"},{"line_number":191,"context_line":"            self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":192,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":193,"context_line":"                share_id\u003dshare[\u0027id\u0027])"},{"line_number":194,"context_line":"            self.assertRaises(lib_exc.NotFound,"},{"line_number":195,"context_line":"                              self.shares_v2_client.get_share,"},{"line_number":196,"context_line":"                              share[\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class ManageCIFSShareTest(ManageNFSShareTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_801a176d","line":196,"range":{"start_line":187,"start_character":8,"end_line":196,"end_character":42},"updated":"2016-04-04 10:14:38.000000000","message":"This part is \"cleanup\" and not related to the goal of test.","commit_id":"8c3339ef66b4799984b0cbf9455e477b004b44c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ee825354db87c2593718763af5f6c68a552e0af8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            protocol\u003dself.shares[1][\u0027share_proto\u0027],"},{"line_number":180,"context_line":"            share_type_id\u003dself.st_invalid[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":184,"context_line":"                share[\u0027id\u0027], \u0027manage_error\u0027)"},{"line_number":185,"context_line":"        except Exception:"},{"line_number":186,"context_line":"            # If manage share somehow succeeded with incorrect values, then"},{"line_number":187,"context_line":"            # delete the share, thus removing database entry and"},{"line_number":188,"context_line":"            # backend resource."},{"line_number":189,"context_line":"            _delete_share(share[\u0027id\u0027])"},{"line_number":190,"context_line":"            raise"},{"line_number":191,"context_line":"        # Delete database entry of share that failed managing."},{"line_number":192,"context_line":"        _delete_share(share[\u0027id\u0027])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Delete resource from backend. We need to manage the share properly"},{"line_number":195,"context_line":"        # so it can be removed."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_cd67adb5","line":192,"range":{"start_line":182,"start_character":8,"end_line":192,"end_character":34},"updated":"2016-04-06 09:54:39.000000000","message":"\"\"\"\n\ntry:\n    self.shares_v2_client.wait_for_share_status(\n        share[\u0027id\u0027], \u0027manage_error\u0027)\nfinally:\n    _delete_share(share[\u0027id\u0027])\n\n\"\"\"\n\nSame in second place.","commit_id":"48906833f3c53b3d421fa655d47dece064cbc5f9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f1a9d1f7716d39d6043d98c3fc4a3377a92f5f57","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            protocol\u003dself.shares[1][\u0027share_proto\u0027],"},{"line_number":180,"context_line":"            share_type_id\u003dself.st_invalid[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":184,"context_line":"                share[\u0027id\u0027], \u0027manage_error\u0027)"},{"line_number":185,"context_line":"        except Exception:"},{"line_number":186,"context_line":"            # If manage share somehow succeeded with incorrect values, then"},{"line_number":187,"context_line":"            # delete the share, thus removing database entry and"},{"line_number":188,"context_line":"            # backend resource."},{"line_number":189,"context_line":"            _delete_share(share[\u0027id\u0027])"},{"line_number":190,"context_line":"            raise"},{"line_number":191,"context_line":"        # Delete database entry of share that failed managing."},{"line_number":192,"context_line":"        _delete_share(share[\u0027id\u0027])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Delete resource from backend. We need to manage the share properly"},{"line_number":195,"context_line":"        # so it can be removed."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_6414b39f","line":192,"range":{"start_line":182,"start_character":8,"end_line":192,"end_character":34},"in_reply_to":"9a061dce_cd67adb5","updated":"2016-04-06 12:58:39.000000000","message":"Done","commit_id":"48906833f3c53b3d421fa655d47dece064cbc5f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee6592debf8c13118c720a834c1e7e830bba3214","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            protocol\u003dself.shares[1][\u0027share_proto\u0027],"},{"line_number":180,"context_line":"            share_type_id\u003dself.st_invalid[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":184,"context_line":"                share[\u0027id\u0027], \u0027manage_error\u0027)"},{"line_number":185,"context_line":"        finally:"},{"line_number":186,"context_line":"            # Delete database entry of share that failed managing."},{"line_number":187,"context_line":"            _delete_share(share[\u0027id\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        # Delete resource from backend. We need to manage the share properly"},{"line_number":190,"context_line":"        # so it can be removed."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_5a1a247e","line":187,"range":{"start_line":182,"start_character":8,"end_line":187,"end_character":38},"updated":"2016-04-06 13:33:21.000000000","message":"What\u0027s wrong with:\n\n    share \u003d self.shares_v2_client.manage_share(\n            service_host\u003dself.shares[1][\u0027host\u0027],\n            export_path\u003dself.shares[1][\u0027export_locations\u0027][0],\n            protocol\u003dself.shares[1][\u0027share_proto\u0027],\n            share_type_id\u003dself.st_invalid[\u0027share_type\u0027][\u0027id\u0027])\n    self.addCleanup(self.delete_share, share[\u0027id\u0027])\n    \n    self.shares_v2_client.wait_for_share_status(\n                share[\u0027id\u0027], \u0027manage_error\u0027)\n\n\n    # Delete resource from backend. We need to manage the share properly\n    # so it can be removed.\n\n    share \u003d self.shares_v2_client.manage_share(\n            service_host\u003dself.shares[1][\u0027host\u0027],\n            export_path\u003dself.shares[1][\u0027export_locations\u0027][0],\n            protocol\u003dself.shares[1][\u0027share_proto\u0027],\n            share_type_id\u003dself.st[\u0027share_type\u0027][\u0027id\u0027])\n    self.addCleanup(self.delete_share, share[\u0027id\u0027])\n\n    self.shares_v2_client.wait_for_share_status(\n                share[\u0027id\u0027], \u0027available\u0027)","commit_id":"3000f7b120bcb38510e99c5d7b0734961b38cde2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cc133ec06bd5014df7b1ffb118011f7db8926acd","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            protocol\u003dself.shares[1][\u0027share_proto\u0027],"},{"line_number":180,"context_line":"            share_type_id\u003dself.st_invalid[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":184,"context_line":"                share[\u0027id\u0027], \u0027manage_error\u0027)"},{"line_number":185,"context_line":"        finally:"},{"line_number":186,"context_line":"            # Delete database entry of share that failed managing."},{"line_number":187,"context_line":"            _delete_share(share[\u0027id\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        # Delete resource from backend. We need to manage the share properly"},{"line_number":190,"context_line":"        # so it can be removed."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_55f03767","line":187,"range":{"start_line":182,"start_character":8,"end_line":187,"end_character":38},"in_reply_to":"9a061dce_5a1a247e","updated":"2016-04-06 13:45:34.000000000","message":"Sry, the addCleanup must be with the custom method you wrote.. \n\n    self.addCleanup(_delete_share, share[\u0027id\u0027])","commit_id":"3000f7b120bcb38510e99c5d7b0734961b38cde2"}]}
