)]}'
{"manila/cmd/all.py":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9bad008e28e201bc81b7ded97f2704285d0f914d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"i18n.enable_lazy()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from manila.common import config  # Need to register global_opts"},{"line_number":42,"context_line":"from manila.i18n import _, _LE"},{"line_number":43,"context_line":"from manila import service"},{"line_number":44,"context_line":"from manila import utils"},{"line_number":45,"context_line":"from manila import version"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_789b7818","line":42,"updated":"2016-04-07 11:06:44.000000000","message":"A nit-question. Shouldn\u0027t it be one import per line?","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"39a01d468171e42bdf2f6da0bf42d766935fbb99","unresolved":false,"context_lines":[{"line_number":39,"context_line":"i18n.enable_lazy()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from manila.common import config  # Need to register global_opts"},{"line_number":42,"context_line":"from manila.i18n import _, _LE"},{"line_number":43,"context_line":"from manila import service"},{"line_number":44,"context_line":"from manila import utils"},{"line_number":45,"context_line":"from manila import version"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5b0e618c","line":42,"in_reply_to":"9a061dce_64d3ced5","updated":"2016-04-07 14:26:10.000000000","message":"I\u0027ve checked it out and it appears to be an overnitpicking from my side. There is an exception for this case in openstack-wide hacking doc and both versions seem to be ok. Sorry!","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"011812c1be4e7791a5f9f57ec5096d7bf05c2b83","unresolved":false,"context_lines":[{"line_number":39,"context_line":"i18n.enable_lazy()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from manila.common import config  # Need to register global_opts"},{"line_number":42,"context_line":"from manila.i18n import _, _LE"},{"line_number":43,"context_line":"from manila import service"},{"line_number":44,"context_line":"from manila import utils"},{"line_number":45,"context_line":"from manila import version"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_64d3ced5","line":42,"in_reply_to":"9a061dce_789b7818","updated":"2016-04-07 13:22:10.000000000","message":"There are lots of places in the manila codebase where this is done and I know of no one-per-line recommendation (please point me).  That said, I will make the change.","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ba53f653b0d763e696b9518d012c73113aaa80cf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def main():"},{"line_number":51,"context_line":"    LOG \u003d log.getLogger(\u0027manila.all\u0027)"},{"line_number":52,"context_line":"    msg \u003d _(\u0027manila-all is deprecated and will be removed in\u0027"},{"line_number":53,"context_line":"            \u0027the next release.\u0027)"},{"line_number":54,"context_line":"    versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":55,"context_line":"    log.register_options(CONF)"},{"line_number":56,"context_line":"    config.set_middleware_defaults()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_78ca5d1c","line":53,"updated":"2016-04-07 09:49:07.000000000","message":"\"next release\" is not very useful :) Can you mention that it will be removed in the \"M\" release?","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"011812c1be4e7791a5f9f57ec5096d7bf05c2b83","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def main():"},{"line_number":51,"context_line":"    LOG \u003d log.getLogger(\u0027manila.all\u0027)"},{"line_number":52,"context_line":"    msg \u003d _(\u0027manila-all is deprecated and will be removed in\u0027"},{"line_number":53,"context_line":"            \u0027the next release.\u0027)"},{"line_number":54,"context_line":"    versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":55,"context_line":"    log.register_options(CONF)"},{"line_number":56,"context_line":"    config.set_middleware_defaults()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_84e702ab","line":53,"in_reply_to":"9a061dce_096cb5cc","updated":"2016-04-07 13:22:10.000000000","message":"so my reply makes your point :-)","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fce06e47114052f653e97719370725ecbcaa9ee3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def main():"},{"line_number":51,"context_line":"    LOG \u003d log.getLogger(\u0027manila.all\u0027)"},{"line_number":52,"context_line":"    msg \u003d _(\u0027manila-all is deprecated and will be removed in\u0027"},{"line_number":53,"context_line":"            \u0027the next release.\u0027)"},{"line_number":54,"context_line":"    versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":55,"context_line":"    log.register_options(CONF)"},{"line_number":56,"context_line":"    config.set_middleware_defaults()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_096cb5cc","line":53,"in_reply_to":"9a061dce_78ca5d1c","updated":"2016-04-07 10:27:24.000000000","message":"Actually, it would be deprecated in N and removed in O, right?","commit_id":"6c695d783e37a54e97aa26640697a862b6c3dd2a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fac77e4ab79ab64391db8e73e4df9a084dee2770","unresolved":false,"context_lines":[{"line_number":39,"context_line":"i18n.enable_lazy()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from manila.common import config  # Need to register global_opts"},{"line_number":42,"context_line":"from manila.i18n import _"},{"line_number":43,"context_line":"from manila.i18n import _LE"},{"line_number":44,"context_line":"from manila import service"},{"line_number":45,"context_line":"from manila import utils"},{"line_number":46,"context_line":"from manila import version"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_a787a8b3","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":27},"updated":"2016-04-07 13:36:53.000000000","message":"JFYI: It is ok to import translation functions in one row. See http://docs.openstack.org/developer/hacking/#imports","commit_id":"59cb8b79fbfdeefa450b673f17e926774d2a38f5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5e51dc93f7f78b4d0a3efa06c58e6936847a2840","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    config.set_middleware_defaults()"},{"line_number":58,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027manila\u0027,"},{"line_number":59,"context_line":"         version\u003dversion.version_string())"},{"line_number":60,"context_line":"    log.setup(CONF, \"manila\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    utils.monkey_patch()"},{"line_number":63,"context_line":"    launcher \u003d service.process_launcher()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_63ca9b1c","line":60,"updated":"2016-04-07 15:26:29.000000000","message":"may need to move this line up.","commit_id":"59cb8b79fbfdeefa450b673f17e926774d2a38f5"}]}
