)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-14 06:59:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix not use provided version for \"manage\" tempest test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not use provided version for \"manage\" command in tempest test."},{"line_number":10,"context_line":"We always test the max_api_microversion version(call manage_share), and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_271f50b8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2016-04-14 10:32:07.000000000","message":"Fix microversion usage in share manage functional tests","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix not use provided version for \"manage\" tempest test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not use provided version for \"manage\" command in tempest test."},{"line_number":10,"context_line":"We always test the max_api_microversion version(call manage_share), and"},{"line_number":11,"context_line":"compare with stable version(call get_share)."},{"line_number":12,"context_line":"So make the following changes："}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_0702140b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":70},"updated":"2016-04-14 10:32:07.000000000","message":"tempest tests do not use provided microversion for \"share manage\" operation and do it only for \"get/show share\" operation. That is incorrect. Therefore, make tempest use microversion appropriately.","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":10,"context_line":"We always test the max_api_microversion version(call manage_share), and"},{"line_number":11,"context_line":"compare with stable version(call get_share)."},{"line_number":12,"context_line":"So make the following changes："},{"line_number":13,"context_line":"-- Add version parameter in manage_share fuction."},{"line_number":14,"context_line":"-- Add mangae tempest tests with different version."},{"line_number":15,"context_line":"-- Remove the built-in version in _test_manage."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_476a4cef","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":49},"updated":"2016-04-14 10:32:07.000000000","message":"s/add/use/","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compare with stable version(call get_share)."},{"line_number":12,"context_line":"So make the following changes："},{"line_number":13,"context_line":"-- Add version parameter in manage_share fuction."},{"line_number":14,"context_line":"-- Add mangae tempest tests with different version."},{"line_number":15,"context_line":"-- Remove the built-in version in _test_manage."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id11171ca3a8a6303ca543dbc104b06e80f3b8081"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_a7b40082","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":51},"updated":"2016-04-14 10:32:07.000000000","message":"Unclear statement. You added one test with specific version - 2.5","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":12,"context_line":"So make the following changes："},{"line_number":13,"context_line":"-- Add version parameter in manage_share fuction."},{"line_number":14,"context_line":"-- Add mangae tempest tests with different version."},{"line_number":15,"context_line":"-- Remove the built-in version in _test_manage."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id11171ca3a8a6303ca543dbc104b06e80f3b8081"},{"line_number":18,"context_line":"Closes-Bug: #1569720"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_a7e6c0ad","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":47},"updated":"2016-04-14 10:32:07.000000000","message":"You do not remove any built-ins. remove this line.","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cb71446799fffdb2f5b879586f415ab0a953674","unresolved":false,"context_lines":[{"line_number":11,"context_line":"incorrect. Therefore, make tempest use microversion appropriately."},{"line_number":12,"context_line":"So make the following changes："},{"line_number":13,"context_line":"-- Use version parameter in manage_share fuction."},{"line_number":14,"context_line":"-- Add one mangae tempest test."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id11171ca3a8a6303ca543dbc104b06e80f3b8081"},{"line_number":17,"context_line":"Closes-Bug: #1569720"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a18252c_211f2509","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":17},"updated":"2016-04-14 18:22:05.000000000","message":"manage","commit_id":"f871084fc37127877ac506e4ae67628f260a3299"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd231fe57c39d5c5b273a97bebf43096a8ad627","unresolved":false,"context_lines":[{"line_number":11,"context_line":"incorrect. Therefore, make tempest use microversion appropriately."},{"line_number":12,"context_line":"So make the following changes："},{"line_number":13,"context_line":"-- Use version parameter in manage_share fuction."},{"line_number":14,"context_line":"-- Add one mangae tempest test."},{"line_number":15,"context_line":"-- Change to testing the return value of the share_manage API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id11171ca3a8a6303ca543dbc104b06e80f3b8081"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_f2e366a2","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":17},"updated":"2016-04-19 12:53:00.000000000","message":"please correct this if you make another patch","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"931485bd4575f2e7ed630f3f6dcb3a4c0cc9129a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            name\u003dname,"},{"line_number":108,"context_line":"            description\u003ddescription,"},{"line_number":109,"context_line":"            is_public\u003dis_public,"},{"line_number":110,"context_line":"            version\u003dversion,"},{"line_number":111,"context_line":"        )"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Add managed share to cleanup queue"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_a1dee20e","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":28},"updated":"2016-04-13 13:51:36.000000000","message":"This is the only change that\u0027s necessary.. all changes below should be part of your other patch: \n\nhttps://review.openstack.org/#/c/298115/","commit_id":"548e9417e4d95f8b44abd675c56c876af89d72fb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        }}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Data for creating shares in parallel"},{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        shares_created \u003d cls.create_shares(data)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        cls.shares \u003d []"},{"line_number":87,"context_line":"        # Load all share data (host, etc.)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_07c05429","line":84,"range":{"start_line":81,"start_character":8,"end_line":84,"end_character":48},"updated":"2016-04-14 10:32:07.000000000","message":"Adding below two decorators, we can update logic here for following:\n\n\"\"\"\ndata \u003d [creation_data, creation_data]\nif utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):\n    data.append(creation_data)\nif utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):\n    data.append(creation_data)\n\"\"\"","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":145,"context_line":"                          share[\u0027id\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":148,"context_line":"    def test_manage_with_os_share_manage_url(self):"},{"line_number":149,"context_line":"        self._test_manage(share\u003dself.shares[2], version\u003d\"2.5\")"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_877f4465","line":147,"updated":"2016-04-14 10:32:07.000000000","message":"add decorator:\n\n@base.skip_if_microversion_not_supported(\"2.5\")","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f112952553cf359d56f37fef7a0f5beb6cd6965","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self._test_manage(share\u003dself.shares[2], version\u003d\"2.5\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"},{"line_number":152,"context_line":"    def test_manage_with_is_public_True(self):"},{"line_number":153,"context_line":"        self._test_manage(share\u003dself.shares[3], is_public\u003dTrue, version\u003d\"2.8\")"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\"])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_a7f1a003","line":152,"updated":"2016-04-14 10:32:07.000000000","message":"add decorator:\n\n@base.skip_if_microversion_not_supported(\"2.8\")","commit_id":"5a9300ab9dfce4479866f1c73211cb24b21bec23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cb71446799fffdb2f5b879586f415ab0a953674","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Verify data of managed share"},{"line_number":123,"context_line":"        actual_share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027],"},{"line_number":124,"context_line":"                                                       version\u003dversion)"},{"line_number":125,"context_line":"        self.assertEqual(name, actual_share[\u0027name\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(description, actual_share[\u0027description\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(share[\u0027host\u0027], actual_share[\u0027host\u0027])"},{"line_number":128,"context_line":"        self.assertEqual(share[\u0027share_proto\u0027], actual_share[\u0027share_proto\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if utils.is_microversion_ge(version, \"2.6\"):"},{"line_number":131,"context_line":"            self.assertEqual(self.st[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":132,"context_line":"                             actual_share[\u0027share_type\u0027])"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            self.assertEqual(self.st[\u0027share_type\u0027][\u0027name\u0027],"},{"line_number":135,"context_line":"                             actual_share[\u0027share_type\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if utils.is_microversion_ge(version, \"2.8\"):"},{"line_number":138,"context_line":"            self.assertEqual(is_public, share[\u0027is_public\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_86b28692","line":135,"range":{"start_line":123,"start_character":8,"end_line":135,"end_character":56},"updated":"2016-04-14 18:22:05.000000000","message":"Here\u0027s my concern with this test.. \n\nWhen you use get_share (line 123) -\u003e you are really testing the GET /shares API.. you are not testing the return value of the POST /share_manage (or /os-share_manage) API.. \n\nI would suggest:\n\nRename the variable on line 103, call it managed_share instead of share\n\n\n\n    self.assertEqual(name, managed_share[\u0027name\u0027])\n    self.assertEqual(description, managed_share[\u0027description\u0027])\n    self.assertEqual(share[\u0027host\u0027], managed_share[\u0027host\u0027])\n    self.assertEqual(share[\u0027share_proto\u0027], managed_share[\u0027share_proto\u0027])\n    \n    if utils.is_microversion_ge(version, \"2.6\"):\n        self.assertEqual(self.st[\u0027share_type\u0027][\u0027id\u0027], managed_share[\u0027share_type\u0027])\n    else:\n        self.assertEqual(self.st[\u0027share_type\u0027][\u0027name\u0027], managed_share[\u0027share_type\u0027])\n\n\nand so on..","commit_id":"f871084fc37127877ac506e4ae67628f260a3299"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"040527325bd0407e7d08a1afedb2ff2eb0c6f103","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Verify data of managed share"},{"line_number":121,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.5\")"},{"line_number":122,"context_line":"        self.assertEqual(name, get[\u0027name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(description, get[\u0027description\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(share[\u0027host\u0027], get[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_63fc653e","side":"PARENT","line":121,"updated":"2016-04-20 15:02:41.000000000","message":"get_share and manage_share may not return exactly the same info.  get_share could return more details.  Are you sure we do not need to call get_share here?  I ran into this when implementing manage_snapshot.  I need to call get after the manage call to retrieve more information.","commit_id":"a44c8c3f6ff2af12078c2d026fbd662476c602dc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fa1994660c90a6d5a55de2002d0e943dfb03ba93","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Verify data of managed share"},{"line_number":121,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.5\")"},{"line_number":122,"context_line":"        self.assertEqual(name, get[\u0027name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(description, get[\u0027description\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(share[\u0027host\u0027], get[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_8911d606","side":"PARENT","line":121,"in_reply_to":"1a122d0e_0076423d","updated":"2016-04-20 18:11:10.000000000","message":"Sure.  Thanks.","commit_id":"a44c8c3f6ff2af12078c2d026fbd662476c602dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fee8eee799ef5a59bb129eeb1c57574ebd886684","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Verify data of managed share"},{"line_number":121,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.5\")"},{"line_number":122,"context_line":"        self.assertEqual(name, get[\u0027name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(description, get[\u0027description\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(share[\u0027host\u0027], get[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_0076423d","side":"PARENT","line":121,"in_reply_to":"1a122d0e_40779a9f","updated":"2016-04-20 15:49:00.000000000","message":"+1 get_share\u0027s been tested in other tests (part of this patch)..\n\nThere\u0027s not much of a difference between the get_share and manage API responses.. since most of the DB fields are set.. of course, the status would be \"managing\" vs \"available\" after the wait on 118.","commit_id":"a44c8c3f6ff2af12078c2d026fbd662476c602dc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"236e66ec6819dbcf48da86b5a357066d8736e49d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Verify data of managed share"},{"line_number":121,"context_line":"        get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\"2.5\")"},{"line_number":122,"context_line":"        self.assertEqual(name, get[\u0027name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(description, get[\u0027description\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(share[\u0027host\u0027], get[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_40779a9f","side":"PARENT","line":121,"in_reply_to":"1a122d0e_63fc653e","updated":"2016-04-20 15:43:47.000000000","message":"Xing, these changes are done exactly for testing \"manage\" answer.","commit_id":"a44c8c3f6ff2af12078c2d026fbd662476c602dc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0e8b4d6541f4a732aba0eb78f9042c9b0ec82cd7","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Data for creating shares in parallel"},{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_20325ea7","line":82,"updated":"2016-04-20 15:47:20.000000000","message":"This differs from decorator of tests, there is check only for specific version, but here - for \"range\" of versions. When we remove support of \"2.5\" microversion, this share still will be created but test will be skipped.","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"872fe51c36cba018a576f375444d762da129c53c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"},{"line_number":86,"context_line":"        shares_created \u003d cls.create_shares(data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        cls.shares \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_03321e5f","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":38},"updated":"2016-04-19 11:21:11.000000000","message":"this statement and the one above do the same thing for anything greater than 2.5, why isn\u0027t then the previous \"2.8\" statement replaced by \"2.5\"?","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2533b9ef6e0fae5d03b50639969c5c20d1b77383","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"},{"line_number":86,"context_line":"        shares_created \u003d cls.create_shares(data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        cls.shares \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_660de0e7","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":38},"in_reply_to":"1a122d0e_03321e5f","updated":"2016-04-19 11:30:42.000000000","message":"nevermind, you are supposed to do it twice for 2.8","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"040527325bd0407e7d08a1afedb2ff2eb0c6f103","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"},{"line_number":86,"context_line":"        shares_created \u003d cls.create_shares(data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        cls.shares \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e334f54a","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":38},"in_reply_to":"1a122d0e_660de0e7","updated":"2016-04-20 15:02:41.000000000","message":"I\u0027m not getting it.  Why do we need to do it twice?","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"363652b73faf6cf00a652343211a11f7bab8d520","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        data \u003d [creation_data, creation_data]"},{"line_number":82,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.5\"):"},{"line_number":83,"context_line":"            data.append(creation_data)"},{"line_number":84,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.8\"):"},{"line_number":85,"context_line":"            data.append(creation_data)"},{"line_number":86,"context_line":"        shares_created \u003d cls.create_shares(data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        cls.shares \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_ddb8b113","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":38},"in_reply_to":"1a122d0e_e334f54a","updated":"2016-04-20 15:35:03.000000000","message":"Xing, here is hint for you : \"150\" and \"155\". ))","commit_id":"1a661758418673801f3629d2c36a9865ae62302f"}]}