)]}'
{"manila_tempest_tests/tests/api/admin/test_admin_actions.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":67,"context_line":"    def test_force_delete_share(self):"},{"line_number":68,"context_line":"        share \u003d self.create_share(self)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Change status from \u0027available\u0027 to \u0027error_deleting\u0027"},{"line_number":71,"context_line":"        self.shares_v2_client.reset_state(share[\"id\"], status\u003dself.bad_status)"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_43729dae","line":68,"range":{"start_line":68,"start_character":34,"end_line":68,"end_character":38},"updated":"2016-05-19 07:53:32.000000000","message":"Just wondering - can\u0027t we pass \"self\" within the base class and not doing it for all create_share calls in the tests?","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9dcd92cd49668c33e495bf356057a80eec54fbb7","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":67,"context_line":"    def test_force_delete_share(self):"},{"line_number":68,"context_line":"        share \u003d self.create_share(self)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Change status from \u0027available\u0027 to \u0027error_deleting\u0027"},{"line_number":71,"context_line":"        self.shares_v2_client.reset_state(share[\"id\"], status\u003dself.bad_status)"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_40556c4e","line":68,"range":{"start_line":68,"start_character":34,"end_line":68,"end_character":38},"in_reply_to":"bab6814e_43729dae","updated":"2016-05-19 10:26:18.000000000","message":"Marc,\n\nit is python-specific thing. If you call \"instancemethod\" (self), then you have there only instance-object. Same for \"classmethod\" (cls). To be able to handle both, by single function/method, we should expect both - for that reason we define \"staticmethod\", that is parent-agnostic and does not require \"class\" or \"instance\" object as first argument.\n\nSo, in conclusion. You do not have \"self\" or \"cls\" in \"staticmethod\". That is why it is provided explicitly.","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            kwargs[\u0027consistency_group_id\u0027] \u003d consistency_group_id"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        share \u003d client.create_share(**kwargs)"},{"line_number":315,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":316,"context_line":"            resource \u003d {"},{"line_number":317,"context_line":"                \"type\": \"share\", \"id\": share[\"id\"],"},{"line_number":318,"context_line":"                \"client\": client, \"consistency_group_id\": consistency_group_id,"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_e892904a","line":315,"updated":"2016-05-19 07:53:32.000000000","message":"It\u0027s better to use inspect module: if inspect.isclass(caller):","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9dcd92cd49668c33e495bf356057a80eec54fbb7","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            kwargs[\u0027consistency_group_id\u0027] \u003d consistency_group_id"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        share \u003d client.create_share(**kwargs)"},{"line_number":315,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":316,"context_line":"            resource \u003d {"},{"line_number":317,"context_line":"                \"type\": \"share\", \"id\": share[\"id\"],"},{"line_number":318,"context_line":"                \"client\": client, \"consistency_group_id\": consistency_group_id,"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_e9a56b04","line":315,"in_reply_to":"bab6814e_e892904a","updated":"2016-05-19 10:26:18.000000000","message":"It is very unlikely that someone would redefine repr in incompatible way. But ok, changed it.","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            kwargs[\u0027share_network_id\u0027] \u003d (share_network_id or"},{"line_number":424,"context_line":"                                          client.share_network_id or None)"},{"line_number":425,"context_line":"        consistency_group \u003d client.create_consistency_group(**kwargs)"},{"line_number":426,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":427,"context_line":"            resource \u003d {"},{"line_number":428,"context_line":"                \"type\": \"consistency_group\","},{"line_number":429,"context_line":"                \"id\": consistency_group[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_e8e0d0ce","line":426,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"            for share in new_cg_shares:"},{"line_number":443,"context_line":"                consistency_group_id \u003d share.get(\"consistency_group_id\")"},{"line_number":444,"context_line":"                if \"\u003cclass\" in repr(caller):"},{"line_number":445,"context_line":"                    resource \u003d {"},{"line_number":446,"context_line":"                        \"type\": \"share\","},{"line_number":447,"context_line":"                        \"id\": share[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_08055479","line":444,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        if description is None:"},{"line_number":468,"context_line":"            description \u003d \"Tempest\u0027s snapshot\""},{"line_number":469,"context_line":"        snapshot \u003d client.create_snapshot(share_id, name, description, force)"},{"line_number":470,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":471,"context_line":"            resource \u003d {"},{"line_number":472,"context_line":"                \"type\": \"snapshot\","},{"line_number":473,"context_line":"                \"id\": snapshot[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_28a3f850","line":470,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                                              name\u003dname,"},{"line_number":491,"context_line":"                                              description\u003ddescription,"},{"line_number":492,"context_line":"                                              **kwargs)"},{"line_number":493,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":494,"context_line":"            resource \u003d {"},{"line_number":495,"context_line":"                \"type\": \"cgsnapshot\","},{"line_number":496,"context_line":"                \"id\": cgsnapshot[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_688500ac","line":493,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        replica \u003d client.create_share_replica(share_id, availability_zone)"},{"line_number":533,"context_line":"        # NOTE(Yogi1): Cleanup needs to be disabled during promotion tests."},{"line_number":534,"context_line":"        if cleanup:"},{"line_number":535,"context_line":"            if \"\u003cclass\" in repr(caller):"},{"line_number":536,"context_line":"                resource \u003d {"},{"line_number":537,"context_line":"                    \"type\": \"share_replica\","},{"line_number":538,"context_line":"                    \"id\": replica[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_08bd5468","line":535,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":560,"context_line":"    def create_share_network(caller, client\u003dNone, **kwargs):"},{"line_number":561,"context_line":"        client \u003d client if client else caller.shares_v2_client"},{"line_number":562,"context_line":"        share_network \u003d client.create_share_network(**kwargs)"},{"line_number":563,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":564,"context_line":"            resource \u003d {"},{"line_number":565,"context_line":"                \"type\": \"share_network\","},{"line_number":566,"context_line":"                \"id\": share_network[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_28bad86e","line":563,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":575,"context_line":"    def create_security_service(caller, ss_type\u003d\"ldap\", client\u003dNone, **kwargs):"},{"line_number":576,"context_line":"        client \u003d client if client else caller.shares_v2_client"},{"line_number":577,"context_line":"        security_service \u003d client.create_security_service(ss_type, **kwargs)"},{"line_number":578,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":579,"context_line":"            resource \u003d {"},{"line_number":580,"context_line":"                \"type\": \"security_service\","},{"line_number":581,"context_line":"                \"id\": security_service[\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_88b14492","line":578,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7977d2602b7e4e99f4e78d8f4f307812e8f99899","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    def create_share_type(caller, name, is_public\u003dTrue, client\u003dNone, **kwargs):"},{"line_number":592,"context_line":"        client \u003d client if client else caller.shares_v2_client"},{"line_number":593,"context_line":"        share_type \u003d client.create_share_type(name, is_public, **kwargs)"},{"line_number":594,"context_line":"        if \"\u003cclass\" in repr(caller):"},{"line_number":595,"context_line":"            resource \u003d {"},{"line_number":596,"context_line":"                \"type\": \"share_type\","},{"line_number":597,"context_line":"                \"id\": share_type[\"share_type\"][\"id\"],"}],"source_content_type":"text/x-python","patch_set":19,"id":"bab6814e_c8ab4c1c","line":594,"updated":"2016-05-19 07:53:32.000000000","message":"Same here: use inspect","commit_id":"2e9f4fdce4d612cf97cf35c18e4e1a8358c5bd13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"479787a572d7aa95235fd3f3190daae2bc37fa0a","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        return replica"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @classmethod"},{"line_number":603,"context_line":"    def delete_share_replica(cls, replica_id, client\u003dNone):"},{"line_number":604,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":605,"context_line":"        try:"},{"line_number":606,"context_line":"            client.delete_share_replica(replica_id)"},{"line_number":607,"context_line":"            client.wait_for_resource_deletion(replica_id\u003dreplica_id)"},{"line_number":608,"context_line":"        except exceptions.NotFound:"},{"line_number":609,"context_line":"            pass"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    @classmethod"},{"line_number":612,"context_line":"    def promote_share_replica(cls, replica_id, client\u003dNone):"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_242cfd49","side":"PARENT","line":609,"range":{"start_line":603,"start_character":8,"end_line":609,"end_character":16},"updated":"2016-07-27 22:21:54.000000000","message":"? :O","commit_id":"ee0e68e156781b960338f8f568bf71382447ada7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"be00136c3cc0ea49104957e86f4866e49093dd3a","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        with handle_cleanup_exceptions():"},{"line_number":722,"context_line":"            client.delete_share_replica(replica_id)"},{"line_number":723,"context_line":"            client.wait_for_resource_deletion(replica_id\u003dreplica_id)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    @classmethod"},{"line_number":726,"context_line":"    def delete_share(cls, share_id, consistency_group_id\u003dNone, client\u003dNone):"},{"line_number":727,"context_line":"        client \u003d cls._get_client(client)"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_a4ce2d81","line":724,"range":{"start_line":724,"start_character":0,"end_line":724,"end_character":0},"updated":"2016-07-27 22:25:06.000000000","message":"ah.","commit_id":"2b52def0cf251d940e349472cb0d243f7895abf9"}]}