)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a43c4cfa5126f394a0c7d77dd652e3eb3f9ce4f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Xu \u003cjay.xu@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-20 06:13:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":xAdd gateway in network_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get gateway information from network plugin and put it into network_info"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_28aee197","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2016-04-20 08:47:48.000000000","message":"Are these two symbols needed here?","commit_id":"680ddaa324bbc2c7322e18c175e924ebb1df4312"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"39506b091004c04ef59dc3ff20a34c0d610949bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Xu \u003cjay.xu@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-20 06:13:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":xAdd gateway in network_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get gateway information from network plugin and put it into network_info"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_ae715946","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"1a122d0e_28aee197","updated":"2016-04-20 09:21:36.000000000","message":"typo when trying to save the commit message. Remove it in patch #4.","commit_id":"680ddaa324bbc2c7322e18c175e924ebb1df4312"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cb6919bd54b46fb28d82becb532c0567a727c9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get gateway information from network plugin and put it into network_info."},{"line_number":10,"context_line":"It is required by EMC Unity storage to create a interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8614b8686af7fa5764b49e8e3cb4a4855dc3a5f4"},{"line_number":13,"context_line":"Implements: blueprint add-gateway-info"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3aaa91ec_c2631919","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-06-23 03:32:28.000000000","message":"Please add the \"APIImpact\" and \"DocImpact\" flags..","commit_id":"2eec1402d5902ef62b1c9ea4ddbc3510bcf4ec22"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"6978600775f042e1afc4863859619f29a748a584","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get gateway information from network plugin and put it into network_info."},{"line_number":10,"context_line":"It is required by EMC Unity storage to create a interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8614b8686af7fa5764b49e8e3cb4a4855dc3a5f4"},{"line_number":13,"context_line":"Implements: blueprint add-gateway-info"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3aaa91ec_a8134465","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"3aaa91ec_c2631919","updated":"2016-06-23 09:24:18.000000000","message":"Done","commit_id":"2eec1402d5902ef62b1c9ea4ddbc3510bcf4ec22"}],"manila/api/views/share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cb6919bd54b46fb28d82becb532c0567a727c9f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027),"},{"line_number":49,"context_line":"                \u0027cidr\u0027: share_network.get(\u0027cidr\u0027),"},{"line_number":50,"context_line":"                \u0027ip_version\u0027: share_network.get(\u0027ip_version\u0027),"},{"line_number":51,"context_line":"                \u0027gateway\u0027: share_network.get(\u0027gateway\u0027),"},{"line_number":52,"context_line":"                \u0027description\u0027: share_network.get(\u0027description\u0027),"},{"line_number":53,"context_line":"            })"},{"line_number":54,"context_line":"        return sn"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_624505b2","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":56},"updated":"2016-06-23 03:32:28.000000000","message":"Please bump the API microversion... See examples in other view builders on how to  add the key and increase the API microversion.","commit_id":"2eec1402d5902ef62b1c9ea4ddbc3510bcf4ec22"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"6978600775f042e1afc4863859619f29a748a584","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u0027segmentation_id\u0027: share_network.get(\u0027segmentation_id\u0027),"},{"line_number":49,"context_line":"                \u0027cidr\u0027: share_network.get(\u0027cidr\u0027),"},{"line_number":50,"context_line":"                \u0027ip_version\u0027: share_network.get(\u0027ip_version\u0027),"},{"line_number":51,"context_line":"                \u0027gateway\u0027: share_network.get(\u0027gateway\u0027),"},{"line_number":52,"context_line":"                \u0027description\u0027: share_network.get(\u0027description\u0027),"},{"line_number":53,"context_line":"            })"},{"line_number":54,"context_line":"        return sn"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_2808f42b","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":56},"in_reply_to":"3aaa91ec_624505b2","updated":"2016-06-23 09:24:18.000000000","message":"Done","commit_id":"2eec1402d5902ef62b1c9ea4ddbc3510bcf4ec22"}],"manila/db/migrations/alembic/versions/fdfb668d19e1_add_gateway_to_network_allocations_table.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6329dafda5fd08558867e9c0a92a178981620380","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        sa.Column(\u0027gateway\u0027, sa.String(64), nullable\u003dTrue))"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        \u0027share_networks\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027gateway\u0027, sa.String(36), nullable\u003dTrue))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_d6eb4277","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":41},"updated":"2016-04-21 12:33:36.000000000","message":"Copy-paste error? Model has 64.\n\ns/36/64/","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"c485204617cf1141cde7905b8bbce729659b60b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        sa.Column(\u0027gateway\u0027, sa.String(64), nullable\u003dTrue))"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        \u0027share_networks\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027gateway\u0027, sa.String(36), nullable\u003dTrue))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_edf440d0","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":41},"in_reply_to":"1a122d0e_d6eb4277","updated":"2016-04-25 11:35:35.000000000","message":"Done","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0dfbe7f51935dc6500cc41a42870ef38aec1a16d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"add_gateway_to_network_allocations_table"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: fdfb668d19e1"},{"line_number":16,"context_line":"Revises: eb6d5544cbbd"},{"line_number":17,"context_line":"Create Date: 2016-04-19 10:07:16.224806"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_180c1fec","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2016-06-24 10:44:18.000000000","message":"?","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"fae41d46d2550c0ded8e9a875b4171d839eb871e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"add_gateway_to_network_allocations_table"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: fdfb668d19e1"},{"line_number":16,"context_line":"Revises: eb6d5544cbbd"},{"line_number":17,"context_line":"Create Date: 2016-04-19 10:07:16.224806"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_d6eeed89","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"3aaa91ec_180c1fec","updated":"2016-06-30 09:23:52.000000000","message":"Done","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e3077f9f116f44d5a90648aba3b9bfd88c85f408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3aaa91ec_6e8d8b30","updated":"2016-07-01 01:05:08.000000000","message":"This file just refers to the network_allocations model. It adds the column to share_networks as well. Not a big deal, but \"fdfb668d19e1_add_gateway_to_share_network_tables\" or something like that would have made more sense..","commit_id":"d98222a654973f1acc7ab6d82e52e67590ed31ec"}],"manila/share/manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6329dafda5fd08558867e9c0a92a178981620380","unresolved":false,"context_lines":[{"line_number":2314,"context_line":"            \u0027server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":2315,"context_line":"            \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":2316,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":2317,"context_line":"            \u0027gateway\u0027: share_network[\u0027gateway\u0027],"},{"line_number":2318,"context_line":"            \u0027neutron_net_id\u0027: share_network[\u0027neutron_net_id\u0027],"},{"line_number":2319,"context_line":"            \u0027neutron_subnet_id\u0027: share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":2320,"context_line":"            \u0027nova_net_id\u0027: share_network[\u0027nova_net_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_59192379","line":2317,"range":{"start_line":2317,"start_character":12,"end_line":2317,"end_character":48},"updated":"2016-04-21 12:33:36.000000000","message":"See comment on lines 2309-2312.\n\nSuch value should be used from \"network allocations\" directly.","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"c485204617cf1141cde7905b8bbce729659b60b7","unresolved":false,"context_lines":[{"line_number":2314,"context_line":"            \u0027server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":2315,"context_line":"            \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":2316,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":2317,"context_line":"            \u0027gateway\u0027: share_network[\u0027gateway\u0027],"},{"line_number":2318,"context_line":"            \u0027neutron_net_id\u0027: share_network[\u0027neutron_net_id\u0027],"},{"line_number":2319,"context_line":"            \u0027neutron_subnet_id\u0027: share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":2320,"context_line":"            \u0027nova_net_id\u0027: share_network[\u0027nova_net_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_eb6d509a","line":2317,"range":{"start_line":2317,"start_character":12,"end_line":2317,"end_character":48},"in_reply_to":"1a122d0e_59192379","updated":"2016-04-25 11:35:35.000000000","message":"I will remove this line and let the user use the gateway in network_allocations","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6329dafda5fd08558867e9c0a92a178981620380","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        for network_allocation in network_allocations:"},{"line_number":651,"context_line":"            engine.execute(na_table.insert(network_allocation))"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":654,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":655,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":656,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_39aee7e7","line":653,"range":{"start_line":653,"start_character":4,"end_line":653,"end_character":42},"updated":"2016-04-21 12:33:36.000000000","message":"\"gateway\" field for \"share_networks\" table is not verified.","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"e82e56dcf98d63ea2d9a0eb909e95864d1d39a31","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        for network_allocation in network_allocations:"},{"line_number":651,"context_line":"            engine.execute(na_table.insert(network_allocation))"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":654,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":655,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":656,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_f489a8cb","line":653,"range":{"start_line":653,"start_character":4,"end_line":653,"end_character":42},"in_reply_to":"1a122d0e_39aee7e7","updated":"2016-04-25 11:52:53.000000000","message":"Done","commit_id":"ed79f50a8bc0e1b3484bbc2c779c69486a1b8e47"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2e17304b3bf46677a5901e653f7ccd0776b23480","unresolved":false,"context_lines":[{"line_number":690,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"@map_to_migration(\u0027fdfb668d19e1\u0027)"},{"line_number":694,"context_line":"class ShareNetworkNewGatewayColumnChecks(BaseMigrationChecks):"},{"line_number":695,"context_line":"    table_name \u003d \u0027share_networks\u0027"},{"line_number":696,"context_line":"    ids \u003d [\u0027share_network_id_fake_%d\u0027 % i for i in (1, 2, 3)]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":699,"context_line":"        user_id \u003d \u0027user_id\u0027"},{"line_number":700,"context_line":"        project_id \u003d \u0027project_id\u0027"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        # Create share network"},{"line_number":703,"context_line":"        share_networks \u003d ["},{"line_number":704,"context_line":"            {"},{"line_number":705,"context_line":"                \u0027id\u0027: self.ids[0],"},{"line_number":706,"context_line":"                \u0027user_id\u0027: user_id,"},{"line_number":707,"context_line":"                \u0027project_id\u0027: project_id,"},{"line_number":708,"context_line":"            },"},{"line_number":709,"context_line":"            {"},{"line_number":710,"context_line":"                \u0027id\u0027: self.ids[1],"},{"line_number":711,"context_line":"                \u0027user_id\u0027: user_id,"},{"line_number":712,"context_line":"                \u0027project_id\u0027: project_id,"},{"line_number":713,"context_line":"            },"},{"line_number":714,"context_line":"        ]"},{"line_number":715,"context_line":"        sn_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"},{"line_number":716,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":719,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":720,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":721,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # Create share network"},{"line_number":724,"context_line":"        share_networks \u003d ["},{"line_number":725,"context_line":"            {"},{"line_number":726,"context_line":"                \u0027id\u0027: self.ids[2],"},{"line_number":727,"context_line":"                \u0027user_id\u0027: na.user_id,"},{"line_number":728,"context_line":"                \u0027project_id\u0027: na.project_id,"},{"line_number":729,"context_line":"                \u0027gateway\u0027: \u00271.1.1.1\u0027,"},{"line_number":730,"context_line":"                \u0027name\u0027: \u0027name_foo\u0027,"},{"line_number":731,"context_line":"            },"},{"line_number":732,"context_line":"        ]"},{"line_number":733,"context_line":"        engine.execute(na_table.insert(share_networks))"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        # Select share network"},{"line_number":736,"context_line":"        for na in engine.execute("},{"line_number":737,"context_line":"                na_table.select().where(na_table.c.name \u003d\u003d \u0027name_foo\u0027)):"},{"line_number":738,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":739,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027gateway\u0027],"},{"line_number":740,"context_line":"                                       getattr(na, \u0027gateway\u0027))"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def check_downgrade(self, engine):"},{"line_number":743,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":744,"context_line":"        db_result \u003d engine.execute(na_table.select())"},{"line_number":745,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.ids))"},{"line_number":746,"context_line":"        for na in db_result:"},{"line_number":747,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_3d1bfc81","line":747,"range":{"start_line":693,"start_character":0,"end_line":747,"end_character":62},"updated":"2016-04-25 16:39:46.000000000","message":"Why it is in separate class?\n\nBetter to keep 1-1 approach. One class for one DB migration.","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"4f6c7d5b9d0b24f9fd4b132a05287de3fe29c5a2","unresolved":false,"context_lines":[{"line_number":690,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"@map_to_migration(\u0027fdfb668d19e1\u0027)"},{"line_number":694,"context_line":"class ShareNetworkNewGatewayColumnChecks(BaseMigrationChecks):"},{"line_number":695,"context_line":"    table_name \u003d \u0027share_networks\u0027"},{"line_number":696,"context_line":"    ids \u003d [\u0027share_network_id_fake_%d\u0027 % i for i in (1, 2, 3)]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":699,"context_line":"        user_id \u003d \u0027user_id\u0027"},{"line_number":700,"context_line":"        project_id \u003d \u0027project_id\u0027"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        # Create share network"},{"line_number":703,"context_line":"        share_networks \u003d ["},{"line_number":704,"context_line":"            {"},{"line_number":705,"context_line":"                \u0027id\u0027: self.ids[0],"},{"line_number":706,"context_line":"                \u0027user_id\u0027: user_id,"},{"line_number":707,"context_line":"                \u0027project_id\u0027: project_id,"},{"line_number":708,"context_line":"            },"},{"line_number":709,"context_line":"            {"},{"line_number":710,"context_line":"                \u0027id\u0027: self.ids[1],"},{"line_number":711,"context_line":"                \u0027user_id\u0027: user_id,"},{"line_number":712,"context_line":"                \u0027project_id\u0027: project_id,"},{"line_number":713,"context_line":"            },"},{"line_number":714,"context_line":"        ]"},{"line_number":715,"context_line":"        sn_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"},{"line_number":716,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":719,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":720,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":721,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # Create share network"},{"line_number":724,"context_line":"        share_networks \u003d ["},{"line_number":725,"context_line":"            {"},{"line_number":726,"context_line":"                \u0027id\u0027: self.ids[2],"},{"line_number":727,"context_line":"                \u0027user_id\u0027: na.user_id,"},{"line_number":728,"context_line":"                \u0027project_id\u0027: na.project_id,"},{"line_number":729,"context_line":"                \u0027gateway\u0027: \u00271.1.1.1\u0027,"},{"line_number":730,"context_line":"                \u0027name\u0027: \u0027name_foo\u0027,"},{"line_number":731,"context_line":"            },"},{"line_number":732,"context_line":"        ]"},{"line_number":733,"context_line":"        engine.execute(na_table.insert(share_networks))"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        # Select share network"},{"line_number":736,"context_line":"        for na in engine.execute("},{"line_number":737,"context_line":"                na_table.select().where(na_table.c.name \u003d\u003d \u0027name_foo\u0027)):"},{"line_number":738,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":739,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027gateway\u0027],"},{"line_number":740,"context_line":"                                       getattr(na, \u0027gateway\u0027))"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def check_downgrade(self, engine):"},{"line_number":743,"context_line":"        na_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":744,"context_line":"        db_result \u003d engine.execute(na_table.select())"},{"line_number":745,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.ids))"},{"line_number":746,"context_line":"        for na in db_result:"},{"line_number":747,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_ef3647b3","line":747,"range":{"start_line":693,"start_character":0,"end_line":747,"end_character":62},"in_reply_to":"1a122d0e_3d1bfc81","updated":"2016-06-20 08:47:14.000000000","message":"Done","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":610,"context_line":""},{"line_number":611,"context_line":"@map_to_migration(\u0027fdfb668d19e1\u0027)"},{"line_number":612,"context_line":"class NewGatewayColumnChecks(BaseMigrationChecks):"},{"line_number":613,"context_line":"    network_allocation_table \u003d \u0027network_allocations\u0027"},{"line_number":614,"context_line":"    share_network_table \u003d \u0027share_networks\u0027"},{"line_number":615,"context_line":"    na_ids \u003d [\u0027network_allocation_id_fake_%d\u0027 % i for i in (1, 2, 3)]"},{"line_number":616,"context_line":"    sn_ids \u003d [\u0027share_network_id_fake_%d\u0027 % i for i in (1, 2)]"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_ef1a5cc5","line":614,"range":{"start_line":613,"start_character":4,"end_line":614,"end_character":42},"updated":"2016-04-26 10:23:19.000000000","message":"These are names, not tables.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":610,"context_line":""},{"line_number":611,"context_line":"@map_to_migration(\u0027fdfb668d19e1\u0027)"},{"line_number":612,"context_line":"class NewGatewayColumnChecks(BaseMigrationChecks):"},{"line_number":613,"context_line":"    network_allocation_table \u003d \u0027network_allocations\u0027"},{"line_number":614,"context_line":"    share_network_table \u003d \u0027share_networks\u0027"},{"line_number":615,"context_line":"    na_ids \u003d [\u0027network_allocation_id_fake_%d\u0027 % i for i in (1, 2, 3)]"},{"line_number":616,"context_line":"    sn_ids \u003d [\u0027share_network_id_fake_%d\u0027 % i for i in (1, 2)]"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_c7d01256","line":614,"range":{"start_line":613,"start_character":4,"end_line":614,"end_character":42},"in_reply_to":"1a122d0e_ef1a5cc5","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # Create network allocations"},{"line_number":643,"context_line":"        network_allocations \u003d ["},{"line_number":644,"context_line":"            {"},{"line_number":645,"context_line":"                \u0027id\u0027: self.na_ids[0],"},{"line_number":646,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":647,"context_line":"                \u0027ip_address\u0027: \u00271.1.1.1\u0027,"},{"line_number":648,"context_line":"            },"},{"line_number":649,"context_line":"            {"},{"line_number":650,"context_line":"                \u0027id\u0027: self.na_ids[1],"},{"line_number":651,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":652,"context_line":"                \u0027ip_address\u0027: \u00272.2.2.2\u0027,"},{"line_number":653,"context_line":"            },"},{"line_number":654,"context_line":"        ]"},{"line_number":655,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_2f661451","line":652,"range":{"start_line":645,"start_character":16,"end_line":652,"end_character":40},"updated":"2016-04-26 10:23:19.000000000","message":"Where is \"gateway\"?","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1f72b26baa004dd36aa3c23c56102a6b5e71bf96","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # Create network allocations"},{"line_number":643,"context_line":"        network_allocations \u003d ["},{"line_number":644,"context_line":"            {"},{"line_number":645,"context_line":"                \u0027id\u0027: self.na_ids[0],"},{"line_number":646,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":647,"context_line":"                \u0027ip_address\u0027: \u00271.1.1.1\u0027,"},{"line_number":648,"context_line":"            },"},{"line_number":649,"context_line":"            {"},{"line_number":650,"context_line":"                \u0027id\u0027: self.na_ids[1],"},{"line_number":651,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":652,"context_line":"                \u0027ip_address\u0027: \u00272.2.2.2\u0027,"},{"line_number":653,"context_line":"            },"},{"line_number":654,"context_line":"        ]"},{"line_number":655,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e4c76362","line":652,"range":{"start_line":645,"start_character":16,"end_line":652,"end_character":40},"in_reply_to":"1a122d0e_2f661451","updated":"2016-05-03 19:06:20.000000000","message":"I think \"gateway\" will show up during upgrade, so it is in check_upgrade.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # Create network allocations"},{"line_number":643,"context_line":"        network_allocations \u003d ["},{"line_number":644,"context_line":"            {"},{"line_number":645,"context_line":"                \u0027id\u0027: self.na_ids[0],"},{"line_number":646,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":647,"context_line":"                \u0027ip_address\u0027: \u00271.1.1.1\u0027,"},{"line_number":648,"context_line":"            },"},{"line_number":649,"context_line":"            {"},{"line_number":650,"context_line":"                \u0027id\u0027: self.na_ids[1],"},{"line_number":651,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":652,"context_line":"                \u0027ip_address\u0027: \u00272.2.2.2\u0027,"},{"line_number":653,"context_line":"            },"},{"line_number":654,"context_line":"        ]"},{"line_number":655,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_27c2a685","line":652,"range":{"start_line":645,"start_character":16,"end_line":652,"end_character":40},"in_reply_to":"1a122d0e_2f661451","updated":"2016-06-20 08:45:56.000000000","message":"In the example NetworkAllocationsNewLabelColumnChecks, it creates two NA without label in setup_upgrade_data(), and then creates the 3rd NA with label in check_upgrade(). So I follow the same style. :) Is it related to the assert in check_downgrade()?","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # Create network allocations"},{"line_number":643,"context_line":"        network_allocations \u003d ["},{"line_number":644,"context_line":"            {"},{"line_number":645,"context_line":"                \u0027id\u0027: self.na_ids[0],"},{"line_number":646,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":647,"context_line":"                \u0027ip_address\u0027: \u00271.1.1.1\u0027,"},{"line_number":648,"context_line":"            },"},{"line_number":649,"context_line":"            {"},{"line_number":650,"context_line":"                \u0027id\u0027: self.na_ids[1],"},{"line_number":651,"context_line":"                \u0027share_server_id\u0027: share_server_id,"},{"line_number":652,"context_line":"                \u0027ip_address\u0027: \u00272.2.2.2\u0027,"},{"line_number":653,"context_line":"            },"},{"line_number":654,"context_line":"        ]"},{"line_number":655,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_0ff8f3e4","line":652,"range":{"start_line":645,"start_character":16,"end_line":652,"end_character":40},"in_reply_to":"1a122d0e_e4c76362","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":661,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        # Create network allocation"},{"line_number":664,"context_line":"        network_allocations \u003d ["},{"line_number":665,"context_line":"            {"},{"line_number":666,"context_line":"                \u0027id\u0027: self.na_ids[2],"},{"line_number":667,"context_line":"                \u0027share_server_id\u0027: na.share_server_id,"},{"line_number":668,"context_line":"                \u0027ip_address\u0027: \u00273.3.3.3\u0027,"},{"line_number":669,"context_line":"                \u0027gateway\u0027: \u00273.3.3.1\u0027,"},{"line_number":670,"context_line":"                \u0027label\u0027: \u0027label_foo\u0027,"},{"line_number":671,"context_line":"                \u0027network_type\u0027: \u0027vlan\u0027,"},{"line_number":672,"context_line":"                \u0027segmentation_id\u0027: 1005,"},{"line_number":673,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":674,"context_line":"                \u0027cidr\u0027: \u0027240.0.0.0/16\u0027,"},{"line_number":675,"context_line":"            },"},{"line_number":676,"context_line":"        ]"},{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_cfdcc0e6","line":677,"range":{"start_line":663,"start_character":8,"end_line":677,"end_character":60},"updated":"2016-04-26 10:23:19.000000000","message":"This, additional NA looks redundant. You already created two above. Why do you need this one?","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":661,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        # Create network allocation"},{"line_number":664,"context_line":"        network_allocations \u003d ["},{"line_number":665,"context_line":"            {"},{"line_number":666,"context_line":"                \u0027id\u0027: self.na_ids[2],"},{"line_number":667,"context_line":"                \u0027share_server_id\u0027: na.share_server_id,"},{"line_number":668,"context_line":"                \u0027ip_address\u0027: \u00273.3.3.3\u0027,"},{"line_number":669,"context_line":"                \u0027gateway\u0027: \u00273.3.3.1\u0027,"},{"line_number":670,"context_line":"                \u0027label\u0027: \u0027label_foo\u0027,"},{"line_number":671,"context_line":"                \u0027network_type\u0027: \u0027vlan\u0027,"},{"line_number":672,"context_line":"                \u0027segmentation_id\u0027: 1005,"},{"line_number":673,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":674,"context_line":"                \u0027cidr\u0027: \u0027240.0.0.0/16\u0027,"},{"line_number":675,"context_line":"            },"},{"line_number":676,"context_line":"        ]"},{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_218868e7","line":677,"range":{"start_line":663,"start_character":8,"end_line":677,"end_character":60},"in_reply_to":"1a122d0e_cfdcc0e6","updated":"2016-06-20 08:45:56.000000000","message":"First of all, it creates two items of network_allocations without gateway, and then creates the third one with gateway.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        ]"},{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_0f47d8bc","line":679,"range":{"start_line":679,"start_character":10,"end_line":679,"end_character":42},"updated":"2016-04-26 10:23:19.000000000","message":"It is copy-paste. It is not admin network allocations.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        ]"},{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_c177e400","line":679,"range":{"start_line":679,"start_character":10,"end_line":679,"end_character":42},"in_reply_to":"1a122d0e_0f47d8bc","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":683,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":684,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_4fef1087","line":681,"range":{"start_line":680,"start_character":8,"end_line":681,"end_character":74},"updated":"2016-04-26 10:23:19.000000000","message":"Your change is not related to labels, no need to depend on it.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1f72b26baa004dd36aa3c23c56102a6b5e71bf96","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":683,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":684,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_5d5706ca","line":681,"range":{"start_line":680,"start_character":8,"end_line":681,"end_character":74},"in_reply_to":"1a122d0e_4fef1087","updated":"2016-05-03 19:06:20.000000000","message":"+1.\n\nShould change it to gateway instead of label.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":683,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":684,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_c14ec4c0","line":681,"range":{"start_line":680,"start_character":8,"end_line":681,"end_character":74},"in_reply_to":"1a122d0e_4fef1087","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # Select admin network allocations"},{"line_number":680,"context_line":"        for na in engine.execute("},{"line_number":681,"context_line":"                na_table.select().where(na_table.c.label \u003d\u003d \u0027label_foo\u0027)):"},{"line_number":682,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":683,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":684,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_a14bb8af","line":681,"range":{"start_line":680,"start_character":8,"end_line":681,"end_character":74},"in_reply_to":"1a122d0e_5d5706ca","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        for sn in engine.execute(sn_table.select()):"},{"line_number":688,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027gateway\u0027))"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        # Create share network"},{"line_number":691,"context_line":"        share_networks \u003d ["},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027id\u0027: self.sn_ids[1],"},{"line_number":694,"context_line":"                \u0027user_id\u0027: sn.user_id,"},{"line_number":695,"context_line":"                \u0027project_id\u0027: sn.project_id,"},{"line_number":696,"context_line":"                \u0027gateway\u0027: \u00271.1.1.1\u0027,"},{"line_number":697,"context_line":"                \u0027name\u0027: \u0027name_foo\u0027,"},{"line_number":698,"context_line":"            },"},{"line_number":699,"context_line":"        ]"},{"line_number":700,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        # Select share network"},{"line_number":703,"context_line":"        for sn in engine.execute("}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_0ffa3843","line":700,"range":{"start_line":690,"start_character":8,"end_line":700,"end_character":55},"updated":"2016-04-26 10:23:19.000000000","message":"The same here. Why do you need second SN?","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        for sn in engine.execute(sn_table.select()):"},{"line_number":688,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027gateway\u0027))"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        # Create share network"},{"line_number":691,"context_line":"        share_networks \u003d ["},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027id\u0027: self.sn_ids[1],"},{"line_number":694,"context_line":"                \u0027user_id\u0027: sn.user_id,"},{"line_number":695,"context_line":"                \u0027project_id\u0027: sn.project_id,"},{"line_number":696,"context_line":"                \u0027gateway\u0027: \u00271.1.1.1\u0027,"},{"line_number":697,"context_line":"                \u0027name\u0027: \u0027name_foo\u0027,"},{"line_number":698,"context_line":"            },"},{"line_number":699,"context_line":"        ]"},{"line_number":700,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        # Select share network"},{"line_number":703,"context_line":"        for sn in engine.execute("}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_01956ce3","line":700,"range":{"start_line":690,"start_character":8,"end_line":700,"end_character":55},"in_reply_to":"1a122d0e_0ffa3843","updated":"2016-06-20 08:45:56.000000000","message":"First of all, I creates one item of share_network without gateway, and then creates the second one with gateway info.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                                       getattr(sn, \u0027gateway\u0027))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def check_downgrade(self, engine):"},{"line_number":710,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"},{"line_number":711,"context_line":"        db_result \u003d engine.execute(na_table.select())"},{"line_number":712,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.na_ids))"},{"line_number":713,"context_line":"        for na in db_result:"},{"line_number":714,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        sn_table \u003d utils.load_table(self.share_network_table, engine)"},{"line_number":717,"context_line":"        db_result \u003d engine.execute(sn_table.select())"},{"line_number":718,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.sn_ids))"},{"line_number":719,"context_line":"        for na in db_result:"},{"line_number":720,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_2f3294a7","line":720,"range":{"start_line":710,"start_character":8,"end_line":720,"end_character":62},"updated":"2016-04-26 10:23:19.000000000","message":"for table_name, ids in ((name_a, ids_a), (name_b, ids_b)):\n    table \u003d utils.load_table(table_name, engine)\n    db_result \u003d engine.execute(table.select())\n    self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(ids))\n    for record in db_result:\n        self.test_case.assertFalse(hasattr(record, \u0027gateway\u0027))","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                                       getattr(sn, \u0027gateway\u0027))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def check_downgrade(self, engine):"},{"line_number":710,"context_line":"        na_table \u003d utils.load_table(self.network_allocation_table, engine)"},{"line_number":711,"context_line":"        db_result \u003d engine.execute(na_table.select())"},{"line_number":712,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.na_ids))"},{"line_number":713,"context_line":"        for na in db_result:"},{"line_number":714,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        sn_table \u003d utils.load_table(self.share_network_table, engine)"},{"line_number":717,"context_line":"        db_result \u003d engine.execute(sn_table.select())"},{"line_number":718,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e\u003d len(self.sn_ids))"},{"line_number":719,"context_line":"        for na in db_result:"},{"line_number":720,"context_line":"            self.test_case.assertFalse(hasattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_4112d463","line":720,"range":{"start_line":710,"start_character":8,"end_line":720,"end_character":62},"in_reply_to":"1a122d0e_2f3294a7","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0dfbe7f51935dc6500cc41a42870ef38aec1a16d","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        # Select network allocations with gateway info"},{"line_number":728,"context_line":"        for na in engine.execute("},{"line_number":729,"context_line":"                na_table.select().where(na_table.c.gateway \u003d\u003d \u00273.3.3.1\u0027)):"},{"line_number":730,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":731,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":732,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_78e603b1","line":729,"range":{"start_line":728,"start_character":8,"end_line":729,"end_character":74},"updated":"2016-06-24 10:44:18.000000000","message":"In case you get empty list, you just won\u0027t reach assertions.","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"fae41d46d2550c0ded8e9a875b4171d839eb871e","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        # Select network allocations with gateway info"},{"line_number":728,"context_line":"        for na in engine.execute("},{"line_number":729,"context_line":"                na_table.select().where(na_table.c.gateway \u003d\u003d \u00273.3.3.1\u0027)):"},{"line_number":730,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027gateway\u0027))"},{"line_number":731,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027gateway\u0027],"},{"line_number":732,"context_line":"                                       getattr(na, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_fba78d4d","line":729,"range":{"start_line":728,"start_character":8,"end_line":729,"end_character":74},"in_reply_to":"3aaa91ec_78e603b1","updated":"2016-06-30 09:23:52.000000000","message":"I built the network_allocation in which the gateway property is set to 3.3.3.1. So for this case, it will reach assertions.","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0dfbe7f51935dc6500cc41a42870ef38aec1a16d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        # Select share network"},{"line_number":751,"context_line":"        for sn in engine.execute("},{"line_number":752,"context_line":"                sn_table.select().where(sn_table.c.name \u003d\u003d \u0027name_foo\u0027)):"},{"line_number":753,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027gateway\u0027))"},{"line_number":754,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027gateway\u0027],"},{"line_number":755,"context_line":"                                       getattr(sn, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_98012f3b","line":752,"range":{"start_line":751,"start_character":8,"end_line":752,"end_character":72},"updated":"2016-06-24 10:44:18.000000000","message":"same here","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"fae41d46d2550c0ded8e9a875b4171d839eb871e","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        # Select share network"},{"line_number":751,"context_line":"        for sn in engine.execute("},{"line_number":752,"context_line":"                sn_table.select().where(sn_table.c.name \u003d\u003d \u0027name_foo\u0027)):"},{"line_number":753,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027gateway\u0027))"},{"line_number":754,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027gateway\u0027],"},{"line_number":755,"context_line":"                                       getattr(sn, \u0027gateway\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_1b69b9f9","line":752,"range":{"start_line":751,"start_character":8,"end_line":752,"end_character":72},"in_reply_to":"3aaa91ec_98012f3b","updated":"2016-06-30 09:23:52.000000000","message":"See my comment above.","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a5c492dbff0ee6fd735456809f3f8456d20cf307","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @mock.patch.object(db_api, \u0027share_network_update\u0027, mock.Mock())"},{"line_number":274,"context_line":"    def test_save_neutron_subnet_data(self):"},{"line_number":275,"context_line":"        neutron_subnet_info \u003d {\u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":276,"context_line":"                               \u0027ip_version\u0027: 4,"},{"line_number":277,"context_line":"                               \u0027gateway_ip\u0027: \u002710.0.0.1\u0027}"},{"line_number":278,"context_line":"        subnet_value \u003d {\u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":279,"context_line":"                        \u0027ip_version\u0027: 4,"},{"line_number":280,"context_line":"                        \u0027gateway\u0027: \u002710.0.0.1\u0027}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        with mock.patch.object(self.plugin.neutron_api,"},{"line_number":283,"context_line":"                               \u0027get_subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8e9fa64f","line":280,"range":{"start_line":275,"start_character":8,"end_line":280,"end_character":46},"updated":"2016-04-18 13:54:37.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists\n\"\"\"\"\"\"\"\nsubnet_value \u003d {\n    \u0027cidr\u0027: \u002710.0.0.0/24\u0027,\n    \u0027ip_version\u0027: 4,\n    \u0027gateway\u0027: \u002710.0.0.1\u0027,\n}\n\"\"\"\"\"\"\"","commit_id":"7f066f73ed5b5ba294165db12d673edecfc97e71"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"c17d0a61abcdb46b1271c2c7be95eea976050dea","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @mock.patch.object(db_api, \u0027share_network_update\u0027, mock.Mock())"},{"line_number":274,"context_line":"    def test_save_neutron_subnet_data(self):"},{"line_number":275,"context_line":"        neutron_subnet_info \u003d {\u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":276,"context_line":"                               \u0027ip_version\u0027: 4,"},{"line_number":277,"context_line":"                               \u0027gateway_ip\u0027: \u002710.0.0.1\u0027}"},{"line_number":278,"context_line":"        subnet_value \u003d {\u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":279,"context_line":"                        \u0027ip_version\u0027: 4,"},{"line_number":280,"context_line":"                        \u0027gateway\u0027: \u002710.0.0.1\u0027}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        with mock.patch.object(self.plugin.neutron_api,"},{"line_number":283,"context_line":"                               \u0027get_subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5d899825","line":280,"range":{"start_line":275,"start_character":8,"end_line":280,"end_character":46},"in_reply_to":"1a122d0e_8e9fa64f","updated":"2016-04-19 08:56:56.000000000","message":"Done","commit_id":"7f066f73ed5b5ba294165db12d673edecfc97e71"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2e17304b3bf46677a5901e653f7ccd0776b23480","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @mock.patch.object(db_api, \u0027share_network_update\u0027, mock.Mock())"},{"line_number":274,"context_line":"    def test_save_neutron_subnet_data(self):"},{"line_number":275,"context_line":"        neutron_subnet_info \u003d {"},{"line_number":276,"context_line":"            \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":277,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":278,"context_line":"            \u0027gateway_ip\u0027: \u002710.0.0.1\u0027,"},{"line_number":279,"context_line":"        }"},{"line_number":280,"context_line":"        subnet_value \u003d {"},{"line_number":281,"context_line":"            \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":282,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":283,"context_line":"            \u0027gateway\u0027: \u002710.0.0.1\u0027,"},{"line_number":284,"context_line":"        }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        with mock.patch.object(self.plugin.neutron_api,"},{"line_number":287,"context_line":"                               \u0027get_subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_70a8fbdb","line":284,"range":{"start_line":275,"start_character":8,"end_line":284,"end_character":9},"updated":"2016-04-25 16:39:46.000000000","message":"These are identical. Why do you need them both? Name of the last is confusing.","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"4f6c7d5b9d0b24f9fd4b132a05287de3fe29c5a2","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @mock.patch.object(db_api, \u0027share_network_update\u0027, mock.Mock())"},{"line_number":274,"context_line":"    def test_save_neutron_subnet_data(self):"},{"line_number":275,"context_line":"        neutron_subnet_info \u003d {"},{"line_number":276,"context_line":"            \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":277,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":278,"context_line":"            \u0027gateway_ip\u0027: \u002710.0.0.1\u0027,"},{"line_number":279,"context_line":"        }"},{"line_number":280,"context_line":"        subnet_value \u003d {"},{"line_number":281,"context_line":"            \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":282,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":283,"context_line":"            \u0027gateway\u0027: \u002710.0.0.1\u0027,"},{"line_number":284,"context_line":"        }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        with mock.patch.object(self.plugin.neutron_api,"},{"line_number":287,"context_line":"                               \u0027get_subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_b8cf0d7e","line":284,"range":{"start_line":275,"start_character":8,"end_line":284,"end_character":9},"in_reply_to":"1a122d0e_70a8fbdb","updated":"2016-06-20 08:47:14.000000000","message":"in share_network/network_allocations table, the name of the column is defined as \"gateway\", but it is defined as \"gateway_ip\" in neutron subnet table. So the dict is created just for the conversion between gateway_ip and gateway. This may raise another question: is it better to replace gateway as gateway_ip in this bp?","commit_id":"041113dea1531693841c3cb96716a02000060c53"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2e17304b3bf46677a5901e653f7ccd0776b23480","unresolved":false,"context_lines":[{"line_number":2826,"context_line":"        fake_share_network \u003d dict("},{"line_number":2827,"context_line":"            segmentation_id\u003d\u0027fake_segmentation_id\u0027,"},{"line_number":2828,"context_line":"            cidr\u003d\u0027fake_cidr\u0027,"},{"line_number":2829,"context_line":"            gateway\u003d\u0027fake_gateway\u0027,"},{"line_number":2830,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":2831,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":2832,"context_line":"            nova_net_id\u003d\u0027fake_nova_net_id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_10bf07fc","line":2829,"range":{"start_line":2829,"start_character":12,"end_line":2829,"end_character":35},"updated":"2016-04-25 16:39:46.000000000","message":"should be removed","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"4f6c7d5b9d0b24f9fd4b132a05287de3fe29c5a2","unresolved":false,"context_lines":[{"line_number":2826,"context_line":"        fake_share_network \u003d dict("},{"line_number":2827,"context_line":"            segmentation_id\u003d\u0027fake_segmentation_id\u0027,"},{"line_number":2828,"context_line":"            cidr\u003d\u0027fake_cidr\u0027,"},{"line_number":2829,"context_line":"            gateway\u003d\u0027fake_gateway\u0027,"},{"line_number":2830,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":2831,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":2832,"context_line":"            nova_net_id\u003d\u0027fake_nova_net_id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_585a39f3","line":2829,"range":{"start_line":2829,"start_character":12,"end_line":2829,"end_character":35},"in_reply_to":"1a122d0e_10bf07fc","updated":"2016-06-20 08:47:14.000000000","message":"Done","commit_id":"041113dea1531693841c3cb96716a02000060c53"}],"manila_tempest_tests/tests/api/test_share_networks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6284a95824db6d141130c1feda7e854bbe0f7b39","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # In v2.18 and beyond, we expect gateway."},{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.update.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_b4e9d982","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":41},"updated":"2016-06-23 10:36:41.000000000","message":"O.o","commit_id":"384252c65188b67239a82e27b946e60f1e296ad9"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"8fb9d121ad5448862628c3251fbb2ea1ac26f34b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # In v2.18 and beyond, we expect gateway."},{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.update.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_6a8e34d1","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":41},"in_reply_to":"3aaa91ec_b4e9d982","updated":"2016-06-24 07:28:38.000000000","message":"Done","commit_id":"384252c65188b67239a82e27b946e60f1e296ad9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0dfbe7f51935dc6500cc41a42870ef38aec1a16d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        keys \u003d [\"name\", \"id\"]"},{"line_number":37,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":40,"context_line":"    def test_list_share_networks_with_detail(self):"},{"line_number":41,"context_line":"        listed \u003d self.shares_client.list_share_networks_with_detail()"},{"line_number":42,"context_line":"        any(self.sn_with_ldap_ss[\"id\"] in sn[\"id\"] for sn in listed)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # verify keys"},{"line_number":45,"context_line":"        keys \u003d ["},{"line_number":46,"context_line":"            \"name\", \"id\", \"description\", \"network_type\","},{"line_number":47,"context_line":"            \"project_id\", \"cidr\", \"ip_version\","},{"line_number":48,"context_line":"            \"neutron_net_id\", \"neutron_subnet_id\","},{"line_number":49,"context_line":"            \"created_at\", \"updated_at\", \"segmentation_id\","},{"line_number":50,"context_line":"        ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # In v2.18 and beyond, we expect gateway."},{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":59,"context_line":"    def test_list_share_networks_filter_by_ss(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_98764fd5","line":56,"range":{"start_line":39,"start_character":4,"end_line":56,"end_character":72},"updated":"2016-06-24 10:44:18.000000000","message":"This test fails because you request list of share networks using v1 API.","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"fae41d46d2550c0ded8e9a875b4171d839eb871e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        keys \u003d [\"name\", \"id\"]"},{"line_number":37,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":40,"context_line":"    def test_list_share_networks_with_detail(self):"},{"line_number":41,"context_line":"        listed \u003d self.shares_client.list_share_networks_with_detail()"},{"line_number":42,"context_line":"        any(self.sn_with_ldap_ss[\"id\"] in sn[\"id\"] for sn in listed)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # verify keys"},{"line_number":45,"context_line":"        keys \u003d ["},{"line_number":46,"context_line":"            \"name\", \"id\", \"description\", \"network_type\","},{"line_number":47,"context_line":"            \"project_id\", \"cidr\", \"ip_version\","},{"line_number":48,"context_line":"            \"neutron_net_id\", \"neutron_subnet_id\","},{"line_number":49,"context_line":"            \"created_at\", \"updated_at\", \"segmentation_id\","},{"line_number":50,"context_line":"        ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # In v2.18 and beyond, we expect gateway."},{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":59,"context_line":"    def test_list_share_networks_filter_by_ss(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_9b000936","line":56,"range":{"start_line":39,"start_character":4,"end_line":56,"end_character":72},"in_reply_to":"3aaa91ec_98764fd5","updated":"2016-06-30 09:23:52.000000000","message":"Use v2 API. :)","commit_id":"1234af4e45c75f4bb68a450b9572779a38c3487c"}],"releasenotes/notes/add_gateway_into_network_info-1f3cd3f392ae81cf.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2e17304b3bf46677a5901e653f7ccd0776b23480","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Retrieve gateway info from network and put it into the parameter"},{"line_number":4,"context_line":"    network_info when invoking setup_server()."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_7012bb0a","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":46},"updated":"2016-04-25 16:39:46.000000000","message":"It is too specific information, it is developer-only information. Need just to say something like following:\n\n\"Store network gateway value in DB\".","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"4f6c7d5b9d0b24f9fd4b132a05287de3fe29c5a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Retrieve gateway info from network and put it into the parameter"},{"line_number":4,"context_line":"    network_info when invoking setup_server()."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_b8738d7f","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":46},"in_reply_to":"1a122d0e_7012bb0a","updated":"2016-06-20 08:47:14.000000000","message":"Done","commit_id":"041113dea1531693841c3cb96716a02000060c53"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9892124b8b1af782fc978de44f6b2fa8b745ae78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Sore network gateway value in DB."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_efe1bc2b","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":8},"updated":"2016-04-26 10:23:19.000000000","message":"\"Store\"\n\nAlso, name of file can be changed.","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ac1f318ad01ec12fdfc9b377e4067353d0307a06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Sore network gateway value in DB."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a9d85d2_a41aa66c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":8},"in_reply_to":"1a122d0e_efe1bc2b","updated":"2016-06-20 08:45:56.000000000","message":"Done","commit_id":"c931c60774fd931123bc480b9cca0536e57a712d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aaee47913da9f97aae0ebf57d4b8b443590c61ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Sore network gateway value in DB."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dab17558_5ea22bfe","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":9},"updated":"2016-05-24 21:54:59.000000000","message":"Store","commit_id":"58ea6422f6aeaec23883ba73971445a321eed464"}]}
