)]}'
{"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6971b2c87ebb00942181f8e92d2ddb2992177506","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            self.size_measure \u003d items[4]"},{"line_number":502,"context_line":"            if self.size_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":503,"context_line":"                self.size \u003d self.size * units.Ki"},{"line_number":504,"context_line":"            try:"},{"line_number":505,"context_line":"                self.used \u003d float(items[5])"},{"line_number":506,"context_line":"                self.mounted \u003d True"},{"line_number":507,"context_line":"            except ValueError:"},{"line_number":508,"context_line":"                self.mounted \u003d False"},{"line_number":509,"context_line":"            if self.mounted:"},{"line_number":510,"context_line":"                self.used_measure \u003d items[6]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_71f2589c","line":507,"range":{"start_line":504,"start_character":0,"end_line":507,"end_character":30},"updated":"2016-05-05 20:47:16.000000000","message":"I don\u0027t like the idea of using try-except for this kind of flow control. I\u0027d rather use an if:\n\n    if items[5:7] \u003d\u003d [\"Not\", \"mounted\"]:\n        self.mounted \u003d False\n    else:\n        self.mounted \u003d True\n        self.used \u003d float(items[5])\n        self.used_measure \u003d\u003d items[6]","commit_id":"af3c4138324c48acfc5494161ff351d2ee5f8a85"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae6c0afcefa7d0be6f1af155710bade95adac1e5","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            self.size_measure \u003d items[4]"},{"line_number":502,"context_line":"            if self.size_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":503,"context_line":"                self.size \u003d self.size * units.Ki"},{"line_number":504,"context_line":"            try:"},{"line_number":505,"context_line":"                self.used \u003d float(items[5])"},{"line_number":506,"context_line":"                self.mounted \u003d True"},{"line_number":507,"context_line":"            except ValueError:"},{"line_number":508,"context_line":"                self.mounted \u003d False"},{"line_number":509,"context_line":"            if self.mounted:"},{"line_number":510,"context_line":"                self.used_measure \u003d items[6]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_3ce24a04","line":507,"range":{"start_line":504,"start_character":0,"end_line":507,"end_character":30},"in_reply_to":"dab17558_71f2589c","updated":"2016-05-06 12:02:45.000000000","message":"Done","commit_id":"af3c4138324c48acfc5494161ff351d2ee5f8a85"}],"manila/tests/share/drivers/hitachi/test_ssh.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ad665da5b52ef8e8e5eb7b795d08d9118ef152a6","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    def test_check_fs_mounted_false(self):"},{"line_number":616,"context_line":"        self.mock_object("},{"line_number":617,"context_line":"            ssh.HNASSSHBackend, \"_execute\","},{"line_number":618,"context_line":"            mock.Mock(return_value\u003d(HNAS_RESULT_df_unmounted, \u0027\u0027)))"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        self.assertFalse(self._driver_ssh.check_fs_mounted())"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_26cd8b85","line":618,"range":{"start_line":618,"start_character":62,"end_line":618,"end_character":67},"updated":"2016-05-10 16:25:34.000000000","message":"I suggest adding assert_called_once_with in these new tests to make sure your mock is called as expected -- but since you happen to have a pretty clear result with True|False|Raises it is OK.","commit_id":"0d6de5088882331c575f3a6e837dbddc4af4adf5"}],"releasenotes/notes/fix-hds-hnas-unconfined-09b79f3bdb24a83c.yaml":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6971b2c87ebb00942181f8e92d2ddb2992177506","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Crash when using unconfined filesystems in HDS HNAS driver using"},{"line_number":4,"context_line":"    SSH backend."},{"line_number":5,"context_line":"  - HDS HNAS Driver no longer mounts unmounted filesystems automatically."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dab17558_f1b5a87e","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":73},"updated":"2016-05-05 20:47:16.000000000","message":"Is this a fix?","commit_id":"af3c4138324c48acfc5494161ff351d2ee5f8a85"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae6c0afcefa7d0be6f1af155710bade95adac1e5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Crash when using unconfined filesystems in HDS HNAS driver using"},{"line_number":4,"context_line":"    SSH backend."},{"line_number":5,"context_line":"  - HDS HNAS Driver no longer mounts unmounted filesystems automatically."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dab17558_215ea3e9","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":73},"in_reply_to":"dab17558_f1b5a87e","updated":"2016-05-06 12:02:45.000000000","message":"according to our internal discussion, this is considered a fix.","commit_id":"af3c4138324c48acfc5494161ff351d2ee5f8a85"}]}