)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0dfefb10774ff963cb1648519d993600de9ebe9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-20 19:56:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean \"deleted\" row in Database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to clean up rows that are already"},{"line_number":10,"context_line":"marked as deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_0f948288","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2016-04-21 11:36:18.000000000","message":"Add \"manila-manage db purge\" command","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0dfefb10774ff963cb1648519d993600de9ebe9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean \"deleted\" row in Database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to clean up rows that are already"},{"line_number":10,"context_line":"marked as deleted."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add command: \"manila-manage db purge\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_ef3f8684","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":18},"updated":"2016-04-21 11:36:18.000000000","message":"Cloud admins delete lots of DB records manually that were \"soft-deleted\" in Manila. They do it to reduce size of DB and increase response speed. Therefore, add \"manila-manage db purge\" command that will make cloud admins life easier allowing them to purge such DB records in one click.\n\nExamples of usage:\n\n$ manila-manage db purge 5","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"}],"doc/source/devref/db_purge.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2880a75bcd9a846bb61f210dbdbfb52a67d97f3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright 2010-2011 United States Government as represented by the"},{"line_number":3,"context_line":"      Administrator of the National Aeronautics and Space Administration."},{"line_number":4,"context_line":"      All Rights Reserved."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"      Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_fe3a4dcc","line":3,"range":{"start_line":2,"start_character":6,"end_line":3,"end_character":73},"updated":"2017-01-11 05:15:08.000000000","message":"This copyright header does not look right.","commit_id":"c5020916ac641f07fbccabf156fe269449c63200"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"dbe38f5f61eb536d1ba0a05de2da95d61dd6f417","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright (c) 2015 Huawei Technologies Co., Ltd."},{"line_number":3,"context_line":"      All Rights Reserved."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"      Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ba5201f7_e56360af","line":2,"range":{"start_line":2,"start_character":20,"end_line":2,"end_character":24},"updated":"2017-01-12 04:40:30.000000000","message":"2015?  Since you submitted the patch in 2016, it should be 2016.","commit_id":"712d4f52333b0686758b8ad052e844dc275d1043"}],"manila/cmd/manage.py":[{"author":{"_account_id":21059,"name":"xulin","email":"xulin1@huawei.com","username":"Erik"},"change_message_id":"5098c1a97a221312b0c77be7919bb27b0818de36","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge deleted rows older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted rows older than a given age from cinder tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c\u003d 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b372620f","line":246,"range":{"start_line":246,"start_character":11,"end_line":246,"end_character":72},"updated":"2016-04-20 09:21:50.000000000","message":"Purge deleted rows older than a given age from manila tables.","commit_id":"8377ac99da413a81de44100dcddd23d63970dd63"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted rows older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c\u003d 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_74c997ab","line":248,"range":{"start_line":248,"start_character":11,"end_line":248,"end_character":22},"updated":"2016-09-18 02:28:26.000000000","message":"why not allow age_in_days\u003d\u003d0, then this command will delete all of the deleted rows.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        \"\"\"Purge deleted rows older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c\u003d 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":252,"context_line":"        db.purge_deleted_rows(ctxt, age_in_days)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_f105b913","line":249,"range":{"start_line":249,"start_character":45,"end_line":249,"end_character":53},"updated":"2016-09-18 02:28:26.000000000","message":"I think positive here already indicates non-zero.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        \"\"\"Purge deleted rows older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c\u003d 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":252,"context_line":"        db.purge_deleted_rows(ctxt, age_in_days)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_713a89e8","line":249,"range":{"start_line":249,"start_character":67,"end_line":249,"end_character":68},"updated":"2016-09-18 02:28:26.000000000","message":"tail period.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_bf2e7bf8","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":25},"updated":"2016-11-21 08:01:11.000000000","message":"you\u0027ve already specify the type as int at @args, do we still need this convert?","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1ac995b049d1de69f510d02abe438102a9ba481a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_55935f4f","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":25},"in_reply_to":"7a77a97e_51255308","updated":"2016-11-22 01:35:51.000000000","message":"Ok, let\u0027s wait for the other comments that point out this is unnecessary.","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c5725a5763db99d736fb0da570369a79fed7942f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_51255308","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":25},"in_reply_to":"7a77a97e_b6021d71","updated":"2016-11-21 11:59:00.000000000","message":"I\u0027m not sure either, maybe you could have a try :)","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8a22efae6cb2953d49201a1d172492bfb8ddaedb","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_b6021d71","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":25},"in_reply_to":"7a77a97e_bf2e7bf8","updated":"2016-11-21 11:29:00.000000000","message":"This logic is existing in current codes. Also, I am not sure whether this decorator could ensure that.","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_3fe34b07","line":248,"range":{"start_line":248,"start_character":11,"end_line":248,"end_character":26},"updated":"2016-11-21 08:01:11.000000000","message":"if age_in_days cannot be negative, why it defaults -1 above?","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1ac995b049d1de69f510d02abe438102a9ba481a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_35b503d0","line":248,"range":{"start_line":248,"start_character":11,"end_line":248,"end_character":26},"in_reply_to":"7a77a97e_31d537b9","updated":"2016-11-22 01:35:51.000000000","message":"yeah, you can also put your suggestion here, and maybe -1 is not the best solution","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c5725a5763db99d736fb0da570369a79fed7942f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_31d537b9","line":248,"range":{"start_line":248,"start_character":11,"end_line":248,"end_character":26},"in_reply_to":"7a77a97e_367b6d2b","updated":"2016-11-21 11:59:00.000000000","message":"so if users don\u0027t specify this argument in command line, the argument\u0027ll dedault to -1, and users\u0027ll get this error message and they\u0027ll know that must provide this argument explictly?","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8a22efae6cb2953d49201a1d172492bfb8ddaedb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"},{"line_number":250,"context_line":"            exit(1)"},{"line_number":251,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_367b6d2b","line":248,"range":{"start_line":248,"start_character":11,"end_line":248,"end_character":26},"in_reply_to":"7a77a97e_3fe34b07","updated":"2016-11-21 11:29:00.000000000","message":"the reason why I add the \u0027-1\u0027 here is to prevent default 0, but you can provide more reasonable default value here, thanks","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \"\"\"Stamp the version table with the given version.\"\"\""},{"line_number":241,"context_line":"        return migration.stamp(version)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint, default\u003d-1,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_178644b9","line":243,"range":{"start_line":243,"start_character":35,"end_line":243,"end_character":45},"updated":"2016-11-22 07:32:30.000000000","message":"Is there an option like \u0027required\u0027? If there is, maybe we could require users must specify this argument, and no need to set this default value.","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint, default\u003d-1,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge deleted records older than a given age from manila tables.\"\"\""},{"line_number":247,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":248,"context_line":"        if age_in_days \u003c 0:"},{"line_number":249,"context_line":"            print(_(\"Must supply a non-negative value for age.\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_77c69817","line":246,"range":{"start_line":246,"start_character":17,"end_line":246,"end_character":24},"updated":"2016-11-22 07:32:30.000000000","message":"soft-deleted","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return migration.stamp(version)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge soft-deleted records older than"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_a44843cd","line":244,"range":{"start_line":244,"start_character":16,"end_line":244,"end_character":65},"updated":"2016-11-29 10:52:20.000000000","message":"This is the help text for the argument, not the command itself. \n\n  \u0027A non-negative integer, denoting the age of soft-deleted \u0027\n  \u0027records in number of days. 0 can be specified to purge all \u0027\n  \u0027soft-deleted rows.\u0027","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return migration.stamp(version)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge soft-deleted records older than"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_5b129eb5","line":244,"range":{"start_line":244,"start_character":16,"end_line":244,"end_character":65},"in_reply_to":"5a74a57a_a44843cd","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return migration.stamp(version)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint,"},{"line_number":244,"context_line":"          help\u003d\u0027Purge soft-deleted records older than age in days\u0027)"},{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge soft-deleted records older than"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_fbf52a83","line":244,"range":{"start_line":244,"start_character":16,"end_line":244,"end_character":65},"in_reply_to":"5a74a57a_a44843cd","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge soft-deleted records older than"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        a given age from manila tables."},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":251,"context_line":"        if age_in_days \u003c 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_24e6f3e7","line":248,"range":{"start_line":248,"start_character":19,"end_line":248,"end_character":38},"updated":"2016-11-29 10:52:20.000000000","message":"not required","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    def purge(self, age_in_days):"},{"line_number":246,"context_line":"        \"\"\"Purge soft-deleted records older than"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        a given age from manila tables."},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":251,"context_line":"        if age_in_days \u003c 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_7b175aa3","line":248,"range":{"start_line":248,"start_character":19,"end_line":248,"end_character":38},"in_reply_to":"5a74a57a_24e6f3e7","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"138c5036e78f81a00045e0519fe5a36fe575bf9c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \"\"\"Stamp the version table with the given version.\"\"\""},{"line_number":241,"context_line":"        return migration.stamp(version)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @args(\u0027age_in_days\u0027, type\u003dint,"},{"line_number":244,"context_line":"          help\u003d\u0027A non-negative integer, denoting the age of soft-deleted \u0027"},{"line_number":245,"context_line":"               \u0027records in number of days. 0 can be specified to purge all \u0027"},{"line_number":246,"context_line":"               \u0027soft-deleted rows.\u0027)"},{"line_number":247,"context_line":"    def purge(self, age_in_days):"},{"line_number":248,"context_line":"        \"\"\"Purge soft-deleted records older than a given age.\"\"\""},{"line_number":249,"context_line":"        age_in_days \u003d int(age_in_days)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_96a81022","line":246,"range":{"start_line":243,"start_character":4,"end_line":246,"end_character":36},"updated":"2017-01-17 12:48:14.000000000","message":"We should allow not providing value in days, and assume it is 0 if not provided.","commit_id":"7a8fde34d90e57ece7d1400c4f5c1f4fd40797b4"}],"manila/db/api.py":[{"author":{"_account_id":21059,"name":"xulin","email":"xulin1@huawei.com","username":"Erik"},"change_message_id":"5098c1a97a221312b0c77be7919bb27b0818de36","unresolved":false,"context_lines":[{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"def purge_deleted_rows(context, age_in_days):"},{"line_number":1120,"context_line":"    \"\"\"Purge deleted rows older than given age from cinder tables"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    Raises InvalidParameterValue if age_in_days is incorrect."},{"line_number":1123,"context_line":"    :returns: number of deleted rows"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_338652db","line":1120,"range":{"start_line":1120,"start_character":7,"end_line":1120,"end_character":65},"updated":"2016-04-20 09:21:50.000000000","message":"Purge deleted rows older than given age from manila tables","commit_id":"8377ac99da413a81de44100dcddd23d63970dd63"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":1062,"context_line":"    \"\"\"Purge deleted rows older than given age from manila tables"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    Raises InvalidParameterValue if age_in_days is incorrect."},{"line_number":1065,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_97c094e2","line":1062,"range":{"start_line":1062,"start_character":13,"end_line":1062,"end_character":20},"updated":"2016-11-22 07:32:30.000000000","message":"soft-deleted","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":1062,"context_line":"    \"\"\"Purge soft-deleted rows older than given age from manila tables"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    Raises InvalidParameterValue if age_in_days is incorrect."},{"line_number":1065,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_64de2bde","line":1062,"range":{"start_line":1062,"start_character":52,"end_line":1062,"end_character":70},"updated":"2016-11-29 10:52:20.000000000","message":"from all tables","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":1062,"context_line":"    \"\"\"Purge soft-deleted rows older than given age from manila tables"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    Raises InvalidParameterValue if age_in_days is incorrect."},{"line_number":1065,"context_line":"    \"\"\""},{"line_number":1066,"context_line":"    return IMPL.purge_deleted_records(context, age_in_days\u003dage_in_days)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_84d987f5","line":1064,"range":{"start_line":1064,"start_character":4,"end_line":1064,"end_character":10},"updated":"2016-11-29 10:52:20.000000000","message":":raises","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":1062,"context_line":"    \"\"\"Purge soft-deleted rows older than given age from manila tables"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    Raises InvalidParameterValue if age_in_days is incorrect."},{"line_number":1065,"context_line":"    \"\"\""},{"line_number":1066,"context_line":"    return IMPL.purge_deleted_records(context, age_in_days\u003dage_in_days)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_9bd196d0","line":1064,"range":{"start_line":1064,"start_character":4,"end_line":1064,"end_character":10},"in_reply_to":"5a74a57a_84d987f5","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":21059,"name":"xulin","email":"xulin1@huawei.com","username":"Erik"},"change_message_id":"5098c1a97a221312b0c77be7919bb27b0818de36","unresolved":false,"context_lines":[{"line_number":3801,"context_line":""},{"line_number":3802,"context_line":"@require_admin_context"},{"line_number":3803,"context_line":"def purge_deleted_rows(context, age_in_days):"},{"line_number":3804,"context_line":"    \"\"\"Purge deleted rows older than age from cinder tables.\"\"\""},{"line_number":3805,"context_line":"    try:"},{"line_number":3806,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":3807,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_53b4ae80","line":3804,"range":{"start_line":3804,"start_character":7,"end_line":3804,"end_character":59},"updated":"2016-04-20 09:21:50.000000000","message":"Purge deleted rows older than age from manila tables","commit_id":"8377ac99da413a81de44100dcddd23d63970dd63"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from manila.db.sqlalchemy import models"},{"line_number":50,"context_line":"from manila import exception"},{"line_number":51,"context_line":"from manila.i18n import _"},{"line_number":52,"context_line":"from manila.i18n import _LE"},{"line_number":53,"context_line":"from manila.i18n import _LI"},{"line_number":54,"context_line":"from manila.i18n import _LW"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF \u003d cfg.CONF"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_b4e07f2a","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":27},"updated":"2016-09-18 02:28:26.000000000","message":"suggest moving these to one line.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":3803,"context_line":"def purge_deleted_rows(context, age_in_days):"},{"line_number":3804,"context_line":"    \"\"\"Purge deleted rows older than age from manila tables.\"\"\""},{"line_number":3805,"context_line":"    try:"},{"line_number":3806,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":3807,"context_line":"    except ValueError:"},{"line_number":3808,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":3809,"context_line":"        LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_9459c337","line":3806,"range":{"start_line":3806,"start_character":22,"end_line":3806,"end_character":25},"updated":"2016-09-18 02:28:26.000000000","message":"why need to convert again, it seems like it\u0027s already an int value passed here.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":3805,"context_line":"    try:"},{"line_number":3806,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":3807,"context_line":"    except ValueError:"},{"line_number":3808,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":3809,"context_line":"        LOG.exception(msg)"},{"line_number":3810,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3811,"context_line":"    if age_in_days \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_142f7388","line":3808,"range":{"start_line":3808,"start_character":47,"end_line":3808,"end_character":48},"updated":"2016-09-18 02:28:26.000000000","message":"tail period.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a4aa263651fcb9e129b3b7f12c7562a170784bff","unresolved":false,"context_lines":[{"line_number":3809,"context_line":"        LOG.exception(msg)"},{"line_number":3810,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3811,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":3812,"context_line":"        msg \u003d _(\u0027Must supply a positive value for age\u0027)"},{"line_number":3813,"context_line":"        LOG.error(msg)"},{"line_number":3814,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3815,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3450ef0a","line":3812,"range":{"start_line":3812,"start_character":53,"end_line":3812,"end_character":54},"updated":"2016-09-18 02:28:26.000000000","message":"tail period.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0dfefb10774ff963cb1648519d993600de9ebe9","unresolved":false,"context_lines":[{"line_number":3819,"context_line":"    metadata.bind \u003d engine"},{"line_number":3820,"context_line":"    tables \u003d []"},{"line_number":3821,"context_line":""},{"line_number":3822,"context_line":"    for model_class in models.__dict__.values():"},{"line_number":3823,"context_line":"        if (hasattr(model_class, \"__tablename__\")"},{"line_number":3824,"context_line":"                and hasattr(model_class, \"__tablename__\")"},{"line_number":3825,"context_line":"                and hasattr(model_class, \"deleted\")):"},{"line_number":3826,"context_line":"            tables.append(model_class.__tablename__)"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"    # manila_nodes not in db"},{"line_number":3829,"context_line":"    tables.remove(\"manila_nodes\")"},{"line_number":3830,"context_line":""},{"line_number":3831,"context_line":"    # Reorder the list so the shares table is last to avoid FK constraints"},{"line_number":3832,"context_line":"    tables_remove_list \u003d (\"services\", \"quotas\", \"project_user_quotas\","}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_6f19b621","line":3829,"range":{"start_line":3822,"start_character":4,"end_line":3829,"end_character":33},"updated":"2016-04-21 11:36:18.000000000","message":"Why do you need it?\n\nBetter to define tuple of tables just once using expected order.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(uglide): Required to override default oslo_db Query class"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_9f77ff07","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":64},"updated":"2016-11-21 08:01:11.000000000","message":"remove","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":3764,"context_line":""},{"line_number":3765,"context_line":""},{"line_number":3766,"context_line":"@require_admin_context"},{"line_number":3767,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":3768,"context_line":"    \"\"\"Purge soft-deleted records older than(and equal) age from tables.\"\"\""},{"line_number":3769,"context_line":""},{"line_number":3770,"context_line":"    if age_in_days \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_8a5edb10","line":3767,"range":{"start_line":3767,"start_character":4,"end_line":3767,"end_character":25},"updated":"2016-11-21 08:01:11.000000000","message":"this method doesn\u0027t return the deleted row number.","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8a22efae6cb2953d49201a1d172492bfb8ddaedb","unresolved":false,"context_lines":[{"line_number":3764,"context_line":""},{"line_number":3765,"context_line":""},{"line_number":3766,"context_line":"@require_admin_context"},{"line_number":3767,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":3768,"context_line":"    \"\"\"Purge soft-deleted records older than(and equal) age from tables.\"\"\""},{"line_number":3769,"context_line":""},{"line_number":3770,"context_line":"    if age_in_days \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_b65cddf1","line":3767,"range":{"start_line":3767,"start_character":4,"end_line":3767,"end_character":25},"in_reply_to":"7a77a97e_8a5edb10","updated":"2016-11-21 11:29:00.000000000","message":"We don\u0027t need to return the deleted row number, maybe I\u0027d modified th docstring","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c5725a5763db99d736fb0da570369a79fed7942f","unresolved":false,"context_lines":[{"line_number":3764,"context_line":""},{"line_number":3765,"context_line":""},{"line_number":3766,"context_line":"@require_admin_context"},{"line_number":3767,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":3768,"context_line":"    \"\"\"Purge soft-deleted records older than(and equal) age from tables.\"\"\""},{"line_number":3769,"context_line":""},{"line_number":3770,"context_line":"    if age_in_days \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_d148838d","line":3767,"range":{"start_line":3767,"start_character":4,"end_line":3767,"end_character":25},"in_reply_to":"7a77a97e_b65cddf1","updated":"2016-11-21 11:59:00.000000000","message":"I commented this because I found in the purge_deleted_records definition of db/api.py, the doc string says \"returns: number of deleted rows\"","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":3767,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":3768,"context_line":"    \"\"\"Purge soft-deleted records older than(and equal) age from tables.\"\"\""},{"line_number":3769,"context_line":""},{"line_number":3770,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":3771,"context_line":"        msg \u003d _(\u0027Must supply a non-negative value for \"age_in_days\".\u0027)"},{"line_number":3772,"context_line":"        LOG.error(msg)"},{"line_number":3773,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_1f53ef6d","line":3770,"range":{"start_line":3770,"start_character":19,"end_line":3770,"end_character":21},"updated":"2016-11-21 08:01:11.000000000","message":"according to the print message below, here should be \u003c","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8a22efae6cb2953d49201a1d172492bfb8ddaedb","unresolved":false,"context_lines":[{"line_number":3767,"context_line":"def purge_deleted_records(context, age_in_days):"},{"line_number":3768,"context_line":"    \"\"\"Purge soft-deleted records older than(and equal) age from tables.\"\"\""},{"line_number":3769,"context_line":""},{"line_number":3770,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":3771,"context_line":"        msg \u003d _(\u0027Must supply a non-negative value for \"age_in_days\".\u0027)"},{"line_number":3772,"context_line":"        LOG.error(msg)"},{"line_number":3773,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_561c6913","line":3770,"range":{"start_line":3770,"start_character":19,"end_line":3770,"end_character":21},"in_reply_to":"7a77a97e_1f53ef6d","updated":"2016-11-21 11:29:00.000000000","message":"Done","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"675d1b88fb7a445bf7e0bce191e06678682c61c1","unresolved":false,"context_lines":[{"line_number":3793,"context_line":"        except db_exc.DBError as e:"},{"line_number":3794,"context_line":"            LOG.error(_LE(\"Delete soft-delete records failed %(error), skip\""},{"line_number":3795,"context_line":"                          \"table %(table)\"), {\u0027error\u0027:"},{"line_number":3796,"context_line":"                                              six.text_type(e.message),"},{"line_number":3797,"context_line":"                                              \u0027table\u0027: model.__tablename__})"},{"line_number":3798,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_bf983b1d","line":3796,"range":{"start_line":3796,"start_character":46,"end_line":3796,"end_character":70},"updated":"2016-11-21 08:01:11.000000000","message":"maybe you could use LOG.exception instead, then there\u0027s no necessary to explicitly print out the exception info.","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c5725a5763db99d736fb0da570369a79fed7942f","unresolved":false,"context_lines":[{"line_number":3793,"context_line":"        except db_exc.DBError as e:"},{"line_number":3794,"context_line":"            LOG.error(_LE(\"Delete soft-delete records failed %(error), skip\""},{"line_number":3795,"context_line":"                          \"table %(table)\"), {\u0027error\u0027:"},{"line_number":3796,"context_line":"                                              six.text_type(e.message),"},{"line_number":3797,"context_line":"                                              \u0027table\u0027: model.__tablename__})"},{"line_number":3798,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_cc2468b4","line":3796,"range":{"start_line":3796,"start_character":46,"end_line":3796,"end_character":70},"in_reply_to":"7a77a97e_36e60d17","updated":"2016-11-21 11:59:00.000000000","message":"because LOG.exception will print out the exception trace itself,  the exception message can be included in the trace info.","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8a22efae6cb2953d49201a1d172492bfb8ddaedb","unresolved":false,"context_lines":[{"line_number":3793,"context_line":"        except db_exc.DBError as e:"},{"line_number":3794,"context_line":"            LOG.error(_LE(\"Delete soft-delete records failed %(error), skip\""},{"line_number":3795,"context_line":"                          \"table %(table)\"), {\u0027error\u0027:"},{"line_number":3796,"context_line":"                                              six.text_type(e.message),"},{"line_number":3797,"context_line":"                                              \u0027table\u0027: model.__tablename__})"},{"line_number":3798,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_36e60d17","line":3796,"range":{"start_line":3796,"start_character":46,"end_line":3796,"end_character":70},"in_reply_to":"7a77a97e_bf983b1d","updated":"2016-11-21 11:29:00.000000000","message":"could you explain why this is not needed, and maybe add a link here?","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1ac995b049d1de69f510d02abe438102a9ba481a","unresolved":false,"context_lines":[{"line_number":3793,"context_line":"        except db_exc.DBError as e:"},{"line_number":3794,"context_line":"            LOG.error(_LE(\"Delete soft-delete records failed %(error), skip\""},{"line_number":3795,"context_line":"                          \"table %(table)\"), {\u0027error\u0027:"},{"line_number":3796,"context_line":"                                              six.text_type(e.message),"},{"line_number":3797,"context_line":"                                              \u0027table\u0027: model.__tablename__})"},{"line_number":3798,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_5508bf91","line":3796,"range":{"start_line":3796,"start_character":46,"end_line":3796,"end_character":70},"in_reply_to":"7a77a97e_cc2468b4","updated":"2016-11-22 01:35:51.000000000","message":"thanks~","commit_id":"418f5c7fcd770ca3ddd376559d1bfae0b3cc3da3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_75e6a917","line":3777,"range":{"start_line":3777,"start_character":45,"end_line":3777,"end_character":47},"updated":"2016-11-21 18:03:35.000000000","message":"/is/are/","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_f5b8f9ea","line":3777,"range":{"start_line":3777,"start_character":48,"end_line":3777,"end_character":55},"updated":"2016-11-21 18:03:35.000000000","message":"s/marked/marked as/","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_35b3510c","line":3777,"range":{"start_line":3777,"start_character":55,"end_line":3777,"end_character":66},"updated":"2016-11-21 18:03:35.000000000","message":"s/soft-delete/soft-deleted/","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_55999f1e","line":3777,"range":{"start_line":3777,"start_character":55,"end_line":3777,"end_character":66},"in_reply_to":"7a77a97e_35b3510c","updated":"2016-11-22 01:36:36.000000000","message":"Done","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_359423e7","line":3777,"range":{"start_line":3777,"start_character":45,"end_line":3777,"end_character":47},"in_reply_to":"7a77a97e_75e6a917","updated":"2016-11-22 01:36:36.000000000","message":"Done","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_f5fb8b45","line":3777,"range":{"start_line":3777,"start_character":48,"end_line":3777,"end_character":55},"in_reply_to":"7a77a97e_f5b8f9ea","updated":"2016-11-22 01:36:36.000000000","message":"Done","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"},{"line_number":3781,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b5f041cb","line":3778,"range":{"start_line":3778,"start_character":22,"end_line":3778,"end_character":27},"updated":"2016-11-21 18:03:35.000000000","message":"s/older/old/","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":3775,"context_line":"        try:"},{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"},{"line_number":3781,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b501133c","line":3778,"range":{"start_line":3778,"start_character":22,"end_line":3778,"end_character":27},"in_reply_to":"7a77a97e_b5f041cb","updated":"2016-11-22 01:36:36.000000000","message":"Done","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"},{"line_number":3781,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"},{"line_number":3782,"context_line":"                                                      \u003c\u003d deleted_age)"},{"line_number":3783,"context_line":"                # Eliminate all records which has at lease one child"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_d5721d49","line":3780,"range":{"start_line":3779,"start_character":16,"end_line":3780,"end_character":68},"updated":"2016-11-21 18:03:35.000000000","message":"Calculate it only once - before loop. Do not do it for each separate cycle of a loop.","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":3776,"context_line":"            with session.begin_nested():"},{"line_number":3777,"context_line":"                # Retrieve all records which is marked soft-delete"},{"line_number":3778,"context_line":"                # and older enough."},{"line_number":3779,"context_line":"                deleted_age \u003d (timeutils.utcnow() -"},{"line_number":3780,"context_line":"                               datetime.timedelta(days\u003dage_in_days))"},{"line_number":3781,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"},{"line_number":3782,"context_line":"                                                      \u003c\u003d deleted_age)"},{"line_number":3783,"context_line":"                # Eliminate all records which has at lease one child"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_95ec1791","line":3780,"range":{"start_line":3779,"start_character":16,"end_line":3780,"end_character":68},"in_reply_to":"7a77a97e_d5721d49","updated":"2016-11-22 01:36:36.000000000","message":"Done","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":3768,"context_line":"    if age_in_days \u003c 0:"},{"line_number":3769,"context_line":"        msg \u003d _(\u0027Must supply a non-negative value for \"age_in_days\".\u0027)"},{"line_number":3770,"context_line":"        LOG.error(msg)"},{"line_number":3771,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3772,"context_line":"    session \u003d get_session()"},{"line_number":3773,"context_line":"    session.begin()"},{"line_number":3774,"context_line":"    deleted_age \u003d (timeutils.utcnow() - datetime.timedelta(days\u003dage_in_days))"},{"line_number":3775,"context_line":"    for model in models.SORTED_MODELS.keys():"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_f77628d7","line":3772,"range":{"start_line":3771,"start_character":0,"end_line":3772,"end_character":27},"updated":"2016-11-22 07:32:30.000000000","message":"suggest adding a new line between these two lines, it\u0027ll make codes more readable.","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":3771,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3772,"context_line":"    session \u003d get_session()"},{"line_number":3773,"context_line":"    session.begin()"},{"line_number":3774,"context_line":"    deleted_age \u003d (timeutils.utcnow() - datetime.timedelta(days\u003dage_in_days))"},{"line_number":3775,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3776,"context_line":"        try:"},{"line_number":3777,"context_line":"            with session.begin_nested():"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_7749388e","line":3774,"range":{"start_line":3774,"start_character":18,"end_line":3774,"end_character":19},"updated":"2016-11-22 07:32:30.000000000","message":"redundant parenthesis.","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":3772,"context_line":"    session \u003d get_session()"},{"line_number":3773,"context_line":"    session.begin()"},{"line_number":3774,"context_line":"    deleted_age \u003d (timeutils.utcnow() - datetime.timedelta(days\u003dage_in_days))"},{"line_number":3775,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3776,"context_line":"        try:"},{"line_number":3777,"context_line":"            with session.begin_nested():"},{"line_number":3778,"context_line":"                # Retrieve all records which are marked as soft-deleted"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_62c5f459","line":3775,"range":{"start_line":3775,"start_character":38,"end_line":3775,"end_character":44},"updated":"2016-11-22 07:32:30.000000000","message":"no need to explicitly convert to key list, \"for model in models.SORTED_MODELS\" is OK.","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":3774,"context_line":"    deleted_age \u003d (timeutils.utcnow() - datetime.timedelta(days\u003dage_in_days))"},{"line_number":3775,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3776,"context_line":"        try:"},{"line_number":3777,"context_line":"            with session.begin_nested():"},{"line_number":3778,"context_line":"                # Retrieve all records which are marked as soft-deleted"},{"line_number":3779,"context_line":"                # and old enough."},{"line_number":3780,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_02f9a0c8","line":3777,"range":{"start_line":3777,"start_character":12,"end_line":3777,"end_character":40},"updated":"2016-11-22 07:32:30.000000000","message":"could this step be merged to session.begin()? such as session.begin(nested\u003dTrue), I found there\u0027s a \u0027nested\u0027 argument for this \u0027begin\u0027 method.","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"48fffbc1bd166c274c7945ac586895fc2e6e38bf","unresolved":false,"context_lines":[{"line_number":3788,"context_line":"                         {\u0027row\u0027: rowcount,"},{"line_number":3789,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3790,"context_line":"        except db_exc.DBError:"},{"line_number":3791,"context_line":"            LOG.exception(_LE(\"Delete soft-delete records failed, \""},{"line_number":3792,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3793,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_d7ba0c6e","line":3791,"range":{"start_line":3791,"start_character":38,"end_line":3791,"end_character":49},"updated":"2016-11-22 07:32:30.000000000","message":"soft-deleted","commit_id":"b508cb19cf4739265170d424e619861ccb507da6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(uglide): Required to override default oslo_db Query class"},{"line_number":28,"context_line":"import manila.db.sqlalchemy.query  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":"from oslo_db import api as oslo_db_api"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_e4979be9","side":"PARENT","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":41},"updated":"2016-11-29 10:52:20.000000000","message":"why delete this?","commit_id":"97c764a9ea4b9b79d6c0fae92ca6ca782ee6da88"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(uglide): Required to override default oslo_db Query class"},{"line_number":28,"context_line":"import manila.db.sqlalchemy.query  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":"from oslo_db import api as oslo_db_api"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_7b1d9a72","side":"PARENT","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":41},"in_reply_to":"5a74a57a_e4979be9","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"97c764a9ea4b9b79d6c0fae92ca6ca782ee6da88"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":3789,"context_line":"                         {\u0027row\u0027: rowcount,"},{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_446f6ffb","line":3792,"range":{"start_line":3792,"start_character":31,"end_line":3792,"end_character":37},"updated":"2016-11-29 10:52:20.000000000","message":"Deletion of","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":3789,"context_line":"                         {\u0027row\u0027: rowcount,"},{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_d613e35a","line":3792,"range":{"start_line":3792,"start_character":31,"end_line":3792,"end_character":37},"in_reply_to":"5a74a57a_446f6ffb","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_847507cc","line":3793,"range":{"start_line":3793,"start_character":31,"end_line":3793,"end_character":35},"updated":"2016-11-29 10:52:20.000000000","message":"skipping","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_a480438c","line":3793,"range":{"start_line":3793,"start_character":43,"end_line":3793,"end_character":44},"updated":"2016-11-29 10:52:20.000000000","message":"trailing period","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_f610df50","line":3793,"range":{"start_line":3793,"start_character":31,"end_line":3793,"end_character":35},"in_reply_to":"5a74a57a_847507cc","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3791,"context_line":"        except db_exc.DBError:"},{"line_number":3792,"context_line":"            LOG.exception(_LE(\"Delete soft-deleted records failed, \""},{"line_number":3793,"context_line":"                              \"skip table %s\"), model.__tablename__)"},{"line_number":3794,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_161e3b63","line":3793,"range":{"start_line":3793,"start_character":43,"end_line":3793,"end_character":44},"in_reply_to":"5a74a57a_a480438c","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"87a4b87d460b377ceaaeadb7e25ec1bdfac196d5","unresolved":false,"context_lines":[{"line_number":3773,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":3774,"context_line":"    session \u003d get_session()"},{"line_number":3775,"context_line":"    session.begin()"},{"line_number":3776,"context_line":"    deleted_age \u003d (timeutils.utcnow() - datetime.timedelta(days\u003dage_in_days))"},{"line_number":3777,"context_line":"    for model in models.SORTED_MODELS.keys():"},{"line_number":3778,"context_line":"        try:"},{"line_number":3779,"context_line":"            with session.begin_nested():"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_91786791","line":3776,"range":{"start_line":3776,"start_character":18,"end_line":3776,"end_character":19},"updated":"2016-12-03 01:09:41.000000000","message":"redundant parenthesis","commit_id":"69c4843b895c7ad447e37a4a0cc6fd05ef38d97e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"87a4b87d460b377ceaaeadb7e25ec1bdfac196d5","unresolved":false,"context_lines":[{"line_number":3781,"context_line":"                # and old enough."},{"line_number":3782,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"},{"line_number":3783,"context_line":"                                                      \u003c\u003d deleted_age)"},{"line_number":3784,"context_line":"                # Eliminate all records which has at lease one child"},{"line_number":3785,"context_line":"                for relationship in models.SORTED_MODELS[model]:"},{"line_number":3786,"context_line":"                    children \u003d session.query(relationship)"},{"line_number":3787,"context_line":"                    records \u003d records.filter(~model.id.in_(children))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_d172dfac","line":3784,"range":{"start_line":3784,"start_character":46,"end_line":3784,"end_character":49},"updated":"2016-12-03 01:09:41.000000000","message":"have","commit_id":"69c4843b895c7ad447e37a4a0cc6fd05ef38d97e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"87a4b87d460b377ceaaeadb7e25ec1bdfac196d5","unresolved":false,"context_lines":[{"line_number":3786,"context_line":"                    children \u003d session.query(relationship)"},{"line_number":3787,"context_line":"                    records \u003d records.filter(~model.id.in_(children))"},{"line_number":3788,"context_line":"                rowcount \u003d records.delete(synchronize_session\u003dFalse)"},{"line_number":3789,"context_line":"                LOG.info(_LI(\"Deleted %(row)d rows from table\u003d%(table)s\"),"},{"line_number":3790,"context_line":"                         {\u0027row\u0027: rowcount,"},{"line_number":3791,"context_line":"                          \u0027table\u0027: model.__tablename__})"},{"line_number":3792,"context_line":"        except db_exc.DBError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_d1801f49","line":3789,"range":{"start_line":3789,"start_character":30,"end_line":3789,"end_character":71},"updated":"2016-12-03 01:09:41.000000000","message":"tailing with comma.","commit_id":"69c4843b895c7ad447e37a4a0cc6fd05ef38d97e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"22ac6f33564747964b4df91def7fd325d5be7f80","unresolved":false,"context_lines":[{"line_number":3781,"context_line":"                # and old enough."},{"line_number":3782,"context_line":"                records \u003d session.query(model).filter(model.deleted_at"},{"line_number":3783,"context_line":"                                                      \u003c\u003d deleted_age)"},{"line_number":3784,"context_line":"                # Eliminate all records which have at lease one child"},{"line_number":3785,"context_line":"                for relationship in models.SORTED_MODELS[model]:"},{"line_number":3786,"context_line":"                    children \u003d session.query(relationship)"},{"line_number":3787,"context_line":"                    records \u003d records.filter(~model.id.in_(children))"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_b62a267d","line":3784,"range":{"start_line":3784,"start_character":54,"end_line":3784,"end_character":59},"updated":"2016-12-12 15:27:49.000000000","message":"least","commit_id":"5c31bba904d50ec181745c4ed2855a94f0b3433b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"138c5036e78f81a00045e0519fe5a36fe575bf9c","unresolved":false,"context_lines":[{"line_number":3782,"context_line":"                        try:"},{"line_number":3783,"context_line":"                            with session.begin_nested():"},{"line_number":3784,"context_line":"                                session.delete(record)"},{"line_number":3785,"context_line":"                                LOG.info(_LI(\"Deleted record: \""},{"line_number":3786,"context_line":"                                             \"%(table)s %(id)s.\"),"},{"line_number":3787,"context_line":"                                         {\u0027id\u0027: record.id, \u0027table\u0027: table})"},{"line_number":3788,"context_line":"                        except db_exc.DBError:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_5656a85c","line":3785,"range":{"start_line":3785,"start_character":31,"end_line":3785,"end_character":63},"updated":"2017-01-17 12:48:14.000000000","message":"We should not write this message while we do not delete them indeed. So, in case of some error on one of last records we get lots of messages saying we deleted them, but it is not true because we failed on last one and haven\u0027t commited DB request.","commit_id":"7a8fde34d90e57ece7d1400c4f5c1f4fd40797b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"138c5036e78f81a00045e0519fe5a36fe575bf9c","unresolved":false,"context_lines":[{"line_number":3784,"context_line":"                                session.delete(record)"},{"line_number":3785,"context_line":"                                LOG.info(_LI(\"Deleted record: \""},{"line_number":3786,"context_line":"                                             \"%(table)s %(id)s.\"),"},{"line_number":3787,"context_line":"                                         {\u0027id\u0027: record.id, \u0027table\u0027: table})"},{"line_number":3788,"context_line":"                        except db_exc.DBError:"},{"line_number":3789,"context_line":"                            LOG.warning("},{"line_number":3790,"context_line":"                                _LE(\"Deletion of soft-delete record failed, \""}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_562868e2","line":3787,"range":{"start_line":3787,"start_character":48,"end_line":3787,"end_character":57},"updated":"2017-01-17 12:48:14.000000000","message":"It fails on \"DriverPrivateData\" table records which do not have \"id\" attr. See: https://github.com/openstack/manila/blob/6dad1666/manila/db/sqlalchemy/models.py#L880\n\nSo, we need either automatic detection of primary key name or avoid its usage because it is not fixed.","commit_id":"7a8fde34d90e57ece7d1400c4f5c1f4fd40797b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"138c5036e78f81a00045e0519fe5a36fe575bf9c","unresolved":false,"context_lines":[{"line_number":3786,"context_line":"                                             \"%(table)s %(id)s.\"),"},{"line_number":3787,"context_line":"                                         {\u0027id\u0027: record.id, \u0027table\u0027: table})"},{"line_number":3788,"context_line":"                        except db_exc.DBError:"},{"line_number":3789,"context_line":"                            LOG.warning("},{"line_number":3790,"context_line":"                                _LE(\"Deletion of soft-delete record failed, \""},{"line_number":3791,"context_line":"                                    \"skipping record %s.\"), record)"},{"line_number":3792,"context_line":"            except db_exc.DBError:"},{"line_number":3793,"context_line":"                LOG.exception(_LE(\"Deletion of soft-delete records failed, \""},{"line_number":3794,"context_line":"                                  \"skipping table %s.\"), table)"},{"line_number":3795,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_96e3b0a3","line":3794,"range":{"start_line":3789,"start_character":28,"end_line":3794,"end_character":63},"updated":"2017-01-17 12:48:14.000000000","message":"Would be really great to avoid this duplication.","commit_id":"7a8fde34d90e57ece7d1400c4f5c1f4fd40797b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"31620dcd3a64f7022f366b0126d704f9aa1336a2","unresolved":false,"context_lines":[{"line_number":3781,"context_line":"                    for record in s_deleted_records:"},{"line_number":3782,"context_line":"                        try:"},{"line_number":3783,"context_line":"                            with session.begin_nested():"},{"line_number":3784,"context_line":"                                session.delete(record)"},{"line_number":3785,"context_line":"                        except db_exc.DBError:"},{"line_number":3786,"context_line":"                            LOG.warning("},{"line_number":3787,"context_line":"                                _LW(\"Deleting soft-deleted resource %s \""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_585dee45","line":3784,"updated":"2017-01-17 15:23:21.000000000","message":"I would like to keep logging here, just not using primary keys. So, it would be really great to have amount of records that were deleted per each of DB table, so it could look like following in result:\n\n\"\"\"\nDeleted \u002710\u0027 records in \u0027share_instance_export_locations_metadata\u0027 table.\nDeleted \u002710\u0027 records in \u0027share_instance_export_locations\u0027 table.\nDeleted \u002720\u0027 records in \u0027share_metadata\u0027 table.\nDeleted \u00272\u0027 records in \u0027share_instances\u0027 table.\nDeleted \u00271\u0027 records in \u0027shares\u0027 table.\nDeleted \u00274\u0027 records in \u0027drivers_private_data\u0027 table.\n\"\"\"","commit_id":"76c0c665d756075dbff95173a715cce450c4062e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d110e1584490702b437aff4ed1894b9553de8685","unresolved":false,"context_lines":[{"line_number":3788,"context_line":"                            LOG.warning("},{"line_number":3789,"context_line":"                                _LW(\"Deleting soft-deleted resource %s \""},{"line_number":3790,"context_line":"                                    \"failed, skipping.\"), record)"},{"line_number":3791,"context_line":"                    LOG.info(_LI(\"Deleted %(count)s records in \""},{"line_number":3792,"context_line":"                                 \"table %(table)s.\"), {\u0027count\u0027: deleted_count,"},{"line_number":3793,"context_line":"                                                       \u0027table\u0027: table})"},{"line_number":3794,"context_line":"            except db_exc.DBError:"},{"line_number":3795,"context_line":"                LOG.warning(_LW(\"Querying table %s\u0027s soft-deleted records \""},{"line_number":3796,"context_line":"                                \"failed, skipping.\"), table)"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a3c09a3_d61b6a71","line":3793,"range":{"start_line":3791,"start_character":20,"end_line":3793,"end_character":71},"updated":"2017-01-17 16:16:14.000000000","message":"It will log not affected tables too. Better to log only if \"deleted_count \u003e 0\"","commit_id":"a334189ccc36f8633486167517ba3efa56a32da0"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    return share_access_status"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1032,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1033,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1034,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_706797ea","line":1031,"range":{"start_line":1027,"start_character":0,"end_line":1031,"end_character":36},"updated":"2016-11-21 18:03:35.000000000","message":"I am pretty sure that it is not necessary. There should be a way to build model dependency tree using sqlalchemy. Or, iterate tables recursively, deleting rows starting from last object in each dependency chain.","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    return share_access_status"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1032,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1033,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1034,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_9587b7d6","line":1031,"range":{"start_line":1027,"start_character":0,"end_line":1031,"end_character":36},"in_reply_to":"7a77a97e_706797ea","updated":"2016-11-22 01:36:36.000000000","message":"I do wish I can find a better and simple solution for this, could you help me with a useful link?","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                               share_type_id)),"},{"line_number":1080,"context_line":"                 (AvailabilityZone, (Service.availability_zone_id,"},{"line_number":1081,"context_line":"                                     ShareInstance.availability_zone_id)))"},{"line_number":1082,"context_line":"SORTED_MODELS \u003d collections.OrderedDict(SORTED_MODELS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_55ec4d8f","line":1082,"range":{"start_line":1082,"start_character":28,"end_line":1082,"end_character":39},"updated":"2016-11-21 18:03:35.000000000","message":"Why do you need \"OrderedDict\" here?","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                               share_type_id)),"},{"line_number":1080,"context_line":"                 (AvailabilityZone, (Service.availability_zone_id,"},{"line_number":1081,"context_line":"                                     ShareInstance.availability_zone_id)))"},{"line_number":1082,"context_line":"SORTED_MODELS \u003d collections.OrderedDict(SORTED_MODELS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_154647bf","line":1082,"range":{"start_line":1082,"start_character":28,"end_line":1082,"end_character":39},"in_reply_to":"7a77a97e_55ec4d8f","updated":"2016-11-22 01:36:36.000000000","message":"The dictionay keys here are required to be in order, and the basic dict can not guarantee the order sequence when used by \u0027dict.keys()\u0027","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"9be4f3179a225709243dd33e176a210b78f1e460","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1032,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1033,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1034,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_30a1d546","line":1031,"updated":"2016-11-29 10:02:13.000000000","message":"Can you give more information about the data structure in the comment.  So it list of models and how is the order kept? IMHO it\u0027s really hard to read.","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1032,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1033,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1034,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_041e576f","line":1031,"in_reply_to":"5a74a57a_30a1d546","updated":"2016-11-29 10:52:20.000000000","message":"+1 - i am assuming these models are included with Primary and Foreign Keys for each referenced table?","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"9be4f3179a225709243dd33e176a210b78f1e460","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1032,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1033,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1034,"context_line":"                 (Reservation, ()),"},{"line_number":1035,"context_line":"                 (QuotaUsage, (Reservation.usage_id, )),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_b3dfafd4","line":1032,"range":{"start_line":1032,"start_character":0,"end_line":1032,"end_character":13},"updated":"2016-11-29 10:02:13.000000000","message":"Furthermore, wouldn\u0027t it be possible to retrieve the list by inspecting the models and check for \"delete/delete_at\" fields? The order should be possible to retrieve by the orm.relationship? Maybe this is a bit overkill but this list will be hard to maintain..","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"22ac6f33564747964b4df91def7fd325d5be7f80","unresolved":false,"context_lines":[{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_36da9679","line":1028,"range":{"start_line":1028,"start_character":65,"end_line":1028,"end_character":72},"updated":"2016-12-12 15:27:49.000000000","message":"is updated","commit_id":"5c31bba904d50ec181745c4ed2855a94f0b3433b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"22ac6f33564747964b4df91def7fd325d5be7f80","unresolved":false,"context_lines":[{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1028,"context_line":"# constraint, so please update the list once data module\u0027s table updated"},{"line_number":1029,"context_line":"# exception models:"},{"line_number":1030,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1031,"context_line":"# \u0027ManilaNode\u0027 is not used currently"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_96cfeab2","line":1028,"range":{"start_line":1028,"start_character":40,"end_line":1028,"end_character":44},"updated":"2016-12-12 15:27:49.000000000","message":"whenever","commit_id":"5c31bba904d50ec181745c4ed2855a94f0b3433b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d20203bafd92699ed4c88461e2899986eecb6a6d","unresolved":false,"context_lines":[{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1029,"context_line":"# constraint, so please update the list whenever data module\u0027s table is"},{"line_number":1030,"context_line":"# updated exception models:"},{"line_number":1031,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1032,"context_line":"# \u0027ManilaNode\u0027 is not used currently"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_b1cf73b2","line":1029,"range":{"start_line":1029,"start_character":17,"end_line":1029,"end_character":39},"updated":"2017-01-12 11:49:51.000000000","message":"\"please update the list\" - consider it as already broken.","commit_id":"1365b6f3b991ad5c06135af3a2d5de730ef56370"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d20203bafd92699ed4c88461e2899986eecb6a6d","unresolved":false,"context_lines":[{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1029,"context_line":"# constraint, so please update the list whenever data module\u0027s table is"},{"line_number":1030,"context_line":"# updated exception models:"},{"line_number":1031,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1032,"context_line":"# \u0027ManilaNode\u0027 is not used currently"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_918d0f7e","line":1029,"range":{"start_line":1029,"start_character":54,"end_line":1029,"end_character":60},"updated":"2017-01-12 11:49:51.000000000","message":"module?","commit_id":"1365b6f3b991ad5c06135af3a2d5de730ef56370"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d13a0a67360330f86b4e0edd4dc80667525af428","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"    return share_access_status"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1029,"context_line":"# constraint, so please update the list whenever data model\u0027s table is"},{"line_number":1030,"context_line":"# updated, exception models:"},{"line_number":1031,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1032,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1033,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1034,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1035,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a3c09a3_c848ac30","line":1032,"range":{"start_line":1028,"start_character":0,"end_line":1032,"end_character":36},"updated":"2017-01-13 16:48:18.000000000","message":"Wait, why do you need list of foreign keys here? It should be enough just to iterate tables in proper order. First tables that are not referenced as foreign key holders, then tables that are referenced by already cleaned up tables and so on. So, it should be just list of tables.","commit_id":"3d1f75f5d4f4a412ad08a261790e2bf8c584da36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"81b6c033c3df95355505a7edd2f2764c42b4ccb1","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"    return share_access_status"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"# Note(tommylike): This list is kept in order to avoid foreign key"},{"line_number":1029,"context_line":"# constraint, so please update the list whenever data model\u0027s table is"},{"line_number":1030,"context_line":"# updated, exception models:"},{"line_number":1031,"context_line":"# \u0027ShareNetworkSecurityServiceAssociation\u0027 will be deleted automatically"},{"line_number":1032,"context_line":"# \u0027ManilaNode\u0027 is not used currently"},{"line_number":1033,"context_line":"SORTED_MODELS \u003d ((CGSnapshotMember, ()), (Service, ()), (Quota, ()),"},{"line_number":1034,"context_line":"                 (ProjectUserQuota, ()), (QuotaClass, ()),"},{"line_number":1035,"context_line":"                 (Reservation, ()),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a3c09a3_9eca5e4e","line":1032,"range":{"start_line":1028,"start_character":0,"end_line":1032,"end_character":36},"in_reply_to":"7a3c09a3_c848ac30","updated":"2017-01-13 17:35:38.000000000","message":"Also, list of foreign key relations can be found using following:\n\n\"\"\"\nmodels.ManilaNode.metadata._fk_memos\n\"\"\"\n\nIt will be the same for all model classes.\n\nIt will return something like following:\n\nmodels.ManilaNode.metadata._fk_memos \u003d\u003e defaultdict(\n\t\u003ctype \u0027list\u0027\u003e, \n\t{\n\t\t(\u0027share_networks\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_networks.id\u0027), ForeignKey(\u0027share_networks.id\u0027), ForeignKey(\u0027share_networks.id\u0027), ForeignKey(\u0027share_networks.id\u0027)\n\t\t],\n\t\t(\u0027services\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027services.id\u0027)\n\t\t],\n\t\t(\u0027share_types\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_types.id\u0027), ForeignKey(\u0027share_types.id\u0027), ForeignKey(\u0027share_types.id\u0027), ForeignKey(\u0027share_types.id\u0027), ForeignKey(\u0027share_types.id\u0027)\n\t\t],\n\t\t(\u0027share_snapshots\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_snapshots.id\u0027)\n\t\t],\n\t\t(\u0027share_access_map\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_access_map.id\u0027)\n\t\t],\n\t\t(\u0027share_group_snapshots\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_group_snapshots.id\u0027)\n\t\t],\n\t\t(\u0027share_instance_export_locations\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_instance_export_locations.id\u0027)\n\t\t],\n\t\t(\u0027availability_zones\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027availability_zones.id\u0027), ForeignKey(\u0027availability_zones.id\u0027)\n\t\t],\n\t\t(\u0027share_servers\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_servers.id\u0027),\tForeignKey(\u0027share_servers.id\u0027),\tForeignKey(\u0027share_servers.id\u0027),\tForeignKey(\u0027share_servers.id\u0027)\n\t\t],\n\t\t(\u0027security_services\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027security_services.id\u0027)\n\t\t],\n\t\t(\u0027quota_usages\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027quota_usages.id\u0027)\n\t\t],\n\t\t(\u0027share_groups\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_groups.id\u0027), ForeignKey(\u0027share_groups.id\u0027), ForeignKey(\u0027share_groups.id\u0027)\n\t\t],\n\t\t(\u0027share_group_types\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_group_types.id\u0027), ForeignKey(\u0027share_group_types.id\u0027), ForeignKey(\u0027share_group_types.id\u0027), ForeignKey(\u0027share_group_types.id\u0027)\n\t\t],\n\t\t(\u0027shares\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027shares.id\u0027), ForeignKey(\u0027shares.id\u0027), ForeignKey(\u0027shares.id\u0027), ForeignKey(\u0027shares.id\u0027)\n\t\t],\n\t\t(\u0027share_instances\u0027, \u0027id\u0027): [\n\t\t\tForeignKey(\u0027share_instances.id\u0027), ForeignKey(\u0027share_instances.id\u0027), ForeignKey(\u0027share_instances.id\u0027), ForeignKey(\u0027share_instances.id\u0027)\n\t\t]\n\t}\n)\n\nSo, you can use this for dynamic build of dependency tree.","commit_id":"3d1f75f5d4f4a412ad08a261790e2bf8c584da36"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0dfefb10774ff963cb1648519d993600de9ebe9","unresolved":false,"context_lines":[{"line_number":2222,"context_line":"            self.assertIn(na.label, (\u0027admin\u0027, \u0027user\u0027, None))"},{"line_number":2223,"context_line":""},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"@ddt.ddt"},{"line_number":2226,"context_line":"class PurgeDeletedTest(test.TestCase):"},{"line_number":2227,"context_line":""},{"line_number":2228,"context_line":"    def setUp(self):"},{"line_number":2229,"context_line":"        super(PurgeDeletedTest, self).setUp()"},{"line_number":2230,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"    @ddt.data({\"del_days\": 30, \"del_num\": 6},"},{"line_number":2233,"context_line":"              {\"del_days\": 20, \"del_num\": 4},"},{"line_number":2234,"context_line":"              {\"del_days\": 10, \"del_num\": 4})"},{"line_number":2235,"context_line":"    @ddt.unpack"},{"line_number":2236,"context_line":"    def test_purge_deleted_rows_old(self, del_days, del_num):"},{"line_number":2237,"context_line":"        old \u003d timeutils.utcnow() - datetime.timedelta(days\u003d20)"},{"line_number":2238,"context_line":"        for unused in range(4):"},{"line_number":2239,"context_line":"            db_utils.create_share(id\u003duuid.uuid4().hex)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"        # Set 2 of them deleted at 20 days ago"},{"line_number":2242,"context_line":"        for unused in range(2):"},{"line_number":2243,"context_line":"            db_utils.create_share(id\u003duuid.uuid4().hex, deleted_at\u003dold)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        # Purge at del_days old"},{"line_number":2246,"context_line":"        db_api.purge_deleted_rows(self.context, age_in_days\u003ddel_days)"},{"line_number":2247,"context_line":"        rows \u003d db_api.model_query(self.context, models.Share).count()"},{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"        self.assertEqual(del_num, rows)"},{"line_number":2250,"context_line":""},{"line_number":2251,"context_line":"    def test_purge_deleted_rows_bad_args(self):"},{"line_number":2252,"context_line":"        # Test with no age argument"},{"line_number":2253,"context_line":"        self.assertRaises(TypeError, db_api.purge_deleted_rows, self.context)"},{"line_number":2254,"context_line":"        # Test purge with non-integer"},{"line_number":2255,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":2256,"context_line":"                          db_api.purge_deleted_rows, self.context,"},{"line_number":2257,"context_line":"                          age_in_days\u003d\u0027ten\u0027)"},{"line_number":2258,"context_line":"        # Test with negative value"},{"line_number":2259,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":2260,"context_line":"                          db_api.purge_deleted_rows, self.context,"},{"line_number":2261,"context_line":"                          age_in_days\u003d-1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f442bb66","line":2261,"range":{"start_line":2225,"start_character":0,"end_line":2261,"end_character":41},"updated":"2016-04-21 11:36:18.000000000","message":"It is too small test coverage.\n\nFollowing scenarios should be covered:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFIRST (CGs)\n\n1) create \"security-service\"\n2) create \"share-network\"\n3) attach (1) to (2)\n4) create \"share-type\"\n5) create \"consistency-group\"\n6) create share using (2), (4) and (5)\n7) add access rules for share (6)\n8) create snapshot from share (7)\n9) create CG snapshot from CG with share (5,6)\n10) create CG from CG snapshot (9)\n\nThen delete all of these in reverse order.\nRepeat it twice.\nDelete entities from first two chains.\nCall \"purge\" with time only for first chain and check that first part of deleted rows is absent and second part of deleted rows still exist - new, that do not satisfy time criterion. + Not deleted exist\n\nNow delete last not deleted chain of resources.\nCall \"purge\".\nCheck that everything was removed.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nSECOND (replicas)\n\n1) create \"share-type\"\n2) create share using (1)\n3) add access rules for share (2)\n4) create share replica for share (2)\n5) create snapshot for share (2)\n\nadditional actions are the same as for previous scenario\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from sqlalchemy.sql import schema"},{"line_number":28,"context_line":"from sqlalchemy import Table"},{"line_number":29,"context_line":"import uuid"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from manila.common import constants"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_51f580ea","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":28},"updated":"2016-11-29 03:59:03.000000000","message":"should not import object, see http://docs.openstack.org/developer/hacking/#imports","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"        exclude_models \u003d (models.ManilaNode, )"},{"line_number":2187,"context_line":"        for model_class in models.__dict__.values():"},{"line_number":2188,"context_line":"            if(hasattr(model_class, \u0027__tablename__\u0027) and"},{"line_number":2189,"context_line":"               hasattr(model_class, \u0027deleted\u0027) and not exclude_models):"},{"line_number":2190,"context_line":"                self.assertIn(model_class,"},{"line_number":2191,"context_line":"                              models.SORTED_MODELS.keys())"},{"line_number":2192,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_588e862e","line":2189,"range":{"start_line":2189,"start_character":51,"end_line":2189,"end_character":69},"updated":"2016-11-29 03:59:03.000000000","message":"what\u0027s this about? According to the above code, this must be False.","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2202,"context_line":"                    index_length \u003d (sorted_tables.index(table)"},{"line_number":2203,"context_line":"                                    - sorted_tables.index(str(foreign_key."},{"line_number":2204,"context_line":"                                                          column.table)))"},{"line_number":2205,"context_line":"                    self.assertTrue(index_length \u003c 0, \u0027child model should \u0027"},{"line_number":2206,"context_line":"                                                      \u0027come before its parent\u0027)"},{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"    @ddt.data({\"del_days\": 30, \"left_num\": 6},"},{"line_number":2209,"context_line":"              {\"del_days\": 20, \"left_num\": 4},"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_b3d17d25","line":2206,"range":{"start_line":2205,"start_character":54,"end_line":2206,"end_character":78},"updated":"2016-11-29 03:59:03.000000000","message":"I think it\u0027d better prompt which table has what foreign key.","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"    @ddt.data({\"del_days\": 30, \"left_num\": 6},"},{"line_number":2209,"context_line":"              {\"del_days\": 20, \"left_num\": 4},"},{"line_number":2210,"context_line":"              {\"del_days\": 10, \"left_num\": 4})"},{"line_number":2211,"context_line":"    @ddt.unpack"},{"line_number":2212,"context_line":"    def test_purge_records_without_constraint(self, del_days, left_num):"},{"line_number":2213,"context_line":"        fake_now \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_d3cfd953","line":2210,"range":{"start_line":2210,"start_character":32,"end_line":2210,"end_character":40},"updated":"2016-11-29 03:59:03.000000000","message":"cover the situation that all soft-deleted rows will be purged.","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                               mock.Mock(return_value\u003dfake_now)):"},{"line_number":2216,"context_line":"            # 4 share instance 1 days ago"},{"line_number":2217,"context_line":"            for unused in range(4):"},{"line_number":2218,"context_line":"                db_utils.create_share_instance(id\u003duuid.uuid4().hex,"},{"line_number":2219,"context_line":"                                               share_id\u003duuid.uuid4().hex,"},{"line_number":2220,"context_line":"                                               deleted_at\u003dself._days_ago(1))"},{"line_number":2221,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_53958930","line":2218,"range":{"start_line":2218,"start_character":50,"end_line":2218,"end_character":66},"updated":"2016-11-29 03:59:03.000000000","message":"should use uuidutils.generate_uuid() instead.","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2216,"context_line":"            # 4 share instance 1 days ago"},{"line_number":2217,"context_line":"            for unused in range(4):"},{"line_number":2218,"context_line":"                db_utils.create_share_instance(id\u003duuid.uuid4().hex,"},{"line_number":2219,"context_line":"                                               share_id\u003duuid.uuid4().hex,"},{"line_number":2220,"context_line":"                                               deleted_at\u003dself._days_ago(1))"},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"            # 2 share instance \u0027del_days\u0027 ago"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_7398c56a","line":2219,"range":{"start_line":2219,"start_character":56,"end_line":2219,"end_character":72},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"            # 2 share instance \u0027del_days\u0027 ago"},{"line_number":2223,"context_line":"            for unused in range(2):"},{"line_number":2224,"context_line":"                db_utils.create_share_instance(id\u003duuid.uuid4().hex,"},{"line_number":2225,"context_line":"                                               share_id\u003duuid.uuid4().hex,"},{"line_number":2226,"context_line":"                                               deleted_at\u003dself._days_ago(20))"},{"line_number":2227,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_f3acd58d","line":2224,"range":{"start_line":2224,"start_character":50,"end_line":2224,"end_character":66},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2222,"context_line":"            # 2 share instance \u0027del_days\u0027 ago"},{"line_number":2223,"context_line":"            for unused in range(2):"},{"line_number":2224,"context_line":"                db_utils.create_share_instance(id\u003duuid.uuid4().hex,"},{"line_number":2225,"context_line":"                                               share_id\u003duuid.uuid4().hex,"},{"line_number":2226,"context_line":"                                               deleted_at\u003dself._days_ago(20))"},{"line_number":2227,"context_line":""},{"line_number":2228,"context_line":"            db_api.purge_deleted_records(self.context, age_in_days\u003ddel_days)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_13a87176","line":2225,"range":{"start_line":2225,"start_character":56,"end_line":2225,"end_character":72},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2232,"context_line":"            self.assertEqual(left_num, rows)"},{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"    def test_purge_records_with_single_constraint(self):"},{"line_number":2235,"context_line":"        type_id \u003d uuid.uuid4().hex"},{"line_number":2236,"context_line":"        # create share typ1"},{"line_number":2237,"context_line":"        db_utils.create_share_type(id\u003dtype_id,"},{"line_number":2238,"context_line":"                                   deleted_at\u003dself._days_ago(20))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_11a148f8","line":2235,"range":{"start_line":2235,"start_character":18,"end_line":2235,"end_character":34},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2260,"context_line":"        self.assertEqual(type_id, ret_type.id)"},{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"    def test_purge_records_with_multi_constraints(self):"},{"line_number":2263,"context_line":"        net_id1 \u003d uuid.uuid4().hex"},{"line_number":2264,"context_line":"        net_id2 \u003d uuid.uuid4().hex"},{"line_number":2265,"context_line":""},{"line_number":2266,"context_line":"        # create share network 1/2/3"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_d1b3504b","line":2263,"range":{"start_line":2263,"start_character":18,"end_line":2263,"end_character":34},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b19f80ae31c108dae92a512ed123d654f4eb15f4","unresolved":false,"context_lines":[{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"    def test_purge_records_with_multi_constraints(self):"},{"line_number":2263,"context_line":"        net_id1 \u003d uuid.uuid4().hex"},{"line_number":2264,"context_line":"        net_id2 \u003d uuid.uuid4().hex"},{"line_number":2265,"context_line":""},{"line_number":2266,"context_line":"        # create share network 1/2/3"},{"line_number":2267,"context_line":"        for inst_id in [net_id1, net_id2, uuid.uuid4().hex]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_f184cc5e","line":2264,"range":{"start_line":2264,"start_character":18,"end_line":2264,"end_character":34},"updated":"2016-11-29 03:59:03.000000000","message":"ditto","commit_id":"50ac32afcf07e3d49496c7e96bc764db6a46f6a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":2207,"context_line":"                                                      \u0027foreign key \"%s\"\u0027"},{"line_number":2208,"context_line":"                                    % (table, foreign_key.column))"},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"    @ddt.data({\"del_days\": 30, \"left_num\": 6},"},{"line_number":2211,"context_line":"              {\"del_days\": 20, \"left_num\": 4},"},{"line_number":2212,"context_line":"              {\"del_days\": 10, \"left_num\": 4},"},{"line_number":2213,"context_line":"              {\"del_days\": 1, \"left_num\": 0})"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_7f3876d3","line":2210,"range":{"start_line":2210,"start_character":32,"end_line":2210,"end_character":40},"updated":"2016-11-29 10:52:20.000000000","message":"num_left","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":2207,"context_line":"                                                      \u0027foreign key \"%s\"\u0027"},{"line_number":2208,"context_line":"                                    % (table, foreign_key.column))"},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"    @ddt.data({\"del_days\": 30, \"left_num\": 6},"},{"line_number":2211,"context_line":"              {\"del_days\": 20, \"left_num\": 4},"},{"line_number":2212,"context_line":"              {\"del_days\": 10, \"left_num\": 4},"},{"line_number":2213,"context_line":"              {\"del_days\": 1, \"left_num\": 0})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_16355bd9","line":2210,"range":{"start_line":2210,"start_character":32,"end_line":2210,"end_character":40},"in_reply_to":"5a74a57a_7f3876d3","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"              {\"del_days\": 10, \"left_num\": 4},"},{"line_number":2213,"context_line":"              {\"del_days\": 1, \"left_num\": 0})"},{"line_number":2214,"context_line":"    @ddt.unpack"},{"line_number":2215,"context_line":"    def test_purge_records_without_constraint(self, del_days, left_num):"},{"line_number":2216,"context_line":"        fake_now \u003d timeutils.utcnow()"},{"line_number":2217,"context_line":"        with mock.patch.object(timeutils, \u0027utcnow\u0027,"},{"line_number":2218,"context_line":"                               mock.Mock(return_value\u003dfake_now)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_ff52c611","line":2215,"range":{"start_line":2215,"start_character":62,"end_line":2215,"end_character":70},"updated":"2016-11-29 10:52:20.000000000","message":"num_left","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"              {\"del_days\": 10, \"left_num\": 4},"},{"line_number":2213,"context_line":"              {\"del_days\": 1, \"left_num\": 0})"},{"line_number":2214,"context_line":"    @ddt.unpack"},{"line_number":2215,"context_line":"    def test_purge_records_without_constraint(self, del_days, left_num):"},{"line_number":2216,"context_line":"        fake_now \u003d timeutils.utcnow()"},{"line_number":2217,"context_line":"        with mock.patch.object(timeutils, \u0027utcnow\u0027,"},{"line_number":2218,"context_line":"                               mock.Mock(return_value\u003dfake_now)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_363257f2","line":2215,"range":{"start_line":2215,"start_character":62,"end_line":2215,"end_character":70},"in_reply_to":"5a74a57a_ff52c611","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"87a4b87d460b377ceaaeadb7e25ec1bdfac196d5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from sqlalchemy.sql import schema"},{"line_number":28,"context_line":"import sqlalchemy"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from manila.common import constants"},{"line_number":31,"context_line":"from manila import context"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_b63c79e3","line":28,"updated":"2016-12-03 01:09:41.000000000","message":"pep8, imports not in alphabetical order","commit_id":"69c4843b895c7ad447e37a4a0cc6fd05ef38d97e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"87a4b87d460b377ceaaeadb7e25ec1bdfac196d5","unresolved":false,"context_lines":[{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"    def test_purge_records_with_single_constraint(self):"},{"line_number":2242,"context_line":"        type_id \u003d uuidutils.generate_uuid()"},{"line_number":2243,"context_line":"        # create share typ1"},{"line_number":2244,"context_line":"        db_utils.create_share_type(id\u003dtype_id,"},{"line_number":2245,"context_line":"                                   deleted_at\u003dself._days_ago(20))"},{"line_number":2246,"context_line":"        # create share type2"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_71d4ab1f","line":2243,"range":{"start_line":2243,"start_character":23,"end_line":2243,"end_character":26},"updated":"2016-12-03 01:09:41.000000000","message":"type","commit_id":"69c4843b895c7ad447e37a4a0cc6fd05ef38d97e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"22ac6f33564747964b4df91def7fd325d5be7f80","unresolved":false,"context_lines":[{"line_number":2261,"context_line":"                                      models.ShareTypes).first()"},{"line_number":2262,"context_line":""},{"line_number":2263,"context_line":"        # share type1 should not be deleted"},{"line_number":2264,"context_line":"        self.assertEqual(1, inst_row, \u0027records with children existed \u0027"},{"line_number":2265,"context_line":"                                      \u0027should not be deleted\u0027)"},{"line_number":2266,"context_line":"        self.assertEqual(1, type_row)"},{"line_number":2267,"context_line":"        self.assertEqual(type_id, ret_type.id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_b66226ac","line":2264,"range":{"start_line":2264,"start_character":61,"end_line":2264,"end_character":68},"updated":"2016-12-12 15:27:49.000000000","message":"exist, should not be deleted","commit_id":"5c31bba904d50ec181745c4ed2855a94f0b3433b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"22ac6f33564747964b4df91def7fd325d5be7f80","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"                                        models.ShareServer).count()"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # share network 1\u00262 should not be deleted"},{"line_number":2296,"context_line":"        self.assertEqual(2, net_row, \u0027records with children existed \u0027"},{"line_number":2297,"context_line":"                                     \u0027should not be deleted\u0027)"},{"line_number":2298,"context_line":"        self.assertEqual(1, inst_row)"},{"line_number":2299,"context_line":"        self.assertEqual(1, server_row)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_76696e8b","line":2296,"range":{"start_line":2296,"start_character":60,"end_line":2296,"end_character":67},"updated":"2016-12-12 15:27:49.000000000","message":"same as above","commit_id":"5c31bba904d50ec181745c4ed2855a94f0b3433b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d20203bafd92699ed4c88461e2899986eecb6a6d","unresolved":false,"context_lines":[{"line_number":2190,"context_line":"               model_class not in exclude_models):"},{"line_number":2191,"context_line":"                self.assertIn(model_class,"},{"line_number":2192,"context_line":"                              models.SORTED_MODELS.keys())"},{"line_number":2193,"context_line":""},{"line_number":2194,"context_line":"    def test_parent_and_children_model_sorted(self):"},{"line_number":2195,"context_line":"        sorted_tables \u003d [x.__tablename__ for x in models.SORTED_MODELS.keys()]"},{"line_number":2196,"context_line":"        engine \u003d db_api.get_engine()"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_f1565b05","line":2193,"updated":"2017-01-12 11:49:51.000000000","message":"security_services update check?\nsnapshots check?","commit_id":"1365b6f3b991ad5c06135af3a2d5de730ef56370"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d20203bafd92699ed4c88461e2899986eecb6a6d","unresolved":false,"context_lines":[{"line_number":2201,"context_line":"            for column in t.columns:"},{"line_number":2202,"context_line":"                for foreign_key in column.foreign_keys:"},{"line_number":2203,"context_line":"                    index_length \u003d (sorted_tables.index(table)"},{"line_number":2204,"context_line":"                                    - sorted_tables.index(str(foreign_key."},{"line_number":2205,"context_line":"                                                          column.table)))"},{"line_number":2206,"context_line":"                    self.assertTrue(index_length \u003c 0, \u0027child model %(child) \u0027"},{"line_number":2207,"context_line":"                                                      \u0027should come before its \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_b1fe9303","line":2204,"range":{"start_line":2204,"start_character":58,"end_line":2204,"end_character":61},"updated":"2017-01-12 11:49:51.000000000","message":"\"str\" should not be used. Use \"six.text_type\"","commit_id":"1365b6f3b991ad5c06135af3a2d5de730ef56370"}],"manila/tests/db_utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5c4ba9f759649f9b93657e6ffe95bd5696c6f76e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"def create_share_type(**kwargs):"},{"line_number":180,"context_line":"    \"\"\"Create a share type object\"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    type \u003d {"},{"line_number":183,"context_line":"        \u0027name\u0027: \u0027fake_type\u0027,"},{"line_number":184,"context_line":"        \u0027is_public\u0027: True"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_d0ba2b0a","line":182,"range":{"start_line":182,"start_character":4,"end_line":182,"end_character":8},"updated":"2016-11-21 18:03:35.000000000","message":"Do not redefine built-ins.","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb2610fc6928da3e395547a8fe52cd62a0e3c86","unresolved":false,"context_lines":[{"line_number":179,"context_line":"def create_share_type(**kwargs):"},{"line_number":180,"context_line":"    \"\"\"Create a share type object\"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    type \u003d {"},{"line_number":183,"context_line":"        \u0027name\u0027: \u0027fake_type\u0027,"},{"line_number":184,"context_line":"        \u0027is_public\u0027: True"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_95d5f7ba","line":182,"range":{"start_line":182,"start_character":4,"end_line":182,"end_character":8},"in_reply_to":"7a77a97e_d0ba2b0a","updated":"2016-11-22 01:36:36.000000000","message":"thanks done~","commit_id":"03b5d442c57c8df197ff3de1ec9803eb39cd92e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    share_type \u003d {"},{"line_number":183,"context_line":"        \u0027name\u0027: \u0027fake_type\u0027,"},{"line_number":184,"context_line":"        \u0027is_public\u0027: True"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    return _create_db_row(db.share_type_create, share_type, kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_5fb2da4c","line":184,"range":{"start_line":184,"start_character":21,"end_line":184,"end_character":25},"updated":"2016-11-29 10:52:20.000000000","message":"trailing comma","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3bfd8c2de245727c42b599a17d6e75b8b08a6607","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    share_type \u003d {"},{"line_number":183,"context_line":"        \u0027name\u0027: \u0027fake_type\u0027,"},{"line_number":184,"context_line":"        \u0027is_public\u0027: True"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    return _create_db_row(db.share_type_create, share_type, kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_36497760","line":184,"range":{"start_line":184,"start_character":21,"end_line":184,"end_character":25},"in_reply_to":"5a74a57a_5fb2da4c","updated":"2016-12-02 06:26:54.000000000","message":"Done","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"}],"releasenotes/notes/add-manage-db-purge-b32a24ee045d8d45.yaml":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"7594fc23fb2809966489df5405a5e0e254f000eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add manage db purge API for clean up rows that are already"},{"line_number":4,"context_line":"    marked as deleted."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a122d0e_0badb687","line":3,"updated":"2016-04-20 20:42:39.000000000","message":"It\u0027s not only API. You also add a CLI. Please mention that.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0dfefb10774ff963cb1648519d993600de9ebe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add manage db purge API for clean up rows that are already"},{"line_number":4,"context_line":"    marked as deleted."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a122d0e_146657ec","line":3,"in_reply_to":"1a122d0e_0badb687","updated":"2016-04-21 11:36:18.000000000","message":"Actually, \"API\" is widely used to call \"REST API\". And it is not changed here. It is local app CLI command.","commit_id":"d5e785c1923f61d19448261fb22fc50c08cefff2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e080ead2db5f633cf00f2abff6d132a952bd6787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add manila-manage db purge command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a74a57a_5f99fac2","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":38},"updated":"2016-11-29 10:52:20.000000000","message":"Add ``purge`` sub command to the ``manila-manage db`` command for administrators to be able to purge soft-deleted rows.","commit_id":"65fbf0649f5fc1a85d623f9bb4a239c507855762"}]}
