)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and shares logical volume attached to it. The volume gets created"},{"line_number":12,"context_line":"simultaneously to the container on a host in a volume group"},{"line_number":13,"context_line":"specified by the user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I711813a2022d765ab7a70ed670e34f68f9cf1399"},{"line_number":16,"context_line":"Implements: blueprint manila-container-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"9abb7d3a_e9e4660e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2016-05-29 04:24:46.000000000","message":"please add the DocImpact flag","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and shares logical volume attached to it. The volume gets created"},{"line_number":12,"context_line":"simultaneously to the container on a host in a volume group"},{"line_number":13,"context_line":"specified by the user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I711813a2022d765ab7a70ed670e34f68f9cf1399"},{"line_number":16,"context_line":"Implements: blueprint manila-container-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"7aa08908_74ab6076","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"9abb7d3a_e9e4660e","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":184,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":185,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":186,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d1"},{"line_number":187,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":188,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":189,"context_line":"    iniset $TEMPEST_CONFIG share run_migration_tests False"}],"source_content_type":"text/x-sh","patch_set":42,"id":"9abb7d3a_89bafadf","line":186,"range":{"start_line":186,"start_character":31,"end_line":186,"end_character":32},"updated":"2016-05-29 04:24:46.000000000","message":"any reason?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":184,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":185,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":186,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d1"},{"line_number":187,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":188,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":189,"context_line":"    iniset $TEMPEST_CONFIG share run_migration_tests False"}],"source_content_type":"text/x-sh","patch_set":42,"id":"7aa08908_74d9a022","line":186,"range":{"start_line":186,"start_character":31,"end_line":186,"end_character":32},"in_reply_to":"9abb7d3a_89bafadf","updated":"2016-06-15 09:15:27.000000000","message":"Concurrency was set to 1 for initial testing, should be safe to increase it now.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":209,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":210,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":211,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d1"},{"line_number":212,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":213,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":214,"context_line":"    iniset $TEMPEST_CONFIG share run_migration_tests False"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_920d74ea","line":211,"range":{"start_line":211,"start_character":31,"end_line":211,"end_character":32},"updated":"2016-07-27 11:29:39.000000000","message":"Why 1?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests False"},{"line_number":217,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":218,"context_line":"    iniset $TEMPEST_CONFIG share run_snapshot_tests False"},{"line_number":219,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027cifs\u0027"},{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":222,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027\u0027"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_52a3fcb1","line":219,"range":{"start_line":219,"start_character":61,"end_line":219,"end_character":67},"updated":"2016-07-27 11:29:39.000000000","message":"Driver should report it in uppercase in consistency with all other.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests False"},{"line_number":217,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":218,"context_line":"    iniset $TEMPEST_CONFIG share run_snapshot_tests False"},{"line_number":219,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027cifs\u0027"},{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":222,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027\u0027"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_c9e9fbe7","line":219,"range":{"start_line":219,"start_character":61,"end_line":219,"end_character":67},"in_reply_to":"dada55a8_52a3fcb1","updated":"2016-07-27 12:59:14.000000000","message":"Oh, here it is. Now it all makes sense all of a sudden. Thank you.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":222,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027\u0027"},{"line_number":223,"context_line":"fi"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Enable consistency group tests"},{"line_number":226,"context_line":"iniset $TEMPEST_CONFIG share run_consistency_group_tests $RUN_MANILA_CG_TESTS"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_f21310ff","line":223,"updated":"2016-07-27 11:29:39.000000000","message":"add following? - \n\n\"\"\"\nMANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\"\n\"\"\"","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":222,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027\u0027"},{"line_number":223,"context_line":"fi"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Enable consistency group tests"},{"line_number":226,"context_line":"iniset $TEMPEST_CONFIG share run_consistency_group_tests $RUN_MANILA_CG_TESTS"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_49a34bb2","line":223,"in_reply_to":"dada55a8_f21310ff","updated":"2016-07-27 12:59:14.000000000","message":"Sorry, I don\u0027t get it. Is it a request or something?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"}],"devstack/plugin.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"85e3d572ecdd1e2376ea2a0d00b4757eb2d46328","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        fi"},{"line_number":526,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d \"manila.share.drivers.container.ContainerShareDriver\" ]; then"},{"line_number":527,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":528,"context_line":"            SHARE_GROUP\u003d\"manila_container_volumes\""},{"line_number":529,"context_line":"            configure_backing_file"},{"line_number":530,"context_line":"        fi"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a122d0e_07391da4","line":528,"range":{"start_line":528,"start_character":25,"end_line":528,"end_character":49},"updated":"2016-04-29 13:05:50.000000000","message":"I guess it should be configurable.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        fi"},{"line_number":526,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d \"manila.share.drivers.container.ContainerShareDriver\" ]; then"},{"line_number":527,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":528,"context_line":"            SHARE_GROUP\u003d\"manila_container_volumes\""},{"line_number":529,"context_line":"            configure_backing_file"},{"line_number":530,"context_line":"        fi"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a122d0e_2e4bdb2c","line":528,"range":{"start_line":528,"start_character":25,"end_line":528,"end_character":49},"in_reply_to":"1a122d0e_07391da4","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"85e3d572ecdd1e2376ea2a0d00b4757eb2d46328","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    local image image_fname"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":718,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":719,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":720,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":721,"context_line":"            wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":722,"context_line":"            if [[ $? -ne 0 ]]; then"},{"line_number":723,"context_line":"                echo \"Not found: $image_url\""},{"line_number":724,"context_line":"                return"},{"line_number":725,"context_line":"            fi"},{"line_number":726,"context_line":"        fi"},{"line_number":727,"context_line":"        image\u003d\"$FILES/${image_fname}\""},{"line_number":728,"context_line":"    else"},{"line_number":729,"context_line":"        # File based URL (RFC 1738): ``file://host/path``"},{"line_number":730,"context_line":"        # Remote files are not considered here."},{"line_number":731,"context_line":"        # unix: ``file:///home/user/path/file``"},{"line_number":732,"context_line":"        # windows: ``file:///C:/Documents%20and%20Settings/user/path/file``"},{"line_number":733,"context_line":"        image\u003d$(echo $image_url | sed \"s/^file:\\/\\///g\")"},{"line_number":734,"context_line":"        if [[ ! -f $image || \"$(stat -c \"%s\" $image)\" \u003d\u003d \"0\" ]]; then"},{"line_number":735,"context_line":"            echo \"Not found: $image_url\""},{"line_number":736,"context_line":"            return"},{"line_number":737,"context_line":"        fi"},{"line_number":738,"context_line":"    fi"},{"line_number":739,"context_line":"}"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"function import_docker_service_image {"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a122d0e_475675ce","line":738,"range":{"start_line":718,"start_character":4,"end_line":738,"end_character":6},"updated":"2016-04-29 13:05:50.000000000","message":"Why devstack functions are not used for this purpose?","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    local image image_fname"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":718,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":719,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":720,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":721,"context_line":"            wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":722,"context_line":"            if [[ $? -ne 0 ]]; then"},{"line_number":723,"context_line":"                echo \"Not found: $image_url\""},{"line_number":724,"context_line":"                return"},{"line_number":725,"context_line":"            fi"},{"line_number":726,"context_line":"        fi"},{"line_number":727,"context_line":"        image\u003d\"$FILES/${image_fname}\""},{"line_number":728,"context_line":"    else"},{"line_number":729,"context_line":"        # File based URL (RFC 1738): ``file://host/path``"},{"line_number":730,"context_line":"        # Remote files are not considered here."},{"line_number":731,"context_line":"        # unix: ``file:///home/user/path/file``"},{"line_number":732,"context_line":"        # windows: ``file:///C:/Documents%20and%20Settings/user/path/file``"},{"line_number":733,"context_line":"        image\u003d$(echo $image_url | sed \"s/^file:\\/\\///g\")"},{"line_number":734,"context_line":"        if [[ ! -f $image || \"$(stat -c \"%s\" $image)\" \u003d\u003d \"0\" ]]; then"},{"line_number":735,"context_line":"            echo \"Not found: $image_url\""},{"line_number":736,"context_line":"            return"},{"line_number":737,"context_line":"        fi"},{"line_number":738,"context_line":"    fi"},{"line_number":739,"context_line":"}"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"function import_docker_service_image {"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a122d0e_4e1577e3","line":738,"range":{"start_line":718,"start_character":4,"end_line":738,"end_character":6},"in_reply_to":"1a122d0e_475675ce","updated":"2016-05-04 12:26:36.000000000","message":"Like which?","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":741,"context_line":"function install_docker {"},{"line_number":742,"context_line":"    sudo apt-get update"},{"line_number":743,"context_line":"    install_package apparmor"},{"line_number":744,"context_line":"    sleep 5"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"    sleep 5"},{"line_number":747,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_20ad1de9","line":744,"range":{"start_line":744,"start_character":4,"end_line":744,"end_character":11},"updated":"2016-05-12 03:30:05.000000000","message":"Why sleep here?","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":741,"context_line":"function install_docker {"},{"line_number":742,"context_line":"    sudo apt-get update"},{"line_number":743,"context_line":"    install_package apparmor"},{"line_number":744,"context_line":"    sleep 5"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"    sleep 5"},{"line_number":747,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_9dbfcba9","line":744,"range":{"start_line":744,"start_character":4,"end_line":744,"end_character":11},"in_reply_to":"dab17558_20ad1de9","updated":"2016-05-13 10:01:06.000000000","message":"Not really needed here, left from debugging. Will remove in the next patch set.","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":743,"context_line":"    install_package apparmor"},{"line_number":744,"context_line":"    sleep 5"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"    sleep 5"},{"line_number":747,"context_line":"}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"function download_image {"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_60b3a54d","line":746,"range":{"start_line":746,"start_character":4,"end_line":746,"end_character":11},"updated":"2016-05-12 03:30:05.000000000","message":"Why here too?","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":743,"context_line":"    install_package apparmor"},{"line_number":744,"context_line":"    sleep 5"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"    sleep 5"},{"line_number":747,"context_line":"}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"function download_image {"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_5df3a39f","line":746,"range":{"start_line":746,"start_character":4,"end_line":746,"end_character":11},"in_reply_to":"dab17558_60b3a54d","updated":"2016-05-13 10:01:06.000000000","message":"The same reason as at line 744.","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        fi"},{"line_number":801,"context_line":"    fi"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    if is_driver_enabled $MANILA_LXD_DRIVER; then"},{"line_number":804,"context_line":"        install_lxd"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"# Main dispatcher"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_2066bdec","line":805,"range":{"start_line":803,"start_character":4,"end_line":805,"end_character":6},"updated":"2016-05-12 03:30:05.000000000","message":"Obsolete","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        fi"},{"line_number":801,"context_line":"    fi"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    if is_driver_enabled $MANILA_LXD_DRIVER; then"},{"line_number":804,"context_line":"        install_lxd"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"# Main dispatcher"}],"source_content_type":"text/x-sh","patch_set":35,"id":"dab17558_dd2dd3fe","line":805,"range":{"start_line":803,"start_character":4,"end_line":805,"end_character":6},"in_reply_to":"dab17558_2066bdec","updated":"2016-05-13 10:01:06.000000000","message":"Done","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":740,"context_line":"}"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_fc283d35","line":743,"range":{"start_line":743,"start_character":4,"end_line":743,"end_character":23},"updated":"2016-05-20 22:32:46.000000000","message":"This will only work in Debian / ubuntu.\nAlso, install_package calls update_package_repo which already calls call apt-get update.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":740,"context_line":"}"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_4ef75d59","line":743,"range":{"start_line":743,"start_character":4,"end_line":743,"end_character":23},"in_reply_to":"bab6814e_fc283d35","updated":"2016-05-25 09:45:43.000000000","message":"I have not worked on support for other distros yet. Thank you for pointing out install_package behavior!","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"},{"line_number":747,"context_line":""}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_91dc6874","line":744,"range":{"start_line":744,"start_character":20,"end_line":744,"end_character":28},"updated":"2016-05-20 22:32:46.000000000","message":"Is apparmor required for the docker install?\nIf it is not strictly required i would prefer to not install apparmor.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"},{"line_number":747,"context_line":""}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_8e7b05f4","line":744,"range":{"start_line":744,"start_character":20,"end_line":744,"end_character":28},"in_reply_to":"bab6814e_91dc6874","updated":"2016-05-25 09:45:43.000000000","message":"At least for Ubuntu the answer seems to be yes.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"function download_image {"}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_5185e004","line":745,"range":{"start_line":745,"start_character":20,"end_line":745,"end_character":29},"updated":"2016-05-20 22:32:46.000000000","message":"This will only work in Debian / Ubuntu.\nIn Fedora \u0026 CentOS the package is just called \u0027docker\u0027, not \u0027docker.io\u0027.\n\nYou could have a look at lib/apache in devstack, which has the same problem (package is called \u0027apache2\u0027 in ubuntu, but \u0027httpd\u0027 in fedora).","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":742,"context_line":"function install_docker {"},{"line_number":743,"context_line":"    sudo apt-get update"},{"line_number":744,"context_line":"    install_package apparmor"},{"line_number":745,"context_line":"    install_package docker.io"},{"line_number":746,"context_line":"}"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"function download_image {"}],"source_content_type":"text/x-sh","patch_set":40,"id":"bab6814e_2e549952","line":745,"range":{"start_line":745,"start_character":20,"end_line":745,"end_character":29},"in_reply_to":"bab6814e_5185e004","updated":"2016-05-25 09:45:43.000000000","message":"Yes, this will definitely cause issues with distros other than Ubuntu. I have not worked on the support for other distros yet, it is still to be done.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"b22d1c320f3af16dfd67829dace2e554346b457d","unresolved":false,"context_lines":[{"line_number":778,"context_line":"    download_image $MANILA_DOCKER_IMAGE_URL"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    # Import image in Docker"},{"line_number":781,"context_line":"    gzip -d $FILES/`basename \"$MANILA_DOCKER_IMAGE_URL\"`"},{"line_number":782,"context_line":"    IMG_NAME\u003d`basename \"$MANILA_DOCKER_IMAGE_URL\"`"},{"line_number":783,"context_line":"    sudo docker load --input $FILES/${IMG_NAME%.*}"},{"line_number":784,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":50,"id":"1aa78d24_b9c6bb65","line":781,"updated":"2016-07-06 14:35:45.000000000","message":"This gzip call is problematic, because it removes the \u0027.gz\u0027 suffix from the image filename.\nTherefore, when you run stack.sh a second time download_image will not detect that the image was already downloaded (because it checks for the filename with the \u0027gz\u0027 suffix, which was cut off by the gzip call), and download it again. Then, gzip will try to decompress this new file, which causes a conflict with the existing file.","commit_id":"6fc25192b1ada2989df8b3436a1cb3a8ae50aeca"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7a0853ed031aee227e6f8169d4aed32e32ebaa72","unresolved":false,"context_lines":[{"line_number":778,"context_line":"    download_image $MANILA_DOCKER_IMAGE_URL"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    # Import image in Docker"},{"line_number":781,"context_line":"    gzip -d $FILES/`basename \"$MANILA_DOCKER_IMAGE_URL\"`"},{"line_number":782,"context_line":"    IMG_NAME\u003d`basename \"$MANILA_DOCKER_IMAGE_URL\"`"},{"line_number":783,"context_line":"    sudo docker load --input $FILES/${IMG_NAME%.*}"},{"line_number":784,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":50,"id":"1aa78d24_17d7ce4b","line":781,"in_reply_to":"1aa78d24_b9c6bb65","updated":"2016-07-06 17:22:49.000000000","message":"Yes, this could cause trouble, I\u0027ll add a check.","commit_id":"6fc25192b1ada2989df8b3436a1cb3a8ae50aeca"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"38330e9b7c8f144fba51ddcdcef6537ffda7c4ff","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        fi"},{"line_number":631,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d $MANILA_CONTAINER_DRIVER ]; then"},{"line_number":632,"context_line":"        echo \"The driver is OK\""},{"line_number":633,"context_line":"        MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":634,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":635,"context_line":"            echo \"m-shr service is enabled\""},{"line_number":636,"context_line":"            if is_ubuntu; then"}],"source_content_type":"text/x-sh","patch_set":52,"id":"1aa78d24_f3a04df6","line":633,"range":{"start_line":633,"start_character":7,"end_line":633,"end_character":41},"updated":"2016-07-12 15:55:10.000000000","message":"Remove this","commit_id":"11bbd3b73a83aacfc988aa0205e130f11f16f7a1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"cd37196bc476410b5def622f37d70d67b834ef3d","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        fi"},{"line_number":631,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d $MANILA_CONTAINER_DRIVER ]; then"},{"line_number":632,"context_line":"        echo \"The driver is OK\""},{"line_number":633,"context_line":"        MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":634,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":635,"context_line":"            echo \"m-shr service is enabled\""},{"line_number":636,"context_line":"            if is_ubuntu; then"}],"source_content_type":"text/x-sh","patch_set":52,"id":"1aa78d24_33a13547","line":633,"range":{"start_line":633,"start_character":7,"end_line":633,"end_character":41},"in_reply_to":"1aa78d24_f3a04df6","updated":"2016-07-12 16:04:31.000000000","message":"Done","commit_id":"11bbd3b73a83aacfc988aa0205e130f11f16f7a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    fi"},{"line_number":271,"context_line":"}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"function is_driver_enabled {"},{"line_number":274,"context_line":"    driver_name\u003d$1"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    for BE in ${MANILA_ENABLED_BACKENDS//,/ }; do"},{"line_number":277,"context_line":"        share_driver\u003d$(iniget $MANILA_CONF $BE share_driver)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if [ \"$share_driver\" \u003d\u003d \"$driver_name\" ]; then"},{"line_number":280,"context_line":"            return 0"},{"line_number":281,"context_line":"        fi"},{"line_number":282,"context_line":"    done"},{"line_number":283,"context_line":"    return 1"},{"line_number":284,"context_line":"}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# create_service_share_servers - creates service Nova VMs, one per generic"},{"line_number":287,"context_line":"# driver, and only if it is configured to mode without handling of share servers."}],"source_content_type":"text/x-sh","patch_set":57,"id":"1aa78d24_5b770f02","line":284,"range":{"start_line":273,"start_character":0,"end_line":284,"end_character":1},"updated":"2016-07-15 12:39:22.000000000","message":"this","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    fi"},{"line_number":271,"context_line":"}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"function is_driver_enabled {"},{"line_number":274,"context_line":"    driver_name\u003d$1"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    for BE in ${MANILA_ENABLED_BACKENDS//,/ }; do"},{"line_number":277,"context_line":"        share_driver\u003d$(iniget $MANILA_CONF $BE share_driver)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if [ \"$share_driver\" \u003d\u003d \"$driver_name\" ]; then"},{"line_number":280,"context_line":"            return 0"},{"line_number":281,"context_line":"        fi"},{"line_number":282,"context_line":"    done"},{"line_number":283,"context_line":"    return 1"},{"line_number":284,"context_line":"}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# create_service_share_servers - creates service Nova VMs, one per generic"},{"line_number":287,"context_line":"# driver, and only if it is configured to mode without handling of share servers."}],"source_content_type":"text/x-sh","patch_set":57,"id":"dada55a8_13ee4b22","line":284,"range":{"start_line":273,"start_character":0,"end_line":284,"end_character":1},"in_reply_to":"1aa78d24_5b770f02","updated":"2016-07-18 17:49:34.000000000","message":"Ok, I think we can survive without this one.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    local type_exists\u003d$( manila type-list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":457,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":458,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":459,"context_line":"        if is_driver_enabled $MANILA_CONTAINER_DRIVER; then"},{"line_number":460,"context_line":"            # TODO(aovchinnikov): Remove this condition when Container driver supports"},{"line_number":461,"context_line":"            # snapshots"},{"line_number":462,"context_line":"            command_args\u003d\"$command_args --snapshot_support false\""},{"line_number":463,"context_line":"        fi"},{"line_number":464,"context_line":"        manila type-create $command_args"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":"    if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":467,"context_line":"        manila type-key $MANILA_DEFAULT_SHARE_TYPE set $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS"}],"source_content_type":"text/x-sh","patch_set":57,"id":"1aa78d24_bbd393d4","line":464,"range":{"start_line":458,"start_character":8,"end_line":464,"end_character":40},"updated":"2016-07-15 12:39:22.000000000","message":"and this are redundant. Just set some value to \"MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\" env var, that is used below. And it should be set in pre_test_hook.sh","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    local type_exists\u003d$( manila type-list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":457,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":458,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":459,"context_line":"        if is_driver_enabled $MANILA_CONTAINER_DRIVER; then"},{"line_number":460,"context_line":"            # TODO(aovchinnikov): Remove this condition when Container driver supports"},{"line_number":461,"context_line":"            # snapshots"},{"line_number":462,"context_line":"            command_args\u003d\"$command_args --snapshot_support false\""},{"line_number":463,"context_line":"        fi"},{"line_number":464,"context_line":"        manila type-create $command_args"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":"    if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":467,"context_line":"        manila type-key $MANILA_DEFAULT_SHARE_TYPE set $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS"}],"source_content_type":"text/x-sh","patch_set":57,"id":"dada55a8_58174051","line":464,"range":{"start_line":458,"start_character":8,"end_line":464,"end_character":40},"in_reply_to":"1aa78d24_bbd393d4","updated":"2016-07-18 17:49:34.000000000","message":"This code block is not redundant since it is creating a share type.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            fi"},{"line_number":624,"context_line":"        fi"},{"line_number":625,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d $MANILA_CONTAINER_DRIVER ]; then"},{"line_number":626,"context_line":"        echo \"The driver is OK\""},{"line_number":627,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":628,"context_line":"            echo \"m-shr service is enabled\""},{"line_number":629,"context_line":"            if is_ubuntu; then"}],"source_content_type":"text/x-sh","patch_set":57,"id":"1aa78d24_9b497791","line":626,"range":{"start_line":626,"start_character":14,"end_line":626,"end_character":30},"updated":"2016-07-15 12:39:22.000000000","message":"The driver? Need to specify which one.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            fi"},{"line_number":624,"context_line":"        fi"},{"line_number":625,"context_line":"    elif [ \"$SHARE_DRIVER\" \u003d\u003d $MANILA_CONTAINER_DRIVER ]; then"},{"line_number":626,"context_line":"        echo \"The driver is OK\""},{"line_number":627,"context_line":"        if is_service_enabled m-shr; then"},{"line_number":628,"context_line":"            echo \"m-shr service is enabled\""},{"line_number":629,"context_line":"            if is_ubuntu; then"}],"source_content_type":"text/x-sh","patch_set":57,"id":"dada55a8_1852e813","line":626,"range":{"start_line":626,"start_character":14,"end_line":626,"end_character":30},"in_reply_to":"1aa78d24_9b497791","updated":"2016-07-18 17:49:34.000000000","message":"This one is not cleaned up after initial debugging and is not really needed.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                echo \"Importing docker image\""},{"line_number":633,"context_line":"                import_docker_service_image"},{"line_number":634,"context_line":"            else"},{"line_number":635,"context_line":"                echo \"Manila Devstack plugin does not support Container Driver on  \"\\"},{"line_number":636,"context_line":"                     \" distros other than Ubuntu.\""},{"line_number":637,"context_line":"                exit 1"},{"line_number":638,"context_line":"            fi"},{"line_number":639,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":57,"id":"1aa78d24_bb14334d","line":636,"range":{"start_line":635,"start_character":16,"end_line":636,"end_character":50},"updated":"2016-07-15 12:39:22.000000000","message":"Then it is better to rename existing functions to something that mentions distro.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                echo \"Importing docker image\""},{"line_number":633,"context_line":"                import_docker_service_image"},{"line_number":634,"context_line":"            else"},{"line_number":635,"context_line":"                echo \"Manila Devstack plugin does not support Container Driver on  \"\\"},{"line_number":636,"context_line":"                     \" distros other than Ubuntu.\""},{"line_number":637,"context_line":"                exit 1"},{"line_number":638,"context_line":"            fi"},{"line_number":639,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":57,"id":"dada55a8_389b6ccb","line":636,"range":{"start_line":635,"start_character":16,"end_line":636,"end_character":50},"in_reply_to":"1aa78d24_bb14334d","updated":"2016-07-18 17:49:34.000000000","message":"Done","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    local type_exists\u003d$( manila type-list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":457,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":458,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":459,"context_line":"        if is_driver_enabled $MANILA_CONTAINER_DRIVER; then"},{"line_number":460,"context_line":"            # TODO(aovchinnikov): Remove this condition when Container driver supports"},{"line_number":461,"context_line":"            # snapshots"},{"line_number":462,"context_line":"            command_args\u003d\"$command_args --snapshot_support false\""},{"line_number":463,"context_line":"        fi"},{"line_number":464,"context_line":"        manila type-create $command_args"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":"    if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":467,"context_line":"        manila type-key $MANILA_DEFAULT_SHARE_TYPE set $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_d2288ce4","line":464,"range":{"start_line":458,"start_character":7,"end_line":464,"end_character":40},"updated":"2016-07-27 11:29:39.000000000","message":"As was mentioned in PS59 [1], this change is redundant. You should have set env var called \"MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\". See lines 466-468. They do what you need.\n\n[1] https://review.openstack.org/#/c/308930/57..67/devstack/plugin.sh","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    local type_exists\u003d$( manila type-list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":457,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":458,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":459,"context_line":"        if is_driver_enabled $MANILA_CONTAINER_DRIVER; then"},{"line_number":460,"context_line":"            # TODO(aovchinnikov): Remove this condition when Container driver supports"},{"line_number":461,"context_line":"            # snapshots"},{"line_number":462,"context_line":"            command_args\u003d\"$command_args --snapshot_support false\""},{"line_number":463,"context_line":"        fi"},{"line_number":464,"context_line":"        manila type-create $command_args"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":"    if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":467,"context_line":"        manila type-key $MANILA_DEFAULT_SHARE_TYPE set $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS"}],"source_content_type":"text/x-sh","patch_set":67,"id":"dada55a8_e9b2ff47","line":464,"range":{"start_line":458,"start_character":7,"end_line":464,"end_character":40},"in_reply_to":"dada55a8_d2288ce4","updated":"2016-07-27 12:59:14.000000000","message":"No, they don\u0027t. Please refer to gate results in PS60, PS61 and PS62.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"}],"devstack/settings":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"85e3d572ecdd1e2376ea2a0d00b4757eb2d46328","unresolved":false,"context_lines":[{"line_number":159,"context_line":"MANILA_ZFSONLINUX_REPLICATION_DOMAIN\u003d${MANILA_ZFSONLINUX_REPLICATION_DOMAIN:-\"ZFSonLinux\"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# Container Driver"},{"line_number":162,"context_line":"MANILA_CONTAINER_DRIVER\u003d${MANILA_CONTAINER_DRIVER:-\"manila.share.drivers.container.ContainerShareDriver\"}"},{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":165,"context_line":"# permanent one as soon as possible."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1a122d0e_07d2bd5b","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":105},"updated":"2016-04-29 13:05:50.000000000","message":"It is duplication of existing env var \"SHARE_DRIVER\".","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"MANILA_ZFSONLINUX_REPLICATION_DOMAIN\u003d${MANILA_ZFSONLINUX_REPLICATION_DOMAIN:-\"ZFSonLinux\"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# Container Driver"},{"line_number":162,"context_line":"MANILA_CONTAINER_DRIVER\u003d${MANILA_CONTAINER_DRIVER:-\"manila.share.drivers.container.ContainerShareDriver\"}"},{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":165,"context_line":"# permanent one as soon as possible."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1a122d0e_eedc4348","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":105},"in_reply_to":"1a122d0e_07d2bd5b","updated":"2016-05-04 12:26:36.000000000","message":"It is used to enable actions when SHARE_DRIVER is set to the same value.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cc069205325772b4ab576180f6ac4cd4ec264ca","unresolved":false,"context_lines":[{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"MANILA_CONTAINER_VOLUME_GROUP_NAME\u003d${MANILA_CONTAINER_VOLUME_GROUP_NAME:-\"manila_docker_volumes\"}"},{"line_number":165,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":166,"context_line":"# permanent one as soon as possible."},{"line_number":167,"context_line":"MANILA_DOCKER_IMAGE_URL\u003d${MANILA_DOCKER_IMAGE_URL:-\"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz\"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# Enable manila services"}],"source_content_type":"application/octet-stream","patch_set":57,"id":"1aa78d24_9e7a17ef","line":166,"range":{"start_line":166,"start_character":35,"end_line":166,"end_character":36},"updated":"2016-07-15 05:03:41.000000000","message":"when?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"25221cf6c33cc8d1be60b708012f0721b290ebc0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"MANILA_CONTAINER_VOLUME_GROUP_NAME\u003d${MANILA_CONTAINER_VOLUME_GROUP_NAME:-\"manila_docker_volumes\"}"},{"line_number":165,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":166,"context_line":"# permanent one as soon as possible."},{"line_number":167,"context_line":"MANILA_DOCKER_IMAGE_URL\u003d${MANILA_DOCKER_IMAGE_URL:-\"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz\"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# Enable manila services"}],"source_content_type":"application/octet-stream","patch_set":57,"id":"1aa78d24_017087a3","line":166,"range":{"start_line":166,"start_character":35,"end_line":166,"end_character":36},"in_reply_to":"1aa78d24_9e7a17ef","updated":"2016-07-15 08:28:24.000000000","message":"The new location is on its way! And it will be amazing! It is not here yet, but will be soon! :)","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"MANILA_CONTAINER_VOLUME_GROUP_NAME\u003d${MANILA_CONTAINER_VOLUME_GROUP_NAME:-\"manila_docker_volumes\"}"},{"line_number":165,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":166,"context_line":"# permanent one as soon as possible."},{"line_number":167,"context_line":"MANILA_DOCKER_IMAGE_URL\u003d${MANILA_DOCKER_IMAGE_URL:-\"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz\"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# Enable manila services"}],"source_content_type":"application/octet-stream","patch_set":67,"id":"dada55a8_b2a07891","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":35},"updated":"2016-07-27 11:29:39.000000000","message":"\"as soon as possible\"? It is unclear statement. What exactly stops us from doing it right now?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"MANILA_DOCKER_IMAGE_ALIAS\u003d${MANILA_DOCKER_IMAGE_ALIAS:-\"manila_docker_image\"}"},{"line_number":164,"context_line":"MANILA_CONTAINER_VOLUME_GROUP_NAME\u003d${MANILA_CONTAINER_VOLUME_GROUP_NAME:-\"manila_docker_volumes\"}"},{"line_number":165,"context_line":"# (aovchinnikov): This location is temporary and will be changed to a"},{"line_number":166,"context_line":"# permanent one as soon as possible."},{"line_number":167,"context_line":"MANILA_DOCKER_IMAGE_URL\u003d${MANILA_DOCKER_IMAGE_URL:-\"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz\"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# Enable manila services"}],"source_content_type":"application/octet-stream","patch_set":67,"id":"dada55a8_891ee35c","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":35},"in_reply_to":"dada55a8_b2a07891","updated":"2016-07-27 12:59:14.000000000","message":"Lack of proper publisher? Unwillingness to first rush-publish things then rush-unpublish things?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"}],"doc/source/devref/container_driver.rst":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Container Driver"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Container driver provides a lightweight solution for share servers"}],"source_content_type":"text/x-rst","patch_set":40,"id":"bab6814e_34976aed","line":17,"updated":"2016-05-20 22:32:46.000000000","message":"The whole document lacks some formatting.\nIt would be good to use some code-blocks for better readability.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Container Driver"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Container driver provides a lightweight solution for share servers"}],"source_content_type":"text/x-rst","patch_set":40,"id":"bab6814e_4e8e3dd1","line":17,"in_reply_to":"bab6814e_34976aed","updated":"2016-05-25 09:45:43.000000000","message":"Agreed, will do something about it in the next patch set.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Container driver provides a lightweight solution for share servers"},{"line_number":21,"context_line":"management. It allows to use Docker containers for hosting userspace"},{"line_number":22,"context_line":"shared filesystems services."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Supported operations and limitations"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_a9b9beeb","line":22,"range":{"start_line":22,"start_character":7,"end_line":22,"end_character":18},"updated":"2016-05-29 04:24:46.000000000","message":"file system","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Container driver provides a lightweight solution for share servers"},{"line_number":21,"context_line":"management. It allows to use Docker containers for hosting userspace"},{"line_number":22,"context_line":"shared filesystems services."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Supported operations and limitations"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_f4fbd079","line":22,"range":{"start_line":22,"start_character":7,"end_line":22,"end_character":18},"in_reply_to":"9abb7d3a_a9b9beeb","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Setting Container Driver Up via devstack"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The driver could be set up via devstack. This requires the following update to"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_c9ab6288","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":7},"updated":"2016-05-29 04:24:46.000000000","message":"nit: Setting up container driver with devstack","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Setting Container Driver Up via devstack"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The driver could be set up via devstack. This requires the following update to"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_74f08092","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":7},"in_reply_to":"9abb7d3a_c9ab6288","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The driver could be set up via devstack. This requires the following update to"},{"line_number":37,"context_line":"local.conf:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"enable_plugin manila https://git.openstack.org/openstack/manila \u003cref\u003e"},{"line_number":40,"context_line":"MANILA_BACKEND1_CONFIG_GROUP_NAME\u003dlondon"},{"line_number":41,"context_line":"MANILA_SHARE_BACKEND1_NAME\u003dLONDON"},{"line_number":42,"context_line":"MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":43,"context_line":"MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":44,"context_line":"SHARE_DRIVER\u003dmanila.share.drivers.container.container.ContainerShareDriver"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":47,"context_line":"\u003chostname\u003e is the name of the host with running neutron"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_29c66e67","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":74},"updated":"2016-05-29 04:24:46.000000000","message":".. code-block:: ini","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The driver could be set up via devstack. This requires the following update to"},{"line_number":37,"context_line":"local.conf:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"enable_plugin manila https://git.openstack.org/openstack/manila \u003cref\u003e"},{"line_number":40,"context_line":"MANILA_BACKEND1_CONFIG_GROUP_NAME\u003dlondon"},{"line_number":41,"context_line":"MANILA_SHARE_BACKEND1_NAME\u003dLONDON"},{"line_number":42,"context_line":"MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":43,"context_line":"MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":44,"context_line":"SHARE_DRIVER\u003dmanila.share.drivers.container.container.ContainerShareDriver"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":47,"context_line":"\u003chostname\u003e is the name of the host with running neutron"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_143adc34","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":74},"in_reply_to":"9abb7d3a_29c66e67","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This section describes steps needed to be performed to set the driver up"},{"line_number":55,"context_line":"manually. The driver has been tested on Ubuntu 14.04, thus in case of"},{"line_number":56,"context_line":"any other distribution package names might differ."},{"line_number":57,"context_line":"The following packages must be istalled:"},{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_e992a656","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":39},"updated":"2016-05-29 04:24:46.000000000","message":"installed","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This section describes steps needed to be performed to set the driver up"},{"line_number":55,"context_line":"manually. The driver has been tested on Ubuntu 14.04, thus in case of"},{"line_number":56,"context_line":"any other distribution package names might differ."},{"line_number":57,"context_line":"The following packages must be istalled:"},{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_541bc4ca","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":39},"in_reply_to":"9abb7d3a_e992a656","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":56,"context_line":"any other distribution package names might differ."},{"line_number":57,"context_line":"The following packages must be istalled:"},{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_299dce65","line":59,"range":{"start_line":59,"start_character":54,"end_line":59,"end_character":72},"updated":"2016-05-29 04:24:46.000000000","message":"``sudo docker info``","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"any other distribution package names might differ."},{"line_number":57,"context_line":"The following packages must be istalled:"},{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_346b9821","line":59,"range":{"start_line":59,"start_character":54,"end_line":59,"end_character":72},"in_reply_to":"9abb7d3a_299dce65","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_89883a24","line":61,"range":{"start_line":61,"start_character":67,"end_line":61,"end_character":75},"updated":"2016-05-29 04:24:46.000000000","message":"``apparmor``","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":58,"context_line":" - docker.io"},{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_5472a412","line":61,"range":{"start_line":61,"start_character":67,"end_line":61,"end_character":75},"in_reply_to":"9abb7d3a_89883a24","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":65,"context_line":"packages must be provided. Curently such image could be downloaded from"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_698d1631","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":17},"updated":"2016-05-29 04:24:46.000000000","message":"comma is not necessary..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"One can verify if the package is installed by issuing \u0027sudo docker info\u0027"},{"line_number":60,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":61,"context_line":"In case it fails complaining on inaccessible socket try installing apparmor."},{"line_number":62,"context_line":"Please note, that docker usage requires superuser privileges."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":65,"context_line":"packages must be provided. Curently such image could be downloaded from"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_f4575058","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":17},"in_reply_to":"9abb7d3a_698d1631","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":65,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":66,"context_line":"``https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz``."},{"line_number":67,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":68,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":69,"context_line":"image could be uploaded to docker via"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_c9824200","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":125},"updated":"2016-05-29 04:24:46.000000000","message":"http://docs.openstack.org/contributor-guide/rst-conv/refs.html\n\n\nwhen you use a permanent link.. :)","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":65,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":66,"context_line":"``https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz``."},{"line_number":67,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":68,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":69,"context_line":"image could be uploaded to docker via"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_14fdbc3b","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":125},"in_reply_to":"9abb7d3a_c9824200","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":67,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":68,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":69,"context_line":"image could be uploaded to docker via"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" sudo docker load --input \u003cimagename.tar\u003e"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"If the previous command finished successfully you will be able to see the image"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_09960a4c","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":0},"updated":"2016-05-29 04:24:46.000000000","message":".. code-block:: console","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":68,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":69,"context_line":"image could be uploaded to docker via"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" sudo docker load --input \u003cimagename.tar\u003e"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"If the previous command finished successfully you will be able to see the image"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_b492e8fa","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":0},"in_reply_to":"9abb7d3a_09960a4c","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"If the previous command finished successfully you will be able to see the image"},{"line_number":74,"context_line":"in the image list:"},{"line_number":75,"context_line":" sudo docker images"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The driver expects to find a folder /tmp/shares on the host where it is running"},{"line_number":78,"context_line":"as well as a logical volume group \"manila_docker_volumes\"."}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_09a44aa4","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":19},"updated":"2016-05-29 04:24:46.000000000","message":"same","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"If the previous command finished successfully you will be able to see the image"},{"line_number":74,"context_line":"in the image list:"},{"line_number":75,"context_line":" sudo docker images"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The driver expects to find a folder /tmp/shares on the host where it is running"},{"line_number":78,"context_line":"as well as a logical volume group \"manila_docker_volumes\"."}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_34aef82f","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":19},"in_reply_to":"9abb7d3a_09a44aa4","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Finally to use the driver one must add a backend to the config file"},{"line_number":85,"context_line":"containing the following  settings:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":" driver_handles_share_servers \u003d True"},{"line_number":88,"context_line":" share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":89,"context_line":" neutron_host_id \u003d \u003chostname\u003e"}],"source_content_type":"text/x-rst","patch_set":42,"id":"9abb7d3a_e9a0e692","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":0},"updated":"2016-05-29 04:24:46.000000000","message":".. code-block:: ini","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Finally to use the driver one must add a backend to the config file"},{"line_number":85,"context_line":"containing the following  settings:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":" driver_handles_share_servers \u003d True"},{"line_number":88,"context_line":" share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":89,"context_line":" neutron_host_id \u003d \u003chostname\u003e"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7aa08908_548e24d1","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":0},"in_reply_to":"9abb7d3a_e9a0e692","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cc069205325772b4ab576180f6ac4cd4ec264ca","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":67,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":68,"context_line":"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz."},{"line_number":69,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":70,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":71,"context_line":"image could be uploaded to docker via"}],"source_content_type":"text/x-rst","patch_set":57,"id":"1aa78d24_fe0a3b78","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":121},"updated":"2016-07-15 05:03:41.000000000","message":"Should we upload to manila-image-elements project?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"25221cf6c33cc8d1be60b708012f0721b290ebc0","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":67,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":68,"context_line":"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz."},{"line_number":69,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":70,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"},{"line_number":71,"context_line":"image could be uploaded to docker via"}],"source_content_type":"text/x-rst","patch_set":57,"id":"1aa78d24_41e1effb","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":121},"in_reply_to":"1aa78d24_fe0a3b78","updated":"2016-07-15 08:28:24.000000000","message":"manila-image-elements hosts code needed to build an image, but not actual images. The code for bulding docker container is already there. Images should go to tarballs.openstack.org. In an ideal world we should have a gate job in manila-image-elements that publishes container images once they get built. We don\u0027t have this job yet, and I don\u0027t want to have it until we are sure everything is OK with the driver and the image because the last time we rushed a publishing job for a container image I ended up pulling it out.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- Create CIFS share;"},{"line_number":29,"context_line":"- Delete CIFS share;"},{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Setting up container driver with devstack"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_effa2742","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":33},"updated":"2016-08-01 07:00:42.000000000","message":"Extend share?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- Create CIFS share;"},{"line_number":29,"context_line":"- Delete CIFS share;"},{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Setting up container driver with devstack"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_c8b8c02c","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":33},"in_reply_to":"bacf61ea_effa2742","updated":"2016-08-02 08:04:37.000000000","message":"Definitely.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efa6689ede498f318b26d5d184f60b197fd85f74","unresolved":false,"context_lines":[{"line_number":43,"context_line":" MANILA_SHARE_BACKEND1_NAME\u003dLONDON"},{"line_number":44,"context_line":" MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":45,"context_line":" MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":46,"context_line":" SHARE_DRIVER\u003dmanila.share.drivers.container.container.ContainerShareDriver"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":49,"context_line":"\u003chostname\u003e is the name of the host with running neutron"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_26d58c1b","line":46,"range":{"start_line":46,"start_character":45,"end_line":46,"end_character":54},"updated":"2016-08-01 02:58:29.000000000","message":"driver","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":43,"context_line":" MANILA_SHARE_BACKEND1_NAME\u003dLONDON"},{"line_number":44,"context_line":" MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":45,"context_line":" MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":46,"context_line":" SHARE_DRIVER\u003dmanila.share.drivers.container.container.ContainerShareDriver"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":49,"context_line":"\u003chostname\u003e is the name of the host with running neutron"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_086138a9","line":46,"range":{"start_line":46,"start_character":45,"end_line":46,"end_character":54},"in_reply_to":"bacf61ea_26d58c1b","updated":"2016-08-02 08:04:37.000000000","message":"Done","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"``apparmor``. Please note that docker usage requires superuser privileges."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":67,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":68,"context_line":"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz."},{"line_number":69,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":70,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_ef74e736","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":35},"updated":"2016-08-01 07:00:42.000000000","message":"s / Curently / Currently","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"``apparmor``. Please note that docker usage requires superuser privileges."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":67,"context_line":"packages must be provided. Curently such image could be downloaded from"},{"line_number":68,"context_line":"https://github.com/a-ovchinnikov/manila-image-elements-lxd-images/releases/download/0.1.0/manila-docker-container.tar.gz."},{"line_number":69,"context_line":"The image has to be unpacked but not untarred. This could be achieved by"},{"line_number":70,"context_line":"running \u0027gzip -d \u003cimagename\u003e\u0027 command. Resulting tar-archive of the"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_6870b472","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":35},"in_reply_to":"bacf61ea_ef74e736","updated":"2016-08-02 08:04:37.000000000","message":"Done","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":94,"context_line":".. code-block:: ini"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  driver_handles_share_servers \u003d True"},{"line_number":97,"context_line":"  share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":98,"context_line":"  neutron_host_id \u003d \u003chostname\u003e"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"where \u003chostname\u003e is the name of the host running neutron. (In case of single"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_cf9ac36d","line":97,"range":{"start_line":97,"start_character":48,"end_line":97,"end_character":57},"updated":"2016-08-01 07:00:42.000000000","message":"s/ container/ driver","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":94,"context_line":".. code-block:: ini"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  driver_handles_share_servers \u003d True"},{"line_number":97,"context_line":"  share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":98,"context_line":"  neutron_host_id \u003d \u003chostname\u003e"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"where \u003chostname\u003e is the name of the host running neutron. (In case of single"}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_c86ba083","line":97,"range":{"start_line":97,"start_character":48,"end_line":97,"end_character":57},"in_reply_to":"bacf61ea_cf9ac36d","updated":"2016-08-02 08:04:37.000000000","message":"Done","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":98,"context_line":"  neutron_host_id \u003d \u003chostname\u003e"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"where \u003chostname\u003e is the name of the host running neutron. (In case of single"},{"line_number":101,"context_line":"VM devstack it is VM\u0027s name)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"After restarting manila services you should be able to use the driver."}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_afd30f03","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":1},"updated":"2016-08-01 07:00:42.000000000","message":"s/w/W","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  share_driver \u003d manila.share.drivers.container.container.ContainerShareDriver"},{"line_number":98,"context_line":"  neutron_host_id \u003d \u003chostname\u003e"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"where \u003chostname\u003e is the name of the host running neutron. (In case of single"},{"line_number":101,"context_line":"VM devstack it is VM\u0027s name)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"After restarting manila services you should be able to use the driver."}],"source_content_type":"text/x-rst","patch_set":72,"id":"bacf61ea_a8fd8cb2","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":1},"in_reply_to":"bacf61ea_afd30f03","updated":"2016-08-02 08:04:37.000000000","message":"This is one sentence, like in a textbook: x\u003dy, where x is ...\n\nA comma after \u003chostname\u003e would be extremely confusing, so I had to to skip it, but lowercase looks fine to me.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d571b68c561c7111c1a96746968783f6a8be553c","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright 2016 Mirantis Inc."},{"line_number":3,"context_line":"      All Rights Reserved."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":76,"id":"9ad45d7e_06e68baf","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":2},"updated":"2016-08-11 02:09:04.000000000","message":"This file should be linked in index.rst","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright 2016 Mirantis Inc."},{"line_number":3,"context_line":"      All Rights Reserved."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":76,"id":"9ad45d7e_049799ec","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":2},"in_reply_to":"9ad45d7e_06e68baf","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"886315bc345bb3e048f549a54d62d2d87766d2f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"shared file systems services."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Supported operations and limitations"},{"line_number":26,"context_line":"------------------------------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Create CIFS share;"},{"line_number":29,"context_line":"- Delete CIFS share;"},{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share;"},{"line_number":32,"context_line":"- Extend CIFS share."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Setting up container driver with devstack"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_e425da5c","line":32,"range":{"start_line":25,"start_character":0,"end_line":32,"end_character":20},"updated":"2016-08-13 18:39:19.000000000","message":"No mention of limitations.  Can you have a \"Supported Ops\" section and separate \"Restrictions\" section as seen e.g. for the corresponding zfs on linux doc?\n\nI would think the \"Restrictions\" section would reflect what I see in the feature support matrix and also what I see in the post-test-hook.","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f2fcae2bd9e9f8d07ee66942d842955bcf38c63f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"shared file systems services."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Supported operations and limitations"},{"line_number":26,"context_line":"------------------------------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Create CIFS share;"},{"line_number":29,"context_line":"- Delete CIFS share;"},{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share;"},{"line_number":32,"context_line":"- Extend CIFS share."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Setting up container driver with devstack"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_a2a7354e","line":32,"range":{"start_line":25,"start_character":0,"end_line":32,"end_character":20},"in_reply_to":"3ac371cc_e425da5c","updated":"2016-08-15 12:23:34.000000000","message":"Done","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"886315bc345bb3e048f549a54d62d2d87766d2f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share;"},{"line_number":32,"context_line":"- Extend CIFS share."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Setting up container driver with devstack"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_24209249","line":33,"updated":"2016-08-13 18:39:19.000000000","message":"Please add a \"Known Problems\" section.\n\nIt can say \u0027None\u0027 if that is true.  (But if that is the case, why is tempest concurrency set to 1 in post-test hook?)","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f2fcae2bd9e9f8d07ee66942d842955bcf38c63f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- Allow user access to CIFS share;"},{"line_number":31,"context_line":"- Deny user access to CIFS share;"},{"line_number":32,"context_line":"- Extend CIFS share."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Setting up container driver with devstack"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_e81aaf6d","line":33,"in_reply_to":"3ac371cc_24209249","updated":"2016-08-15 12:23:34.000000000","message":"Done","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"886315bc345bb3e048f549a54d62d2d87766d2f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":" MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":46,"context_line":" MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":47,"context_line":" SHARE_DRIVER\u003dmanila.share.drivers.container.driver.ContainerShareDriver"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":50,"context_line":"\u003chostname\u003e is the name of the host with running neutron"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_641a8a19","line":48,"updated":"2016-08-13 18:39:19.000000000","message":"For reliable operation does one need to set the options set in our test runs to set a SHARE_BACKING_FILE_SIZE and to set snapshot_support False in extra specs?","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f2fcae2bd9e9f8d07ee66942d842955bcf38c63f","unresolved":false,"context_lines":[{"line_number":45,"context_line":" MANILA_OPTGROUP_london_driver_handles_share_servers\u003dTrue"},{"line_number":46,"context_line":" MANILA_OPTGROUP_london_neutron_host_id\u003d\u003chostname\u003e"},{"line_number":47,"context_line":" SHARE_DRIVER\u003dmanila.share.drivers.container.driver.ContainerShareDriver"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"where \u003cref\u003e is change reference, which could be copied from gerrit web-interface,"},{"line_number":50,"context_line":"\u003chostname\u003e is the name of the host with running neutron"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_a8e4370d","line":48,"in_reply_to":"3ac371cc_641a8a19","updated":"2016-08-15 12:23:34.000000000","message":"Good point, thank you.","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"886315bc345bb3e048f549a54d62d2d87766d2f0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"One can verify if the package is installed by issuing ``sudo docker info``"},{"line_number":63,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":64,"context_line":"In case it fails complaining on inaccessible socket try installing"},{"line_number":65,"context_line":"``apparmor``. Please note that docker usage requires superuser privileges."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":68,"context_line":"packages must be provided. Currently such image could be downloaded from"}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_e47b1a7a","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":14},"updated":"2016-08-13 18:39:19.000000000","message":"hmm, what about non-ubuntu?\n\nI amd doing a bit of testing and will get back to you.","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f2fcae2bd9e9f8d07ee66942d842955bcf38c63f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"One can verify if the package is installed by issuing ``sudo docker info``"},{"line_number":63,"context_line":"command. In case of normal operation it should return docker usage statistics."},{"line_number":64,"context_line":"In case it fails complaining on inaccessible socket try installing"},{"line_number":65,"context_line":"``apparmor``. Please note that docker usage requires superuser privileges."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"After docker is successfully installed a docker image containing necessary"},{"line_number":68,"context_line":"packages must be provided. Currently such image could be downloaded from"}],"source_content_type":"text/x-rst","patch_set":77,"id":"3ac371cc_a81d5711","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":14},"in_reply_to":"3ac371cc_e47b1a7a","updated":"2016-08-15 12:23:34.000000000","message":"The driver has been tested on Ubuntu 14.04, it has not been extensively tested on other platforms yet.","commit_id":"b2384e5649e0bf9f49a200f94cfa968b724f5a0b"}],"etc/manila/rootwrap.d/share.filters":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# manila/data/utils.py: \u0027touch\u0027, \u0027--reference\u003d%s\u0027, \u0027%s\u0027"},{"line_number":153,"context_line":"touch: CommandFilter, touch, root"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"9abb7d3a_69bb56c5","line":155,"range":{"start_line":155,"start_character":42,"end_line":155,"end_character":50},"updated":"2016-05-29 04:24:46.000000000","message":"?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# manila/data/utils.py: \u0027touch\u0027, \u0027--reference\u003d%s\u0027, \u0027%s\u0027"},{"line_number":153,"context_line":"touch: CommandFilter, touch, root"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"9abb7d3a_09cbaa54","line":155,"range":{"start_line":155,"start_character":2,"end_line":155,"end_character":32},"updated":"2016-05-29 04:24:46.000000000","message":"manila/share/drivers/container/container.py","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# manila/data/utils.py: \u0027touch\u0027, \u0027--reference\u003d%s\u0027, \u0027%s\u0027"},{"line_number":153,"context_line":"touch: CommandFilter, touch, root"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"7aa08908_9701ae07","line":155,"range":{"start_line":155,"start_character":2,"end_line":155,"end_character":32},"in_reply_to":"9abb7d3a_09cbaa54","updated":"2016-06-15 09:15:27.000000000","message":"Yes, that is the correct comment now. Thank you!","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# manila/data/utils.py: \u0027touch\u0027, \u0027--reference\u003d%s\u0027, \u0027%s\u0027"},{"line_number":153,"context_line":"touch: CommandFilter, touch, root"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"7aa08908_5718e675","line":155,"range":{"start_line":155,"start_character":42,"end_line":155,"end_character":50},"in_reply_to":"9abb7d3a_69bb56c5","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"9abb7d3a_c9b082e0","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":49},"updated":"2016-05-29 04:24:46.000000000","message":"?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"9abb7d3a_e9c74643","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":32},"updated":"2016-05-29 04:24:46.000000000","message":"manila/share/drivers/container/container.py","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"7aa08908_b7230aaa","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":49},"in_reply_to":"9abb7d3a_c9b082e0","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"# manila/share/drivers/docker.py: docker \u003cwhatever\u003e"},{"line_number":156,"context_line":"docker: CommandFilter, docker, root"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# manila/share/drivers/docker.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"7aa08908_97288e87","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":32},"in_reply_to":"9abb7d3a_e9c74643","updated":"2016-06-15 09:15:27.000000000","message":"ditto","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f571c9b0fcde0ecd530af6afc3c5758bdf84176","unresolved":false,"context_lines":[{"line_number":158,"context_line":"# manila/share/drivers/container/container.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# manila/share/drivers/container/container.py: brctl \u003cwhatever\u003e"},{"line_number":162,"context_line":"e2fsck: CommandFilter, e2fsck, root"}],"source_content_type":"application/octet-stream","patch_set":65,"id":"dada55a8_406e10ca","line":161,"range":{"start_line":161,"start_character":47,"end_line":161,"end_character":52},"updated":"2016-07-24 16:22:12.000000000","message":"e2fsck","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"bf2b15cb9b099d60bd21358b51791188efa0213e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"# manila/share/drivers/container/container.py: brctl \u003cwhatever\u003e"},{"line_number":159,"context_line":"brctl: CommandFilter, brctl, root"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# manila/share/drivers/container/container.py: brctl \u003cwhatever\u003e"},{"line_number":162,"context_line":"e2fsck: CommandFilter, e2fsck, root"}],"source_content_type":"application/octet-stream","patch_set":65,"id":"dada55a8_aed1b6fd","line":161,"range":{"start_line":161,"start_character":47,"end_line":161,"end_character":52},"in_reply_to":"dada55a8_406e10ca","updated":"2016-07-25 06:25:35.000000000","message":"Done","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"41aefb625f78cc16f3b38682f3c05ee4bafbe80e","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _create_port(self, context, share_server, share_network, device_owner):"},{"line_number":128,"context_line":"        host_id \u003d self.neutron_api.configuration.neutron_host_id"},{"line_number":129,"context_line":"        port \u003d self.neutron_api.create_port("},{"line_number":130,"context_line":"            share_network[\u0027project_id\u0027],"},{"line_number":131,"context_line":"            network_id\u003dshare_network[\u0027neutron_net_id\u0027],"},{"line_number":132,"context_line":"            subnet_id\u003dshare_network[\u0027neutron_subnet_id\u0027],"},{"line_number":133,"context_line":"            device_owner\u003d\u0027manila:\u0027 + device_owner, host_id\u003dhost_id)"},{"line_number":134,"context_line":"        port_dict \u003d {"},{"line_number":135,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"},{"line_number":136,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_e55b1c2d","line":133,"range":{"start_line":129,"start_character":7,"end_line":133,"end_character":67},"updated":"2016-05-18 06:37:34.000000000","message":"This will cause race conditions. A port has a state and if you add a host_id this means an binding will take place. Please rebase on https://review.openstack.org/#/c/283494/","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _create_port(self, context, share_server, share_network, device_owner):"},{"line_number":128,"context_line":"        host_id \u003d self.neutron_api.configuration.neutron_host_id"},{"line_number":129,"context_line":"        port \u003d self.neutron_api.create_port("},{"line_number":130,"context_line":"            share_network[\u0027project_id\u0027],"},{"line_number":131,"context_line":"            network_id\u003dshare_network[\u0027neutron_net_id\u0027],"},{"line_number":132,"context_line":"            subnet_id\u003dshare_network[\u0027neutron_subnet_id\u0027],"},{"line_number":133,"context_line":"            device_owner\u003d\u0027manila:\u0027 + device_owner, host_id\u003dhost_id)"},{"line_number":134,"context_line":"        port_dict \u003d {"},{"line_number":135,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"},{"line_number":136,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_2913f35d","line":133,"range":{"start_line":129,"start_character":7,"end_line":133,"end_character":67},"in_reply_to":"bab6814e_4130fc9e","updated":"2016-05-25 09:45:43.000000000","message":"Yes, this might cause race conditions and definitely more work has to be done to prevent them, however it would have been helpful to see any steps to reproduce such races as the driver seems to work on both my dev environment and in the gate. As for network  creation, I might be missing something, but this driver relies on existing networks, so noone actually waits on vif to create a network. Am I still missing something here?","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"bfeeb12ecfafd8875bdaa1985a6aa65d94fb79ab","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _create_port(self, context, share_server, share_network, device_owner):"},{"line_number":128,"context_line":"        host_id \u003d self.neutron_api.configuration.neutron_host_id"},{"line_number":129,"context_line":"        port \u003d self.neutron_api.create_port("},{"line_number":130,"context_line":"            share_network[\u0027project_id\u0027],"},{"line_number":131,"context_line":"            network_id\u003dshare_network[\u0027neutron_net_id\u0027],"},{"line_number":132,"context_line":"            subnet_id\u003dshare_network[\u0027neutron_subnet_id\u0027],"},{"line_number":133,"context_line":"            device_owner\u003d\u0027manila:\u0027 + device_owner, host_id\u003dhost_id)"},{"line_number":134,"context_line":"        port_dict \u003d {"},{"line_number":135,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"},{"line_number":136,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_4130fc9e","line":133,"range":{"start_line":129,"start_character":7,"end_line":133,"end_character":67},"in_reply_to":"bab6814e_e55b1c2d","updated":"2016-05-24 12:44:08.000000000","message":"I had a deeper look in this:\nIf we want to make this work it\u0027s a bit more tricky. In the official docker nova driver (https://github.com/openstack/nova-docker/blob/master/novadocker/virt/docker/driver.py#L474) the docker container is started before the network creation is done. The reason is otherwise the ovs-agent can\u0027t do any binding (no vif exist). Basically we have two possibilities: \n* Change some code in manager.py and make it possible for drivers to signal that server creation will be done before the network creation\n* make network and server creation an parallel job (like in nova-libvirt)","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_e9ce2659","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":34},"updated":"2016-05-29 04:24:46.000000000","message":"? It\u0027s being introduced only now..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_f7c75296","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":34},"in_reply_to":"9abb7d3a_e9ce2659","updated":"2016-06-15 09:15:27.000000000","message":"It means that you can put it in DEFAULT group as well, but you probably should not.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":42,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt("},{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_0578bac3","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":21},"updated":"2016-07-28 11:43:20.000000000","message":"ID","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":42,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt("},{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_50fd4e39","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":21},"in_reply_to":"bacf61ea_0578bac3","updated":"2016-07-28 12:38:42.000000000","message":"Done","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_6536d604","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":1},"updated":"2016-07-28 11:43:20.000000000","message":"No default? \n\nsocket.gethostname()?\n\n\nAlso, will this change affect this? https://review.openstack.org/#/c/283494/19/manila/network/neutron/neutron_network_plugin.py\n\nPlease add unit tests to this module","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        help\u003d\"Host id to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_70ccd235","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":1},"in_reply_to":"bacf61ea_6536d604","updated":"2016-07-28 12:38:42.000000000","message":"No defaults. This one must be specified explicitly.\n\nYes, it will affect this change. Or vise versa, depending on which is merged first.\n\nWhat about https://review.openstack.org/#/c/308930/71/manila/tests/network/neutron/test_neutron_plugin.py -- doesn\u0027t it count?","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a984f85b9881b5b203746de326a781adba61232","unresolved":false,"context_lines":[{"line_number":42,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt("},{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host ID to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_eaf5fcec","line":47,"range":{"start_line":45,"start_character":8,"end_line":47,"end_character":36},"updated":"2016-07-31 21:34:33.000000000","message":"Alexey, my point was that Marc\u0027s change would assign a default... why are you against a default?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"neutron_network_plugin_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt("},{"line_number":44,"context_line":"        \"neutron_host_id\","},{"line_number":45,"context_line":"        help\u003d\"Host ID to be used when creating neutron port. Hostname of \""},{"line_number":46,"context_line":"        \"a controller running Neutron should be used in a general case.\","},{"line_number":47,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_4843306c","line":47,"range":{"start_line":45,"start_character":8,"end_line":47,"end_character":36},"in_reply_to":"bacf61ea_eaf5fcec","updated":"2016-08-02 08:04:37.000000000","message":"I believe (maybe falsely) that default value is capable of silently causing non-working ports to appear. It will work perfectly fine in all-in-one installation, but I am not so sure about actual multinode installations. I am not sure, I have not tried that yet, so I don\u0027t want a default value. My approach is somewhat ad-hoc solution for a problem I have encountered while working on the driver, Marc\u0027s change is much more fundamental than mine and I expect that his new network plugin will handle ambiguous situations properly. Until we don\u0027t have a better way to handle port binding I prefer to be as explicit as possible.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d8aebd0bb4ad9248894244fbde580a35e660e6c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self._label \u003d kwargs.pop(\u0027label\u0027, \u0027user\u0027)"},{"line_number":62,"context_line":"        CONF.register_opts("},{"line_number":63,"context_line":"            neutron_network_plugin_opts,"},{"line_number":64,"context_line":"            group\u003dself.neutron_api.config_group_name)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def label(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_ea7e9c68","line":64,"range":{"start_line":64,"start_character":18,"end_line":64,"end_character":52},"updated":"2016-07-31 21:21:36.000000000","message":"what is self.neutron_api?\n\nDo you mean neutron_api.config_group_name?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a984f85b9881b5b203746de326a781adba61232","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self._label \u003d kwargs.pop(\u0027label\u0027, \u0027user\u0027)"},{"line_number":62,"context_line":"        CONF.register_opts("},{"line_number":63,"context_line":"            neutron_network_plugin_opts,"},{"line_number":64,"context_line":"            group\u003dself.neutron_api.config_group_name)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def label(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_aaef841c","line":64,"range":{"start_line":64,"start_character":18,"end_line":64,"end_character":52},"in_reply_to":"bacf61ea_ea7e9c68","updated":"2016-07-31 21:34:33.000000000","message":"ignore this.. i see that neutron_api is a property.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"}],"manila/opts.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    manila.network.network_opts,"},{"line_number":101,"context_line":"    manila.network.neutron.api.neutron_opts,"},{"line_number":102,"context_line":"    manila.network.neutron.neutron_network_plugin."},{"line_number":103,"context_line":"    neutron_single_network_plugin_opts,"},{"line_number":104,"context_line":"    manila.network.nova_network_plugin.nova_single_network_plugin_opts,"},{"line_number":105,"context_line":"    manila.network.standalone_network_plugin.standalone_network_plugin_opts,"},{"line_number":106,"context_line":"    manila.quota.quota_opts,"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_49dc9212","line":103,"range":{"start_line":103,"start_character":38,"end_line":103,"end_character":39},"updated":"2016-05-29 04:24:46.000000000","message":"neutron_network_plugin_opts?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    manila.network.network_opts,"},{"line_number":101,"context_line":"    manila.network.neutron.api.neutron_opts,"},{"line_number":102,"context_line":"    manila.network.neutron.neutron_network_plugin."},{"line_number":103,"context_line":"    neutron_single_network_plugin_opts,"},{"line_number":104,"context_line":"    manila.network.nova_network_plugin.nova_single_network_plugin_opts,"},{"line_number":105,"context_line":"    manila.network.standalone_network_plugin.standalone_network_plugin_opts,"},{"line_number":106,"context_line":"    manila.quota.quota_opts,"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_972ece40","line":103,"range":{"start_line":103,"start_character":38,"end_line":103,"end_character":39},"in_reply_to":"9abb7d3a_49dc9212","updated":"2016-06-15 09:15:27.000000000","message":"Yes. Thank you!","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"}],"manila/share/drivers/container/.protocol_helper.py.swo":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f2750b34ad7756f4a6e5f6d9782fdbec216e2bf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9ad45d7e_25c3e539","updated":"2016-08-10 14:08:00.000000000","message":"?","commit_id":"bc1bb0fda6de5075be4633b43bf80be63e7dae26"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f162a51b8ab746bcdd26b96d32959f1a52a2e45a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9ad45d7e_8b51f638","in_reply_to":"9ad45d7e_25c3e539","updated":"2016-08-10 17:26:11.000000000","message":"Whoops, sorry, didn\u0027t mean to upload this one!","commit_id":"bc1bb0fda6de5075be4633b43bf80be63e7dae26"}],"manila/share/drivers/container/__init__.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Container Driver for shares."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This driver allows to use a container as a share server."},{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_60fd65b0","line":16,"updated":"2016-05-12 03:30:05.000000000","message":"We shouldn\u0027t put driver code in __init__.py -- it should go in a file called container.py or driver.py.","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Container Driver for shares."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This driver allows to use a container as a share server."},{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_bdfc4f3f","line":16,"in_reply_to":"dab17558_60fd65b0","updated":"2016-05-13 10:01:06.000000000","message":"Done","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"}],"manila/share/drivers/container/container.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_name \u003d share.share_id"},{"line_number":125,"context_line":"        self.container.execute_sync("},{"line_number":126,"context_line":"            server_id,"},{"line_number":127,"context_line":"            [\"mkdir\", \"-m\", \"777\", \"/shares/%s\" % share_name]"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.storage.provide_storage(share)"},{"line_number":130,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_3cde4cdd","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":32},"updated":"2016-05-20 22:32:46.000000000","message":"Is it really necessary to set the permissions to 777?","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_name \u003d share.share_id"},{"line_number":125,"context_line":"        self.container.execute_sync("},{"line_number":126,"context_line":"            server_id,"},{"line_number":127,"context_line":"            [\"mkdir\", \"-m\", \"777\", \"/shares/%s\" % share_name]"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.storage.provide_storage(share)"},{"line_number":130,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_b00f29e0","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":32},"in_reply_to":"bab6814e_0b2b7295","updated":"2016-05-25 14:45:15.000000000","message":"Right!","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_name \u003d share.share_id"},{"line_number":125,"context_line":"        self.container.execute_sync("},{"line_number":126,"context_line":"            server_id,"},{"line_number":127,"context_line":"            [\"mkdir\", \"-m\", \"777\", \"/shares/%s\" % share_name]"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.storage.provide_storage(share)"},{"line_number":130,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_894f7f69","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":32},"in_reply_to":"bab6814e_3cde4cdd","updated":"2016-05-25 09:45:43.000000000","message":"Good catch! 0640 should do the trick as well.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_name \u003d share.share_id"},{"line_number":125,"context_line":"        self.container.execute_sync("},{"line_number":126,"context_line":"            server_id,"},{"line_number":127,"context_line":"            [\"mkdir\", \"-m\", \"777\", \"/shares/%s\" % share_name]"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.storage.provide_storage(share)"},{"line_number":130,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_0b2b7295","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":32},"in_reply_to":"bab6814e_894f7f69","updated":"2016-05-25 13:41:10.000000000","message":"As this is a directory,the permissions should be 0750.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def check_for_setup_error(self, *args, **kwargs):"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":178,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":179,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":180,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_e8587e8c","line":177,"updated":"2016-05-20 22:32:46.000000000","message":"This method seems wrong to me.\nI think it would be better if the docker container was linked to the correct ovs bridge when started.\nAs it is here, the container gets linked to the docker0 bridge (with default settings), then gets removed from the docker0 bridge and afterwards added to the ovs bridge.\nLinking the container to the ovs directly would make the code of this method unnecessary, because the container would be in the correct network from the start.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def check_for_setup_error(self, *args, **kwargs):"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":178,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":179,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":180,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_f0e7f10f","line":177,"in_reply_to":"bab6814e_61ba1de3","updated":"2016-05-25 14:45:15.000000000","message":"We are stuck with rather outdated version of Docker on trusty, so I suggest to keep this part as is  for now,.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def check_for_setup_error(self, *args, **kwargs):"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":178,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":179,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":180,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_61ba1de3","line":177,"in_reply_to":"bab6814e_89d2df59","updated":"2016-05-25 13:41:10.000000000","message":"It should be possible to specify the network containers should connect to using the --net parameter for docker run. (See https://docs.docker.com/engine/reference/run/#network-settings)\nBut it may be, that this is only possible for newer docker versions.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def check_for_setup_error(self, *args, **kwargs):"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":178,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":179,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":180,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_89d2df59","line":177,"in_reply_to":"bab6814e_e8587e8c","updated":"2016-05-25 09:45:43.000000000","message":"AFAIK docker does not support ovs integration out of the box, but that might be no longer a valid concern. Also if I get this right we\u0027ll still need to connect the container to a proper neutron network.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.container.stop_container(server_id)"},{"line_number":220,"context_line":"        interfaces \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\","},{"line_number":221,"context_line":"                                   run_as_root\u003dTrue)[0]"},{"line_number":222,"context_line":"        veths \u003d re.findall(\"veth[0-9a-zA-Z]{7}\", interfaces)"},{"line_number":223,"context_line":"        manila_re \u003d (\"manila_[0-9a-f]{8}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{4}_\""},{"line_number":224,"context_line":"                     \"[0-9a-f]{12}\")"},{"line_number":225,"context_line":"        for veth in veths:"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_94cd7687","line":222,"range":{"start_line":222,"start_character":27,"end_line":222,"end_character":47},"updated":"2016-05-20 22:32:46.000000000","message":"You could compile this regex once and then use the compiled regex","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.container.stop_container(server_id)"},{"line_number":220,"context_line":"        interfaces \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\","},{"line_number":221,"context_line":"                                   run_as_root\u003dTrue)[0]"},{"line_number":222,"context_line":"        veths \u003d re.findall(\"veth[0-9a-zA-Z]{7}\", interfaces)"},{"line_number":223,"context_line":"        manila_re \u003d (\"manila_[0-9a-f]{8}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{4}_\""},{"line_number":224,"context_line":"                     \"[0-9a-f]{12}\")"},{"line_number":225,"context_line":"        for veth in veths:"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_29c49390","line":222,"range":{"start_line":222,"start_character":27,"end_line":222,"end_character":47},"in_reply_to":"bab6814e_94cd7687","updated":"2016-05-25 09:45:43.000000000","message":"Yes, sure.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        interfaces \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\","},{"line_number":221,"context_line":"                                   run_as_root\u003dTrue)[0]"},{"line_number":222,"context_line":"        veths \u003d re.findall(\"veth[0-9a-zA-Z]{7}\", interfaces)"},{"line_number":223,"context_line":"        manila_re \u003d (\"manila_[0-9a-f]{8}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{4}_\""},{"line_number":224,"context_line":"                     \"[0-9a-f]{12}\")"},{"line_number":225,"context_line":"        for veth in veths:"},{"line_number":226,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":227,"context_line":"                                       run_as_root\u003dTrue)[0]"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_14a8668c","line":224,"range":{"start_line":223,"start_character":21,"end_line":224,"end_character":35},"updated":"2016-05-20 22:32:46.000000000","message":"Like above: You could compile this regex.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        interfaces \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\","},{"line_number":221,"context_line":"                                   run_as_root\u003dTrue)[0]"},{"line_number":222,"context_line":"        veths \u003d re.findall(\"veth[0-9a-zA-Z]{7}\", interfaces)"},{"line_number":223,"context_line":"        manila_re \u003d (\"manila_[0-9a-f]{8}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{4}_\""},{"line_number":224,"context_line":"                     \"[0-9a-f]{12}\")"},{"line_number":225,"context_line":"        for veth in veths:"},{"line_number":226,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":227,"context_line":"                                       run_as_root\u003dTrue)[0]"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_49b91715","line":224,"range":{"start_line":223,"start_character":21,"end_line":224,"end_character":35},"in_reply_to":"bab6814e_14a8668c","updated":"2016-05-25 09:45:43.000000000","message":"Agreed.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":227,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":228,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":229,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":230,"context_line":"                continue"},{"line_number":231,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":232,"context_line":"                LOG.debug(\"Deleting veth.\")"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_746c52d0","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":33},"updated":"2016-05-20 22:32:46.000000000","message":"Could be simplified to \u0027if not container_id\u0027","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":227,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":228,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":229,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":230,"context_line":"                continue"},{"line_number":231,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":232,"context_line":"                LOG.debug(\"Deleting veth.\")"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_c9434712","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":33},"in_reply_to":"bab6814e_746c52d0","updated":"2016-05-25 09:45:43.000000000","message":"Yes, that could be done.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                              veth, run_as_root\u003dTrue)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_veth_state(self):"},{"line_number":238,"context_line":"        result \u003d self._execute(\"brctl\", \"show\", \"docker0\", run_as_root\u003dTrue)"},{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_f4c20233","line":238,"range":{"start_line":238,"start_character":48,"end_line":238,"end_character":57},"updated":"2016-05-20 22:32:46.000000000","message":"Hardcoded interface name.\nI think this should be self.configuration.container_linux_bridge_name.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                              veth, run_as_root\u003dTrue)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_veth_state(self):"},{"line_number":238,"context_line":"        result \u003d self._execute(\"brctl\", \"show\", \"docker0\", run_as_root\u003dTrue)"},{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_0990af4d","line":238,"range":{"start_line":238,"start_character":48,"end_line":238,"end_character":57},"in_reply_to":"bab6814e_f4c20233","updated":"2016-05-25 09:45:43.000000000","message":"Yes, good catch, this should not be hardcoded.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_veth_state(self):"},{"line_number":238,"context_line":"        result \u003d self._execute(\"brctl\", \"show\", \"docker0\", run_as_root\u003dTrue)"},{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""},{"line_number":242,"context_line":"                  \" docker0 now: \" + \", \".join(veths))"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_b497da46","line":239,"range":{"start_line":239,"start_character":27,"end_line":239,"end_character":38},"updated":"2016-05-20 22:32:46.000000000","message":"Like above: You could compile this regex.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_veth_state(self):"},{"line_number":238,"context_line":"        result \u003d self._execute(\"brctl\", \"show\", \"docker0\", run_as_root\u003dTrue)"},{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""},{"line_number":242,"context_line":"                  \" docker0 now: \" + \", \".join(veths))"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_699fbb5f","line":239,"range":{"start_line":239,"start_character":27,"end_line":239,"end_character":38},"in_reply_to":"bab6814e_b497da46","updated":"2016-05-25 09:45:43.000000000","message":"Yes, this could be done.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""},{"line_number":242,"context_line":"                  \" docker0 now: \" + \", \".join(veths))"},{"line_number":243,"context_line":"        return veths"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def _get_corresponding_veth(self, before, after):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_d4bffea7","line":242,"range":{"start_line":242,"start_character":20,"end_line":242,"end_character":27},"updated":"2016-05-20 22:32:46.000000000","message":"Like above: Interfce name should not be hardcoded.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        veths \u003d re.findall(\"veth.*\\\\n\", result[0])"},{"line_number":240,"context_line":"        veths \u003d [x.rstrip(\u0027\\n\u0027) for x in veths]"},{"line_number":241,"context_line":"        LOG.debug(\"The following veth interfaces are plugged into\""},{"line_number":242,"context_line":"                  \" docker0 now: \" + \", \".join(veths))"},{"line_number":243,"context_line":"        return veths"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def _get_corresponding_veth(self, before, after):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_e981ebfc","line":242,"range":{"start_line":242,"start_character":20,"end_line":242,"end_character":27},"in_reply_to":"bab6814e_d4bffea7","updated":"2016-05-25 09:45:43.000000000","message":"Yes, will fix it in the next patchset.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Container Driver for shares."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This driver allows to use a container as a share server."},{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_8904ba7e","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":25},"updated":"2016-05-29 04:24:46.000000000","message":"nit: uses","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Container Driver for shares."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This driver allows to use a container as a share server."},{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_b79e6a67","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":25},"in_reply_to":"9abb7d3a_8904ba7e","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\"container_linux_bridge_name\","},{"line_number":42,"context_line":"               default\u003d\"docker0\","},{"line_number":43,"context_line":"               required\u003dTrue,"},{"line_number":44,"context_line":"               help\u003d\"Linux bridge used by container hypervisor to plug\""},{"line_number":45,"context_line":"                    \"host-side veth to. It will be unplugged from here \""},{"line_number":46,"context_line":"                    \"by the driver.\"),"},{"line_number":47,"context_line":"    cfg.StrOpt(\"container_ovs_bridge_name\","}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_69099695","line":44,"range":{"start_line":44,"start_character":70,"end_line":44,"end_character":71},"updated":"2016-05-29 04:24:46.000000000","message":"missing space","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\"container_linux_bridge_name\","},{"line_number":42,"context_line":"               default\u003d\"docker0\","},{"line_number":43,"context_line":"               required\u003dTrue,"},{"line_number":44,"context_line":"               help\u003d\"Linux bridge used by container hypervisor to plug\""},{"line_number":45,"context_line":"                    \"host-side veth to. It will be unplugged from here \""},{"line_number":46,"context_line":"                    \"by the driver.\"),"},{"line_number":47,"context_line":"    cfg.StrOpt(\"container_ovs_bridge_name\","}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_f7a8f28e","line":44,"range":{"start_line":44,"start_character":70,"end_line":44,"end_character":71},"in_reply_to":"9abb7d3a_69099695","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""},{"line_number":60,"context_line":"               \"DockerExecHelper\","}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_a9037e72","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":50},"updated":"2016-05-29 04:24:46.000000000","message":"\u0027the container driven share server\u0027?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""},{"line_number":60,"context_line":"               \"DockerExecHelper\","}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_17901e4e","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":50},"in_reply_to":"9abb7d3a_a9037e72","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""},{"line_number":60,"context_line":"               \"DockerExecHelper\","},{"line_number":61,"context_line":"               help\u003d\"Container helper which provides container-related\""},{"line_number":62,"context_line":"                    \"operations to the driver.\"),"},{"line_number":63,"context_line":"    cfg.StrOpt(\"container_protocol_helper\","},{"line_number":64,"context_line":"               default\u003d\"manila.share.drivers.container.protocol_helper.\""}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_e9f58683","line":61,"range":{"start_line":61,"start_character":70,"end_line":61,"end_character":71},"updated":"2016-05-29 04:24:46.000000000","message":"missing space","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""},{"line_number":60,"context_line":"               \"DockerExecHelper\","},{"line_number":61,"context_line":"               help\u003d\"Container helper which provides container-related\""},{"line_number":62,"context_line":"                    \"operations to the driver.\"),"},{"line_number":63,"context_line":"    cfg.StrOpt(\"container_protocol_helper\","},{"line_number":64,"context_line":"               default\u003d\"manila.share.drivers.container.protocol_helper.\""}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_779d2266","line":61,"range":{"start_line":61,"start_character":70,"end_line":61,"end_character":71},"in_reply_to":"9abb7d3a_e9f58683","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ContainerShareDriver(driver.ShareDriver, driver.ExecuteMixin):"},{"line_number":79,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":80,"context_line":"        self.admin_context \u003d context.get_admin_context()"},{"line_number":81,"context_line":"        super(ContainerShareDriver, self).__init__([True], *args, **kwargs)"},{"line_number":82,"context_line":"        self.configuration.append_config_values(container_opts)"},{"line_number":83,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_29f02e90","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":56},"updated":"2016-05-29 04:24:46.000000000","message":"don\u0027t see this being used..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ContainerShareDriver(driver.ShareDriver, driver.ExecuteMixin):"},{"line_number":79,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":80,"context_line":"        self.admin_context \u003d context.get_admin_context()"},{"line_number":81,"context_line":"        super(ContainerShareDriver, self).__init__([True], *args, **kwargs)"},{"line_number":82,"context_line":"        self.configuration.append_config_values(container_opts)"},{"line_number":83,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_37c8ba56","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":56},"in_reply_to":"9abb7d3a_29f02e90","updated":"2016-06-15 09:15:27.000000000","message":"Yes, it is a leftover.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"},{"line_number":115,"context_line":"            \u0027snapshot_support\u0027: False,"},{"line_number":116,"context_line":"            \u0027driver_name\u0027: \u0027ContainerShareDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_49fdb239","line":113,"range":{"start_line":113,"start_character":16,"end_line":113,"end_character":60},"updated":"2016-05-29 04:24:46.000000000","message":"This is being overwritten with 0?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"},{"line_number":115,"context_line":"            \u0027snapshot_support\u0027: False,"},{"line_number":116,"context_line":"            \u0027driver_name\u0027: \u0027ContainerShareDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_37243a0d","line":113,"range":{"start_line":113,"start_character":16,"end_line":113,"end_character":60},"in_reply_to":"9abb7d3a_49fdb239","updated":"2016-06-15 09:15:27.000000000","message":"No, it happens vice versa.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        veth \u003d self._get_corresponding_veth(veths_before, veths_after)"},{"line_number":269,"context_line":"        self._connect_to_network(server_id, network_info, veth)"},{"line_number":270,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"},{"line_number":271,"context_line":"        return {\"id\": network_info[\"server_id\"]}"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_69ccf635","line":270,"range":{"start_line":270,"start_character":12,"end_line":270,"end_character":17},"updated":"2016-05-29 04:24:46.000000000","message":"info?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        veth \u003d self._get_corresponding_veth(veths_before, veths_after)"},{"line_number":269,"context_line":"        self._connect_to_network(server_id, network_info, veth)"},{"line_number":270,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"},{"line_number":271,"context_line":"        return {\"id\": network_info[\"server_id\"]}"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_c9d1a2cf","line":270,"range":{"start_line":270,"start_character":43,"end_line":270,"end_character":44},"updated":"2016-05-29 04:24:46.000000000","message":"no exclamation..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        veth \u003d self._get_corresponding_veth(veths_before, veths_after)"},{"line_number":269,"context_line":"        self._connect_to_network(server_id, network_info, veth)"},{"line_number":270,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"},{"line_number":271,"context_line":"        return {\"id\": network_info[\"server_id\"]}"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_a284665d","line":270,"range":{"start_line":270,"start_character":12,"end_line":270,"end_character":17},"in_reply_to":"9abb7d3a_69ccf635","updated":"2016-06-15 09:15:27.000000000","message":"Yes.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        veth \u003d self._get_corresponding_veth(veths_before, veths_after)"},{"line_number":269,"context_line":"        self._connect_to_network(server_id, network_info, veth)"},{"line_number":270,"context_line":"        LOG.debug(\"Container %s was created!\", server_id)"},{"line_number":271,"context_line":"        return {\"id\": network_info[\"server_id\"]}"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_628b9e69","line":270,"range":{"start_line":270,"start_character":43,"end_line":270,"end_character":44},"in_reply_to":"9abb7d3a_c9d1a2cf","updated":"2016-06-15 09:15:27.000000000","message":"That\u0027s no fun!","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_4540d335","line":22,"updated":"2016-06-16 16:55:29.000000000","message":"Maybe better call this module something else? For example \"driver\"?. Because parent module has the same name. Or define this code in __init__.py?","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1cfbbb5d4a43677d33c7fb135ae6524e0d32f4d4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_b90b9f23","line":22,"in_reply_to":"7aa08908_4540d335","updated":"2016-06-16 19:11:02.000000000","message":"Please don\u0027t put code in __init__.py!\n\nYou could call this driver.py or docker.py, although I think the current name isn\u0027t terrible.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_b34a8525","line":22,"in_reply_to":"7aa08908_4540d335","updated":"2016-06-17 11:11:20.000000000","message":"The main reason for container.py was to remove code from __init__.py.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"3cbe726a5260473917e6f4909a885c4f10451f8b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_659b25ca","line":22,"in_reply_to":"7aa08908_539b56c9","updated":"2016-06-17 12:22:23.000000000","message":"Ok, let it be \u0027driver.py\u0027 then.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db0146ae0fdf3fe61f69db208c5d7564cb93ef4d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_539b56c9","line":22,"in_reply_to":"7aa08908_b34a8525","updated":"2016-06-17 11:36:04.000000000","message":"Em, test module is called as \"*driver*\":\n\nmanila/tests/share/drivers/container/test_driver.py\n\nSome other name different than \"duplicating parent\" is always better.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current implementation suggests that a container when started by Docker will"},{"line_number":20,"context_line":"be plugged into a Linux bridge. Also it is suggested that all interfaces"},{"line_number":21,"context_line":"willing to talk to each other reside in an OVS bridge.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_13bef963","line":22,"in_reply_to":"7aa08908_b90b9f23","updated":"2016-06-17 11:11:20.000000000","message":"I\u0027ll keep the current name for now.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\"container_linux_bridge_name\","},{"line_number":42,"context_line":"               default\u003d\"docker0\","},{"line_number":43,"context_line":"               required\u003dTrue,"},{"line_number":44,"context_line":"               help\u003d\"Linux bridge used by container hypervisor to plug \""},{"line_number":45,"context_line":"                    \"host-side veth to. It will be unplugged from here \""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_aaa226ab","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":32},"updated":"2016-06-16 16:55:29.000000000","message":"Not sure we should have default value for it. Same for \"container_ovs_bridge_name\" and \"container_image_name\".","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\"container_linux_bridge_name\","},{"line_number":42,"context_line":"               default\u003d\"docker0\","},{"line_number":43,"context_line":"               required\u003dTrue,"},{"line_number":44,"context_line":"               help\u003d\"Linux bridge used by container hypervisor to plug \""},{"line_number":45,"context_line":"                    \"host-side veth to. It will be unplugged from here \""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_1314399d","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":32},"in_reply_to":"7aa08908_aaa226ab","updated":"2016-06-17 11:11:20.000000000","message":"One has to put extra effort into changing this name i.e. reconfigure docker. The same stands true for \"container_ovs_bridge_name\": bridge name should first be explicitly changed elsewhere.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\"yes\","},{"line_number":53,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a container-based share server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_0aaffa7d","line":56,"range":{"start_line":55,"start_character":15,"end_line":56,"end_character":49},"updated":"2016-06-16 16:55:29.000000000","message":"Such options should be \"required\" and without default value. Admin should intentionally define this one and first two options.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\"yes\","},{"line_number":53,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a container-based share server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_b37ba528","line":56,"range":{"start_line":55,"start_character":15,"end_line":56,"end_character":49},"in_reply_to":"7aa08908_0aaffa7d","updated":"2016-06-17 11:11:20.000000000","message":"No, they should not, unless we are expecting other people to supply third-party images. Even then I believe it is ok to keep the default value. If someone does not have such image at hand then he is probably doing something wrong or understands what he is doing well enough.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"3cbe726a5260473917e6f4909a885c4f10451f8b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\"yes\","},{"line_number":53,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a container-based share server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_052ea18b","line":56,"range":{"start_line":55,"start_character":15,"end_line":56,"end_character":49},"in_reply_to":"7aa08908_381dc973","updated":"2016-06-17 12:22:23.000000000","message":"Exactly, that\u0027s why in some real deployment this will be changed to something more appropriate no matter if it has default value or not.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db0146ae0fdf3fe61f69db208c5d7564cb93ef4d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\"yes\","},{"line_number":53,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":54,"context_line":"                    \"or not.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"container_image_name\","},{"line_number":56,"context_line":"               default\u003d\"manila-docker-container\","},{"line_number":57,"context_line":"               help\u003d\"Image to be used for a container-based share server.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt(\"container_helper\","},{"line_number":59,"context_line":"               default\u003d\"manila.share.drivers.container.container_helper.\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_381dc973","line":56,"range":{"start_line":55,"start_character":15,"end_line":56,"end_character":49},"in_reply_to":"7aa08908_b37ba528","updated":"2016-06-17 11:36:04.000000000","message":"If it is used in some real deployment then images will have normal names with some versions, architectures and other tags. This one is suitable only for testing.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    \"is used to provide storage for a share.\"),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF.register_opts(container_opts)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ContainerShareDriver(driver.ShareDriver, driver.ExecuteMixin):"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_0a409a06","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":34},"updated":"2016-06-16 16:55:29.000000000","message":"It is redundant. You use driver \"configuration\" attribute. Not default group options.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    \"is used to provide storage for a share.\"),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF.register_opts(container_opts)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ContainerShareDriver(driver.ShareDriver, driver.ExecuteMixin):"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_f31fedb4","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":34},"in_reply_to":"7aa08908_0a409a06","updated":"2016-06-17 11:11:20.000000000","message":"Good point, thank you.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1cfbbb5d4a43677d33c7fb135ae6524e0d32f4d4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                configuration\u003dself.configuration)"},{"line_number":90,"context_line":"        self._helpers \u003d {}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _get_helper(self, share):"},{"line_number":93,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":94,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":95,"context_line":"            if helper is not None:"},{"line_number":96,"context_line":"                helper.share \u003d share"},{"line_number":97,"context_line":"                return helper"},{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)("},{"line_number":100,"context_line":"                    self.container, share\u003dshare, config\u003dself.configuration)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_79d2d75c","line":97,"range":{"start_line":92,"start_character":4,"end_line":97,"end_character":29},"updated":"2016-06-16 19:11:02.000000000","message":"You appear to be caching the protocol helper, which itself has state (the share).  Because it is stateful, it is not reentrant and will lead to hard-to-find concurrency bugs.  I learned this the hard way in the NetApp driver.  You should make the protocol helpers stateless, or just create a new one whenever you need one.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db0146ae0fdf3fe61f69db208c5d7564cb93ef4d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                configuration\u003dself.configuration)"},{"line_number":90,"context_line":"        self._helpers \u003d {}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _get_helper(self, share):"},{"line_number":93,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":94,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":95,"context_line":"            if helper is not None:"},{"line_number":96,"context_line":"                helper.share \u003d share"},{"line_number":97,"context_line":"                return helper"},{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)("},{"line_number":100,"context_line":"                    self.container, share\u003dshare, config\u003dself.configuration)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_1890cdec","line":97,"range":{"start_line":92,"start_character":4,"end_line":97,"end_character":29},"in_reply_to":"7aa08908_3394d5e6","updated":"2016-06-17 11:36:04.000000000","message":"+1 for making it stateless.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                configuration\u003dself.configuration)"},{"line_number":90,"context_line":"        self._helpers \u003d {}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _get_helper(self, share):"},{"line_number":93,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":94,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":95,"context_line":"            if helper is not None:"},{"line_number":96,"context_line":"                helper.share \u003d share"},{"line_number":97,"context_line":"                return helper"},{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)("},{"line_number":100,"context_line":"                    self.container, share\u003dshare, config\u003dself.configuration)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_3394d5e6","line":97,"range":{"start_line":92,"start_character":4,"end_line":97,"end_character":29},"in_reply_to":"7aa08908_79d2d75c","updated":"2016-06-17 11:11:20.000000000","message":"Yes, this has a great potential for sporadic glitches. Thank you for pointing this out!","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"}],"manila/share/drivers/container/container_helper.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":32,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_0f6d0c31","line":34,"range":{"start_line":34,"start_character":51,"end_line":34,"end_character":63},"updated":"2016-05-20 22:32:46.000000000","message":"Why is it required to start the container in privileged mode?\nIf it is possible, I would prefer to run the container as not privileged.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":32,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_69f21b9c","line":34,"range":{"start_line":34,"start_character":51,"end_line":34,"end_character":63},"in_reply_to":"bab6814e_0f6d0c31","updated":"2016-05-25 09:45:43.000000000","message":"Apparently privileged mode is needed to make samba work inside a container. The same holds true for nfs-ganesha inside a container, by the way.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":32,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_a199a570","line":34,"range":{"start_line":34,"start_character":51,"end_line":34,"end_character":63},"in_reply_to":"bab6814e_69f21b9c","updated":"2016-05-25 13:41:10.000000000","message":"Ah ok, good to know!\nIt would be great if you could add a little comment here to explain that --privileged is needed for samba.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":32,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_70bae1e2","line":34,"range":{"start_line":34,"start_character":51,"end_line":34,"end_character":63},"in_reply_to":"bab6814e_a199a570","updated":"2016-05-25 14:45:15.000000000","message":"Done","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":38,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_17f068fd","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"updated":"2016-05-20 22:32:46.000000000","message":"What happens if \u0027docker run\u0027 fails?\nI think you need some error handling before logging that the container has been successfully started.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":38,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_8933ff12","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"bab6814e_17f068fd","updated":"2016-05-25 09:45:43.000000000","message":"Well, yes, but from what I know about docker if one has a working container and a working docker installation she has to put some significant effort into making \u0027docker run\u0027 fail. Am I wrong? I would actually appreciate any points on how to make \u0027docker run\u0027 fail, as it seems to be rather stable and it is not immediately clear how such a failure looks like and what exactly should be handled.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":38,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_e43a9bcc","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"bab6814e_8933ff12","updated":"2016-05-25 13:41:10.000000000","message":"One possibility that comes to my mind which would cause \u0027docker run\u0027 to fail is that somebody (maybe accidentally) deletes the image.\nObviously the container won\u0027t be able to start when the image is missing.\n\nIMHO you should check the return code or the error output from the \u0027docker run\u0027 command, and if this indicates a failure you should log that error (and maybe raise an error).","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":34,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":35,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":36,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027]"},{"line_number":37,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":38,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_f0db71eb","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"bab6814e_e43a9bcc","updated":"2016-05-25 14:45:15.000000000","message":"An excellent example, thank you!","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def stop_container(self, name):"},{"line_number":41,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_b7dfdc67","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":32},"updated":"2016-05-20 22:32:46.000000000","message":"What happens if \u0027docker stop\u0027 fails?\nI think you need some error handling before logging that the container has been successfully stopped.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def stop_container(self, name):"},{"line_number":41,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_d0fd8d3c","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":32},"in_reply_to":"bab6814e_04c4ff5c","updated":"2016-05-25 14:45:15.000000000","message":"Ok, agreed, will add a check here as well.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def stop_container(self, name):"},{"line_number":41,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_d45abaf1","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":32},"in_reply_to":"bab6814e_b7dfdc67","updated":"2016-05-25 09:45:43.000000000","message":"Could you please provide a reliably reproducible example of how \u0027docker stop\u0027 could fail, especially in our use case? The lack of error handling is disturbing me as well, but docker has not demonstrated any instablility so far.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def stop_container(self, name):"},{"line_number":41,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_04c4ff5c","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":32},"in_reply_to":"bab6814e_d45abaf1","updated":"2016-05-25 13:41:10.000000000","message":"While I can\u0027t think of an example how docker stop could fail, the possibility of a failure surely exists (just google \u0027docker stop fail\u0027 and you\u0027ll find many github issues regarding problems where \u0027docker stop\u0027 failed, e.g. https://github.com/docker/docker/issues/10589 )\n\nI think it would be a good style to have error handling here, and not just log a success, even if there may have been a failure.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"},{"line_number":47,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":48,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":49,"context_line":"        result \u003d self._inner_execute(cmd)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_9771f878","line":46,"range":{"start_line":46,"start_character":32,"end_line":46,"end_character":41},"updated":"2016-05-20 22:32:46.000000000","message":"\"newname\" doesn\u0027t seem like a good default value to me.\n\u0027docker exec\u0027 will most likely fail with this name, because it won\u0027t find any container with this name.\nI would prefer None as default, together with a check if a name was passed.\nIf name is None the method should not try to run \u0027docker exec\u0027, but raise an Exception.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._inner_execute(cmd)"},{"line_number":44,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def execute_sync(self, name\u003d\"newname\", cmd\u003dNone):"},{"line_number":47,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":48,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":49,"context_line":"        result \u003d self._inner_execute(cmd)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_34e7c613","line":46,"range":{"start_line":46,"start_character":32,"end_line":46,"end_character":41},"in_reply_to":"bab6814e_9771f878","updated":"2016-05-25 09:45:43.000000000","message":"Good point, thank you.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":49,"context_line":"        result \u003d self._inner_execute(cmd)"},{"line_number":50,"context_line":"        LOG.debug(\"Run result: %s.\", str(result))"},{"line_number":51,"context_line":"        return result"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _inner_execute(self, cmd):"},{"line_number":54,"context_line":"        LOG.debug(\"Executing command: %s.\", \" \".join(cmd))"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_02a2e8fc","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":21},"updated":"2016-05-20 22:32:46.000000000","message":"_inner_execute can return None when an Exception is thrown by _execute.\n\nYou call execute_sync in many places in your code and try to access [0] directly afterwards, without any error checking.\nThis could cause a TypeError, when execute_sync returns None or an IndexError if result is empty.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":49,"context_line":"        result \u003d self._inner_execute(cmd)"},{"line_number":50,"context_line":"        LOG.debug(\"Run result: %s.\", str(result))"},{"line_number":51,"context_line":"        return result"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _inner_execute(self, cmd):"},{"line_number":54,"context_line":"        LOG.debug(\"Executing command: %s.\", \" \".join(cmd))"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_54440ab6","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":21},"in_reply_to":"bab6814e_02a2e8fc","updated":"2016-05-25 09:45:43.000000000","message":"Done","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1dfad77bc76a502251fc4ab195eeab9bde894aae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":39,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":40,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":41,"context_line":"        if result[1] !\u003d 0:"},{"line_number":42,"context_line":"            raise exception.ManilaException("},{"line_number":43,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":44,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_3ab6a18a","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":26},"updated":"2016-06-10 10:25:36.000000000","message":"I\u0027m currently testing this, and for me all started containers are reported as failures, even though i can see with \u0027docker ps\u0027 that they were successfully created.\n\nDebugging this i noticed that result is\n\n  (\u002746d34c2038ba6a39c3f5e217db1b443c6f06d715f8e6cb224ce47483ca15d279\\n\u0027, \u0027\u0027)\n\nSo the problem is, that result[1] is an empty string, not 0.\n\nAccording to the documentation of processutils.execute() the method returns the tuple (stdout, stderr). So I guess you should either check for a string here or look if you can pass \u0027check_exit_code\u0027 to processutils.execute and catch the ProcessExecutionError that would be thrown if the exit code is wrong.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":39,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":40,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":41,"context_line":"        if result[1] !\u003d 0:"},{"line_number":42,"context_line":"            raise exception.ManilaException("},{"line_number":43,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":44,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_a265861e","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":26},"in_reply_to":"7aa08908_3ab6a18a","updated":"2016-06-15 09:15:27.000000000","message":"Yes, thank you, will fix this in the next patch set.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if result[1] !\u003d 0:"},{"line_number":42,"context_line":"            raise exception.ManilaException("},{"line_number":43,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":44,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":45,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def stop_container(self, name):"},{"line_number":48,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_e9d8e6f1","line":45,"range":{"start_line":44,"start_character":19,"end_line":45,"end_character":22},"updated":"2016-05-29 04:24:46.000000000","message":"LOG.info(_LI(\"Container %s has been started successfully.\", result[0].rstrip(\u0027\\n\u0027))","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if result[1] !\u003d 0:"},{"line_number":42,"context_line":"            raise exception.ManilaException("},{"line_number":43,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":44,"context_line":"        LOG.debug(\"A container has been successfully started! Its id is \""},{"line_number":45,"context_line":"                  \"%s.\", result[0].rstrip(\u0027\\n\u0027))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def stop_container(self, name):"},{"line_number":48,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_82e32aa4","line":45,"range":{"start_line":44,"start_character":19,"end_line":45,"end_character":22},"in_reply_to":"9abb7d3a_e9d8e6f1","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1dfad77bc76a502251fc4ab195eeab9bde894aae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":49,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":50,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":51,"context_line":"        if result[1] !\u003d 0:"},{"line_number":52,"context_line":"            raise exception.ManilaException("},{"line_number":53,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":54,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_fa309909","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":26},"updated":"2016-06-10 10:25:36.000000000","message":"Same as in start_container","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        LOG.debug(\"Stopping container %s.\", name)"},{"line_number":49,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":50,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":51,"context_line":"        if result[1] !\u003d 0:"},{"line_number":52,"context_line":"            raise exception.ManilaException("},{"line_number":53,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":54,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_02429a68","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":26},"in_reply_to":"7aa08908_fa309909","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if result[1] !\u003d 0:"},{"line_number":52,"context_line":"            raise exception.ManilaException("},{"line_number":53,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":54,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def execute_sync(self, name\u003dNone, cmd\u003dNone):"},{"line_number":57,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_49e652b5","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":17},"updated":"2016-05-29 04:24:46.000000000","message":"info..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if result[1] !\u003d 0:"},{"line_number":52,"context_line":"            raise exception.ManilaException("},{"line_number":53,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":54,"context_line":"        LOG.debug(\"Container %s is successfully stopped.\", name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def execute_sync(self, name\u003dNone, cmd\u003dNone):"},{"line_number":57,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_222076b0","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":17},"in_reply_to":"9abb7d3a_49e652b5","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":55,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def execute_sync(self, name\u003dNone, cmd\u003dNone):"},{"line_number":58,"context_line":"        if name is None:"},{"line_number":59,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":60,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_6adf9ed6","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":20},"updated":"2016-06-16 16:55:29.000000000","message":"It is unclear what does conjunction of \"execute\" and \"sync\" means. Meaning of \"name\" becomes clear after reading whole method only.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":55,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def execute_sync(self, name\u003dNone, cmd\u003dNone):"},{"line_number":58,"context_line":"        if name is None:"},{"line_number":59,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":60,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_e4056114","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":20},"in_reply_to":"7aa08908_6adf9ed6","updated":"2016-06-17 11:11:20.000000000","message":"Yes, the name does not make much sense now. Will change it to something more appropriate.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"b22d1c320f3af16dfd67829dace2e554346b457d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if name is None:"},{"line_number":59,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":60,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":61,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":62,"context_line":"        result \u003d self._inner_execute(cmd)"},{"line_number":63,"context_line":"        LOG.debug(\"Run result: %s.\", str(result))"},{"line_number":64,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":50,"id":"1aa78d24_d93747fd","line":61,"range":{"start_line":61,"start_character":14,"end_line":61,"end_character":50},"updated":"2016-07-06 14:35:45.000000000","message":"You have set the default value of cmd to None. So in case no cmd is passed to the execute method, this will result in\n\n[\"docker\", \"exec\", \"-i\", name] + None\n\nwhich will cause a TypeError because None can not be concatenated to a list.\n\nI think it would be a good idea to ensure that cmd is actually a list before doing this concatenation. Because as a caller of this method it is not unreasonable to think that cmd could also be a string (a single command without arguments).","commit_id":"6fc25192b1ada2989df8b3436a1cb3a8ae50aeca"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7a0853ed031aee227e6f8169d4aed32e32ebaa72","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if name is None:"},{"line_number":59,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":60,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":61,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":62,"context_line":"        result \u003d self._inner_execute(cmd)"},{"line_number":63,"context_line":"        LOG.debug(\"Run result: %s.\", str(result))"},{"line_number":64,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":50,"id":"1aa78d24_d4fee4ac","line":61,"range":{"start_line":61,"start_character":14,"end_line":61,"end_character":50},"in_reply_to":"1aa78d24_d93747fd","updated":"2016-07-06 17:22:49.000000000","message":"Well yes, one might try to call it with wrong parameters, but chances that someone would want to do it seem to be small. I\u0027ll add a check anyway.","commit_id":"6fc25192b1ada2989df8b3436a1cb3a8ae50aeca"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.init_execute_mixin()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def start_container(self, name\u003dNone):"},{"line_number":34,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":35,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":36,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":37,"context_line":"        # (aovchinnikov): --privileged is required for both samba and"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_151cce68","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":53},"updated":"2016-07-27 11:29:39.000000000","message":"If you expect empty value, then autogenerated should be unique. Please, use some unique-symbol sequence generator.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.init_execute_mixin()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def start_container(self, name\u003dNone):"},{"line_number":34,"context_line":"        name \u003d name or \"manila_cifs_docker_container\""},{"line_number":35,"context_line":"        image_name \u003d self.configuration.container_image_name"},{"line_number":36,"context_line":"        LOG.debug(\"Starting container from image %s.\", image_name)"},{"line_number":37,"context_line":"        # (aovchinnikov): --privileged is required for both samba and"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_defff3ff","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":53},"in_reply_to":"dada55a8_151cce68","updated":"2016-07-27 12:59:14.000000000","message":"Good point, will fix in the next PS.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":54,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":55,"context_line":"        if result[1] !\u003d \u0027\u0027:"},{"line_number":56,"context_line":"            raise exception.ManilaException("},{"line_number":57,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":58,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def execute(self, name\u003dNone, cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_909b46c9","line":57,"range":{"start_line":56,"start_character":11,"end_line":57,"end_character":70},"updated":"2016-07-28 11:43:20.000000000","message":"not covered by unit test..","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        cmd \u003d [\"docker\", \"stop\", name]"},{"line_number":54,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":55,"context_line":"        if result[1] !\u003d \u0027\u0027:"},{"line_number":56,"context_line":"            raise exception.ManilaException("},{"line_number":57,"context_line":"                _(\"Container %s has failed to stop properly.\") % name)"},{"line_number":58,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def execute(self, name\u003dNone, cmd\u003dNone):"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_eb3e17b7","line":57,"range":{"start_line":56,"start_character":11,"end_line":57,"end_character":70},"in_reply_to":"bacf61ea_909b46c9","updated":"2016-07-28 12:38:42.000000000","message":"Done","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def execute(self, name\u003dNone, cmd\u003dNone):"},{"line_number":61,"context_line":"        if name is None:"},{"line_number":62,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":63,"context_line":"        if cmd is None or (type(cmd) is not list):"},{"line_number":64,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":65,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":66,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":67,"context_line":"        result \u003d self._inner_execute(cmd)"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_d07c9e74","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":79},"updated":"2016-07-28 11:43:20.000000000","message":"not covered by unit tests..","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        LOG.info(_LI(\"Container %s is successfully stopped.\"), name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def execute(self, name\u003dNone, cmd\u003dNone):"},{"line_number":61,"context_line":"        if name is None:"},{"line_number":62,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":63,"context_line":"        if cmd is None or (type(cmd) is not list):"},{"line_number":64,"context_line":"            raise exception.ManilaException(_(\"Container name not specified.\"))"},{"line_number":65,"context_line":"        LOG.debug(\"Executing inside a container %s.\", name)"},{"line_number":66,"context_line":"        cmd \u003d [\"docker\", \"exec\", \"-i\", name] + cmd"},{"line_number":67,"context_line":"        result \u003d self._inner_execute(cmd)"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_8b74bb9c","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":79},"in_reply_to":"bacf61ea_d07c9e74","updated":"2016-07-28 12:38:42.000000000","message":"Done. Also the second exception message is plainly wrong -- done as well.","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a984f85b9881b5b203746de326a781adba61232","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":43,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":44,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":45,"context_line":"        if result[1] !\u003d \u0027\u0027:"},{"line_number":46,"context_line":"            raise exception.ManilaException("},{"line_number":47,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":48,"context_line":"        LOG.info(_LI(\"A container has been successfully started! Its id is \""},{"line_number":49,"context_line":"                     \"%s.\"), result[0].rstrip(\u0027\\n\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_2adc3472","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":62},"updated":"2016-07-31 21:34:33.000000000","message":"nit: to satisfy our coverage job, i suggest you unit test this too..\n\nhttp://logs.openstack.org/30/308930/72/check/manila-coverage-db-ubuntu-xenial/33618d1/cover/manila_share_drivers_container_container_helper_py.html","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cmd \u003d [\"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\","},{"line_number":43,"context_line":"               \"--name\u003d%s\" % name, \u0027-v\u0027, \"/tmp/shares:/shares\", image_name]"},{"line_number":44,"context_line":"        result \u003d self._inner_execute(cmd) or [\u0027\u0027, 1]"},{"line_number":45,"context_line":"        if result[1] !\u003d \u0027\u0027:"},{"line_number":46,"context_line":"            raise exception.ManilaException("},{"line_number":47,"context_line":"                _(\"Container %s has failed to start.\") % name)"},{"line_number":48,"context_line":"        LOG.info(_LI(\"A container has been successfully started! Its id is \""},{"line_number":49,"context_line":"                     \"%s.\"), result[0].rstrip(\u0027\\n\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_aef0f5c9","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":62},"in_reply_to":"bacf61ea_2adc3472","updated":"2016-08-02 08:04:37.000000000","message":"Done","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"}],"manila/share/drivers/container/driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df481fe91759b89a56b2fa4dc83cfe294c7ac12a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":93,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":94,"context_line":"            if helper is not None:"},{"line_number":95,"context_line":"                return helper(self.container,"},{"line_number":96,"context_line":"                              share\u003dshare,"},{"line_number":97,"context_line":"                              config\u003dself.configuration)"},{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)"},{"line_number":100,"context_line":"            return self._helpers[\"CIFS\"](self.container,"},{"line_number":101,"context_line":"                                         share\u003dshare,"},{"line_number":102,"context_line":"                                         config\u003dself.configuration)"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            raise exception.InvalidShare("},{"line_number":105,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_7e10d600","line":102,"range":{"start_line":95,"start_character":16,"end_line":102,"end_character":67},"updated":"2016-06-17 12:45:24.000000000","message":"Why you create new instance instead of making it stateless? It is too expensive approach.","commit_id":"f25db6cc94dbc2110ebe293bf81b4779a2c14510"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"9b33a96e7c4e57e5b8370f3aef2411fb8e65f9e3","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                  \"share server %(share_server)s.\","},{"line_number":159,"context_line":"                  {\"share_server\": share_server[\"id\"],"},{"line_number":160,"context_line":"                   \"share\": share.share_id})"},{"line_number":161,"context_line":"        self._get_helper(share).update_access(share_name, server_id,"},{"line_number":162,"context_line":"                                              access_rules, add_rules,"},{"line_number":163,"context_line":"                                              delete_rules)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_623d1bbb","line":161,"updated":"2016-07-05 03:27:37.000000000","message":"share_name is already in the instance of DockerCIFSHelper class. IMHO, it is better to remove share_name from the parameters of update_access. Just like create_share in line 130","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0b262b02cf83c2358a3427581ea1e27d5ad3d088","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                  \"share server %(share_server)s.\","},{"line_number":159,"context_line":"                  {\"share_server\": share_server[\"id\"],"},{"line_number":160,"context_line":"                   \"share\": share.share_id})"},{"line_number":161,"context_line":"        self._get_helper(share).update_access(share_name, server_id,"},{"line_number":162,"context_line":"                                              access_rules, add_rules,"},{"line_number":163,"context_line":"                                              delete_rules)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_5ea9cf7a","line":161,"in_reply_to":"1aa78d24_623d1bbb","updated":"2016-07-05 08:23:27.000000000","message":"Yes, this makes sense.","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"985106540bdc119a62ca5f1f9086ee40cf245c86","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":188,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":191,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":192,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":193,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_cfc5183d","line":190,"updated":"2016-07-05 02:49:22.000000000","message":"Will it support vLAN in this version?","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0b262b02cf83c2358a3427581ea1e27d5ad3d088","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":188,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":191,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"},{"line_number":192,"context_line":"        network_allocation \u003d network_info[\u0027network_allocations\u0027][0]"},{"line_number":193,"context_line":"        port_address \u003d network_allocation.ip_address"}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_bed39337","line":190,"in_reply_to":"1aa78d24_cfc5183d","updated":"2016-07-05 08:23:27.000000000","message":"As long as neutron supports it I believe the answer is yes.","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"}],"source_content_type":"text/x-python","patch_set":57,"id":"1aa78d24_9694aee8","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":37},"updated":"2016-07-15 12:39:22.000000000","message":"it is in uppercase in other drivers.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"}],"source_content_type":"text/x-python","patch_set":57,"id":"dada55a8_585d80e8","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":37},"in_reply_to":"1aa78d24_9694aee8","updated":"2016-07-18 17:49:34.000000000","message":"Done","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            server_id,"},{"line_number":143,"context_line":"            [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        LOG.debug(\"Deletion of share %s is complete!\", share.share_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":148,"context_line":"        self.storage.extend_share(share, new_size, share_server)"}],"source_content_type":"text/x-python","patch_set":57,"id":"1aa78d24_f68372a7","line":145,"range":{"start_line":145,"start_character":40,"end_line":145,"end_character":51},"updated":"2016-07-15 12:39:22.000000000","message":"has been completed?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            server_id,"},{"line_number":143,"context_line":"            [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        LOG.debug(\"Deletion of share %s is complete!\", share.share_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":148,"context_line":"        self.storage.extend_share(share, new_size, share_server)"}],"source_content_type":"text/x-python","patch_set":57,"id":"dada55a8_d869708d","line":145,"range":{"start_line":145,"start_character":40,"end_line":145,"end_character":51},"in_reply_to":"1aa78d24_f68372a7","updated":"2016-07-18 17:49:34.000000000","message":"is completed?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)"},{"line_number":100,"context_line":"            return self._helpers[\"CIFS\"](self.container,"},{"line_number":101,"context_line":"                                         share\u003dshare,"},{"line_number":102,"context_line":"                                         config\u003dself.configuration)"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            raise exception.InvalidShare("}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_956c3ed1","line":101,"range":{"start_line":101,"start_character":41,"end_line":101,"end_character":53},"updated":"2016-07-27 11:29:39.000000000","message":"IIRC, Clinton asked you to avoid usage of \"stateful\" helper, because it leads to concurrency issues.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            self._helpers[\"CIFS\"] \u003d importutils.import_class("},{"line_number":99,"context_line":"                self.configuration.container_protocol_helper)"},{"line_number":100,"context_line":"            return self._helpers[\"CIFS\"](self.container,"},{"line_number":101,"context_line":"                                         share\u003dshare,"},{"line_number":102,"context_line":"                                         config\u003dself.configuration)"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            raise exception.InvalidShare("}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_dea37341","line":101,"range":{"start_line":101,"start_character":41,"end_line":101,"end_character":53},"in_reply_to":"dada55a8_956c3ed1","updated":"2016-07-27 12:59:14.000000000","message":"As you can see new helper gets created each time some code requests for it: _helpers[\"CIFS\u0027] is but a helper class, not a helper instance, it has no state. Thus it does not cause concurrency issues. Please correct me if I am wrong.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _update_share_stats(self):"},{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_15b84e29","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":55},"updated":"2016-07-27 11:29:39.000000000","message":"Actually, this method \"reports\" driver\u0027s stats info.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _update_share_stats(self):"},{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_de7a53b9","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":55},"in_reply_to":"dada55a8_15b84e29","updated":"2016-07-27 12:59:14.000000000","message":"Good point, looks like it has slipped in from somewhere else.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_b2cb5871","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":37},"updated":"2016-07-27 11:29:39.000000000","message":"Why it is in lowercase?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":109,"context_line":"        data \u003d {"},{"line_number":110,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":111,"context_line":"            \u0027storage_protocol\u0027: \u0027cifs\u0027,"},{"line_number":112,"context_line":"            \u0027reserved_percentage\u0027:"},{"line_number":113,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":114,"context_line":"            \u0027consistency_group_support\u0027: None,"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_9e229bb7","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":37},"in_reply_to":"dada55a8_b2cb5871","updated":"2016-07-27 12:59:14.000000000","message":"Because some code somewhere does case sensitive comparison  and fails if it gets CIFS in uppercase? Update: ok, apparently now I know what is its problem. Will fix it for consistency.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"               default\u003d\"br-int\","},{"line_number":50,"context_line":"               required\u003dTrue,"},{"line_number":51,"context_line":"               help\u003d\"OVS bridge to use to plug a container to.\"),"},{"line_number":52,"context_line":"    cfg.StrOpt(\"container_cifs_guest_ok\","},{"line_number":53,"context_line":"               default\u003d\"yes\","},{"line_number":54,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":55,"context_line":"                    \"or not.\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\"container_image_name\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_90886624","line":53,"range":{"start_line":52,"start_character":15,"end_line":53,"end_character":28},"updated":"2016-07-28 11:43:20.000000000","message":"Valid values have to be specified as an enum for strings like this.. \n\nthis should be a bool opt..","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":49,"context_line":"               default\u003d\"br-int\","},{"line_number":50,"context_line":"               required\u003dTrue,"},{"line_number":51,"context_line":"               help\u003d\"OVS bridge to use to plug a container to.\"),"},{"line_number":52,"context_line":"    cfg.StrOpt(\"container_cifs_guest_ok\","},{"line_number":53,"context_line":"               default\u003d\"yes\","},{"line_number":54,"context_line":"               help\u003d\"Determines whether to allow guest access to CIFS share \""},{"line_number":55,"context_line":"                    \"or not.\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\"container_image_name\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_8b267bb8","line":53,"range":{"start_line":52,"start_character":15,"end_line":53,"end_character":28},"in_reply_to":"bacf61ea_90886624","updated":"2016-07-28 12:38:42.000000000","message":"Done","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            msg \u003d _(\"%s requires neutron_host_id to be \""},{"line_number":182,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":183,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":184,"context_line":"        elif host_id is None:"},{"line_number":185,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":186,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":189,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_d0581efd","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"updated":"2016-07-28 11:43:20.000000000","message":"You should not get into this situation if you set a default value (socket.gethostname()) \n\nAlso, this did not have any unit test coverage","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            msg \u003d _(\"%s requires neutron_host_id to be \""},{"line_number":182,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":183,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":184,"context_line":"        elif host_id is None:"},{"line_number":185,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":186,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":189,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_b0492a8e","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"in_reply_to":"bacf61ea_d0581efd","updated":"2016-07-28 12:38:42.000000000","message":"You should not attempt to automatically set things that could lead to hard to track down strange behaviors. That is the reason for not setting default value for neutron_host_id.\n\nYep, unit tests, will add in the next PS.","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":238,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":239,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":240,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":241,"context_line":"                continue"},{"line_number":242,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":243,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":244,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_d00f7edf","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":24},"updated":"2016-07-28 11:43:20.000000000","message":"not covered by unit test/s","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":238,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":239,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":240,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":241,"context_line":"                continue"},{"line_number":242,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":243,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":244,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_8b4ddb74","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":24},"in_reply_to":"bacf61ea_d00f7edf","updated":"2016-07-28 12:38:42.000000000","message":"Done","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._get_helper(share).delete_share(server_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.storage.remove_storage(share)"},{"line_number":140,"context_line":"        self.container.execute("},{"line_number":141,"context_line":"            server_id,"},{"line_number":142,"context_line":"            [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"        LOG.debug(\"Deletion of share %s is completed!\", share.share_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_7acd5384","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":9},"updated":"2016-08-01 07:00:42.000000000","message":"The code line 71 in container_helper.py. If delete share fail, it will return None, and the delete_share function will return successful, but actually the share is not deleted. Is it ok? or Did I missing something?\nhttps://review.openstack.org/#/c/308930/72/manila/share/drivers/container/container_helper.py","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._get_helper(share).delete_share(server_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.storage.remove_storage(share)"},{"line_number":140,"context_line":"        self.container.execute("},{"line_number":141,"context_line":"            server_id,"},{"line_number":142,"context_line":"            [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"        LOG.debug(\"Deletion of share %s is completed!\", share.share_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_0ed301d6","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":9},"in_reply_to":"bacf61ea_7acd5384","updated":"2016-08-02 08:04:37.000000000","message":"That is right, but let me point out that if recursive rm with force flag run as superuser fails inside a container this basically means that there are way more serious issues present than a single not properly deleted share. This probably means that a container providing shares is down and this has already caused problems someplace else. Also since the actual data has been removed by the storage helper there is no problem in having stray directory left in a non-operational container.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a984f85b9881b5b203746de326a781adba61232","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            msg \u003d _(\"%s requires neutron_host_id to be \""},{"line_number":182,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":183,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":184,"context_line":"        elif host_id is None:"},{"line_number":185,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":186,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":189,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_cad11859","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"updated":"2016-07-31 21:34:33.000000000","message":"Still not covered apparently: http://logs.openstack.org/30/308930/72/check/manila-coverage-db-ubuntu-xenial/33618d1/cover/manila_share_drivers_container_driver_py.html\n\nAlso, see my comment about marc\u0027s change assigning a default.. Why do you forecast strange errors by setting it to the hostname of the controller? What could go wrong, any thing in specific to this driver?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            msg \u003d _(\"%s requires neutron_host_id to be \""},{"line_number":182,"context_line":"                    \"specified.\") % neutron_class"},{"line_number":183,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":184,"context_line":"        elif host_id is None:"},{"line_number":185,"context_line":"            LOG.warning(_LW(\"neutron_host_id is not specified. This driver \""},{"line_number":186,"context_line":"                            \"might not work as expected without it.\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _connect_to_network(self, server_id, network_info, host_veth):"},{"line_number":189,"context_line":"        LOG.debug(\"Attempting to connect container to neutron network.\")"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_d13ce894","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"in_reply_to":"bacf61ea_cad11859","updated":"2016-08-02 08:04:37.000000000","message":"Please see my comment in the corresponding module. In short there could be issues with ad-hoc port binding for multinode clouds.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"af5a05c5d7bb7e4c2e9ffcd2ff7afaf45a9a53a7","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":241,"context_line":"                continue"},{"line_number":242,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":243,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":244,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":245,"context_line":"                              self.configuration.container_ovs_bridge_name,"},{"line_number":246,"context_line":"                              veth, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_1a91b747","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":41},"updated":"2016-08-01 07:00:42.000000000","message":"LOG.debug(\"Deleting veth %s.\", veth)","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":241,"context_line":"                continue"},{"line_number":242,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":243,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":244,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":245,"context_line":"                              self.configuration.container_ovs_bridge_name,"},{"line_number":246,"context_line":"                              veth, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_5438e6d2","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":41},"in_reply_to":"bacf61ea_1a91b747","updated":"2016-08-02 08:04:37.000000000","message":"Done","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d571b68c561c7111c1a96746968783f6a8be553c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            \u0027lb\u0027: self.configuration.container_linux_bridge_name,"},{"line_number":205,"context_line":"            \u0027ovsb\u0027: self.configuration.container_ovs_bridge_name,"},{"line_number":206,"context_line":"            \u0027ip\u0027: port_address,"},{"line_number":207,"context_line":"            \u0027subnet\u0027: network_info[\u0027neutron_subnet_id\u0027]"},{"line_number":208,"context_line":"        }"},{"line_number":209,"context_line":"        LOG.debug(\"Container %(id)s veth is %(veth)s.\", msg_helper)"},{"line_number":210,"context_line":"        LOG.debug(\"Removing %(veth)s from %(lb)s.\", msg_helper)"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_c183bd54","line":207,"range":{"start_line":207,"start_character":53,"end_line":207,"end_character":55},"updated":"2016-08-11 02:09:04.000000000","message":"trailing comma","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            \u0027lb\u0027: self.configuration.container_linux_bridge_name,"},{"line_number":205,"context_line":"            \u0027ovsb\u0027: self.configuration.container_ovs_bridge_name,"},{"line_number":206,"context_line":"            \u0027ip\u0027: port_address,"},{"line_number":207,"context_line":"            \u0027subnet\u0027: network_info[\u0027neutron_subnet_id\u0027]"},{"line_number":208,"context_line":"        }"},{"line_number":209,"context_line":"        LOG.debug(\"Container %(id)s veth is %(veth)s.\", msg_helper)"},{"line_number":210,"context_line":"        LOG.debug(\"Removing %(veth)s from %(lb)s.\", msg_helper)"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_04be7964","line":207,"range":{"start_line":207,"start_character":53,"end_line":207,"end_character":55},"in_reply_to":"9ad45d7e_c183bd54","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"}],"manila/share/drivers/container/protocol_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DockerCIFSHelper(object):"},{"line_number":28,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":29,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":30,"context_line":"        self.share \u003d None or kwargs.get(\"share\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_c7b72538","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":31},"updated":"2016-04-29 13:01:28.000000000","message":"You may want to use abstract class for all helpers. Because they will have common interface.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DockerCIFSHelper(object):"},{"line_number":28,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":29,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":30,"context_line":"        self.share \u003d None or kwargs.get(\"share\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_6ef2f39b","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":31},"in_reply_to":"1a122d0e_c7b72538","updated":"2016-05-04 12:26:36.000000000","message":"Yes, but since we have only one helper so far I prefer to postpone interface separation to a later change.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class DockerCIFSHelper(object):"},{"line_number":28,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":29,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":30,"context_line":"        self.share \u003d None or kwargs.get(\"share\")"},{"line_number":31,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":32,"context_line":"        self.container \u003d container_helper"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_2c6ebeff","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":48},"updated":"2016-04-29 13:01:28.000000000","message":"Very interesting coding ))","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class DockerCIFSHelper(object):"},{"line_number":28,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":29,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":30,"context_line":"        self.share \u003d None or kwargs.get(\"share\")"},{"line_number":31,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":32,"context_line":"        self.container \u003d container_helper"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_0e3a5f34","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":48},"in_reply_to":"1a122d0e_2c6ebeff","updated":"2016-05-04 12:26:36.000000000","message":"Yes, very unusual indeed!","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            server_id,"},{"line_number":57,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":58,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":59,"context_line":"        location \u003d \u0027\\\\\\\\\u0027 + result + \u0027\\\\\u0027 + \"/shares/%s\" % share_name"},{"line_number":60,"context_line":"        return location"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_c71ba571","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":69},"updated":"2016-04-29 13:01:28.000000000","message":"It should be \u0027//%s/%s\u0027\n\nCommunity agreement.\n\nExample:\nhttps://github.com/openstack/manila/blob/9a9bc9ca/manila/share/drivers/helpers.py#L476","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            server_id,"},{"line_number":57,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":58,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":59,"context_line":"        location \u003d \u0027\\\\\\\\\u0027 + result + \u0027\\\\\u0027 + \"/shares/%s\" % share_name"},{"line_number":60,"context_line":"        return location"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_0e689f20","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":69},"in_reply_to":"1a122d0e_c71ba571","updated":"2016-05-04 12:26:36.000000000","message":"Right, will fix this.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      access_level):"},{"line_number":88,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":89,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":90,"context_line":"                raise exception.ManilaException(_(\"Can\u0027t provide \u0027ro\u0027 access\""},{"line_number":91,"context_line":"                                                  \"for guest.\"))"},{"line_number":92,"context_line":"            LOG.debug(\"Host is accessible for reading data.\")"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_e751810f","line":91,"range":{"start_line":90,"start_character":51,"end_line":91,"end_character":61},"updated":"2016-04-29 13:01:28.000000000","message":"For whom?","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      access_level):"},{"line_number":88,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":89,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":90,"context_line":"                raise exception.ManilaException(_(\"Can\u0027t provide \u0027ro\u0027 access\""},{"line_number":91,"context_line":"                                                  \"for guest.\"))"},{"line_number":92,"context_line":"            LOG.debug(\"Host is accessible for reading data.\")"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_eeb5637e","line":91,"range":{"start_line":90,"start_character":51,"end_line":91,"end_character":61},"in_reply_to":"1a122d0e_e751810f","updated":"2016-05-04 12:26:36.000000000","message":"For guest? A share ID is needed here, though. Oh, I see what you mean, will fix this.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":90,"context_line":"                raise exception.ManilaException(_(\"Can\u0027t provide \u0027ro\u0027 access\""},{"line_number":91,"context_line":"                                                  \"for guest.\"))"},{"line_number":92,"context_line":"            LOG.debug(\"Host is accessible for reading data.\")"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":95,"context_line":"            allowed_hosts \u003d self.container.execute_sync("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_87436d41","line":92,"range":{"start_line":92,"start_character":23,"end_line":92,"end_character":59},"updated":"2016-04-29 13:01:28.000000000","message":"For whom?","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":90,"context_line":"                raise exception.ManilaException(_(\"Can\u0027t provide \u0027ro\u0027 access\""},{"line_number":91,"context_line":"                                                  \"for guest.\"))"},{"line_number":92,"context_line":"            LOG.debug(\"Host is accessible for reading data.\")"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":95,"context_line":"            allowed_hosts \u003d self.container.execute_sync("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_19aaa7d2","line":92,"range":{"start_line":92,"start_character":23,"end_line":92,"end_character":59},"in_reply_to":"1a122d0e_87436d41","updated":"2016-05-04 12:26:36.000000000","message":"Ditto.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                server_id,"},{"line_number":53,"context_line":"                [\"net\", \"conf\", \"setparm\", share_name, param, value]"},{"line_number":54,"context_line":"            )"},{"line_number":55,"context_line":"        result \u003d self.container.execute_sync("},{"line_number":56,"context_line":"            server_id,"},{"line_number":57,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":58,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":59,"context_line":"        location \u003d \"\\\\\\\\%(addr)s\\\\/shares/%(name)s\" % {\"addr\": result,"},{"line_number":60,"context_line":"                                                       \"name\": share_name}"},{"line_number":61,"context_line":"        return location"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_d7726010","line":60,"range":{"start_line":55,"start_character":8,"end_line":60,"end_character":74},"updated":"2016-05-20 22:32:46.000000000","message":"This is how the location looked in my test:\n\n  \\\\    inet 10.0.0.9/8 brd 10.255.255.255 scope global eth0\\/shares/18d2e929-e4c7-42c0-a0da-4db5c685c373\n\nSeems like something went wrong with the result parsing.\nI think it could be easier to retrieve the address using \u0027docker inspect\u0027.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                server_id,"},{"line_number":53,"context_line":"                [\"net\", \"conf\", \"setparm\", share_name, param, value]"},{"line_number":54,"context_line":"            )"},{"line_number":55,"context_line":"        result \u003d self.container.execute_sync("},{"line_number":56,"context_line":"            server_id,"},{"line_number":57,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":58,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":59,"context_line":"        location \u003d \"\\\\\\\\%(addr)s\\\\/shares/%(name)s\" % {\"addr\": result,"},{"line_number":60,"context_line":"                                                       \"name\": share_name}"},{"line_number":61,"context_line":"        return location"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_facc04bd","line":60,"range":{"start_line":55,"start_character":8,"end_line":60,"end_character":74},"in_reply_to":"bab6814e_d7726010","updated":"2016-05-25 09:45:43.000000000","message":"Done","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                server_id,"},{"line_number":137,"context_line":"                [\"net\", \"conf\", \"setparm\", share_name, \"hosts allow\", \"\"]"},{"line_number":138,"context_line":"            )"},{"line_number":139,"context_line":"            for rule in (access_rules or []):"},{"line_number":140,"context_line":"                host_to_allow \u003d rule[\u0027access_to\u0027]"},{"line_number":141,"context_line":"                access_level \u003d rule[\u0027access_level\u0027]"},{"line_number":142,"context_line":"                access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":143,"context_line":"                if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":144,"context_line":"                    self._allow_access(share_name, server_id, host_to_allow,"},{"line_number":145,"context_line":"                                       access_level)"},{"line_number":146,"context_line":"                elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":147,"context_line":"                    self._allow_user_access(share_name, server_id,"},{"line_number":148,"context_line":"                                            rule[\u0027access_to\u0027], access_level)"},{"line_number":149,"context_line":"                else:"},{"line_number":150,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":151,"context_line":"                            \"driver.\") % access_type"},{"line_number":152,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":"        for rule in add_rules:"},{"line_number":155,"context_line":"            host_to_allow \u003d rule[\u0027access_to\u0027]"},{"line_number":156,"context_line":"            access_level \u003d rule[\u0027access_level\u0027]"},{"line_number":157,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":158,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":159,"context_line":"                self._allow_access(share_name, server_id, host_to_allow,"},{"line_number":160,"context_line":"                                   access_level)"},{"line_number":161,"context_line":"            elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":162,"context_line":"                self._allow_user_access(share_name, server_id,"},{"line_number":163,"context_line":"                                        rule[\u0027access_to\u0027], access_level)"},{"line_number":164,"context_line":"            else:"},{"line_number":165,"context_line":"                msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":166,"context_line":"                        \"driver.\") % access_type"},{"line_number":167,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":168,"context_line":"        for rule in delete_rules:"},{"line_number":169,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":170,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_e2ab6473","line":167,"range":{"start_line":139,"start_character":12,"end_line":167,"end_character":62},"updated":"2016-05-20 22:32:46.000000000","message":"Code duplication in these two for loops.\nI think it would be best to move the code into a common private method.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                server_id,"},{"line_number":137,"context_line":"                [\"net\", \"conf\", \"setparm\", share_name, \"hosts allow\", \"\"]"},{"line_number":138,"context_line":"            )"},{"line_number":139,"context_line":"            for rule in (access_rules or []):"},{"line_number":140,"context_line":"                host_to_allow \u003d rule[\u0027access_to\u0027]"},{"line_number":141,"context_line":"                access_level \u003d rule[\u0027access_level\u0027]"},{"line_number":142,"context_line":"                access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":143,"context_line":"                if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":144,"context_line":"                    self._allow_access(share_name, server_id, host_to_allow,"},{"line_number":145,"context_line":"                                       access_level)"},{"line_number":146,"context_line":"                elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":147,"context_line":"                    self._allow_user_access(share_name, server_id,"},{"line_number":148,"context_line":"                                            rule[\u0027access_to\u0027], access_level)"},{"line_number":149,"context_line":"                else:"},{"line_number":150,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":151,"context_line":"                            \"driver.\") % access_type"},{"line_number":152,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":"        for rule in add_rules:"},{"line_number":155,"context_line":"            host_to_allow \u003d rule[\u0027access_to\u0027]"},{"line_number":156,"context_line":"            access_level \u003d rule[\u0027access_level\u0027]"},{"line_number":157,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"},{"line_number":158,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":159,"context_line":"                self._allow_access(share_name, server_id, host_to_allow,"},{"line_number":160,"context_line":"                                   access_level)"},{"line_number":161,"context_line":"            elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":162,"context_line":"                self._allow_user_access(share_name, server_id,"},{"line_number":163,"context_line":"                                        rule[\u0027access_to\u0027], access_level)"},{"line_number":164,"context_line":"            else:"},{"line_number":165,"context_line":"                msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":166,"context_line":"                        \"driver.\") % access_type"},{"line_number":167,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":168,"context_line":"        for rule in delete_rules:"},{"line_number":169,"context_line":"            host_to_deny \u003d rule[\u0027access_to\u0027]"},{"line_number":170,"context_line":"            access_type \u003d rule[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_dab940ee","line":167,"range":{"start_line":139,"start_character":12,"end_line":167,"end_character":62},"in_reply_to":"bab6814e_e2ab6473","updated":"2016-05-25 09:45:43.000000000","message":"Done","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_ea0a6e1f","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"updated":"2016-06-16 16:55:29.000000000","message":"Instead of saying \"\u0027RO\u0027 IP-based rules are not supported\" you just silently ignore it. I think it is incorrect.\n\nAlso, not sure we should allow both types at once.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"3cbe726a5260473917e6f4909a885c4f10451f8b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_a5c6ad99","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"in_reply_to":"7aa08908_530516c0","updated":"2016-06-17 12:22:23.000000000","message":"That\u0027s how \u0027guest_ok\u0027 is supposed to work. Do you want a ro access? Is it allowed for everybody to browse around? If both are \u0027yes\u0027 nothing else should be done. However the message is unclear for the case when guests are not allowed.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"4fa6ea0eb72f9d2b922bda62f09244aed7d4850b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_7e3c56e1","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"in_reply_to":"7aa08908_5ed35a38","updated":"2016-06-17 12:55:29.000000000","message":"If requested access level is ro and if guest ok then do nothing and return; if guest not ok then raise. It looks like I am missing the point where request for ro allows rw to a guest.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db0146ae0fdf3fe61f69db208c5d7564cb93ef4d","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_530516c0","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"in_reply_to":"7aa08908_8453ba15","updated":"2016-06-17 11:36:04.000000000","message":"\"No\"? You make \"return\" not making changes to CIFS. It means \"yes, ignored\".","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"13967b029ac677b20f753ce0d0b031e8cd7d70b2","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_5ed35a38","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"in_reply_to":"7aa08908_a5c6ad99","updated":"2016-06-17 12:45:34.000000000","message":"\"guest_ok\" is related to \"user\" access. This method is called only on \"IP\" rules. And IP rules can be set as either RO or RW, but only one case per share is allowed.\n\nSo, if I allowed guest and wanted to make only RO access from some IP for it, then current code still will provide me RW access.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _allow_access(self, share_name, server_id, host_to_allow,"},{"line_number":90,"context_line":"                      access_level):"},{"line_number":91,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":92,"context_line":"            msg_dict \u003d {\"host\": host_to_allow, \"share\": share_name}"},{"line_number":93,"context_line":"            if self.conf.container_cifs_guest_ok !\u003d \"yes\":"},{"line_number":94,"context_line":"                raise exception.ManilaException("},{"line_number":95,"context_line":"                    _(\"Can\u0027t provide \u0027ro\u0027 access for %(host)s to %(share)s.\") %"},{"line_number":96,"context_line":"                    msg_dict)"},{"line_number":97,"context_line":"            LOG.debug(\"Share %(share)s is accessible for %(host)s for reading \""},{"line_number":98,"context_line":"                      \"data.\" % msg_dict)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":101,"context_line":"            allowed_hosts \u003d self.container.execute_sync("},{"line_number":102,"context_line":"                server_id,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_8453ba15","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":18},"in_reply_to":"7aa08908_ea0a6e1f","updated":"2016-06-17 11:11:20.000000000","message":"No. ro IP-based rules are supported, but not allowed. Thus the message lacks an explanation why manila can\u0027t provide access. I\u0027ll add it.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _allow_user_access(self, share_name, server_id, user_to_allow,"},{"line_number":120,"context_line":"                           access_level):"},{"line_number":121,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":122,"context_line":"            access \u003d \u0027read list\u0027"},{"line_number":123,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":124,"context_line":"            access \u003d \u0027valid users\u0027"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":127,"context_line":"        self.container.execute_sync("},{"line_number":128,"context_line":"            server_id,"},{"line_number":129,"context_line":"            [\"net\", \"conf\", \"setparm\", share_name, access,"},{"line_number":130,"context_line":"             user_to_allow]"},{"line_number":131,"context_line":"        )"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_access(self, share_name, server_id, access_rules,"},{"line_number":134,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_cf9fc463","line":131,"range":{"start_line":121,"start_character":8,"end_line":131,"end_character":9},"updated":"2016-06-16 16:55:29.000000000","message":"Are you sure it extends existing list and not overrides it? Have you tested access by two different users at the same time?","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _allow_user_access(self, share_name, server_id, user_to_allow,"},{"line_number":120,"context_line":"                           access_level):"},{"line_number":121,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":122,"context_line":"            access \u003d \u0027read list\u0027"},{"line_number":123,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":124,"context_line":"            access \u003d \u0027valid users\u0027"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":127,"context_line":"        self.container.execute_sync("},{"line_number":128,"context_line":"            server_id,"},{"line_number":129,"context_line":"            [\"net\", \"conf\", \"setparm\", share_name, access,"},{"line_number":130,"context_line":"             user_to_allow]"},{"line_number":131,"context_line":"        )"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_access(self, share_name, server_id, access_rules,"},{"line_number":134,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_07698c8c","line":131,"range":{"start_line":121,"start_character":8,"end_line":131,"end_character":9},"in_reply_to":"7aa08908_cf9fc463","updated":"2016-06-17 11:11:20.000000000","message":"Good catch, thank you!","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"f9155d7d490c9f49f6ee9fa3ff91b096c2752f50","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        location \u003d \"\\\\\\\\%(addr)s\\\\/shares/%(name)s\" % {\"addr\": address,"},{"line_number":60,"context_line":"                                                       \"name\": share_name}"},{"line_number":61,"context_line":"        return location"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def delete_share(self, server_id):"},{"line_number":64,"context_line":"        self.container.execute("}],"source_content_type":"text/x-python","patch_set":54,"id":"1aa78d24_278d6ad3","line":61,"range":{"start_line":59,"start_character":8,"end_line":61,"end_character":23},"updated":"2016-07-12 19:03:31.000000000","message":"return r\u0027\\\\%s\\%s\u0027 % (address, share_name)","commit_id":"4c3a819ff225266dd6722d1ade667afaa1d94f1a"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"1a4ec86b659d1e0659590d121d633f9892d78093","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        location \u003d \"\\\\\\\\%(addr)s\\\\/shares/%(name)s\" % {\"addr\": address,"},{"line_number":60,"context_line":"                                                       \"name\": share_name}"},{"line_number":61,"context_line":"        return location"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def delete_share(self, server_id):"},{"line_number":64,"context_line":"        self.container.execute("}],"source_content_type":"text/x-python","patch_set":54,"id":"1aa78d24_ba5d9617","line":61,"range":{"start_line":59,"start_character":8,"end_line":61,"end_character":23},"in_reply_to":"1aa78d24_278d6ad3","updated":"2016-07-14 06:24:27.000000000","message":"I don\u0027t think it is a good idea to remove explicit substitution.","commit_id":"4c3a819ff225266dd6722d1ade667afaa1d94f1a"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"953f05652ccf73f73b339921826a1c16899bfca5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        return r\"\\\\%(addr)s\\/shares/%(name)s\" % {\"addr\": address,"},{"line_number":60,"context_line":"                                                 \"name\": share_name}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":56,"id":"1aa78d24_ac6396dc","line":59,"updated":"2016-07-14 12:35:51.000000000","message":"That wasn\u0027t the point of my comment. If you like the substitution then change it to:\n\n return r\u0027\\\\%(addr)s\\%(name)s\u0027 % {\"addr\": address, \"name\": share_name}\n\nThs point is that the \"/shares/\" should be removed.","commit_id":"875c5776ee2aeb9ceabc6f98163dae81cb9e1ef1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d2a019e0b9b2cb09711b9c8a0a0afd5f5e6e0677","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        return r\"\\\\%(addr)s\\/shares/%(name)s\" % {\"addr\": address,"},{"line_number":60,"context_line":"                                                 \"name\": share_name}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, server_id):"}],"source_content_type":"text/x-python","patch_set":56,"id":"1aa78d24_4c1032ac","line":59,"in_reply_to":"1aa78d24_ac6396dc","updated":"2016-07-14 12:46:07.000000000","message":"Oh, I see. Will remove it in the next patch.","commit_id":"875c5776ee2aeb9ceabc6f98163dae81cb9e1ef1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class DockerCIFSHelper(object):"},{"line_number":29,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":30,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":31,"context_line":"        self.share \u003d kwargs.get(\"share\")"},{"line_number":32,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":33,"context_line":"        self.container \u003d container_helper"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_d5c6b698","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":40},"updated":"2016-07-27 11:29:39.000000000","message":"Why do you use stateful approach?","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class DockerCIFSHelper(object):"},{"line_number":29,"context_line":"    def __init__(self, container_helper, *args, **kwargs):"},{"line_number":30,"context_line":"        super(DockerCIFSHelper, self).__init__()"},{"line_number":31,"context_line":"        self.share \u003d kwargs.get(\"share\")"},{"line_number":32,"context_line":"        self.conf \u003d kwargs.get(\"config\")"},{"line_number":33,"context_line":"        self.container \u003d container_helper"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_bedddfe1","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":40},"in_reply_to":"dada55a8_d5c6b698","updated":"2016-07-27 12:59:14.000000000","message":"State exists per request for helper, so this should not cause problems.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \"/shares/%s\" % share_name, \"writeable\u003dy\"]"},{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok \u003d\u003d \"yes\":"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_50c9ce77","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":36},"updated":"2016-07-28 11:43:20.000000000","message":"not covered by tests..","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \"/shares/%s\" % share_name, \"writeable\u003dy\"]"},{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok \u003d\u003d \"yes\":"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_dd5b1653","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_50c9ce77","updated":"2016-07-28 12:38:42.000000000","message":"Yes it is. Please consider manila/tests/share/drivers/container/test_protocol_helper.DockerCIFSHelperTestCase.test_create_share_guest_not_ok","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a984f85b9881b5b203746de326a781adba61232","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_aad6644c","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"updated":"2016-07-31 21:34:33.000000000","message":"something strange is happening with mocked config values.. why not just mock the ones you want and test it, rather than using test_utils.create_temp_config_with_opts?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_d49a1613","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_aad6644c","updated":"2016-08-02 08:04:37.000000000","message":"I am not using  test_utils.create_temp_config_with_opts in this particular case.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa1b15df9d3f408c09983a9ead37e7f0385871f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_eaccdcbc","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_aad6644c","updated":"2016-07-31 21:35:34.000000000","message":"something strange wrt to unit tests.. could you check the coverage report and help determine the issue: http://logs.openstack.org/30/308930/72/check/manila-coverage-db-ubuntu-xenial/33618d1/cover/manila_share_drivers_container_protocol_helper_py.html","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_547586c8","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_eaccdcbc","updated":"2016-08-02 08:04:37.000000000","message":"Ok, I\u0027ll check this out.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"514252a68270d4aa263a93731dfc424f6b46fcf3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        return r\"\\\\%(addr)s\\%(name)s\" % {\"addr\": address, \"name\": share_name}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def delete_share(self, server_id):"},{"line_number":62,"context_line":"        self.container.execute("}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_afeadd71","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":77},"updated":"2016-08-01 12:43:58.000000000","message":"I am not a SMB guy, but shouldn\u0027t CIFS shares be r\"//%(adds)s/%(name)s\"?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            [\"ip\", \"addr\", \"show\", \"eth0\"]"},{"line_number":57,"context_line":"        )[0].split(\u0027\\n\u0027)[2]"},{"line_number":58,"context_line":"        address \u003d re.findall(\"\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\", result)[0]"},{"line_number":59,"context_line":"        return r\"\\\\%(addr)s\\%(name)s\" % {\"addr\": address, \"name\": share_name}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def delete_share(self, server_id):"},{"line_number":62,"context_line":"        self.container.execute("}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_b42e82a2","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":77},"in_reply_to":"bacf61ea_afeadd71","updated":"2016-08-02 08:04:37.000000000","message":"You are right, thank you for pointing this out.","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"287bfb60eb48c5a576f648cb34b2ca028298fb80","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_6924775f","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":66},"updated":"2016-08-01 04:10:57.000000000","message":"This check should not raise an exception in the delete path. If it does, you may never be able to remove a bad rule.. \n\nTry:\ni. Add an IP access rule\nii. Remove the access rule you just added","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"26f81b7070aa3d3c22b81c43d6e96bfe9ef84fcf","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":72,"id":"bacf61ea_3459f28e","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":66},"in_reply_to":"bacf61ea_6924775f","updated":"2016-08-02 08:04:37.000000000","message":"How exactly a rule with bad access type could appear when all rules are checked by this very code above before being added?","commit_id":"ec43bfb4b428f504432750e2959d60bd2e1fc5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d441d149f79f26d8ea0615aa7e1fbfa04eaf7568","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":73,"id":"bacf61ea_8e2fdf3d","line":127,"range":{"start_line":125,"start_character":20,"end_line":127,"end_character":66},"updated":"2016-08-02 12:38:57.000000000","message":"response to your response in Patchset 72: \nhttps://review.openstack.org/#/c/308930/72..73/manila/share/drivers/container/protocol_helper.py\n\nThe \"bad\" rule does not get added; the driver sets the rule status to ``error``. If you try to delete it, however, using ``manila access-deny``, you will run into this issue, and the rule is set to ``error_deleting``. So, no matter what the issue is, the delete path should allow deletion of rules, even if they haven\u0027t been applied... \n\nTry:\ni. Add an IP access rule\nii. Remove the access rule you just added","commit_id":"a38a53385741448b5c91979a7d8fcfbe6e58d480"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9a1e8e1aee50390345052ff32453de69e8220dd1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":73,"id":"bacf61ea_2013500f","line":127,"range":{"start_line":125,"start_character":20,"end_line":127,"end_character":66},"in_reply_to":"bacf61ea_2ff50acb","updated":"2016-08-02 16:12:10.000000000","message":"Oh, I get it now. Makes sense, will fix in the next PS.","commit_id":"a38a53385741448b5c91979a7d8fcfbe6e58d480"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b2379d7be04ce2f367909c7e0e1d7576c3f27dd1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":73,"id":"bacf61ea_91025e08","line":127,"range":{"start_line":125,"start_character":20,"end_line":127,"end_character":66},"in_reply_to":"bacf61ea_8e2fdf3d","updated":"2016-08-02 12:57:00.000000000","message":"The driver does not set it to \u0027error\u0027, it just raises. So it is not the driver, who loses access_type. Am I wrong?","commit_id":"a38a53385741448b5c91979a7d8fcfbe6e58d480"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79a7da8a5c0ea51566247b2ec0e8f64b8e5bac4b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    action(share_name, server_id, rule[\u0027access_to\u0027],"},{"line_number":123,"context_line":"                           access_level)"},{"line_number":124,"context_line":"                else:"},{"line_number":125,"context_line":"                    msg \u003d _(\"Access type \u0027%s\u0027 is not supported by the \""},{"line_number":126,"context_line":"                            \"driver.\") % access_type"},{"line_number":127,"context_line":"                    raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        share_name \u003d self.share.share_id"},{"line_number":130,"context_line":"        if not (add_rules or delete_rules):"}],"source_content_type":"text/x-python","patch_set":73,"id":"bacf61ea_2ff50acb","line":127,"range":{"start_line":125,"start_character":20,"end_line":127,"end_character":66},"in_reply_to":"bacf61ea_91025e08","updated":"2016-08-02 13:58:24.000000000","message":"Yep.. raising this would set this to \u0027error\u0027.. but remember that the share manager does not know *why* something is set to \u0027error\u0027; so when an update_access call is made again, this rule will be there; either in add_rules (retry logic) or in delete_rules or in access_rules.","commit_id":"a38a53385741448b5c91979a7d8fcfbe6e58d480"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"428c46553631de51750bce905a32e1fca9aa3ef2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.warning(_LW(\"Can\u0027t access smbd at share %s.\") % share_name)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            allowed_users \u003d existing_users.replace(user_to_deny, \"\")"},{"line_number":112,"context_line":"        self._set_users(server_id, share_name, access, allowed_users)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def update_access(self, server_id, access_rules,"},{"line_number":115,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"}],"source_content_type":"text/x-python","patch_set":74,"id":"9ad45d7e_08c6da99","line":112,"range":{"start_line":111,"start_character":12,"end_line":112,"end_character":69},"updated":"2016-08-10 00:40:54.000000000","message":"I have two problems with this approach:\n\n1) What if you have this as your list of users:\n\n    \"openstack_u, openstack_u2, openstacku3\"\n\n    and you want to deny access to openstack_u..\n\nSo, no, don\u0027t use string replace, use split and match instead..  \n\n2) What if there\u0027s nothing to replace; i.e, the user was never added (ex: A bad rule was added previously, say an IP based rule and you\u0027re in the deny path?\n\nWe will unnecessarily call smb net conf setparm... \n\nCould you please fix this?","commit_id":"8b90d62b26ad98aa78f8995656dbc3034397d191"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"208df8d5b06e356aaeeb1ce6e0ed1f4f0c200614","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.warning(_LW(\"Can\u0027t access smbd at share %s.\") % share_name)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            allowed_users \u003d existing_users.replace(user_to_deny, \"\")"},{"line_number":112,"context_line":"        self._set_users(server_id, share_name, access, allowed_users)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def update_access(self, server_id, access_rules,"},{"line_number":115,"context_line":"                      add_rules\u003dNone, delete_rules\u003dNone):"}],"source_content_type":"text/x-python","patch_set":74,"id":"9ad45d7e_8a861ed9","line":112,"range":{"start_line":111,"start_character":12,"end_line":112,"end_character":69},"in_reply_to":"9ad45d7e_08c6da99","updated":"2016-08-10 13:55:32.000000000","message":"Ok.","commit_id":"8b90d62b26ad98aa78f8995656dbc3034397d191"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f2750b34ad7756f4a6e5f6d9782fdbec216e2bf2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.warning(_LW(\"Can\u0027t access smbd at share %s.\") % share_name)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            allowed_users \u003d \" \".join(set(existing_users.split()) -"},{"line_number":112,"context_line":"                                     set([user_to_deny]))"},{"line_number":113,"context_line":"            if allowed_users !\u003d existing_users:"},{"line_number":114,"context_line":"                self._set_users(server_id, share_name, access, allowed_users)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":75,"id":"9ad45d7e_c5f76989","line":112,"range":{"start_line":111,"start_character":12,"end_line":112,"end_character":57},"updated":"2016-08-10 14:08:00.000000000","message":"?\n\nPlease add a unit test with multiple users.. This doesn\u0027t work:\n\n \u003e\u003e\u003e users \u003d \"openstack_u, openstack_u2, openstacku3\"\n \u003e\u003e\u003e \" \".join(set(users.split()) - set([\"openstack_u2\"]))\n\n \u0027openstack_u, openstack_u2, openstacku3\u0027\n\n \nopenstack_u2 was supposed to be denied access...","commit_id":"bc1bb0fda6de5075be4633b43bf80be63e7dae26"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca2cacca811f75e97e2d98f0108da1bb7ab81c3e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.warning(_LW(\"Can\u0027t access smbd at share %s.\") % share_name)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            allowed_users \u003d \" \".join(set(existing_users.split()) -"},{"line_number":112,"context_line":"                                     set([user_to_deny]))"},{"line_number":113,"context_line":"            if allowed_users !\u003d existing_users:"},{"line_number":114,"context_line":"                self._set_users(server_id, share_name, access, allowed_users)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":75,"id":"9ad45d7e_8b1f366b","line":112,"range":{"start_line":111,"start_character":12,"end_line":112,"end_character":57},"in_reply_to":"9ad45d7e_6b764207","updated":"2016-08-10 17:28:09.000000000","message":"okay.. works for me","commit_id":"bc1bb0fda6de5075be4633b43bf80be63e7dae26"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f162a51b8ab746bcdd26b96d32959f1a52a2e45a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.warning(_LW(\"Can\u0027t access smbd at share %s.\") % share_name)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            allowed_users \u003d \" \".join(set(existing_users.split()) -"},{"line_number":112,"context_line":"                                     set([user_to_deny]))"},{"line_number":113,"context_line":"            if allowed_users !\u003d existing_users:"},{"line_number":114,"context_line":"                self._set_users(server_id, share_name, access, allowed_users)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":75,"id":"9ad45d7e_6b764207","line":112,"range":{"start_line":111,"start_character":12,"end_line":112,"end_character":57},"in_reply_to":"9ad45d7e_c5f76989","updated":"2016-08-10 17:26:11.000000000","message":"There are two ways users can be separated, without comma and with comma. This implementation uses comma-free option. So the only way to get commas in userlist is to intervene in normal drivers activity.","commit_id":"bc1bb0fda6de5075be4633b43bf80be63e7dae26"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"11e8ac4f3d54c0100a69a8acf07c8f22aa9c718d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \"/shares/%s\" % share_name, \"writeable\u003dy\"]"},{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_4156ad5c","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":36},"updated":"2016-08-11 02:21:49.000000000","message":"This block wasn\u0027t covered by a unit test.","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \"/shares/%s\" % share_name, \"writeable\u003dy\"]"},{"line_number":39,"context_line":"        if self.conf.container_cifs_guest_ok:"},{"line_number":40,"context_line":"            cmd.append(\"guest_ok\u003dy\")"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cmd.append(\"guest_ok\u003dn\")"},{"line_number":43,"context_line":"        self.container.execute(server_id, cmd)"},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            \"browseable\": \"yes\","}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_674ad727","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"9ad45d7e_4156ad5c","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"}],"manila/share/drivers/container/storage_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"lv_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\"container_volume_group\","},{"line_number":28,"context_line":"               default\u003d\"manila_docker_volumes\","},{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes.\"),"},{"line_number":30,"context_line":"    cfg.StrOpt(\"container_lv_size\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_4ce69ab0","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":38},"updated":"2016-04-29 13:01:28.000000000","message":"Maybe would be better to reuse existing option from LVM driver?\nhttps://github.com/openstack/manila/blob/9a9bc9ca/manila/share/drivers/lvm.py#L50","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"lv_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\"container_volume_group\","},{"line_number":28,"context_line":"               default\u003d\"manila_docker_volumes\","},{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes.\"),"},{"line_number":30,"context_line":"    cfg.StrOpt(\"container_lv_size\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_b903b375","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":38},"in_reply_to":"1a122d0e_4ce69ab0","updated":"2016-05-04 12:26:36.000000000","message":"While I can\u0027t imagine a practical situation where both drivers will coexist in a same cloud I believe that it is not the best idea to couple two weakly related entities via options.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"09b551da640cdd17a1766757f5f8fdecc04bb584","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes.\"),"},{"line_number":30,"context_line":"    cfg.StrOpt(\"container_lv_size\","},{"line_number":31,"context_line":"               default\u003d\"10M\","},{"line_number":32,"context_line":"               help\u003d\"Logical volume size.\"),"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF.register_opts(lv_opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8c04324a","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":41},"updated":"2016-04-29 13:01:28.000000000","message":"Please, add more information.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes.\"),"},{"line_number":30,"context_line":"    cfg.StrOpt(\"container_lv_size\","},{"line_number":31,"context_line":"               default\u003d\"10M\","},{"line_number":32,"context_line":"               help\u003d\"Logical volume size.\"),"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF.register_opts(lv_opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_9906b783","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":41},"in_reply_to":"1a122d0e_8c04324a","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes. This volume group \""},{"line_number":30,"context_line":"                    \"must be created by the cloud administrator independently \""},{"line_number":31,"context_line":"                    \"from manila operations.\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\"container_lv_size\","},{"line_number":33,"context_line":"               default\u003d\"10M\","},{"line_number":34,"context_line":"               help\u003d\"Default logical volume size. This value determines the \""},{"line_number":35,"context_line":"                    \"size of a volume to be created in container_volume_group \""},{"line_number":36,"context_line":"                    \"for providing actual storage for the driver. This value \""},{"line_number":37,"context_line":"                    \"must be \" \"overriden when the driver is used for any \""},{"line_number":38,"context_line":"                    \"other purpose than testing.\"),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"CONF.register_opts(lv_opts)"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_604f2534","line":38,"range":{"start_line":32,"start_character":4,"end_line":38,"end_character":51},"updated":"2016-05-12 03:30:05.000000000","message":"I don\u0027t see any reason to keep this.","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d\"LVM volume group to use for volumes. This volume group \""},{"line_number":30,"context_line":"                    \"must be created by the cloud administrator independently \""},{"line_number":31,"context_line":"                    \"from manila operations.\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\"container_lv_size\","},{"line_number":33,"context_line":"               default\u003d\"10M\","},{"line_number":34,"context_line":"               help\u003d\"Default logical volume size. This value determines the \""},{"line_number":35,"context_line":"                    \"size of a volume to be created in container_volume_group \""},{"line_number":36,"context_line":"                    \"for providing actual storage for the driver. This value \""},{"line_number":37,"context_line":"                    \"must be \" \"overriden when the driver is used for any \""},{"line_number":38,"context_line":"                    \"other purpose than testing.\"),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"CONF.register_opts(lv_opts)"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_03053ac1","line":38,"range":{"start_line":32,"start_character":4,"end_line":38,"end_character":51},"in_reply_to":"dab17558_604f2534","updated":"2016-05-13 10:01:06.000000000","message":"Done","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"60906bbe108e5723366984a36a191ac0cc34d037","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def provide_storage(self, share):"},{"line_number":75,"context_line":"        share_name \u003d share.share_id"},{"line_number":76,"context_line":"        self._execute(\"lvcreate\", \"-p\", \"rw\", \"-L\","},{"line_number":77,"context_line":"                      self.configuration.container_lv_size, \"-n\", share_name,"},{"line_number":78,"context_line":"                      self.configuration.container_volume_group,"},{"line_number":79,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":80,"context_line":"        self._execute(\"mkfs.ext4\", self._get_lv_device(share),"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_0040d905","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":58},"updated":"2016-05-12 03:30:05.000000000","message":"Size should come from share","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0596ba36276687b756811266cfc7fda155833b97","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def provide_storage(self, share):"},{"line_number":75,"context_line":"        share_name \u003d share.share_id"},{"line_number":76,"context_line":"        self._execute(\"lvcreate\", \"-p\", \"rw\", \"-L\","},{"line_number":77,"context_line":"                      self.configuration.container_lv_size, \"-n\", share_name,"},{"line_number":78,"context_line":"                      self.configuration.container_volume_group,"},{"line_number":79,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":80,"context_line":"        self._execute(\"mkfs.ext4\", self._get_lv_device(share),"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab17558_c36cd29e","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":58},"in_reply_to":"dab17558_0040d905","updated":"2016-05-13 10:01:06.000000000","message":"Done","commit_id":"c0fe11aac8914aecff9661d203bd3a7452727b86"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        out, err \u003d self._execute(\u0027vgs\u0027,"},{"line_number":47,"context_line":"                                 self.configuration.container_volume_group,"},{"line_number":48,"context_line":"                                 \u0027--rows\u0027, run_as_root\u003dTrue)"},{"line_number":49,"context_line":"        total_size \u003d re.findall(\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":50,"context_line":"        free_size \u003d re.findall(\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":51,"context_line":"        return [{"},{"line_number":52,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":53,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_8253786a","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":63},"updated":"2016-05-20 22:32:46.000000000","message":"As you\u0027re only interested in the first match of the regex, you should use re.search rather than re.findall here.\nAlso, instead of slicing the result string to get the size, you could capture the size directly from the regex.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        out, err \u003d self._execute(\u0027vgs\u0027,"},{"line_number":47,"context_line":"                                 self.configuration.container_volume_group,"},{"line_number":48,"context_line":"                                 \u0027--rows\u0027, run_as_root\u003dTrue)"},{"line_number":49,"context_line":"        total_size \u003d re.findall(\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":50,"context_line":"        free_size \u003d re.findall(\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":51,"context_line":"        return [{"},{"line_number":52,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":53,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_5541a138","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":63},"in_reply_to":"bab6814e_8253786a","updated":"2016-05-25 09:45:43.000000000","message":"Yes, this could be done in a more straight-forward way.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":75,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":76,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":77,"context_line":"        self._execute(\"chmod\", \"-R\", \"777\", self._get_lv_folder(share),"},{"line_number":78,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_9cc3f8ec","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"updated":"2016-05-20 22:32:46.000000000","message":"Is it really necessary to set the permissions to 777?","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":75,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":76,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":77,"context_line":"        self._execute(\"chmod\", \"-R\", \"777\", self._get_lv_folder(share),"},{"line_number":78,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_d53631b3","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"in_reply_to":"bab6814e_9cc3f8ec","updated":"2016-05-25 09:45:43.000000000","message":"Well, 0640 should do the trick here as well, also there were some issues with actually accessing a share.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c709e1b847a03330a9387c792f76f9dc1342aa87","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":75,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":76,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":77,"context_line":"        self._execute(\"chmod\", \"-R\", \"777\", self._get_lv_folder(share),"},{"line_number":78,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_963bfeea","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"in_reply_to":"bab6814e_a4b093de","updated":"2016-05-25 14:45:15.000000000","message":"Done","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c4ba3acf3bd495cc2c2cdb7ccd53c9755a28562","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":75,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":76,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":77,"context_line":"        self._execute(\"chmod\", \"-R\", \"777\", self._get_lv_folder(share),"},{"line_number":78,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_a4b093de","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"in_reply_to":"bab6814e_d53631b3","updated":"2016-05-25 13:41:10.000000000","message":"Should be 0750, as this is a directory","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1b868a7abe9cbe206093677cd23be02521f0ed1e","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":86,"context_line":"        lv_device \u003d self._get_lv_device(share)"},{"line_number":87,"context_line":"        cmd \u003d (\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % new_size, \u0027-n\u0027, lv_device)"},{"line_number":88,"context_line":"        self._execute(*cmd, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        self._execute(\u0027resize2fs\u0027, lv_device, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_c2f74057","line":89,"range":{"start_line":87,"start_character":8,"end_line":89,"end_character":63},"updated":"2016-05-20 22:32:46.000000000","message":"This seems dangerous.\nI think it would be better if the volume was unmounted during the resize operation.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"723da0d398e8826a17f542d70a7161bcd8ec1643","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":86,"context_line":"        lv_device \u003d self._get_lv_device(share)"},{"line_number":87,"context_line":"        cmd \u003d (\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % new_size, \u0027-n\u0027, lv_device)"},{"line_number":88,"context_line":"        self._execute(*cmd, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        self._execute(\u0027resize2fs\u0027, lv_device, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_356dfd99","line":89,"range":{"start_line":87,"start_character":8,"end_line":89,"end_character":63},"in_reply_to":"bab6814e_c2f74057","updated":"2016-05-25 09:45:43.000000000","message":"Good point.","commit_id":"2e9bf92faffe97231d7328f0c18ddd9f24b30a10"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":53,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":54,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":55,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":56,"context_line":"        }, ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_699a3616","line":55,"range":{"start_line":55,"start_character":34,"end_line":55,"end_character":37},"updated":"2016-05-29 04:24:46.000000000","message":"what if configured?","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":53,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":54,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":55,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":56,"context_line":"        }, ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_bdcdabbc","line":55,"range":{"start_line":55,"start_character":34,"end_line":55,"end_character":37},"in_reply_to":"9abb7d3a_699a3616","updated":"2016-06-15 09:15:27.000000000","message":"It is not handled by LVM handler yet.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1351c8d52c2a447e7adb3b09bc99befebb269dc8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class LVMHelper(driver.ExecuteMixin):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":41,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":42,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_c5fde309","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":62},"updated":"2016-06-16 16:55:29.000000000","message":"Here you allow None to be set but right after it you call \"append_config_values\" attribute. Better to handle it correctly.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db0146ae0fdf3fe61f69db208c5d7564cb93ef4d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class LVMHelper(driver.ExecuteMixin):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":41,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":42,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_d3ce2682","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":62},"in_reply_to":"7aa08908_929bfc16","updated":"2016-06-17 11:36:04.000000000","message":"Not hard at all. Just define single backend in default config group.\n\nCurrent code is weak for it and will fail with unclear errors. It should be handled properly.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class LVMHelper(driver.ExecuteMixin):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":41,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":42,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_929bfc16","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":62},"in_reply_to":"7aa08908_c5fde309","updated":"2016-06-17 11:11:20.000000000","message":"Hmm, well, it will be rather hard to actually get None here (the helper is used in one single place, little chance it will be ever used anywhere else). I\u0027ll remove None to make it less confusing.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"3cbe726a5260473917e6f4909a885c4f10451f8b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class LVMHelper(driver.ExecuteMixin):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":41,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":42,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_a554edc5","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":62},"in_reply_to":"7aa08908_d3ce2682","updated":"2016-06-17 12:22:23.000000000","message":"Ok, let\u0027s add an explicit exception here.","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"9b33a96e7c4e57e5b8370f3aef2411fb8e65f9e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"lv_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"container_volume_group\","},{"line_number":30,"context_line":"               default\u003d\"manila_docker_volumes\","},{"line_number":31,"context_line":"               help\u003d\"LVM volume group to use for volumes. This volume group \""}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_eff1f46b","line":28,"updated":"2016-07-05 03:27:37.000000000","message":"How about consolidate the configuration into driver.py. \nFor example, container_image_name is defined in driver.py, but used in container_helper.py.","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"0b262b02cf83c2358a3427581ea1e27d5ad3d088","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"lv_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"container_volume_group\","},{"line_number":30,"context_line":"               default\u003d\"manila_docker_volumes\","},{"line_number":31,"context_line":"               help\u003d\"LVM volume group to use for volumes. This volume group \""}],"source_content_type":"text/x-python","patch_set":49,"id":"1aa78d24_3efa03be","line":28,"in_reply_to":"1aa78d24_eff1f46b","updated":"2016-07-05 08:23:27.000000000","message":"Good point, thank you! I think it makes more sense to keep options in the modules which actually use them. I\u0027ll probably move container_image_name to the appropriate module.","commit_id":"d3e6f19290743682cb20fc04bc35dab035ff3252"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"28ecb241fabf08280c6406c5d177e97aa445e16e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":80,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":81,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":82,"context_line":"        self._execute(\"chmod\", \"-R\", \"750\", self._get_lv_folder(share),"},{"line_number":83,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":54,"id":"1aa78d24_97723a10","line":82,"updated":"2016-07-14 02:41:40.000000000","message":"I suggest adding a \"chown nobody:nogroup\" here. The shares are accessible by \"guest\" through CIFS and that maps to \"nobody\" in Linux. By changing the ownership of the root directory, then CIFS client can actually write to the directory.","commit_id":"4c3a819ff225266dd6722d1ade667afaa1d94f1a"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"1a4ec86b659d1e0659590d121d633f9892d78093","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":80,"context_line":"        self._execute(\"mount\", self._get_lv_device(share),"},{"line_number":81,"context_line":"                      self._get_lv_folder(share), run_as_root\u003dTrue)"},{"line_number":82,"context_line":"        self._execute(\"chmod\", \"-R\", \"750\", self._get_lv_folder(share),"},{"line_number":83,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def remove_storage(self, share):"}],"source_content_type":"text/x-python","patch_set":54,"id":"1aa78d24_dab7c238","line":82,"in_reply_to":"1aa78d24_97723a10","updated":"2016-07-14 06:24:27.000000000","message":"Good point, thank you!","commit_id":"4c3a819ff225266dd6722d1ade667afaa1d94f1a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4ca8228f7d23c77a187a1a0b475904fc768e372","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":58,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":59,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":60,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":61,"context_line":"        }, ]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":57,"id":"1aa78d24_f66c129f","line":60,"updated":"2016-07-15 12:39:22.000000000","message":"In [1] you defined that \"thick_provisioning\" is supported, but you do not report such capability. Please, add it.\n\n[1] https://review.openstack.org/#/c/308930/57/doc/source/devref/share_back_ends_feature_support_mapping.rst","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d44b834ec82fc81013200b52e68b51986605e7b5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":58,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":59,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":60,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":61,"context_line":"        }, ]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":57,"id":"dada55a8_983c1831","line":60,"in_reply_to":"1aa78d24_f66c129f","updated":"2016-07-18 17:49:34.000000000","message":"Sorry, I don\u0027t see how LVM server pools should report thick provisioning. Could you please elaborate? Also, thick is thick, isn\u0027t it the default mode if not stated otherwise?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f25b48154a82b0cf1d926c155da8fd0d98d072ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":42,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":43,"context_line":"        if self.configuration is None:"},{"line_number":44,"context_line":"            raise exception.ManilaException(_(\"LVMHelper called without \""},{"line_number":45,"context_line":"                                              \"supplying configuration.\"))"},{"line_number":46,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":47,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":48,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_f0a0c292","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":74},"updated":"2016-07-28 11:43:20.000000000","message":"not covered by unit test/s","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"65f0db4de0ec85619202805b569f795be0ddc740","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":42,"context_line":"        self.configuration \u003d kwargs.pop(\"configuration\", None)"},{"line_number":43,"context_line":"        if self.configuration is None:"},{"line_number":44,"context_line":"            raise exception.ManilaException(_(\"LVMHelper called without \""},{"line_number":45,"context_line":"                                              \"supplying configuration.\"))"},{"line_number":46,"context_line":"        self.configuration.append_config_values(lv_opts)"},{"line_number":47,"context_line":"        super(LVMHelper, self).__init__(*args, **kwargs)"},{"line_number":48,"context_line":"        self.init_execute_mixin()"}],"source_content_type":"text/x-python","patch_set":71,"id":"bacf61ea_80601537","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":74},"in_reply_to":"bacf61ea_f0a0c292","updated":"2016-07-28 12:38:42.000000000","message":"Done","commit_id":"a24a5efb7ceb68709606d590bfef1ab94d0657f1"}],"manila/share/drivers/docker/__init__.py":[{"author":{"_account_id":21059,"name":"xulin","email":"xulin1@huawei.com","username":"Erik"},"change_message_id":"380207589c2ef7b8e436ae8d9e48a55d401f0515","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        self._helpers \u003d {}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _get_helper(self, share):"},{"line_number":278,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":279,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":280,"context_line":"            if helper is not None:"},{"line_number":281,"context_line":"                helper.share \u003d share"},{"line_number":282,"context_line":"                return helper"},{"line_number":283,"context_line":"            self._helpers[\"CIFS\"] \u003d DockerCIFSHelper(self.docker, share\u003dshare,"},{"line_number":284,"context_line":"                                                     config\u003dself.configuration)"},{"line_number":285,"context_line":"            return self._helpers[\"CIFS\"]"},{"line_number":286,"context_line":"        else:"},{"line_number":287,"context_line":"            raise exception.InvalidShare("},{"line_number":288,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b9779707","line":285,"range":{"start_line":278,"start_character":0,"end_line":285,"end_character":40},"updated":"2016-04-21 12:48:48.000000000","message":"The word \"CIFS\" appear many times, why not define it in constants, just like \"ACCESS_LEVEL_RW\", \"ACCESS_LEVEL_LO\".","commit_id":"c21092fc3166fc40fde16a3bd613d1ef8b8ef0a2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"4484aa2958ff78ee7336fc45e1546325184aedcf","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        self._helpers \u003d {}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _get_helper(self, share):"},{"line_number":278,"context_line":"        if share[\"share_proto\"].upper() \u003d\u003d \"CIFS\":"},{"line_number":279,"context_line":"            helper \u003d self._helpers.get(\"CIFS\")"},{"line_number":280,"context_line":"            if helper is not None:"},{"line_number":281,"context_line":"                helper.share \u003d share"},{"line_number":282,"context_line":"                return helper"},{"line_number":283,"context_line":"            self._helpers[\"CIFS\"] \u003d DockerCIFSHelper(self.docker, share\u003dshare,"},{"line_number":284,"context_line":"                                                     config\u003dself.configuration)"},{"line_number":285,"context_line":"            return self._helpers[\"CIFS\"]"},{"line_number":286,"context_line":"        else:"},{"line_number":287,"context_line":"            raise exception.InvalidShare("},{"line_number":288,"context_line":"                reason\u003d_(\"Wrong, unsupported or disabled protocol.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9ce0c9ce","line":285,"range":{"start_line":278,"start_character":0,"end_line":285,"end_character":40},"in_reply_to":"1a122d0e_b9779707","updated":"2016-04-21 13:01:24.000000000","message":"Yes, this could be done.","commit_id":"c21092fc3166fc40fde16a3bd613d1ef8b8ef0a2"},{"author":{"_account_id":21059,"name":"xulin","email":"xulin1@huawei.com","username":"Erik"},"change_message_id":"380207589c2ef7b8e436ae8d9e48a55d401f0515","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":440,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":441,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":442,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":443,"context_line":"                continue"},{"line_number":444,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":445,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":446,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_390b872d","line":443,"range":{"start_line":442,"start_character":0,"end_line":443,"end_character":24},"updated":"2016-04-21 12:48:48.000000000","message":"Maybe this is better:\n    if not container_id:\n        continue","commit_id":"c21092fc3166fc40fde16a3bd613d1ef8b8ef0a2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"4484aa2958ff78ee7336fc45e1546325184aedcf","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            iface_data \u003d self._execute(\"ovs-vsctl\", \"list\", \"interface\", veth,"},{"line_number":440,"context_line":"                                       run_as_root\u003dTrue)[0]"},{"line_number":441,"context_line":"            container_id \u003d re.findall(manila_re, iface_data)"},{"line_number":442,"context_line":"            if container_id \u003d\u003d []:"},{"line_number":443,"context_line":"                continue"},{"line_number":444,"context_line":"            elif container_id[0] \u003d\u003d server_id:"},{"line_number":445,"context_line":"                LOG.debug(\"Deleting veth.\")"},{"line_number":446,"context_line":"                self._execute(\"ovs-vsctl\", \"--\", \"del-port\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7c484dcd","line":443,"range":{"start_line":442,"start_character":0,"end_line":443,"end_character":24},"in_reply_to":"1a122d0e_390b872d","updated":"2016-04-21 13:01:24.000000000","message":"Why?","commit_id":"c21092fc3166fc40fde16a3bd613d1ef8b8ef0a2"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38a9b1559a5f56e0a798f6e97951d35f15970c13","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                fake_share_network[\u0027project_id\u0027],"},{"line_number":131,"context_line":"                network_id\u003dfake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":132,"context_line":"                subnet_id\u003dfake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":133,"context_line":"                device_owner\u003d\u0027manila:share\u0027, host_id\u003dNone)"},{"line_number":134,"context_line":"            db_api.network_allocation_create.assert_called_once_with("},{"line_number":135,"context_line":"                self.fake_context,"},{"line_number":136,"context_line":"                fake_network_allocation)"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_353112a3","line":133,"range":{"start_line":133,"start_character":41,"end_line":133,"end_character":58},"updated":"2016-07-27 11:29:39.000000000","message":"Case where we define it via config is not covered.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f928bc4a08a7b7bf11e4c771bf8e8390f861f3d8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                fake_share_network[\u0027project_id\u0027],"},{"line_number":131,"context_line":"                network_id\u003dfake_share_network[\u0027neutron_net_id\u0027],"},{"line_number":132,"context_line":"                subnet_id\u003dfake_share_network[\u0027neutron_subnet_id\u0027],"},{"line_number":133,"context_line":"                device_owner\u003d\u0027manila:share\u0027, host_id\u003dNone)"},{"line_number":134,"context_line":"            db_api.network_allocation_create.assert_called_once_with("},{"line_number":135,"context_line":"                self.fake_context,"},{"line_number":136,"context_line":"                fake_network_allocation)"}],"source_content_type":"text/x-python","patch_set":67,"id":"dada55a8_49d22b5d","line":133,"range":{"start_line":133,"start_character":41,"end_line":133,"end_character":58},"in_reply_to":"dada55a8_353112a3","updated":"2016-07-27 12:59:14.000000000","message":"OK, will add it in the next PS.","commit_id":"8fa030e8cbaa589fec0bdf937d811aa4b2efca6f"}],"manila/tests/share/drivers/container/test_container_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from manila.share.drivers.container import container_helper"},{"line_number":22,"context_line":"from manila import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DockerExecHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_2727f963","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":15},"updated":"2016-04-29 13:08:57.000000000","message":"Redundant.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from manila.share.drivers.container import container_helper"},{"line_number":22,"context_line":"from manila import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DockerExecHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_19d627c3","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":15},"in_reply_to":"1a122d0e_2727f963","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.DockerExecHelper \u003d container_helper.DockerExecHelper("},{"line_number":35,"context_line":"            configuration\u003dself.fake_conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def tearDown(self):"},{"line_number":38,"context_line":"        super(DockerExecHelperTestCase, self).tearDown()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_start_container(self):"},{"line_number":41,"context_line":"        self.mock_object(self.DockerExecHelper, \"_inner_execute\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_271099ff","line":38,"range":{"start_line":37,"start_character":1,"end_line":38,"end_character":56},"updated":"2016-04-29 13:08:57.000000000","message":"Redundant.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.DockerExecHelper \u003d container_helper.DockerExecHelper("},{"line_number":35,"context_line":"            configuration\u003dself.fake_conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def tearDown(self):"},{"line_number":38,"context_line":"        super(DockerExecHelperTestCase, self).tearDown()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_start_container(self):"},{"line_number":41,"context_line":"        self.mock_object(self.DockerExecHelper, \"_inner_execute\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_79e59ba6","line":38,"range":{"start_line":37,"start_character":1,"end_line":38,"end_character":56},"in_reply_to":"1a122d0e_271099ff","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1cfbbb5d4a43677d33c7fb135ae6524e0d32f4d4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_start_container(self):"},{"line_number":35,"context_line":"        self.mock_object(self.DockerExecHelper, \"_inner_execute\","},{"line_number":36,"context_line":"                         mock.Mock(return_value\u003d[\u0027fake_output\u0027, \u0027\u0027]))"},{"line_number":37,"context_line":"        self.DockerExecHelper.start_container()"},{"line_number":38,"context_line":"        expected \u003d [\u0027docker\u0027, \u0027run\u0027, \u0027-d\u0027, \u0027-i\u0027, \u0027-t\u0027, \u0027--privileged\u0027,"},{"line_number":39,"context_line":"                    \u0027--name\u003dmanila_cifs_docker_container\u0027, \u0027-v\u0027,"},{"line_number":40,"context_line":"                    \u0027/tmp/shares:/shares\u0027, \u0027manila-docker-container\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_59db9b1b","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":47},"updated":"2016-06-16 19:11:02.000000000","message":"Please separate all unit tests into 3 sections (mocks, call, asserts).  This greatly enhances readability!","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dff8fbc0784b8162407811d7ef46b76325f7e85b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_start_container(self):"},{"line_number":35,"context_line":"        self.mock_object(self.DockerExecHelper, \"_inner_execute\","},{"line_number":36,"context_line":"                         mock.Mock(return_value\u003d[\u0027fake_output\u0027, \u0027\u0027]))"},{"line_number":37,"context_line":"        self.DockerExecHelper.start_container()"},{"line_number":38,"context_line":"        expected \u003d [\u0027docker\u0027, \u0027run\u0027, \u0027-d\u0027, \u0027-i\u0027, \u0027-t\u0027, \u0027--privileged\u0027,"},{"line_number":39,"context_line":"                    \u0027--name\u003dmanila_cifs_docker_container\u0027, \u0027-v\u0027,"},{"line_number":40,"context_line":"                    \u0027/tmp/shares:/shares\u0027, \u0027manila-docker-container\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"7aa08908_6d5951fd","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":47},"in_reply_to":"7aa08908_59db9b1b","updated":"2016-06-17 11:11:20.000000000","message":"Done","commit_id":"dfb79b2154294ec7567039dc869a162e4a80d9c5"}],"manila/tests/share/drivers/container/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Used only to test compatibility with share manager"},{"line_number":97,"context_line":"        self.share_server \u003d \"fake_share_server\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def tearDown(self):"},{"line_number":100,"context_line":"        super(ContainerShareDriverTestCase, self).tearDown()"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test__get_helper_ok(self):"},{"line_number":103,"context_line":"        share \u003d fake_share(share_proto\u003d\u0027CIFS\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_67e4510c","line":100,"range":{"start_line":99,"start_character":4,"end_line":100,"end_character":60},"updated":"2016-04-29 13:08:57.000000000","message":"Redundant.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Used only to test compatibility with share manager"},{"line_number":97,"context_line":"        self.share_server \u003d \"fake_share_server\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def tearDown(self):"},{"line_number":100,"context_line":"        super(ContainerShareDriverTestCase, self).tearDown()"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test__get_helper_ok(self):"},{"line_number":103,"context_line":"        share \u003d fake_share(share_proto\u003d\u0027CIFS\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_b9ed7390","line":100,"range":{"start_line":99,"start_character":4,"end_line":100,"end_character":60},"in_reply_to":"1a122d0e_67e4510c","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def fake_share(**kwargs):"},{"line_number":36,"context_line":"    share \u003d {"},{"line_number":37,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":38,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":39,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":40,"context_line":"        \u0027size\u0027: 1,"},{"line_number":41,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":42,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    share.update(kwargs)"},{"line_number":45,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_access(**kwargs):"},{"line_number":49,"context_line":"    access \u003d {"},{"line_number":50,"context_line":"        \u0027id\u0027: \u0027fakeaccid\u0027,"},{"line_number":51,"context_line":"        \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":52,"context_line":"        \u0027access_to\u0027: \u002710.0.0.2\u0027,"},{"line_number":53,"context_line":"        \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":54,"context_line":"        \u0027state\u0027: \u0027active\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"    access.update(kwargs)"},{"line_number":57,"context_line":"    return db_fakes.FakeModel(access)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def fake_network(**kwargs):"},{"line_number":61,"context_line":"    allocations \u003d db_fakes.FakeModel({\u0027id\u0027: \u0027fake_allocation_id\u0027,"},{"line_number":62,"context_line":"                                      \u0027ip_address\u0027: \u0027127.0.0.0.1\u0027,"},{"line_number":63,"context_line":"                                      \u0027mac_address\u0027: \u0027fe:16:3e:61:e0:58\u0027})"},{"line_number":64,"context_line":"    network \u003d {"},{"line_number":65,"context_line":"        \u0027id\u0027: \u0027fake_network_id\u0027,"},{"line_number":66,"context_line":"        \u0027server_id\u0027: \u0027fake_server_id\u0027,"},{"line_number":67,"context_line":"        \u0027network_allocations\u0027: [allocations],"},{"line_number":68,"context_line":"        \u0027neutron_subnet_id\u0027: \u0027fake_subnet\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    network.update(kwargs)"},{"line_number":71,"context_line":"    return db_fakes.FakeModel(network)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ContainerShareDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_a9a41e57","line":71,"range":{"start_line":35,"start_character":0,"end_line":71,"end_character":38},"updated":"2016-05-29 04:24:46.000000000","message":"should go into the fakes file you created.. https://review.openstack.org/#/c/308930/42/manila/tests/share/drivers/container/fakes.py","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def fake_share(**kwargs):"},{"line_number":36,"context_line":"    share \u003d {"},{"line_number":37,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":38,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":39,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":40,"context_line":"        \u0027size\u0027: 1,"},{"line_number":41,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":42,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    share.update(kwargs)"},{"line_number":45,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_access(**kwargs):"},{"line_number":49,"context_line":"    access \u003d {"},{"line_number":50,"context_line":"        \u0027id\u0027: \u0027fakeaccid\u0027,"},{"line_number":51,"context_line":"        \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":52,"context_line":"        \u0027access_to\u0027: \u002710.0.0.2\u0027,"},{"line_number":53,"context_line":"        \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":54,"context_line":"        \u0027state\u0027: \u0027active\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"    access.update(kwargs)"},{"line_number":57,"context_line":"    return db_fakes.FakeModel(access)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def fake_network(**kwargs):"},{"line_number":61,"context_line":"    allocations \u003d db_fakes.FakeModel({\u0027id\u0027: \u0027fake_allocation_id\u0027,"},{"line_number":62,"context_line":"                                      \u0027ip_address\u0027: \u0027127.0.0.0.1\u0027,"},{"line_number":63,"context_line":"                                      \u0027mac_address\u0027: \u0027fe:16:3e:61:e0:58\u0027})"},{"line_number":64,"context_line":"    network \u003d {"},{"line_number":65,"context_line":"        \u0027id\u0027: \u0027fake_network_id\u0027,"},{"line_number":66,"context_line":"        \u0027server_id\u0027: \u0027fake_server_id\u0027,"},{"line_number":67,"context_line":"        \u0027network_allocations\u0027: [allocations],"},{"line_number":68,"context_line":"        \u0027neutron_subnet_id\u0027: \u0027fake_subnet\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    network.update(kwargs)"},{"line_number":71,"context_line":"    return db_fakes.FakeModel(network)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ContainerShareDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_88b7cb39","line":71,"range":{"start_line":35,"start_character":0,"end_line":71,"end_character":38},"in_reply_to":"9abb7d3a_a9a41e57","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"e01b4cef5b11f4f241ad33699075f079f81d4ad8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(\u0027Docker\u0027, self._driver._stats[\u0027share_backend_name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(\u0027cifs\u0027, self._driver._stats[\u0027storage_protocol\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(0, self._driver._stats[\u0027reserved_percentage\u0027])"},{"line_number":125,"context_line":"        self.assertEqual(None,"},{"line_number":126,"context_line":"                         self._driver._stats[\u0027consistency_group_support\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(False, self._driver._stats[\u0027snapshot_support\u0027])"},{"line_number":128,"context_line":"        self.assertEqual(\u0027ContainerShareDriver\u0027,"},{"line_number":129,"context_line":"                         self._driver._stats[\u0027driver_name\u0027])"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_f1f8c5c6","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":74},"updated":"2016-06-10 08:19:38.000000000","message":"Please use assertIsNone(...) instead of assertEqual(None, ...)","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(\u0027Docker\u0027, self._driver._stats[\u0027share_backend_name\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(\u0027cifs\u0027, self._driver._stats[\u0027storage_protocol\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(0, self._driver._stats[\u0027reserved_percentage\u0027])"},{"line_number":125,"context_line":"        self.assertEqual(None,"},{"line_number":126,"context_line":"                         self._driver._stats[\u0027consistency_group_support\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(False, self._driver._stats[\u0027snapshot_support\u0027])"},{"line_number":128,"context_line":"        self.assertEqual(\u0027ContainerShareDriver\u0027,"},{"line_number":129,"context_line":"                         self._driver._stats[\u0027driver_name\u0027])"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_3d49bb33","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":74},"in_reply_to":"7aa08908_f1f8c5c6","updated":"2016-06-15 09:15:27.000000000","message":"Done","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"301dcdd2a7403075184a42ecc2dead698a6a5075","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         self._driver._get_container_name(\"fake-server\"))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_do_setup(self):"},{"line_number":185,"context_line":"        # Does effectively nothing by design."},{"line_number":186,"context_line":"        self.assertEqual(1, 1)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_check_for_setup_error(self):"},{"line_number":189,"context_line":"        # Does effectively nothing by design."},{"line_number":190,"context_line":"        self.assertEqual(1, 1)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test__connect_to_network(self):"},{"line_number":193,"context_line":"        network_info \u003d fake_network()"}],"source_content_type":"text/x-python","patch_set":42,"id":"9abb7d3a_098a8abf","line":190,"range":{"start_line":185,"start_character":0,"end_line":190,"end_character":30},"updated":"2016-05-29 04:24:46.000000000","message":"you could remove these.. you\u0027re not calling the methods..","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7c50f2c77687473090d51df9c3e6fc503de26ccb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         self._driver._get_container_name(\"fake-server\"))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_do_setup(self):"},{"line_number":185,"context_line":"        # Does effectively nothing by design."},{"line_number":186,"context_line":"        self.assertEqual(1, 1)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_check_for_setup_error(self):"},{"line_number":189,"context_line":"        # Does effectively nothing by design."},{"line_number":190,"context_line":"        self.assertEqual(1, 1)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test__connect_to_network(self):"},{"line_number":193,"context_line":"        network_info \u003d fake_network()"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aa08908_9dbc2fdd","line":190,"range":{"start_line":185,"start_character":0,"end_line":190,"end_character":30},"in_reply_to":"9abb7d3a_098a8abf","updated":"2016-06-15 09:15:27.000000000","message":"Doing that will leave me with lower coverage (as reported by the coverage tool), so I\u0027ll keep these tests for now.","commit_id":"24005c567392ec380478d0efa4795c119aa29ed1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"11e8ac4f3d54c0100a69a8acf07c8f22aa9c718d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from manila.tests.share.drivers.container import fakes as cont_fakes"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ContainerShareDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_61bf71aa","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":15},"updated":"2016-08-11 02:21:49.000000000","message":"Please add the following line to enable the unit tests to work in PyCharm:\n\n    CONF.import_opt(\u0027lvm_share_export_ip\u0027, \u0027manila.share.drivers.lvm\u0027)","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from manila.tests.share.drivers.container import fakes as cont_fakes"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ContainerShareDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_a7f7af57","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":15},"in_reply_to":"9ad45d7e_61bf71aa","updated":"2016-08-11 09:19:43.000000000","message":"Ok.","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"11e8ac4f3d54c0100a69a8acf07c8f22aa9c718d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                \u0027manila.network.neutron.neutron_network_plugin.\u0027"},{"line_number":180,"context_line":"                \u0027NeutronNetworkPlugin\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        driver.LOG.warning.assert_called_once()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test__connect_to_network(self):"},{"line_number":185,"context_line":"        network_info \u003d cont_fakes.fake_network()"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_61edb1b6","line":182,"range":{"start_line":182,"start_character":27,"end_line":182,"end_character":45},"updated":"2016-08-11 02:21:49.000000000","message":"assert_called_once() doesn\u0027t exist.  Use either:\n\n    self.assertTrue(driver.LOG.warning.called)\n\nor\n\n    driver.LOG.warning.assert_called_once_with(mock.ANY)","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                \u0027manila.network.neutron.neutron_network_plugin.\u0027"},{"line_number":180,"context_line":"                \u0027NeutronNetworkPlugin\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        driver.LOG.warning.assert_called_once()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test__connect_to_network(self):"},{"line_number":185,"context_line":"        network_info \u003d cont_fakes.fake_network()"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_273e1fda","line":182,"range":{"start_line":182,"start_character":27,"end_line":182,"end_character":45},"in_reply_to":"9ad45d7e_61edb1b6","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"}],"manila/tests/share/drivers/container/test_protocol_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.tests.db import fakes as db_fakes"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fake_share(**kwargs):"},{"line_number":27,"context_line":"    share \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":29,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":30,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":31,"context_line":"        \u0027size\u0027: 1,"},{"line_number":32,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":33,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class DockerCIFSHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_c7c60567","line":36,"range":{"start_line":26,"start_character":0,"end_line":36,"end_character":36},"updated":"2016-04-29 13:08:57.000000000","message":"Copy-paste not only for existing test modules in master, but also for all your new modules.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.tests.db import fakes as db_fakes"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fake_share(**kwargs):"},{"line_number":27,"context_line":"    share \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":29,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":30,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":31,"context_line":"        \u0027size\u0027: 1,"},{"line_number":32,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":33,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class DockerCIFSHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_f96c0b0a","line":36,"range":{"start_line":26,"start_character":0,"end_line":36,"end_character":36},"in_reply_to":"1a122d0e_c7c60567","updated":"2016-05-04 12:26:36.000000000","message":"Not sure what exactly you are trying to say here, but yes, this one should be moved to a separate module.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.DockerCIFSHelper \u003d protocol_helper.DockerCIFSHelper("},{"line_number":48,"context_line":"            self._helper, share\u003dfake_share(), config\u003dself.fake_conf)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def tearDown(self):"},{"line_number":51,"context_line":"        super(DockerCIFSHelperTestCase, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def fake_exec_sync(self, *args, **kwargs):"},{"line_number":54,"context_line":"        kwargs[\u0027execute_arguments\u0027].append(args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_a7eae9d5","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"updated":"2016-04-29 13:08:57.000000000","message":"Redundant.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.DockerCIFSHelper \u003d protocol_helper.DockerCIFSHelper("},{"line_number":48,"context_line":"            self._helper, share\u003dfake_share(), config\u003dself.fake_conf)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def tearDown(self):"},{"line_number":51,"context_line":"        super(DockerCIFSHelperTestCase, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def fake_exec_sync(self, *args, **kwargs):"},{"line_number":54,"context_line":"        kwargs[\u0027execute_arguments\u0027].append(args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_f99ecb05","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"in_reply_to":"1a122d0e_a7eae9d5","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32f474eb71cbc31f40fef282188dc45b222140f3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            return_value\u003d\"joost jaap huub dirk\")"},{"line_number":200,"context_line":"        self.DockerCIFSHelper._set_users \u003d mock.Mock()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Sorry, Jaap."},{"line_number":203,"context_line":"        self.DockerCIFSHelper._deny_access(\"fake_share\", \"fake_server_id\","},{"line_number":204,"context_line":"                                           \"jaap\", \"rw\")"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_52ecc1f2","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":22},"updated":"2016-08-10 23:28:48.000000000","message":"lol","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d571b68c561c7111c1a96746968783f6a8be553c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.DockerCIFSHelper._get_existing_users.assert_called_once_with("},{"line_number":226,"context_line":"            \"fake_server_id\", \"fake_share\", \"valid users\")"},{"line_number":227,"context_line":"        self.assertFalse(self.DockerCIFSHelper._set_users.called)"},{"line_number":228,"context_line":"        protocol_helper.LOG.warning.assert_called_once()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def test_update_access_access_rules_wrong_type(self):"},{"line_number":231,"context_line":"        allow_rules \u003d [{"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_e1288135","line":228,"range":{"start_line":228,"start_character":36,"end_line":228,"end_character":54},"updated":"2016-08-11 02:09:04.000000000","message":"assert_called_once() doesn\u0027t exist.  Use either:\n\n    self.assertTrue(protocol_helper.LOG.warning.called)\n\nor\n\n    protocol_helper.LOG.warning.assert_called_once_with(mock.ANY)","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.DockerCIFSHelper._get_existing_users.assert_called_once_with("},{"line_number":226,"context_line":"            \"fake_server_id\", \"fake_share\", \"valid users\")"},{"line_number":227,"context_line":"        self.assertFalse(self.DockerCIFSHelper._set_users.called)"},{"line_number":228,"context_line":"        protocol_helper.LOG.warning.assert_called_once()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def test_update_access_access_rules_wrong_type(self):"},{"line_number":231,"context_line":"        allow_rules \u003d [{"}],"source_content_type":"text/x-python","patch_set":76,"id":"9ad45d7e_27157f48","line":228,"range":{"start_line":228,"start_character":36,"end_line":228,"end_character":54},"in_reply_to":"9ad45d7e_e1288135","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"}],"manila/tests/share/drivers/container/test_storage_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.tests.db import fakes as db_fakes"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fake_share(**kwargs):"},{"line_number":27,"context_line":"    share \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":29,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":30,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":31,"context_line":"        \u0027size\u0027: 1,"},{"line_number":32,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":33,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class LVMHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_47a9558f","line":36,"range":{"start_line":26,"start_character":1,"end_line":36,"end_character":36},"updated":"2016-04-29 13:08:57.000000000","message":"Copy-paste. Should be reused.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.tests.db import fakes as db_fakes"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fake_share(**kwargs):"},{"line_number":27,"context_line":"    share \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: \u0027fakeid\u0027,"},{"line_number":29,"context_line":"        \u0027share_id\u0027: \u0027fakeshareid\u0027,"},{"line_number":30,"context_line":"        \u0027name\u0027: \u0027fakename\u0027,"},{"line_number":31,"context_line":"        \u0027size\u0027: 1,"},{"line_number":32,"context_line":"        \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":33,"context_line":"        \u0027export_location\u0027: \u0027127.0.0.1:/mnt/nfs/volume-00002\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class LVMHelperTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_99335713","line":36,"range":{"start_line":26,"start_character":1,"end_line":36,"end_character":36},"in_reply_to":"1a122d0e_47a9558f","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68733ac4c69fa2c09652b42bbdb0d63463e47873","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":46,"context_line":"        self.LVMHelper \u003d storage_helper.LVMHelper(configuration\u003dself.fake_conf)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def tearDown(self):"},{"line_number":49,"context_line":"        super(LVMHelperTestCase, self).tearDown()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def fake_exec_sync(self, *args, **kwargs):"},{"line_number":52,"context_line":"        kwargs[\u0027execute_arguments\u0027].append(args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_07a3ddb2","line":49,"range":{"start_line":48,"start_character":4,"end_line":49,"end_character":49},"updated":"2016-04-29 13:08:57.000000000","message":"Redundant.","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"107dc8c083d7d2992a4b3b70e5b0931bfbfe490d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":46,"context_line":"        self.LVMHelper \u003d storage_helper.LVMHelper(configuration\u003dself.fake_conf)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def tearDown(self):"},{"line_number":49,"context_line":"        super(LVMHelperTestCase, self).tearDown()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def fake_exec_sync(self, *args, **kwargs):"},{"line_number":52,"context_line":"        kwargs[\u0027execute_arguments\u0027].append(args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_c8dcda48","line":49,"range":{"start_line":48,"start_character":4,"end_line":49,"end_character":49},"in_reply_to":"1a122d0e_07a3ddb2","updated":"2016-05-04 12:26:36.000000000","message":"Done","commit_id":"38136744e2997a1b5d07f612838b8828354c59b2"}],"releasenotes/notes/container-driver-5d972cc40e314663.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cc069205325772b4ab576180f6ac4cd4ec264ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    A new driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_1ee107fd","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":25},"updated":"2016-07-15 05:03:41.000000000","message":"dramatic. :) what\u0027s the name of the driver, please?","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"25221cf6c33cc8d1be60b708012f0721b290ebc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    A new driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_61c98b5a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":25},"in_reply_to":"1aa78d24_1ee107fd","updated":"2016-07-15 08:28:24.000000000","message":"Ok, good point, I\u0027ll reduce the drama level by adding a name.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cc069205325772b4ab576180f6ac4cd4ec264ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - Currently only CIFS is supported."},{"line_number":10,"context_line":"  - Only basic driver operations are supported."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_7eac8b8c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":37},"updated":"2016-07-15 05:03:41.000000000","message":"This is not really an issue. It\u0027s perfectly valid to support only one protocol. Please list the protocol supported in the features above.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"25221cf6c33cc8d1be60b708012f0721b290ebc0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - Currently only CIFS is supported."},{"line_number":10,"context_line":"  - Only basic driver operations are supported."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_e1029b71","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":37},"in_reply_to":"1aa78d24_7eac8b8c","updated":"2016-07-15 08:28:24.000000000","message":"Done","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cc069205325772b4ab576180f6ac4cd4ec264ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    A new driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - Currently only CIFS is supported."},{"line_number":10,"context_line":"  - Only basic driver operations are supported."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_5e70af40","line":10,"range":{"start_line":5,"start_character":0,"end_line":10,"end_character":47},"updated":"2016-07-15 05:03:41.000000000","message":"What basic operations are these?\n\n\nPlease remember that you need to specify the name of the driver in every line or, do something like this:\n\n features:\n   * The native docker-based container driver supports using a docker container as a share server.\n\n issues:\n  - | \n      The native docker-based container driver has the following known issues:\n      * Currently only CIFS is supported.\n      * Only basic driver operations are supported.\n\n\nYou probably have a cooler name than \u0027native docker-based container\u0027.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"25221cf6c33cc8d1be60b708012f0721b290ebc0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    A new driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - Currently only CIFS is supported."},{"line_number":10,"context_line":"  - Only basic driver operations are supported."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1aa78d24_61f7cb8c","line":10,"range":{"start_line":5,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"1aa78d24_5e70af40","updated":"2016-07-15 08:28:24.000000000","message":"Um, described in the list of required methods? I\u0027ll add them here anyway, despite not having any really cool name for the driver.","commit_id":"ae7127a8146c8099eb0e9b90f17de3da9be232e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f571c9b0fcde0ecd530af6afc3c5758bdf84176","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    A new Container driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - CIFS is supported."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"dada55a8_806808bc","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":10},"updated":"2016-07-24 16:22:12.000000000","message":"The Container drivers allows use of a docker container as a share server.","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"bf2b15cb9b099d60bd21358b51791188efa0213e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    A new Container driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - CIFS is supported."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"dada55a8_ce722a11","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":10},"in_reply_to":"dada55a8_806808bc","updated":"2016-07-25 06:25:35.000000000","message":"Done","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f571c9b0fcde0ecd530af6afc3c5758bdf84176","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - CIFS is supported."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The Container driver has the following known issues:"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"dada55a8_c06200d8","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":21},"updated":"2016-07-24 16:22:12.000000000","message":"The Container driver supports CIFS protocol","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"bf2b15cb9b099d60bd21358b51791188efa0213e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - CIFS is supported."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The Container driver has the following known issues:"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"dada55a8_ae541654","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":21},"in_reply_to":"dada55a8_c06200d8","updated":"2016-07-25 06:25:35.000000000","message":"Done","commit_id":"30d2224a5a899701180ecbab879f2d32a79d413b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d571b68c561c7111c1a96746968783f6a8be553c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    A new Container driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - The Container driver allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - The Container driver supports CIFS protocol."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9ad45d7e_a1a169fa","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":38},"updated":"2016-08-11 02:09:04.000000000","message":"s/to use/using/","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    A new Container driver is added. It uses docker container as"},{"line_number":4,"context_line":"    a share server."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - The Container driver allows to use a docker container as a share server."},{"line_number":7,"context_line":"    This allows for very fast share server startup."},{"line_number":8,"context_line":"  - The Container driver supports CIFS protocol."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9ad45d7e_a2b4bd34","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":38},"in_reply_to":"9ad45d7e_a1a169fa","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d571b68c561c7111c1a96746968783f6a8be553c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The Container driver has the following known issues:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Only basic driver operations are supported: create/delete share,"},{"line_number":14,"context_line":"      update acces and extend share."}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9ad45d7e_016cb5ce","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":18},"updated":"2016-08-11 02:09:04.000000000","message":"typo: access","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"a254700e35956ff0b198806332196e3423b68089","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The Container driver has the following known issues:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Only basic driver operations are supported: create/delete share,"},{"line_number":14,"context_line":"      update acces and extend share."}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9ad45d7e_0284a95b","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":18},"in_reply_to":"9ad45d7e_016cb5ce","updated":"2016-08-11 09:19:43.000000000","message":"Done","commit_id":"d87203ae5d1120a9aaa138f224b668b022c35ac9"}]}
